D12626: revlog: use %d to format int instead of %lu (issue6565)

2022-05-17 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The issue says gcc warns that the data types don't match. I couldn't reproduce the warning locally for some reason, but this patch shouldn't break things. Maybe

D12622: doc: use an absolute path in sys.path

2022-05-10 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The idea and rationale is similar to https://phab.mercurial-scm.org/D12599 (landed as 1b6e381521c5

D12621: check-py3-compat: use an absolute path in sys.path

2022-05-10 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The idea and rationale is similar to https://phab.mercurial-scm.org/D12599 (landed as 1b6e381521c5

D12620: tests: make sure .js files stay in ASCII encoding (issue6559)

2022-05-09 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12620 AFFECTED FILES tests/test-check-encoding.t CHANGE DETAILS diff --git

D12598: tests: make sure .js files stay in ASCII encoding (issue6559)

2022-05-02 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12598 AFFECTED FILES tests/test-check-encoding.t CHANGE DETAILS diff --git

D12597: followlines: don't put Unicode directly into the .js file (issue6559)

2022-05-02 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Apparently some web server setups may serve this file in a different encoding than UTF-8, and that results in visual garbage in the followlines button that

D12589: tests: fix misspelling of supersede

2022-04-27 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12589 AFFECTED FILES tests/test-push-checkheads-partial-C1.t

D12195: obsolete: don't use os.stat in repo.obsstore.__nonzero__ if it's static HTTP

2022-02-15 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If a repo is accessed via static HTTP, then we obviously can't use os.stat() to just peek at the file size. Let's download the entire file to check its size.

D12157: scmutil: obsrevs is already a frozenset

2022-02-09 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12157 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git

D12156: obsolete: always return frozensets from obsolete.getrevs()

2022-02-09 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY getrevs function already returns an empty frozenset when there is no obsstore, but let's make sure to return a frozenset in any case. This makes it possible to

D12138: branchmap: split a long condition in branchcache.validfor(), add comments

2022-02-07 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12138 AFFECTED FILES mercurial/branchmap.py CHANGE DETAILS diff --git

D12135: branchmap: don't add branch entries if there are no heads

2022-02-06 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We definitely don't want any empty entries to be present in repo.branchmap() just for the sake of not breaking test-notify.t. No test changes required because

D12134: notify: don't produce errors if a revision is not found

2022-02-06 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Notify extension has a way to only subscribe to a specific revset, such as "branch(foo)". Before this patch, when there was no branch with that name, it would

D12121: obsolete: don't import from .node twice

2022-01-31 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY See d55b71393907 . REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D12120: dagop: don't import nullrev from .node twice

2022-01-31 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY See 59fa3890d40a . REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D12097: branchmap: skip obsolete revisions while computing heads

2022-01-28 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It's time to make this part of core Mercurial obsolescence-aware. Not considering obsolete revisions when computing heads is clearly what Mercurial should do.

D12098: discovery: port _postprocessobsolete() changes from evolve, add tests

2022-01-28 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Let's make this function obsolescence-aware as well. Now we check that revisions are not obsolete first, and only then check that they are going to be common

D12100: obsolete: make sure windows tests pass when stat() is given a URL

2022-01-28 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is a band-aid for test-static-http.t breakage on windows. On windows this exception is not ENOENT, but EINVAL (because of `:` symbol, for example).

D12099: destutil: if wdp is obsolete, update to the closest non-obsolete ancestor

2022-01-28 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY As the original comments suggest, using prune as a model here was an existing idea, and now this patch implements it. I think it would be even better to do

D12092: interfaces: add missing caches kwarg of localrepo.updatecaches()

2022-01-27 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Added to localrepo: in 1337bfaa88ca , added to the interface: now. REPOSITORY rHG

D11223: obsolete: disable other evolution config options if createmarkers is off

2021-07-28 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We used to raise an abort in this case, but recent changes to local clone command (377d8fc20e34

D11221: rebase: use obsolete.isenabled() to check for experimental.allowdivergence

2021-07-28 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Now that obsolete.isenabled() can also check if divergence is allowed, let's use it for consistency. Other

D11222: fix: use obsolete.isenabled() to check for experimental.allowdivergence

2021-07-28 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Now that obsolete.isenabled() can also check if divergence is allowed, let's use it for consistency. Other experimental.evolution options are already checked via

D10948: exchange: use "served" repo filter to guess what the server will publish

2021-07-03 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Previously, the second push in the added test would say "push would publish 2 changesets" because _checkpublish() was considering secret changesets to be

D8619: tests: skip pyflakes for selectors2.py

2020-06-06 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The current version (2.2.0) correctly detects one issue: mercurial/thirdparty/selectors2.py:335:40 '...'.format(...) has unused arguments at position(s): 1

D8618: tests: adjust to the new format in pyflakes output

2020-06-06 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY According to the pyflakes' NEWS.rst, the default output format changed recently: 2.2.0 (2020-04-08) - Include column information in error messages

D8617: tests: consistently use pyflakes as a Python module

2020-06-06 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We check availability of pyflakes as a module, and also running it for real as a module. Only fair to test filterpyflakes.py working correctly when using pyflakes

D8394: revset: implement a simple 'foo#generations' expression

2020-04-10 Thread av6 (Anton Shestakov)
av6 created this revision. av6 added a reviewer: yuja. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The result of this expression is equivalent to 'foo#g[:]': all reachable ancestors and descendants of a revset foo. While not very

D8393: revset: rename generationsrel() to generationssubrel()

2020-04-10 Thread av6 (Anton Shestakov)
av6 created this revision. av6 added a reviewer: yuja. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This highlights that this is an implementation of 'x#y[z]' relation subscript operator as opposed to 'x#y' relation operator. REPOSITORY

D6709: config: add --registered flag to show all known configs

2019-09-17 Thread av6 (Anton Shestakov)
av6 added a comment. In D6709#100618 , @marmoute wrote: > In D6709#99199 , @av6 wrote: > >> I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is scripts

D6709: config: add --registered flag to show all known configs

2019-09-12 Thread av6 (Anton Shestakov)
av6 added a comment. I'll be okay with this too, once we get rid of `(EXPERIMENTAL)` everywhere. INLINE COMMENTS > test-config.t:962 > + > + $ hg showconfig --registered -T '{name}={value}\n' | egrep '^(color|diff)' > + color.mode=auto Let's change this to `hg showconfig cmdserver

D6762: packaging: add Bullseye, remove Jessie

2019-08-25 Thread av6 (Anton Shestakov)
Closed by commit rHG0a50a4232db7: packaging: add Bullseye, remove Jessie (authored by av6). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6762?vs=16308=16310 CHANGES SINCE LAST

D6761: packaging: add Cosmic and Disco, remove Trusty and Artful

2019-08-25 Thread av6 (Anton Shestakov)
Closed by commit rHG0363bb086c57: packaging: add Cosmic and Disco, remove Trusty and Artful (authored by av6). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6761?vs=16307=16309

D6761: packaging: add Cosmic and Disco, remove Trusty and Artful

2019-08-25 Thread av6 (Anton Shestakov)
av6 added a comment. Intended for stable. Confirming that building the packages for Cosmic and Disco actually works is very much welcome. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6761/new/ REVISION DETAIL

D6762: packaging: add Bullseye, remove Jessie

2019-08-25 Thread av6 (Anton Shestakov)
av6 added a comment. Intended for stable. Confirming that building the package for Bullseye actually works is very much welcome. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6762/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6762 To:

D6762: packaging: add Bullseye, remove Jessie

2019-08-25 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Jessie is oldoldstable now, and Bullseye is going to be the next stable (now testing). We're continuing to support the current oldstable, stable and testing

D6761: packaging: add Cosmic and Disco, remove Trusty and Artful

2019-08-25 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY - Trusty was publicly supported until 2019-04-30 - Artful was publicly supported until 2018-07-19 - Cosmic was publicly supported until 2019-07-18 - Disco will be

D6709: config: add --registered flag to show all known configs

2019-08-23 Thread av6 (Anton Shestakov)
This revision now requires changes to proceed. av6 added a comment. av6 requested changes to this revision. I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is scripts (as explained in issue6014) -- regular users lived without this feature for years

D6709: config: add --registered flag to show all known configs

2019-08-22 Thread av6 (Anton Shestakov)
av6 added a comment. av6 accepted this revision. @marmoute did you want this flag marked as experimental or am I misremembering? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709 To:

D6709: config: add --registered flag to show all known configs

2019-08-20 Thread av6 (Anton Shestakov)
av6 added inline comments. INLINE COMMENTS > commands.py:1893 > else: > -fm.write('name value', '%s=%s\n', entryname, value) > -fm.data(defaultvalue=defaultvalue) > +value_ = value > +for tfopt in [('True', 'yes'), ('False', 'no'), ('true',

D6730: config: handle default values of type list

2019-08-17 Thread av6 (Anton Shestakov)
This revision now requires changes to proceed. av6 added a comment. av6 requested changes to this revision. The changes in tests that this patch causes are actually already present in the D6709 , so let's fold this patch into it as well. REPOSITORY

D6709: config: add --registered flag to show all known configs

2019-08-17 Thread av6 (Anton Shestakov)
av6 added inline comments. INLINE COMMENTS > ui.py:832 > +# Omit config items with dynamicdefault, devel, > +# experimental and generic config opts. > +continue Nit: originally I was fine with two different `if ...: continue` blocks

D6707: revset: drop argument when it's None

2019-08-06 Thread av6 (Anton Shestakov)
Closed by commit rHG911e25dc9d8c: revset: drop argument when its None (authored by av6). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6707?vs=16107=16139 CHANGES SINCE LAST

D6706: stack: remove unnecessary reverse() predicate

2019-08-06 Thread av6 (Anton Shestakov)
Closed by commit rHG77c52ce50e6a: stack: remove unnecessary reverse() predicate (authored by av6). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6706?vs=16106=16138 CHANGES SINCE

D6709: config: add --all flag to show all known configs

2019-08-02 Thread av6 (Anton Shestakov)
This revision now requires changes to proceed. av6 added inline comments. av6 requested changes to this revision. INLINE COMMENTS > commands.py:1774 > @command('config|showconfig|debugconfig', > -[('u', 'untrusted', None, _('show untrusted configuration options')), > +[('a', 'all',

D6707: revset: drop argument when it's None

2019-08-02 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY getstack's definition is `getstack(repo, rev=None)`, so providing None explicitly is unnecessary. Moreover, when x is not None, it's definitely not a revision but a

D6706: stack: remove unnecessary reverse() predicate

2019-08-02 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Stack already sorts revisions, so no need to do it twice. This change was a part of D2400 , which didn't land for other

D6551: statecheck: added support for cmdutil.afterresolvedstates

2019-07-04 Thread av6 (Anton Shestakov)
av6 added inline comments. INLINE COMMENTS > cmdutil.py:3303 > > afterresolvedstates tuples define a .hg/{file} and the corresponding > command needed to finish it. Now that afterresolvedstates has been removed, you need to update this docstring. > cmdutil.py:3322 > > If

D6501: state: created new class statecheck to handle unfinishedstates

2019-06-18 Thread av6 (Anton Shestakov)
av6 added inline comments. INLINE COMMENTS > state.py:151 > +'graft', > +fname = 'graftstate', > +clearable = True, It's funny how Pulkit's comment is now at this line and looks like asking to add spaces around `=` here. But in this case `=` is not an operator, it's used to

D6476: merge: correct argument name in docstring

2019-06-04 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG127937874395: merge: correct argument name in docstring (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6476?vs=15332=15333

D6476: merge: correct argument name in docstring

2019-06-04 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6476 AFFECTED FILES mercurial/merge.py CHANGE DETAILS diff --git a/mercurial/merge.py

D6467: doc: fix description of "predecessors" to match reality

2019-06-01 Thread av6 (Anton Shestakov)
av6 added a comment. This change looks good, but I have doubts about "visible" in the docstring. https://phab.mercurial-scm.org/rHG1858fc2327ef7b631941e37550738f1fc4217bfb does say that this template keyword respects repo filtering, but I've encountered instances where it shows hidden

D6461: githelp: translate git stash show and clear actions and --patch flag

2019-05-30 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7752cd3a2f83: githelp: translate git stash show and clear actions and --patch flag (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6461: githelp: translate git stash show and clear actions and --patch flag

2019-05-30 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6461 AFFECTED FILES hgext/githelp.py tests/test-githelp.t CHANGE DETAILS diff --git

D6460: githelp: add --dry-run for mv

2019-05-30 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6460 AFFECTED FILES hgext/githelp.py CHANGE DETAILS diff --git a/hgext/githelp.py b/hgext/githelp.py ---

D6459: githelp: translate --directory of git apply to --prefix

2019-05-30 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY According to the help pages, these flags do the same. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6459 AFFECTED FILES

D6441: help: check if a subtopic exists and raise an error if it doesn't (issue6145)

2019-05-24 Thread av6 (Anton Shestakov)
av6 added inline comments. INLINE COMMENTS > help.py:689-695 > +exists = False > for names, header, doc in subtopics[name]: > if subtopic in names: > +exists = True > break > +if not exists: > +

D6442: help: include subtopic in error message if passed

2019-05-24 Thread av6 (Anton Shestakov)
av6 added inline comments. INLINE COMMENTS > help.py:826 > +if subtopic: > +hint += _(" or 'hg help --keyword %s'") % subtopic > raise error.Abort(msg, hint=hint) Concatenating things is not the best option when it comes to i18n, but even if

D6122: tests: add a file listing all the flaky tests

2019-03-21 Thread av6 (Anton Shestakov)
av6 added a comment. In https://phab.mercurial-scm.org/D6122#89818, @lothiraldan wrote: > @av6 is a `--no-flaky-tests` flag what you had in mind? Something like that, yes. I suggested that flag seeing how this change introduces a quite specific file with just one line. And I

D6123: ZeroDivisionError: Add condition to avoid Zerodivisonerror due to float number (issue6099)

2019-03-13 Thread av6 (Anton Shestakov)
av6 added a comment. Okay, let's go over #1 in https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist once more. If you want to know what a good "topic" is, look at what other people do. How patches that get accepted generally look. How bug-fixing commits are worded.

D6123: Experimental features: Add condition to for float number (issue6099)

2019-03-13 Thread av6 (Anton Shestakov)
av6 added inline comments. INLINE COMMENTS > similar.py:67 > +if lengths > 0: > return equal * 2.0 / lengths > This returns None in some cases, and code that uses `_score()` and `score()` tries to compare it to an integer. In Python3 `None > 1` raises TypeError. REPOSITORY rHG

D6123: Experimental features: Add condition to for float number (issue6099)

2019-03-13 Thread av6 (Anton Shestakov)
av6 added a comment. I find it troubling that we now have contributors that don't follow #1 in https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist. Potentially #4 too (as Pulkit commented). Seriously, the title is terrible at describing what this patch fixes and

D6122: tests: add a file listing all the flaky tests

2019-03-12 Thread av6 (Anton Shestakov)
av6 added a comment. Another way to do this could be to introduce another special keyword, similar to "slow", so that tests that are known flaky can `#require flaky` or even mark a specific block with `#if flaky`. Obviously fixing ​test-remotefilelog-bgprefetch.t is a better idea

D5779: copyright: update to 2019

2019-01-31 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8427fea04017: copyright: update to 2019 (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5779?vs=13640=13643 REVISION DETAIL

D5779: copyright: update to 2019

2019-01-30 Thread av6 (Anton Shestakov)
av6 added a comment. Intended for stable. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5779 To: av6, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D5779: copyright: update to 2019

2019-01-30 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5779 AFFECTED FILES contrib/packaging/debian/copyright contrib/win32/ReadMe.html

D5538: hgweb: add /obsgraph page that shows obsolescence history of a changeset (PoC)

2019-01-30 Thread av6 (Anton Shestakov)
av6 abandoned this revision. av6 added a comment. Okay then, I'll work on a non-PoC version of this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5538 To: av6, #hg-reviewers Cc: durin42, mjpieters, mercurial-devel

D5710: py3: add 7 new passing tests to whitelist found by buildbot

2019-01-26 Thread av6 (Anton Shestakov)
av6 added a comment. Is this patch a result of some flawed automated script? Because wow, unless my eyes fail me, these additions are all duplicates. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5710 To: pulkit, #hg-reviewers Cc: av6, mercurial-devel

D5538: hgweb: add /obsgraph page that shows obsolescence history of a changeset (PoC)

2019-01-09 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Feel free to ask questions, I suspect some chunks would need a comment (either in review or in code) to explain what's going on there. I'll start

D5537: obsutil: add a simplified obshistorywalker() (PoC)

2019-01-09 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This code is taken from evolve extension, namely from obslog command implementation, and somewhat simplified to be easier to review. No tests and no

D5474: obsutil: fix the issue5686

2018-12-22 Thread av6 (Anton Shestakov)
av6 added inline comments. INLINE COMMENTS > test-obsmarker-template.t:2511 >| @ 471597cad322 > - |/ Obsfate: pruned; > + |/ Obsfate: rewritten as 2:617adc3a144c by test (at 1970-01-01 00:00 > +); >o ea207398892e The new output looks somewhat more correct, but not

D5455: help: hide default value for default-off flags

2018-12-20 Thread av6 (Anton Shestakov)
av6 accepted this revision. av6 added a comment. This revision is now accepted and ready to land. These look good. One more thing I want to mention: hg help evolve looks like this: --phase-divergent solves only phase-divergent changesets --content-divergent solves only

D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off"

2018-12-15 Thread av6 (Anton Shestakov)
av6 added a comment. The point of https://phab.mercurial-scm.org/D5430 was to make hg help output more human friendly by replacing `True` and `False` with something less Python-related. In other words, more human-friendly. "Yes" and "no" are way more human-friendly: - they are one of

D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off"

2018-12-15 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5444 AFFECTED FILES mercurial/help.py tests/test-extension.t

D5064: style: run black on a subset of mercurial

2018-11-13 Thread av6 (Anton Shestakov)
av6 added a comment. I look at the changes and see nitpicks at best. On the one hand, black proved better than any linter that we can already write consistent code. On the other, if black were a linter... I'd switch to flake8, which at least is configurable

D4362: zsh_completion: complete merge tools for -t/--tool

2018-11-02 Thread av6 (Anton Shestakov)
av6 added projects: hg, hg-reviewers. av6 added a comment. Changing project tags, please ignore. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4362 To: av6, #hg-reviewers, spectral Cc: spectral, mercurial-devel, namenlos, dsp, pulkit, durham, akushner

D5142: zsh_completion: add -l/--list flag for hg bookmarks completion

2018-10-17 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd365e2b7aa2a: zsh_completion: add -l/--list flag for hg bookmarks completion (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5141: zsh_completion: fix a couple of flags still not being perfect

2018-10-17 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG01bdf7294274: zsh_completion: fix a couple of flags still not being perfect (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5140: zsh_completion: use $_hg_remote_opts after it is defined

2018-10-17 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4c9418e3a7d3: zsh_completion: use $_hg_remote_opts after it is defined (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5142: zsh_completion: add -l/--list flag for hg bookmarks completion

2018-10-17 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flags in parentheses are mutually exclusive. Logic is taken from commands.py: selactions = [k for k in ['delete', 'rename', 'list'] if opts.get(k)] if

D5141: zsh_completion: fix a couple of flags still not being perfect

2018-10-17 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5141 AFFECTED FILES contrib/zsh_completion CHANGE DETAILS diff --git a/contrib/zsh_completion

D5140: zsh_completion: use $_hg_remote_opts after it is defined

2018-10-17 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, zsh wouldn't complete --ssh, --remotecmd or --insecure for hg clone. While at it, replace --uncompressed by --stream. REPOSITORY rHG

D4680: bundle2: make server.bundle2.stream default to True

2018-09-20 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4bd6e444c76f: bundle2: make server.bundle2.stream default to True (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4679: bundle2: graduate bundle2.stream option from experimental to server section

2018-09-20 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1b5880352314: bundle2: graduate bundle2.stream option from experimental to server section (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4678: tests: split capabilities into separate lines while searching for "narrow"

2018-09-20 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7d9b1b50cad5: tests: split capabilities into separate lines while searching for narrow (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4680: bundle2: make server.bundle2.stream default to True

2018-09-20 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Support for bundle2 streaming clones has been shipped in Mercurial 4.5 (https://phab.mercurial-scm.org/rHG7eedbd5d4880f6c0518e5ff706450a7389acb70d), but was never

D4679: bundle2: graduate bundle2.stream option from experimental to server section

2018-09-20 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4679 AFFECTED FILES mercurial/bundle2.py mercurial/configitems.py mercurial/help/config.txt

D4678: tests: split capabilities into separate lines while searching for "narrow"

2018-09-20 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This test is interested only in capabilities that are related to narrow, so let's omit everything else. Makes it easier to update

D4665: meld: enable auto-merge

2018-09-20 Thread av6 (Anton Shestakov)
av6 added a comment. Although I must say that EPEL 6 (it's for RHEL/CentOS 6) still has meld 1.3.1, which may be too old for this option: https://repology.org/metapackage/meld/versions REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4665 To: martinvonz,

D4612: zsh_completion: add -b/--branch and -B/--bookmark(s) flags properly

2018-09-18 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3f11cb1aeb90: zsh_completion: add -b/--branch and -B/--bookmark(s) flags properly (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4612: zsh_completion: add -b/--branch and -B/--bookmark(s) flags properly

2018-09-17 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY _hg_branch_bmark_opts used to add these two flags, but had the same descriptions for the flags regardless of what command took them and didn't allow specifying

D4519: zsh_completion: add new and remove deprecated flags

2018-09-12 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa2d17b699628: zsh_completion: add new and remove deprecated flags (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4518: zsh_completion: update various arguments, descriptions, metavariables

2018-09-12 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5f06c21d37de: zsh_completion: update various arguments, descriptions, metavariables (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4519: zsh_completion: add new and remove deprecated flags

2018-09-10 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4519 AFFECTED FILES contrib/zsh_completion CHANGE DETAILS diff --git a/contrib/zsh_completion

D4518: zsh_completion: update various arguments, descriptions, metavariables

2018-09-10 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Addition of "=" means the flag must have an argument after it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4518 AFFECTED FILES

D4428: zsh_completion: complete shelve and unshelve

2018-09-05 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG45d12c49c3f3: zsh_completion: complete shelve and unshelve (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4428?vs=10717=10781

D4426: zsh_completion: use revsets to exclude this rev from suggestions to hg merge

2018-09-05 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2815e0db4c54: zsh_completion: use revsets to exclude this rev from suggestions to hg merge (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4426: zsh_completion: use revsets to exclude this rev from suggestions to hg merge

2018-09-03 Thread av6 (Anton Shestakov)
av6 added a comment. Now it's only one call to hg. All possible branches included, even if hg merge that-branch would complain (see my comment above), because in completions it's better to give extra suggestions than to miss some. But this "revision numbers + branch names" got me

D4428: zsh_completion: complete shelve and unshelve

2018-09-03 Thread av6 (Anton Shestakov)
av6 added a comment. Ah, and now the comments are grayed out. I shouldn't have re-phabsend-ed this, since there are no changes from the previous version. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4428 To: av6, #hg-reviewers Cc: spectral, mercurial-devel

D4428: zsh_completion: complete shelve and unshelve

2018-09-03 Thread av6 (Anton Shestakov)
av6 updated this revision to Diff 10717. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4428?vs=10684=10717 REVISION DETAIL https://phab.mercurial-scm.org/D4428 AFFECTED FILES contrib/zsh_completion CHANGE DETAILS diff --git

  1   2   >