D1393: bundle2: inline struct operations

indygreg added a comment. FWIW, when I last looked at adding stream clones to bundle2, I held off because of the performance overhead. With the performance work in this series, I suspect bundle2's I/O is fast enough to support stream clones with minimal performance degradation. I may have a

D1394: bundle2: avoid unbound read when seeking

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently, seekableunbundlepart.seek() will perform a read() during seek operations. This will allocate a buffer to hold the raw data over the seek distance.

D1393: bundle2: inline struct operations

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before, we were calling struct.unpack() (via an alias) on every loop iteration. I'm not sure what Python does under the hood, but it would have to look at the

D1391: bundle2: inline debug logging

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Profiling revealed that repeated calls to indebug() were consuming a fair amount of CPU during bundle2 reading, with most of the time spent in ui.configbool().

D1392: bundle2: inline changegroup.readexactly()

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Profiling reveals this loop is pretty tight. Literally any function call elimination can make a big difference. This commit inlines the relatively trivial

D1390: bundle2: don't use seekable bundle2 parts by default (issue5691)

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The last commit removed the last use of the bundle2 part seek() API in the generic bundle2 part iteration code. This means we can now switch to using

D1389: bundle2: only seek to beginning of part in bundlerepo

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For reasons still not yet fully understood by me, bundlerepo requires its changegroup bundle2 part to be seeked to beginning after part iteration. As far as I

D1388: bundle2: implement consume() API on unbundlepart

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We want bundle parts to not be seekable by default. That means eliminating the generic seek() method. A common pattern in bundle2.py is to seek to the end

D1387: bundle2: implement generic part payload decoder

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous commit extracted _payloadchunks() to a new derived class. There was still a reference to this method in unbundlepart, making unbundlepart unusable

D1386: bundle2: extract logic for seeking bundle2 part into own class

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently, unbundlepart classes support bi-directional seeking. Most consumers of unbundlepart only ever seek forward - typically as part of moving to the end

D1385: perf: add command to benchmark bundle reading

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Upcoming commits will be refactoring bundle2 I/O code. This commit establishes a `hg perfbundleread` command that measures how long it takes to read a

D1383: bundlerepo: rename "bundle" arguments to "cgunpacker"

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY "bundle" was appropriate for the bundle1 days where a bundle was a changegroup. In a bundle2 world, changegroup readers are referred to as "changegroup

D1384: bundlerepo: rename "bundlefilespos" variable and attribute

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Strictly speaking, this variable tracks offsets within the changegroup, not the bundle. While we're here, mark a class attribute as private because it is.

D1382: bundlerepo: use early return

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I like avoiding patterns that lead to the pyramid of doom. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1382 AFFECTED FILES

Re: Upstreaming Facebook extensions

On Mon, 13 Nov 2017 22:12:31 -0500, Jun Wu wrote: Excerpts from Matt Harbison's message of 2017-11-13 21:50:29 -0500: For LFS, it has been used in a repo synced from p4 for about half a year. It's mostly good except for lack of features (ex. support the Git-LFS SSH

Re: Upstreaming Facebook extensions

Excerpts from Matt Harbison's message of 2017-11-13 21:50:29 -0500: > I see some things are being upstreamed out of the hg-experimental repo on > Bitbucket, but I haven't seen mention of how these are being selected. > I'm interested in the absorb and lfs extensions. The former works great

Upstreaming Facebook extensions

I see some things are being upstreamed out of the hg-experimental repo on Bitbucket, but I haven't seen mention of how these are being selected. I'm interested in the absorb and lfs extensions. The former works great on Linux in my limited use, but the linelog module dependency doesn't

D1381: crecord: fix revert -r '.^' crash caused by 3649c3f2cd

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY https://phab.mercurial-scm.org/rHG3649c3f2cd90c8aec395ca8af5adae33defff12c (revert: do not reverse hunks in interactive when REV is not parent (issue5096)) changed

Re: Desired use case for obsmarkers / visibility

Excerpts from Augie Fackler's message of 2017-11-10 17:58:34 -0500: > Here's a proposal I ran by Martin probably a year ago, and that he > didn't immediately hate: > > Prunes are different from regular obsolete markers. By default, you > don't push prunes, and pulled prunes are not applied, but

D1336: remove: print message for each file in verbose mode only while using `-A`

mharbison72 added a comment. If this can't be taken as-is, what about something in tweakdefaults to hide this by default? I just assumed that --quiet already worked, and the problem was that this throws away the other more useful warnings in the non --after case. (Or people don't remember

Re: linkrev corruption (was Re: Corrupted repo? Full of unexpected changesets)

Excerpts from Martin von Zweigbergk's message of 2017-10-29 22:46:25 +: > I think Jun (on CC) once wrote some extension that would cache linkrevs. I > think it could be configured not to care about the linkrevs in the revlog > at all. If that's correct, it seems like one could run a server

D1354: dirstate: change all writes to dirstatemap._map to go through one method

durin42 added a comment. In https://phab.mercurial-scm.org/D1354#22991, @mbolin wrote: > @durin42 The issue is that `dirstatemap` is doing so much "stuff" beyond just storage that Eden prefers to subclass it rather than copy/paste all of the business logic. That's an argument

D1354: dirstate: change all writes to dirstatemap._map to go through one method

mbolin added a comment. @durin42 The issue is that `dirstatemap` is doing so much "stuff" beyond just storage that Eden prefers to subclass it rather than copy/paste all of the business logic. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1354 To: mbolin,

Re: [PATCH 02 of 15 V2] bookmark: add methods to binary encode and decode bookmark values

> On Nov 13, 2017, at 05:16, Boris Feld wrote: > > On Fri, 2017-11-10 at 17:35 -0500, Augie Fackler wrote: >> (+indygreg, who also is a formats enthusiast) >> >> On Thu, Nov 02, 2017 at 02:17:59PM +0100, Boris Feld wrote: >>> # HG changeset patch >>> # User Boris Feld

D1377: bundlerepo: make bundle and bundlefile attributes private

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdf2a676a2e9e: bundlerepo: make bundle and bundlefile attributes private (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1376: bundlerepo: don't assume there are only two bundle classes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4f04c9207a76: bundlerepo: dont assume there are only two bundle classes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1379: bundlerepo: rename _bundle to _cgunpacker

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3f393e4593f2: bundlerepo: rename _bundle to _cgunpacker (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1379?vs=3434=3455

D1378: bundlerepo: assign bundle attributes in bundle type blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rHG495fcff10124: bundlerepo: assign bundle attributes in bundle type blocks (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1374: bundlerepo: rename arguments to bundlerepository.__init__

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4696938d40f9: bundlerepo: rename arguments to bundlerepository.__init__ (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1375: bundlerepo: add docstring for bundlerepository class

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd2458ba810c5: bundlerepo: add docstring for bundlerepository class (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1373: bundlerepo: use suffix variable

This revision was automatically updated to reflect the committed changes. Closed by commit rHG80e9b85d96e5: bundlerepo: use suffix variable (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1373?vs=3428=3450 REVISION

D1372: bundlerepo: make methods agree with base class

This revision was automatically updated to reflect the committed changes. Closed by commit rHG32d079f37207: bundlerepo: make methods agree with base class (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 12 of 15 V2] bundle2: support a 'records' mode for the 'bookmarks' part

> On Nov 13, 2017, at 05:24, Boris Feld wrote: > > On Fri, 2017-11-10 at 17:43 -0500, Augie Fackler wrote: >> On Thu, Nov 02, 2017 at 02:18:09PM +0100, Boris Feld wrote: >>> # HG changeset patch >>> # User Boris Feld >>> # Date 1508246776 -7200

Re: [PATCH 4 of 4 STABLE] dispatch: abort if early boolean options can't be parsed

On Sun, Nov 12, 2017 at 12:02:49AM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1510376561 -32400 > # Sat Nov 11 14:02:41 2017 +0900 > # Branch stable > # Node ID a8d8c3229692d77881a6242329160803cb5ab8c5 > # Parent

Re: [PATCH 5 of 4 STABLE] dispatch: fix early parsing of short option with value like -R=foo

On Tue, Nov 14, 2017 at 12:43:46AM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1510586759 -32400 > # Tue Nov 14 00:25:59 2017 +0900 > # Branch stable > # Node ID 6bccada86df7f70c24f2e62bedf9bfb5d796cbd1 > # Parent

Re: [PATCH 6 of 6 V2] test-pattern: actually update tests using the patterns

On Mon, Nov 13, 2017 at 12:11:20PM +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1509866592 -3600 > # Sun Nov 05 08:23:12 2017 +0100 > # Node ID 715948f2256fa181c4f3730825492f9da0f74b2e > # Parent

Re: [PATCH 4 of 4] rebase: exclude obsoletes without a successor in destination (issue5300)

On Sun, Nov 12, 2017 at 06:06:37PM +0100, Denis Laxalde wrote: > # HG changeset patch > # User Denis Laxalde > # Date 1510489041 -3600 > # Sun Nov 12 13:17:21 2017 +0100 > # Node ID 25d1891bd300bc527cb7e878532c8512ff5489de > # Parent

D1371: global: remove redundant parenthesis

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY My code editor was spewing several warnings for redundant parenthesis. It supports easily fixing them. So I just did it globally. What redundant

D1224: merge: cache unknown dir checks (issue5716)

durin42 requested changes to this revision. durin42 added a comment. This revision now requires changes to proceed. needs rebased, otherwise looks fine REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1224 To: mbthomas, #hg-reviewers, durin42 Cc: durin42, sid0,

D1346: fsmonitor: only access inner dirstate map if it is available

durin42 requested changes to this revision. durin42 added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > __init__.py:279 > +# directly access the inner dirstate map if the standard dirstate > +# implementation is in use. > +dmap =

D1345: dirstate: add explicit methods for querying directories

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Looks good. For bonus points do one more upload with the right `.. api::` annotation for the releasenotes extension. REPOSITORY rHG Mercurial REVISION DETAIL

D1343: dirstate: move dropping of folded filenames into the dirstate map

durin42 added a comment. btw I'm dubious of the 'filefoldmap' in self.__dict__ checks, as that very much looks like it should be an invariant now REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1343 To: mbthomas, #hg-reviewers, durin42 Cc: mercurial-devel

D1380: dirstate: document dirstatemap interface

durin42 requested changes to this revision. durin42 added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > dirstate.py:1198 > class dirstatemap(object): > +''' > +Dirstate contents Nit: let's try and prefer """ to ''' Try and get a pithy one-line

D1347: dirstate: make map implementation overridable

durin42 added subscribers: mbolin, durin42. durin42 accepted this revision as: durin42. durin42 added a comment. I'd prefer this as a class attr, but would like to hear from @mbolin as to whether or not that solves the problem(s) that inspired https://phab.mercurial-scm.org/D1354. INLINE

D971: uncommit: unify functions _uncommitdirstate and _unamenddirstate to one

durin42 added subscribers: hooper, martinvonz, durin42. durin42 accepted this revision as: durin42. durin42 added a comment. (Marking accepted, but consider just moving this to `scmutil` or `rewriteutil` (I made that second one up, but it might be a sensible thing to have?) in parallel with

D821: unamend: move fb extension unamend to core

durin42 added inline comments. INLINE COMMENTS > uncommit.py:247 > +def unamend(ui, repo, **opts): > +"""undo the amend operation on a current changeset > + undo the _most recent_ amend? or can I run this iteratively and undo many amends in sequence? > uncommit.py:265 > +markers =

D1336: remove: print message for each file in verbose mode only while using `-A`

durin42 added a comment. I think this probably violates our BC policy. We could probably stand to add a `--quiet` for suppressing this output, I suppose. I'll leave this open for other reviewers to mull over, and if it's still open in a week without comment I'll probably pass final

D1372: bundlerepo: make methods agree with base class

durin42 added a comment. In https://phab.mercurial-scm.org/D1372#22818, @lothiraldan wrote: > In https://phab.mercurial-scm.org/D1372#22814, @dlax wrote: > > > > For methods that are implemented, we change arguments to match the base. > > > > Alternatively, we could use `**kwargs`

[Bug 5740] New: No obvious way to disable graph output added from alias

https://bz.mercurial-scm.org/show_bug.cgi?id=5740 Bug ID: 5740 Summary: No obvious way to disable graph output added from alias Product: Mercurial Version: default branch Hardware: PC OS: Windows

Re: D1358: remotenames: store journal entry for bookmarks if journal is loaded

pulkit (Pulkit Goyal) writes: > pulkit created this revision. > Herald added a subscriber: mercurial-devel. > Herald added a reviewer: hg-reviewers. > > REPOSITORY > rHG Mercurial > > REVISION DETAIL > https://phab.mercurial-scm.org/D1358 > > AFFECTED FILES >

D939: remotenames: add functionality to store remotenames under .hg/hgremotenames/

pulkit added a subscriber: durin42. pulkit added inline comments. INLINE COMMENTS > test-remotenames.t:69 > + ec2426147f0e39dbc9cef599b066be6035ce691d file:$TESTTMP/server default > + 3e1487808078543b0af6d10dadf5d46943578db0 file:$TESTTMP/server wat @durin42 related to your comment on

D1378: bundlerepo: assign bundle attributes in bundle type blocks

indygreg added inline comments. INLINE COMMENTS > dlax wrote in bundlerepo.py:298 > Within `_handlebundle2part`, there's still a `self._bundle = > changegroup.getunbundler(...)` statement. Perhaps, it'd be even clearer if > this method would `return changegroup.getunbundler(...)` and let the

Re: Desired use case for obsmarkers / visibility

On Fri, Nov 3, 2017 at 12:34 PM, Boris Feld wrote: > On Thu, 2017-11-02 at 10:06 -0700, Gregory Szorc wrote: > > I have a potential use case for obsmarkers / visibility that I want > > to run by people to see if it can be supported. > > > > Changesets are pushed to the

Re: Desired use case for obsmarkers / visibility

On Mon, Nov 13, 2017 at 8:33 AM, Boris Feld wrote: > On Fri, 2017-11-03 at 20:34 +0100, Boris Feld wrote: > > On Thu, 2017-11-02 at 10:06 -0700, Gregory Szorc wrote: > > > I have a potential use case for obsmarkers / visibility that I want > > > to run by people to see if

D1371: global: remove redundant parenthesis

indygreg added a comment. I used my editor's feature to fix violations. That's probably what introduced the whitespace changes. If only Mercurial conformed to PEP-8 style... REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1371 To: indygreg, #hg-reviewers, yuja

Re: Desired use case for obsmarkers / visibility

On Fri, 2017-11-03 at 20:34 +0100, Boris Feld wrote: > On Thu, 2017-11-02 at 10:06 -0700, Gregory Szorc wrote: > > I have a potential use case for obsmarkers / visibility that I want > > to run by people to see if it can be supported. > > > > Changesets are pushed to the Firefox repo via a

[PATCH 5 of 4 STABLE] dispatch: fix early parsing of short option with value like -R=foo

# HG changeset patch # User Yuya Nishihara # Date 1510586759 -32400 # Tue Nov 14 00:25:59 2017 +0900 # Branch stable # Node ID 6bccada86df7f70c24f2e62bedf9bfb5d796cbd1 # Parent a8d8c3229692d77881a6242329160803cb5ab8c5 dispatch: fix early parsing of short option with value

D1336: remove: print message for each file in verbose mode only while using `-A`

lothiraldan accepted this revision. lothiraldan added a comment. In https://phab.mercurial-scm.org/D1336#22841, @pavanpc wrote: > @lothiraldan I modified a test case for hg rm -A case where we get the message 'not removing : file still exists' . For other cases, test cases already

D1370: bundle2: use os.SEEK_* constants

This revision was automatically updated to reflect the committed changes. Closed by commit rHG241d9caca11e: bundle2: use os.SEEK_* constants (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1370?vs=3425=3446 REVISION

D974: py3: handle keyword arguments correctly in hgext/patchbomb.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG71e63fe6b1ab: py3: handle keyword arguments correctly in hgext/patchbomb.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1270: help: adding a topic on flags

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb0262b25ab48: help: adding a topic on flags (authored by rdamazio, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D1270?vs=3359=3445#toc REPOSITORY rHG Mercurial CHANGES

D1348: histedit: add support to output nodechanges using formatter

yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > histedit.py:1208 > +fd = fm.formatdict > +nodechanges = fd({hf(oldn): fl([hf(n) for n in newn], 'succ') > + for oldn, newn in

D1270: help: adding a topic on flags

yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Removed -f=foo and queued, thanks. > it makes permanent my --no- boolean prefix for flags, Perhaps we can add some note saying --no- is still experimental? INLINE COMMENTS >

D1371: global: remove redundant parenthesis

yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > revsetlang.py:298 > # x + y + z -> (or x y z) -> (or (list x y z)) > -return (op, _fixops(('list',) + x[1:])) > elif op == 'subscript' and

D974: py3: handle keyword arguments correctly in hgext/patchbomb.py

yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Queued this, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D974 To: pulkit, #hg-reviewers, yuja Cc: yuja, mercurial-devel

Re: [POLL] Mass renaming options for consistency + guidelines

On Sun, 12 Nov 2017 12:26:18 -0500, Augie Fackler wrote: > > On Nov 12, 2017, at 4:42 AM, Yuya Nishihara wrote: > > On Sat, 14 Oct 2017 14:02:03 +0900, Yuya Nishihara wrote: > >> On Sat, 14 Oct 2017 00:41:04 -0400, Augie Fackler wrote: > >>> > >>> durin42: +1 > >>> martinvonz: +1

D1345: dirstate: add explicit methods for querying directories

mbthomas updated this revision to Diff 3442. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1345?vs=3345=3442 REVISION DETAIL https://phab.mercurial-scm.org/D1345 AFFECTED FILES contrib/perf.py hgext/largefiles/reposetup.py mercurial/dirstate.py

D1347: dirstate: make map implementation overridable

mbthomas updated this revision to Diff 3443. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1347?vs=3347=3443 REVISION DETAIL https://phab.mercurial-scm.org/D1347 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git

D1343: dirstate: move dropping of folded filenames into the dirstate map

mbthomas updated this revision to Diff 3440. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1343?vs=3343=3440 REVISION DETAIL https://phab.mercurial-scm.org/D1343 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git

D1341: dirstate: move management of nonnormal sets into dirstate map

mbthomas updated this revision to Diff 3438. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1341?vs=3341=3438 REVISION DETAIL https://phab.mercurial-scm.org/D1341 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git

D1342: dirstate: move management of the dirstate dirs into the dirstatemap

mbthomas updated this revision to Diff 3439. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1342?vs=3342=3439 REVISION DETAIL https://phab.mercurial-scm.org/D1342 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git

D1344: dirstate: remove _droppath method

mbthomas updated this revision to Diff 3441. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1344?vs=3344=3441 REVISION DETAIL https://phab.mercurial-scm.org/D1344 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git

D1380: dirstate: document dirstatemap interface

mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1380 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git a/mercurial/dirstate.py

D1340: dirstate: add explicit methods for modifying dirstate

mbthomas updated this revision to Diff 3437. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1340?vs=3340=3437 REVISION DETAIL https://phab.mercurial-scm.org/D1340 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git

D1358: remotenames: store journal entry for bookmarks if journal is loaded

pulkit added a comment. In https://phab.mercurial-scm.org/D1358#22836, @dlax wrote: > The state of this stack is not quite clear: there are abandoned revisions and the first changeset (introducing "mercurial/remotenames.py" file) seems to be missing. Ah, I will resend the series

[PATCH 3 of 6 V2] test-pattern: register current the bundlecaps string

# HG changeset patch # User Boris Feld # Date 1509860620 -3600 # Sun Nov 05 06:43:40 2017 +0100 # Node ID 16289f5358a17c0ee629dfa6910b00bb8dec7fe9 # Parent 15aa75b64e1dff38fcce4a8f283daf0ce37a1261 # EXP-Topic better-substitute # Available At

[PATCH 4 of 6 V2] test-pattern: register the current the bundle2 capabilities string

# HG changeset patch # User Boris Feld # Date 1510545585 -3600 # Mon Nov 13 04:59:45 2017 +0100 # Node ID 8f0e6aaf04b6bdd6535b6bc03008538c95085105 # Parent 16289f5358a17c0ee629dfa6910b00bb8dec7fe9 # EXP-Topic better-substitute # Available At

[PATCH 2 of 6 V2] test-pattern: substitute common compression list

# HG changeset patch # User Boris Feld # Date 1509860498 -3600 # Sun Nov 05 06:41:38 2017 +0100 # Node ID 15aa75b64e1dff38fcce4a8f283daf0ce37a1261 # Parent a7d1303d69b73deac107d78ed37506f662ec661b # EXP-Topic better-substitute # Available At

[PATCH 1 of 6 V2] run-tests: allow to register any arbitrary pattern for replacement

# HG changeset patch # User Boris Feld # Date 1509860067 -3600 # Sun Nov 05 06:34:27 2017 +0100 # Node ID a7d1303d69b73deac107d78ed37506f662ec661b # Parent 5d4369079c861d8fb01ab4505bf7d5911cf7a6e1 # EXP-Topic better-substitute # Available At

[PATCH 5 of 6 V2] test-pattern: substitute the HTTP log timestamp too

# HG changeset patch # User Boris Feld # Date 1509866633 -3600 # Sun Nov 05 08:23:53 2017 +0100 # Node ID c06ed80fc1063905dc6a711fc32c88d5913b0db6 # Parent 8f0e6aaf04b6bdd6535b6bc03008538c95085105 # EXP-Topic better-substitute # Available At

[PATCH 6 of 6 V2] test-pattern: actually update tests using the patterns

# HG changeset patch # User Boris Feld # Date 1509866592 -3600 # Sun Nov 05 08:23:12 2017 +0100 # Node ID 715948f2256fa181c4f3730825492f9da0f74b2e # Parent c06ed80fc1063905dc6a711fc32c88d5913b0db6 # EXP-Topic better-substitute # Available At

Re: [PATCH 11 of 11] test-pattern: actually update tests using the patterns

Sorry I included some obsolete changesets by mistake, I will resend a new series. On Mon, 2017-11-13 at 12:05 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1509866592 -3600 > #  Sun Nov 05 08:23:12 2017 +0100 > # Node ID

[PATCH 09 of 11] test-pattern: register the current the bundle2 capabilities string

# HG changeset patch # User Boris Feld # Date 1510545585 -3600 # Mon Nov 13 04:59:45 2017 +0100 # Node ID 8f0e6aaf04b6bdd6535b6bc03008538c95085105 # Parent 16289f5358a17c0ee629dfa6910b00bb8dec7fe9 # EXP-Topic better-substitute # Available At

[PATCH 04 of 11] test-pattern: register the current the bundle2 capabilities string

# HG changeset patch # User Boris Feld # Date 1510545585 -3600 # Mon Nov 13 04:59:45 2017 +0100 # Node ID 5714516a59c40bd83187bdb2a1615710a6cf # Parent 6e8aa2adeceaa523f214b79970df6471d728faf9 # EXP-Topic better-substitute # Available At

[PATCH 05 of 11] test-pattern: substitute the HTTP log timestamp too

# HG changeset patch # User Boris Feld # Date 1509866633 -3600 # Sun Nov 05 08:23:53 2017 +0100 # Node ID bacfe13eb9b21a13c8144ae4d2337415ea93f2e3 # Parent 5714516a59c40bd83187bdb2a1615710a6cf # EXP-Topic better-substitute # Available At

[PATCH 06 of 11] run-tests: allow to register any arbitrary pattern for replacement

# HG changeset patch # User Boris Feld # Date 1509860067 -3600 # Sun Nov 05 06:34:27 2017 +0100 # Node ID a7d1303d69b73deac107d78ed37506f662ec661b # Parent 5d4369079c861d8fb01ab4505bf7d5911cf7a6e1 # EXP-Topic better-substitute # Available At

[PATCH 01 of 11] run-tests: allow to register any arbitrary pattern for replacement

# HG changeset patch # User Boris Feld # Date 1509860067 -3600 # Sun Nov 05 06:34:27 2017 +0100 # Node ID fda6ff97ddead2610694668042f58f892130d982 # Parent 5d4369079c861d8fb01ab4505bf7d5911cf7a6e1 # EXP-Topic better-substitute # Available At

[PATCH 08 of 11] test-pattern: register current the bundlecaps string

# HG changeset patch # User Boris Feld # Date 1509860620 -3600 # Sun Nov 05 06:43:40 2017 +0100 # Node ID 16289f5358a17c0ee629dfa6910b00bb8dec7fe9 # Parent 15aa75b64e1dff38fcce4a8f283daf0ce37a1261 # EXP-Topic better-substitute # Available At

[PATCH 07 of 11] test-pattern: substitute common compression list

# HG changeset patch # User Boris Feld # Date 1509860498 -3600 # Sun Nov 05 06:41:38 2017 +0100 # Node ID 15aa75b64e1dff38fcce4a8f283daf0ce37a1261 # Parent a7d1303d69b73deac107d78ed37506f662ec661b # EXP-Topic better-substitute # Available At

[PATCH 11 of 11] test-pattern: actually update tests using the patterns

# HG changeset patch # User Boris Feld # Date 1509866592 -3600 # Sun Nov 05 08:23:12 2017 +0100 # Node ID 715948f2256fa181c4f3730825492f9da0f74b2e # Parent c06ed80fc1063905dc6a711fc32c88d5913b0db6 # EXP-Topic better-substitute # Available At

[PATCH 02 of 11] test-pattern: substitute common compression list

# HG changeset patch # User Boris Feld # Date 1509860498 -3600 # Sun Nov 05 06:41:38 2017 +0100 # Node ID aaaceee35dc84c5a5a7f3287d2605dd9d5f27688 # Parent fda6ff97ddead2610694668042f58f892130d982 # EXP-Topic better-substitute # Available At

[PATCH 03 of 11] test-pattern: register current the bundlecaps string

# HG changeset patch # User Boris Feld # Date 1509860620 -3600 # Sun Nov 05 06:43:40 2017 +0100 # Node ID 6e8aa2adeceaa523f214b79970df6471d728faf9 # Parent aaaceee35dc84c5a5a7f3287d2605dd9d5f27688 # EXP-Topic better-substitute # Available At

[PATCH 10 of 11] test-pattern: substitute the HTTP log timestamp too

# HG changeset patch # User Boris Feld # Date 1509866633 -3600 # Sun Nov 05 08:23:53 2017 +0100 # Node ID c06ed80fc1063905dc6a711fc32c88d5913b0db6 # Parent 8f0e6aaf04b6bdd6535b6bc03008538c95085105 # EXP-Topic better-substitute # Available At

D1336: remove: print message for each file in verbose mode only while using `-A`

pavanpc added a comment. @lothiraldan I modified a test case for hg rm -A case where we get the message 'not removing : file still exists' . For other cases, test cases already exist with 'hg rm -A' and 'hg rm --after' without verbose mode. INLINE COMMENTS > mharbison72 wrote in

D1336: remove: print message for each file in verbose mode only while using `-A`

pavanpc updated this revision to Diff 3435. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1336?vs=3424=3435 REVISION DETAIL https://phab.mercurial-scm.org/D1336 AFFECTED FILES mercurial/cmdutil.py tests/test-remove.t CHANGE DETAILS diff --git

Re: [PATCH 12 of 15 V2] bundle2: support a 'records' mode for the 'bookmarks' part

On Fri, 2017-11-10 at 17:43 -0500, Augie Fackler wrote: > On Thu, Nov 02, 2017 at 02:18:09PM +0100, Boris Feld wrote: > > # HG changeset patch > > # User Boris Feld > > # Date 1508246776 -7200 > > #  Tue Oct 17 15:26:16 2017 +0200 > > # Node ID

Re: [PATCH 02 of 15 V2] bookmark: add methods to binary encode and decode bookmark values

On Fri, 2017-11-10 at 17:35 -0500, Augie Fackler wrote: > (+indygreg, who also is a formats enthusiast) > > On Thu, Nov 02, 2017 at 02:17:59PM +0100, Boris Feld wrote: > > # HG changeset patch > > # User Boris Feld > > # Date 1508072395 -7200 > > #  Sun Oct 15

D1358: remotenames: store journal entry for bookmarks if journal is loaded

dlax added a comment. The state of this stack is not quite clear: there are abandoned revisions and the first changeset (introducing "mercurial/remotenames.py" file) seems to be missing. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1358 To: pulkit,

D1371: global: remove redundant parenthesis

dlax added a comment. LGTM modulo a few nits. Nice cleanup. INLINE COMMENTS > hgk.py:79 > ('S', 'search', "", _('search'))], > -('[OPTION]... NODE1 NODE2 [FILE]...'), > + '[OPTION]... NODE1 NODE2 [FILE]...', > inferrepo=True) Why this extra indentation? > hgk.py:337 >

D1378: bundlerepo: assign bundle attributes in bundle type blocks

dlax added inline comments. INLINE COMMENTS > bundlerepo.py:298 > > -self._handlebundle2part(part) > +self._handlebundle2part(bundle, part) > Within `_handlebundle2part`, there's still a `self._bundle = changegroup.getunbundler(...)` statement. Perhaps, it'd

  1   2   >