D2091: wireprotoserver: extract SSH response handling functions

indygreg marked an inline comment as done. indygreg added inline comments. INLINE COMMENTS > yuja wrote in wireprotoserver.py:424 > `rsp.res` here looks like an integer. This was fixed by https://phab.mercurial-scm.org/rHGb67d4b7e8235a1c5d16a2885801d21bf670d3b03. REPOSITORY rHG Mercurial

D2096: infinitepush: move the extension to core from fb-hgext

indygreg added a comment. I'll try to look at this tomorrow. (I was on a mini vacation last week and didn't spend much time looking at a computer.) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2096 To: pulkit, #hg-reviewers Cc: indygreg, mercurial-devel

Re: [PATCH 1 of 2 RFC] lfs: add support for serving blob files

On Sat, Feb 17, 2018 at 11:15 PM, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1518937155 18000 > # Sun Feb 18 01:59:15 2018 -0500 > # Node ID ba2e8627d87cfaca00931fe2dcee738c3c9a4f9d > # Parent

Re: [PATCH 1 of 3] pycompat: correct the shlex.split() proxy method signature in py3

> On Feb 20, 2018, at 11:32 PM, Matt Harbison wrote: > > # HG changeset patch > # User Matt Harbison > # Date 1519180650 18000 > # Tue Feb 20 21:37:30 2018 -0500 > # Node ID 50a2885e94783ecce0820a08dd40d26cadbf0ae1 > # Parent

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. I like where this is going. Out of curiosity, do you think it would be possible to implement an option that behaved like a boolean when given in isolation but also

D1957: streamclonebundle: make sure we accept new stream clone bundle spec

indygreg added a comment. In general, I'm pretty happy with this series. Although I held off accepting changesets because I think we should have a mini discussion about //content options// versus //capabilities// before things get out of control and we duplicate too much logic. I'd

D1952: bundlespec: move computing the bundle contentops in parsebundlespec

indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. I like where this is going. It's worth noting that at some point this will reinvent the //capabilities// mechanism of bundle2. Over the wire protocol today, the client

[PATCH 1 of 3] pycompat: correct the shlex.split() proxy method signature in py3

# HG changeset patch # User Matt Harbison # Date 1519180650 18000 # Tue Feb 20 21:37:30 2018 -0500 # Node ID 50a2885e94783ecce0820a08dd40d26cadbf0ae1 # Parent aefb75730ea34f545f0756bf8441fc9ae07bf8dc pycompat: correct the shlex.split() proxy method signature in py3

[PATCH 3 of 3] debuginstall: strip double quotes from editorbin on Windows

# HG changeset patch # User Matt Harbison # Date 1519182193 18000 # Tue Feb 20 22:03:13 2018 -0500 # Node ID d78bc61eebd8f4a8e0e6aac21085308502fa3d9d # Parent 8d7c512d216042abc6df7653ad6981275880ec45 debuginstall: strip double quotes from editorbin on Windows The

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

dploch added a comment. Friendly ping! This is my first commit so I'm not sure if more information or changes are expected; please let me know if there's anything I'm missing. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2090 To: dploch, #hg-reviewers,

mercurial@36332: 89 new changesets

89 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/18bdfad8506e changeset: 36244:18bdfad8506e parent: 36239:428de1a59f2d user:Yuya Nishihara date:Sun Jan 07 11:04:53 2018 +0900 summary: templater: extract function scanning template

Re: [PATCH 1 of 6 remotenames-ext] Back out "remotenames: push anonymous head if --force is given"

Ryan McElroy writes: > # HG changeset patch > # User Ryan McElroy > # Date 1519040197 28800 > # Mon Feb 19 03:36:37 2018 -0800 > # Node ID 6b80188783ee2626030113a9b2319f2fd14a8119 > # Parent 905b79d62df82d8ca16ecac175e6236fe959f4ed > Back out "remotenames:

Re: D2277: remotenames: don't use the default value of logfmt for namespaces

pulkit (Pulkit Goyal) writes: > pulkit updated this revision to Diff 5777. > pulkit edited the summary of this revision. > > REPOSITORY > rHG Mercurial > > CHANGES SINCE LAST UPDATE > https://phab.mercurial-scm.org/D2277?vs=5756=5777 > > REVISION DETAIL >

Re: D1756: remotenames: introduce class to encapsulate remotenames info in an extension

martinvonz (Martin von Zweigbergk) writes: > martinvonz added inline comments. > > INLINE COMMENTS > >> remotenames.py:23 >> + >> +class remotenames(dict): >> +""" > > Why does this extend dict? Do we expect callers to update bookmarks by doing > something

[Bug 5798] New: annotate output is broken if the file contains multiple CR in a line

https://bz.mercurial-scm.org/show_bug.cgi?id=5798 Bug ID: 5798 Summary: annotate output is broken if the file contains multiple CR in a line Product: Mercurial Version: default branch Hardware: PC OS: Linux

D2351: py3: add b'' prefixes in fakepatchtime.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9a75619776ca: py3: add b prefixes in fakepatchtime.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2351?vs=5919=5929

D2356: py3: add a r'' prefix to prevent transformer from adding b''

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1eee42aed306: py3: add a r prefix to prevent transformer from adding b (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2353: py3: use dict.items() instead of dict.iteritems() in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rHG58c1368ab629: py3: use dict.items() instead of dict.iteritems() in tests (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2352: py3: add b'' prefixes in test-transplant.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa2cbff474821: py3: add b prefixes in test-transplant.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2352?vs=5920=5930

D2357: convert: don't use bytes as a variable name

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe218830f6f0a: convert: dont use bytes as a variable name (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2357?vs=5925=5936

D2358: convert: don't use type as a variable name

This revision was automatically updated to reflect the committed changes. Closed by commit rHGaefb75730ea3: convert: dont use type as a variable name (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2358?vs=5926=5935#toc REPOSITORY rHG Mercurial

D2355: py3: use pycompat.byteskwargs in hgext/convert/

This revision was automatically updated to reflect the committed changes. Closed by commit rHG93943eef696f: py3: use pycompat.byteskwargs in hgext/convert/ (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2354: py3: add b'' prefixes in test-mdiff.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8d0b0b533e09: py3: add b prefixes in test-mdiff.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2354?vs=5922=5932

D2349: py3: use '%d' to convert integer to bytes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG920bbfb686da: py3: use %d to convert integer to bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2349?vs=5917=5927

D2350: py3: add b'' prefixes in fakedirstatewritetime.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHGac04f17b7041: py3: add b prefixes in fakedirstatewritetime.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 1 of 2] tests: check obsolete changeset with two obsfate entries

On Mon, 19 Feb 2018 14:02:39 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1519014623 -28800 > # Mon Feb 19 12:30:23 2018 +0800 > # Node ID 29f9eeec6782d2815cf742d22286b0192fc3c14a > # Parent

Re: [PATCH 2 of 4] revbranchcache: add a bundle2 handler for a rbc part

On Tue, 20 Feb 2018 12:02:36 +0100, Feld Boris wrote: > On 19/01/2018 15:54, Yuya Nishihara wrote: > > On Thu, 18 Jan 2018 16:38:45 +0100, Boris Feld wrote: > >> # HG changeset patch > >> # User Boris Feld > >> # Date 1516282142 -3600 > >> # Thu Jan 18 14:29:02 2018

Re: [PATCH 2 of 4] revbranchcache: add a bundle2 handler for a rbc part

On 19/01/2018 15:54, Yuya Nishihara wrote: On Thu, 18 Jan 2018 16:38:45 +0100, Boris Feld wrote: # HG changeset patch # User Boris Feld # Date 1516282142 -3600 # Thu Jan 18 14:29:02 2018 +0100 # Node ID 9c1ad82226a2e1fc7ca69550a46a7f7329c6b579 # Parent

D1957: streamclonebundle: make sure we accept new stream clone bundle spec

lothiraldan added a comment. Ping on this series REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1957 To: lothiraldan, #hg-reviewers Cc: indygreg, mercurial-devel ___ Mercurial-devel mailing list