D987: copies: add a config to limit the number of candidates to check in heuristics

stash added a comment. @pulkit sorry for being late with the comments. I agree with @yuja - falling back is not an option, because it's probably going to be slow. As for these two options > - do not try to find copy from the first n candidates, and show the message saying copy

D358: copytrace: move fb extension to core under flag experimental.fastcopytrace

stash added a comment. Quick heads-up: one of our bootcampers works on the task that does the following: if rebase/merge/graft happens only on the local stack (i.e. base commit is draft), then we fallback to the normal copytrace, because we are sure it's going to be fast enough REPOSITORY

[PATCH V2] selectivepull: fix tests

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1496247075 25200 # Wed May 31 09:11:15 2017 -0700 # Node ID 8728c97e46330e67bcf5237686d3078c9eb83d03 # Parent 900f1c70436bd7a266f64a6db592af602f8138a5 selectivepull: fix tests There was a change up

Re: [PATCH remotenames-ext] selectivepull: fix tests

Excerpts from Sean Farley's message of 2017-05-30 17:23:11 -0700: > Stanislau Hlebik <st...@fb.com> writes: > > > # HG changeset patch > > # User Stanislau Hlebik <st...@fb.com> > > # Date 1495731588 25200 > > # Th

[PATCH 5 of 7] copies: remove msrc and mdst parameters

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1496062645 25200 # Mon May 29 05:57:25 2017 -0700 # Node ID e460d9165b77c5333a0288bd423175ad9ac4519a # Parent cfdf3dc92e2c9415474cef9b004a002e9b0bc7ff copies: remove msrc and mdst parameters This function already ha

[PATCH 3 of 7] copies: rename ctx to srcctx

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1496062577 25200 # Mon May 29 05:56:17 2017 -0700 # Node ID cff8c67aae48c7ee7c07b0878e15fb5aa54aed8c # Parent 2cf8c7e99a33dce384b49d3fd0fc4c9512ee94b5 copies: rename ctx to srcctx In the next diff we'll pass new

[PATCH 7 of 7] copies: introduce getdstfctx

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1496063173 25200 # Mon May 29 06:06:13 2017 -0700 # Node ID 337ac332b0a1260583c82a3bf346a304a9245ff1 # Parent 216a6a72c032ab10e8cc8dc6f916593508dc0a45 copies: introduce getdstfctx Previously `c2` may had an incorrect l

[PATCH 4 of 7] copies: add dstctx parameter

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1496062623 25200 # Mon May 29 05:57:03 2017 -0700 # Node ID cfdf3dc92e2c9415474cef9b004a002e9b0bc7ff # Parent cff8c67aae48c7ee7c07b0878e15fb5aa54aed8c copies: add dstctx parameter Add parameter with destination context

[PATCH 1 of 7] copies: rename m1 to msrc

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1496062335 25200 # Mon May 29 05:52:15 2017 -0700 # Node ID 75f0d8342109877a0dd620df3f566d0f080a9138 # Parent c2b7fb580794ccbe21fa8c47f493eff6e9431fee copies: rename m1 to msrc Small refactoring that renames `m1` par

[PATCH 2 of 7] copies: rename m2 to mdst

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1496062335 25200 # Mon May 29 05:52:15 2017 -0700 # Node ID 2cf8c7e99a33dce384b49d3fd0fc4c9512ee94b5 # Parent 75f0d8342109877a0dd620df3f566d0f080a9138 copies: rename m2 to mdst Small refactoring to rename m2 to more c

[PATCH remotenames-ext] selectivepull: fix tests

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1495731588 25200 # Thu May 25 09:59:48 2017 -0700 # Node ID 78c8966c02759755235a6566e0c557b82ff9cb0a # Parent 900f1c70436bd7a266f64a6db592af602f8138a5 selectivepull: fix tests diff --git a/tests/test-selective-pull.t b

[PATCH V2] filemerge: store error messages in module variables

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1495190863 25200 # Fri May 19 03:47:43 2017 -0700 # Node ID 48651bcde6516d2bc075ce694a3d8b2fc0084e7b # Parent 8a87bfc5bebbbe0ac996ac8e047a029eb931af45 filemerge: store error messages in module variables Copytraci

[PATCH] filemerge: store error messages in module variables

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1495125989 25200 # Thu May 18 09:46:29 2017 -0700 # Node ID a1bf790daa1dcaf534c766b961951947d69938ae # Parent 8a87bfc5bebbbe0ac996ac8e047a029eb931af45 filemerge: store error messages in module variables Copytraci

[PATCH 1 of 2 remotenames-ext] remotenames: get rid of useless lookup

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1487690067 28800 # Tue Feb 21 07:14:27 2017 -0800 # Node ID cf04161615a48d42a2bb6181060ae9be8ceaa467 # Parent 4f17d4ae821e7654b3c134002537155b28f7e146 remotenames: get rid of useless lookup Lookup is useless since `boo

[PATCH 2 of 2 remotenames-ext] remotenames: selectivepull, add _listremotebookmarks

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1487690190 28800 # Tue Feb 21 07:16:30 2017 -0800 # Node ID f49560facf4802449ab15aaf9b12287754619990 # Parent cf04161615a48d42a2bb6181060ae9be8ceaa467 remotenames: selectivepull, add _listremotebookmarks Adding a se

[PATCH] repoview: separate cache hash computation from cache reading

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1487584447 28800 # Mon Feb 20 01:54:07 2017 -0800 # Node ID cb1151ce14f7ec9e2ca991bc8bd590020ec4b061 # Parent 693a5bb478543a986808264e586073a3ceedc38f repoview: separate cache hash computation from cache reading This

Re: RFC: bitmap storage for precursors and phases

Excerpts from Augie Fackler's message of 2017-02-19 21:06:53 -0500: > On Fri, Feb 17, 2017 at 09:59:48PM +0000, Stanislau Hlebik wrote: > > Excerpts from Bryan O'Sullivan's message of 2017-02-17 13:29:58 -0800: > > > On Fri, Feb 17, 2017 at 10:30 AM, Jun Wu &l

Re: RFC: bitmap storage for precursors and phases

Excerpts from Jun Wu's message of 2017-02-17 19:14:12 -0800: > Excerpts from Bryan O'Sullivan's message of 2017-02-17 13:29:58 -0800: > > On Fri, Feb 17, 2017 at 10:30 AM, Jun Wu wrote: > > > > > Excerpts from Stanislau Hlebik's message of 2017-02-17 11:24:34 +: > > > > As I

Re: RFC: bitmap storage for precursors and phases

Excerpts from Bryan O'Sullivan's message of 2017-02-17 13:29:58 -0800: > On Fri, Feb 17, 2017 at 10:30 AM, Jun Wu wrote: > > > Excerpts from Stanislau Hlebik's message of 2017-02-17 11:24:34 +: > > > As I said before we will load all non-public revs in one set and all > > > >

Re: RFC: bitmap storage for precursors and phases

Excerpts from Jun Wu's message of 2017-02-17 10:30:45 -0800: > Excerpts from Stanislau Hlebik's message of 2017-02-17 11:24:34 +: > > As I said before we will load all non-public revs in one set and all > > The problem is, loading a Python set from disk is O(size-of-the-set). > > Bitmap's

Re: RFC: bitmap storage for precursors and phases

Excerpts from Stanislau Hlebik's message of 2017-02-17 11:24:34 +: > Excerpts from Jun Wu's message of 2017-02-16 13:42:46 -0800: > > Excerpts from Stanislau Hlebik's message of 2017-02-16 19:39:07 +: > > > Excerpts from Stanislau Hlebik's message of 2017-02-14 09:29:25 +: > > > >

Re: RFC: bitmap storage for precursors and phases

Excerpts from Jun Wu's message of 2017-02-16 13:42:46 -0800: > Excerpts from Stanislau Hlebik's message of 2017-02-16 19:39:07 +: > > Excerpts from Stanislau Hlebik's message of 2017-02-14 09:29:25 +: > > > Excerpts from Sean Farley's message of 2017-02-13 18:30:25 -0800: > > > > Jun Wu

Re: RFC: bitmap storage for precursors and phases

Excerpts from Stanislau Hlebik's message of 2017-02-14 09:29:25 +: > Excerpts from Sean Farley's message of 2017-02-13 18:30:25 -0800: > > Jun Wu writes: > > > > > Excerpts from Sean Farley's message of 2017-02-13 17:04:35 -0800: > > >> I was thinking about a more high-level

Re: RFC: bitmap storage for precursors and phases

Excerpts from Gregory Szorc's message of 2017-02-13 20:28:37 -0700: > > > On Feb 10, 2017, at 10:33, Stanislau Hlebik <st...@fb.com> wrote: > > > > Last year Durham sent a proposal for bitmap storage for computehidden() > > https://urldefense.proofpoint.com

Re: RFC: bitmap storage for precursors and phases

Excerpts from Sean Farley's message of 2017-02-13 18:30:25 -0800: > Jun Wu writes: > > > Excerpts from Sean Farley's message of 2017-02-13 17:04:35 -0800: > >> I was thinking about a more high-level approach (please feel free to > >> pick apart): > >> > >> r =

[PATCH 2 of 2] localrepo: avoid unnecessary sorting

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1486981916 28800 # Mon Feb 13 02:31:56 2017 -0800 # Node ID 30fd6051a7e441aac16b5ba7b4a19aa3731576f0 # Parent 8bc5ae6cf51408dbd1b789555196f031bfef19d4 localrepo: avoid unnecessary sorting headrevs output already

[PATCH 1 of 2] localrepo: cache self.changelog in local variable

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1486981578 28800 # Mon Feb 13 02:26:18 2017 -0800 # Node ID 8bc5ae6cf51408dbd1b789555196f031bfef19d4 # Parent a0e3d808690d57d1c9dff840e0b8ee099526397b localrepo: cache self.changelog in local variable Repeated self.cha

Re: [PATCH 6 of 6 remotenames-ext] selectivepull: support list of default bookmarks

Excerpts from Gregory Szorc's message of 2017-02-11 10:54:43 -0800: > > > On Jan 30, 2017, at 07:56, Stanislau Hlebik <st...@fb.com> wrote: > > > > # HG changeset patch > > # User Stanislau Hlebik <st...@fb.com> > > # Date 1485791649 28800 > >

Re: RFC: bitmap storage for precursors and phases

Excerpts from Jun Wu's message of 2017-02-10 11:04:24 -0800: > In general, I think this is a good direction. Some random thoughts: > > - general purposed > > I think the bitmap is not always a cache, so it should only have > operations like set/unset/readfromdisk/writetodisk.

RFC: bitmap storage for precursors and phases

Last year Durham sent a proposal for bitmap storage for computehidden() https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-September/087860.html. It got a few useful comments, two most important comments: 1. Use bitmaps for lower-level data structures, for example, bitmap for

[PATCH V2] localrepo: avoid unnecessary conversion from node to rev

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1486457478 28800 # Tue Feb 07 00:51:18 2017 -0800 # Node ID 8614d5d15d6fe47c3bcfdf79823f68f18c7741ae # Parent 1f51b4658f21bbb797e922d155c1046eddccf91d localrepo: avoid unnecessary conversion from node to rev changelog

[PATCH 4 of 6 remotenames-ext] tests: write to local hgrc

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1485791649 28800 # Mon Jan 30 07:54:09 2017 -0800 # Node ID 25d873eac976b58ac99dabb3f0e62814bb2aa2f8 # Parent 3e17b130293b0c65918041ad4e51a32a909e4f48 tests: write to local hgrc A future test will need to run w

[PATCH 3 of 6 remotenames-ext] selectivepull: add function to get default bookmarks

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1485791649 28800 # Mon Jan 30 07:54:09 2017 -0800 # Node ID 3e17b130293b0c65918041ad4e51a32a909e4f48 # Parent a7786a178d5cb9abed981c76e47588fffede7511 selectivepull: add function to get default bookmarks Small refac

[PATCH 2 of 6 remotenames-ext] selectivepull: fix passing `heads` argument multiple times

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1485791608 28800 # Mon Jan 30 07:53:28 2017 -0800 # Node ID a7786a178d5cb9abed981c76e47588fffede7511 # Parent 8b66569e49ce6382670497aa4e96c5e81c224439 selectivepull: fix passing `heads` argument multiple times Usually

[PATCH 1 of 6 remotenames-ext] selectivepull: add comments

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1485515845 28800 # Fri Jan 27 03:17:25 2017 -0800 # Node ID 8b66569e49ce6382670497aa4e96c5e81c224439 # Parent 18f8e0f8ba54270bf158734c781327581cf43634 selectivepull: add comments Explain why selectivepull is useful

[PATCH 6 of 6 remotenames-ext] selectivepull: support list of default bookmarks

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1485791649 28800 # Mon Jan 30 07:54:09 2017 -0800 # Node ID 227796849698292c76c70e874179de52b7b688d6 # Parent a96117003c763be640a975d8128068d2bd3527c0 selectivepull: support list of default bookmarks The addition is t

[PATCH remotenames-ext] remotenames: lazily read remotenames file

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1483717320 28800 # Fri Jan 06 07:42:00 2017 -0800 # Node ID 043090278718e0b82f6b3d8f7258d56080209d40 # Parent c65e41aef8dc18f29f8652f9d71a9c0d028fd95d remotenames: lazily read remotenames file remotenames file is read

[PATCH evolve-ext] tests: fix tests to reflect hg core changes

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1483608997 28800 # Thu Jan 05 01:36:37 2017 -0800 # Node ID 98b6678ee09c76aa471b119939935a9b67b1ff77 # Parent ba9fabaca91b0897cffb7048d81193e44d440948 tests: fix tests to reflect hg core c

Re: [PATCH] bookmarks: introduce binary encoding

Excerpts from Stanislau Hlebik's message of 2016-12-20 13:49:37 +: > Excerpts from Pierre-Yves David's message of 2016-12-17 08:39:18 +0100: > > > > On 12/09/2016 12:16 PM, Stanislau Hlebik wrote: > > > # HG changeset patch > > > # User Stanislau Hlebik <s

Re: [PATCH] bookmarks: introduce binary encoding

Excerpts from Pierre-Yves David's message of 2016-12-17 08:39:18 +0100: > > On 12/09/2016 12:16 PM, Stanislau Hlebik wrote: > > # HG changeset patch > > # User Stanislau Hlebik <st...@fb.com> > > # Date 1481281951 28800 > > # Fri Dec

Re: [PATCH 2 of 2] bookmarks: make bookmarks.comparebookmarks accept binary nodes (API)

Excerpts from Pierre-Yves David's message of 2016-12-17 08:33:20 +0100: > > On 12/09/2016 12:31 PM, Stanislau Hlebik wrote: > > # HG changeset patch > > # User Stanislau Hlebik <st...@fb.com> > > # Date 1481282546 28800 > > # Fri Dec

[PATCH] cg1packer: fix `compressed` method

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1481738036 28800 # Wed Dec 14 09:53:56 2016 -0800 # Node ID f511d71c272bf87ea263cdcda3045e26fd5f8dfe # Parent 4cdc738f8246c748dc1639754d0e7ced97d15e23 cg1packer: fix `compressed` method `cg1packer.compressed()` return

[PATCH 2 of 2] bookmarks: make bookmarks.comparebookmarks accept binary nodes (API)

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1481282546 28800 # Fri Dec 09 03:22:26 2016 -0800 # Node ID df861963a18c00d72362b415a77a62d2c18660bf # Parent 08ab8f9d0abcbd1b2405ecb0a8670d212866af1f bookmarks: make bookmarks.comparebookmarks accept binary node

[PATCH] bookmarks: introduce binary encoding

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1481281951 28800 # Fri Dec 09 03:12:31 2016 -0800 # Node ID 001ceadc2bc36699bdf816370899a27203bf1818 # Parent 9e29d4e4e08b5996adda49cdd0b497d89e2b16ee bookmarks: introduce binary encoding Bookmarks binary en

[PATCH 8 of 8 V12] help: add documentation about bookmark part

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807361 28800 # Tue Nov 22 01:36:01 2016 -0800 # Node ID 261bc4a0670a47a8fbe8d633f19f92542be4790c # Parent dc34527b28959ef96a4e7b23430ad467b5fbf85e help: add documentation about bookmark part diff --git a/mercuria

[PATCH 4 of 8 V12] bundle2: add `bookmarks` part handler

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807361 28800 # Tue Nov 22 01:36:01 2016 -0800 # Node ID 49d598a6db4b0fa63b7a30b55899caa0fa1f9c99 # Parent 81854771326941912a0dfd80f4f0c9d0191eea75 bundle2: add `bookmarks` part handler Applies bookmarks part to the

[PATCH 2 of 8 V12] bookmarks: rename `compare()` to `comparebookmarks()` (API)

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807211 28800 # Tue Nov 22 01:33:31 2016 -0800 # Node ID 0fd97a0c043a3f5c1d4ba050435d86e09dbd0f54 # Parent d184b91890ae3cbd21f656847b6b2728892b2425 bookmarks: rename `compare()` to `comparebookmarks()` (API) Next

[PATCH 5 of 8 V12] exchange: getbundle `bookmarks` part generator

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807361 28800 # Tue Nov 22 01:36:01 2016 -0800 # Node ID b08e4f9ed873bb9b6bd8e170401a150f9b094bfd # Parent 49d598a6db4b0fa63b7a30b55899caa0fa1f9c99 exchange: getbundle `bookmarks` part generator This gen

[PATCH 7 of 8 V12] bundle2: advertise bookmark capability

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807361 28800 # Tue Nov 22 01:36:01 2016 -0800 # Node ID dc34527b28959ef96a4e7b23430ad467b5fbf85e # Parent be39a83d5cb8c60e9b9a2a1b58b4b0dde833c77b bundle2: advertise bookmark capability diff --git a/mercurial/bund

[PATCH 1 of 8 V12] bookmarks: introduce binary encoding

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807211 28800 # Tue Nov 22 01:33:31 2016 -0800 # Node ID d184b91890ae3cbd21f656847b6b2728892b2425 # Parent 9e29d4e4e08b5996adda49cdd0b497d89e2b16ee bookmarks: introduce binary encoding Bookmarks binary en

[PATCH 7 of 8 V11] bundle2: advertise bookmark capability

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807361 28800 # Tue Nov 22 01:36:01 2016 -0800 # Node ID 729a7c3e2a60c5740c1629abfba7726933d018b7 # Parent df763dd7f611acbc9fcb4ad9c3fe4706b60bde6e bundle2: advertise bookmark capability diff --git a/mercurial/bund

[PATCH 6 of 8 V11] pull: use `bookmarks` bundle2 part

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807361 28800 # Tue Nov 22 01:36:01 2016 -0800 # Node ID df763dd7f611acbc9fcb4ad9c3fe4706b60bde6e # Parent ce7bdfedd1b36290a981228f630daabc9fc09cfd pull: use `bookmarks` bundle2 part Apply changes from `bookmarks

[PATCH 8 of 8 V11] help: add documentation about bookmark part

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807361 28800 # Tue Nov 22 01:36:01 2016 -0800 # Node ID 4e82e7ed1c1eb0eddb2fe7409a812c27be133b94 # Parent 729a7c3e2a60c5740c1629abfba7726933d018b7 help: add documentation about bookmark part diff --git a/mercuria

[PATCH 2 of 8 V11] bookmarks: rename `compare()` to `comparebookmarks()` (API)

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807211 28800 # Tue Nov 22 01:33:31 2016 -0800 # Node ID 20e2f13b7a1083f8d44a7a9e554eb3d5735b80f2 # Parent 8efced91de4d48478555d91c53e89cd1b4e3b78d bookmarks: rename `compare()` to `comparebookmarks()` (API) Next

[PATCH 3 of 8 V11] bookmarks: make bookmarks.compare accept binary nodes (API)

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807361 28800 # Tue Nov 22 01:36:01 2016 -0800 # Node ID 36d83269edc51168908c9b1160e22282ab6c5c04 # Parent 20e2f13b7a1083f8d44a7a9e554eb3d5735b80f2 bookmarks: make bookmarks.compare accept binary nodes (API

[PATCH 4 of 8 V11] bundle2: add `bookmarks` part handler

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807361 28800 # Tue Nov 22 01:36:01 2016 -0800 # Node ID 1572af8f4545b11c8147170cb421c23547d918fc # Parent 36d83269edc51168908c9b1160e22282ab6c5c04 bundle2: add `bookmarks` part handler Applies bookmarks part to the

[PATCH 5 of 8 V11] exchange: getbundle `bookmarks` part generator

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807361 28800 # Tue Nov 22 01:36:01 2016 -0800 # Node ID ce7bdfedd1b36290a981228f630daabc9fc09cfd # Parent 1572af8f4545b11c8147170cb421c23547d918fc exchange: getbundle `bookmarks` part generator This gen

[PATCH 1 of 8 V11] bookmarks: introduce binary encoding

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479807211 28800 # Tue Nov 22 01:33:31 2016 -0800 # Node ID 8efced91de4d48478555d91c53e89cd1b4e3b78d # Parent 259296eb59e77951572872fb2f542c6dbff8bc74 bookmarks: introduce binary encoding Bookmarks binary en

Re: [PATCH 08 of 10 V10] pull: use `bookmarks` bundle2 part

From: Gregory Szorc <gregory.sz...@gmail.com> Date: Tuesday, November 22, 2016 at 3:48 AM To: Stanislau Hlebik <st...@fb.com> Cc: mercurial-devel <mercurial-devel@mercurial-scm.org>, Pierre-Yves David <pierre-yves.da...@ens-lyon.org> Subject: Re: [PATCH 08 of 10 V10] pull:

[PATCH 03 of 10 V10] exchange: add `_getbookmarks()` function

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479373181 28800 # Thu Nov 17 00:59:41 2016 -0800 # Node ID 4e782ccf84f8fee96963f09439f7da7202c37775 # Parent 54b24eb2eac7c181f9fd15423fd05218a6a11186 exchange: add `_getbookmarks()` function This function will b

[PATCH 04 of 10 V10] bookmarks: introduce binary encoding

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479373181 28800 # Thu Nov 17 00:59:41 2016 -0800 # Node ID bd590f83eb640f4464ba5465f4e10677e348e83c # Parent 4e782ccf84f8fee96963f09439f7da7202c37775 bookmarks: introduce binary encoding Bookmarks binary en

[PATCH 08 of 10 V10] pull: use `bookmarks` bundle2 part

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479373181 28800 # Thu Nov 17 00:59:41 2016 -0800 # Node ID 2ac3e9d5983f18f94a1df84317d1d2f1bd9b88b8 # Parent 5af41d2c5226c36d5a1f999ff3d99d8694ae68b9 pull: use `bookmarks` bundle2 part Apply changes from `bookmarks

[PATCH 07 of 10 V10] exchange: getbundle `bookmarks` part generator

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479373181 28800 # Thu Nov 17 00:59:41 2016 -0800 # Node ID 5af41d2c5226c36d5a1f999ff3d99d8694ae68b9 # Parent 866281dae2407308c19c7c3109bb5501b940ee67 exchange: getbundle `bookmarks` part generator This gen

[PATCH 10 of 10 V10] help: add documentation about bookmark part

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479373181 28800 # Thu Nov 17 00:59:41 2016 -0800 # Node ID b46026585f5961e520c21ea336baa7a6f68a3d85 # Parent adbd3b69427059264d78fa8f29fa6eabcc38bf5f help: add documentation about bookmark part diff --git a/mercuria

[PATCH 06 of 10 V10] bundle2: add `bookmarks` part handler

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479643450 28800 # Sun Nov 20 04:04:10 2016 -0800 # Node ID 866281dae2407308c19c7c3109bb5501b940ee67 # Parent 57d7f92db34461da87850e26d831d2d235282356 bundle2: add `bookmarks` part handler Applies bookmarks part to the

[PATCH 05 of 10 V10] bookmarks: make bookmarks.compare accept binary nodes

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479373181 28800 # Thu Nov 17 00:59:41 2016 -0800 # Node ID 57d7f92db34461da87850e26d831d2d235282356 # Parent bd590f83eb640f4464ba5465f4e10677e348e83c bookmarks: make bookmarks.compare accept binary nodes New `boo

[PATCH 02 of 10 V10] bookmarks: use listbinbookmarks() in listbookmarks()

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479373181 28800 # Thu Nov 17 00:59:41 2016 -0800 # Node ID 54b24eb2eac7c181f9fd15423fd05218a6a11186 # Parent a3159f73e59868f8ae0993cc91277142aaa10536 bookmarks: use listbinbookmarks() in listbookmarks() diff

[PATCH 02 of 10 V9] bookmarks: use listbinbookmarks() in listbookmarks()

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479032114 28800 # Sun Nov 13 02:15:14 2016 -0800 # Branch stable # Node ID 031419529f6594c3f23fc179d67c8de9ef63472f # Parent ffa31155703b725b20d67f379bea4de7c56379fe bookmarks: use listbinbookmarks() in listbookmarks()

[PATCH 03 of 10 V9] exchange: add `_getbookmarks()` function

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479032456 28800 # Sun Nov 13 02:20:56 2016 -0800 # Branch stable # Node ID 0917ce41b232a5fc2a6e503cbad15879e037a2f9 # Parent 031419529f6594c3f23fc179d67c8de9ef63472f exchange: add `_getbookmarks()` function This fu

[PATCH 05 of 10 V9] bookmarks: make bookmarks.compare accept binary nodes

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479032456 28800 # Sun Nov 13 02:20:56 2016 -0800 # Branch stable # Node ID 5cdf21805bb97ba99199c8779e3ad91137061c07 # Parent 8b6ab3b8df3aae90ac72d7fa4603e7d5b4ab55e9 bookmarks: make bookmarks.compare accept binary node

[PATCH 07 of 10 V9] exchange: getbundle `bookmarks` part generator

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479032456 28800 # Sun Nov 13 02:20:56 2016 -0800 # Branch stable # Node ID 606bb4a7fb818f24d52e764828ba0d0a7921f999 # Parent bf21586f26e5a41f7d8bf342d4b4c16d71dbc6d2 exchange: getbundle `bookmarks` part gen

[PATCH 08 of 10 V9] pull: use `bookmarks` bundle2 part

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479032456 28800 # Sun Nov 13 02:20:56 2016 -0800 # Branch stable # Node ID 35096015b14e891b5d6a12af036163875bc60460 # Parent 606bb4a7fb818f24d52e764828ba0d0a7921f999 pull: use `bookmarks` bundle2 part Apply change

[PATCH 10 of 10 V9] help: add documentation about bookmark part

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479032456 28800 # Sun Nov 13 02:20:56 2016 -0800 # Branch stable # Node ID f221666dfbb6e055219634aa18c7460b0bcf24a4 # Parent a261e5b0c5a402c5f084bb8fcf53866f2f900687 help: add documentation about bookmark part diff

[PATCH 01 of 10 V9] bookmarks: introduce listbinbookmarks()

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1479032036 28800 # Sun Nov 13 02:13:56 2016 -0800 # Branch stable # Node ID ffa31155703b725b20d67f379bea4de7c56379fe # Parent b9f7b0c10027764cee77f9c6d61877fcffea837f bookmarks: introduce listbinbookmarks() `boo

[PATCH 09 of 10 V8] bundle2: advertise bookmark capability

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478980606 28800 # Sat Nov 12 11:56:46 2016 -0800 # Branch stable # Node ID dd7caf9f799c4c8e012afca214683159645cc931 # Parent 66787435b18cf4050ba50097b4d6725f09233b74 bundle2: advertise bookmark capability diff

[PATCH 10 of 10 V8] help: add documentation about bookmark part

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478980606 28800 # Sat Nov 12 11:56:46 2016 -0800 # Branch stable # Node ID d1bfcb4a1594060275db040e6534fd262c5a43ec # Parent dd7caf9f799c4c8e012afca214683159645cc931 help: add documentation about bookmark part diff

[PATCH 06 of 10 V8] bundle2: add `bookmarks` part handler

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478980606 28800 # Sat Nov 12 11:56:46 2016 -0800 # Branch stable # Node ID f8a24164d9190f457ff5cd5089b8879c71ec801f # Parent 745156544137985fe5c6b31fe99232e84d596ec4 bundle2: add `bookmarks` part handler Applies boo

[PATCH 07 of 10 V8] exchange: getbundle `bookmarks` part generator

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478980606 28800 # Sat Nov 12 11:56:46 2016 -0800 # Branch stable # Node ID 7bd99f5871d67df64e60174f2c349bc088a584f6 # Parent f8a24164d9190f457ff5cd5089b8879c71ec801f exchange: getbundle `bookmarks` part gen

[PATCH 08 of 10 V8] pull: use `bookmarks` bundle2 part

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478980606 28800 # Sat Nov 12 11:56:46 2016 -0800 # Branch stable # Node ID 66787435b18cf4050ba50097b4d6725f09233b74 # Parent 7bd99f5871d67df64e60174f2c349bc088a584f6 pull: use `bookmarks` bundle2 part Apply change

[PATCH 05 of 10 V8] bookmarks: make bookmarks.compare accept binary nodes

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478980606 28800 # Sat Nov 12 11:56:46 2016 -0800 # Branch stable # Node ID 745156544137985fe5c6b31fe99232e84d596ec4 # Parent 767dc51625be5f1ca62fe15cfa17f96dcd1b7cec bookmarks: make bookmarks.compare accept binary node

[PATCH 04 of 10 V8] bookmarks: introduce binary encoding

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478980606 28800 # Sat Nov 12 11:56:46 2016 -0800 # Branch stable # Node ID 767dc51625be5f1ca62fe15cfa17f96dcd1b7cec # Parent cf754de559217f5965d1101c4591689d9924bddc bookmarks: introduce binary encoding Bookmarks

[PATCH 03 of 10 V8] exchange: add `_getbookmarks()` function

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478980606 28800 # Sat Nov 12 11:56:46 2016 -0800 # Branch stable # Node ID cf754de559217f5965d1101c4591689d9924bddc # Parent 13b3e16c68d303a523550980d7739bb676420851 exchange: add `_getbookmarks()` function This fu

[PATCH 02 of 10 V8] bookmarks: introduce listbookmarks()

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478980589 28800 # Sat Nov 12 11:56:29 2016 -0800 # Branch stable # Node ID 13b3e16c68d303a523550980d7739bb676420851 # Parent fe9e78883230a875ae7acf6c7a5b324c1d9016f5 bookmarks: introduce listbookmarks() `bookmarks` b

Re: [PATCH 6 of 9 V6] bundle2: add `bookmarks` part handler

BTW, how do you think it should look like? Do you want to introduce another type of categories in unbundlerecords or just rewrite categories whenever a new bookmark category is added? On 11/11/16, 11:50 AM, "Stanislau Hlebik" <st...@fb.com> wrote: I think we can but it wou

Re: [PATCH 5 of 9 V6] bookmarks: add srchex param to updatefromremote

That should be fine On 11/11/16, 11:59 AM, "Pierre-Yves David" <pierre-yves.da...@ens-lyon.org> wrote: On 11/11/2016 11:29 AM, Stanislau Hlebik wrote: > Not sure I fully understand your idea. > Do you suggest to rewrite bookmarks.compare and book

Re: [PATCH 2 of 8 V7] bookmarks: introduce binary encoding

We can use 32 bytes, but only 20 bytes will be used. What’s the point then? On 11/9/16, 5:22 PM, "Augie Fackler" <r...@durin42.com> wrote: On Wed, Nov 02, 2016 at 07:06:44AM -0700, Stanislau Hlebik wrote: > # HG changeset patch > # User Stanislau Hlebik <s

Re: [PATCH 8 of 8 V7] help: add documentation about bookmark part

07:06:50AM -0700, Stanislau Hlebik wrote: > # HG changeset patch > # User Stanislau Hlebik <st...@fb.com> > # Date 1478095405 25200 > # Wed Nov 02 07:03:25 2016 -0700 > # Branch stable > # Node ID 5ed1eda9bf3e92dd6037028a0202690dc845efa2 > # Paren

[PATCH 1 of 8 V7] exchange: add `_getbookmarks()` function

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478016027 25200 # Tue Nov 01 09:00:27 2016 -0700 # Branch stable # Node ID a56a624a8a42b93ec980d2c284756a38719dffe6 # Parent b9f7b0c10027764cee77f9c6d61877fcffea837f exchange: add `_getbookmarks()` function This fu

[PATCH 7 of 8 V7] bundle2: advertise bookmark capability

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478088362 25200 # Wed Nov 02 05:06:02 2016 -0700 # Branch stable # Node ID c2a9f675fac55522bb954ea81c29fa0158106214 # Parent e2122d93aeb4da4a39c0c257e74414ac348a89f1 bundle2: advertise bookmark capability diff

[PATCH 6 of 8 V7] pull: use `bookmarks` bundle2 part

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478086459 25200 # Wed Nov 02 04:34:19 2016 -0700 # Branch stable # Node ID e2122d93aeb4da4a39c0c257e74414ac348a89f1 # Parent 12466c729bb6783fbef11a6e148c648809b4f592 pull: use `bookmarks` bundle2 part Apply change

[PATCH 5 of 8 V7] exchange: getbundle `bookmarks` part generator

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478016027 25200 # Tue Nov 01 09:00:27 2016 -0700 # Branch stable # Node ID 12466c729bb6783fbef11a6e148c648809b4f592 # Parent 2f89680108366512c1a6345abec5cebdb85170ac exchange: getbundle `bookmarks` part gen

[PATCH 2 of 8 V7] bookmarks: introduce binary encoding

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478016027 25200 # Tue Nov 01 09:00:27 2016 -0700 # Branch stable # Node ID f3da841e3d47ccbb0be3892b521607c09fdeab13 # Parent a56a624a8a42b93ec980d2c284756a38719dffe6 bookmarks: introduce binary encoding Bookmarks

[PATCH 3 of 8 V7] bookmarks: add srchex param to updatefromremote

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478016027 25200 # Tue Nov 01 09:00:27 2016 -0700 # Branch stable # Node ID d752daa2b736f0336a18760940104c59d6bd1a5c # Parent f3da841e3d47ccbb0be3892b521607c09fdeab13 bookmarks: add srchex param to updatefromremote

[PATCH 4 of 8 V7] bundle2: add `bookmarks` part handler

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1478016027 25200 # Tue Nov 01 09:00:27 2016 -0700 # Branch stable # Node ID 2f89680108366512c1a6345abec5cebdb85170ac # Parent d752daa2b736f0336a18760940104c59d6bd1a5c bundle2: add `bookmarks` part handler Applies boo

Re: [PATCH 5 of 9 V6] bookmarks: add srchex param to updatefromremote

I’m using srchex in bookmarks part handler to convert from bin nodes to hex nodes, because updatefromremote expect hex nodes. On 10/14/16, 2:28 AM, "Pierre-Yves David" <pierre-yves.da...@ens-lyon.org> wrote: On 10/11/2016 06:25 PM, Stanislau Hlebik wrote:

[PATCH 7 of 9 V6] exchange: getbundle `bookmarks` part generator

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1476195835 25200 # Tue Oct 11 07:23:55 2016 -0700 # Node ID 48e5db9c751c1eca19019bbc24de43f7cb3368e7 # Parent b9e71247c1b68ce1fac7dd69cf26d106f88f9372 exchange: getbundle `bookmarks` part generator This gen

[PATCH 2 of 9 V6] bookmarks: introduce BookmarksEncodeError

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1476195835 25200 # Tue Oct 11 07:23:55 2016 -0700 # Node ID 91ae660eb2faf74cb96ee7ee5bdcc1f2507f9cf7 # Parent 55e997127023d7208488c593adb933a1bfb23312 bookmarks: introduce BookmarksEncodeError Binary encoding for boo

[PATCH 6 of 9 V6] bundle2: add `bookmarks` part handler

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1476197535 25200 # Tue Oct 11 07:52:15 2016 -0700 # Node ID b9e71247c1b68ce1fac7dd69cf26d106f88f9372 # Parent f781756b8de11a6f3e7dd5fd6354e9778defd8c3 bundle2: add `bookmarks` part handler Applies bookmarks part to the

[PATCH 5 of 9 V6] bookmarks: add srchex param to updatefromremote

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1476197429 25200 # Tue Oct 11 07:50:29 2016 -0700 # Node ID f781756b8de11a6f3e7dd5fd6354e9778defd8c3 # Parent 718ed86a3698631077a087efaf668d70513056f5 bookmarks: add srchex param to updatefromremote diff --git a/mer

[PATCH 4 of 9 V6] bookmarks: introduce binary encoding

# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1476195835 25200 # Tue Oct 11 07:23:55 2016 -0700 # Node ID 718ed86a3698631077a087efaf668d70513056f5 # Parent 6f5a3300a5457c92eb09170a30c98328ebe3bcce bookmarks: introduce binary encoding Bookmarks binary en

  1   2   >