D12625: amend: stop specifying matcher, get all copies in wctx

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When we're recreating the commit that we'll be committing, we don't want to filter our copy information based on just the *new* [versions of the] files we're

D12624: amend: add test showing poor behavior when copies are involved

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12624 AFFECTED FILES tests/test-amend.t CHANGE DETAILS diff --git

D12577: amend: small refactor of logic for clarity

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12577 AFFECTED FILES mercurial/cmdutil.py CHANGE DETAILS diff --git

D12576: amend: move "return None for removed files" into block handling filestoamend

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is just a small logic cleanup from D12573 , no change in behavior. REPOSITORY rHG Mercurial BRANCH default

D12552: rebase: while rewriting desc hashes, ignore ambiguous prefix "hashes"

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If a repo is sufficiently large, a six digit number "hash prefix" can somewhat easily reference an ambiguous hash prefix. REPOSITORY rHG Mercurial BRANCH

D12551: tests: add test demonstrating issue with ambiguous has prefixes during rebase

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D12551 AFFECTED FILES tests/test-rebase-inmemory.t CHANGE DETAILS diff --git

D12441: crecord: avoid duplicating lines when reverting noeol->eol change

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When reversing a patch that looks like this while using crecord: @@ -301,4 +302,4 @@ zza zzb zzc zzd -zze \ No newline at end of

D12440: crecord: add test demonstrating issue when reverting noeol->eol change

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12440 AFFECTED FILES tests/test-revert-interactive-curses.t CHANGE DETAILS diff

D12375: tests: fix formatting issue in run-tests.py after c194e93d1ebc

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12375 AFFECTED FILES tests/run-tests.py CHANGE DETAILS diff --git

D12371: tests: support another error case when detecting ipv4/ipv6 support

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I encountered this on Linux in a VM environment with a rather strange networking setup (both on the host and in the VM). REPOSITORY rHG Mercurial BRANCH

D11883: directaccess: fix uses of commands.status() that don't go through flag parsing

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When `commands.commit.post-status` is enabled, after commit/amend, commands.status() is called without any revs argument, which means that status gets None

D11884: status: when extracting arguments from `opts`, use the same default values

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Sometimes other code, such as commit when using `commands.commit.post-status`, calls `commands.status()` without going through the normal dispatch mechanism

D11734: pyoxidizer: use in-memory resources on non-Windows platforms

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY In-memory resources were disabled for macOS in 7bc1beed , and for all platforms

D11714: tests: fix test-convert-git to work w/ "git pull" requiring strategy

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY A recent change to git (031e2f7ae195) made it an error to not specify a strategy (`--rebase`, `--no-rebase`, `--ff-only`), instead of just the warning it was

D11706: merge-halt: fix issue with merge.on-failure=halt breaking unshelve

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11706 AFFECTED FILES mercurial/merge.py tests/test-merge-halt.t CHANGE DETAILS

D11705: merge-halt: demonstrate unshelve issue with merge.on-failure=halt

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11705 AFFECTED FILES tests/test-merge-halt.t CHANGE DETAILS diff --git

D11698: pyoxidizer: update README.md with several small fixes

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Currently, pyoxidizer.bzl does not mention the git commit that should be checked out, so these instructions are a bit difficult to follow right now

D11697: pyoxidizer: disable using in-memory resources

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It's possible that the errors are due to using an incompatible version of PyOxidizer; unfortunately the README.md file in this directory says to fetch a copy

D11391: filemerge: be more strict when detecting conflict markers, add `|` markers

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I received a user complaint about detecting a line that contained 78 `=` followed by `*/` as a conflict marker. We'll never generate that, we generate 7

D11217: help: correct config.profiling.freq name (frequency->freq)

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11217 AFFECTED FILES mercurial/helptext/config.txt CHANGE DETAILS diff --git

D10539: black: make codebase compatible with black v21.4b2 and v20.8b1

spectral created this revision. Herald added a reviewer: durin42. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I don't know what exact version of black made it care about these whitespace differences, but this is the version I got when

D10537: tests: fix chg tests missed in D10470

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10537 AFFECTED FILES contrib/chg/chg.c tests/test-blackbox.t

D10538: tests: allow trunk versions of clang-format to be used

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10538 AFFECTED FILES tests/hghave.py CHANGE DETAILS diff --git

D10504: dirstateguard: use mktemp-like functionality to generate the backup filenames

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Previously these were generated with names like: `dirstate.backup.commit.` This could cause problems if two hg commands ran at the same time that used

D10469: profiling: add --no-profile to disable profiling enabled via config

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10469 AFFECTED FILES mercurial/dispatch.py tests/test-chg.t CHANGE DETAILS

D10470: chg: pass --no-profile to disable profiling when starting hg serve

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If profiling is enabled via global/user config (as far as I can tell, this doesn't affect use of the --profile flag, but it probably does affect --config

D10468: tests: fix test-chg to ignore a warning about being unable to set locale

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I think this is only enabled on some newer Python versions, which is why this wasn't caught before. REPOSITORY rHG Mercurial BRANCH default REVISION

D6719: branchmap: refresh all "heads" of the branchmap subsets

Herald added a subscriber: mercurial-patches. spectral added a comment. spectral abandoned this revision. I'm apparently not going to resolve the comments, sorry for leaving this open so long. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6719/new/

D10388: split: fix issue with empty splits adjusting phases

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10388 AFFECTED FILES hgext/split.py tests/test-split.t CHANGE DETAILS diff

D10389: split: avoid strip if split is a no-op (identical to original)

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10389 AFFECTED FILES hgext/split.py tests/test-split.t CHANGE DETAILS diff

D10387: split: add test demonstrating issue with empty splits adjusting phases

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10387 AFFECTED FILES tests/test-split.t CHANGE DETAILS diff --git

D10386: tests: avoid use of "python", which may not even be installed

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10386 AFFECTED FILES tests/test-convert-cvs.t tests/test-merge-tools.t CHANGE

D10320: remotefilelog: include file contents in bundles produced during strip

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY `hg strip` and other things that use repair.strip (such as the narrow extension's `hg tracked --removeinclude`) will "save" some commits that have a higher

D10319: tests: add test-remotefilelog-strip.t to demonstrate an issue with linknodes

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Background -- Every time a commit is modified, remotefilelog updates the metadata for the file object to point to the new commit (I believe

D10295: exthelper: improve docs to indicate what module vars are needed

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I recently tried creating an extension "from scratch" using exthelper, and it wasn't obvious that you needed these. I believe that a careful reading of one of

D10294: match: convert O(n) to O(log n) in exactmatcher.visitchildrenset

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When using narrow, during rebase this is called (at least) once per directory in the set of files in the commit being rebased. Every time it's called, we did

D10292: deb: avoid use of [[ in 'rules' file

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It's not supported by posix shell, and apparently my build system uses that. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10020: debian: support a "chg-first" installation mechanism (hg is actually chg)

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This mechanism builds chg such that it looks for `hg` to be available at /usr/lib/mercurial/hg instead of in the $PATH as `hg`, and makes the `hg` in

D9990: gendoc: use an empty comment so aliases are separated from previous elements

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY For commands like `hg bookmarks`, where there's no `[+] marked option can be specified multiple times`, this causes the final option in the option list to

D9989: gendoc: add support for loading extensions from config settings

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We manage our installation and ship some extensions, enabled by default for our users, that are in hgext3rd or other directories not scanned by this tool by

D9988: gendoc: support defaults on customopts a bit better

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Without this, a customopt will very likely render like this: -foo does foo (default: ) I copied this logic from how this is handled in

D9983: packaging: add Provides: python3-mercurial and Homepage to debian package

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY There are other packages that depend on python3-mercurial, like debian's mercurial-git, so we should mark ourselves as providing it. I compared the

D9952: revlog: add a mechanism to verify expected file position before appending

spectral created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If someone uses `hg debuglocks`, or some non-hg process writes to the .hg directory without respecting the locks, or if the

D9953: tests: add a comment in a test that will hopefully save someone some time

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I spent at least an hour, probably closer to 1.5, trying to figure out what this was complaining about. Hopefully anyone else in my position will see this

D9891: wix: tell ComponentSearch that it is finding a directory (not a file)

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is to fix an issue we've noticed where fresh installations start at `C:\Program Files\Mercurial`, and then upgrades "walk up" the tree and end up in

D9729: patch: handle filenames with trailing spaces

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I have no idea if this is *actually* supported by the patch file format, but at least when reading from a patch file created by running `hg shelve`, it is

D9567: copies: make calculating lazy for dir move detection's "addedfiles"

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The information calculated here was only needed if (a) --debug was specified, or (b) a directory move was plausibly detected. With tree manifests (especially

D9553: treemanifest: stop storing full path for each item in manifest._lazydirs

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This information is obtainable, if needed, based on the lazydirs key (which is the entry name) and the manifest's `dir()` method. Performance

D9511: statprof: separate functions and "line", assume 4 digit line numbers

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Previously, the profile output looked like this (I've removed many lines that are mostly inconsequential): | 100.0% 0.02s hg:

D9510: statprof: fix off-by-one-line error in output

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY martinvonz claims they thought that this was intentional, but couldn't remember the reasoning for it. I can't understand why it would be preferable, and I

D9503: copies: avoid materializing a full directory map during copy tracing

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Materializing a full copy of every directory in a treemanifest repo can be quite expensive, even with a narrow matcher. For flat manifest repos, this should

D9488: match: skip walking up the directory hierarchy if the number of pats are small

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Previously, we would receive a path like abc/def/ghi and "walk up" the directory hierarchy, checking abc/def, abc, and `b''` to see if they were in the set of

D9207: record: when backing up, avoid generating very long filenames

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If the original file's path is longer than the individual filename maximum length (256 on Linux, I believe?), then this mechanism of "replace slashes with

D9023: branchmap: add a cache validation cache, avoid expensive re-hash on every use

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY In a pathological `hg log` case, we end up executing the branchmap validity checking twice per commit displayed. Or maybe we always do, and I just noticed

D9022: repo: avoid copying/updating a dict on every `repo.__getitem__`

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This has some mild performance benefits. I'm looking into a pathological case where one of our `hg log` invocations takes several seconds, and according to

D8814: tests: make check-py3-compat.py actually load the specified files correctly

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY For most uses, this change is essentially a no-op, as this script is generally only run by test-check-py3-compat.t, which will already put `$TESTDIR/..` in

D8813: tests: make test-install.t work on debian systems

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Debian systems, at least as of their version of python3.8 on my machine, have rewritten some logic in ensurepip to make it not use the wheels in pip._bundled,

D8812: tests: virtualenv is only used on py2, rename and conditionalize

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If I have I have the Debian `python3-virtualenv` package installed on my machine, the import succeeds but then I receive an AttributeError because the

D8811: morestatus: mention --stop even if not using --verbose

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8811 AFFECTED FILES mercurial/state.py tests/test-absorb-unfinished.t

D8642: debian: support building a single deb for multiple py3 versions

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Around transitions from one python minor version to another (such as 3.7 to 3.8), the current packaging can be slightly problematic - it produces a `control`

D8639: py3: fix broken man page generation, it was generating `(default: NUL*)`

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY `bytes(default)` was producing things like `(default: \x00)` when handed non-bytes values such as `1`, `10`, or `True`. The man page generation would

D8464: locking: wait for locks in `hg cp` and `hg mv`

spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I traced this back to revision 1822 (64df422 ), and there's no explanation why we

D8385: hgk: remove a "b" used on a kwargs expansion, the keys are strs

Closed by commit rHG1756f75873bf: hgk: remove a b used on a kwargs expansion, the keys are strs (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8385: hgk: remove a "b" used on a kwargs expansion, the keys are strs

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8385 AFFECTED FILES hgext/hgk.py CHANGE DETAILS diff --git a/hgext/hgk.py

D8354: histedit: add missing b prefix to a string

Closed by commit rHG8fca7e8449a8: histedit: add missing b prefix to a string (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D8354: histedit: add missing b prefix to a string

spectral created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If i18n is disabled (such as via HGPLAIN=1), `_()` doesn't convert from str to bytes, so this raises a TypeError on py3.

D8321: darwin: use vim, not vi, to avoid data-loss inducing posix behavior

Closed by commit rHGc23877cb25a5: darwin: use vim, not vi, to avoid data-loss inducing posix behavior (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D8321: darwin: use vim, not vi, to avoid data-loss inducing posix behavior

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Apple's version of vim, available at opensource.apple.com/release/macos-1015.html (for Catalina, but this behavior has been there for a while) has several

D8281: narrow: escape includepats/excludepats when sending over the wire

spectral added a comment. In D8281#124247 , @martinvonz wrote: > In D8281#124246 , @spectral wrote: > >> - Server emits a new capability `narrow-exp-1-escaped` (in addition to the current

D8281: narrow: escape includepats/excludepats when sending over the wire

spectral added a comment. In D8281#124129 , @durin42 wrote: > In D8281#124058 , @marmoute wrote: > >> Since narrow is still experimental, I don't think we should try too hard for backward

D8281: narrow: escape includepats/excludepats when sending over the wire

spectral updated this revision to Diff 20819. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8281?vs=20818=20819 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8281/new/ REVISION DETAIL

D8281: narrow: escape includepats/excludepats when sending over the wire

spectral updated this revision to Diff 20818. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8281?vs=20813=20818 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8281/new/ REVISION DETAIL

D8296: chistedit: support histedit.summary-template in curses histedit plan

Closed by commit rHGad5a10f49dfa: chistedit: support histedit.summary-template in curses histedit plan (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D8297: vfs: fix typo in comment (remove extra "l")

Closed by commit rHG77d48738b8e0: vfs: fix typo in comment (remove extra l) (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D8281: narrow: escape includepats/excludepats when sending over the wire

spectral edited the summary of this revision. spectral retitled this revision from "narrow: escape includepats/excludepats when sending over the wire (BC)" to "narrow: escape includepats/excludepats when sending over the wire". spectral updated this revision to Diff 20813. REPOSITORY rHG

D8297: vfs: fix typo in comment (remove extra "l")

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8297 AFFECTED FILES mercurial/vfs.py CHANGE DETAILS diff --git a/mercurial/vfs.py

D8296: chistedit: support histedit.summary-template in curses histedit plan

spectral created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8296 AFFECTED FILES hgext/histedit.py CHANGE

D8294: tests: make test-doctest.t automatically find files to run tests on

Closed by commit rHG0af56d3ee24c: tests: make test-doctest.t automatically find files to run tests on (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D8280: tests: make test-doctest.t module list match reality

Closed by commit rHG529cb23155bc: tests: make test-doctest.t module list match reality (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D8279: tests: remove doctest in narrowspec, it is broken

Closed by commit rHG1922694d638f: tests: remove doctest in narrowspec, it is broken (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D8280: tests: make test-doctest.t module list match reality

spectral added a comment. spectral marked an inline comment as done. In D8280#123642 , @marmoute wrote: > Should we try to move to some automatic detection of file with doctest? That would be more reliable. D8294

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

spectral updated this revision to Diff 20789. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8281?vs=20767=20789 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8281/new/ REVISION DETAIL

D8294: tests: make test-doctest.t automatically find files to run tests on

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8294 AFFECTED FILES tests/test-doctest.py CHANGE DETAILS diff --git

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

spectral added a comment. In D8281#123621 , @mharbison72 wrote: > The Windows path changes seem like a good idea. > Would quoting paths with commas eliminate the need for custom escaping? I don't feel strongly about it, but custom escaping

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

spectral updated this revision to Diff 20767. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8281?vs=20765=20767 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8281/new/ REVISION DETAIL

D8280: tests: make test-doctest.t module list match reality

spectral updated this revision to Diff 20766. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8280?vs=20764=20766 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8280/new/ REVISION DETAIL

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

spectral created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When transmitting data over the wire, first run util.pconvert on each item (this is just

D8280: tests: make test-doctest.t module list match reality

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8280 AFFECTED FILES tests/test-doctest.py CHANGE DETAILS diff --git

D8279: tests: remove doctest in narrowspec, it is broken

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think every item here is considered incorrect (if we fix doctest to run it), so let's just delete it. REPOSITORY rHG Mercurial BRANCH default REVISION

D8140: shelve: fix ordering of merge labels

Closed by commit rHG69b091cdc506: shelve: fix ordering of merge labels (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8140?vs=20273=20275 CHANGES SINCE LAST

D8139: shelve: add test clearly demonstrating that the conflict labels are backwards

Closed by commit rHG2527c10a2569: shelve: add test clearly demonstrating that the conflict labels are backwards (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8140: shelve: fix ordering of merge labels

spectral updated this revision to Diff 20273. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8140?vs=20264=20273 BRANCH stable CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8140/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8140

D8141: darwin: add another preemptive gui() call when using chg

Closed by commit rHG6392bd7c26a8: darwin: add another preemptive gui() call when using chg (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D8141: darwin: add another preemptive gui() call when using chg

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Changeset a89381e04c58 added this gui() call before background forks, and Google's

D8140: shelve: fix ordering of merge labels

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8140 AFFECTED FILES mercurial/shelve.py tests/test-shelve.t

D8139: shelve: add test clearly demonstrating that the conflict labels are backwards

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8139 AFFECTED FILES tests/test-shelve2.t CHANGE DETAILS diff --git

D8023: chg: read CHGORIG_ values from env and handle these appropriately

spectral added a comment. spectral abandoned this revision. We decided to use a different method to resolve this issue. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8023/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8023 To: spectral,

D8091: py3: fully fix bundlepart.__repr__ to return str not bytes

Closed by commit rHG74172a234dd3: py3: fully fix bundlepart.__repr__ to return str not bytes (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8089: py3: __repr__ needs to return str, not bytes

spectral added inline comments. INLINE COMMENTS > mharbison72 wrote in bundle2.py:1018 > Aren't `self.__class__.__module__` and `self.__class__.__name__` str? Yep, so this instance fails for other reasons as well. Sigh. I've sent a followup (D8091 ). This

D8091: py3: fully fix bundlepart.__repr__ to return str not bytes

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY My previous fix did not fully fix the issue: it would attempt to use %-formatting to combine two strs into a bytes, which won't work. Let's just switch the

  1   2   3   4   5   6   7   >