D1506: dagop: handle IndexError when using wdir() in dag range

2017-11-24 Thread swhitaker (Simon Whitaker)
swhitaker created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Using wdir() in a dag range revset can crash Mercurial. For example: hg status --rev '.^::wdir() revlog.c reports an IndexError in this instance, but

D785: context: also consider path conflicts when clearing unknown files

2017-10-16 Thread swhitaker (Simon Whitaker)
swhitaker added inline comments. INLINE COMMENTS > context.py:1941 > +if wvfs.isfileorlink(p): > +wvfs.unlink(p) > +break This breaks test-audit-path.t on macOS. In the test "attack /tmp/test", we call this codepath with f == '/tmp/test'.

D884: dirstate: implement __len__ on dirstatemap (issue5695)

2017-10-01 Thread swhitaker (Simon Whitaker)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7d2f71b7bc31: dirstate: implement __len__ on dirstatemap (issue5695) (authored by swhitaker, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D884: dirstate: implement __len__ on dirstatemap (issue5695)

2017-10-01 Thread swhitaker (Simon Whitaker)
swhitaker created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D884 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git a/mercurial/dirstate.py

D865: obsmarker: crash more helpfully when metadata fields are >255 bytes (issue5681)

2017-10-01 Thread swhitaker (Simon Whitaker)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb6692ba7d5b0: obsmarker: crash more helpfully when metadata fields are 255bytes (issue5681) (authored by swhitaker, committed by ). CHANGED PRIOR TO COMMIT

D865: obsmarker: fix crash when metadata fields are >255 bytes (issue5681)

2017-10-01 Thread swhitaker (Simon Whitaker)
swhitaker updated this revision to Diff 2255. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D865?vs=2229=2255 REVISION DETAIL https://phab.mercurial-scm.org/D865 AFFECTED FILES mercurial/obsolete.py tests/test-obsolete-bounds-checking.t CHANGE

D865: obsmarker: fix crash when metadata fields are >255 bytes

2017-10-01 Thread swhitaker (Simon Whitaker)
swhitaker added a comment. @ikostia Sure, I can change this. What should we do if the metadata value is not under user control? In the case of a username longer than 255 bytes, the user can change that in their hgrc (although it's debatable whether they should; "error, your name is too

D865: obsmarker: fix crash when metadata fields are >255 bytes

2017-10-01 Thread swhitaker (Simon Whitaker)
swhitaker created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Various mutators fail when attempting to write obsmarkers with metadata fields longer than 255 bytes, since the length of mwetadata fields is stored in u8s.

D787: tests: add test for path conflicts during merge

2017-09-29 Thread swhitaker (Simon Whitaker)
swhitaker accepted this revision. swhitaker added a comment. _like_ REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D787 To: mbthomas, #hg-reviewers, swhitaker Cc: swhitaker, mercurial-devel

D786: tests: add test for path conflicts during update

2017-09-29 Thread swhitaker (Simon Whitaker)
swhitaker accepted this revision. swhitaker added a comment. goodjob REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D786 To: mbthomas, #hg-reviewers, swhitaker Cc: swhitaker, mercurial-devel