Re: [PATCH] color: issue warning in yellow

2018-10-18 Thread Yuya Nishihara
On Thu, 18 Oct 2018 06:14:43 -0700, Martin von Zweigbergk wrote: > On Thu, Oct 18, 2018, 05:42 Yuya Nishihara > > On Wed, 17 Oct 2018 15:17:58 +0200, Boris FELD wrote: > > > On 21/08/2018 15:15, Yuya Nishihara wrote: > > > > On Mon, 20 Aug 2018 11:14:23 -0700, Martin von Zweigbergk via > >

Re: [PATCH] color: issue warning in yellow

2018-10-18 Thread Martin von Zweigbergk via Mercurial-devel
On Thu, Oct 18, 2018, 05:42 Yuya Nishihara On Wed, 17 Oct 2018 15:17:58 +0200, Boris FELD wrote: > > On 21/08/2018 15:15, Yuya Nishihara wrote: > > > On Mon, 20 Aug 2018 11:14:23 -0700, Martin von Zweigbergk via > Mercurial-devel wrote: > > >> On Mon, Aug 20, 2018 at 9:26 AM Kyle Lippincott >

Re: [PATCH] color: issue warning in yellow

2018-10-18 Thread Yuya Nishihara
On Wed, 17 Oct 2018 15:17:58 +0200, Boris FELD wrote: > On 21/08/2018 15:15, Yuya Nishihara wrote: > > On Mon, 20 Aug 2018 11:14:23 -0700, Martin von Zweigbergk via > > Mercurial-devel wrote: > >> On Mon, Aug 20, 2018 at 9:26 AM Kyle Lippincott > >> wrote: > >> > >>> Bright/bold yellow should

Re: [PATCH] color: issue warning in yellow

2018-10-17 Thread Boris FELD
On 21/08/2018 15:15, Yuya Nishihara wrote: > On Mon, 20 Aug 2018 11:14:23 -0700, Martin von Zweigbergk via Mercurial-devel > wrote: >> On Mon, Aug 20, 2018 at 9:26 AM Kyle Lippincott wrote: >> >>> Bright/bold yellow should be considered unavailable. "Normal" yellow, >>> which is closer to brown

Re: [PATCH] color: issue warning in yellow

2018-09-05 Thread David Demelier
On Mon, 2018-08-20 at 10:03 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1534290303 -7200 > # Wed Aug 15 01:45:03 2018 +0200 > # Node ID 4144148d7aba13ece916c6f735c791ca3d93a249 > # Parent c62184c6299c09d2e8e7be340f9aee138229cb86 > # EXP-Topic color-warning >

Re: [PATCH] color: issue warning in yellow

2018-08-21 Thread Yuya Nishihara
On Mon, 20 Aug 2018 11:14:23 -0700, Martin von Zweigbergk via Mercurial-devel wrote: > On Mon, Aug 20, 2018 at 9:26 AM Kyle Lippincott wrote: > > > Bright/bold yellow should be considered unavailable. "Normal" yellow, > > which is closer to brown or maybe gold on many screens, is fine. > > >

Re: [PATCH] color: issue warning in yellow

2018-08-20 Thread Martin von Zweigbergk via Mercurial-devel
On Mon, Aug 20, 2018 at 9:26 AM Kyle Lippincott wrote: > Bright/bold yellow should be considered unavailable. "Normal" yellow, > which is closer to brown or maybe gold on many screens, is fine. > Ah, and we already use yellow for a few things (as you also pointed out). Sorry I didn't even

Re: [PATCH] color: issue warning in yellow

2018-08-20 Thread Kyle Lippincott via Mercurial-devel
Bright/bold yellow should be considered unavailable. "Normal" yellow, which is closer to brown or maybe gold on many screens, is fine. At Google, and I think other tools like clang, generally use magenta I believe, but I have no strong preference. Keep in mind that ui.prompt is also yellow a

Re: [PATCH] color: issue warning in yellow

2018-08-20 Thread Martin von Zweigbergk via Mercurial-devel
I think most of us would be happy with this, but I seem to remember Kyle always saying that it will be unreadable for users who use white background. On Aug 20, 2018 01:04, "Boris Feld" wrote: # HG changeset patch # User Boris Feld # Date 1534290303 -7200 # Wed Aug 15 01:45:03 2018 +0200

[PATCH] color: issue warning in yellow

2018-08-20 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1534290303 -7200 # Wed Aug 15 01:45:03 2018 +0200 # Node ID 4144148d7aba13ece916c6f735c791ca3d93a249 # Parent c62184c6299c09d2e8e7be340f9aee138229cb86 # EXP-Topic color-warning # Available At https://bitbucket.org/octobus/mercurial-devel/ #