D2873: remotenames: add functionality to override -B flag of push

Herald added a subscriber: mercurial-patches. This revision now requires changes to proceed. marmoute added a comment. marmoute requested changes to this revision. Baymax does not catch stuff in `Accepted` state, but this diff is over 2 years old, so resubmit if still relevant. REPOSITORY

D2873: remotenames: add functionality to override -B flag of push

smf added a comment. In https://phab.mercurial-scm.org/D2873#52100, @indygreg wrote: > In https://phab.mercurial-scm.org/D2873#52025, @smf wrote: > > > In https://phab.mercurial-scm.org/D2873#52021, @indygreg wrote: > > > > > Looks good! > > > > > > I'm very heavily against

D2873: remotenames: add functionality to override -B flag of push

indygreg added a comment. In https://phab.mercurial-scm.org/D2873#52025, @smf wrote: > In https://phab.mercurial-scm.org/D2873#52021, @indygreg wrote: > > > Looks good! > > > I'm very heavily against this direction. Changing the behavior of push (even in this extension) is

D2873: remotenames: add functionality to override -B flag of push

smf added a comment. In https://phab.mercurial-scm.org/D2873#52021, @indygreg wrote: > Looks good! I'm very heavily against this direction. Changing the behavior of push (even in this extension) is something I've always considered outside the scope of remotenames. Having another

D2873: remotenames: add functionality to override -B flag of push

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Looks good! INLINE COMMENTS > remotenames.py:113 > +else: > +msg = _("bookmark '%s' does not exists on remote") > +raise error.Abort(msg % bookmark) Nit: "exist".

D2873: remotenames: add functionality to override -B flag of push

pulkit added a comment. A gentle reminder for reviewing this series. If this config option gets in, we can use it in infinitepush extension too where for now we have overridden `-B` flag in a hacky way. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2873 To:

D2873: remotenames: add functionality to override -B flag of push

pulkit updated this revision to Diff 7286. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2873?vs=7249=7286 REVISION DETAIL https://phab.mercurial-scm.org/D2873 AFFECTED FILES hgext/remotenames.py

D2873: remotenames: add functionality to override -B flag of push

indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. I'm happy with this feature. But the code needs work around multiple revisions/heads before it can be queued. INLINE COMMENTS > remotenames.py:99 > +bookmark =

D2873: remotenames: add functionality to override -B flag of push

pulkit updated this revision to Diff 7249. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2873?vs=7103=7249 REVISION DETAIL https://phab.mercurial-scm.org/D2873 AFFECTED FILES hgext/remotenames.py tests/test-logexchange.t CHANGE DETAILS diff

D2873: remotenames: add functionality to override -B flag of push

pulkit updated this revision to Diff 7103. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2873?vs=7061=7103 REVISION DETAIL https://phab.mercurial-scm.org/D2873 AFFECTED FILES hgext/remotenames.py tests/test-logexchange.t CHANGE DETAILS diff

D2873: remotenames: add functionality to override -B flag of push

pulkit added a comment. I am not sure the functionality and config names should go to core or not, so I have introduced them in this extension. Also suggestions for better config names are welcome. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2873 To:

D2873: remotenames: add functionality to override -B flag of push

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds a new config option which can be used to override the `-B` flag of push command. If config is set to true, changesets will be pushed to that