D2881: hgweb: refactor multirequest to be a dict of lists

2018-03-19 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG44467a4d472f: hgweb: refactor multirequest to be a dict of lists (authored by indygreg, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2881?vs=7078=7114#toc REPOSITORY rHG

D2881: hgweb: refactor multirequest to be a dict of lists

2018-03-19 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued, thanks. INLINE COMMENTS > request.py:31 > def __init__(self): > # Stores (key, value) 2-tuples. This isn't the most efficient. But we > # don't rely on parameters that much, so it shouldn't be a perf > issue. Deleted this comment in

D2881: hgweb: refactor multirequest to be a dict of lists

2018-03-16 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY ... instead of a list of 2-tuples. This makes key lookups faster. The only downside is we lose total ordering of all entries. But we weren't relying on that