D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-07-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz abandoned this revision. martinvonz added a comment. I think I've now convinced myself that this won't work. Consider these statements: 1. A revset should resolve to the same revisions whatever command it's passed to 2. `hg co X` should check out the "best" node with name X

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-26 Thread yuja (Yuya Nishihara)
yuja added a comment. > I was also thinking we could do that, but it feels like a workaround to me. I think of bookmarks and tags as pointing to specific commits. I think of branches as being many commits. `hg help revisions` says this: > > Any other string is treated as a

Re: D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-26 Thread Yuya Nishihara
> I was also thinking we could do that, but it feels like a workaround to me. > I think of bookmarks and tags as pointing to specific commits. I think of > branches as being many commits. `hg help revisions` says this: > > Any other string is treated as a bookmark, tag, or branch name.

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-15 Thread yuja (Yuya Nishihara)
yuja added a comment. > > This patch strikes me as a Seems-Like-A-Good-Idea-But-Could-Blowup type > > of thing. So, what this patch does is conditionally change the behavior > > of 'log -r' based on the type of object passed in. > > > No, it just allows namespaces to

Re: D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-15 Thread Yuya Nishihara
> > This patch strikes me as a Seems-Like-A-Good-Idea-But-Could-Blowup type > > of thing. So, what this patch does is conditionally change the behavior > > of 'log -r' based on the type of object passed in. > > > No, it just allows namespaces to do that. As I said (or tried to say)

Re: D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-15 Thread Sean Farley
martinvonz (Martin von Zweigbergk) writes: > martinvonz added a comment. > > > In https://phab.mercurial-scm.org/D3715#58729, @smf wrote: > > > --=-=-= > > Content-Type: text/plain > > > > martinvonz (Martin von Zweigbergk) writes: > > > > > martinvonz added a comment. > >

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D3715#58729, @smf wrote: > --=-=-= > Content-Type: text/plain > > martinvonz (Martin von Zweigbergk) writes: > > > martinvonz added a comment. > > > > In https://phab.mercurial-scm.org/D3715#58720, @smf

Re: D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-15 Thread Sean Farley
--=-=-= Content-Type: text/plain martinvonz (Martin von Zweigbergk) writes: > martinvonz added a comment. > > > In https://phab.mercurial-scm.org/D3715#58720, @smf wrote: > > > Sean Farley writes: > > > > > durin42 (Augie Fackler) writes: > > > > > >> durin42 added subscribers:

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-15 Thread smf (Sean Farley)
smf added a comment. It seems I'm having email sending trouble ... going to attempt to send again REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3715 To: martinvonz, #hg-reviewers, durin42 Cc: durin42, smf, lothiraldan, mercurial-devel

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D3715#58726, @martinvonz wrote: > In https://phab.mercurial-scm.org/D3715#58720, @smf wrote: > > > Sean Farley writes: > > > > > durin42 (Augie Fackler) writes: > > > > > >> durin42 added subscribers:

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D3715#58720, @smf wrote: > Sean Farley writes: > > > durin42 (Augie Fackler) writes: > > > >> durin42 added subscribers: lothiraldan, smf, durin42. > >> durin42 accepted this revision as: durin42. > >> durin42

Re: D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-14 Thread Sean Farley
Sean Farley writes: > durin42 (Augie Fackler) writes: > >> durin42 added subscribers: lothiraldan, smf, durin42. >> durin42 accepted this revision as: durin42. >> durin42 added a comment. >> >> >> I'm in favor, but feel like I've got enough conflict of interest I >> shouldn't land the

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-13 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D3715#58383, @durin42 wrote: > I'm in favor, but feel like I've got enough conflict of interest I shouldn't land the patches. > > @smf @lothiraldan this might be of interest to both of you? In

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-13 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D3715#58383, @durin42 wrote: > I'm in favor, but feel like I've got enough conflict of interest I shouldn't land the patches. > > @smf @lothiraldan this might be of interest to both of you? The proposition of

Re: D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-12 Thread Sean Farley
durin42 (Augie Fackler) writes: > durin42 added subscribers: lothiraldan, smf, durin42. > durin42 accepted this revision as: durin42. > durin42 added a comment. > > > I'm in favor, but feel like I've got enough conflict of interest I > shouldn't land the patches. > > @smf @lothiraldan this

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-12 Thread durin42 (Augie Fackler)
durin42 added subscribers: lothiraldan, smf, durin42. durin42 accepted this revision as: durin42. durin42 added a comment. I'm in favor, but feel like I've got enough conflict of interest I shouldn't land the patches. @smf @lothiraldan this might be of interest to both of you?

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-11 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The goal of this commit is to allow namespaces that support multiple nodes per name to also have the name resolve to those multiple nodes in the revset. For