D7835: nodemap: write nodemap data on disk

Closed by commit rHG5962fd0d1045: nodemap: write nodemap data on disk (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7835: nodemap: write nodemap data on disk

marmoute updated this revision to Diff 20016. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7835?vs=19883&id=20016 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7835/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7835 AFFECTED FILE

D7835: nodemap: write nodemap data on disk

marmoute added a comment. marmoute updated this revision to Diff 19883. rebase to latest default REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7835?vs=19825&id=19883 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7835/new/ REVISION DETAI

D7835: nodemap: write nodemap data on disk

marmoute added a comment. marmoute updated this revision to Diff 19825. small doc update on .#s[1] REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7835?vs=19780&id=19825 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7835/new/ REVISION DET

D7835: nodemap: write nodemap data on disk

marmoute updated this revision to Diff 19780. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7835?vs=19751&id=19780 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7835/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7835 AFFECTED FILE

D7835: nodemap: write nodemap data on disk

marmoute updated this revision to Diff 19751. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7835?vs=19425&id=19751 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7835/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7835 AFFECTED FILE

D7835: nodemap: write nodemap data on disk

marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in nodemap.py:49 > and here? this is a series that introduced a lot of new code, so try running > all (previously passing) py3 test at least at the end of the series If you can taje the series starting at D8011

D7835: nodemap: write nodemap data on disk

martinvonz added inline comments. INLINE COMMENTS > martinvonz wrote in nodemap.py:42 > need b'' here and below for py3? not needed here, it seems, because `ProgrammingError` converts it for us REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7835/new/ RE

D7835: nodemap: write nodemap data on disk

martinvonz added inline comments. INLINE COMMENTS > nodemap.py:50-51 > +# store vfs > +with revlog.opener(revlog.nodemap_file, 'w') as f: > +f.write(data) > +# EXP-TODO: if the transaction abort, we should remove the new data and Actually, does `revlog.opener.write(revlog.nod

D7835: nodemap: write nodemap data on disk

martinvonz added inline comments. INLINE COMMENTS > nodemap.py:42 > +raise error.ProgrammingError( > +"cannot persist nodemap of a filtered changelog" > +) need b'' here and below for py3? > nodemap.py:49 > +# EXP-TODO: if this is a cache, this should use a cache

D7835: nodemap: write nodemap data on disk

marmoute updated this revision to Diff 19425. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7835?vs=19185&id=19425 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7835/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7835 AFFECTED FILE

D7835: nodemap: write nodemap data on disk

marmoute updated this revision to Diff 19185. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7835?vs=19172&id=19185 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7835/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7835 AFFECTED FILE

D7835: nodemap: write nodemap data on disk

marmoute updated this revision to Diff 19172. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7835?vs=19155&id=19172 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7835/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7835 AFFECTED FILE

D7835: nodemap: write nodemap data on disk

marmoute created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Let us start writing data on disk (so that we can read it from there later). This series of changeset is going to focus first o