D618: largefiles: remove unused assignments from wrapfunction()

lothiraldan added a comment. In https://phab.mercurial-scm.org/D618#10161, @mharbison72 wrote: > Is it acceptable to move the exthelper stuff in evolve into the core somewhere? The fact that there are so many functions and commands wrapped in largefiles makes it harder to read the

D542: effectflag: document effect flag

lothiraldan added a comment. @quark Thank you for reposting your comment here, it's helpful to not lose track on all these discussions. We've had this experiment in Evolve for a little while now and the users using it are giving positive feedback. The next step is to upstream it in

D555: cmdutil: allow extra properties to be added to each context

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbe1fcffe651f: cmdutil: allow extra properties to be added to each context (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D556: show: pass the minimum length for nodes as a template keyword

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb93658d7b2d5: show: pass the minimum length for nodes as a template keyword (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D558: show: use consistent (and possibly shorter) node lengths

This revision was automatically updated to reflect the committed changes. Closed by commit rHG98010c7a5745: show: use consistent (and possibly shorter) node lengths (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D477: revlog: add option to mmap revlog index

mbthomas added a comment. I had put the numbers in the commit message, but that doesn't update the Phabricator summary, so I've done that manually. It should be clear from the numbers that the improvement only really surfaces when the filesystem cache is warm, and there is a penalty for

D477: revlog: add option to mmap revlog index

durin42 requested changes to this revision. durin42 added a comment. This revision now requires changes to proceed. Please include benchmark numbers in your commit message. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D477 To: mbthomas, #fbhgext, indygreg,

Re: 4.4 Sprint Planning

> On Sep 14, 2017, at 01:16, Gregory Szorc wrote: > > Thank you and Kostia for volunteering to organize things on the ground! The > sprints can be chaotic and I'm sure you'll make great masters-of-ceremony. +1 > > While the draft schedule seems very reasonable (I'd

D529: uncommit: move fb-extension to core which uncommits a changeset

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd01819c8f3c4: uncommit: move fb-extension to core which uncommits a changeset (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D614: registrar: make cmdtype an attribute of the function in registar.command

durin42 added inline comments. INLINE COMMENTS > dispatch.py:491 > def __getattr__(self, name): > -adefaults = {r'norepo': True, > +adefaults = {r'norepo': True, r'cmdtype': 'unrecoverable', > r'optionalrepo': False, r'inferrepo': False} Shouldn't this

Re: [PATCH] revlog: update signature of dummy addgroup() in bundlerepo and unionrepo

On Sat, Sep 16, 2017 at 12:14:50AM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1505487525 -32400 > # Fri Sep 15 23:58:45 2017 +0900 > # Node ID 18004bf555f8c1087753ab3ca3a16741c0ce6482 > # Parent

D696: registrar: add a enum 'cmdtype' for the type of the command

yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. To make it less controversial, I would move these constants to registrar.command class and rename them to lowercaseconstants. The registrar provides semi-public API, which should

D663: dirstate: perform transactions with _map using single call, where possible

yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D663 To: mbolin, #hg-reviewers, phillco, yuja Cc: yuja, phillco, mercurial-devel

D715: repair: preserve phase also when not using generaldelta (issue5678)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG91f0677dc920: repair: preserve phase also when not using generaldelta (issue5678) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D663: dirstate: perform transactions with _map using single call, where possible

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6d734a3a76e2: dirstate: perform transactions with _map using single call, where possible (authored by mbolin, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[PATCH] revlog: update signature of dummy addgroup() in bundlerepo and unionrepo

# HG changeset patch # User Yuya Nishihara # Date 1505487525 -32400 # Fri Sep 15 23:58:45 2017 +0900 # Node ID 18004bf555f8c1087753ab3ca3a16741c0ce6482 # Parent 98010c7a5745e1b47bf17268ef023338d5989274 revlog: update signature of dummy addgroup() in bundlerepo and unionrepo

D714: tests: add test for issue5678

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb5d7e7d5c573: tests: add test for issue5678 (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D714?vs=1832=1846 REVISION

[PATCH buildfix] tests: fix test-uncommit.t to not rely on GNU rm's flags behavior

# HG changeset patch # User Augie Fackler # Date 1505502693 14400 # Fri Sep 15 15:11:33 2017 -0400 # Node ID 042b6de785af1dd5a65c4cc7202d8a1004ab # Parent 99a25fd51eee06baf00117114f84b630dd75f15e tests: fix test-uncommit.t to not rely on GNU rm's flags behavior

[PATCH buildfix v2] tests: fix test-uncommit.t to not rely on GNU rm's flags behavior

# HG changeset patch # User Augie Fackler # Date 1505502693 14400 # Fri Sep 15 15:11:33 2017 -0400 # Node ID 933ca2b610855d7479a2514e81b5eb9ad1c13cb4 # Parent 99a25fd51eee06baf00117114f84b630dd75f15e tests: fix test-uncommit.t to not rely on GNU rm's flags behavior

D722: obsmarker: track operation by default

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We added support for including the operation responsible for creating the obsmarker in

D723: templates: introduce a obsfateoperation() function

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D723 AFFECTED FILES mercurial/obsutil.py mercurial/templater.py tests/test-obsmarker-template.t

D674: filemerge: use arbitraryfilectx for backup files

phillco planned changes to this revision. phillco added a comment. Putting back in my queue -- still have two comments of Martin's to respond to. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D674 To: phillco, #hg-reviewers Cc: sid0, martinvonz, mercurial-devel

[PATCH buildfix-svn] tests: fix test-convert-hg-svn.t for e34abf9e8c

# HG changeset patch # User Augie Fackler # Date 1505503981 14400 # Fri Sep 15 15:33:01 2017 -0400 # Node ID 6527d101d236a8e54225772f077f3a175bf17b75 # Parent 99a25fd51eee06baf00117114f84b630dd75f15e tests: fix test-convert-hg-svn.t for e34abf9e8c For some reason this

Re: [PATCH buildfix v2] tests: fix test-uncommit.t to not rely on GNU rm's flags behavior

On Fri, Sep 15, 2017 at 12:16 PM, Augie Fackler wrote: > > # HG changeset patch > # User Augie Fackler > # Date 1505502693 14400 > # Fri Sep 15 15:11:33 2017 -0400 > # Node ID 933ca2b610855d7479a2514e81b5eb9ad1c13cb4 > # Parent

D477: revlog: add option to mmap revlog index

durham added a comment. Also, the improvements should become more pronounced if we fix some algorithms (like phases) that access really old commits. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D477 To: mbthomas, #fbhgext, indygreg, #hg-reviewers, durin42,

mercurial@34142: 15 new changesets

15 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/82bd4c5a81e5 changeset: 34128:82bd4c5a81e5 user:Yuya Nishihara date:Sun Sep 10 23:37:14 2017 +0900 summary: extensions: fix wrapcommand/function of class instance

D724: templater: extract shortest() logic from template function

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It can be useful for extensions to be able to produce the shortest unambiguous hash. That logic is currently inside the shortest() template function. Let's

Re: [PATCH windows] tests: add and remove some (glob) markers

> On Sep 15, 2017, at 22:08, Augie Fackler wrote: > > # HG changeset patch > # User Augie Fackler > # Date 1505527705 14400 > # Fri Sep 15 22:08:25 2017 -0400 > # Node ID 0da0e691552a428641c75e1633e5f1d0fbf3483e > # Parent

mercurial@34145: 3 new changesets (3 on stable)

3 new changesets (3 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/b5d7e7d5c573 changeset: 34143:b5d7e7d5c573 branch: stable parent: 34090:987a85c42b08 user:Martin von Zweigbergk date:Thu Sep 14 11:16:47 2017 -0700 summary:

[PATCH windows] tests: add and remove some (glob) markers

# HG changeset patch # User Augie Fackler # Date 1505527705 14400 # Fri Sep 15 22:08:25 2017 -0400 # Node ID 0da0e691552a428641c75e1633e5f1d0fbf3483e # Parent 209120041d12b524648fa856732aa404dfedd91d tests: add and remove some (glob) markers I have no idea if these

Re: [PATCH windows] tests: add and remove some (glob) markers

On Fri, 15 Sep 2017 22:08:45 -0400, Augie Fackler wrote: # HG changeset patch # User Augie Fackler # Date 1505527705 14400 # Fri Sep 15 22:08:25 2017 -0400 # Node ID 0da0e691552a428641c75e1633e5f1d0fbf3483e # Parent

Re: [PATCH windows] tests: add and remove some (glob) markers

On Fri, 15 Sep 2017 22:14:31 -0400, Augie Fackler wrote: On Sep 15, 2017, at 22:08, Augie Fackler wrote: # HG changeset patch # User Augie Fackler # Date 1505527705 14400 # Fri Sep 15 22:08:25 2017 -0400 # Node ID

D542: effectflag: document effect flag

quark requested changes to this revision. quark added a comment. This revision now requires changes to proceed. In https://phab.mercurial-scm.org/D542#11973, @lothiraldan wrote: > @quark Thank you for reposting your comment here, it's helpful to not lose track > on all these

D612: command: add a cmdtype argument to registrar.command

quark added subscribers: indygreg, quark. quark added a comment. I think @indygreg has some ideas around making "read-only" vs "writable" repo objects. I personally think it's cleaner to make this repo level. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D612

Re: [PATCH stable] ssh: fix flakey ssh errors on BSD systems

On Fri, Sep 15, 2017 at 2:32 PM, Augie Fackler wrote: > # HG changeset patch > # User Durham Goode > # Date 1505170758 25200 > # Mon Sep 11 15:59:18 2017 -0700 > # Branch stable > # Node ID 7d51e7a6ca176e3de6a8f1c4881afacbf4687487 > # Parent

D477: revlog: add option to mmap revlog index

quark added a comment. In https://phab.mercurial-scm.org/D477#12028, @mbthomas wrote: > I had put the numbers in the commit message, but that doesn't update the Phabricator summary, so I've done that manually. I think you were using `arc` and can use `hg phabsend` to get the

[PATCH stable] ssh: fix flakey ssh errors on BSD systems

# HG changeset patch # User Durham Goode # Date 1505170758 25200 # Mon Sep 11 15:59:18 2017 -0700 # Branch stable # Node ID 7d51e7a6ca176e3de6a8f1c4881afacbf4687487 # Parent 91f0677dc92028e4778f58adf365940fbed48fa9 ssh: fix flakey ssh errors on BSD systems This is a trivial

Re: [PATCH buildfix-svn] tests: fix test-convert-hg-svn.t for e34abf9e8c

On Fri, Sep 15, 2017 at 12:34 PM, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1505503981 14400 > # Fri Sep 15 15:33:01 2017 -0400 > # Node ID 6527d101d236a8e54225772f077f3a175bf17b75 > # Parent

Re: D529: uncommit: move fb-extension to core which uncommits a changeset

We've had some discussion about this on irc. The evolve behavior of preserving empty commits is important in one circumstance: when the commit will briefly be empty, but should retain its identity for the purposes of evolution. Personally, I've never used uncommit and ended up with an empty

D724: templater: extract shortest() logic from template function

martinvonz updated this revision to Diff 1860. martinvonz edited the summary of this revision. Herald added a reviewer: indygreg. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D724?vs=1859=1860 REVISION DETAIL https://phab.mercurial-scm.org/D724

D724: templater: extract shortest() logic from template function

martinvonz added a comment. In https://phab.mercurial-scm.org/D724#12091, @quark wrote: > It might make sense to be a revlog method if we don't really care about the "cleanness" of revlog class. I slightly prefer that. Heh, that's what I decided to do. I apparently forgot to send

D722: obsmarker: track operation by default

quark accepted this revision. quark added a comment. I think we do need this information recorded. Previous discussion suggests 10% increase in obsstore size is bad. But the current obsstore format has other stupid repetitive information like "user". So I won't blame this patch. REPOSITORY

[PATCH 6 of 8 py3] drawdag: tagsmod.tag() takes a list of names, not a single name

# HG changeset patch # User Augie Fackler # Date 1503465841 14400 # Wed Aug 23 01:24:01 2017 -0400 # Node ID 6780213e5a48edeef40d6fa24ef5cb939de8abdc # Parent 370f8212917c1af7e6189d3f0a7ca59ec49d1a4a drawdag: tagsmod.tag() takes a list of names, not a single name We were

[PATCH 8 of 8 py3] drawdag: port to python 3

# HG changeset patch # User Augie Fackler # Date 1503465796 14400 # Wed Aug 23 01:23:16 2017 -0400 # Node ID d08554602cdbd245ddd213af325473da037a240f # Parent 962f6b24541c419fc135ebd75de8529344d85d31 drawdag: port to python 3 diff --git a/tests/drawdag.py

[PATCH 1 of 8 py3] bundle2: raise a more helpful error if building a bundle part header fails

# HG changeset patch # User Augie Fackler # Date 1505515049 14400 # Fri Sep 15 18:37:29 2017 -0400 # Node ID 662bbd6d96952985eff807f424dd128663724672 # Parent 209120041d12b524648fa856732aa404dfedd91d bundle2: raise a more helpful error if building a bundle part header

[PATCH 5 of 8 py3] bruterebase: port to python 3

# HG changeset patch # User Augie Fackler # Date 1503465779 14400 # Wed Aug 23 01:22:59 2017 -0400 # Node ID 370f8212917c1af7e6189d3f0a7ca59ec49d1a4a # Parent 050dd624a9a887c3efde65b7750311d3d3bd716c bruterebase: port to python 3 diff --git a/tests/bruterebase.py

[PATCH 7 of 8 py3] drawdag: add a couple of doctests to help with python3 porting

# HG changeset patch # User Augie Fackler # Date 1503499886 14400 # Wed Aug 23 10:51:26 2017 -0400 # Node ID 962f6b24541c419fc135ebd75de8529344d85d31 # Parent 6780213e5a48edeef40d6fa24ef5cb939de8abdc drawdag: add a couple of doctests to help with python3 porting diff

[PATCH 3 of 8 py3] exchange: use '%d' % x instead of str(x) to encode ints

# HG changeset patch # User Augie Fackler # Date 1503451273 14400 # Tue Aug 22 21:21:13 2017 -0400 # Node ID e6d61e2a38873be057c9ecd0432750935423d745 # Parent 43b1c3ab1d6a4af1ea86f4e9d676d52740782895 exchange: use '%d' % x instead of str(x) to encode ints Recommended by

[PATCH 2 of 8 py3] bundles: turn nbchanges int into a bytestr using pycompat.bytestr

# HG changeset patch # User Augie Fackler # Date 1505515116 14400 # Fri Sep 15 18:38:36 2017 -0400 # Node ID 43b1c3ab1d6a4af1ea86f4e9d676d52740782895 # Parent 662bbd6d96952985eff807f424dd128663724672 bundles: turn nbchanges int into a bytestr using pycompat.bytestr Fixes

[PATCH 4 of 8 py3] repair: reliably obtain bytestr of node ids

# HG changeset patch # User Augie Fackler # Date 1503451354 14400 # Tue Aug 22 21:22:34 2017 -0400 # Node ID 050dd624a9a887c3efde65b7750311d3d3bd716c # Parent e6d61e2a38873be057c9ecd0432750935423d745 repair: reliably obtain bytestr of node ids diff --git

D724: templater: extract shortest() logic from template function

quark accepted this revision. quark added a comment. It might make sense to be a revlog method if we don't really care about the "cleanness" of revlog class. I slightly prefer that. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D724 To: martinvonz,

D723: templates: introduce a obsfateoperation() function

quark accepted this revision. quark added a comment. I think this is a good step forward. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D723 To: martinvonz, #hg-reviewers, quark Cc: quark, mercurial-devel ___

D723: templates: introduce a obsfateoperation() function

martinvonz updated this revision to Diff 1861. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D723?vs=1858=1861 REVISION DETAIL https://phab.mercurial-scm.org/D723 AFFECTED FILES mercurial/obsutil.py mercurial/templater.py

[PATCH 3 of 4 python3] posix: use slicing to grab a single byte out of a bytes in HFS+ normcase code

# HG changeset patch # User Augie Fackler # Date 1505519045 14400 # Fri Sep 15 19:44:05 2017 -0400 # Node ID 8a1f211ac2afb3e49a15def443b7f556ee3c0d47 # Parent 33c529f19fdf5dbecc7e2853e8eabaac4cc347e2 posix: use slicing to grab a single byte out of a bytes in HFS+ normcase

[PATCH 2 of 4 python3] encoding: ensure getutf8char always returns a bytestr, never an int

# HG changeset patch # User Augie Fackler # Date 1505519012 14400 # Fri Sep 15 19:43:32 2017 -0400 # Node ID 33c529f19fdf5dbecc7e2853e8eabaac4cc347e2 # Parent 34469e4e2187381259d78ec0a35c2dd5b0e9e85a encoding: ensure getutf8char always returns a bytestr, never an int diff

[PATCH 4 of 4 python3] posix: always pass a native str to unicodedata.normalize's first arg

# HG changeset patch # User Augie Fackler # Date 1505519072 14400 # Fri Sep 15 19:44:32 2017 -0400 # Node ID 4fd8345c78af58b6303a06590a83b8fd6c8fa00f # Parent 8a1f211ac2afb3e49a15def443b7f556ee3c0d47 posix: always pass a native str to unicodedata.normalize's first arg

[PATCH 1 of 4 python3] posix: fix HFS+ normcase doctest to produce valid bytes literals in Python 3

# HG changeset patch # User Augie Fackler # Date 1505518982 14400 # Fri Sep 15 19:43:02 2017 -0400 # Node ID 34469e4e2187381259d78ec0a35c2dd5b0e9e85a # Parent d08554602cdbd245ddd213af325473da037a240f posix: fix HFS+ normcase doctest to produce valid bytes literals in