On Wed, 31 Jan 2018 23:30:02 -0500, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1517457704 18000
> # Wed Jan 31 23:01:44 2018 -0500
> # Branch stable
> # Node ID 844666bf1f9e995e47f38a72fd7ad69a83601628
> # Parent
On Thu, 01 Feb 2018 18:28:37 +0800, Anton Shestakov wrote:
> # HG changeset patch
> # User Anton Shestakov
> # Date 1517474772 -28800
> # Thu Feb 01 16:46:12 2018 +0800
> # Branch stable
> # Node ID 2c33f6442935b2a835461a50a4fc01c5651c3429
> # Parent
On Wed, 31 Jan 2018 23:28:53 -0500, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1517166539 18000
> # Sun Jan 28 14:08:59 2018 -0500
> # Branch stable
> # Node ID 1cb013a6f74e22a1867962bdd9a810c787dd4944
> # Parent
durin42 updated this revision to Diff 5040.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1885?vs=4946=5040
REVISION DETAIL
https://phab.mercurial-scm.org/D1885
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git a/mercurial/commands.py
durin42 updated this revision to Diff 5039.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1883?vs=4873=5039
REVISION DETAIL
https://phab.mercurial-scm.org/D1883
AFFECTED FILES
tests/run-tests.py
CHANGE DETAILS
diff --git a/tests/run-tests.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame because it's just some bytes prefixes
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1964
AFFECTED FILES
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame because this is bytes prefixes and a s/iteritems/items/
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1963
AFFECTED
durin42 updated this revision to Diff 5042.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1892?vs=4882=5042
REVISION DETAIL
https://phab.mercurial-scm.org/D1892
AFFECTED FILES
mercurial/bundlerepo.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 5041.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1886?vs=4947=5041
REVISION DETAIL
https://phab.mercurial-scm.org/D1886
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git a/mercurial/commands.py
durin42 updated this revision to Diff 5044.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1899?vs=4951=5044
REVISION DETAIL
https://phab.mercurial-scm.org/D1899
AFFECTED FILES
mercurial/localrepo.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 5043.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1898?vs=4950=5043
REVISION DETAIL
https://phab.mercurial-scm.org/D1898
AFFECTED FILES
mercurial/localrepo.py
CHANGE DETAILS
diff --git
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The HTTP wire protocol server / response handler is currently defined
in the hgweb sub-package. That only kind of makes sense. hgweb does
contain most of the
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Importing hgweb.common requires importing hgweb.
hgweb/__init__.py contains a bit of code and does imports of large
parts of the hgweb.* module tree.
All
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
In the context of multiple handlers, call() is ambiguous.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1966
AFFECTED FILES
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Let's have the interface live next to things that define it.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1969
AFFECTED FILES
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Our custom server has too many heads to announce (one per code review,
plus a public head), but it still lets the user request one of them by
doing
hg
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb3deff73887c: contrib: fix dirstatenonnormalcheck to work
in Python 3 (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Let's welcome the SSH protocol handler to our new central home
for protocol handlers.
.. api::
Content from mercurial.sshserver has been moved into
4 new changesets (4 on stable) in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/91c8d2e763d1
changeset: 35817:91c8d2e763d1
branch: stable
parent: 35806:ab239e3de23b
user:Wagner Bruna
date:Wed Jan 31 19:41:34 2018 -0200
summary:
9 new changesets (9 on stable) in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/178aacdc25db
changeset: 35808:178aacdc25db
branch: stable
user:Gregory Szorc
date:Mon Jan 29 13:30:29 2018 -0800
summary: configitems: traverse sections
> On Jan 31, 2018, at 11:57, Boris Feld wrote:
>
> On Tue, 2018-01-30 at 17:02 -0500, Augie Fackler wrote:
>>
>>
>>> On Jan 30, 2018, at 17:00, Boris Feld wrote:
>>> After chatting on IRC with Gregory about this, here is a detailed list of
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf4faae661968: revsetlang: fix a doctest example on Python 3
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Due to a bug that will be fixed in the next patch, we never actually
read back .testcases, so we didn't notice that it could not be parsed
successfully when
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
When using #testcases, the lines that read something like
ERROR: test-split.t (case obsstore-off) output changed
get colored red and the filename
New changeset (1 on stable) in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/4425790f2373
changeset: 35807:4425790f2373
branch: stable
bookmark:@
tag: tip
user:Matt Harbison
date:Mon Jan 29 21:42:18 2018 -0500
summary: lfs:
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We attempt to write the 5 most recent test timings to a file called
.testtimes, but we read previous results from a file called
.testtimes- (including the
martinvonz added a comment.
I wrote this patch before https://phab.mercurial-scm.org/D1959, but perhaps I
should rebase it on top of that and reuse the same regex for matching the test
case?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1960
To: martinvonz,
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a redo of https://phab.mercurial-scm.org/D1963 that has the added
benefit of not breaking
Python 2. Oops.
1. skip-blame because this is bytes
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1971
AFFECTED FILES
contrib/perf.py
tests/test-contrib-perf.t
CHANGE DETAILS
diff --git
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I want to optimize splitnewlines, so writing tests seems prudent.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1972
AFFECTED
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
./hg perfunidiff mercurial/manifest.py 0 --count 500 --profile before:
! wall 0.309280 comb 0.35 user 0.29 sys 0.06 (best of 32)
./hg perfunidiff
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2f7ab4fb7711: tests: allow [Errno] in output (authored by
indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1958?vs=5032=5087
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG568917059243: testrunner: make reading of test times work
with #testcases (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
These tests predate the testcases functionality in run-tests.py, so it
was never done in narrowhg.
REPOSITORY
rHG Mercurial
REVISION DETAIL
durin42 updated this revision to Diff 5115.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1970?vs=5080=5115
REVISION DETAIL
https://phab.mercurial-scm.org/D1970
AFFECTED FILES
contrib/dirstatenonnormalcheck.py
mercurial/dirstate.py
CHANGE DETAILS
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is portable to Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1992
AFFECTED FILES
mercurial/mdiff.py
CHANGE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf45076c52e41: context: use native string when peeking in
__dict__ (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG09140fb0de22: dirstate: use native strings when peeking in
__dict__ (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0851cbd422ae: smartset: use native string when peeking in
__dict__ (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGfd46deec0841: tests: bytestring-ify all the adhoc
extensions in test-strip.t (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG73183301a1d3: bundlerepo: use native str when peeking in
__dict__ (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5a34d8b667c1: localrepo: consistently use native str when
__dict__ is involved (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3cec0055969b: obsolete: use native string when peeking in
__dict__ (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG99ffac2da488: lsprof: use native string when peeking in
__dict__ (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa07f727a7eb1: transaction: fix hg version check when
loading journal (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd9ae54f7eed6: branchmap: make error messages consistent
between Python 2 and 3 (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG81c3ad368574: testrunner: on error, color the (case
xxx) part the same as filename (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG577a4d267e0f: mq: use bytes() instead of str() to encode
statusentries for writing (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz added inline comments.
INLINE COMMENTS
> martinvonz wrote in strip.py:218
> I would expect "%d" with a revision number (such as uctx.rev()). I saw that
> that's also what Yuya suggested on https://phab.mercurial-scm.org/D1884.
> Fixing in flight.
Oh, that's done in the next patch
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1976
AFFECTED FILES
hgext/narrow/narrowbundle2.py
CHANGE DETAILS
diff --git
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Adjustments:
- renamed src to hgext/narrow
- marked extension experimental
- added correct copyright header where it was missing
- updated hgrc extension
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1977
AFFECTED FILES
hgext/narrow/narrowrevlog.py
CHANGE DETAILS
diff --git
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1978
AFFECTED FILES
hgext/narrow/narrowrevlog.py
CHANGE DETAILS
diff --git
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1975
AFFECTED FILES
hgext/narrow/__init__.py
CHANGE DETAILS
diff --git a/hgext/narrow/__init__.py
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I'd be curious if there is a perf hit to this. The slicing API is a bit more
involved than `__getitem__` at the C layer. But since this is Python code, my
guess is run time is
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1994
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git a/mercurial/commands.py
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3ebff846f752: filemerge: fix regular expression pattern to
be bytes (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG435547be7257: tests: get run-tests to reliably hand
shellquote a string and not a bytes (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG58aa5adc7d90: tags: explicitly grab list of dict keys
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1887?vs=4877=5056
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG81ee8d21f0d1: commands: replace map() with list
comprehension (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa7ba11fbdd4b: commands: rewrite legacy ternary operator
hack using modern syntax (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0341b4c5665e: python3: whitelist another 7 passing tests
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1900?vs=4890=5070
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG177eb3847a0a: mq: open status file et al in bytes mode
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1902?vs=4909=5072
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG94e124e3db1e: python3: whitelist an additional 23 passing
tests (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd5030224cada: tests: fix a missed b prefix in a test
extension in test-strip.t (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0ba365937220: mq: fix up statusentry to be both repr()-able
and bytes()-able (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa630fc9cc674: localrepo: pass transaction kwargs as
strings, not bytes (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG24dd168d712a: revlog: correct type in check to verify
rawtext is immutable (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://bz.mercurial-scm.org/show_bug.cgi?id=5780
Bug ID: 5780
Summary: hg incoming --bundle --quiet uses debilitating amounts
of RAM on large repos
Product: Mercurial
Version: 4.4.2
Hardware: PC
OS: Linux
indygreg added subscribers: yuja, indygreg.
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
This looks mostly good. Needs some minor tweaks. Some of my comments are
informative and can probably be ignored as far as
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG204435ef0a6f: perf: add a perfunidiff command for
benchmarking unified diff speed (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg added a comment.
I glanced at the code and found the first set of needed follow-ups.
INLINE COMMENTS
> __init__.py:11-14
> +from mercurial import __version__
> +if __version__.version < '3.7':
> +raise ImportError(
> +'narrowhg requires mercurial 3.7 or newer')
This
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG41f952d10905: strip: use in-place revset formatspec instead
of %-formatting ourselves (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG81a00cd2a6e5: strip: use %d for known-int string
interpolation (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
New changeset in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/34287c2e3fc4
changeset: 35821:34287c2e3fc4
bookmark:@
tag: tip
parent: 35793:4fb2bb61597c
parent: 35820:1d60ad093792
user:Augie Fackler
date:Thu Feb 01 14:28:45 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG32675dbbec99: testrunner: fix updating of .testtimes file
(authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd34a01d55133: wireprotoserver: move abstractserverproto
class from wireproto (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa3a1ffcf5f8c: wireprotoserver: dont import symbol
from hgweb.common (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG86196f91fee8: wireprotoserver: rename call to callhttp
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1966?vs=5046=5091
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1aa42928bb47: wireprotoserver: rename hgweb.protocol to
wireprotoserver (API) (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe28ae1f4b194: wireprotoserver: move sshserver into module
(API) (authored by indygreg, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D1968?vs=5048=5094#toc
REPOSITORY
rHG
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
AFAICT sshserver.lock is unused. The last caller of it disappeared
in https://phab.mercurial-scm.org/rHG9f6e0e7ef82884e3ec66455dac7312820c2b35ce
~18 months ago
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
These aren't part of the protocol interface. So they should be
_ prefixed.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1984
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
sshserver attempts to conform to a well-defined interface. The instance
attributes changed as part of this commit don't appear to be part of
that interface. So
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Plug in the abc module so we can have run-time validation of type
conformance.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
AFAICT the last consumer of this helper method was removed by
https://phab.mercurial-scm.org/rHGd054cc5c77370c345a0c41a002b2ce0aada45389 in
2010.
REPOSITORY
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The send* methods are specific to sshserver and aren't part of the
common protocol interface. So rename them accordingly.
The handlers dict is also specific
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Old versions of wire protocol handlers relied on methods
named do_ to handle wire protocol commands. The last
definition of these methods on sshserver was
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a required part of the interface. Abstract properties must
be defined at type creation time. So we make name a @property.
REPOSITORY
rHG Mercurial
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
To aid readability. And to make it easier to search the code base
for protocol instances.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Let's make this file slightly easier to read.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1981
AFFECTED FILES
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I think the last use of this attribute was removed by
https://phab.mercurial-scm.org/rHG2f8adc60e01328523052b1829ca9846ec1285f60
in 2010.
REPOSITORY
rHG
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Using raw strings away from the consumer is a bit weird. But this is a minor
nit.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1896
To: durin42,
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I initially thought this would have test fallout. But since we're using a
batch command to issue the `heads` wire protocol command, it won't show up in
HTTP logs. We'd only catch it in
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG98b746a1ebe3: setdiscovery: dont call
heads wire command when heads specified (authored by martinvonz,
committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz added inline comments.
INLINE COMMENTS
> strip.py:218
> # between the working context and uctx
> -descendantrevs = repo.revs("%s::." % uctx.rev())
> +descendantrevs = repo.revs("%s::.", uctx.rev())
> changedfiles = []
I would expect
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa9d07bd8f758: mdiff: explicitly compute places for the
newline marker (authored by joerg.sonnenberger, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6a33e81e4c5e: mdiff: remove rewindhunk by yielding a bool
first to indicate data (authored by joerg.sonnenberger, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG079b27b5a869: patch: avoid repeated binary checks if all
files in a patch are text (authored by joerg.sonnenberger, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Nice.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1971
To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
1 - 100 of 150 matches
Mail list logo