D4521: narrow: add narrow and ellipses as server capabilities

2018-09-11 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 10875. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4521?vs=10860=10875 REVISION DETAIL https://phab.mercurial-scm.org/D4521 AFFECTED FILES

D4520: narrow: build the known set of nodes only when ellipses is enabled

2018-09-11 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 10874. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4520?vs=10859=10874 REVISION DETAIL https://phab.mercurial-scm.org/D4520 AFFECTED FILES

D4374: narrowspec: fix a typoed 'supported'

2018-09-11 Thread pulkit (Pulkit Goyal)
pulkit added a comment. This should be good to go. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4374 To: pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D4371: treemanifest: use visitchildrenset when doing a walk

2018-09-11 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3ba9ef0fb693: treemanifest: use visitchildrenset when doing a walk (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4341: sparse: add local files to temporaryfiles if they exist out of sparse

2018-09-11 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 10877. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4341?vs=10503=10877 REVISION DETAIL https://phab.mercurial-scm.org/D4341 AFFECTED FILES mercurial/sparse.py

D4370: treemanifest: use visitchildrenset when filtering a manifest to a matcher

2018-09-11 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued, thanks. > +def _loadchildrensetlazy(self, visit): > +if not visit: > +return None > +if visit == 'all' or visit == 'this': > +self._loadalllazy() > +return None > + > +todel

D4340: tests: show that merging with sparse is broken when rename is involved

2018-09-11 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 10876. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4340?vs=10488=10876 REVISION DETAIL https://phab.mercurial-scm.org/D4340 AFFECTED FILES tests/test-sparse-merges.t CHANGE DETAILS diff --git

Re: D4370: treemanifest: use visitchildrenset when filtering a manifest to a matcher

2018-09-11 Thread Yuya Nishihara
Queued, thanks. > +def _loadchildrensetlazy(self, visit): > +if not visit: > +return None > +if visit == 'all' or visit == 'this': > +self._loadalllazy() > +return None > + > +todel = [] > +for k in visit: > +

D4370: treemanifest: use visitchildrenset when filtering a manifest to a matcher

2018-09-11 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG154e4f84b51c: treemanifest: use visitchildrenset when filtering a manifest to a matcher (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4522: narrowspec: limit patterns to path: and rootfilesin: (BC)

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D4522#69130, @indygreg wrote: > Looking through this code a bit more, it appears that there is a not-in-core "remote expansion" wire protocol command that recognizes the `include:` prefix and asks the server to expand it.

[PATCH STABLE] subrepo: mask out passwords embedded in the messages displaying a URL

2018-09-11 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1536688337 14400 # Tue Sep 11 13:52:17 2018 -0400 # Branch stable # Node ID 41ac8ea1bdd751303e49d5a98def025f78dbbf0c # Parent 6af7765bdb7c88da8393cdddbe836989852b5a5f subrepo: mask out passwords embedded in the messages displaying a URL I

[PATCH 3 of 6] ancestor: unroll loop of parents in _lazyancestorsiter()

2018-09-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1536584080 -32400 # Mon Sep 10 21:54:40 2018 +0900 # Node ID acc190466e6d1e6db9bd99024e360b68c3c8d8cb # Parent dd6a0955ec0081c6133ce8cf42d38914a8e305ab ancestor: unroll loop of parents in _lazyancestorsiter() This change itself isn't major

[PATCH 4 of 6] ancestor: optimize _lazyancestorsiter() for contiguous chains

2018-09-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1536584339 -32400 # Mon Sep 10 21:58:59 2018 +0900 # Node ID d346926526c0ca1d35b549d8f47840d123879249 # Parent acc190466e6d1e6db9bd99024e360b68c3c8d8cb ancestor: optimize _lazyancestorsiter() for contiguous chains If there's no revision

D4541: hg: write narrow patterns after repo creation

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that hg.clone() knows when a narrow clone is requested, it makes sense to have it update the narrow patterns for the repo

D4538: commands: pass include and exclude options to hg.clone()

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These arguments are defined by the narrow extension. Let's teach core to recognize them so we can delete some code from the

D4527: narrow: check "narrow" wire protocol capability, not bundle2 capability

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2862e9b868c5: narrow: check narrow wire protocol capability, not bundle2 capability (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4530: narrow: drop support for remote expansion (BC)

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previous patches to validate narrow patterns accidentically dropped support for the include: syntax that allows patterns to be

D4524: narrowspec: validate patterns when loading and saving spec file

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10901. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4524?vs=10897=10901 REVISION DETAIL https://phab.mercurial-scm.org/D4524 AFFECTED FILES mercurial/narrowspec.py tests/test-narrow-patterns.t CHANGE

[PATCH 1 of 6] ancestor: remove alias of initrevs from _lazyancestorsiter()

2018-09-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1536673112 -32400 # Tue Sep 11 22:38:32 2018 +0900 # Node ID 2989618d644ce4694a3288f8f20107f446703f66 # Parent a1b6b1fcfd29503e8cb9c8cef617571334a69339 ancestor: remove alias of initrevs from _lazyancestorsiter() It's just redundant and

[PATCH 2 of 6] ancestor: return early from _lazyancestorsiter() when reached to stoprev

2018-09-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1536583579 -32400 # Mon Sep 10 21:46:19 2018 +0900 # Node ID dd6a0955ec0081c6133ce8cf42d38914a8e305ab # Parent 2989618d644ce4694a3288f8f20107f446703f66 ancestor: return early from _lazyancestorsiter() when reached to stoprev There's no need

D4526: narrow: validate spec files are well-formed during clone (BC)

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > test-narrow-clone-no-ellipsis.t:133 >> path:dir/tests/ > - > file:dir/src/f12 >> EOF Maybe "file:" was just a typo for "path:" so it's better to replace it by "path:" (instead of having both)? > test-narrow-clone.t:279 >reading

[PATCH 6 of 6] ancestor: use heapreplace() in place of heappop/heappush()

2018-09-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1536586459 -32400 # Mon Sep 10 22:34:19 2018 +0900 # Node ID 5756061e6a540182307184da3742eedce7a8706d # Parent a7b608b84035fcd1d25ca9bac3c8b1cfb1b7f4c3 ancestor: use heapreplace() in place of heappop/heappush() This should be slightly

D4537: localrepo: add requirement when narrow files creation option present

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous commit taught hg.clone() to define a creation option when file include or exclude patterns are passed. This commit teaches the new repo

D4528: narrow: move wire proto capabilities to narrowwirepeer

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These are not bundle2 capabilities (they just happened to share the name "narrow"), so they seem to belong with the wirepeer

D4527: narrow: check "narrow" wire protocol capability, not bundle2 capability

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It seems like the new "narrow" wire protocol capability should be what determines if the server supports the "narrow" and

D4522: narrowspec: limit patterns to path: and rootfilesin: (BC)

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > martinvonz wrote in narrowspec.py:114-130 > Obsolete copy of what you inlined into parsepatterns? It is a copy, but not obsolete. `parsepatterns()` normalizes patterns supplied by the user or an untrusted source. `validatepatterns` is used on

D4529: narrow: mark wire proto capability names experimental and versioned

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D4529#69177, @indygreg wrote: > Unfortunately we likely can never ship either the `narrow` or `ellipsis` capability as stable because it would confuse 4.7 clients, which will presumably have a different understanding of what

D4526: narrow: validate spec files are well-formed during clone (BC)

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > martinvonz wrote in test-narrow-clone-no-ellipsis.t:133 > Maybe "file:" was just a typo for "path:" so it's better to replace it by > "path:" (instead of having both)? I was wondering about that too. I agree it feels wrong. I didn't feel like

D4542: fastannotate: use repo.local()

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is the proper way to check whether we're dealing with a local repository, since extensions should be coding to an interface and not testing for exact

D4522: narrowspec: limit patterns to path: and rootfilesin: (BC)

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > narrowspec.py:114-130 > +def validatepatterns(pats): > +"""Validate that patterns are in the expected data structure and format. > + > +And that is a set of normalized patterns beginning with ``path:`` or > +``rootfilesin:``. > +

D4529: narrow: mark wire proto capability names experimental and versioned

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Unfortunately we likely can never ship either the `narrow` or `ellipsis` capability as stable because it would confuse 4.7 clients, which will presumably have a different understanding

D4522: narrowspec: limit patterns to path: and rootfilesin: (BC)

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10896. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4522?vs=10885=10896 REVISION DETAIL https://phab.mercurial-scm.org/D4522 AFFECTED FILES mercurial/narrowspec.py tests/test-narrow-clone.t

D4523: narrow: validate patterns returned by expandnarrow

2018-09-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG55eea29833d2: narrow: validate patterns returned by expandnarrow (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4526: narrow: validate spec files are well-formed during clone (BC)

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10902. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4526?vs=10898=10902 REVISION DETAIL https://phab.mercurial-scm.org/D4526 AFFECTED FILES hgext/narrow/narrowcommands.py

D4531: tests: drop extra "file:" prefix from paths in narrow test

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It looks like these were added by mistake in https://phab.mercurial-scm.org/rHGf4d4bd8c8911bab0381a4937ce54f5acdd6fc2f5

D4532: narrow: set opts['narrow'] instead of local variable

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will allow the command function in core to infer the presence of the option without duplicating logic. REPOSITORY rHG

D4535: hg: allow extra arguments to be passed to repo creation

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently, repository creation is influenced by consulting the ui instance and turning config options into requirements. This means that in order to influence

D4528: narrow: move wire proto capabilities to narrowwirepeer

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe82da0fcc7c5: narrow: move wire proto capabilities to narrowwirepeer (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: D4370: treemanifest: use visitchildrenset when filtering a manifest to a matcher

2018-09-11 Thread Yuya Nishihara
> > Any reason not to use `self._loadlazy(kslash)`? > > Hmm, I feel like there was a previous version that iterated differently and > meant I'd need a copy of the list to do this correctly.. in this version, no > I don't think there's a reason to avoid it besides a potential minor speed

D4370: treemanifest: use visitchildrenset when filtering a manifest to a matcher

2018-09-11 Thread yuja (Yuya Nishihara)
yuja added a comment. > > Any reason not to use `self._loadlazy(kslash)`? > > Hmm, I feel like there was a previous version that iterated differently and meant I'd need a copy of the list to do this correctly.. in this version, no I don't think there's a reason to avoid it besides

D4531: tests: drop extra "file:" prefix from paths in narrow test

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0a5f7e16ec96: tests: drop extra file: prefix from paths in narrow test (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4540: narrow: don't wrap exchange.pull() during clone

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The wrapped version was setting up the narrow repo requirement when a narrow clone was requested. Previous commits taught

D4539: exchange: support defining narrow file patterns for pull

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit teaches exchange.pull() about the desire to perform a narrow file pull. We simply pass include and exclude patterns to the function. The values are

D4529: narrow: mark wire proto capability names experimental and versioned

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We already plan to add a "widen" wire protocol command to the "narrow" capability, so let's version the capabilities as

D4522: narrowspec: limit patterns to path: and rootfilesin: (BC)

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
martinvonz requested changes to this revision. martinvonz added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > martinvonz wrote in narrowspec.py:114-130 > Obsolete copy of what you inlined into parsepatterns? Oh, this gets used in the next patch. Was

D4529: narrow: mark wire proto capability names experimental and versioned

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG576b92928cc7: narrow: mark wire proto capability names experimental and versioned (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4529: narrow: mark wire proto capability names experimental and versioned

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D4529#69189, @martinvonz wrote: > In https://phab.mercurial-scm.org/D4529#69177, @indygreg wrote: > > > Unfortunately we likely can never ship either the `narrow` or `ellipsis` capability as stable because it would confuse

Re: [PATCH 1 of 6] ancestor: remove alias of initrevs from _lazyancestorsiter()

2018-09-11 Thread Gregory Szorc
On Tue, Sep 11, 2018 at 4:10 PM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1536673112 -32400 > # Tue Sep 11 22:38:32 2018 +0900 > # Node ID 2989618d644ce4694a3288f8f20107f446703f66 > # Parent a1b6b1fcfd29503e8cb9c8cef617571334a69339 > ancestor: remove

D4526: narrow: validate spec files are well-formed during clone (BC)

2018-09-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8301741e1f89: narrow: validate spec files are well-formed during clone (BC) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4533: localrepo: pass ui to newreporequirements()

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY newreporequirements() is called as part of creating a new repository. It doesn't make much sense for it to receive a repo instance as part of determining what

D4534: localrepo: move repo creation logic out of localrepository.__init__

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It has long bothered me that local repository creation is handled as part of localrepository.__init__. Upcoming changes I want to make around how repositories

D4526: narrow: validate spec files are well-formed during clone (BC)

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10898. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4526?vs=10889=10898 REVISION DETAIL https://phab.mercurial-scm.org/D4526 AFFECTED FILES hgext/narrow/narrowcommands.py

D4524: narrowspec: validate patterns when loading and saving spec file

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10897. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4524?vs=10887=10897 REVISION DETAIL https://phab.mercurial-scm.org/D4524 AFFECTED FILES mercurial/narrowspec.py tests/test-narrow-patterns.t CHANGE

[PATCH 5 of 6] ancestor: rename local aliases of heapq functions in _lazyancestorsiter()

2018-09-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1536673011 -32400 # Tue Sep 11 22:36:51 2018 +0900 # Node ID a7b608b84035fcd1d25ca9bac3c8b1cfb1b7f4c3 # Parent d346926526c0ca1d35b549d8f47840d123879249 ancestor: rename local aliases of heapq functions in _lazyancestorsiter() The original

D4524: narrowspec: validate patterns when loading and saving spec file

2018-09-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8d8e61df8259: narrowspec: validate patterns when loading and saving spec file (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4536: hg: recognize include and exclude patterns when cloning

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit teaches clone() to accept arguments defining file patterns to clone. This is the first step in teaching core code about the existence of a narrow

D4522: narrowspec: limit patterns to path: and rootfilesin: (BC)

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg added a subscriber: martinvonz. indygreg added a comment. Looking through this code a bit more, it appears that there is a not-in-core "remote expansion" wire protocol command that recognizes the `include:` prefix and asks the server to expand it. This series will stop that from

D4522: narrowspec: limit patterns to path: and rootfilesin: (BC)

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > indygreg wrote in narrowspec.py:114-130 > It is a copy, but not obsolete. > > `parsepatterns()` normalizes patterns supplied by the user or an untrusted > source. `validatepatterns` is used on "internal" data structures to ensure > things

D4522: narrowspec: limit patterns to path: and rootfilesin: (BC)

2018-09-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0d572769046a: narrowspec: limit patterns to path: and rootfilesin: (BC) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4525: narrow: validate patterns on incoming bundle2 part

2018-09-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGce20caecacbd: narrow: validate patterns on incoming bundle2 part (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4521: narrow: add narrow and ellipses as server capabilities

2018-09-11 Thread martinvonz (Martin von Zweigbergk)
martinvonz accepted this revision. martinvonz added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > narrowbundle2.py:51 > caps = orig(repo, **kwargs) > caps[NARROWCAP] = ['v0'] > return caps Should this perhaps be ELLIPSISCAP? I don't think the

D4521: narrow: add narrow and ellipses as server capabilities

2018-09-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc90514043eaa: narrow: add narrow and ellipses as server capabilities (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4374: narrowspec: fix a typoed 'supported'

2018-09-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2675d561f5cb: narrowspec: fix a typoed supported (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4374?vs=10565=10882

D4341: sparse: add local files to temporaryfiles if they exist out of sparse

2018-09-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9db856446298: sparse: add local files to temporaryfiles if they exist out of sparse (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4520: narrow: build the known set of nodes only when ellipses is enabled

2018-09-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG294c571490f0: narrow: build the known set of nodes only when ellipses is enabled (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4520?vs=10874=10881#toc

D4340: tests: show that merging with sparse is broken when rename is involved

2018-09-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc6eb2118f44f: tests: show that merging with sparse is broken when rename is involved (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4524: narrowspec: validate patterns when loading and saving spec file

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Patterns should be normalized and validated before being passed into narrowspec.save(). Let's assert that by checking

D4523: narrow: validate patterns returned by expandnarrow

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Remotes could supply malicious or invalid patterns. We should validate them as soon as possible. REPOSITORY rHG Mercurial

D4525: narrow: validate patterns on incoming bundle2 part

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The remote data is untrusted and needs to be validated for pattern conformance. REPOSITORY rHG Mercurial REVISION DETAIL

D4522: narrowspec: limit patterns to path: and rootfilesin: (BC)

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Some matcher patterns are computationally expensive and may even have security issues (e.g. evaluating some file

D4526: narrow: validate spec files are well-formed during clone (BC)

2018-09-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, specfiles would get read then normalized. We want specfiles to be normalized on read so there is no confusion about

D4370: treemanifest: use visitchildrenset when filtering a manifest to a matcher

2018-09-11 Thread spectral (Kyle Lippincott)
spectral added a comment. In https://phab.mercurial-scm.org/D4370#69050, @yuja wrote: > Queued, thanks. > > > +def _loadchildrensetlazy(self, visit): > > +if not visit: > > +return None > > +if visit == 'all' or visit == 'this': > > +

Re: [PATCH] about: update URLs and prefer https://

2018-09-11 Thread Augie Fackler
(+smf - this is for the website) > On Sep 6, 2018, at 22:07, Bradley M. Jones wrote: > > # HG changeset patch > # User Bradley Jones > # Date 1536285273 -43200 > # Fri Sep 07 13:54:33 2018 +1200 > # Node ID 4a6711700f7fb592b18164f1032fabb7c10480ec > # Parent

D4346: hg: wrap the highest layer in the `hg` script possible in trace event

2018-09-11 Thread durin42 (Augie Fackler)
durin42 added a comment. I think this is ready? Do I owe you anything else on it? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4346 To: durin42, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel ___

mercurial@39527: 43 new changesets

2018-09-11 Thread Mercurial Commits
43 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/42bc1c70a6b8 changeset: 39485:42bc1c70a6b8 user:Gregory Szorc date:Thu Aug 23 13:50:47 2018 -0700 summary: wireprotov2peer: report exceptions in frame handling against request future