indygreg added inline comments.
INLINE COMMENTS
> test-extension.t:108
>>
> + > bytesname = name.encode('utf-8')
>> # custom predicate to check registration of functions at loading
`name` will already be bytes on Python 2. But, `.encode()` will still work
because Python 2 has an
indygreg updated this revision to Diff 11243.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4615?vs=4=11243
REVISION DETAIL
https://phab.mercurial-scm.org/D4615
AFFECTED FILES
mercurial/wireprotov2server.py
tests/test-http-protocol.t
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG56cb053a71ed: py3: suppress the output on .write() calls in
tests/test-hgweb-commands.t (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg updated this revision to Diff 11246.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4619?vs=8=11246
REVISION DETAIL
https://phab.mercurial-scm.org/D4619
AFFECTED FILES
mercurial/help/internals/wireprotocolv2.txt
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4684
AFFECTED FILES
mercurial/changegroup.py
CHANGE DETAILS
diff --git a/mercurial/changegroup.py
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9d5c919b6dc3: narrow: extract wdir cleanup function to make
it extensible (authored by spectral, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg updated this revision to Diff 11244.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4616?vs=5=11244
REVISION DETAIL
https://phab.mercurial-scm.org/D4616
AFFECTED FILES
mercurial/help/internals/wireprotocolv2.txt
mercurial/narrowspec.py
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5495ceab5637: py3: use print as a function in
tests/test-subrepo-svn.t (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7e3ce2131882: py3: use pycompat.maplist instead of map
(authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4673?vs=11210=11230
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc71f80bfb414: changegroup: remove outdated comment
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4684?vs=11224=11235
indygreg updated this revision to Diff 11248.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4621?vs=11120=11248
REVISION DETAIL
https://phab.mercurial-scm.org/D4621
AFFECTED FILES
mercurial/help/internals/wireprotocolv2.txt
spectral created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We have an overlay filesystem which shows the entire repository, and unlinking
a file that's in the underlying data store will
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe1e10cbb5568: py3: make tests/svn-safe-append.py compatible
with python 3 (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg abandoned this revision.
indygreg added a comment.
I'm folding this into another patch.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4617
To: indygreg, #hg-reviewers, durin42
Cc: mercurial-devel
___
16 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/d8a7690ccc74
changeset: 39715:d8a7690ccc74
user:Martin von Zweigbergk
date:Wed Sep 19 17:34:36 2018 -0700
summary: fastannotate: process files as they arrive
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7d9b1b50cad5: tests: split capabilities into separate lines
while searching for narrow (authored by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It's extracted so extensions can filter manifest nodes if needed. This
is an unfortunate hack, but I think I only need it for manifests. The
long-term solution
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbe396c86f98e: py3: add some b prefixes in
tests/test-extension.t (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa2bb0ec3b4d4: py3: add a missing b in
tests/test-newercgi.t (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe03c1a63155c: changegroup: tease out a temporary prune
method for manifests (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4bd6e444c76f: bundle2: make server.bundle2.stream default
to True (authored by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1b5880352314: bundle2: graduate bundle2.stream option from
experimental to server section (authored by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGce4c29705983: py3: use stringutil.pprint() to print boolean
values (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5adc5fe41a7d: changegroup: reintroduce some comments that
have gotten lost over the years (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg added subscribers: sheehan, indygreg.
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I'm comfortable enabling this useful feature by default.
IIRC we may still be lacking a story for denoting bundle2 stream clones in
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I got concerned about the correctness of the pruning logic, but I was
misreading it. I didn't figure that out until I walked all the way
back to
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG65b39c556c6d: py3: encode the name to bytes before using in
revsetpredicate() (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg updated this revision to Diff 11245.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4618?vs=7=11245
REVISION DETAIL
https://phab.mercurial-scm.org/D4618
AFFECTED FILES
mercurial/help/internals/wireprotocolv2.txt
# HG changeset patch
# User Matt Harbison
# Date 1537501530 14400
# Thu Sep 20 23:45:30 2018 -0400
# Node ID 1b0ca924a1c3de80bf3b2b3efcf0f82b2815b4d7
# Parent 7303ab86431a09f85f19606f932a645f6999ec24
run-tests: partially backout PYTHON quoting
In 7f8b7a060584, I quoted this to support
# HG changeset patch
# User Matt Harbison
# Date 1537504623 14400
# Fri Sep 21 00:37:03 2018 -0400
# Node ID 0be4328bfbaf10cbd9f8aa6e96222107426567a5
# Parent 1b0ca924a1c3de80bf3b2b3efcf0f82b2815b4d7
py3: fix a type error in hghave.has_hardlink
test-hghave.t was failing with:
pulkit accepted this revision.
pulkit added a comment.
The code looks mostly good. Since this is something which changes existing
bookmark behavior, I will let one more pair of eyes to look before getting
pushed.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg added inline comments.
INLINE COMMENTS
> commands.py:4881-4884
> + " changes, or 'hg update %d' to update") % ctx.rev()
> else:
> hint = _("use --all to revert all files,"
> + " or 'hg update %d' to update") %
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe0a7cfa9323f: py3: use print as a function in
tests/test-revert.t (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This makes the test work on Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4687
AFFECTED FILES
contrib/python3-whitelist
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Python 3 does not allow to use '%s' for integers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4688
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7303ab86431a: py3: use %d instead of
%s for integers (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4688?vs=11250=11252
av6 added a comment.
Although I must say that EPEL 6 (it's for RHEL/CentOS 6) still has meld
1.3.1, which may be too old for this option:
https://repology.org/metapackage/meld/versions
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4665
To: martinvonz,
On Wed, 19 Sep 2018 19:01:48 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1537323243 14400
> # Tue Sep 18 22:14:03 2018 -0400
> # Node ID 6a29fe518906d0f21b7bdd76323d2f71e7667241
> # Parent a5dafefc4a53294aa0bd88a27cc29baf2a1ea62c
> py3: make osenvironb
Queued, thanks.
> +for result in results:
> +r = result.result()
Should we use a future-aware iterator to pick any finished future without
waiting for the first unfinished item?
___
Mercurial-devel mailing list
yuja added a comment.
> + $ rm -r narrow-via-localpeer
> + rm: narrow-via-localpeer: $ENOENT$
> + [1]
Changed this to `rm -Rf` and queued, thanks. It appears that GNU rm shows
friendlier message.
REPOSITORY
rHG Mercurial
REVISION DETAIL
# HG changeset patch
# User Matt Harbison
# Date 1537415656 14400
# Wed Sep 19 23:54:16 2018 -0400
# Node ID b5969b11d817a810d608d944e00e6afe64286c73
# Parent de033c83ce6ef41b81cef5c27d33b4d518005085
py3: resolve Unicode issues around `hg serve` on Windows
Presumably we're going to want to
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd8a7690ccc74: fastannotate: process files as they arrive
(authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
On Thu, Sep 20, 2018, 04:59 Yuya Nishihara wrote:
> Queued, thanks.
>
> > +for result in results:
> > +r = result.result()
>
> Should we use a future-aware iterator to pick any finished future without
> waiting for the first unfinished item?
>
That won't matter with the
# HG changeset patch
# User Matt Harbison
# Date 1537407718 14400
# Wed Sep 19 21:41:58 2018 -0400
# Node ID de033c83ce6ef41b81cef5c27d33b4d518005085
# Parent 4d2a7291137d1fc1ac8ac32862a1d3593f3eb10e
run-tests: avoid os.getcwdb() on Windows
Any call to this issues a DeprecationWarning
New changeset in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/bfeab472e3c0
changeset: 39687:bfeab472e3c0
bookmark:@
tag: tip
user:Gregory Szorc
date:Wed Sep 12 11:02:16 2018 -0700
summary: localrepo: create new function for instantiating a local repo
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG63c2b44bbe60: setdiscovery: access future.result() inside
command executor (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb990f5a31e6b: narrow: add test showing that local-to-local
narrow clones dont work (authored by durin42, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D4640?vs=11147=11206#toc
On Thu, 20 Sep 2018 08:09:59 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1537404357 14400
> # Wed Sep 19 20:45:57 2018 -0400
> # Node ID 4d2a7291137d1fc1ac8ac32862a1d3593f3eb10e
> # Parent 6a29fe518906d0f21b7bdd76323d2f71e7667241
> run-tests: quote
10 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/2f9cdb5b3644
changeset: 39688:2f9cdb5b3644
user:Gregory Szorc
date:Wed Sep 12 11:31:14 2018 -0700
summary: localrepo: move some vfs initialization out of __init__
yuja added a comment.
Queued, thanks.
> +for result in results:
> +r = result.result()
Should we use a future-aware iterator to pick any finished future without
waiting for the first unfinished item?
REPOSITORY
rHG Mercurial
REVISION DETAIL
# HG changeset patch
# User Matt Harbison
# Date 1537404357 14400
# Wed Sep 19 20:45:57 2018 -0400
# Node ID 4d2a7291137d1fc1ac8ac32862a1d3593f3eb10e
# Parent 6a29fe518906d0f21b7bdd76323d2f71e7667241
run-tests: quote PYTHON when spawning a subprocess
Same reason as 5abc47d4ca6b. This
indygreg added a comment.
A futures-aware iterator is logically the correct thing to do. I just can't
recall if that works with `commandexecutor` to the buffering nature of outgoing
requests. It may require an explicit `e.close()` or `e.sendcommands()` to
trigger sending the commands over
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Support for bundle2 streaming clones has been shipped in Mercurial 4.5
(https://phab.mercurial-scm.org/rHG7eedbd5d4880f6c0518e5ff706450a7389acb70d),
but was never
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4670
AFFECTED FILES
tests/test-subrepo-svn.t
CHANGE DETAILS
diff --git a/tests/test-subrepo-svn.t
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4671
AFFECTED FILES
tests/svn-safe-append.py
CHANGE DETAILS
diff --git a/tests/svn-safe-append.py
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame because just b'' prefixes
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4672
AFFECTED FILES
tests/test-extension.t
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4673
AFFECTED FILES
hgext/fastannotate/formatter.py
CHANGE DETAILS
diff --git
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame because just b'' prefixes
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4674
AFFECTED FILES
tests/test-newercgi.t
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4675
AFFECTED FILES
hgext/fastannotate/context.py
CHANGE DETAILS
diff --git
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4676
AFFECTED FILES
tests/test-hgweb-commands.t
CHANGE DETAILS
diff --git
pulkit created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4677
AFFECTED FILES
tests/test-extension.t
CHANGE DETAILS
diff --git
av6 created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This test is interested only in capabilities that are related to narrow, so
let's omit everything else. Makes it easier to update
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4679
AFFECTED FILES
mercurial/bundle2.py
mercurial/configitems.py
mercurial/help/config.txt
indygreg added a comment.
I'm going to drop this from hg-committed because it introduces deadlock in
test-http-bad-server.t.
The deadlock is due to buggy future handling in (at least) httppeer. I'll
keep this patch in my local queue and will try to hack on a fix for the peer.
New changeset in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/491fc3f4be67
changeset: 39714:491fc3f4be67
bookmark:@
tag: tip
user:Matt Harbison
date:Tue Sep 18 22:14:03 2018 -0400
summary: py3: make osenvironb a proxy for, instead of a copy of os.environ
16 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/f44187605315
changeset: 39698:f44187605315
user:Gregory Szorc
date:Wed Sep 12 15:07:27 2018 -0700
summary: localrepo: move store() from store module
> On Sep 20, 2018, at 11:53 AM, Gregory Szorc wrote:
>
>> On Wed, Sep 19, 2018 at 8:28 PM Matt Harbison wrote:
>> On Wed, 19 Sep 2018 21:41:20 -0400, Gregory Szorc
>> wrote:
>>
>> > Currently, the largefiles and lfs extensions monkeypatch various
>> > functions
>> > so that when they
67 matches
Mail list logo
