This revision was automatically updated to reflect the committed changes.
Closed by commit rHGad51e6117095: simplestorerepo: migrate to in-hg CBOR code
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5544
AFFECTED FILES
beta
CHANGE DETAILS
diff --git a/beta b/beta
--- a/beta
+++ b/beta
@@ -1 +1
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG98ce494e104d: cleanup: stop including thirdparty.cbor in
builds (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5542
AFFECTED FILES
hgext/histedit.py
CHANGE DETAILS
diff --git
mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5545
AFFECTED FILES
alpha
CHANGE DETAILS
diff --git a/alpha b/alpha
--- a/alpha
+++ b/alpha
@@
rdamazio added a comment.
(and btw I'd be happier with '' meaning the default, but the original author
went through the trouble of checking both cases explicitly, so I kept that)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5543
To: rdamazio, durin42,
martinvonz added inline comments.
INLINE COMMENTS
> histedit.py:1605-1606
> +# operations.
> +if ui.interface('histedit') == 'curses' and not (
> +opts.get( b'continue', False) or opts.get( b'abort', False)):
> return _chistedit(ui, repo, *freeargs, **opts)
Maybe
indygreg added a comment.
In https://phab.mercurial-scm.org/D5519#81903, @durin42 wrote:
> In https://phab.mercurial-scm.org/D5519#81899, @indygreg wrote:
>
> > The original purpose of the simple store repo was to flush out problems
with storage abstraction by building an alternate
7 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/2e60a77b7058
changeset: 41139:2e60a77b7058
user:Augie Fackler
date:Tue Jan 08 10:31:10 2019 -0500
summary: xdiff: don't attempt to use fuzzer inputs larger than 100k
indygreg added a comment.
I agree that we should nuke the vendored CBOR package altogether.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5523
To: durin42, indygreg, #hg-reviewers
Cc: mercurial-devel
___
":null},\"cursor\":{\"limit\":100,\"after\":null,\"before\":null,\"order\":null}},\"error_code\":null,\"error_info\":null}"
+}
+},
+"r
# HG changeset patch
# User Matt Harbison
# Date 1546735830 18000
# Sat Jan 05 19:50:30 2019 -0500
# Node ID bb9cd63d1cce015431a274a581021d8807cd9267
# Parent 0b7c3a31e42b075b5fc1d90c85f10239d87f9e33
phabricator: teach {phabreview} to work without --amend
There's some possibility of this
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I overlooked this when I did the initial import.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5540
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc4639fdae1b9: simplestorerepo: minimal changes required to
get this mostly working again (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added a comment.
In https://phab.mercurial-scm.org/D5519#81899, @indygreg wrote:
> The original purpose of the simple store repo was to flush out problems
with storage abstraction by building an alternate storage backend. Now that we
have storage interface unit tests and the
rdamazio created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Before this, `hg --config histedit.defaultrev= histedit` would crash with
File "destutil.py", line 385, in desthistedit
On Wed, 09 Jan 2019 23:28:38 -0500, Matt Harbison
wrote:
# HG changeset patch
# User Matt Harbison
# Date 1546719633 18000
# Sat Jan 05 15:20:33 2019 -0500
# Node ID 0b7c3a31e42b075b5fc1d90c85f10239d87f9e33
# Parent 98ce494e104dca5200af6ed53d3f4ff6547962a8
phabricator: warn if unable
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa9905045b992: tests: get access to thirdparty.cbor without
requiring it to be installed (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG23d5e03dad70: tests: add simplestorerepo to
test-check-interfaces.py (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
On Wed, 09 Jan 2019 16:16:02 -0500, Pulkit Goyal <7895pul...@gmail.com>
wrote:
Hey everyone,
Hope you are doing good.
In past few weeks, I have been playing with mercurial on windows. During
that time, I realised why windows support is so hard and was quite proud
that hg support windows.
angel.ezquerra added a comment.
In https://phab.mercurial-scm.org/D5495#81562, @yuja wrote:
> > +@predicate('merge(*withbranch)', safe=True)
> >
> > def merge(repo, subset, x):
> >
> > - """Changeset is a merge changeset. +"""Changeset is a merge
changeset + +All
On Wed, 09 Jan 2019 15:30:19 -0500, Augie Fackler wrote:
On Dec 6, 2018, at 23:21, Matt Harbison wrote:
On Wed, 05 Dec 2018 08:23:17 -0500, Yuya Nishihara
wrote:
On Tue, 4 Dec 2018 10:06:24 -0500, Augie Fackler wrote:
So, options to move forward:
1) blacken everything
lothiraldan added a comment.
The new makeprogress API is more clean but more low-level, could we extend
the deprecation warning until the 5.1 release to gives more time to extension
authors to update?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5531
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG89d103fc9c19: testrunner: avoid capturing a regex group we
dont care about (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
yuja added subscribers: foozy, yuja.
yuja added a comment.
> The code already supports this but there is no syntax to make use of
> it, so it seems reasonable to create such syntax. I create a new
> hgignore syntax "rootedglob". There might be a better name, but
> "rooted" is the
> > This is logically incorrect. The problem is that we're doing variable
> > expansion at too lower layer. `vfs(expand(user_specified_path))` makes
> > some sense, but `vfs(expand(getcwd()))` is clearly wrong. And the vfs
> class
> > can't know where the `base` comes from.
>
> If
> The code already supports this but there is no syntax to make use of
> it, so it seems reasonable to create such syntax. I create a new
> hgignore syntax "rootedglob". There might be a better name, but
> "rooted" is the terminology in use in user-facing documentation.
Perhaps, it can be
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG92a5fb73b3d5: remotefilelog: add newlines to ui.log()
invocations (authored by spectral, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
yuja added a comment.
> > This is logically incorrect. The problem is that we're doing variable
> > expansion at too lower layer. `vfs(expand(user_specified_path))` makes
> > some sense, but `vfs(expand(getcwd()))` is clearly wrong. And the vfs
class
> > can't know where the
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2e60a77b7058: xdiff: dont attempt to use fuzzer
inputs larger than 100k (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
sangeet259 added a comment.
@durin42 So the `try/except` will fall back to `unified diff`?
Is there a way we can enforce this on system's that don't have mercurial
installed globally and not have to fall back on the earlier practice.
Also, I didn't get your comment on checking the API
av6 created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Feel free to ask questions, I suspect some chunks would need a comment (either
in review or in code) to explain what's going on there.
I'll start
av6 created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This code is taken from evolve extension, namely from obslog command
implementation, and somewhat simplified to be easier to review.
No tests and no
martinvonz added a comment.
In https://phab.mercurial-scm.org/D5531#81827, @lothiraldan wrote:
> The new makeprogress API is more clean but more low-level, could we extend
the deprecation warning until the 5.1 release to gives more time to extension
authors to update?
I'm not
martinvonz updated this revision to Diff 13095.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5531?vs=13082=13095
REVISION DETAIL
https://phab.mercurial-scm.org/D5531
AFFECTED FILES
mercurial/ui.py
CHANGE DETAILS
diff --git a/mercurial/ui.py
4 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/050ea8eb42a5
changeset: 41135:050ea8eb42a5
user:Augie Fackler
date:Mon Jan 07 16:34:04 2019 -0500
summary: state: update comment about use of CBOR
durin42 added a comment.
I see a few minor issues here, but it's at least plausible?
INLINE COMMENTS
> minifileset.py:57-58
> symbols = {
> -'all': lambda n, s: True,
> -'none': lambda n, s: False,
> -'size': lambda n, s: _sizep(tree[2])(s),
> +
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf36fd52dae8f: perfrevlogwrite: use progress helper on
modern hg (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added a comment.
In https://phab.mercurial-scm.org/D5514#81800, @sangeet259 wrote:
> @durin42 So the `try/except` will fall back to `unified diff`?
Correct.
> Is there a way we can enforce this on system's that don't have mercurial
installed globally and not have to
Hey everyone,
Hope you are doing good.
In past few weeks, I have been playing with mercurial on windows. During
that time, I realised why windows support is so hard and was quite proud
that hg support windows. Huge thanks to all the people who work on this.
Now, I know things work because there
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3025fd3c2e71: progress: split up _print() method in
bar-updating and debug-printing (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added a comment.
In https://phab.mercurial-scm.org/D5516#81683, @hooper wrote:
> In https://phab.mercurial-scm.org/D5516#81679, @durin42 wrote:
>
> > I'm -0 on this: what's special about this functionality that it needs to
be an extension of an extension instead of something
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb05eb98a6b67: sparse: fix debugrebuilddirsate when narrow
extension is enabled (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7b7e081f8954: histedit: add user input to warning message
on editing tagged commits (authored by navaneeth.suresh, committed by ).
CHANGED PRIOR TO COMMIT
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG191fac9ff9d3: obsutil: fix the issue5686 (authored by
khanchi97, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5474?vs=12962=13105
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf18f665b1424: context: schedule file prefetch before
comparing for cleanliness (authored by spectral, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz added a comment.
In https://phab.mercurial-scm.org/D5372#81858, @durin42 wrote:
> per yuya, this has to support old hgs
Thanks for the reminder. I was thinking of just leaving this on the old API,
but now that I'm deprecating `ui.progress()`, this needs to be migrated.
hooper added a comment.
In https://phab.mercurial-scm.org/D5516#81841, @durin42 wrote:
> In https://phab.mercurial-scm.org/D5516#81683, @hooper wrote:
>
> > In https://phab.mercurial-scm.org/D5516#81679, @durin42 wrote:
> >
> > > I'm -0 on this: what's special about this
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I've tried to pick knobs that more or less conform to our current
style. I ran the formatter on the same set of files as the black
proposal (see
durin42 added a comment.
Without looking deeply at the implementation (I basically trust you to do
reasonable things here), I like the feature existing and poking around briefly
on obsdemo looks reasonable...
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5538
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG963462786f6e: progress: check what type of progress bar to
use only once per topic (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8cf92ca92bfe: progress: write ui.progress() in terms of
ui.makeprogress() (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added a comment.
Could you add a test?
(Bonus points if you add a test that shows the wrong behavior and then fix it
in this change.)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5490
To: navaneeth.suresh, #hg-reviewers
Cc: durin42, pulkit,
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8eaf693b1409: sparse: dont enable on clone if it was
a narrow clone (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGeb172f9c208c: tests: add tests for narrow clone when both
sparse and narrow are enabled (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG76dcf7958c5f: tests: show that debugrebuilddirstate is
broken with narrow+sparse (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit added a comment.
Sorry for bumping on this now, can you add tests for this as follow-up?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5494
To: navaneeth.suresh, durin42, #hg-reviewers
Cc: pulkit, yuja, mharbison72, mercurial-devel
durin42 requested changes to this revision.
durin42 added a comment.
This revision now requires changes to proceed.
per yuya, this has to support old hgs
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5372
To: martinvonz, #hg-reviewers, durin42
Cc: durin42,
durin42 added inline comments.
INLINE COMMENTS
> manifest.py:1139
> +
> +def _iterativediff(t1, t2, stack):
> +"""compares two tree manifests and append new tree-manifests
> which
room for a follow-up: I'm not sure this needs to be a nested function anymore
(it could be a
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2c3f69855ce8: manifest: convert a recursive function to
iterative one using stacks (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8c222bec97da: merge: make local file storage in the
.hg/merge directory extensible (authored by dploch, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz updated this revision to Diff 13109.
martinvonz retitled this revision from "perfrevlogwrite: use progress helper"
to "perfrevlogwrite: use progress helper on modern hg".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5372?vs=12711=13109
durin42 added a comment.
Per mailing list thread, I've sent out https://phab.mercurial-scm.org/D5539
to show what yapf would want to do.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5064
To: mjpieters, indygreg, durin42, #hg-reviewers
Cc: mharbison72, av6,
> On Dec 6, 2018, at 23:21, Matt Harbison wrote:
>
> On Wed, 05 Dec 2018 08:23:17 -0500, Yuya Nishihara wrote:
>
>> On Tue, 4 Dec 2018 10:06:24 -0500, Augie Fackler wrote:
>>>
>>> So, options to move forward:
>>> 1) blacken everything (controversial for good reasons)
>>> 2) try black only
> After sometime of fighting with windows, here I am looking for suggestions on
> how one can use mercurial on windows smoothly and what are the recommended
> ways. Like shall I use MYSYS, did things will work in cmd.exe?
>
> If anyone can shed some light on their experiences and tips and
65 matches
Mail list logo
