D7816: tests: stabilize test-subrepo-svn.t on Windows

2020-01-08 Thread mharbison72 (Matt Harbison)
mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This partially reverts 991e4404e910 , because the URL form of `C:\...` gets

D7814: sha1dc: import latest version from github

2020-01-08 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. Rubber stamp. (I've been wanting to use this library for a while as well.) REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION

D7815: sha1dc: initial implementation of Python extension

2020-01-08 Thread indygreg (Gregory Szorc)
indygreg added a comment. This seems mostly good to me. INLINE COMMENTS > cext.c:68 > + if (SHA1DCFinal(hash_out, )) { > + PyErr_SetString(PyExc_OverflowError, > + "sha1 collision attack detected"); I'm not super keen on overloading

[Bug 6251] New: `hg: parse error: pick "..." changeset was not a candidate` when using `hg histedit` Curses UI

2020-01-08 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6251 Bug ID: 6251 Summary: `hg: parse error: pick "..." changeset was not a candidate` when using `hg histedit` Curses UI Product: Mercurial Version: 5.2.1 Hardware: PC

D7708: lfs: add a switch to `hg verify` to ignore the content of blobs

2020-01-08 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. mharbison72 requested review of this revision. Setting this back to wanting a review because I suspect my response questions were overlooked with vacations, and it won't show up in anybody's dashboard otherwise. REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7812: examples: specify rustfmt nightly using a $() construct

2020-01-08 Thread quark (Jun Wu)
quark added a comment. You can use `rustfmt +nightly` if it's installed by rustup. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7812/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7812 To: durin42, #hg-reviewers Cc: quark, gracinet,

D7660: rust-index: add a `experimental.rust.index` option to use the wrapper

2020-01-08 Thread mharbison72 (Matt Harbison)
mharbison72 added inline comments. INLINE COMMENTS > localrepo.py:930 > > +if ui.configbool('experimental', 'rust.index'): > +options[b'rust.index'] = True This needs bytes if someone with write access wants to rewrite it before it gets too deep. Alternately, I submitted D7817

D7817: py3: byteify some `ui.configbool()` parameters

2020-01-08 Thread mharbison72 (Matt Harbison)
mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This popped up in 8042856c90b6 . REPOSITORY rHG Mercurial REVISION DETAIL

D7815: sha1dc: initial implementation of Python extension

2020-01-08 Thread durin42 (Augie Fackler)
durin42 edited the summary of this revision. durin42 retitled this revision from "sha1dc: initial implementation of Python extension (NOT READY)" to "sha1dc: initial implementation of Python extension". durin42 updated this revision to Diff 19119. REPOSITORY rHG Mercurial CHANGES SINCE LAST

hg-configexpress: new version (0.4.0) and hosting migration

2020-01-08 Thread Pierre-Yves David
Hello all, A new version (0.4.0) of hg-configexpress has been released, it contains the following changes: * recommended configuration are now issued at the start of the bundle. So the user is prompted at the start of the pull. * The extensions is now compatible with python 3 (or at

D7803: tests: split out another ~1/2 of test-graft.t

2020-01-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz marked an inline comment as done. martinvonz updated this revision to Diff 19066. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7803?vs=19055=19066 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7803/new/

D7807: hgrc: introduce HGRCSKIPREPO to skip reading the hgrc's repository

2020-01-08 Thread durin42 (Augie Fackler)
durin42 added inline comments. durin42 added subscribers: krbullock, durin42. INLINE COMMENTS > scripting.txt:80 > + > +Note that these approaches can have unintended consequences, as the > +repository config files might define things like extensions that may Awkward. Maybe: Note that

D7705: phases: make the working directory consistently a draft

2020-01-08 Thread rdamazio (Rodrigo Damazio Bovendorp)
Closed by commit rHG2ab225377c27: phases: make the working directory consistently a draft (authored by rdamazio). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7696: inno: drop support for Windows 95/98/ME

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG4ccd0c9f9e92: inno: drop support for Windows 95/98/ME (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7696?vs=18847=19070 CHANGES

D7618: fix: correct the clang-format example hgrc so that it actually works

2020-01-08 Thread spectral (Kyle Lippincott)
Closed by commit rHG7a16c779a9d0: fix: correct the clang-format example hgrc so that it actually works (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7730: rebase: make sure pruning does not confuse rebase (issue6180)

2020-01-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > rebase.py:597 > self.state[rev] = dest > +# since we are done, make sure wdir has one parent (issue6180) > +if len(repo[None].parents()) == 2: I think it's incorrect that rebase sets two parents while the

D7657: rust-index: handle `MixedIndex` in `pyindex_to_graph`

2020-01-08 Thread marmoute (Pierre-Yves David)
Closed by commit rHGc627f1b2f3c3: rust-index: handle `MixedIndex` in `pyindex_to_graph` (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7659: rust-index: use the new method in shortesthexnodeidprefix

2020-01-08 Thread gracinet (Georges Racinet)
Closed by commit rHG992f0d6e7f33: rust-index: use the new method in shortesthexnodeidprefix (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7783: rust-matchers: fixing cargo doc

2020-01-08 Thread gracinet (Georges Racinet)
Closed by commit rHGefa5d2539cd9: rust-matchers: fixing cargo doc (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7782: rust-core: extracted a revlog submodule

2020-01-08 Thread gracinet (Georges Racinet)
Closed by commit rHG9aee291b608a: rust-core: extracted a revlog submodule (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE

D7570: match: resolve filesets against the passed `cwd`, not the current one

2020-01-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 19072. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7570?vs=18895=19072 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7570/new/ REVISION DETAIL

D7658: rust-index: expose a method to retrieve the C index

2020-01-08 Thread gracinet (Georges Racinet)
Closed by commit rHG443dc1655923: rust-index: expose a method to retrieve the C index (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7800: movedirstate: get copies from dirstate before setting parents

2020-01-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 19065. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7800?vs=19052=19065 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7800/new/ REVISION DETAIL

D7803: tests: split out another ~1/2 of test-graft.t

2020-01-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > pulkit wrote in test-graft-rename.t:70 > Now that repo is created at start of test, we should drop `../` Oops, thanks for noticing. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7803/new/ REVISION

D7570: match: resolve filesets against the passed `cwd`, not the current one

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG28ea223a65c5: match: resolve filesets against the passed `cwd`, not the current one (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7656: rust-index: make it possible to clone the struct referencing the C index

2020-01-08 Thread gracinet (Georges Racinet)
Closed by commit rHG2728fcb8127c: rust-index: make it possible to clone the struct referencing the C index (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D7660: rust-index: add a `experimental.rust.index` option to use the wrapper

2020-01-08 Thread gracinet (Georges Racinet)
Closed by commit rHG8042856c90b6: rust-index: add a `experimental.rust.index` option to use the wrapper (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7810: packaging: update Ubuntu docker build dependencies to Python 3

2020-01-08 Thread sheehan (Connor Sheehan)
sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Changeset 7574ccd87200f02e updated the Debian docker builds to Python 3. In doing

D7811: tests: fix a "naked exception" issue in test-remotefilelog-prefetch.t

2020-01-08 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7811 AFFECTED FILES tests/test-remotefilelog-prefetch.t CHANGE DETAILS diff --git

D7779: py3: replace `time.clock()` with `time.perf_counter()`

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG6b90f5c89cb4: py3: replace `time.clock()` with `time.perf_counter()` (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7778: mq: avoid using `__file__` to compare modules

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG5bbd770d1324: mq: avoid using `__file__` to compare modules (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7813: revlog: run rustfmt nightly

2020-01-08 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added subscribers: mercurial-devel, kevincox. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm a little nervous about folding this back (might be nightly rustfmt mismatches?) so I want someone to review this. REPOSITORY rHG Mercurial BRANCH

D7765: cleanup: replace contiguous spaces in regex patterns with an explicit count

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHGac3cb5e05a38: cleanup: replace contiguous spaces in regex patterns with an explicit count (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D7723: tests: update test-releasenotes-formatting.t output

2020-01-08 Thread pulkit (Pulkit Goyal)
Closed by commit rHGdf470e764770: tests: update test-releasenotes-formatting.t output (authored by pulkit). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7769: tests: fix a copy/paste name duplication in storage.py

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHGa1ee825fc6c5: tests: fix a copy/paste name duplication in storage.py (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7733: hgext: initial version of fastexport extension

2020-01-08 Thread durin42 (Augie Fackler)
durin42 added a comment. durin42 accepted this revision as: durin42. I only did a light pass, but looks good to me. Any plans for a fast-export importer as well? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7733/new/ REVISION DETAIL

D7812: examples: specify rustfmt nightly using a $() construct

2020-01-08 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is ugly, but it's how we have to configure rustfmt for now as we require nightly rustfmt. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D7714: subrepo: fix a crash when archiving an svn or git subrepo

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG7ca8aa8840c0: subrepo: fix a crash when archiving an svn or git subrepo (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7811: tests: fix a "naked exception" issue in test-remotefilelog-prefetch.t

2020-01-08 Thread spectral (Kyle Lippincott)
Closed by commit rHG1e0783b946c8: tests: fix a naked exception issue in test-remotefilelog-prefetch.t (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7780: util: avoid referencing `time.clock()` on Windows when missing (issue6238)

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHGf9d29e1d3354: util: avoid referencing `time.clock()` on Windows when missing (issue6238) (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D7767: cleanup: drop redundant character escapes outside of `[]`

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHGc1ccefb513e4: cleanup: drop redundant character escapes outside of `[]` (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7772: resourceutil: don't limit resources to the `mercurial` package

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG52f0140c2604: resourceutil: dont limit resources to the `mercurial` package (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7774: resourceutil: implement `contents()` to iterate over resources in a package

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHGbba9149adc14: resourceutil: implement `contents()` to iterate over resources in a package (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D7784: progress: flush stderr after clearing

2020-01-08 Thread spectral (Kyle Lippincott)
Closed by commit rHG4e0a6d157910: progress: flush stderr after clearing (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE

D7808: mmap: add a size argument to mmapread

2020-01-08 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > marmoute wrote in util.py:419-422 > passing 0 in `mmap.mmap(fd, 0, access=mmap.ACCESS_READ)` get you "all the > byte you can eat". That's is not 0 sized mmap. > > The `size` argument for `util.mmapread` is (after this patch). If size is > None

D7576: hg-core: add configparser to library

2020-01-08 Thread durin42 (Augie Fackler)
durin42 added a comment. I'm a little lost on the state of this. It looks like we need to downgrade the required Rust version? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7576/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7576 To:

D7712: lfs: don't skip locally available blobs when verifying

2020-01-08 Thread durin42 (Augie Fackler)
This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. Needs rebased. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7712/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7712 To:

D7617: fix: make example fix hgrc work in subdirs

2020-01-08 Thread durin42 (Augie Fackler)
durin42 added a comment. Now that D7570 is landed, this is obsolete, right? REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7617/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7617 To:

D7809: revlogutils: move the NodeMap class in a dedicated nodemap module

2020-01-08 Thread marmoute (Pierre-Yves David)
Closed by commit rHGab595920de0e: revlogutils: move the NodeMap class in a dedicated nodemap module (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7808: mmap: add a size argument to mmapread

2020-01-08 Thread marmoute (Pierre-Yves David)
Closed by commit rHG8ed8dfbeabb9: mmap: add a size argument to mmapread (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO COMMIT

D7812: examples: specify rustfmt nightly using a $() construct

2020-01-08 Thread gracinet (Georges Racinet)
gracinet added a comment. thanks for the tip. Fun fact: `rustup which` doesn't have a --toolchain option on my system, so perhaps it needs to be itself upgraded, (and that might explain a few things. I've been using rustmt nightly since forever, but maybe I'm stuck on an old version of

D7815: sha1dc: initial implementation of Python extension (NOT READY)

2020-01-08 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is not yet ready: there's some bug (probably a simple oversight) that causes it to segfault inside PyType_Ready() during import of the module.

D7815: sha1dc: initial implementation of Python extension (NOT READY)

2020-01-08 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 19113. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7815?vs=19112=19113 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7815/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7815

D7771: setup: include `defaultrc` in the package list

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG44b03c0313aa: setup: include `defaultrc` in the package list (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7773: resourceutil: implement `is_resource()`

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG42a897bf678c: resourceutil: implement `is_resource()` (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D7768: commit: change default `editor` parameter to None

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG3216cabffd4a: commit: change default `editor` parameter to None (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7766: cleanup: drop redundant character escapes from `[]` character sets

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG6d3b67a837a6: cleanup: drop redundant character escapes from `[]` character sets (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7777: rcutil: drop the `defaultrcpath()` method (API)

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG2d4cad94d08a: rcutil: drop the `defaultrcpath()` method (API) (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7775: ui: refactor `readconfig()` into a form that can consume resources

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG5ac0e6f19eb4: ui: refactor `readconfig()` into a form that can consume resources (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7776: ui: add the ability to apply `defaultrc` configs from resources

2020-01-08 Thread mharbison72 (Matt Harbison)
Closed by commit rHG1864efbe90d9: ui: add the ability to apply `defaultrc` configs from resources (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7810: packaging: update Ubuntu docker build dependencies to Python 3

2020-01-08 Thread sheehan (Connor Sheehan)
Closed by commit rHGb084ad4875a4: packaging: update Ubuntu docker build dependencies to Python 3 (authored by sheehan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7815: sha1dc: initial implementation of Python extension (NOT READY)

2020-01-08 Thread spectral (Kyle Lippincott)
spectral added inline comments. INLINE COMMENTS > cext.c:24 > +} pysha1ctx; > +/* clang-format oon */ > + Nit: "clang-format on" (typo: s/oon/on/) > cext.c:104 > + "Return a copy of the hash object."}, > +}; > + I think you need a {NULL} entry here, or else it's going to walk off the end

D7815: sha1dc: initial implementation of Python extension (NOT READY)

2020-01-08 Thread durin42 (Augie Fackler)
durin42 edited the summary of this revision. durin42 updated this revision to Diff 19115. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7815?vs=19113=19115 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7815/new/ REVISION

D7815: sha1dc: initial implementation of Python extension (NOT READY)

2020-01-08 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 19116. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7815?vs=19115=19116 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7815/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7815

D7815: sha1dc: initial implementation of Python extension (NOT READY)

2020-01-08 Thread durin42 (Augie Fackler)
durin42 added inline comments. durin42 marked 4 inline comments as done. INLINE COMMENTS > spectral wrote in cext.c:24 > Nit: "clang-format on" (typo: s/oon/on/) Good catch! > spectral wrote in cext.c:104 > I think you need a {NULL} entry here, or else it's going to walk off the end > of this

[Bug 6250] New: `TypeError: must be str or None, not bytes` in histedit.py:geteditcomment

2020-01-08 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6250 Bug ID: 6250 Summary: `TypeError: must be str or None, not bytes` in histedit.py:geteditcomment Product: Mercurial Version: 5.2.1 Hardware: PC OS: Mac OS

D7785: remotefilelog: actually fix (and test this time) a bytes vs str issue

2020-01-08 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > test-remotefilelog-prefetch.t:253 > + > repo.fileservice.prefetch([(b'somefile.txt', hexid)]) > + > except: > + > pass `test-check-code.t` fails now: --- /home/pulkitg/repo/hgpush/tests/test-check-code.t +++

mercurial@44003: 2 new changesets

2020-01-08 Thread Mercurial Commits
2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/d9d78e70149a changeset: 44002:d9d78e70149a user:Martin von Zweigbergk date:Fri Dec 27 09:55:35 2019 -0800 summary: tests: fix failing doctest in match.py by adding dummy auditor

D7803: tests: split out another ~1/2 of test-graft.t

2020-01-08 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > test-graft-rename.t:70 > >$ hg init ../graftmove >$ cd ../graftmove Now that repo is created at start of test, we should drop `../` REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7803/new/

D7807: hgrc: introduce HGRCSKIPREPO to skip reading the hgrc's repository

2020-01-08 Thread pulkit (Pulkit Goyal)
pulkit added a comment. > hgrc: introduce HGRCSKIPREPO to skip reading the hgrc's repository s/ hgrc's repository/repository's hgrc REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7807/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7807

D7731: tests: fix failing doctest in match.py by adding dummy auditor

2020-01-08 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGd9d78e70149a: tests: fix failing doctest in match.py by adding dummy auditor (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7728: rebase: add test to demonstrate issue6180

2020-01-08 Thread khanchi97 (Sushil khanchi)
khanchi97 added a comment. Ping. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7728/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7728 To: khanchi97, #hg-reviewers Cc: mercurial-devel ___

D7732: convert: refactor authormap into separate function for outside use

2020-01-08 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > convcmd.py:58 > > +def readauthormap(ui, authorfile, authors={}): > +with open(authorfile, b'rb') as afile: We disallow usage of default mutable arguments. Hence `test-check-code.t` says hi. + hgext/convert/convcmd.py:58: + > def

[Bug 6249] New: can not interact with Server repository with proxy

2020-01-08 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6249 Bug ID: 6249 Summary: can not interact with Server repository with proxy Product: Mercurial Version: 5.2rc0 Hardware: PC OS: Linux Status: UNCONFIRMED

D7730: rebase: make sure pruning does not confuse rebase (issue6180)

2020-01-08 Thread khanchi97 (Sushil khanchi)
khanchi97 added a comment. Ping. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7730/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7730 To: khanchi97, martinvonz, #hg-reviewers Cc: mercurial-devel

D7781: rust-core: updated copyright notice

2020-01-08 Thread gracinet (Georges Racinet)
Closed by commit rHGcb2e2b095dc9: rust-core: updated copyright notice (authored by gracinet). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7781?vs=19029=19064 CHANGES SINCE LAST