D1494: develwarn: do not emit warning if "config" is unspecified

2017-11-22 Thread spectral (Kyle Lippincott)
spectral added a comment. (Specifically picked yuja as reviewer since they reviewed the original https://www.mercurial-scm.org/repo/hg/rev/3f33831a9202, so hopefully can tell me whether this was intentional or not and I'm possibly breaking stuff with this change :)) REPOSITORY rHG

D1494: develwarn: do not emit warning if "config" is unspecified

2017-11-22 Thread spectral (Kyle Lippincott)
spectral created this revision. spectral added a reviewer: yuja. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, if the develwarn call site did not specify the category of warning, and devel.all-warnings was False, it would emit

D1285: repoview: add a new attribute _visibilityexceptions and related API

2017-11-22 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D1285#24461, @quark wrote: > I think the state of "visibilityexception" should really be bounded into whoever controls "filteredrevs", which is the `repoview` object. This allows different exceptions to be set for different

D1492: repoview: take out the logic of computehidden to a new function

2017-11-22 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We are going to use that logic in compute functions for the new filternames which will be introduced in the next patch. So lets make a utility function which

D1285: repoview: add a new attribute _visibilityexceptions and related API

2017-11-22 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 3784. pulkit edited the summary of this revision. pulkit retitled this revision from "localrepo: add a new attribute _visibilityexceptions and related API" to "repoview: add a new attribute _visibilityexceptions and related API". REPOSITORY rHG Mercurial

D1287: repoview: add two new filternames to be used for accessing hidden commits

2017-11-22 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 3787. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1287?vs=3207=3787 REVISION DETAIL https://phab.mercurial-scm.org/D1287 AFFECTED FILES mercurial/branchmap.py

D1286: repoview: consider visibility exceptions in computehidden()

2017-11-22 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 3785. pulkit edited the summary of this revision. pulkit retitled this revision from "repoview: also consider visibility exceptions in pinnedrevs" to "repoview: consider visibility exceptions in computehidden()". REPOSITORY rHG Mercurial CHANGES SINCE

D1348: histedit: add support to output nodechanges using formatter

2017-11-22 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 3783. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1348?vs=3420=3783 REVISION DETAIL https://phab.mercurial-scm.org/D1348 AFFECTED FILES hgext/histedit.py tests/test-histedit-templates.t CHANGE DETAILS diff

D1063: rebase: enable multidest by default

2017-11-22 Thread quark (Jun Wu)
quark added a comment. We have shipped restack based on this code path and haven't heard a problem yet. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1063 To: quark, #hg-reviewers, durin42 Cc: krbullock, dlax, martinvonz, durin42, mercurial-devel

D1483: globalopts: make special flags ineffective after '--' (BC)

2017-11-22 Thread quark (Jun Wu)
quark abandoned this revision. quark added a comment. I didn't notice it's fixed in stable. Thanks! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1483 To: quark, #hg-reviewers, yuja Cc: yuja, lothiraldan, dlax, mercurial-devel

D1063: rebase: enable multidest by default

2017-11-22 Thread krbullock (Kevin Bullock)
krbullock added a comment. @quark @martinvonz Ping REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1063 To: quark, #hg-reviewers, durin42 Cc: krbullock, dlax, martinvonz, durin42, mercurial-devel ___ Mercurial-devel

[PATCH v3] cmdutil: add within-line color diff capacity

2017-11-22 Thread matthieu . laneuville
# HG changeset patch # User Matthieu Laneuville # Date 1508944418 -32400 # Thu Oct 26 00:13:38 2017 +0900 # Node ID e4b4d581af0fc4e39a28150470b5a658d8315a3f # Parent 75013952d8d9608f73cd45f68405fbd6ec112bf2 # EXP-Topic hg248 cmdutil: add within-line color

D1293: rebase: use fm.formatlist() and fm.formatdict() to support user template

2017-11-22 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf56a30b844aa: rebase: use fm.formatlist() and fm.formatdict() to support user template (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT

D1462: tests: add test for rebase template showing wrong behavior

2017-11-22 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc157bb0120a9: tests: add test for rebase template showing wrong behavior (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [POLL] Mass renaming options for consistency + guidelines

2017-11-22 Thread Yuya Nishihara
On Tue, 21 Nov 2017 16:34:20 +0100, Boris Feld wrote: > On Tue, 2017-11-21 at 22:00 +0900, Yuya Nishihara wrote: > > On Sun, 19 Nov 2017 05:13:49 +, Martin von Zweigbergk wrote: > > > On Sat, Nov 18, 2017, 19:22 Yuya Nishihara wrote: > > > > On Mon, 13 Nov 2017 22:31:38 +0900,

D1293: rebase: use fm.formatlist() and fm.formatdict() to support user template

2017-11-22 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued the series, many thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1293 To: pulkit, #hg-reviewers, yuja Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list

D1483: globalopts: make special flags ineffective after '--' (BC)

2017-11-22 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. A similar patch is already in stable. Can you send a follow-up if you found a problem? https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-November/107567.html

D1460: workers: add config to enable/disable workers

2017-11-22 Thread lothiraldan (Boris Feld)
lothiraldan requested changes to this revision. lothiraldan added a comment. This revision now requires changes to proceed. Looks good. We are in the process of registering all the config options in the file named `configitems.py`

D1474: run-tests: convert to argparse

2017-11-22 Thread lothiraldan (Boris Feld)
lothiraldan accepted this revision. lothiraldan added a comment. LGTM to me and seems to works fine on Linux. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1474 To: indygreg, #hg-reviewers, lothiraldan Cc: lothiraldan, mercurial-devel