pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in remotenames.py:189
> > Does remotebookmark, and remotebranch sounds good?
>
> Will the log output get aligned for these longer names?
>
> Should we include a space? "remote bookmark:" looks more user-friendly
I made it
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch adds three new revsets 'remotenames', 'remotebookmarks' and
'remotebranches' which will return changesets which have remotenames,
remotebookmarks and
pulkit updated this revision to Diff 5148.
pulkit edited the summary of this revision.
pulkit retitled this revision from "remotenames: introduce a template keyword
for remotenames" to "remotenames: introduce new template keywords for
remotenames".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST
pulkit updated this revision to Diff 5146.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1757?vs=4611=5146
REVISION DETAIL
https://phab.mercurial-scm.org/D1757
AFFECTED FILES
hgext/remotenames.py
CHANGE DETAILS
diff --git a/hgext/remotenames.py
pulkit updated this revision to Diff 5145.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1756?vs=4610=5145
REVISION DETAIL
https://phab.mercurial-scm.org/D1756
AFFECTED FILES
hgext/remotenames.py
tests/test-help.t
CHANGE DETAILS
diff --git
pulkit updated this revision to Diff 5144.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1755?vs=4794=5144
REVISION DETAIL
https://phab.mercurial-scm.org/D1755
AFFECTED FILES
mercurial/logexchange.py
tests/test-logexchange.t
CHANGE DETAILS
diff
pulkit updated this revision to Diff 5147.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1758?vs=4612=5147
REVISION DETAIL
https://phab.mercurial-scm.org/D1758
AFFECTED FILES
hgext/remotenames.py
tests/test-logexchange.t
CHANGE DETAILS
diff
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Previously, HTTP wire protocol clients would attempt a
"capabilities" wire protocol command. If that failed, they would
fall back to issuing a "between"
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Both were introduced in 0.9.1.
"hello" made its entrance in
https://phab.mercurial-scm.org/rHGb17eebc911ae808e10487a567d94e1f05d70adf1,
quark added a comment.
> Another thing to consider is reading things from .arcconfig files and
reading the API token however Arcanist does it (as the comment in this file
suggests).
That was my original plan - in `readurltoken`, fallback to `~/.arcrc` and
`.arcconfig` if hgrc does not
# HG changeset patch
# User Matt Harbison
# Date 1517281788 18000
# Mon Jan 29 22:09:48 2018 -0500
# Node ID dac55f22cd775a8d3a213e9b6716f03e49e1e765
# Parent 0088fad7fa84a6ec668682e137273e252bc7441c
lfs: emit a status message to indicate how many blobs were
# HG changeset patch
# User Matt Harbison
# Date 1517362401 18000
# Tue Jan 30 20:33:21 2018 -0500
# Node ID 0088fad7fa84a6ec668682e137273e252bc7441c
# Parent f1a0933ce59e809f190602655e22ae6ec107c397
lfs: drop an unused function parameter
diff --git
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf1a0933ce59e: config: replace a for-else by any() (authored
by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1994?vs=5118=5141
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5523aabb85c3: discovery: dont reimplement all()
(authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1993?vs=5117=5140
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG786a70abb4d7: contrib: fix dirstatenonnormalcheck to work
in Python 3 (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg added a comment.
In https://phab.mercurial-scm.org/D1919#33519, @durin42 wrote:
> In https://phab.mercurial-scm.org/D1919#33517, @indygreg wrote:
>
> > FWIW Mozilla will likely start leaning on this extension pretty soon.
Look for a push from us to move it to core before the
durin42 added a comment.
In https://phab.mercurial-scm.org/D1919#33517, @indygreg wrote:
> FWIW Mozilla will likely start leaning on this extension pretty soon. Look
for a push from us to move it to core before the next release.
I've had a...slightly bonkers idea around using
indygreg added a comment.
In https://phab.mercurial-scm.org/D1974#33514, @durin42 wrote:
> Should I add follow-up commits for the feedback? I think I'd slightly
prefer doing that so that we import something that's as minimally modified as
possible, and then fix it up all at once, but if
indygreg added a comment.
In https://phab.mercurial-scm.org/D1919#33462, @durin42 wrote:
> I like this, and I'm fine with the backwards incompatible change in
contrib. How do others feel?
I'm fine with BC in contrib.
One thing to bikeshed is if the `[phabricator]` section is
durin42 added a comment.
Should I add follow-up commits for the feedback? I think I'd slightly prefer
doing that so that we import something that's as minimally modified as
possible, and then fix it up all at once, but if you'd rather fix things here
that's fine too.
(I agree with the
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I'm about to add more arguments and want them to be documented.
Plus, good documentation is nice to have.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The `try..except error.Abort` was added in
https://phab.mercurial-scm.org/rHG8474be4412ca5eb4e67047a97acb7cb7f3120ff0 back
in
2012. The intent was to ensure
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Wire protocol commands have historically been declared as
2-tuples in wireproto.commands. There are some additional features I'd
like to implement that require
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Currently, we perform simple membership testing for whether a wire
command is available. In the future, not all wire protocol commands
will be available on all
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The mechanism by which SSH peers establish connections with remotes
is wonky and requires a bit of code archeology to understand. While
it is already
durin42 accepted this revision as: durin42.
durin42 added a comment.
I like this, and I'm fine with the backwards incompatible change in contrib.
How do others feel?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1919
To: tom.prince, #hg-reviewers, durin42
Cc:
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGcd1928ca94e4: python3: whitelist another 24 passing tests
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1911?vs=4916=5133
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG00466a8b4d13: cmdutil: add a kludge to make bytes repr()
the same on 2 and 3 (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2713f62fd898: mdiff: use slice instead of index on bytestr
when checking single bytes (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4705dc1500e0: obsutil: work around filter() being a
generator in Python 3 (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGae7c16df7967: wireprotoserver: make attributes private
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1984?vs=5107=5122
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6edb973da584: wireprotoserver: remove lock references
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1986?vs=5109=5124
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf87323084271: wireprotoserver: remove support for
do_command handlers (API) (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG654d1f79b9a6: wireprotoserver: make abstractserverproto a
proper abstract base class (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8e949f7f4913: wireprotoserver: remove sshserver.getarg()
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1987?vs=5110=5125
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Writing this as a generator expression /might/ be a bit better. But I don't
think perf is an issue here.
REPOSITORY
rHG Mercurial
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG397c2a9ba553: wireprotoserver: add some blank lines between
methods (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6da3f324b9de: wireprotoserver: remove unused response
attribute (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9d9d1c248ba3: wireprotoserver: rename p to proto (authored
by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1982?vs=5105=5120
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4e3cb2830397: wireprotoserver: make name part of protocol
interface (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7ce570643fcc: wireprotoserver: make some instance
attributes private (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6968eb2579a5: wireprotoserver: make response handling
attributes private (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I'd be curious if there is a perf hit to this. The slicing API is a bit more
involved than `__getitem__` at the C layer. But since this is Python code, my
guess is run time is
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1994
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git a/mercurial/commands.py
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1993
AFFECTED FILES
mercurial/discovery.py
CHANGE DETAILS
diff --git a/mercurial/discovery.py
indygreg added a comment.
I glanced at the code and found the first set of needed follow-ups.
INLINE COMMENTS
> __init__.py:11-14
> +from mercurial import __version__
> +if __version__.version < '3.7':
> +raise ImportError(
> +'narrowhg requires mercurial 3.7 or newer')
This
durin42 updated this revision to Diff 5115.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1970?vs=5080=5115
REVISION DETAIL
https://phab.mercurial-scm.org/D1970
AFFECTED FILES
contrib/dirstatenonnormalcheck.py
mercurial/dirstate.py
CHANGE DETAILS
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is portable to Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1992
AFFECTED FILES
mercurial/mdiff.py
CHANGE
durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.
Fixing a typo (now instead of no) in log message in flight.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1985
To: indygreg, #hg-reviewers, durin42
Cc:
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Old versions of wire protocol handlers relied on methods
named do_ to handle wire protocol commands. The last
definition of these methods on sshserver was
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a required part of the interface. Abstract properties must
be defined at type creation time. So we make name a @property.
REPOSITORY
rHG Mercurial
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Plug in the abc module so we can have run-time validation of type
conformance.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
These aren't part of the protocol interface. So they should be
_ prefixed.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1984
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
AFAICT the last consumer of this helper method was removed by
https://phab.mercurial-scm.org/rHGd054cc5c77370c345a0c41a002b2ce0aada45389 in
2010.
REPOSITORY
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The send* methods are specific to sshserver and aren't part of the
common protocol interface. So rename them accordingly.
The handlers dict is also specific
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
AFAICT sshserver.lock is unused. The last caller of it disappeared
in https://phab.mercurial-scm.org/rHG9f6e0e7ef82884e3ec66455dac7312820c2b35ce
~18 months ago
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
sshserver attempts to conform to a well-defined interface. The instance
attributes changed as part of this commit don't appear to be part of
that interface. So
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I think the last use of this attribute was removed by
https://phab.mercurial-scm.org/rHG2f8adc60e01328523052b1829ca9846ec1285f60
in 2010.
REPOSITORY
rHG
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
To aid readability. And to make it easier to search the code base
for protocol instances.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Let's make this file slightly easier to read.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1981
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG119e4dbdeb29: tests: start a set of unit tests for
mdiff.py, starting with splitnewlines (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG204435ef0a6f: perf: add a perfunidiff command for
benchmarking unified diff speed (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg added subscribers: yuja, indygreg.
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
This looks mostly good. Needs some minor tweaks. Some of my comments are
informative and can probably be ignored as far as
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1980
AFFECTED FILES
hgext/narrow/__init__.py
CHANGE DETAILS
diff --git a/hgext/narrow/__init__.py
https://bz.mercurial-scm.org/show_bug.cgi?id=5780
Bug ID: 5780
Summary: hg incoming --bundle --quiet uses debilitating amounts
of RAM on large repos
Product: Mercurial
Version: 4.4.2
Hardware: PC
OS: Linux
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
These tests predate the testcases functionality in run-tests.py, so it
was never done in narrowhg.
REPOSITORY
rHG Mercurial
REVISION DETAIL
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1976
AFFECTED FILES
hgext/narrow/narrowbundle2.py
CHANGE DETAILS
diff --git
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1977
AFFECTED FILES
hgext/narrow/narrowrevlog.py
CHANGE DETAILS
diff --git
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1978
AFFECTED FILES
hgext/narrow/narrowrevlog.py
CHANGE DETAILS
diff --git
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Adjustments:
- renamed src to hgext/narrow
- marked extension experimental
- added correct copyright header where it was missing
- updated hgrc extension
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1975
AFFECTED FILES
hgext/narrow/__init__.py
CHANGE DETAILS
diff --git a/hgext/narrow/__init__.py
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe28ae1f4b194: wireprotoserver: move sshserver into module
(API) (authored by indygreg, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D1968?vs=5048=5094#toc
REPOSITORY
rHG
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd34a01d55133: wireprotoserver: move abstractserverproto
class from wireproto (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1aa42928bb47: wireprotoserver: rename hgweb.protocol to
wireprotoserver (API) (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa3a1ffcf5f8c: wireprotoserver: dont import symbol
from hgweb.common (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG86196f91fee8: wireprotoserver: rename call to callhttp
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1966?vs=5046=5091
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Nice.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1971
To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG568917059243: testrunner: make reading of test times work
with #testcases (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2f7ab4fb7711: tests: allow [Errno] in output (authored by
indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1958?vs=5032=5087
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG32675dbbec99: testrunner: fix updating of .testtimes file
(authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1971
AFFECTED FILES
contrib/perf.py
tests/test-contrib-perf.t
CHANGE DETAILS
diff --git
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
./hg perfunidiff mercurial/manifest.py 0 --count 500 --profile before:
! wall 0.309280 comb 0.35 user 0.29 sys 0.06 (best of 32)
./hg perfunidiff
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I want to optimize splitnewlines, so writing tests seems prudent.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1972
AFFECTED
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG079b27b5a869: patch: avoid repeated binary checks if all
files in a patch are text (authored by joerg.sonnenberger, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6a33e81e4c5e: mdiff: remove rewindhunk by yielding a bool
first to indicate data (authored by joerg.sonnenberger, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa9d07bd8f758: mdiff: explicitly compute places for the
newline marker (authored by joerg.sonnenberger, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 updated this revision to Diff 5080.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1970?vs=5079=5080
REVISION DETAIL
https://phab.mercurial-scm.org/D1970
AFFECTED FILES
contrib/dirstatenonnormalcheck.py
mercurial/dirstate.py
CHANGE DETAILS
martinvonz added inline comments.
INLINE COMMENTS
> martinvonz wrote in strip.py:218
> I would expect "%d" with a revision number (such as uctx.rev()). I saw that
> that's also what Yuya suggested on https://phab.mercurial-scm.org/D1884.
> Fixing in flight.
Oh, that's done in the next patch
martinvonz added inline comments.
INLINE COMMENTS
> strip.py:218
> # between the working context and uctx
> -descendantrevs = repo.revs("%s::." % uctx.rev())
> +descendantrevs = repo.revs("%s::.", uctx.rev())
> changedfiles = []
I would expect
New changeset in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/34287c2e3fc4
changeset: 35821:34287c2e3fc4
bookmark:@
tag: tip
parent: 35793:4fb2bb61597c
parent: 35820:1d60ad093792
user:Augie Fackler
date:Thu Feb 01 14:28:45 2018
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a redo of https://phab.mercurial-scm.org/D1963 that has the added
benefit of not breaking
Python 2. Oops.
1. skip-blame because this is bytes
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG98b746a1ebe3: setdiscovery: dont call
heads wire command when heads specified (authored by martinvonz,
committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I initially thought this would have test fallout. But since we're using a
batch command to issue the `heads` wire protocol command, it won't show up in
HTTP logs. We'd only catch it in
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG81c3ad368574: testrunner: on error, color the (case
xxx) part the same as filename (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG577a4d267e0f: mq: use bytes() instead of str() to encode
statusentries for writing (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG94e124e3db1e: python3: whitelist an additional 23 passing
tests (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG177eb3847a0a: mq: open status file et al in bytes mode
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1902?vs=4909=5072
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0ba365937220: mq: fix up statusentry to be both repr()-able
and bytes()-able (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd5030224cada: tests: fix a missed b prefix in a test
extension in test-strip.t (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG24dd168d712a: revlog: correct type in check to verify
rawtext is immutable (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
1 - 100 of 150 matches
Mail list logo