D2108: infinitepush: drop the `--to` flag to push and use `-B` instead

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. I'm find with you sending more parts to this series. Especially if they delete code: if they delete code then my review of the import will be a review of the final state of the code

D2097: infinitepush: remove backupcommands.py

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. This is a nifty feature. But I agree it is beyond scope of the initial landing of this feature. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2097 To:

Re: [PATCH 3 of 3] lfs: teach '{lfs_files}' to handle removed files

On Fri, 09 Feb 2018 08:04:04 -0500, Yuya Nishihara wrote: On Fri, 09 Feb 2018 00:30:23 -0500, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1517098935 18000 # Sat Jan 27 19:22:15 2018 -0500 # Node ID

Re: [PATCH] test: glob the temporary directory out of temporary file path

On Fri, 09 Feb 2018 19:03:37 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1518178697 -3600 > # Fri Feb 09 13:18:17 2018 +0100 > # Node ID b74d05c795298bc4230950086cc5667a8845cd6c > # Parent c64b9adfb371b6e9dfd2257d3e2f62d5121341df > #

Re: [PATCH] tests: raise a better error when patterns are wrongly formatted

On Fri, 09 Feb 2018 14:46:27 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1518176892 -3600 > # Fri Feb 09 12:48:12 2018 +0100 > # Node ID 3fe40329001a42dcbe98c69b342aa00ec821fa92 > # Parent 80e5210df25c330bd2a4e8f12385422545cb69bf > #

[Bug 5787] New: `annotate --skip` is undocumented in `--help`

https://bz.mercurial-scm.org/show_bug.cgi?id=5787 Bug ID: 5787 Summary: `annotate --skip` is undocumented in `--help` Product: Mercurial Version: unspecified Hardware: PC OS: Linux Status: UNCONFIRMED

D2096: infinitepush: move the extension to core from fb-hgext

indygreg added a comment. I can take review of this series since this feature is of extreme interest to Mozilla. I //might// get around to looking at it this weekend. But no promises. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2096 To: pulkit,

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

sangeet259 added a comment. @dlax Yes, but the short summary didn't say what it does! It just says "include the specified changeset". REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2095 To: sangeet259, #hg-reviewers Cc: dlax, mercurial-devel

[PATCH] test: glob the temporary directory out of temporary file path

# HG changeset patch # User Boris Feld # Date 1518178697 -3600 # Fri Feb 09 13:18:17 2018 +0100 # Node ID b74d05c795298bc4230950086cc5667a8845cd6c # Parent c64b9adfb371b6e9dfd2257d3e2f62d5121341df # EXP-Topic test-tmpdir # Available At

[Bug 5786] New: `hg evolve --continue` crashes if working directory clean

https://bz.mercurial-scm.org/show_bug.cgi?id=5786 Bug ID: 5786 Summary: `hg evolve --continue` crashes if working directory clean Product: Mercurial Version: 4.4-rc Hardware: PC OS: Linux

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

dlax added a comment. As mentioned in the issue, there's already an explanation paragraph help: To pull only a subset of changesets, specify one or more revisions identifiers with -r/--rev or branches with -b/--branch. The resulting clone will contain only the specified

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

sangeet259 updated this revision to Diff 5371. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2095?vs=5370=5371 REVISION DETAIL https://phab.mercurial-scm.org/D2095 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git

[PATCH] tests: raise a better error when patterns are wrongly formatted

# HG changeset patch # User Boris Feld # Date 1518176892 -3600 # Fri Feb 09 12:48:12 2018 +0100 # Node ID 3fe40329001a42dcbe98c69b342aa00ec821fa92 # Parent 80e5210df25c330bd2a4e8f12385422545cb69bf # EXP-Topic pattern-error # Available At

Re: [PATCH 3 of 3] lfs: teach '{lfs_files}' to handle removed files

On Fri, 09 Feb 2018 00:30:23 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1517098935 18000 > # Sat Jan 27 19:22:15 2018 -0500 > # Node ID e545487fa7fa9ff2fa4f85e2482bea8ba4040ef6 > # Parent

Re: [PATCH 1 of 3] lfs: add a fileset for detecting lfs files

On Fri, 09 Feb 2018 00:30:21 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1517093899 18000 > # Sat Jan 27 17:58:19 2018 -0500 > # Node ID 5b3ca0f7f4b676863d5b3a481ce7ed88bf6acd55 > # Parent

D2108: infinitepush: drop the `--to` flag to push and use `-B` instead

pulkit added a subscriber: durham. pulkit added a comment. There is still some work required to make this extension better. I didn't want to grow my stack too long and hence send upto here. Few things which will be coming for sure: - removal of wrapping of `push` command on client side

D2108: infinitepush: drop the `--to` flag to push and use `-B` instead

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The extension added a `--to` flag to specify the bookmark to which revs should be pushed. This patch deletes that flag and instead uses the `-B` flag. After this

D2107: infinitepush: drop the `--create` flag to push command

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The extension added a `--create` flag for creating a new bookmark on the bundlestore. This patch changes the bahviour to create a bookmark if it does not exists

D2103: infinitepush: drop `--list-remote`, `--remote-path` flags to bookmark cmd

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The extension adds these two flags to list remote bookmarks using the `hg bookmark` command. These are not required in core currently and needs some discussion

D2106: infinitepush: drop logic related to treemanifest extension

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY treemanifest is another facebook's extension which is not in core. Let's drop the logic related to infinitepush extension which is now ported to core. REPOSITORY

D2105: infinitepush: drop hack related to --to, --create flags of remotenames-ext

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The remotenames extension has --to, --create. --allow-anon flags which won't be ported to core. This patch drops the hack which fixes the interaction with

D2104: infinitepush: drop error handling while pushing to svn server

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is something which is internal to Facebook and we don't want in core. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2104

D2099: infinitepush: delete the hack to load the extension after remotenames

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The remotenames extension which circumvents the default push implementation lives outside the core, so let's delete logic related to loading of extension on the

D2102: infinitepush: drop the scratchbookmarksparttype bundle2 part

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The scratchbookmarksparttype bundle2 part was used in backupcommands.py which we deleted in an earlier changeset. We don't need this part anymore. Moreover we

D2101: infinitepush: remove wrapping around bundle2._addpartsfromopts()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This wrapping around bundle2._addpartsfromopts() was added by me while hacking on an alternate way to mark a push as infinitepush or not. However the wrapping

D2098: infinitepush: drop the logic related to inhibit extension

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The inhibit extension lives in hg-experimental and is not a core extension. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2098

D2100: infinitepush: delete the bundle2 part ordering related to pushrebase

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY pushrebase is another Facebook extension which does not live in core yet. So let's remove the logic which make sures infinitepush part is moved before the

D2097: infinitepush: remove backupcommands.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This file contains command pushbackup and pullbackup which are used to store things to infinitepush. This is an advanced functionality which we don't require