[PATCH] lfs: drop a duplicate blob verification method

# HG changeset patch # User Matt Harbison # Date 1522468951 14400 # Sat Mar 31 00:02:31 2018 -0400 # Node ID 9837cda5fd115adecf860d3a97e5a01c07ca72fc # Parent f1f70b2610da96054c6750122092adbb24e7aea8 lfs: drop a duplicate blob verification method diff --git

[PATCH 1 of 2] server: refactor 'daemon_postexec' instructions into a dictionary

# HG changeset patch # User Matt Harbison # Date 1522466506 14400 # Fri Mar 30 23:21:46 2018 -0400 # Node ID 6e77d0a68122a6513521c94c4b8256b7e6da6f93 # Parent 45aa79668d4ee38866b0829786da076ef59b0381 server: refactor 'daemon_postexec' instructions into a dictionary

[PATCH 2 of 2] server: minor code cleanup

# HG changeset patch # User Matt Harbison # Date 1522467126 14400 # Fri Mar 30 23:32:06 2018 -0400 # Node ID f1f70b2610da96054c6750122092adbb24e7aea8 # Parent 6e77d0a68122a6513521c94c4b8256b7e6da6f93 server: minor code cleanup Suggested by Yuya after 77f9e95fe3c4,

Re: [PATCH 2 of 2] tests: partially stabilize test-fix-* for Windows

On Fri, 30 Mar 2018 22:21:51 -0400, Yuya Nishihara wrote: On Fri, 30 Mar 2018 21:43:42 -0400, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1522458729 14400 # Fri Mar 30 21:12:09 2018 -0400 # Node ID

D2988: fix: use a portable python script instead of sed in test

mharbison72 added a comment. sys.std* need the procutil.setbinary() treatment, and globbing applied to the delta below to keep Windows happy. Also, test-fix-topology.t probably needs the same fix. --- c:/Users/Matt/projects/hg/tests/test-fix.t +++

Re: [PATCH 2 of 2] tests: partially stabilize test-fix-* for Windows

On Fri, 30 Mar 2018 21:43:42 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1522458729 14400 > # Fri Mar 30 21:12:09 2018 -0400 > # Node ID 3262e4f5d83b86754e8d4bd56ba651cf166a87d8 > # Parent

Re: [PATCH 1 of 2] tests: conditionalize test-stream-bundle-v2 for Windows

On Fri, 30 Mar 2018 21:43:41 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1522457616 14400 > # Fri Mar 30 20:53:36 2018 -0400 > # Node ID d0bae217b58314cd50c43e345e754f2f373b0441 > # Parent

Re: [PATCH V2] server: add an error feedback mechanism for when the daemon fails to launch

On Fri, 30 Mar 2018 21:34:02 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1522210269 14400 > # Wed Mar 28 00:11:09 2018 -0400 > # Node ID 74bbfa1b88c69471713bcaa0c8124df4ce93783c > # Parent

[PATCH 11 of 11] templater: drop global exception catcher from runfilter() (API)

# HG changeset patch # User Yuya Nishihara # Date 1521359827 -32400 # Sun Mar 18 16:57:07 2018 +0900 # Node ID 9a2646947602dd11d7f65422e3ea27fabb3ee555 # Parent bf00dda4a053a9dbf7163e993a454dd9dc03cb1f templater: drop global exception catcher from runfilter() (API) Now all

[PATCH 01 of 11] hgweb: use registrar to declare "websub" template filter

# HG changeset patch # User Yuya Nishihara # Date 1521459546 -32400 # Mon Mar 19 20:39:06 2018 +0900 # Node ID eb32cf0cbbf309242f75d5b94f27744b1a1abd5d # Parent 81951fe000108850cd19f4f1185f803e20778d1b hgweb: use registrar to declare "websub" template filter Prepares for

[PATCH 10 of 11] templatefilters: raise ProgrammingError if unencodable type passed to json()

# HG changeset patch # User Yuya Nishihara # Date 1521359588 -32400 # Sun Mar 18 16:53:08 2018 +0900 # Node ID bf00dda4a053a9dbf7163e993a454dd9dc03cb1f # Parent 68b69a593cf0865a1485d10a87c58f1c3254fb76 templatefilters: raise ProgrammingError if unencodable type passed to

[PATCH 05 of 11] templatefuncs: use evaldate() where seems appropriate

# HG changeset patch # User Yuya Nishihara # Date 1521356302 -32400 # Sun Mar 18 15:58:22 2018 +0900 # Node ID 5195b8b4c84633ed4529a0c5430c3b04e88f6898 # Parent 01d55beea227cca5b033cfe9dd4a0a068aad5b8c templatefuncs: use evaldate() where seems appropriate This means

[PATCH 03 of 11] templatefilters: declare input type as bytes where appropriate

# HG changeset patch # User Yuya Nishihara # Date 1521355348 -32400 # Sun Mar 18 15:42:28 2018 +0900 # Node ID 5b226692c357623256819fc6ab2abead595734bc # Parent a31ddf984c1b851d78faa753b12aa694f6884ee5 templatefilters: declare input type as bytes where appropriate Some test

[PATCH 09 of 11] templatefilters: handle TypeError by count()

# HG changeset patch # User Yuya Nishihara # Date 1521359264 -32400 # Sun Mar 18 16:47:44 2018 +0900 # Node ID 68b69a593cf0865a1485d10a87c58f1c3254fb76 # Parent 068cf6f31d4733d74d084d0cca61a9ff04939ea5 templatefilters: handle TypeError by count() Prepares for removing the

[PATCH 02 of 11] templatefilters: allow declaration of input data type

# HG changeset patch # User Yuya Nishihara # Date 1521353698 -32400 # Sun Mar 18 15:14:58 2018 +0900 # Node ID a31ddf984c1b851d78faa753b12aa694f6884ee5 # Parent eb32cf0cbbf309242f75d5b94f27744b1a1abd5d templatefilters: allow declaration of input data type Currently filters

[PATCH 06 of 11] templater: attach hint to input-type error of runfilter()

# HG changeset patch # User Yuya Nishihara # Date 1521554256 -32400 # Tue Mar 20 22:57:36 2018 +0900 # Node ID 044cf5cbae04306dc21919b1dbb461a1f01b3a2e # Parent 5195b8b4c84633ed4529a0c5430c3b04e88f6898 templater: attach hint to input-type error of runfilter() Tests will be

[PATCH 04 of 11] templater: factor out function that parses argument as date tuple

# HG changeset patch # User Yuya Nishihara # Date 1521356131 -32400 # Sun Mar 18 15:55:31 2018 +0900 # Node ID 01d55beea227cca5b033cfe9dd4a0a068aad5b8c # Parent 5b226692c357623256819fc6ab2abead595734bc templater: factor out function that parses argument as date tuple diff

[PATCH 07 of 11] templatefilters: declare input type as date where appropriate

# HG changeset patch # User Yuya Nishihara # Date 1521357164 -32400 # Sun Mar 18 16:12:44 2018 +0900 # Node ID baf331e387375dd7ad56b45b59fce950c385d17b # Parent 044cf5cbae04306dc21919b1dbb461a1f01b3a2e templatefilters: declare input type as date where appropriate I'm not

[PATCH 08 of 11] keyword: declare input type of date filters as date

# HG changeset patch # User Yuya Nishihara # Date 1521360159 -32400 # Sun Mar 18 17:02:39 2018 +0900 # Node ID 068cf6f31d4733d74d084d0cca61a9ff04939ea5 # Parent baf331e387375dd7ad56b45b59fce950c385d17b keyword: declare input type of date filters as date Dropped redundant

[PATCH 1 of 2 RESEND] procutil: unroll uin/uout loop in protectstdio()

# HG changeset patch # User Yuya Nishihara # Date 1521947238 -32400 # Sun Mar 25 12:07:18 2018 +0900 # Node ID 6fdab0e7824cd95ea5edd4511d5063823ba423d5 # Parent 40be6a8728a046b3673a517af2a3e15574457728 procutil: unroll uin/uout loop in protectstdio() I'll change uout to be

[PATCH 2 of 2 RESEND] procutil: redirect ui.fout to stderr while stdio is protected

# HG changeset patch # User Yuya Nishihara # Date 1521947733 -32400 # Sun Mar 25 12:15:33 2018 +0900 # Node ID 81951fe000108850cd19f4f1185f803e20778d1b # Parent 6fdab0e7824cd95ea5edd4511d5063823ba423d5 procutil: redirect ui.fout to stderr while stdio is protected The new

[PATCH] py3: fix fix doctests to be bytes-safe

# HG changeset patch # User Yuya Nishihara # Date 1522459698 -32400 # Sat Mar 31 10:28:18 2018 +0900 # Node ID 40be6a8728a046b3673a517af2a3e15574457728 # Parent 2a2ce93e12f4a70fa4aa2efae74658e43cc0e989 py3: fix fix doctests to be bytes-safe diff --git a/hgext/fix.py

[PATCH 1 of 2] tests: conditionalize test-stream-bundle-v2 for Windows

# HG changeset patch # User Matt Harbison # Date 1522457616 14400 # Fri Mar 30 20:53:36 2018 -0400 # Node ID d0bae217b58314cd50c43e345e754f2f373b0441 # Parent 74bbfa1b88c69471713bcaa0c8124df4ce93783c tests: conditionalize test-stream-bundle-v2 for Windows diff

[PATCH 2 of 2] tests: partially stabilize test-fix-* for Windows

# HG changeset patch # User Matt Harbison # Date 1522458729 14400 # Fri Mar 30 21:12:09 2018 -0400 # Node ID 3262e4f5d83b86754e8d4bd56ba651cf166a87d8 # Parent d0bae217b58314cd50c43e345e754f2f373b0441 tests: partially stabilize test-fix-* for Windows It looks like

[PATCH V2] server: add an error feedback mechanism for when the daemon fails to launch

# HG changeset patch # User Matt Harbison # Date 1522210269 14400 # Wed Mar 28 00:11:09 2018 -0400 # Node ID 74bbfa1b88c69471713bcaa0c8124df4ce93783c # Parent b9dd8403d8ff4b36847ce405c0db127ca64491a1 server: add an error feedback mechanism for when the daemon fails

D2904: templatefuncs: add mailmap template function

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2a2ce93e12f4: templatefuncs: add mailmap template function (authored by sheehan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2904?vs=7381=7453#toc REPOSITORY rHG

D2976: extdiff: document that it copies modified files back to working directory

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2208149c4b8e: extdiff: document that it copies modified files back to working directory (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2904: templatefuncs: add mailmap template function

yuja added a comment. Queued, thanks. Can you send a followup? INLINE COMMENTS > templatefuncs.py:189 > + > +return stringutil.mapname(cache['mailmap'], author) or author > + Perhaps the last `or author` wouldn't be necessary because that's the default of `mapname()`. >

D2958: infinitepush: introduce server option to route every push to bundlestore

mharbison72 added inline comments. INLINE COMMENTS > test-infinitepush-ci.t:79 > + > + $ hg unbundle > .hg/scratchbranches/filebundlestore/a4/c2/a4c202c147a9c4bb91bbadb56321fc5f3950f7f2 > + adding changesets On Windows, this command fails like so. Any thoughts on the unexpected end of

D2988: fix: use a portable python script instead of sed in test

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2988 AFFECTED FILES tests/test-fix.t CHANGE DETAILS diff --git a/tests/test-fix.t b/tests/test-fix.t

D2983: wireproto: port protocol handler to zope.interface

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY zope.interface is superior to the abc module. Let's port to it. As part of this, we add tests for interface conformance for classes implementing the

D2987: stringutil: add function to pretty print an object

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is inspired by the pprint() module/function (which we can't use because the output is different on Python 2 and 3 - namely the use of b'' literals).

D2982: wireproto: separate commands tables for version 1 and 2 commands

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We can't easily reuse existing command handlers for version 2 commands because the response types will be different. e.g. many commands return nodes encoded as

D2984: keepalive: implement readinto()

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is part of the standard I/O interface. It is used by the framing protocol. So we need to implement it so frames can be decoded. REPOSITORY rHG Mercurial

D2981: wireproto: mark SSHv2 as a version 1 transport

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The version component is used for filtering/routing wire protocol commands to their proper handler. The actual version 2 of the wire protocol commands will use

D2986: wireproto: add frame flag to denote payloads as CBOR

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We may eventually want a separate frame type for this. But for now this is the easiest to implement. REPOSITORY rHG Mercurial REVISION DETAIL

D2985: wireproto: implement custom __repr__ for frame

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This version won't print the full payload (which could be large). It also prints human friendly values for types and flags. REPOSITORY rHG Mercurial

D2980: zope: force module import by importing symbols

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, we tried to import a module and handle the ImportError. Our lazy module importer doesn't verify the module exists and returns a dummy object

D2977: fix: remove unused imports

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd3f1d3e4e58d: fix: remove unused imports (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2977?vs=7431=7441 REVISION DETAIL

D2951: wireproto: use CBOR for command requests

indygreg updated this revision to Diff 7439. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2951?vs=7328=7439 REVISION DETAIL https://phab.mercurial-scm.org/D2951 AFFECTED FILES mercurial/help/internals/wireprotocol.txt

D2907: wireproto: add streams to frame-based protocol

indygreg updated this revision to Diff 7435. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2907?vs=7325=7435 REVISION DETAIL https://phab.mercurial-scm.org/D2907 AFFECTED FILES mercurial/debugcommands.py mercurial/help/internals/wireprotocol.txt

D2948: wireproto: syntax for encoding CBOR into frames

indygreg updated this revision to Diff 7437. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2948?vs=7352=7437 REVISION DETAIL https://phab.mercurial-scm.org/D2948 AFFECTED FILES mercurial/debugcommands.py mercurial/utils/stringutil.py

D2979: wireproto: stop aliasing wire protocol types (API)

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We generally shy away from aliasing module symbols. I think I was keeping this around for API compatibility. We've already made tons of other API breaks in the

D2906: wireproto: start to associate frame generation with a stream

indygreg updated this revision to Diff 7434. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2906?vs=7324=7434 REVISION DETAIL https://phab.mercurial-scm.org/D2906 AFFECTED FILES mercurial/wireprotoframing.py mercurial/wireprotoserver.py

D2902: wireproto: define frame to represent progress updates

indygreg updated this revision to Diff 7438. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2902?vs=7311=7438 REVISION DETAIL https://phab.mercurial-scm.org/D2902 AFFECTED FILES mercurial/help/internals/wireprotocol.txt

D2947: wireproto: explicit API to create outgoing streams

indygreg updated this revision to Diff 7436. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2947?vs=7326=7436 REVISION DETAIL https://phab.mercurial-scm.org/D2947 AFFECTED FILES mercurial/wireprotoframing.py mercurial/wireprotoserver.py

D2950: tests: fix duplicate and failing test

indygreg updated this revision to Diff 7433. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2950?vs=7323=7433 REVISION DETAIL https://phab.mercurial-scm.org/D2950 AFFECTED FILES tests/test-wireproto-serverreactor.py CHANGE DETAILS diff --git

D2978: cbor: import CBORDecoder and CBOREncoder

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY And format the imports so it is cleaner. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2978 AFFECTED FILES

D2977: fix: remove unused imports

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2977 AFFECTED FILES hgext/fix.py CHANGE DETAILS diff --git a/hgext/fix.py b/hgext/fix.py ---

D2952: infinitepush: delete infinitepush.fillmetadatabranchpattern config option

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8b5d7ef81066: infinitepush: delete infinitepush.fillmetadatabranchpattern config option (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2106: infinitepush: drop logic related to treemanifest extension

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7fa00a6f8180: infinitepush: drop logic related to treemanifest extension (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2957: infinitepush: don't wrap bundle2.processparts while calling `hg unbundle`

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe5cd0ef5c362: infinitepush: dont wrap bundle2.processparts while calling `hg unbundle` (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2958: infinitepush: introduce server option to route every push to bundlestore

This revision was automatically updated to reflect the committed changes. Closed by commit rHG571f25dae740: infinitepush: introduce server option to route every push to bundlestore (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2954: infinitepush: drop the wrapping of update command on client side

This revision was automatically updated to reflect the committed changes. Closed by commit rHG95cc57a74363: infinitepush: drop the wrapping of update command on client side (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2956: inifnitepush: use utils.{stringutil|procutil}.* instead of util.*

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0d6c12668691: inifnitepush: use utils.{stringutil|procutil}.* instead of util.* (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2108: infinitepush: drop the `--to` flag to push and use `-B` instead

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc5687ce3b411: infinitepush: drop the `--to` flag to push and use `-B` instead (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2108?vs=7334=7422#toc

D2953: infinitepush: delete infinitepushcommands.py and related tests

This revision was automatically updated to reflect the committed changes. Closed by commit rHGaa015dd92591: infinitepush: delete infinitepushcommands.py and related tests (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2953?vs=7336=7425#toc

D2103: infinitepush: drop `--list-remote`, `--remote-path` flags to bookmark cmd

This revision was automatically updated to reflect the committed changes. Closed by commit rHG320b1f95f676: infinitepush: drop `--list-remote`, `--remote-path` flags to bookmark cmd (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2101: infinitepush: remove wrapping around bundle2._addpartsfromopts()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe702ca152b33: infinitepush: remove wrapping around bundle2._addpartsfromopts() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2105: infinitepush: drop hack related to --to, --create flags of remotenames-ext

This revision was automatically updated to reflect the committed changes. Closed by commit rHG14acab54e08b: infinitepush: drop hack related to --to, --create flags of remotenames-ext (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2104: infinitepush: drop error handling while pushing to svn server

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3be6f435db4f: infinitepush: drop error handling while pushing to svn server (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2107: infinitepush: drop the `--create` flag to push command

This revision was automatically updated to reflect the committed changes. Closed by commit rHG78c2e9418278: infinitepush: drop the `--create` flag to push command (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2098: infinitepush: drop the logic related to inhibit extension

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb377b7dfe682: infinitepush: drop the logic related to inhibit extension (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2097: infinitepush: remove backupcommands.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHGde4c2f3af97f: infinitepush: remove backupcommands.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2097?vs=5358=7412

D2100: infinitepush: delete the bundle2 part ordering related to pushrebase

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2fdc827f76ec: infinitepush: delete the bundle2 part ordering related to pushrebase (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2102: infinitepush: drop the scratchbookmarksparttype bundle2 part

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5a9692d0d6fc: infinitepush: drop the scratchbookmarksparttype bundle2 part (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2099: infinitepush: delete the hack to load the extension after remotenames

This revision was automatically updated to reflect the committed changes. Closed by commit rHGecdd8c3044de: infinitepush: delete the hack to load the extension after remotenames (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2096: infinitepush: move the extension to core from fb-hgext

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. OK. I applied this series locally and looked at the final code. There are some minor issues with the current series. But I can fix those in flight. I've also captured a number

D2976: extdiff: document that it copies modified files back to working directory

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2976 AFFECTED FILES hgext/extdiff.py tests/test-extension.t CHANGE DETAILS diff --git

D2897: fix: new extension for automatically modifying file contents

This revision was automatically updated to reflect the committed changes. Closed by commit rHGded5ea279a93: fix: new extension for automatically modifying file contents (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2973: narrow: use repo.local() instead of isinstance()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6d43b39fbaa0: narrow: use repo.local() instead of isinstance() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2974: contrib: rename clang-format-blacklist to clang-format-ignorelist

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0024961aa493: contrib: rename clang-format-blacklist to clang-format-ignorelist (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2975: tests: add zope.interface to clang-format ignore list

This revision was automatically updated to reflect the committed changes. Closed by commit rHG027db60ae756: tests: add zope.interface to clang-format ignore list (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2096: infinitepush: move the extension to core from fb-hgext

indygreg added inline comments. INLINE COMMENTS > __init__.py:136 > +common, > +infinitepushcommands, > +) This deleted module isn't dropped later in the series. > __init__.py:266 > +self._repo = repo > +storetype = self._repo.ui.config('infinitepush', 'storetype', '')

D2096: infinitepush: move the extension to core from fb-hgext

indygreg added inline comments. INLINE COMMENTS > __init__.py:258 > +if common.isremotebooksenabled(ui): > +hoist = ui.config('remotenames', 'hoist') + '/' > +if remotebookmark.startswith(hoist): This will need updated to `hoistedpeer`. REPOSITORY rHG Mercurial REVISION

D2943: grep: fixes errorneous output of grep in forward order

pulkit closed this revision. pulkit added a comment. This was committed as https://www.mercurial-scm.org/repo/hg/rev/a2a6755a3def. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2943 To: pulkit, #hg-reviewers, yuja, sangeet259 Cc: yuja, mercurial-devel

D2897: fix: new extension for automatically modifying file contents

pulkit accepted this revision. pulkit added inline comments. INLINE COMMENTS > hooper wrote in test-fix.t:857 > Would it abort or merge if the working copy is dirty? Is that behavior > expected to end up in cleanupnodes? It could also just force --working-dir. > It's similar to creating an

D2975: tests: add zope.interface to clang-format ignore list

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2975 AFFECTED FILES contrib/clang-format-ignorelist CHANGE DETAILS diff --git

D2974: contrib: rename clang-format-blacklist to clang-format-ignorelist

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY "blacklist" is racially charged. Let's rename it to something that isn't. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2974

D2958: infinitepush: introduce server option to route every push to bundlestore

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. This looks reasonable. Could we also please get an explicit test for `hg pull -r ` in this server configuration? Yes, I believe that will be redundant with other tests. But it is

D2930: thirdparty: port zope.interface to relative imports

This revision was automatically updated to reflect the committed changes. Closed by commit rHG68ee61822182: thirdparty: port zope.interface to relative imports (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2932: setup: register zope.interface packages and compile C extension

This revision was automatically updated to reflect the committed changes. Closed by commit rHG922b3fae9c7d: setup: register zope.interface packages and compile C extension (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2931: thirdparty: allow zope.interface.advice to be lazily imported

This revision was automatically updated to reflect the committed changes. Closed by commit rHG49630e75635d: thirdparty: allow zope.interface.advice to be lazily imported (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2929: thirdparty: don't make zope a namespace package

This revision was automatically updated to reflect the committed changes. Closed by commit rHG338367d44d34: thirdparty: dont make zope a namespace package (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2972: tests: ignore zope packages when running pyflakes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG559069689121: tests: ignore zope packages when running pyflakes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2973: narrow: use repo.local() instead of isinstance()

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2973 AFFECTED FILES hgext/narrow/__init__.py CHANGE DETAILS

D2972: tests: ignore zope packages when running pyflakes

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2972 AFFECTED FILES tests/test-check-pyflakes.t CHANGE DETAILS diff --git

D2970: context: set repo property in basectx

indygreg added a comment. I mean accidentally pushed to Phabricator after the queuing. The queueing was correct. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2970 To: martinvonz, #hg-reviewers, indygreg Cc: mercurial-devel

D2970: context: set repo property in basectx

indygreg added a comment. I accidentally pushed this. Derp. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2970 To: martinvonz, #hg-reviewers, indygreg Cc: mercurial-devel ___ Mercurial-devel mailing list

D2928: thirdparty: vendor zope.interface 4.4.3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG943d77fc07a3: thirdparty: vendor zope.interface 4.4.3 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2928?vs=7241=7396

D2970: context: set repo property in basectx

indygreg updated this revision to Diff 7394. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2970?vs=7393=7394 REVISION DETAIL https://phab.mercurial-scm.org/D2970 AFFECTED FILES mercurial/context.py CHANGE DETAILS diff --git a/mercurial/context.py

D2933: repository: define interface for local repositories

This revision was automatically updated to reflect the committed changes. indygreg marked 2 inline comments as done. Closed by commit rHG0dfb5672f015: repository: define interface for local repositories (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2957: infinitepush: don't wrap bundle2.processparts while calling `hg unbundle`

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. The next patch adds test coverage. So I think this is fine. A follow-up to make this less hacky (if possible) would be appreciated, but isn't required. REPOSITORY rHG Mercurial

D2957: infinitepush: don't wrap bundle2.processparts while calling `hg unbundle`

indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. Can the `op` argument be used instead? Also, given the hackiness of this, I'd feel much better if there were test coverage for `hg unbundle` continuing to work with this

D2970: context: set repo property in basectx

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfbe34945220d: context: set repo property in basectx (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2970?vs=7372=7393

D2969: context: move reuse of context object to repo.__getitem__ (API)

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbb47dc2f71a0: context: move reuse of context object to repo.__getitem__ (API) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2969: context: move reuse of context object to repo.__getitem__ (API)

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. That's 2 of us who think this is a good idea. I'm going to queue it. If @smf knows of a reason why this is bad, we can always drop it or revert it. REPOSITORY rHG Mercurial

D2968: memctx: create parent contexts using "repo[p]" syntax

This revision was automatically updated to reflect the committed changes. Closed by commit rHG05ff1a155a21: memctx: create parent contexts using repo[p] syntax (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2967: context: avoid using a context object as a changeid

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdaef13da66fe: context: avoid using a context object as a changeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2966: context: remove unwanted assignments in basectx.__new__() (API)

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd7f3fdab94c4: context: remove unwanted assignments in basectx.__new__() (API) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

  1   2   >