Re: [PATCH] dispatch: split global error handling out so it can be reused

Excerpts from Yuya Nishihara's message of 2016-08-11 17:32:03 +0900: > Okay, queued this, thanks. I've updated test-devel-warnings.t in flight. Sorry for the inconvenience. I sometimes only run a small subset of tests for seemingly-trivial patches. I may want to implement patchbomb hooks and

Re: [PATCH 4 of 4] chg: change server's process title

Excerpts from Yuya Nishihara's message of 2016-08-11 23:28:20 +0900: > On Wed, 10 Aug 2016 18:30:00 +0100, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1470849617 -3600 > > # Wed Aug 10

Re: [PATCH 4 of 4] chg: change server's process title

Excerpts from Yuya Nishihara's message of 2016-08-12 01:55:44 +0900: > Maybe we'll need setproctitle() equivalent for Linux which will update argv? That would be probably rewriting argv[0], afaik. I think it is impossible to get the "argv" pointer in a reasonable way. > 16-char limitation of

Re: [PATCH 4 of 4] chg: change server's process title

Excerpts from Yuya Nishihara's message of 2016-08-12 09:26:37 +0900: > On Thu, 11 Aug 2016 18:28:09 +0100, Jun Wu wrote: > > Excerpts from Yuya Nishihara's message of 2016-08-12 01:55:44 +0900: > > > Maybe we'll need setproctitle() equivalent for Linux which will

Re: [PATCH] remotenames: selectivepull, pull only bookmarks that are in remotenames

The community code usually wraps its commit message at 76-79 chars, like below: Excerpts from Stanislau Hlebik's message of 2016-08-12 02:38:31 -0700: > # HG changeset patch > # User Stanislau Hlebik > # Date 1470994524 25200 > # Fri Aug 12 02:35:24 2016 -0700 > # Node ID

Re: [PATCH] worker: ensure a posix worker exits with os._exit

Excerpts from Yuya Nishihara's message of 2016-08-09 23:45:37 +0900: > I agree we should call _exit(), but the problem wouldn't be that simple. My > understanding is that worker has to propagate an exception so that it will > be caught at dispatch._runcatch() and mapped to an appropriate warning

Re: Making chg stateful

Excerpts from Yuya Nishihara's message of 2017-02-04 00:31:45 +0900: > On Fri, 3 Feb 2017 09:33:32 +0000, Jun Wu wrote: > > 1) What does the worker talk to the master via IPC? > > > > Current: worker sends "possible_dirty_repo: $REPO_PATH" after runco

Re: Making chg stateful

Excerpts from Yuya Nishihara's message of 2017-02-04 00:11:22 +0900: > On Thu, 2 Feb 2017 16:56:11 +0000, Jun Wu wrote: > > Excerpts from Yuya Nishihara's message of 2017-02-03 00:45:22 +0900: > > > On Thu, 2 Feb 2017 09:34:47 +, Jun Wu wrote: > > >

Re: Making chg stateful

Fixes a mysterious typo that affects reading. Excerpts from Jun Wu's message of 2017-02-02 09:34:47 +: > This is mainly to discuss more details about chg repo preloading idea [1]. > > Perf Numbers > > I wrote a hacky prototype [2] that shows significant improvements on > various

Making chg stateful

This is mainly to discuss more details about chg repo preloading idea [1]. Perf Numbers I wrote a hacky prototype [2] that shows significant improvements on various commands in our repo: Before After (in seconds) chg bookmark 0.40

Re: [PATCH stable] commandserver: handle backlog before exiting

Excerpts from Yuya Nishihara's message of 2017-01-31 23:36:46 +0900: > > This introduces another race condition that unlinks an innocent socket file. > > I will send a V2 later. (This actually seems to be a regression after the socketserver refactoring. It probably requires sub-classing

Re: [PATCH stable] commandserver: handle backlog before exiting

Excerpts from Yuya Nishihara's message of 2017-02-01 00:48:26 +0900: > On Tue, 31 Jan 2017 15:24:42 +0000, Jun Wu wrote: > > Excerpts from Yuya Nishihara's message of 2017-01-31 23:36:46 +0900: > > > > This introduces another race condition that unlinks an innocent socket &g

Re: [PATCH v2] pager: migrate heavily-used extension into core

Excerpts from Augie Fackler's message of 2017-02-06 17:52:30 -0500: > (sending again because this seems to have gotten stuck somewhere...) > (+yuya explicitly for chg thoughts, +smf so someone else can forward to the > list if it's stuck again) chg would be fine so long as ui.pager() calls

[PATCH] chg: verify XDG_RUNTIME_DIR

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1486429266 28800 # Mon Feb 06 17:01:06 2017 -0800 # Node ID 8081cb8c346f1ccfa8c98e94d7e25cdfccafeb06 # Parent b6c051cd1231910b0981edb01b173cd53a3338d0 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: Making chg stateful

Excerpts from Yuya Nishihara's message of 2017-02-05 13:31:29 +0900: > > > Since we shouldn't pass repo to revlog (it's layering violation), I think > > > we'll need a thin wrapper for chgcache anyway. > > > > I mentioned this in the second mail, "4) Where to get preloaded results (in > >

Re: [PATCH] dispatch: treat SIGPIPE as a termination signal (BC)

Actually that's not a problem since the output is redirected to the pager and it won't get printed out. Excerpts from Jun Wu's message of 2017-02-07 12:17:00 -0800: > This approach looks good to me. The only problem is it will print "killed!" > on SIGPIPE so maybe a follow-up to make it silent. >

Re: [PATCH] pager: backed out changeset aaa751585325

I've marked this as Superseded, as Simon's patch is a better fix. Excerpts from Jun Wu's message of 2017-02-07 11:23:42 -0800: > # HG changeset patch > # User Jun Wu <qu...@fb.com> > # Date 1486495380 28800 > # Tue Feb 07 11:23:00 2017

Re: [PATCH] dispatch: treat SIGPIPE as a termination signal (BC)

This approach looks good to me. The only problem is it will print "killed!" on SIGPIPE so maybe a follow-up to make it silent. Excerpts from Simon Farnsworth's message of 2017-02-07 12:08:29 -0800: > # HG changeset patch > # User Simon Farnsworth > # Date 1486498104 28800 > #

Re: [PATCH V2] localrepo: avoid unnecessary conversion from node to rev

V1 was accepted and in hg-committed [1] already. I don't know the official recommended workflows but I used to just push follow-up fixes. In general, it's a good practice to use hg-committed instead of the hg repo for development, to avoid potential conflicts with other changes. [1]:

Re: Does chg need to be its own program?

I think you are talking about the "entry point", which is different from "chg". At Facebook, "hg" is a wrapper that reads a tiny config file, and calls either "chg" or "hg.real", where "hg.real" is the "hg" script elsewhere. So it makes sense to have a very lightweight binary that basically

[PATCH 1 of 2 V2] commandserver: prevent unlink socket twice

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1486593458 28800 # Wed Feb 08 14:37:38 2017 -0800 # Node ID 5fc577761fb78168fcbd7ec93d911a1b7b4989c9 # Parent a68510b69f413545722c086eaeb840dd5e8305b4 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 2 of 2 V2] commandserver: handle backlog before exiting

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1486593930 28800 # Wed Feb 08 14:45:30 2017 -0800 # Node ID cb56fce57eceef2cf4cd9893d387b9fe2b3cecd6 # Parent 5fc577761fb78168fcbd7ec93d911a1b7b4989c9 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 2 of 4 RFC] chgcache: implement simple IPC mechanism

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1486601798 28800 # Wed Feb 08 16:56:38 2017 -0800 # Node ID 8410c4a6703bed4b459cf8d62bd32fdcb1e7 # Parent 138f7ba58a70de9610713b8bd55d1ba0ac468fa6 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 1 of 4 RFC] chgcache: new experimental extension

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1486601732 28800 # Wed Feb 08 16:55:32 2017 -0800 # Node ID 138f7ba58a70de9610713b8bd55d1ba0ac468fa6 # Parent a68510b69f413545722c086eaeb840dd5e8305b4 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 4 of 4 RFC] chgcache: add the background preloading thread

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1486604289 28800 # Wed Feb 08 17:38:09 2017 -0800 # Node ID 79adf3722f1b0f602e9461f13fa940a25dbfce56 # Parent 88c498ad9318df115d8408412a38edbac7d92a6a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 3 of 4 RFC] chgcache: report repo paths from worker to master

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1486603691 28800 # Wed Feb 08 17:28:11 2017 -0800 # Node ID 88c498ad9318df115d8408412a38edbac7d92a6a # Parent 8410c4a6703bed4b459cf8d62bd32fdcb1e7 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH] zeroconf: fail nicely on IPv6 only system

This does not work if the hardcoded 127.0.0.1 is not known to the system: sudo ip addr del 127.0.0.1/8 dev lo # on Linux That could happen if the system is IPv6-only, or only has other addresses in the 127./8 subnet like 127.0.0.2, or does not have a "lo" device. I think the pathological

Re: [PATCH] localrepo: avoid unnecessary conversion from node to rev

This patch looks good to me. See inline comment about how to make it faster. That could probably be fixed in flight. Excerpts from Stanislau Hlebik's message of 2017-02-02 02:57:24 -0800: > # HG changeset patch > # User Stanislau Hlebik > # Date 1486032998 28800 > # Thu Feb 02

Re: Making chg stateful

Excerpts from Simon Farnsworth's message of 2017-02-02 15:25:45 +: > On 02/02/2017 09:34, Jun Wu wrote: > > > > What's the API? > > > > (This is an existing implementation detail. I'm open to any ideas) > > > > For example, let's say we wa

Re: Making chg stateful

Excerpts from Yuya Nishihara's message of 2017-02-05 13:59:32 +0900: > Perhaps that is a matter of taste, I like the explicit one. But I heard > Python 3 has a generator-based coroutine, so using "yield" for that purpose > is more common in Python 3? > > @preload('index') > def

Re: [PATCH v2] pager: migrate heavily-used extension into core

Excerpts from Augie Fackler's message of 2017-02-05 22:24:39 -0500: > > On Sun, Feb 5, 2017 at 1:44 AM, Yuya Nishihara wrote: > > I like the direction of this patch, but this still involves a behavior > > change. If PAGER variable is set but pager extension disabled, pager will > >

Re: [PATCH 1 of 6 v2] pager: don't terminate with extreme prejudice on SIGPIPE (BC)

Excerpts from Yuya Nishihara's message of 2017-02-03 22:59:07 +0900: > On Thu, 2 Feb 2017 12:04:09 -0800, Bryan O'Sullivan wrote: > > On Thu, Feb 2, 2017 at 11:18 AM, Simon Farnsworth wrote: > > > > > pager: don't terminate with extreme prejudice on SIGPIPE (BC) > > > > > > >

[PATCH] pager: backed out changeset aaa751585325

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1486495380 28800 # Tue Feb 07 11:23:00 2017 -0800 # Node ID 8cfbd33c54779d1bbd50412e99f8256eea954401 # Parent a68510b69f413545722c086eaeb840dd5e8305b4 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: Making chg stateful

ield preload.update(content, hash) This also looks more flexible - we may extend the preloading framework by adding more contents. Excerpts from Yuya Nishihara's message of 2017-02-03 00:45:22 +0900: > On Thu, 2 Feb 2017 09:34:47 +, Jun Wu wrote: > > Perf Numbers > > &g

Re: Making chg stateful

Excerpts from Yuya Nishihara's message of 2017-02-03 00:45:22 +0900: > On Thu, 2 Feb 2017 09:34:47 +0000, Jun Wu wrote: > > Perf Numbers > > > > I wrote a hacky prototype [2] that shows significant improvements on > > v

[PATCH stable] commandserver: handle backlog before exiting

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1485794838 0 # Mon Jan 30 16:47:18 2017 + # Node ID 0f9c5c49ad7ac321f6fecb4ca90121969bb038d4 # Parent ea5353feeec3c2eddd7e4acfd398baddaf37b3e4 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 1 of 4] runtests: add a function to test if IPv6 is available

Excerpts from Augie Fackler's message of 2017-02-15 21:23:37 -0500: > I'm not overjoyed at the static default. Is there a reason to use the > static default instead of checking HGPORT, so that multiple users on a > single box (such as the big compile farm machine several of us favor) > can run the

[PATCH] localrepo: move extension loading to a separate method

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487216474 28800 # Wed Feb 15 19:41:14 2017 -0800 # Node ID dda2ebe89f50fcf3bf5a9b8d2266aa2dd5b106ea # Parent e5363cb96233861fc99f7e9b85d7884d3121558c # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 1 of 4] runtests: add a function to test if IPv6 is available

Excerpts from Augie Fackler's message of 2017-02-15 21:32:38 -0500: > On Wed, Feb 15, 2017 at 06:26:11PM -0800, Jun Wu wrote: > > Excerpts from Augie Fackler's message of 2017-02-15 21:23:37 -0500: > > > I'm not overjoyed at the static default. Is there a reason to use the &g

[PATCH] chgserver: move comments in config example

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487212221 28800 # Wed Feb 15 18:30:21 2017 -0800 # Node ID 894c348d49abb67613b156a2f7c60a840818bc39 # Parent e5363cb96233861fc99f7e9b85d7884d3121558c # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH] runtests: check ports on IPv6 address

Excerpts from Augie Fackler's message of 2017-02-15 23:27:23 -0500: > >> Heh, I reported the flakiness on #mercurial earlier today. That's why > >> Jun sent a series of patches maybe 2 hours ago that you then queued. > >> Have you tested with those patches applied? I have not had time to > >> look

Re: RFC: bitmap storage for precursors and phases

Excerpts from Sean Farley's message of 2017-02-21 15:45:44 -0800: > Augie Fackler <r...@durin42.com> writes: > > > On Fri, Feb 17, 2017 at 07:14:12PM -0800, Jun Wu wrote: > >> Excerpts from Bryan O'Sullivan's message of 2017-02-17 13:29:58 -0800: > >> >

[PATCH] smartset: preserve istopo for baseset operations

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487723371 28800 # Tue Feb 21 16:29:31 2017 -0800 # Node ID 70e221675023dc23b5da10ae0c1d6baffdd6dd93 # Parent 37ab9e20991c1d39014db8297065357fbded0213 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Phase based repoview?

This is a proposal that adds a new "archived" phase so we have "public > draft > secret > archived", and archived changesets are hidden. It was an idea I mentioned causally on IRC, and interested some people. I figured out that I had mentioned the same idea 5 months ago, where marmoute pointed me

Re: [PATCH 1 of 2] chg: refactor ui.system() to be partly overridden

The series is a nice refator and looks good to me. Excerpts from Yuya Nishihara's message of 2017-02-19 02:44:51 +0900: > # HG changeset patch > # User Yuya Nishihara > # Date 1487433610 -32400 > # Sun Feb 19 01:00:10 2017 +0900 > # Node ID

Re: [PATCH 1 of 2] smartset: convert set to list lazily

Excerpts from Martin von Zweigbergk's message of 2017-02-18 17:03:12 -0800: > @@ -205,5 +215,5 @@ class baseset(abstractsmartset): > > def __nonzero__(self): > -return bool(self._list) > +return bool(len(self)) > > Could delete method, I think. Just FYI. No, because

Re: [PATCH] smartset: reorder initialization of baseset in more intuitive way

Looks good to me. Thanks for the clean-up! Excerpts from Yuya Nishihara's message of 2017-02-18 18:48:06 +0900: > # HG changeset patch > # User Yuya Nishihara > # Date 1487407072 -32400 > # Sat Feb 18 17:37:52 2017 +0900 > # Node ID 1ca3469fdd08c0d5d814a4bc359869bc157c7fc9 >

Re: [PATCH 8 of 9 pager v2] annotate: migrate to modern pager API

Excerpts from Yuya Nishihara's message of 2017-02-19 11:04:19 +0900: > On Sat, 18 Feb 2017 15:39:08 -0500, Augie Fackler wrote: > > > > > On Feb 18, 2017, at 3:11 PM, Martin von Zweigbergk > > > wrote: > > > > > >> > --- a/mercurial/commands.py > > >> > +++

Re: [PATCH 04 of 10 ipv6 V2] tinyproxy: use IPv6 if HGIPV6 is set to 1

Excerpts from David Soria Parra's message of 2017-02-20 13:48:40 -0800: > On Fri, Feb 17, 2017 at 10:51:18AM -0800, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1487228025 28800 > > # Wed Feb 15

Re: RFC: bitmap storage for precursors and phases

Excerpts from Stanislau Hlebik's message of 2017-02-17 11:24:34 +: > As I said before we will load all non-public revs in one set and all The problem is, loading a Python set from disk is O(size-of-the-set). Bitmap's loading cost should be basically 0 (with mmap). I think that's why we want

[PATCH 09 of 10 ipv6 V2] runtests: always set web.ipv6

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487263439 28800 # Thu Feb 16 08:43:59 2017 -0800 # Node ID cfcb22413b1958bb3c1ffe961b7471e8802abe59 # Parent d6c00b275ebe044afb891ee3f3491cde210583b0 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 06 of 10 ipv6 V2] dummyssh: use LOCALIP

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487229843 28800 # Wed Feb 15 23:24:03 2017 -0800 # Node ID bb7f41b2c8043a3115f242fb9b9f71ee461c93a9 # Parent 9222c925de31506ee513f58a913ddec0c3a8a9c5 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 10 of 10 ipv6 V2] runtests: add an IPv6 command line flag

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487323275 28800 # Fri Feb 17 01:21:15 2017 -0800 # Node ID b1c5a6273c7b670337a48270045cc79e1cb39eb6 # Parent cfcb22413b1958bb3c1ffe961b7471e8802abe59 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 07 of 10 ipv6 V2] tests: use LOCALIP

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487266732 28800 # Thu Feb 16 09:38:52 2017 -0800 # Node ID 1ea3da89ecc44b59e96cb366e6388c1ac178d3af # Parent bb7f41b2c8043a3115f242fb9b9f71ee461c93a9 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 08 of 10 ipv6 V2] runtests: set web.address to localhost

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487232809 28800 # Thu Feb 16 00:13:29 2017 -0800 # Node ID d6c00b275ebe044afb891ee3f3491cde210583b0 # Parent 1ea3da89ecc44b59e96cb366e6388c1ac178d3af # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 01 of 10 ipv6 V2] runtests: prefer IPv4 to IPv6

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487321949 28800 # Fri Feb 17 00:59:09 2017 -0800 # Node ID 85e1f03110abeaab9a82517f5716a1cab7044042 # Parent 3844b3299a53b3746e1a708c84bbd6b83adddb7d # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 04 of 10 ipv6 V2] tinyproxy: use IPv6 if HGIPV6 is set to 1

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487228025 28800 # Wed Feb 15 22:53:45 2017 -0800 # Node ID c34ad0f0fc375de9e2d96d17ddcb644d9054d154 # Parent 5e76ef1698fde7a47fa78003beac71324793d051 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 03 of 10 ipv6 V2] dumbhttp: use IPv6 if HGIPV6 is set to 1

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487221740 28800 # Wed Feb 15 21:09:00 2017 -0800 # Node ID 5e76ef1698fde7a47fa78003beac71324793d051 # Parent a16166a6c56f6289252a9c2e72117385756a45c3 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 02 of 10 ipv6 V2] runtests: export HGIPV6 to hint test scripts whether to use IPv6

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487221422 28800 # Wed Feb 15 21:03:42 2017 -0800 # Node ID a16166a6c56f6289252a9c2e72117385756a45c3 # Parent 85e1f03110abeaab9a82517f5716a1cab7044042 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 1 of 2] dispatch: move detection of profiling earlier during startup

This breaks extensions that wraps maybeprofile, namely fb-hgext/profiling.py which tries to log interactive time. That said, I think we could just remove profiling.py as Simon's change is a superior solution. Excerpts from Bryan O'Sullivan's message of 2017-02-13 20:50:10 -0800: > # HG changeset

Re: [PATCH 10 of 10 ipv6 V2] runtests: add an IPv6 command line flag

Excerpts from Martin von Zweigbergk's message of 2017-02-17 14:56:24 -0800: > > Unused. Should I drop in flight? > > I ended up doing that. This is now queued, thanks. Thanks! Sorry about the unused variable. I recently switched to gcc112 for faster testing and it does not run pyflakes somehow

Re: RFC: bitmap storage for precursors and phases

Excerpts from Bryan O'Sullivan's message of 2017-02-17 13:29:58 -0800: > On Fri, Feb 17, 2017 at 10:30 AM, Jun Wu <qu...@fb.com> wrote: > > > Excerpts from Stanislau Hlebik's message of 2017-02-17 11:24:34 +: > > > As I said before we will load all non-pub

Re: RFC: bitmap storage for precursors and phases

Excerpts from Stanislau Hlebik's message of 2017-02-17 16:06:33 +: > This is implementation of two caches (nonpublic + precursor) using > serialized sorted lists and sets > https://bitbucket.org/stashlebik/hg/commits/99879579ac2848a2567810b677d8344150a7b319?at=hiddenbitmaps_lists I had a

[PATCH 2 of 2] smartset: use native set operations as fast paths

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487396855 28800 # Fri Feb 17 21:47:35 2017 -0800 # Node ID 1315d68b1dcf55247f51208608d139029eaae632 # Parent b32af6cafb9b958decb7ae0db7dd754aa5a5f883 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 1 of 2] smartset: convert set to list lazily

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487393969 28800 # Fri Feb 17 20:59:29 2017 -0800 # Node ID b32af6cafb9b958decb7ae0db7dd754aa5a5f883 # Parent 01eebb65a61d9edcad1665ed747c7092f1ddb8b9 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 2 of 3 V2] revset: use phasecache.getrevset

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487407171 28800 # Sat Feb 18 00:39:31 2017 -0800 # Node ID 432992303718ec631b81a351795071c34cfe68f6 # Parent 7e30a7c38d845e9a526a7ac64c648f18ec51687e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 1 of 3 V2] phases: add a getrevset method to phasecache

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487400545 28800 # Fri Feb 17 22:49:05 2017 -0800 # Node ID 7e30a7c38d845e9a526a7ac64c648f18ec51687e # Parent 1315d68b1dcf55247f51208608d139029eaae632 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 3 of 3 V2] obsolete: avoid using revset language to compute the obsolete revset

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487408120 28800 # Sat Feb 18 00:55:20 2017 -0800 # Node ID 286567ff59dbf6cc5645f878b8b223c94c3e4116 # Parent 432992303718ec631b81a351795071c34cfe68f6 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH] merge: add resolve --prep, which outputs conflicted comparison files

Congratulations on your first patch to the list! But I think we have better ways to achieve the same goal that we may prefer them to this patch. 1) Better way to provide conflicted file contents - in-python merge tools From a high-level, the patch tries to solve the problem: - Get all

Re: [PATCH STABLE] worker: ignore meaningless exit status indication returned by os.waitpid()

Looks great to me. Thanks for examining it carefully! I can confirm it from FreeBSD kernel code [1]: sys_wait4 -> kern_wait | sys_wait6 -> kern_wait6 -> proc_to_reap # write status [1]:

Re: [PATCH STABLE V2] worker: ignore meaningless exit status indication returned by os.waitpid()

Looks good. Thanks again for discovering the subtle issue. Excerpts from FUJIWARA Katsunori's message of 2017-02-25 01:11:11 +0900: > # HG changeset patch > # User FUJIWARA Katsunori > # Date 1487952472 -32400 > # Sat Feb 25 01:07:52 2017 +0900 > # Branch stable > #

Re: [PATCH] merge: add resolve --prep, which outputs conflicted comparison files

Excerpts from Phil Cohen's message of 2017-02-24 14:54:00 -0800: > Hi Jun, > > Interesting, thanks. So if I understand correctly, if --tool accepted > a Python function, to replicate the functionality described here, the > user could write a simple script that wrote out the four* versions to

Re: [PATCH] merge: add resolve --prep, which outputs conflicted comparison files

Excerpts from Durham Goode's message of 2017-02-24 15:42:34 -0800: > Maybe I don't understand your proposal. The current merge-tools are > invoked once per file. Would this python merge-tool be invoked in some > other way where it's given the full conflict state at the beginning then > it can

[PATCH] wireproto: remove unused code

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487787258 28800 # Wed Feb 22 10:14:18 2017 -0800 # Node ID 2cf1e5207fdfb3beac255dbacf74b8ac03e5125d # Parent 80f04ba7f4d1f439d726068f02172f9a52b981fe # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 04 of 10] localrepo: move ui loading to baselocalrepository

Excerpts from Yuya Nishihara's message of 2017-02-23 22:05:24 +0900: > On Wed, 22 Feb 2017 20:27:39 -0800, Jun Wu wrote: > > Excerpts from Kevin Bullock's message of 2017-02-22 20:31:14 -0600: > > > There's another alternative we might consider: can we move all of the > &

[PATCH 2 of 2 V2] smartset: use native set operations as fast paths

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487467423 28800 # Sat Feb 18 17:23:43 2017 -0800 # Node ID 6f57ef05c74567db95f42426499640ad29bc878f # Parent deb48622b857d621606a1cdda4adc868b1c663d4 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 1 of 2 V2] smartset: add some doctests

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487464207 28800 # Sat Feb 18 16:30:07 2017 -0800 # Node ID deb48622b857d621606a1cdda4adc868b1c663d4 # Parent 22722c297b33c2f68a8a34e0b0be0e6a9e0f4759 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 04 of 10 ipv6 V2] tinyproxy: use IPv6 if HGIPV6 is set to 1

Excerpts from David Soria Parra's message of 2017-02-21 09:29:50 -0800: > [...] > > I think my point is that the correct thing to do, is to bind on v6/v4 if > available at all times (that includes hg serve, i look into this) instead > of make it a switch, as that would defeat the address

Re: [PATCH 3 of 4 V3] update: also suggest --merge when non-linear update is aborted

Excerpts from Augie Fackler's message of 2017-02-21 11:08:05 -0500: > > "hg update --abort"? > > I'd be a big fan of having an update --abort that just takes you back to > where you were before the conflicts. To date, nobody has been motivated > enough to do the work (I'd love to do it, but it's

Re: [PATCH 1 of 4 V4] update: accept --merge to allow merging across topo branches (issue5125)

I like the behavior change (didn't check the implementation details carefully). Could you also update the table in the docstring of merge.update? I think that's very helpful to explain the behavior cleanly. Thanks! Excerpts from Martin von Zweigbergk's message of 2017-02-16 08:59:12 -0800: > #

[PATCH 1 of 4 V2] chgcache: implement socketpair-based IPC

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487802520 28800 # Wed Feb 22 14:28:40 2017 -0800 # Node ID aef9e96fb573b85f5731367a470f574dbe730839 # Parent 80f04ba7f4d1f439d726068f02172f9a52b981fe # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 4 of 4 V2] chgserver: start background preloading thread

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487814470 28800 # Wed Feb 22 17:47:50 2017 -0800 # Node ID 5c44925eab9a424369967e852b05f42443eac3a6 # Parent 28571825744fb4f4b424385f55afa9484532ef43 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 3 of 4 V2] chgcache: implement the background preloading thread

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487813979 28800 # Wed Feb 22 17:39:39 2017 -0800 # Node ID 28571825744fb4f4b424385f55afa9484532ef43 # Parent 630457e88fa0485bce7822345ea640b5cdcb9b8e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 1 of 2 RESEND] help: hide command line options marked as "advanced"

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1478011845 0 # Tue Nov 01 14:50:45 2016 + # Node ID a9d70a1a09e4e391f8ec22d10831999d7c3e5294 # Parent 80f04ba7f4d1f439d726068f02172f9a52b981fe # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 2 of 2 RESEND] serve: mark --stdio and --cmdserver as "(ADVANCED)" flags

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487816772 28800 # Wed Feb 22 18:26:12 2017 -0800 # Node ID 8bc0039a28785dce6e9aa05e7323986b92833068 # Parent a9d70a1a09e4e391f8ec22d10831999d7c3e5294 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 04 of 10] localrepo: move ui loading to baselocalrepository

Excerpts from Kevin Bullock's message of 2017-02-22 20:31:14 -0600: > There's another alternative we might consider: can we move all of the > "side effects" out of the localrepository class entirely? That is, instead > of resorting to inheritance, could we create a lower-level "repo storage" >

Re: [PATCH 2 of 4 RFC] chgcache: implement simple IPC mechanism

Excerpts from Yuya Nishihara's message of 2017-02-14 22:49:34 +0900: > On Mon, 13 Feb 2017 09:46:21 -0800, Jun Wu wrote: > > Excerpts from Yuya Nishihara's message of 2017-02-13 23:00:25 +0900: > > > Why not os.pipe()? > > > > > > We share the same (du

Re: [PATCH 10 of 10 shelve-ext v3] shelve: disable inhibit for shelving period

Excerpts from Sean Farley's message of 2017-02-13 12:08:39 -0800: > I didn't see any mention of inhibit in Mercurial? Is this a FB > extension? If so, should this logic be in hgext/shelve.py or in the FB > extension? (honest question) It's part of mutable-history and (imo) should be killed sooner

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

Excerpts from Augie Fackler's message of 2017-02-13 14:55:57 -0500: > On Fri, Feb 10, 2017 at 04:50:55PM -0800, Jun Wu wrote: > > I'd like to note that although this patch prevents repo corruption when > > running hg inside different containers (which has different pid namespace

Re: [PATCH RFC v10] scmutil: add a simple key-value file helper

As said before, I still prefer a simpler design without the "required" boolean flag, and move the responsibility of checking requirements to the higher-level code. Because: - As Yuya pointed out at the first place, "required" here will have trouble dealing with future schema changes. So

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

Excerpts from Siddharth Agarwal's message of 2017-02-13 13:07:08 -0800: > On 2/13/17 13:03, Jun Wu wrote: > > I think it could be an extension outside core. > > I'd say make it a clone-time option, turned off by default, with caveats > documented. At FB we ban the situations wh

Re: RFC: bitmap storage for precursors and phases

Excerpts from Sean Farley's message of 2017-02-13 17:04:35 -0800: > I was thinking about a more high-level approach (please feel free to > pick apart): > > r = repo.filtered("bitmap1") > r2 = r.filtered("bitmap2") > > So that r2 would be an intersection of bitmap1 and bitmap2 (haven't > thought

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

Excerpts from Gregory Szorc's message of 2017-02-13 17:22:59 -0700: > > > On Feb 13, 2017, at 12:55, Augie Fackler <r...@durin42.com> wrote: > > > >> On Fri, Feb 10, 2017 at 04:50:55PM -0800, Jun Wu wrote: > >> I'd like to note that although this patch pre

Re: [PATCH 04 of 10] localrepo: move ui loading to baselocalrepository

Excerpts from Augie Fackler's message of 2017-02-13 18:58:59 -0500: > On Fri, Feb 10, 2017 at 01:07:49PM -0800, Jun Wu wrote: > > Side-effects are basically everything related to writes, like mutating > > (wrapping) internal Python objects, etc. They are done by Python co

[PATCH] ui: fix configwith doctest

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1487048450 28800 # Mon Feb 13 21:00:50 2017 -0800 # Node ID ba4d509ef528627871e26172fcf9cfd71c2195c4 # Parent f2ad0d8047009e6e58ab1fa34ae7107714f5dc30 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: RFC: bitmap storage for precursors and phases

In general, I think this is a good direction. Some random thoughts: - general purposed I think the bitmap is not always a cache, so it should only have operations like set/unset/readfromdisk/writetodisk. Practically, I won't couple cache invalidation with the bitmap implementation.

[PATCH 03 of 10] localrepo: move join and wjoin to baselocalrepository

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1486675027 28800 # Thu Feb 09 13:17:07 2017 -0800 # Node ID 2c1834e1e6b5f734c27199d47de9b2252b8f4913 # Parent 245b1d962dcd5df48f929f10f786dc53936daabf # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 04 of 10] localrepo: move ui loading to baselocalrepository

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1486675034 28800 # Thu Feb 09 13:17:14 2017 -0800 # Node ID 5e47a19fae82f4659f1e7df37f8f26dd56c4f246 # Parent 2c1834e1e6b5f734c27199d47de9b2252b8f4913 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 06 of 10] scmutil: allow reading repo requires without checking

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1486687506 28800 # Thu Feb 09 16:45:06 2017 -0800 # Node ID d93bba366d42f9537a5556d7ff948848b608d02c # Parent 76448b71f139b1fa06f2dbce04ac3f91ffd93f9d # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 05 of 10] localrepo: move supported to baselocalrepository

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1486689390 28800 # Thu Feb 09 17:16:30 2017 -0800 # Node ID 76448b71f139b1fa06f2dbce04ac3f91ffd93f9d # Parent 5e47a19fae82f4659f1e7df37f8f26dd56c4f246 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

  1   2   3   4   5   6   7   8   9   10   >