Re: [PATCH 3 of 3] histedit: revive commits on demand

Excerpts from Pierre-Yves David's message of 2017-03-27 13:16:15 +0200: > > On 03/27/2017 12:29 PM, Jun Wu wrote: > > Excerpts from Pierre-Yves David's message of 2017-03-27 09:17:59 +0200: > >> > >> On 03/26/2017 08:41 PM, Jun Wu wrote: > >>> #

[PATCH 1 of 2 RFC] RFC: implement immutable config objects

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490635856 25200 # Mon Mar 27 10:30:56 2017 -0700 # Node ID 4eb7c76340791f379a34f9df4ec42e0c8b9b2a2f # Parent 4a8d065bbad80d3b3401010375bc80165404aa87 RFC: implement immutable config objects The immutable config objects are basi

[PATCH 2 of 2 RFC] RFC: switch to immutable configs

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490639836 25200 # Mon Mar 27 11:37:16 2017 -0700 # Node ID 13bee3e959f04f970f2fc0a01120f0b30d725b84 # Parent 4eb7c76340791f379a34f9df4ec42e0c8b9b2a2f RFC: switch to immutable configs This replaces "ui" so it's ba

Re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way

n an appropriate way > > > > > > Potentially frequent usecase is to hide nodes in the most appropriate > > > for current repo configuration way. Examples of things which use this > > > are rebase (strip or obsolete old nodes), shelve (strip of obsolete > > > t

Re: [PATCH 07 of 10 V5] rcutil: let environ override system configs (BC)

Excerpts from Ryan McElroy's message of 2017-03-28 09:47:18 +0100: > On 3/27/17 7:02 AM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490589217 25200 > > # Sun Mar 26 21:33:37 2017 -0700 > > # Node ID 38572bb2cffd81

Re: [PATCH 02 of 10 V5] rcutil: split osrcpath to return default.d paths (API)

Excerpts from Yuya Nishihara's message of 2017-03-28 21:53:01 +0900: > On Sun, 26 Mar 2017 23:02:01 -0700, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490584892 25200 > > # Sun Mar 26

Re: [PATCH 07 of 10 V5] rcutil: let environ override system configs (BC)

Excerpts from Yuya Nishihara's message of 2017-03-28 21:53:31 +0900: > And we'll need to avoid caching of envrcitems because of chg, could be fixed > by followup. Good catch. I think that also applies to config files - listing a directory cannot be cached either. So it seems the bug has been

[PATCH 1 of 3] rcutil: do not cache rccomponents

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490712840 25200 # Tue Mar 28 07:54:00 2017 -0700 # Node ID f1c156c854ce36010008816ed6c5097a809ba5e5 # Parent c3ca0ad8ab9c60b3d4df4ef1e5e2e7d9e44cec0e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 2 of 3] rcutil: unindent a block

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490712932 25200 # Tue Mar 28 07:55:32 2017 -0700 # Node ID 3990935c7f25e9e42309cbad92e888a1201ac751 # Parent f1c156c854ce36010008816ed6c5097a809ba5e5 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH] chgserver: do not copy configs set by environment variables

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490715612 25200 # Tue Mar 28 08:40:12 2017 -0700 # Node ID 00edeed528adcf61316b83cd281b2ba3bc27c14b # Parent 01cb4d7bd67aca078f3ca74fdbffd5685a17defe # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 2 of 5] merge: use ProgrammingError

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490572556 25200 # Sun Mar 26 16:55:56 2017 -0700 # Node ID 14659f3ffd6070d6e153f633e18fef9e8df29485 # Parent 92d7eff3f4c7e44e8aab62b486bda78a37b73b83 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 4 of 5] transaction: use ProgrammingError

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490572770 25200 # Sun Mar 26 16:59:30 2017 -0700 # Node ID 4b594304a50056b5bde7b193e5496db6f68982dc # Parent 79b332a45f07401b16e0b8cdb861655057773ff7 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 5 of 5] crecord: use ProgrammingError

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490572823 25200 # Sun Mar 26 17:00:23 2017 -0700 # Node ID 234ade0bb549d9d1bd20aba41cd8ddc96619d703 # Parent 4b594304a50056b5bde7b193e5496db6f68982dc # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way

o hide nodes in the most appropriate > for current repo configuration way. Examples of things which use this > are rebase (strip or obsolete old nodes), shelve (strip of obsolete > temporary nodes) and probably others. > Jun Wu had an idea of having one place in core where this functional

[PATCH] runtests: change local IP glob pattern from "127.0.0.1" to "$LOCALIP"

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490583437 25200 # Sun Mar 26 19:57:17 2017 -0700 # Node ID 82f3dbff59306181303549600cd7a307da667d05 # Parent 38ff33314869869535eb8f5c9cf4fa688847010e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 3 of 5] bundle2: use ProgrammingError

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490572645 25200 # Sun Mar 26 16:57:25 2017 -0700 # Node ID 79b332a45f07401b16e0b8cdb861655057773ff7 # Parent 14659f3ffd6070d6e153f633e18fef9e8df29485 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 1 of 2] debugfsinfo: show fstype for given path

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490574577 25200 # Sun Mar 26 17:29:37 2017 -0700 # Node ID 0b8f4bab3597b1621c07bfc82b9c16a77459a9b1 # Parent e86eb75e74ce1b0803c26d86a229b9b711f6d76a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 2 of 2] debugfsinfo: improve case-sensitive testing

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490576373 25200 # Sun Mar 26 17:59:33 2017 -0700 # Node ID 38ff33314869869535eb8f5c9cf4fa688847010e # Parent 0b8f4bab3597b1621c07bfc82b9c16a77459a9b1 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH] runtests: unset editor and pager related environment variables

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490587134 25200 # Sun Mar 26 20:58:54 2017 -0700 # Node ID 65f76087bc84162bdf0735f156d403e873e5c4e8 # Parent e86eb75e74ce1b0803c26d86a229b9b711f6d76a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH] show: new extension for displaying various repository data

Excerpts from Denis Laxalde's message of 2017-03-23 10:14:14 +0100: > Ryan McElroy a écrit : > > On 3/22/17 7:29 AM, Sean Farley wrote: > >> Yuya Nishihara writes: > >> > >>> On Sun, 12 Mar 2017 21:38:00 -0700, Gregory Szorc wrote: > # HG changeset patch > # User Gregory

Re: [PATCH] hardlink: check directory's st_dev instead of files

Excerpts from Yuya Nishihara's message of 2017-03-26 20:50:06 +0900: > On Sat, 25 Mar 2017 13:58:33 -0700, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490475382 25200 > > # Sat Mar 25

[PATCH 2 of 3] metadataonlyctx: make parents and text optional

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490551051 25200 # Sun Mar 26 10:57:31 2017 -0700 # Node ID 336512ee2f947f07149e399a84927f9d820d2b62 # Parent 65636eb4a1e55f69daf6795a9ecad7a3da39108e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH] metadataonlyctx: speed up sanity check

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490556395 25200 # Sun Mar 26 12:26:35 2017 -0700 # Node ID 2793d297600133bb83a5d2f5a46bfa3fadd037ab # Parent b6766d75404fb8c5d26af016caa76f44b47ce156 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 3 of 3] histedit: revive commits on demand

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490552007 25200 # Sun Mar 26 11:13:27 2017 -0700 # Node ID b6766d75404fb8c5d26af016caa76f44b47ce156 # Parent 336512ee2f947f07149e399a84927f9d820d2b62 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 1 of 3] histedit: add a testcase showing the obsolete cycle issue

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490548029 25200 # Sun Mar 26 10:07:09 2017 -0700 # Node ID 65636eb4a1e55f69daf6795a9ecad7a3da39108e # Parent e86eb75e74ce1b0803c26d86a229b9b711f6d76a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 3 of 3] histedit: test that an aborted histedit can be rerun (with obsolete)

I'm -1 on this series. If the goal is to workaround obsolete cycles, the code could do additional checks "if the destination is obsoleted" and do "hg touch"-like thing automatically. That workaround will be no longer necessary if my obsolete cycle patches are landed. Internally, we have several

Re: [PATCH 3 of 3] histedit: revive commits on demand

Excerpts from Jun Wu's message of 2017-03-26 11:41:41 -0700: > # HG changeset patch > # User Jun Wu <qu...@fb.com> > # Date 1490552007 25200 > # Sun Mar 26 11:13:27 2017 -0700 > # Node ID b6766d75404fb8c5d26af016caa76f44b47ce156 > # Parent 336512ee2f947f07

Re: [PATCH STABLE] changegroup: retry read() when partial data returned

The direction looks good. I'd like to see more solid code. Commented below. Excerpts from Gregory Szorc's message of 2017-03-26 11:56:59 -0700: > +# Retry to get remaining data. In cases where the stream has errored or > +# is at EOF, this will do a bit of redundant work. But it helps

Re: [PATCH 4 of 4 V2] obsolete: allow cycles

Excerpts from Gregory Szorc's message of 2017-03-26 11:25:28 -0700: > I have a thought experiment to add. > > The obsolete store is strictly ordered. So for a repo detached from the > world and not doing any exchange, "date" is strictly metadata and the > offset of a marker in the store is all

Re: [PATCH 1 of 4 V2] obsolete: track node versions

Thanks for the detailed reply. I have replies on multiple subtopics. But I deleted topics that I think are less important, to make the most important topic clear, and make the discussion more efficient. If you think I need to respond to more topics, feel free to point me at them. Excerpts from

Re: [PATCH 3 of 3] histedit: revive commits on demand

Excerpts from Pierre-Yves David's message of 2017-03-27 09:17:59 +0200: > > On 03/26/2017 08:41 PM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490552007 25200 > > # Sun Mar 26 11:13:27 2017 -0700 > > # Node I

[PATCH 2 of 2] histedit: make prune markers local

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490610065 25200 # Mon Mar 27 03:21:05 2017 -0700 # Node ID 293c829c83b02501a44a45bc2ed9794cec00e023 # Parent a3e835b04db41230b02233d5c7c3f4dee49407d3 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 03 of 10 V4] rcutil: extra directory listing logic

Excerpts from Jun Wu's message of 2017-03-26 21:49:16 -0700: > # HG changeset patch > # User Jun Wu <qu...@fb.com> > # Date 1490586365 25200 > # Sun Mar 26 20:46:05 2017 -0700 > # Node ID 30a341f7fd233e55615cab11a64a8a521f389783 > # Parent cd0c8320d216165b

[PATCH 10 of 10 V4] pager: do not read from environment variable

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490589827 25200 # Sun Mar 26 21:43:47 2017 -0700 # Node ID 4a8d065bbad80d3b3401010375bc80165404aa87 # Parent cc06430c144b85ae2d53528eb8149f1debdb7706 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 1 of 5] repair: use ProgrammingError

I think ProgrammingError should all have that hint. So this is not repair.py specific. Excerpts from Pierre-Yves David's message of 2017-03-27 08:27:51 +0200: > > On 03/27/2017 02:14 AM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> >

[PATCH 07 of 10 V4] rcutil: let environ override system configs (BC)

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490589217 25200 # Sun Mar 26 21:33:37 2017 -0700 # Node ID bb2927de1dc8c076c6cfe2369effc132e8371beb # Parent 9ba047e9e8b929c0fc38d0606b4c02438a8aef29 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 05 of 10 V4] rcutil: let rccomponents return different types of configs (API)

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490587469 25200 # Sun Mar 26 21:04:29 2017 -0700 # Node ID 9b02412194004dc012e7f3119520138483c22644 # Parent 8caf1898b14bd5017e1b66348e77194a6cb715e0 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 03 of 10 V4] rcutil: extra directory listing logic

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490586365 25200 # Sun Mar 26 20:46:05 2017 -0700 # Node ID 30a341f7fd233e55615cab11a64a8a521f389783 # Parent cd0c8320d216165bd8a62acc711e174ddef7a9f9 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 01 of 10 V4] rcutil: move scmutil.*rcpath to rcutil (API)

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490584722 25200 # Sun Mar 26 20:18:42 2017 -0700 # Node ID dcef7872ff35187d679a79dc6ad62cb9029923b1 # Parent e86eb75e74ce1b0803c26d86a229b9b711f6d76a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 02 of 10 V4] rcutil: split osrcpath to return default.d paths (API)

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490584892 25200 # Sun Mar 26 20:21:32 2017 -0700 # Node ID cd0c8320d216165bd8a62acc711e174ddef7a9f9 # Parent dcef7872ff35187d679a79dc6ad62cb9029923b1 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 08 of 10 V4] debugconfig: list environment variables in debug output

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490589622 25200 # Sun Mar 26 21:40:22 2017 -0700 # Node ID 4ed7dd7a9241b7b792ab6c810d298a70348c9a27 # Parent bb2927de1dc8c076c6cfe2369effc132e8371beb # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 04 of 10 V4] rcutil: rename rcpath to rccomponents (API)

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490586480 25200 # Sun Mar 26 20:48:00 2017 -0700 # Node ID 8caf1898b14bd5017e1b66348e77194a6cb715e0 # Parent 30a341f7fd233e55615cab11a64a8a521f389783 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 09 of 10 V4] ui: simplify geteditor

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490589702 25200 # Sun Mar 26 21:41:42 2017 -0700 # Node ID cc06430c144b85ae2d53528eb8149f1debdb7706 # Parent 4ed7dd7a9241b7b792ab6c810d298a70348c9a27 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 04 of 10 V5] rcutil: rename rcpath to rccomponents (API)

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490586480 25200 # Sun Mar 26 20:48:00 2017 -0700 # Node ID 86998401114d7e4ae6d1c70b4e1b95b74dd1d6e3 # Parent 3d461afe19576560b9b43b4460dd850abbdbd5fe # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 03 of 10 V5] rcutil: extract rc directory listing logic

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490586365 25200 # Sun Mar 26 20:46:05 2017 -0700 # Node ID 3d461afe19576560b9b43b4460dd850abbdbd5fe # Parent cd0c8320d216165bd8a62acc711e174ddef7a9f9 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 05 of 10 V5] rcutil: let rccomponents return different types of configs (API)

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490587469 25200 # Sun Mar 26 21:04:29 2017 -0700 # Node ID fd9854b8f0f8ba25a237eba2196209cde69106dd # Parent 86998401114d7e4ae6d1c70b4e1b95b74dd1d6e3 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 01 of 10 V5] rcutil: move scmutil.*rcpath to rcutil (API)

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490584722 25200 # Sun Mar 26 20:18:42 2017 -0700 # Node ID dcef7872ff35187d679a79dc6ad62cb9029923b1 # Parent e86eb75e74ce1b0803c26d86a229b9b711f6d76a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 02 of 10 V5] rcutil: split osrcpath to return default.d paths (API)

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490584892 25200 # Sun Mar 26 20:21:32 2017 -0700 # Node ID cd0c8320d216165bd8a62acc711e174ddef7a9f9 # Parent dcef7872ff35187d679a79dc6ad62cb9029923b1 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 08 of 10 V5] debugconfig: list environment variables in debug output

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490589622 25200 # Sun Mar 26 21:40:22 2017 -0700 # Node ID 0c745bb07fd82bb9383698c60c042101ee45f4ab # Parent 38572bb2cffd815526a727bc6f3aacdca2902f4f # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 06 of 10 V5] rcutil: add a method to convert environment variables to config items

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490588822 25200 # Sun Mar 26 21:27:02 2017 -0700 # Node ID 9b0aa30bf151b6c0e999b017fd328e29440bd447 # Parent fd9854b8f0f8ba25a237eba2196209cde69106dd # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 03 of 10 V4] rcutil: extra directory listing logic

Excerpts from Jun Wu's message of 2017-03-26 22:18:35 -0700: > Excerpts from Jun Wu's message of 2017-03-26 21:49:16 -0700: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490586365 25200 > > # Sun Mar 26

Re: [PATCH 3 of 3] histedit: test that an aborted histedit can be rerun (with obsolete)

Excerpts from Pierre-Yves David's message of 2017-03-27 09:19:52 +0200: > > On 03/26/2017 08:42 PM, Jun Wu wrote: > > Excerpts from Jun Wu's message of 2017-03-26 09:59:43 -0700: > >> I'm -1 on this series. > >> > >> If the goal is to workaround obsole

Re: [PATCH 2 of 7] revlog: make sure _cache only contain raw content

Excerpts from Ryan McElroy's message of 2017-03-29 13:39:29 +0100: > On 3/28/17 8:49 AM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490685282 25200 > > # Tue Mar 28 00:14:42 2017 -0700 > > # Node ID 99cfe31d37df62

Re: [PATCH 1 of 3] rcutil: do not cache rccomponents

Excerpts from Yuya Nishihara's message of 2017-03-29 21:00:09 +0900: > On Tue, 28 Mar 2017 08:02:54 -0700, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490712840 25200 > > # Tue Mar 28

Re: [PATCH 3 of 7 shelve-ext v5] shelve: add obs-based shelve functionality

As long as evolve does not have a way to unhide a commit. I think we do need to use strip on repos that with obsstore enabled. So I'd say the patch probably needs to be deferred until we can unhide a commit. Excerpts from Kostia Balytskyi's message of 2017-03-30 10:11:55 +: > > On 30/03/2017

Re: [PATCH 4 of 4 V2] obsolete: allow cycles

changes are by myself and haven't been discussed here. Excerpts from Augie Fackler's message of 2017-03-23 18:05:45 -0400: > On Mon, Mar 13, 2017 at 11:57:08AM -0700, Pierre-Yves David wrote: > > > > > > On 03/13/2017 09:23 AM, Durham Goode wrote: > > >On 3/13/17 2:4

Re: [PATCH 1 of 4 V2] obsolete: track node versions

Per discussion on IRC. I'll drop this series from patchwork and send a new version with better documentation and some planned fixes. Excerpts from Jun Wu's message of 2017-03-27 01:49:03 -0700: > Thanks for the detailed reply. I have replies on multiple subtopics. But I > deleted topics that I

Re: [PATCH 1 of 2] verify: document corner cases

Excerpts from Ryan McElroy's message of 2017-03-30 09:55:50 +0100: > On 3/29/17 10:51 PM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490823901 25200 > > # Wed Mar 29 14:45:01 2017 -0700 > > # Node ID 1

Re: [PATCH 4 of 4 V2] obsolete: allow cycles

Excerpts from Augie Fackler's message of 2017-03-30 12:43:31 -0400: > On Thu, Mar 30, 2017 at 12:40 PM, Jun Wu <qu...@fb.com> wrote: > > I'll drop it from patchwork and send a new version with better documentation > > and some planned fixes. The next version

Re: [PATCH] test-check-code: prevent files being added to the root directory

Excerpts from Ryan McElroy's message of 2017-03-30 09:24:38 +0100: > On 3/29/17 8:14 PM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490814860 25200 > > # Wed Mar 29 12:14:20 2017 -0700 > > # Node ID 4

Re: [PATCH 1 of 4 V2] obsolete: track node versions

I think this is a very nice approach to move forward. There are some behavior changes. But I've discussed with Durham and I'm happy about the new behaviors. The "node version" approach achieves "unhide" in a fast and more conservative way. The root-based hidden seems to require some non-trivial

[PATCH 1 of 2 V2] verify: document corner cases

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490823901 25200 # Wed Mar 29 14:45:01 2017 -0700 # Node ID 17b41390f4912a4c18538d778837bc2cf4a1be92 # Parent dea2a17cbfd00bf08ee87b3e44b1c71499189f89 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 2 of 2 V2] verify: fix length check

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490824154 25200 # Wed Mar 29 14:49:14 2017 -0700 # Node ID 35902a0e3f38c76a66d0dfbf76ec72091832 # Parent 17b41390f4912a4c18538d778837bc2cf4a1be92 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 10 of 13 V3] config: list environment variables in debug output

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1489455351 25200 # Mon Mar 13 18:35:51 2017 -0700 # Node ID fa6d527d03e29efc75591e1721ddcbd6b72e4a76 # Parent 6c04717d3b4958800a39fdf6e2c28e2caf6629bd # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 01 of 13 V3] scmutil: add a method to convert environment variables to config items

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1489449998 25200 # Mon Mar 13 17:06:38 2017 -0700 # Node ID 04259bd73d263306f16e25bd4e6bc53faf80911c # Parent 55c6788c54e2faf80ec14f2b0844bfe429012bc3 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 07 of 13 V3] scmutil: extract rc.d listing function from rccomponents

Excerpts from Martin von Zweigbergk's message of 2017-03-22 22:32:53 -0700: > On Wed, Mar 22, 2017 at 10:23 AM, Jun Wu <qu...@fb.com> wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490201429 25200 > > # Wed M

Re: [PATCH 4 of 4 V2] obsolete: allow cycles

Excerpts from Sean Farley's message of 2017-03-22 13:18:29 -0700: > Heh, yes, that made me chuckle. I understand that *you* need this. I'd argue *most people* wants this. See below. > But that's the thing. I'm not taking "inhibit" into consideration > because inhibit isn't a common workflow.

[PATCH 08 of 13 V3] run-tests: drop environment variables affecting configs

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1489455061 25200 # Mon Mar 13 18:31:01 2017 -0700 # Node ID c537d04829a8dc0b88fe03ec41e95a85638c696b # Parent d604e5baed4ac2f5470860bff89728c282d71e3a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 09 of 13 V3] ui: use scmutil.rccomponents to load configs (BC)

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1489462886 25200 # Mon Mar 13 20:41:26 2017 -0700 # Node ID 6c04717d3b4958800a39fdf6e2c28e2caf6629bd # Parent c537d04829a8dc0b88fe03ec41e95a85638c696b # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 02 of 13 V3] scmutil: define a list of configs overriding system rc, but not users

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1489450537 25200 # Mon Mar 13 17:15:37 2017 -0700 # Node ID 61757ff29df4a35351fd31568a14e0880dd5c2d4 # Parent 04259bd73d263306f16e25bd4e6bc53faf80911c # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 06 of 13 V3] scmutil: implement rccomponents to return multiple config sources

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490201209 25200 # Wed Mar 22 09:46:49 2017 -0700 # Node ID 44c865487bfd2f081bfb322b1fb1b700d57f7adf # Parent 0e0f8914507fc0030d66844bde77854266259603 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 3 of 7] revlog: do not return raw cache blindly

Excerpts from Ryan McElroy's message of 2017-03-29 13:40:10 +0100: > On 3/28/17 8:49 AM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490685397 25200 > > # Tue Mar 28 00:16:37 2017 -0700 > > # Node ID d557aaee6ada70

Re: [PATCH 5 of 7] revlog: add a fast path for non-raw revision

Excerpts from Ryan McElroy's message of 2017-03-29 13:41:21 +0100: > On 3/28/17 8:49 AM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490683355 25200 > > # Mon Mar 27 23:42:35 2017 -0700 > > # Node ID aecce2adbd64b2

Re: [PATCH] test-rebase-base: add a note about the test name

Excerpts from Ryan McElroy's message of 2017-03-29 11:35:56 +0100: > On 3/28/17 10:40 PM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490737090 25200 > > # Tue Mar 28 14:38:10 2017 -0700 > > # Node ID 3

Re: [PATCH 4 of 7] revlog: add test to check raw processing is sane

Excerpts from Ryan McElroy's message of 2017-03-29 13:40:41 +0100: > On 3/28/17 8:49 AM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490677106 25200 > > # Mon Mar 27 21:58:26 2017 -0700 > > # Node ID a9d87712bec99a

Re: [PATCH 1 of 5] repair: use ProgrammingError

Excerpts from Pierre-Yves David's message of 2017-03-29 13:24:39 +0200: > > On 03/28/2017 08:59 PM, Ryan McElroy wrote: > > On 3/27/17 2:11 PM, Augie Fackler wrote: > >> On Mon, Mar 27, 2017 at 09:18:55AM +0200, Pierre-Yves David wrote: > >>> Sure, that seems like a good idea. Can you see to it ?

[PATCH] test-rebase-base: add a note about the test name

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490737090 25200 # Tue Mar 28 14:38:10 2017 -0700 # Node ID 31073077267b5e330925d48098dd6e0fd28bdd8e # Parent ce672245b46749351a71701d2fa6c786d9b2eebb # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH] revlog: use raw revision for rawsize

Excerpts from Ryan McElroy's message of 2017-03-29 11:30:50 +0100: > On 3/29/17 4:31 AM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490758201 25200 > > # Tue Mar 28 20:30:01 2017 -0700 > > # Node ID 5c6ebe1cd99e95

[PATCH] test-check-code: prevent files being added to the root directory

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490814860 25200 # Wed Mar 29 12:14:20 2017 -0700 # Node ID 4b4345a62fbd9fb0f4610d013c4ee5c9c06287e0 # Parent cda83a1bfb3ac3a23cfa158c407be93755c1018e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 5 of 6] rebase: demonstrate behavior with requiredest and pull --rebase

Excerpts from Ryan McElroy's message of 2017-03-29 11:38:00 +0100: > drawdag.py I think you mean? > > I suppose a nice thing about drawdag is that you see the dag being > created so its more obvious what's going on without graph logs, but is > it worth a re-send do you think? These tests are

Re: [PATCH] fileset: perform membership test against set for status queries

Looks prefect. Thanks for the fix! Excerpts from Gregory Szorc's message of 2017-03-28 14:41:13 -0700: > # HG changeset patch > # User Gregory Szorc > # Date 1490737213 25200 > # Tue Mar 28 14:40:13 2017 -0700 > # Node ID cf6393b6a3503f8885b704407e5bd58a89b96dfe > #

[PATCH 1 of 2] verify: document corner cases

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490823901 25200 # Wed Mar 29 14:45:01 2017 -0700 # Node ID 1f7890370b5437466534cbd0a313d21671dade03 # Parent e9fda3b8614a8b701bd48041afa8b709e1227f27 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 2 of 2] verify: fix length check

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490824154 25200 # Wed Mar 29 14:49:14 2017 -0700 # Node ID ab735d6798fb133efdc2be8a441b51e7ba4d547b # Parent 1f7890370b5437466534cbd0a313d21671dade03 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH 1 of 2] verify: document corner cases

Excerpts from Jun Wu's message of 2017-03-29 14:51:59 -0700: > # HG changeset patch > # User Jun Wu <qu...@fb.com> > # Date 1490823901 25200 > # Wed Mar 29 14:45:01 2017 -0700 > # Node ID 1f7890370b5437466534cbd0a313d21671dade03 > # Parent e9fda3b8614a8b70

[PATCH 1 of 3 V2] hardlink: extract topic text logic of copyfiles

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490815275 25200 # Wed Mar 29 12:21:15 2017 -0700 # Node ID b1ef68e4196e01f723b78746d752f60e46e33cc0 # Parent cda83a1bfb3ac3a23cfa158c407be93755c1018e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [1,of,2,RFC] RFC: implement immutable config objects

Excerpts from David Soria Parra's message of 2017-03-29 15:25:26 -0700: > On Mon, Mar 27, 2017 at 11:38:06AM -0700, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu <qu...@fb.com> > > # Date 1490635856 25200 > > # Mon Mar 27

Re: [PATCH] verify: check raw revision size

Actually, there are more issues with "verify". I'll send an updated version, probably with a test. Excerpts from Jun Wu's message of 2017-03-28 14:27:38 -0700: > # HG changeset patch > # User Jun Wu <qu...@fb.com> > # Date 1490736238 25200 > # Tue Mar 28 14:

[PATCH] test-verify: add a testcase where the file has magic meta header

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490820077 25200 # Wed Mar 29 13:41:17 2017 -0700 # Node ID e9fda3b8614a8b701bd48041afa8b709e1227f27 # Parent cda83a1bfb3ac3a23cfa158c407be93755c1018e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: [PATCH] hardlink: check directory's st_dev instead of files

I'll drop this and send a better version. Excerpts from Jun Wu's message of 2017-03-26 09:53:11 -0700: > Excerpts from Yuya Nishihara's message of 2017-03-26 20:50:06 +0900: > > On Sat, 25 Mar 2017 13:58:33 -0700, Jun Wu wrote: > > > # HG changeset patch > > >

[PATCH 2 of 3 V2] hardlink: duplicate hardlink detection for copying files and directories

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490815606 25200 # Wed Mar 29 12:26:46 2017 -0700 # Node ID b4e6f395c7940676c56b6f5308e203aa861d8bbe # Parent b1ef68e4196e01f723b78746d752f60e46e33cc0 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 3 of 3 V2] hardlink: check directory's st_dev when copying files

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490816223 25200 # Wed Mar 29 12:37:03 2017 -0700 # Node ID e9e48ce378c982f4ecbace5dd61ba85d1fc12ad6 # Parent b4e6f395c7940676c56b6f5308e203aa861d8bbe # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 4 of 5] unionrepo: avoid unnecessary node -> rev conversion

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490830131 25200 # Wed Mar 29 16:28:51 2017 -0700 # Node ID 265ea657d75905fb59a27194a75aaff49be94598 # Parent 2d3258eca3f07d249991fcb14e6bfd9a687d07e2 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

Re: Hardlinks and Docker

Excerpts from Gregory Szorc's message of 2017-03-29 18:15:43 -0700: > > So the direct fix is to stat the directory instead of the file. I will send > > it soon. > > Thank you for looking into this complicated issue! I'm glad I don't have > to review your code because this is all over my head at

Re: [2,of,2,RFC] RFC: switch to immutable configs

Excerpts from David Soria Parra's message of 2017-03-29 15:56:21 -0700: > > +# immutable configs > > +self._ocfgs = config.mergedconfig('setconfig', []) # overlay > > +self._tcfgs = config.mergedconfig('loaded', []) # trusted > i would probably actually call

[PATCH 1 of 5] check-code: detect r.revision(r.node(rev))

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490831217 25200 # Wed Mar 29 16:46:57 2017 -0700 # Node ID e28b3818efa140482be9849f7bd8dd915e25fa07 # Parent cda83a1bfb3ac3a23cfa158c407be93755c1018e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 3 of 5] bundlerepo: avoid unnecessary node -> rev conversion

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490830080 25200 # Wed Mar 29 16:28:00 2017 -0700 # Node ID 2d3258eca3f07d249991fcb14e6bfd9a687d07e2 # Parent 21926bb9a6adbadc1f715dc0a71ac53a3c4d8019 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 5 of 5] perf: workaround check-code

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490831529 25200 # Wed Mar 29 16:52:09 2017 -0700 # Node ID 5ca313b3da12d145f1d49a85dd8b753e22d51521 # Parent 265ea657d75905fb59a27194a75aaff49be94598 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 2 of 5] revlog: avoid unnecessary node -> rev conversion

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490829784 25200 # Wed Mar 29 16:23:04 2017 -0700 # Node ID 21926bb9a6adbadc1f715dc0a71ac53a3c4d8019 # Parent e28b3818efa140482be9849f7bd8dd915e25fa07 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH] verify: check raw revision size

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490736238 25200 # Tue Mar 28 14:23:58 2017 -0700 # Node ID ce672245b46749351a71701d2fa6c786d9b2eebb # Parent 331cc4433efe0d897bb16ad4ff08a3fbe850869b # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH] revlog: use raw revision for rawsize

# HG changeset patch # User Jun Wu <qu...@fb.com> # Date 1490758201 25200 # Tue Mar 28 20:30:01 2017 -0700 # Node ID 5c6ebe1cd99e9557b61ef51ed88e335ac87df8da # Parent 31073077267b5e330925d48098dd6e0fd28bdd8e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

<    1   2   3   4   5   6   7   8   9   10   >