indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> bundlerepo.py:325-326
> +
> +This is closure because we need to make sure this tracked by
> +self.tempfile for cleanup purposes."""
> +
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
This change feels a bit brittle to me, as it is relying on low-level
implementation details of how bundle2 part handling and underlying stream
consumption works. But I know from trying
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG558f5b2ee10e: repository: formalize wire protocol interface
(authored by indygreg).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D333?vs=848&id=932
REVISION DET
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa0aad86b3b6a: repository: implement generic capability
methods on peer class (authored by indygreg).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D334?vs=849&id=
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf257943e47ab: repository: formalize peer interface with
abstract base class (authored by indygreg).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D332?vs=847&id=9
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1f8460b55986: sshpeer: use peer interface (authored by
indygreg).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D336?vs=761&id=935
REVISION DETAIL
https://phab
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf913e90f15a0: httppeer: use peer interface (authored by
indygreg).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D337?vs=762&id=936
REVISION DETAIL
https://pha
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb70029f355a3: tests: verify that peer instances only expose
interface members (authored by indygreg).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D339?vs=764&id
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGdedab036215d: wireproto: use new peer interface (authored
by indygreg).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D338?vs=763&id=937#toc
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPD
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG707750e5310b: localrepo: use peer interfaces (authored by
indygreg).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D335?vs=760&id=934
REVISION DETAIL
https://p
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
The commit message should likely say something about how the existing use of
`string.letters` was logically wrong, since it is locale dependent.
`string.ascii_letters` is definitely the
indygreg added inline comments.
INLINE COMMENTS
> simonfar wrote in util.py:413
> As per comment on https://phab.mercurial-scm.org/D477 - do we want this to be
> raw, or `buffer(mmap.mmap(...`?
Some consumers may want file like objects. Others may want buffers.
Whatever you do, I would rename
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
This seems reasonable as an experimental feature.
I worry about memory mapping all files without regards to size. That seems
unnecessary.
Do you know what happens wit
indygreg added inline comments.
INLINE COMMENTS
> mbthomas wrote in test-revlog-mmapindex.t:12-13
> For (1) There's no `ui` object available in the `revlog.revlog` constructor.
> Is there a way to get one?
> For (2), the rest of the test suite will be loading the revlog without mmap,
> so I di
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I suspect most Mercurial developers are using evolve. So this seems
reasonable.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D511
To: quark, #hg-reviewe
indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> phabricator.py:444
> +actiondesc = ui.label(_(action), 'phabricator.action.%s' % action)
> +nodedesc = ui.label(str(ctx), 'phabricator.node
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
`hg show` makes heavy use of shortest() to limit the length of the node
hash.
For the "stack" and "work" views, you are often looking at multiple
lines of
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This will allow us to make the displayed length configurable
and/or dynamic.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D556
A
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Our previous shortest node length of 5 was arbitrarily chosen.
shortest() already does the work of ensuring that a partial node
isn't ambiguous with an integ
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The changeset displayer allows setting extra keywords to be available
to the templating layer. This patch adds an argument to displaygraph()
to pass a dict of e
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
unlink() on Windows is complicated by the fact that Windows doesn't
support removing an open file. Our unlink wrapper currently goes
through a dance where it ge
indygreg added a comment.
On my Windows desktop at home, this reduced `hg debugapplystreamclonebundle`
for mozilla-unified from ~185s to ~160s. So that's 2 machines showing a wall
time reduction for this operation.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Previously, we were performing membership testing against a
list. Change it to a set for a minor perf win. While we're at it,
explode the assignment in place so
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGca6a3852daf0: util: use set for reserved Windows filenames
(authored by indygreg).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D600?vs=1532&id=1575
REVISION DE
indygreg added a comment.
OK. I failed to grok the unlink semantics on Windows. I'll need to read up on
MSDN.
Would it be safe to keep the ``os.stat()`` code and return if the file
doesn't exist? That at least allows us to do the "is directory" and "file
missing" check with a single sys
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I agree that passing in the outgoing data structure makes sense. Discovery
should be done before changegroup APIs are called.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Could I request a follow-up to add docstrings to our new preferred APIs?
Otherwise, this entire series looks great! Thank you for the cleanup work.
These APIs were in desperate need
indygreg added a comment.
I'm holding off on accepting this because I'd like to see an example before
it is committed.
Since Python 2 doesn't have real enums and Mercurial tends to shy away from
object-oriented programming, I'm -0 on the use of a class here. Module-level
variables with
indygreg accepted this revision.
indygreg added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> bundle2.py:387
> +# processing from processing the old format. This is mostly
> needed
> +# to handle different return codes to unbundle acc
indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> bundle2.py:1149-1152
> +try:
> +_processpart(op, part)
> +finally:
> +part.seek(0, 2)
I think there is a change in
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
Let's wait for a new version of https://phab.mercurial-scm.org/D706 before
looking at this.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D708
indygreg added inline comments.
INLINE COMMENTS
> quark wrote in show.py:440
> I'd call low level function without template and maintain a current minlen to
> reduce calculation.
The current minlen code is semi-tightly integrated with the templating layer.
I agree with you that a generic funct
indygreg abandoned this revision.
indygreg added a comment.
This got rolled into https://phab.mercurial-scm.org/D558. `hg phabsend`
didn't appear smart enough to discard it from Phabricator when I pushed the new
stack.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.
indygreg updated this revision to Diff 1810.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D555?vs=1382&id=1810
REVISION DETAIL
https://phab.mercurial-scm.org/D555
AFFECTED FILES
mercurial/cmdutil.py
CHANGE DETAILS
diff --git a/mercurial/cmdutil.py
indygreg updated this revision to Diff 1811.
indygreg edited the summary of this revision.
indygreg retitled this revision from "show: decrease minimum node length from 5
to 3" to "show: use consistent (and possibly shorter) node lengths".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
h
indygreg accepted this revision as: indygreg.
indygreg added a comment.
This seems reasonable to me. I'm not sure it is appropriate for stable though.
The temporary bundles should definitely use the latest available version. But
changing the backup bundles (which are persisted after the o
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbe1fcffe651f: cmdutil: allow extra properties to be added
to each context (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D55
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb93658d7b2d5: show: pass the minimum length for nodes as a
template keyword (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG98010c7a5745: show: use consistent (and possibly shorter)
node lengths (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D558?v
indygreg added a comment.
Before I accept this, I think we should have a brief conversation on the
possibility that an external diff tool invokes its own pager.
Do we need a per-diff tool config option to control whether hg invokes a
pager? I think hg using a pager by default makes sense
indygreg added a comment.
There are a number of security and user control issues at play here.
For security, we need to take a long hard look at what configs can be
modified by in-repo files. Revsets already have a "safe" flag that controls
what to expose on hgweb. We likely need more of
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Looks good. Nits on API can be addressed as a follow-up, if needed.
INLINE COMMENTS
> dirstate.py:1345
> +
> +class dirstatemap(object):
> +def __init__(self):
Do we want this inhe
indygreg accepted this revision.
indygreg added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> dirstate.py:1359
>
> +def filefoldmap(self):
> +try:
Since this is aiming to be a new interface of sorts, could we get a docstring
here as a follow-u
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Again, I wish a docstring were added. But that can be deferred.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D755
To: durham, #hg-reviewers, indygreg
Cc:
indygreg accepted this revision.
indygreg added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> dirstate.py:1299
> class dirstatemap(object):
> -def __init__(self):
> +def __init__(self, opener, ui, root):
> +self._opener = opener
Nit: I think
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Lots of comments. But nothing that should warrant blocking.
INLINE COMMENTS
> dirstate.py:1370
> +st = fp.read(40)
> +fp.close()
> +l = len(st)
Nit:
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
The logic here isn't readable enough that IMO we should fix it in flight.
INLINE COMMENTS
> dirstate.py:1382-1383
> +raise
> +if not self._pare
indygreg added a comment.
In the spirit of full disclosure, I reviewed this series after a long-haul
flight. I'm a little jet lagged and am not an expert in dirstate. This series
seems like a pretty straightforward refactor to me, which is why I felt
comfortable giving review. But if //there
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I forgot to add these when I initially wrote the test. They inherit
from localrepo.localpeer, so they should be explicitly tested.
REPOSITORY
rHG Mercurial
RE
indygreg added a comment.
This commit regressed the behavior of ^C during part application
(https://phab.mercurial-scm.org/rHGad41739c6b2b5a9217467abb65d6429ba4fae9ba and
issue 4784). Before, ^C would abort bundle2 application pretty quickly.
Afterwards, it appears we now attempt I/O to seek
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As the TODO in the test said, the previous error message was not
very helpful. Let's improve things.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.m
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGafcbc6f64d27: tests: add interface checks for bundle,
statichttp, and union peers (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9bd003052d55: keepalive: add more context to bad status
line errors (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D811?vs=2
indygreg added a comment.
Thanks for the patch - the current behavior has bothered me as well and we
should improve the time estimation algorithm for reasons you've outlined.
Is there a reason you went with 60s? Have you experimented with shorter
values? (Obviously this can be bikeshedde
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Currently, --uncompressed will always clone from the origin server, even
if a stream clone bundle is present. Let's add tests demonstrating
this behavior.
REPO
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Previously, `hg clone --uncompressed` would always clone from the
origin server, even if a streaming clone bundle were available.
With this change, we invoke
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Building on top of the new URL query string arguments to control
whitespace settings for annotate, this commit adds HTML checkboxes
reflecting the values of the
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This feature should hopefully be pretty straightforward. We simply
examine some query string arguments to feed into the diff options.
The function to obtain
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
In preparation for adding features to modify whitespace settings.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D848
AFFECTED FILES
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As documented at
https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247(v=vs.85).aspx
system settings or per-application settings can now opt in to
indygreg added a comment.
In https://phab.mercurial-scm.org/D851#14300, @abuehl wrote:
> What about file I/O done via Python lib (e.g. python27.dll)?
I /think/ this works at the process - not DLL - level. But I need to test on
a Windows machine to be sure. One of the reasons this
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG880e47351d1a: tests: add tests for clone bundles with
--uncompressed (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D832?vs=
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGff406f3e57b2: exchange: perform stream clone with clone
bundle with --uncompressed (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-sc
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
--uncompressed isn't a very good name and its description in the
help documentation isn't very useful. We refer to this concept as
"stream clones" in a number o
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This was added in
https://phab.mercurial-scm.org/rHG2df98f6166458ed16534d993a75a738f440da8b9 in
2006. This may be possible but it
seems like a bad idea to even
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe16ad1576d71: tests: add tests for hgweb annotate output
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D848?vs=2173&id=2234
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf6492f482c60: hgweb: query string arguments to control
whitespace for annotate (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGaea6344e989b: commands: remove suggestion to clone via `cp
-al` (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D863?vs=2227&
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6797f1fbc642: hgweb: add HTML elements to control
whitespace settings for annotate (authored by indygreg, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D850?vs=2175&id=2236#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGfffd3369aa83: commands: rename clone --uncompressed to
--stream and document (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D875
AFFECTED FILES
mercurial/hgweb/webcommands.py
mercurial/hgweb/webutil.py
CHANGE DETAILS
diff -
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This was accidentally added in
https://phab.mercurial-scm.org/rHG6797f1fbc6426c7ee691f3ee21610d33e4825c61.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://p
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG689f6cdccef5: hgweb: remove extra
(authored by
indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D880?vs=2276&id=2284
REVISION DETAI
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG407ebe7a9b93: hgweb: use parsebool for parsing diff query
string options (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D875
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
fsmonitor has been busted since
https://phab.mercurial-scm.org/rHG0865d25e8a8ad664e8da31ab1bf12f1fc9bf0c7a due
to moving
self._copymap. Fix it.
REPOSITORY
rH
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We might as well get this out of the way.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D893
AFFECTED FILES
hgext/fsmonitor/__ini
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
fsmonitor can significantly speed up operations on large working
directories. But fsmonitor isn't enabled by default, so naive users
may not realize there is a
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The default value is compiled into the generated type. This means
that default values are shared between instances. For immutable types
like bool, str, int, and
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I could bikeshed the naming. But if there isn't automated style checking to
flag it as bad, then it's good.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
The new code is so much easier to read!
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D898
To: sid0, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
indygreg added a comment.
Before I stamp this I'd like an answer to the mutability concerns.
INLINE COMMENTS
> context.py:1164-1165
> ak = min(a1 + (bk - b1), a2 - 1)
> child[0][bk] = parent[0][ak]
> +child[
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
This seems reasonable.
Potential follow-ups:
1. Documentation in help output.
2. Inline output saying * denotes skip?
3. Support in templater for indicating skip (maybe test
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Immutability is a magical property, isn't it ;)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D899
To: sid0, #hg-reviewers, indygreg
Cc: indygreg, mercuri
indygreg added subscribers: sid0, indygreg.
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Since you weren't at the Sprint, I think the decision for style is that we'd
check the existing wiki page for the style guide into the repo (p
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We mostly abide by this style.
In one case, a blank line was inserted to prevent a local
`#include "file"` from coming before a `#include `.
REPOSITORY
rH
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This seems to be the prevailing style in the code by a wide margin.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D907
AFFECTED FIL
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This seems to be the prevailing style, even though it is a bit more
verbose for very simple switch statements.
REPOSITORY
rHG Mercurial
REVISION DETAIL
http
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is our prevailing style.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D910
AFFECTED FILES
mercurial/cext/manifest.c
mercu
indygreg added a comment.
FWIW, this series stemmed from me hacking on a `.clang-format` file. I want
the big patch where we run clang-format on the repo to be as simple as
possible. This series (so far) is all about introducing consistency in our C
code.
REPOSITORY
rHG Mercurial
REVISIO
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb90e8da190da: cext: reorder #include (authored by indygreg,
committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D908?vs=2347&id=2388
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7ed0750c71a1: cext: wrap before brace for functions
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D910?vs=2349&id=2390
REV
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG88e83a618de0: cext: put case statements on separate line
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D909?vs=2348&id=2389
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGce26a13869fb: cext: move braces for control statements to
same line (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D907?vs=2
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG50474f0b3f1b: changelog: use a Factory for default value
for files (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D901?vs=23
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG718f7acd6d5e: fsmonitor: use configitem (authored by
indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D893?vs=2314&id=2417
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8337f7772aa2: fsmonitor: access copymap in new location
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D892?vs=2313&id=2416
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
FWIW, I've written extensions that have returned the wrong type and
(previously silently) fell off this function. So yay for catching unicode
return values!
REPOSITORY
rHG Mercurial
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Such a brittle pattern. It feels like the names of things should be defined
in a decorator or something. But fixing this would be scope bloat and can be
punted to another time.
REPOSIT
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Oof. It is really tempting to roll our own function that doesn't require this
ugliness. But that can be a follow-up.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I need to brush off my static immutable series so we can do something
sensible with caching.
The reliance on stat_float_times() is a bit concerning. But Python 3 support
is still v
301 - 400 of 4345 matches
Mail list logo
