Re: [PATCH 3 of 3 v3] dispatch: make hg --profile wrap reposetup

2016-09-21 Thread Arun Kulshreshtha 



On 9/21/16, 2:05 PM, "Arun Kulshreshtha"  wrote:




On 9/21/16, 11:08 AM, "Augie Fackler"  wrote:


> On Sep 21, 2016, at 13:50, Pierre-Yves David 
 wrote:
> 
> 
> 
> On 09/21/2016 07:31 PM, Augie Fackler wrote:
>> On Tue, Sep 20, 2016 at 01:35:22PM -0700, Arun Kulshreshtha wrote:
>>> # HG changeset patch
>>> # User Arun Kulshreshtha 
>>> # Date 1474318006 25200
>>> #  Mon Sep 19 13:46:46 2016 -0700
>>> # Node ID f157d9becfe724d624e0f3328febe58c5694d950
>>> # Parent  0bb030bb1ce94c5514b671a3900ba207ebb19269
>>> dispatch: make hg --profile wrap reposetup
>> 
>> This makes sense to me. Queued.
>> 
>> (I shiver a little bit at threadlocals, but what can you do? Sigh.)
> 
> Yuya raised multiples valid question when reviewing V2 and it is 
unclear they have all been addressed especially since the discussion where 
still going on in V2 after V3 was sent).
> Did you checked the status of this series with Yuya ?

No, because I saw a v3 and discarded the entire v2 discussion, assuming 
v3 resolved the things discussed in v2.

> 
> Cheers,
> 
> -- 
> Pierre-Yves David


Is it possible to undo the accept? To repeat, Yuya made further comments on 
v2
after I had already sent out v3 addressing his first set of comments. This 
version 
doesn’t address the latest feedback so it shouldn’t be published yet.

Sorry about the confusion.

Never mind, looks like this was resolved over IRC.



___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 3 of 3 v3] dispatch: make hg --profile wrap reposetup

2016-09-21 Thread Augie Fackler 

> On Sep 21, 2016, at 17:05, Arun Kulshreshtha  wrote:
> 
> 
> 
> 
> On 9/21/16, 11:08 AM, "Augie Fackler"  wrote:
> 
> 
>> On Sep 21, 2016, at 13:50, Pierre-Yves David 
>>  wrote:
>> 
>> 
>> 
>> On 09/21/2016 07:31 PM, Augie Fackler wrote:
>>> On Tue, Sep 20, 2016 at 01:35:22PM -0700, Arun Kulshreshtha wrote:
 # HG changeset patch
 # User Arun Kulshreshtha 
 # Date 1474318006 25200
 #  Mon Sep 19 13:46:46 2016 -0700
 # Node ID f157d9becfe724d624e0f3328febe58c5694d950
 # Parent  0bb030bb1ce94c5514b671a3900ba207ebb19269
 dispatch: make hg --profile wrap reposetup
>>> 
>>> This makes sense to me. Queued.
>>> 
>>> (I shiver a little bit at threadlocals, but what can you do? Sigh.)
>> 
>> Yuya raised multiples valid question when reviewing V2 and it is unclear 
>> they have all been addressed especially since the discussion where still 
>> going on in V2 after V3 was sent).
>> Did you checked the status of this series with Yuya ?
> 
>No, because I saw a v3 and discarded the entire v2 discussion, assuming v3 
> resolved the things discussed in v2.
> 
>> 
>> Cheers,
>> 
>> -- 
>> Pierre-Yves David
> 
> 
> Is it possible to undo the accept? To repeat, Yuya made further comments on v2
> after I had already sent out v3 addressing his first set of comments. This 
> version 
> doesn’t address the latest feedback so it shouldn’t be published yet.
> 
> Sorry about the confusion.

Ugh, I thought I had done that, but it turns out obsolete markers and bookmarks 
play poorly in a way I didn't know about. It's fixed now.

___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 3 of 3 v3] dispatch: make hg --profile wrap reposetup

2016-09-21 Thread Arun Kulshreshtha 



On 9/21/16, 11:08 AM, "Augie Fackler"  wrote:


> On Sep 21, 2016, at 13:50, Pierre-Yves David 
 wrote:
> 
> 
> 
> On 09/21/2016 07:31 PM, Augie Fackler wrote:
>> On Tue, Sep 20, 2016 at 01:35:22PM -0700, Arun Kulshreshtha wrote:
>>> # HG changeset patch
>>> # User Arun Kulshreshtha 
>>> # Date 1474318006 25200
>>> #  Mon Sep 19 13:46:46 2016 -0700
>>> # Node ID f157d9becfe724d624e0f3328febe58c5694d950
>>> # Parent  0bb030bb1ce94c5514b671a3900ba207ebb19269
>>> dispatch: make hg --profile wrap reposetup
>> 
>> This makes sense to me. Queued.
>> 
>> (I shiver a little bit at threadlocals, but what can you do? Sigh.)
> 
> Yuya raised multiples valid question when reviewing V2 and it is unclear 
they have all been addressed especially since the discussion where still going 
on in V2 after V3 was sent).
> Did you checked the status of this series with Yuya ?

No, because I saw a v3 and discarded the entire v2 discussion, assuming v3 
resolved the things discussed in v2.

> 
> Cheers,
> 
> -- 
> Pierre-Yves David


Is it possible to undo the accept? To repeat, Yuya made further comments on v2
after I had already sent out v3 addressing his first set of comments. This 
version 
doesn’t address the latest feedback so it shouldn’t be published yet.

Sorry about the confusion.


___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 3 of 3 v3] dispatch: make hg --profile wrap reposetup

2016-09-21 Thread Arun Kulshreshtha 
V3 doesn’t address all of the feedback on V2, since Yuya sent some additional 
comments after I’d already sent out V3. So this isn’t ready to land yet.


On 9/21/16, 10:50 AM, "Pierre-Yves David"  
wrote:



On 09/21/2016 07:31 PM, Augie Fackler wrote:
> On Tue, Sep 20, 2016 at 01:35:22PM -0700, Arun Kulshreshtha wrote:
>> # HG changeset patch
>> # User Arun Kulshreshtha 
>> # Date 1474318006 25200
>> #  Mon Sep 19 13:46:46 2016 -0700
>> # Node ID f157d9becfe724d624e0f3328febe58c5694d950
>> # Parent  0bb030bb1ce94c5514b671a3900ba207ebb19269
>> dispatch: make hg --profile wrap reposetup
>
> This makes sense to me. Queued.
>
> (I shiver a little bit at threadlocals, but what can you do? Sigh.)

Yuya raised multiples valid question when reviewing V2 and it is unclear 
they have all been addressed especially since the discussion where still 
going on in V2 after V3 was sent).
Did you checked the status of this series with Yuya ?

Cheers,

-- 
Pierre-Yves David



___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 3 of 3 v3] dispatch: make hg --profile wrap reposetup

2016-09-21 Thread Pierre-Yves David 



On 09/21/2016 07:31 PM, Augie Fackler wrote:

On Tue, Sep 20, 2016 at 01:35:22PM -0700, Arun Kulshreshtha wrote:

# HG changeset patch
# User Arun Kulshreshtha 
# Date 1474318006 25200
#  Mon Sep 19 13:46:46 2016 -0700
# Node ID f157d9becfe724d624e0f3328febe58c5694d950
# Parent  0bb030bb1ce94c5514b671a3900ba207ebb19269
dispatch: make hg --profile wrap reposetup


This makes sense to me. Queued.

(I shiver a little bit at threadlocals, but what can you do? Sigh.)


Yuya raised multiples valid question when reviewing V2 and it is unclear 
they have all been addressed especially since the discussion where still 
going on in V2 after V3 was sent).

Did you checked the status of this series with Yuya ?

Cheers,

--
Pierre-Yves David
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

[PATCH 3 of 3 v3] dispatch: make hg --profile wrap reposetup

2016-09-20 Thread Arun Kulshreshtha 
# HG changeset patch
# User Arun Kulshreshtha 
# Date 1474318006 25200
#  Mon Sep 19 13:46:46 2016 -0700
# Node ID f157d9becfe724d624e0f3328febe58c5694d950
# Parent  0bb030bb1ce94c5514b671a3900ba207ebb19269
dispatch: make hg --profile wrap reposetup

Add profiling to _dispatch so that reposetup is included in the profiler
output. All existing usage of the profiling context manager has been preserved,
so the existing behavior of profiling enabled after reposetup will not be
affected.

diff --git a/mercurial/dispatch.py b/mercurial/dispatch.py
--- a/mercurial/dispatch.py
+++ b/mercurial/dispatch.py
@@ -844,7 +844,7 @@
 elif not cmd:
 return commands.help_(ui, 'shortlist')
 
-if True:
+with profiling.maybeprofile(ui):
 repo = None
 cmdpats = args[:]
 if not _cmdattr(ui, cmd, func, 'norepo'):
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel