Re: [PATCH] mdiff: split on unicode character boundaries when shortening function name

2018-02-22 Thread Josef 'Jeff' Sipek
On Fri, Feb 23, 2018 at 01:06:28 +0900, Yuya Nishihara wrote: > On Thu, 22 Feb 2018 10:01:00 -0500, Josef 'Jeff' Sipek wrote: ... > > Yeah... I thought that might be an issue. The code in the 'except' is meant > > as best-effort - > > Ok, I didn't notice that. It's indeed better to catch the

Re: [PATCH] mdiff: split on unicode character boundaries when shortening function name

2018-02-22 Thread Yuya Nishihara
On Thu, 22 Feb 2018 10:01:00 -0500, Josef 'Jeff' Sipek wrote: > On Thu, Feb 22, 2018 at 21:01:44 +0900, Yuya Nishihara wrote: > > On Thu, 22 Feb 2018 09:01:14 +0100, Denis Laxalde wrote: > > > Josef 'Jeff' Sipek wrote: > > > > # HG changeset patch > > > > # User Josef 'Jeff' Sipek

Re: [PATCH] mdiff: split on unicode character boundaries when shortening function name

2018-02-22 Thread Josef 'Jeff' Sipek
On Thu, Feb 22, 2018 at 21:01:44 +0900, Yuya Nishihara wrote: > On Thu, 22 Feb 2018 09:01:14 +0100, Denis Laxalde wrote: > > Josef 'Jeff' Sipek wrote: > > > # HG changeset patch > > > # User Josef 'Jeff' Sipek > > > # Date 1519251311 18000 > > > # Wed Feb 21 17:15:11

Re: [PATCH] mdiff: split on unicode character boundaries when shortening function name

2018-02-22 Thread Yuya Nishihara
On Thu, 22 Feb 2018 09:01:14 +0100, Denis Laxalde wrote: > Josef 'Jeff' Sipek wrote: > > # HG changeset patch > > # User Josef 'Jeff' Sipek > > # Date 1519251311 18000 > > # Wed Feb 21 17:15:11 2018 -0500 > > # Node ID b99df94fdd4813e0ce538a8caa682802da4a6cb2 > > #

Re: [PATCH] mdiff: split on unicode character boundaries when shortening function name

2018-02-22 Thread Denis Laxalde
Josef 'Jeff' Sipek wrote: > # HG changeset patch > # User Josef 'Jeff' Sipek > # Date 1519251311 18000 > # Wed Feb 21 17:15:11 2018 -0500 > # Node ID b99df94fdd4813e0ce538a8caa682802da4a6cb2 > # Parent 106872aa15af9919220705ed72c78459774e1575 > mdiff: split on unicode

[PATCH] mdiff: split on unicode character boundaries when shortening function name

2018-02-21 Thread Josef 'Jeff' Sipek
# HG changeset patch # User Josef 'Jeff' Sipek # Date 1519251311 18000 # Wed Feb 21 17:15:11 2018 -0500 # Node ID b99df94fdd4813e0ce538a8caa682802da4a6cb2 # Parent 106872aa15af9919220705ed72c78459774e1575 mdiff: split on unicode character boundaries when shortening