D271: obsolete: use bytestr() instead of str() so the node is bytes on py3

2017-08-09 Thread yuja (Yuya Nishihara)
yuja added inline comments. INLINE COMMENTS > obsolete.py:587 > > -marker = (str(prec), tuple(succs), int(flag), metadata, date, > parents) > +prec = bytes(pycompat.bytestr(prec)) > +marker = (prec, tuple(succs), int(flag), metadata, date, parents) Why can't this be

D271: obsolete: use bytestr() instead of str() so the node is bytes on py3

2017-08-08 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not sure this is right, since this should either be bytes or str to match what's going on in the revlog layer. REPOSITORY rHG Mercurial REVISION DETAIL