This revision now requires changes to proceed.
baymax added a comment.
baymax requested changes to this revision.
There seems to have been no activities on this Diff for the past 3 Months.
By policy, we are automatically moving it out of the `need-review` state.
Please, move it back t
yuja added a comment.
> > This is logically incorrect. The problem is that we're doing variable
> > expansion at too lower layer. `vfs(expand(user_specified_path))` makes
> > some sense, but `vfs(expand(getcwd()))` is clearly wrong. And the vfs
class
> > can't know where the `
> > This is logically incorrect. The problem is that we're doing variable
> > expansion at too lower layer. `vfs(expand(user_specified_path))` makes
> > some sense, but `vfs(expand(getcwd()))` is clearly wrong. And the vfs
> class
> > can't know where the `base` comes from.
>
> If
navaneeth.suresh added a comment.
> This is logically incorrect. The problem is that we're doing variable
> expansion at too lower layer. `vfs(expand(user_specified_path))` makes
> some sense, but `vfs(expand(getcwd()))` is clearly wrong. And the vfs class
> can't know where the `base`
yuja added a comment.
> def __init__(self, base, audit=True, cacheaudited=False, expandpath=False,
>realpath=False):
>
> +if '$' in base and os.path.isdir(base):
> +# when there exists a repo '$foo' and an env var foo=bar, stop
> +#
navaneeth.suresh updated this revision to Diff 13046.
navaneeth.suresh retitled this revision from "vfs: add support for repo names
with `$` sign while using with env vars (issue5739)" to "vfs: add support for
repo names with `$` when using with env vars (issue5739)".
REPOSITORY
rHG Mercurial
