D1099: dagutil: use a listcomp instead of a map()

2017-10-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG09397d0dd3b7: dagutil: use a listcomp instead of a map() (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1099?vs=2791=2801

D1103: httppeer: always produce native str header keys and values

2017-10-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG67e9678efd98: httppeer: always produce native str header keys and values (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1104: peer: ensure command names are always ascii bytestrs

2017-10-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG115efdd97088: peer: ensure command names are always ascii bytestrs (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1101: wireproto: use a proper exception instead of `assert False`

2017-10-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6be264009841: wireproto: use a proper exception instead of `assert False` (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1100: wireproto: use listcomp instead of map()

2017-10-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6f532c1a4af0: wireproto: use listcomp instead of map() (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1100?vs=2792=2802

D1102: wireproto: use %d to encode int, not %s

2017-10-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG31fdd0509de9: wireproto: use %d to encode int, not %s (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1102?vs=2794=2804

D1099: dagutil: use a listcomp instead of a map()

2017-10-16 Thread ryanmce (Ryan McElroy)
ryanmce accepted this revision. ryanmce added a comment. This revision is now accepted and ready to land. queued REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1099 To: durin42, #hg-reviewers, ryanmce Cc: ryanmce, mercurial-devel

D1101: wireproto: use a proper exception instead of `assert False`

2017-10-16 Thread ryanmce (Ryan McElroy)
ryanmce accepted this revision. ryanmce added a comment. This revision is now accepted and ready to land. queued REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1101 To: durin42, #hg-reviewers, ryanmce Cc: ryanmce, mercurial-devel

D1100: wireproto: use listcomp instead of map()

2017-10-16 Thread ryanmce (Ryan McElroy)
ryanmce accepted this revision. ryanmce added a comment. This revision is now accepted and ready to land. queued REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1100 To: durin42, #hg-reviewers, ryanmce Cc: ryanmce, mercurial-devel

D1070: config: graduate experimental.updatecheck to commands.update.check

2017-10-16 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. Sorry, I was not clear, I was thinking about adding an alias in the config registration, like that: coreconfigitem('commands', 'update.check', default=None, alias=[('experimental', 'updatecheck')] ) Should I send a follow-up?

D1103: httppeer: always produce native str header keys and values

2017-10-16 Thread ryanmce (Ryan McElroy)
ryanmce accepted this revision. ryanmce added a comment. This revision is now accepted and ready to land. queued REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1103 To: durin42, #hg-reviewers, ryanmce Cc: ryanmce, mercurial-devel

D1104: peer: ensure command names are always ascii bytestrs

2017-10-16 Thread ryanmce (Ryan McElroy)
ryanmce accepted this revision. ryanmce added a comment. This revision is now accepted and ready to land. queued REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1104 To: durin42, #hg-reviewers, ryanmce Cc: ryanmce, mercurial-devel

[PATCH 2 of 2] configitems: fixup default value of diff config option

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1507925335 -7200 # Fri Oct 13 22:08:55 2017 +0200 # Node ID 596df3e78d9c2670f00ea3a0b9870b0fced57deb # Parent b3b1e118238d5897da17c41e66a1ce46ebc8096b # EXP-Topic config.register.fixup # Available At

[PATCH 1 of 2] devel-warn: add 'warn-' to 'devel.empty-changegroup' config

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1507491752 -7200 # Sun Oct 08 21:42:32 2017 +0200 # Node ID b3b1e118238d5897da17c41e66a1ce46ebc8096b # Parent a652b7763f669683eb5540c6d4b77ee18e55bc80 # EXP-Topic config.register.fixup # Available At

D1096: releasenotes: make the import of fuzzywuzzy optional

2017-10-16 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > releasenotes.py:222 > +try: > +import fuzzywuzzy.fuzz as fuzz > +except ImportError: Needs to evaluate the fuzz module to get around the

D1097: releasenotes: don't abort is there is a bad formatted entry for releasenotes

2017-10-16 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > releasenotes.py:327 > if not paragraphs: > -raise error.Abort(_('could not find content for release note > ' > -

Re: [PATCH 2 of 2] configitems: fixup default value of diff config option

2017-10-16 Thread Boris Feld
On Mon, 2017-10-16 at 21:51 +0900, Yuya Nishihara wrote: > On Mon, 16 Oct 2017 12:17:16 +0200, Boris Feld wrote: > > # HG changeset patch > > # User Boris Feld > > # Date 1507925335 -7200 > > #  Fri Oct 13 22:08:55 2017 +0200 > > # Node ID

[PATCH] subrepo: share instead of clone if the parent repo is shared (issue5675) (BC)

2017-10-16 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1508122082 14400 # Sun Oct 15 22:48:02 2017 -0400 # Node ID d0c2b68fedb27184337af6392ecc1f03dab39522 # Parent 718adb1bf3a9a1ee509a803c7512c14296a1db79 subrepo: share instead of clone if the parent repo is shared

D1095: amend: add a flag `-n/--note` to store note with amend

2017-10-16 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Seems fine, though I don't know how the note will be displayed. FWIW, note cannot be a long sentence due to the storage limit. $ hg amend --note "$(yes | head -300 | tr -d '\n')"

D1098: releasenotes: add pager support when printing to the ui

2017-10-16 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG25b5787e8dde: releasenotes: add pager support when printing to the ui (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1074: branch: add a --rev flag to change branch name of given revisions

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2807. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1074?vs=2789=2807 REVISION DETAIL https://phab.mercurial-scm.org/D1074 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-branch-change.t

Re: [PATCH 2 of 2] configitems: fixup default value of diff config option

2017-10-16 Thread Yuya Nishihara
On Mon, 16 Oct 2017 12:17:16 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1507925335 -7200 > # Fri Oct 13 22:08:55 2017 +0200 > # Node ID 596df3e78d9c2670f00ea3a0b9870b0fced57deb > # Parent b3b1e118238d5897da17c41e66a1ce46ebc8096b > #

D1095: amend: add a flag `-n/--note` to store note with amend

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D1095#18566, @yuja wrote: > > We don't have a UI to display obsmarker in core, so for now extensions has to do this. > > I know. It would be nice if reviewers can know how the planned UI will be > to determine whether only

Re: [PATCH] configitems: fixup default value of annotate config option

2017-10-16 Thread Yuya Nishihara
On Mon, 16 Oct 2017 15:43:44 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1508159570 -7200 > # Mon Oct 16 15:12:50 2017 +0200 > # Node ID b3c7b74f19ba08ef8c2b4056508cc1f287550587 > # Parent 330d0b582ab38d35d9d521626e9d039044f38ecd > #

D987: copies: add a config to limit the number of candidates to check in heuristics

2017-10-16 Thread stash (Stanislau Hlebik)
stash added a comment. @pulkit sorry for being late with the comments. I agree with @yuja - falling back is not an option, because it's probably going to be slow. As for these two options > - do not try to find copy from the first n candidates, and show the message saying copy

Re: [PATCH 05 of 11 V2] templatekw: introduce obsfate keyword

2017-10-16 Thread Boris Feld
On Sat, 2017-10-14 at 14:58 +0900, Yuya Nishihara wrote: > On Fri, 13 Oct 2017 20:00:32 +0200, Boris Feld wrote: > > On Thu, 2017-10-12 at 22:51 +0900, Yuya Nishihara wrote: > > > On Thu, 12 Oct 2017 15:29:31 +0200, Boris Feld wrote: > > > > On Wed, 2017-10-11 at 22:24 +0900, Yuya Nishihara wrote:

D1095: amend: add a flag `-n/--note` to store note with amend

2017-10-16 Thread yuja (Yuya Nishihara)
yuja added a comment. > We don't have a UI to display obsmarker in core, so for now extensions has to do this. I know. It would be nice if reviewers can know how the planned UI will be to determine whether only --note option should be in the next release or not. REPOSITORY rHG

D1111: hgweb: more "headers are native strs" cleanup

2017-10-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdc2bf7074147: hgweb: more headers are native strs cleanup (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D?vs=2813=2819

D1112: hgweb: fix decodevaluefromheaders to always return a bytes value

2017-10-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0a2ef612ad50: hgweb: fix decodevaluefromheaders to always return a bytes value (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH] transaction-summary: use a revset to filter obsoletes in reportnewcs()

2017-10-16 Thread Yuya Nishihara
On Mon, 16 Oct 2017 15:35:58 +0200, Denis Laxalde wrote: > # HG changeset patch > # User Denis Laxalde > # Date 1508160908 -7200 > # Mon Oct 16 15:35:08 2017 +0200 > # Node ID 4454e61fb17068293bbe3cc273e21400e9eb784a > # Parent 115efdd9708811859c466c363311f93b3500a72e > #

D1112: hgweb: fix decodevaluefromheaders to always return a bytes value

2017-10-16 Thread yuja (Yuya Nishihara)
yuja added a comment. Perhaps bytesurl()/strurl() should be renamed to e.g. asciibytes()/asciistr() since we've started using them everywhere non-ascii character must be rejected. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1112 To: durin42,

[PATCH 1 of 3] revlog: ignore empty trailing chunks when reading segments

2017-10-16 Thread Paul Morelle
# HG changeset patch # User Paul Morelle # Date 1507554821 -7200 # Mon Oct 09 15:13:41 2017 +0200 # Node ID ac3901a97e195627a2ed4e65040912326ce5d943 # Parent a652b7763f669683eb5540c6d4b77ee18e55bc80 # EXP-Topic optimized-read # Available At

[PATCH 2 of 3] revlog: introduce an experimental flag to slice chunks reads when too sparse

2017-10-16 Thread Paul Morelle
# HG changeset patch # User Paul Morelle # Date 1507650627 -7200 # Tue Oct 10 17:50:27 2017 +0200 # Node ID fd6ea10467600ccdfc9f3491ad95da5cdb5b840d # Parent ac3901a97e195627a2ed4e65040912326ce5d943 # EXP-Topic optimized-read # Available At

[PATCH 3 of 3] revlog-sparse-read: add a lower-threshold for read block size

2017-10-16 Thread Paul Morelle
# HG changeset patch # User Paul Morelle # Date 1507993541 -7200 # Sat Oct 14 17:05:41 2017 +0200 # Node ID cac7666538643b087500c09c757a1b5f28421fbb # Parent fd6ea10467600ccdfc9f3491ad95da5cdb5b840d # EXP-Topic optimized-read # Available At

Re: [PATCH] subrepo: share instead of clone if the parent repo is shared (issue5675) (BC)

2017-10-16 Thread Yuya Nishihara
On Mon, 16 Oct 2017 09:21:24 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1508122082 14400 > # Sun Oct 15 22:48:02 2017 -0400 > # Node ID d0c2b68fedb27184337af6392ecc1f03dab39522 > # Parent

D1096: releasenotes: make the import of fuzzywuzzy optional

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > yuja wrote in releasenotes.py:224 > Perhaps it should return True. > > Any maybe it should show warning, status or debug message? Also, whatever message we will use here, warning, status or debug, it will be repeated a lot of times as the

D1107: wireproto: bounce kwargs to/from bytes/str as needed

2017-10-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb880cc11da5d: wireproto: bounce kwargs to/from bytes/str as needed (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1108: hgweb: more "http headers are native strs" cleanup

2017-10-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb2601c5977a4: hgweb: more http headers are native strs cleanup (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1109: wireproto: more strkwargs cleanup

2017-10-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG60143d038eb7: wireproto: more strkwargs cleanup (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1109?vs=2811=2817 REVISION

D1110: hgweb: when unpacking args from request form, convert to bytes

2017-10-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5a9cad0dfddb: hgweb: when unpacking args from request form, convert to bytes (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D987: copies: add a config to limit the number of candidates to check in heuristics

2017-10-16 Thread yuja (Yuya Nishihara)
yuja added a comment. In https://phab.mercurial-scm.org/D987#18592, @stash wrote: > > copy tracing is disabled > > means that it's disabled only for this particular file and not for all files? Yes, this particular file which has an excessive number of candidates. REPOSITORY

D1115: test-clang-format: new test to verify that files stay clang-formatted

2017-10-16 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For now all .c and .h files are blacklisted. As they become clang-formatted, we'll remove them from the blacklist,and then this test will produce output if

D1114: contrib: remove check-code rule about indentation

2017-10-16 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We're moving towards a clang-format world, and clang-format is able to wrap argument lists with spaces reliably, while still enforcing tabs globally. Let's let

D1113: clang-format: configuration for the clang-format source formatter

2017-10-16 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1113 AFFECTED FILES .clang-format tests/test-check-code.t CHANGE DETAILS diff --git

D1116: Makefile: add target to apply clang-format in-place

2017-10-16 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes it easy to reformat files after you finish editing them. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1116 AFFECTED

D1028: mpatch: reformat function prototypes with clang-format

2017-10-16 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 2823. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1028?vs=2628=2823 REVISION DETAIL https://phab.mercurial-scm.org/D1028 AFFECTED FILES mercurial/mpatch.c mercurial/mpatch.h CHANGE DETAILS diff --git

D761: test: backout update evolution config

2017-10-16 Thread lothiraldan (Boris Feld)
lothiraldan abandoned this revision. lothiraldan added a comment. I've started splitting the configuration, need to finish it before the freeze. As the stack will be unrelated to https://phab.mercurial-scm.org/D761 and https://phab.mercurial-scm.org/D762, I think we can close this stack.

[PATCH 3 of 7] configitems: register the 'web.archivesubrepos' config

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1508170589 -7200 # Mon Oct 16 18:16:29 2017 +0200 # Node ID 1d8be35f0dbac0caca48f0feae19a0ca221bc7b3 # Parent 3db230155faa26b3abcf8cbb05bcf213a2232e01 # EXP-Topic config.register.ready # Available At

[PATCH 2 of 7] configitems: register the 'experimental.effect-flags' config

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1507494147 -7200 # Sun Oct 08 22:22:27 2017 +0200 # Node ID 3db230155faa26b3abcf8cbb05bcf213a2232e01 # Parent e5b06824bc5511d914a29983fb95264719493fb5 # EXP-Topic config.register.ready # Available At

[PATCH 1 of 7] configitems: register the full 'merge-tools' config and sub-options

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1507487833 -7200 # Sun Oct 08 20:37:13 2017 +0200 # Node ID e5b06824bc5511d914a29983fb95264719493fb5 # Parent cfb054a7ecc45bcaac95f1e64b644dd0411ffe41 # EXP-Topic config.register.ready # Available At

D1056: context: add a fast-comparision path between arbitraryfilectx and workingfilectx

2017-10-16 Thread phillco (Phil Cohen)
phillco added inline comments. INLINE COMMENTS > ryanmce wrote in context.py:2567 > Why is this sufficient? Can't the contents be the same even if the paths are > different? > > I think you can only fastpath if the paths are the same, otherwise you have > to fall back to data comparison. > >

D1082: split: new extension to split changesets

2017-10-16 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. It will be great to have split in core, even if it's only as an experimental experiment for now. I like the UX improvements, but could we add a config knob to disable the auto-rebase for power-users? I agree that generating orphans is maybe not the best UX

Re: [PATCH 8 of 8] phase: use a binary phase part to push through bundle2 (BC)

2017-10-16 Thread Boris Feld
On Mon, 2017-10-16 at 19:33 +0530, Pulkit Goyal wrote: > On Mon, Oct 16, 2017 at 7:11 PM, Boris Feld > wrote: > > # HG changeset patch > > # User Boris Feld > > # Date 1505929086 -7200 > > #  Wed Sep 20 19:38:06 2017 +0200 > > # Node ID

[PATCH 6 of 8 V2] phase: generate a push-race detection part on push

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1507700400 -7200 # Wed Oct 11 07:40:00 2017 +0200 # Node ID e688d8b13100c464897c7f872c498202f8e82272 # Parent 3e12cfeb7b0177e2efdd39de00dc7f03d944 # EXP-Topic b2.phases.push # Available At

[PATCH 7 of 8 V2] phase: isolate logic to update remote phrase through bundle2 pushkey

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1505927857 -7200 # Wed Sep 20 19:17:37 2017 +0200 # Node ID 9c084f14df72a2d511d414e0ecf50a086c0a2341 # Parent e688d8b13100c464897c7f872c498202f8e82272 # EXP-Topic b2.phases.push # Available At

[PATCH 5 of 8 V2] phase: introduce a new 'check:phases' part

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1507698782 -7200 # Wed Oct 11 07:13:02 2017 +0200 # Node ID 3e12cfeb7b0177e2efdd39de00dc7f03d944 # Parent c581583a2c085662c9a59f55f2483a2c748eb573 # EXP-Topic b2.phases.push # Available At

[PATCH 8 of 8 V2] phase: use a binary phase part to push through bundle2 (BC)

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1505929086 -7200 # Wed Sep 20 19:38:06 2017 +0200 # Node ID 76e192debcd8036c6695b56681ca096690322880 # Parent 9c084f14df72a2d511d414e0ecf50a086c0a2341 # EXP-Topic b2.phases.push # Available At

D1117: config: simplify aliasing commands.update.check

2017-10-16 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY experimental.updatecheck was renamed into commands.update.check, use the config system to provides the fallback on the old config name instead of adding

[PATCH 5 of 7] eol: ensure the eol extensions is loaded when hooks run

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1507936186 -7200 # Sat Oct 14 01:09:46 2017 +0200 # Node ID bdea558e769aa4e8565f8de48610feaa6f8c0534 # Parent 637d309714d8f4e9b25479eef1ad5c6de418a004 # EXP-Topic config.register.ready # Available At

[PATCH 6 of 7] configitems: move rebase config into core

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1507928431 -7200 # Fri Oct 13 23:00:31 2017 +0200 # Node ID d64632aed1d71fd2750aca29fe09d8a2e86921cd # Parent bdea558e769aa4e8565f8de48610feaa6f8c0534 # EXP-Topic config.register.ready # Available At

[PATCH 7 of 7] configitems: adds a developer warning when accessing undeclared configuration

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1508168487 -7200 # Mon Oct 16 17:41:27 2017 +0200 # Node ID 7a2c3832349499f8b00b9db64e6b87ff644faa9d # Parent d64632aed1d71fd2750aca29fe09d8a2e86921cd # EXP-Topic config.register.ready # Available At

D1082: split: new extension to split changesets

2017-10-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > test-split.t:487-493 > + | o 9:88ede1d5ee13 I > + | | > + | x 6:af8cbf225b7b G1 > + | | > + | x 3:be0ef73c17ad D > + | | > + | | o 8:74863e5b5074 H Leaving these two behind seems reasonable. It would also be reasonable to

D1106: context: add workingfilectx.markcopied

2017-10-16 Thread phillco (Phil Cohen)
phillco added a comment. I could split out the wctx passing, if necessary. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1106 To: phillco, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list

D1082: split: new extension to split changesets

2017-10-16 Thread quark (Jun Wu)
quark added a comment. I changed it to "repeatedly". The word "repetively" seems to exist but may have negative tone according to https://www.usingenglish.com/forum/threads/12782-Need-advice-on-the-difference-btw-Repeatedly-and-Repetitively-thanks-teachers! REPOSITORY rHG Mercurial

D1056: context: add a fast-comparision path between arbitraryfilectx and workingfilectx

2017-10-16 Thread phillco (Phil Cohen)
phillco added inline comments. INLINE COMMENTS > phillco wrote in context.py:2567 > Ryan and I talked offline -- but surprisingly, the default `filectx.cmp` > function only compares contents: > > 1:~/1$ repo['.']['A'].cmp(repo['.']['B']) > Out[1]: False > > 2:~/1$

mercurial@34632: 52 new changesets

2017-10-16 Thread Mercurial Commits
52 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/ee0d74083a22 changeset: 34581:ee0d74083a22 user:Yuya Nishihara date:Tue Sep 19 23:13:46 2017 +0900 summary: templater: store revisions as ints so min/max won't compare them as strings

D1082: split: new extension to split changesets

2017-10-16 Thread quark (Jun Wu)
quark updated this revision to Diff 2827. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1082?vs=2758=2827 REVISION DETAIL https://phab.mercurial-scm.org/D1082 AFFECTED FILES hgext/split.py tests/test-split.t CHANGE DETAILS diff --git

[PATCH 1 of 8 V2] phase: filter out non-draft item in "draft root"

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1507745282 -7200 # Wed Oct 11 20:08:02 2017 +0200 # Node ID 629de091478a249c97ce410733c8520aaec779f2 # Parent a652b7763f669683eb5540c6d4b77ee18e55bc80 # EXP-Topic b2.phases.push # Available At

[PATCH 4 of 8 V2] phase: gather remote phase information in a summary object

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1507739944 -7200 # Wed Oct 11 18:39:04 2017 +0200 # Node ID c581583a2c085662c9a59f55f2483a2c748eb573 # Parent 9fb76d6c80d20b5af8ee1d0e7d6c221924b1d7bb # EXP-Topic b2.phases.push # Available At

[PATCH 2 of 8 V2] exchange: fix issue3781 reference in the comment

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1508150202 -7200 # Mon Oct 16 12:36:42 2017 +0200 # Node ID 29a71a5125a7beb8334a7f7386a3023bfa1f66f8 # Parent 629de091478a249c97ce410733c8520aaec779f2 # EXP-Topic b2.phases.push # Available At

[PATCH 3 of 8 V2] phase: simplify the check for issue3781 shortcut in discovery

2017-10-16 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1507739974 -7200 # Wed Oct 11 18:39:34 2017 +0200 # Node ID 9fb76d6c80d20b5af8ee1d0e7d6c221924b1d7bb # Parent 29a71a5125a7beb8334a7f7386a3023bfa1f66f8 # EXP-Topic b2.phases.push # Available At

D1096: releasenotes: make the import of fuzzywuzzy optional

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2830. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1096?vs=2786=2830 REVISION DETAIL https://phab.mercurial-scm.org/D1096 AFFECTED FILES hgext/releasenotes.py CHANGE DETAILS diff --git a/hgext/releasenotes.py

D1119: releasenotes: fix documentation of similaritycheck()

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The function document says that it returns true when the fragment can be merged, but if you see the function just above it which is similar(), it writes already

D1097: releasenotes: don't abort is there is a bad formatted entry for releasenotes

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2833. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1097?vs=2787=2833 REVISION DETAIL https://phab.mercurial-scm.org/D1097 AFFECTED FILES hgext/releasenotes.py CHANGE

D1120: releasenotes: move import of fuzzywuzzy to import level

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will help us in determining easily that whether fuzzywuzzy is loaded or not loaded in any of the function. REPOSITORY rHG Mercurial REVISION DETAIL

D1121: releasenotes: show a warning if fuzzywuzzy is not present

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1121 AFFECTED FILES hgext/releasenotes.py CHANGE DETAILS diff --git a/hgext/releasenotes.py

D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit abandoned this revision. pulkit added a comment. In https://phab.mercurial-scm.org/D937#17855, @durin42 wrote: > Could we try and get this series ready to land before the freeze on Wednesday? or should we be aiming to get this early in the 4.5 cycle? Me and @ryanmce were

mercurial@34649: 17 new changesets

2017-10-16 Thread Mercurial Commits
17 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/347c0f4232e1 changeset: 34633:347c0f4232e1 user:Augie Fackler date:Wed Oct 04 10:55:51 2017 -0400 summary: mpatch: re-wrap wide line with clang-format

D1096: releasenotes: make the import of fuzzywuzzy optional

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > yuja wrote in releasenotes.py:224 > Perhaps it should return True. > > Any maybe it should show warning, status or debug message? Yes it should return True and I think the doc of this function is wrong. Nice catch. REPOSITORY rHG Mercurial

Re: [PATCH] subrepo: share instead of clone if the parent repo is shared (issue5675) (BC)

2017-10-16 Thread Augie Fackler
On Mon, Oct 16, 2017 at 07:30:32PM +0530, Pulkit Goyal wrote: > On Mon, Oct 16, 2017 at 6:51 PM, Matt Harbison wrote: > > # HG changeset patch > > # User Matt Harbison > > # Date 1508122082 14400 > > # Sun Oct 15 22:48:02 2017 -0400 > > # Node

D1063: rebase: enable multidest by default

2017-10-16 Thread quark (Jun Wu)
quark added a comment. Interface-wise, I'm thinking about defining `BASE` as `max(roots(ALLSRC) & ::SRC)^` to make it easier to use. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1063 To: quark, #hg-reviewers, durin42 Cc: dlax, martinvonz, durin42,

D1044: bisect: add --abort flag

2017-10-16 Thread quark (Jun Wu)
quark added a comment. I think with `--command`, an option to restore to the original commit is a useful feature in `bisect` itself. If we cannot reach agreement, could we push the first 3 commits

D1126: test-dispatch: make the test compatible with chg

2017-10-16 Thread quark (Jun Wu)
quark requested changes to this revision. quark added a comment. This revision now requires changes to proceed. Just a small nit. INLINE COMMENTS > test-dispatch.t:77 >$ HGDEMANDIMPORT=disable hg version -q >abort: error getting current working directory: * (glob) >[255]

D1127: test-obsolete-bounds-checking: make the test compatible with chg

2017-10-16 Thread singhsrb (Saurabh Singh)
singhsrb created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This test fails when run with chg because the error message starts with "ProgrammingError" instead of "mercurial.error.ProgrammingError". Therefore, globing

D1126: test-dispatch: make the test compatible with chg

2017-10-16 Thread singhsrb (Saurabh Singh)
singhsrb added inline comments. INLINE COMMENTS > quark wrote in test-dispatch.t:77 > Alternatively, you can use individual line matching without duplicating the > `hg version` line: > > abort: error getting current working directory: * (glob) (no-chg !) > chg: abort: failed to getcwd

[Bug 5711] New: Cannot clone in Python 3 due to string handling

2017-10-16 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5711 Bug ID: 5711 Summary: Cannot clone in Python 3 due to string handling Product: Mercurial Version: 4.3.3 Hardware: Macintosh OS: Mac OS Status: UNCONFIRMED

D1126: test-dispatch: make the test compatible with chg

2017-10-16 Thread singhsrb (Saurabh Singh)
singhsrb created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The test is broken when run with chg because it prints a different error message when chg is running. This commit fixes the test by special casing for chg.

D1126: test-dispatch: make the test compatible with chg

2017-10-16 Thread singhsrb (Saurabh Singh)
singhsrb updated this revision to Diff 2852. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1126?vs=2850=2852 REVISION DETAIL https://phab.mercurial-scm.org/D1126 AFFECTED FILES tests/test-dispatch.t CHANGE DETAILS diff --git

Re: [PATCH 4 of 4 v3] log: add -L/--line-range option to follow file history by line range

2017-10-16 Thread Denis Laxalde
Augie Fackler a écrit : (+jordigh, themystic, indygreg in case one of them has an opinion or inspiration) On Oct 13, 2017, at 10:24 AM, Yuya Nishihara wrote: On Fri, 13 Oct 2017 10:02:07 +0200, Denis Laxalde wrote: Yuya Nishihara a écrit : On Tue, 10 Oct 2017 17:37:27

D1122: arbitraryfilecontext: skip the cmp fast path if any side is a symlink

2017-10-16 Thread phillco (Phil Cohen)
phillco updated this revision to Diff 2840. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1122?vs=2839=2840 REVISION DETAIL https://phab.mercurial-scm.org/D1122 AFFECTED FILES mercurial/context.py tests/test-arbitraryfilectx.t CHANGE DETAILS

D1122: arbitraryfilecontext: skip the cmp fast path if any side is a symlink

2017-10-16 Thread phillco (Phil Cohen)
phillco updated this revision to Diff 2839. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1122?vs=2838=2839 REVISION DETAIL https://phab.mercurial-scm.org/D1122 AFFECTED FILES mercurial/context.py tests/test-arbitraryfilectx.t CHANGE DETAILS

D1063: rebase: enable multidest by default

2017-10-16 Thread durin42 (Augie Fackler)
durin42 added a comment. (Note that I'd still welcome feedback from non-BigCo contributors here - is this something we should make permanent? Have people been testing this? Etc.) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1063 To: quark, #hg-reviewers,

D1057: filemerge: use arbitraryfilectx for backups

2017-10-16 Thread phillco (Phil Cohen)
phillco marked 4 inline comments as done. phillco added inline comments. INLINE COMMENTS > phillco wrote in filemerge.py:604 > Sure, will do. I think most likely by breaking the context -> fileset > dependency. @durin42 done REPOSITORY rHG Mercurial REVISION DETAIL

D1057: filemerge: use arbitraryfilectx for backups

2017-10-16 Thread phillco (Phil Cohen)
phillco added inline comments. INLINE COMMENTS > durin42 wrote in filemerge.py:604 > Ick. Please add a TODO here to figure out a way to break the cycle (it can be > done! I'm sure of it, even if I don't yet know how) and then we can move > forward with this. Sure, will do. I think most likely

Phabricator and [stable] patches

2017-10-16 Thread Augie Fackler
As we approach the freeze, I'm realizing we don't have a good way of flagging things for stable in Phabricator. Anyone have ideas for how we should do this? Thanks, Augie ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D1057: filemerge: use arbitraryfilectx for backups

2017-10-16 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > phillco wrote in filemerge.py:604 > I don't think so, because the filectx classes reference the ctx classes in > various places. Ick. Please add a TODO here to figure out a way to break the cycle (it can be done! I'm sure of it, even if I don't

D1082: split: new extension to split changesets

2017-10-16 Thread quark (Jun Wu)
quark added a comment. In https://phab.mercurial-scm.org/D1082#18648, @lothiraldan wrote: > It will be great to have split in core, even if it's only as an experimental experiment for now. > > I like the UX improvements, but could we add a config knob to disable the auto-rebase for

D1082: split: new extension to split changesets

2017-10-16 Thread quark (Jun Wu)
quark added inline comments. INLINE COMMENTS > martinvonz wrote in test-split.t:487-493 > Leaving these two behind seems reasonable. It would also be reasonable to > evolve/stabilize them. Either way, it's different from what "hg rebase" does. > Do we eventually want them to behave the same?

D785: context: also consider path conflicts when clearing unknown files

2017-10-16 Thread swhitaker (Simon Whitaker)
swhitaker added inline comments. INLINE COMMENTS > context.py:1941 > +if wvfs.isfileorlink(p): > +wvfs.unlink(p) > +break This breaks test-audit-path.t on macOS. In the test "attack /tmp/test", we call this codepath with f == '/tmp/test'.

D1122: arbitraryfilecontext: skip the cmp fast path if any side is a symlink

2017-10-16 Thread phillco (Phil Cohen)
phillco updated this revision to Diff 2838. phillco edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1122?vs=2836=2838 REVISION DETAIL https://phab.mercurial-scm.org/D1122 AFFECTED FILES mercurial/context.py

  1   2   >