This revision was automatically updated to reflect the committed changes.
Closed by commit rHG09397d0dd3b7: dagutil: use a listcomp instead of a map()
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1099?vs=2791=2801
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG67e9678efd98: httppeer: always produce native str header
keys and values (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG115efdd97088: peer: ensure command names are always ascii
bytestrs (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6be264009841: wireproto: use a proper exception instead of
`assert False` (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6f532c1a4af0: wireproto: use listcomp instead of map()
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1100?vs=2792=2802
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG31fdd0509de9: wireproto: use %d to encode int, not %s
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1102?vs=2794=2804
ryanmce accepted this revision.
ryanmce added a comment.
This revision is now accepted and ready to land.
queued
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1099
To: durin42, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel
ryanmce accepted this revision.
ryanmce added a comment.
This revision is now accepted and ready to land.
queued
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1101
To: durin42, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel
ryanmce accepted this revision.
ryanmce added a comment.
This revision is now accepted and ready to land.
queued
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1100
To: durin42, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel
lothiraldan added a comment.
Sorry, I was not clear, I was thinking about adding an alias in the config
registration, like that:
coreconfigitem('commands', 'update.check',
default=None,
alias=[('experimental', 'updatecheck')]
)
Should I send a follow-up?
ryanmce accepted this revision.
ryanmce added a comment.
This revision is now accepted and ready to land.
queued
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1103
To: durin42, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel
ryanmce accepted this revision.
ryanmce added a comment.
This revision is now accepted and ready to land.
queued
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1104
To: durin42, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel
# HG changeset patch
# User Boris Feld
# Date 1507925335 -7200
# Fri Oct 13 22:08:55 2017 +0200
# Node ID 596df3e78d9c2670f00ea3a0b9870b0fced57deb
# Parent b3b1e118238d5897da17c41e66a1ce46ebc8096b
# EXP-Topic config.register.fixup
# Available At
# HG changeset patch
# User Boris Feld
# Date 1507491752 -7200
# Sun Oct 08 21:42:32 2017 +0200
# Node ID b3b1e118238d5897da17c41e66a1ce46ebc8096b
# Parent a652b7763f669683eb5540c6d4b77ee18e55bc80
# EXP-Topic config.register.fixup
# Available At
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> releasenotes.py:222
> +try:
> +import fuzzywuzzy.fuzz as fuzz
> +except ImportError:
Needs to evaluate the fuzz module to get around the
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> releasenotes.py:327
> if not paragraphs:
> -raise error.Abort(_('could not find content for release note
> '
> -
On Mon, 2017-10-16 at 21:51 +0900, Yuya Nishihara wrote:
> On Mon, 16 Oct 2017 12:17:16 +0200, Boris Feld wrote:
> > # HG changeset patch
> > # User Boris Feld
> > # Date 1507925335 -7200
> > # Fri Oct 13 22:08:55 2017 +0200
> > # Node ID
# HG changeset patch
# User Matt Harbison
# Date 1508122082 14400
# Sun Oct 15 22:48:02 2017 -0400
# Node ID d0c2b68fedb27184337af6392ecc1f03dab39522
# Parent 718adb1bf3a9a1ee509a803c7512c14296a1db79
subrepo: share instead of clone if the parent repo is shared
yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.
Seems fine, though I don't know how the note will be displayed.
FWIW, note cannot be a long sentence due to the storage limit.
$ hg amend --note "$(yes | head -300 | tr -d '\n')"
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG25b5787e8dde: releasenotes: add pager support when printing
to the ui (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit updated this revision to Diff 2807.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1074?vs=2789=2807
REVISION DETAIL
https://phab.mercurial-scm.org/D1074
AFFECTED FILES
mercurial/cmdutil.py
mercurial/commands.py
tests/test-branch-change.t
On Mon, 16 Oct 2017 12:17:16 +0200, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1507925335 -7200
> # Fri Oct 13 22:08:55 2017 +0200
> # Node ID 596df3e78d9c2670f00ea3a0b9870b0fced57deb
> # Parent b3b1e118238d5897da17c41e66a1ce46ebc8096b
> #
pulkit added a comment.
In https://phab.mercurial-scm.org/D1095#18566, @yuja wrote:
> > We don't have a UI to display obsmarker in core, so for now extensions
has to do this.
>
> I know. It would be nice if reviewers can know how the planned UI will be
> to determine whether only
On Mon, 16 Oct 2017 15:43:44 +0200, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1508159570 -7200
> # Mon Oct 16 15:12:50 2017 +0200
> # Node ID b3c7b74f19ba08ef8c2b4056508cc1f287550587
> # Parent 330d0b582ab38d35d9d521626e9d039044f38ecd
> #
stash added a comment.
@pulkit sorry for being late with the comments.
I agree with @yuja - falling back is not an option, because it's probably
going to be slow.
As for these two options
> - do not try to find copy from the first n candidates, and show the message
saying copy
On Sat, 2017-10-14 at 14:58 +0900, Yuya Nishihara wrote:
> On Fri, 13 Oct 2017 20:00:32 +0200, Boris Feld wrote:
> > On Thu, 2017-10-12 at 22:51 +0900, Yuya Nishihara wrote:
> > > On Thu, 12 Oct 2017 15:29:31 +0200, Boris Feld wrote:
> > > > On Wed, 2017-10-11 at 22:24 +0900, Yuya Nishihara wrote:
yuja added a comment.
> We don't have a UI to display obsmarker in core, so for now extensions has
to do this.
I know. It would be nice if reviewers can know how the planned UI will be
to determine whether only --note option should be in the next release or not.
REPOSITORY
rHG
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGdc2bf7074147: hgweb: more headers are native
strs cleanup (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D?vs=2813=2819
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0a2ef612ad50: hgweb: fix decodevaluefromheaders to always
return a bytes value (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
On Mon, 16 Oct 2017 15:35:58 +0200, Denis Laxalde wrote:
> # HG changeset patch
> # User Denis Laxalde
> # Date 1508160908 -7200
> # Mon Oct 16 15:35:08 2017 +0200
> # Node ID 4454e61fb17068293bbe3cc273e21400e9eb784a
> # Parent 115efdd9708811859c466c363311f93b3500a72e
> #
yuja added a comment.
Perhaps bytesurl()/strurl() should be renamed to e.g. asciibytes()/asciistr()
since we've started using them everywhere non-ascii character must be
rejected.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1112
To: durin42,
# HG changeset patch
# User Paul Morelle
# Date 1507554821 -7200
# Mon Oct 09 15:13:41 2017 +0200
# Node ID ac3901a97e195627a2ed4e65040912326ce5d943
# Parent a652b7763f669683eb5540c6d4b77ee18e55bc80
# EXP-Topic optimized-read
# Available At
# HG changeset patch
# User Paul Morelle
# Date 1507650627 -7200
# Tue Oct 10 17:50:27 2017 +0200
# Node ID fd6ea10467600ccdfc9f3491ad95da5cdb5b840d
# Parent ac3901a97e195627a2ed4e65040912326ce5d943
# EXP-Topic optimized-read
# Available At
# HG changeset patch
# User Paul Morelle
# Date 1507993541 -7200
# Sat Oct 14 17:05:41 2017 +0200
# Node ID cac7666538643b087500c09c757a1b5f28421fbb
# Parent fd6ea10467600ccdfc9f3491ad95da5cdb5b840d
# EXP-Topic optimized-read
# Available At
On Mon, 16 Oct 2017 09:21:24 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1508122082 14400
> # Sun Oct 15 22:48:02 2017 -0400
> # Node ID d0c2b68fedb27184337af6392ecc1f03dab39522
> # Parent
pulkit added inline comments.
INLINE COMMENTS
> yuja wrote in releasenotes.py:224
> Perhaps it should return True.
>
> Any maybe it should show warning, status or debug message?
Also, whatever message we will use here, warning, status or debug, it will be
repeated a lot of times as the
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb880cc11da5d: wireproto: bounce kwargs to/from bytes/str as
needed (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb2601c5977a4: hgweb: more http headers are native
strs cleanup (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG60143d038eb7: wireproto: more strkwargs cleanup (authored
by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1109?vs=2811=2817
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5a9cad0dfddb: hgweb: when unpacking args from request form,
convert to bytes (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
yuja added a comment.
In https://phab.mercurial-scm.org/D987#18592, @stash wrote:
> > copy tracing is disabled
>
> means that it's disabled only for this particular file and not for all
files?
Yes, this particular file which has an excessive number of candidates.
REPOSITORY
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
For now all .c and .h files are blacklisted. As they become
clang-formatted, we'll remove them from the blacklist,and then this
test will produce output if
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We're moving towards a clang-format world, and clang-format is able to
wrap argument lists with spaces reliably, while still enforcing tabs
globally. Let's let
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1113
AFFECTED FILES
.clang-format
tests/test-check-code.t
CHANGE DETAILS
diff --git
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This makes it easy to reformat files after you finish editing them.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1116
AFFECTED
durin42 updated this revision to Diff 2823.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1028?vs=2628=2823
REVISION DETAIL
https://phab.mercurial-scm.org/D1028
AFFECTED FILES
mercurial/mpatch.c
mercurial/mpatch.h
CHANGE DETAILS
diff --git
lothiraldan abandoned this revision.
lothiraldan added a comment.
I've started splitting the configuration, need to finish it before the
freeze. As the stack will be unrelated to https://phab.mercurial-scm.org/D761
and https://phab.mercurial-scm.org/D762, I think we can close this stack.
# HG changeset patch
# User Boris Feld
# Date 1508170589 -7200
# Mon Oct 16 18:16:29 2017 +0200
# Node ID 1d8be35f0dbac0caca48f0feae19a0ca221bc7b3
# Parent 3db230155faa26b3abcf8cbb05bcf213a2232e01
# EXP-Topic config.register.ready
# Available At
# HG changeset patch
# User Boris Feld
# Date 1507494147 -7200
# Sun Oct 08 22:22:27 2017 +0200
# Node ID 3db230155faa26b3abcf8cbb05bcf213a2232e01
# Parent e5b06824bc5511d914a29983fb95264719493fb5
# EXP-Topic config.register.ready
# Available At
# HG changeset patch
# User Boris Feld
# Date 1507487833 -7200
# Sun Oct 08 20:37:13 2017 +0200
# Node ID e5b06824bc5511d914a29983fb95264719493fb5
# Parent cfb054a7ecc45bcaac95f1e64b644dd0411ffe41
# EXP-Topic config.register.ready
# Available At
phillco added inline comments.
INLINE COMMENTS
> ryanmce wrote in context.py:2567
> Why is this sufficient? Can't the contents be the same even if the paths are
> different?
>
> I think you can only fastpath if the paths are the same, otherwise you have
> to fall back to data comparison.
>
>
lothiraldan added a comment.
It will be great to have split in core, even if it's only as an experimental
experiment for now.
I like the UX improvements, but could we add a config knob to disable the
auto-rebase for power-users? I agree that generating orphans is maybe not the
best UX
On Mon, 2017-10-16 at 19:33 +0530, Pulkit Goyal wrote:
> On Mon, Oct 16, 2017 at 7:11 PM, Boris Feld
> wrote:
> > # HG changeset patch
> > # User Boris Feld
> > # Date 1505929086 -7200
> > # Wed Sep 20 19:38:06 2017 +0200
> > # Node ID
# HG changeset patch
# User Boris Feld
# Date 1507700400 -7200
# Wed Oct 11 07:40:00 2017 +0200
# Node ID e688d8b13100c464897c7f872c498202f8e82272
# Parent 3e12cfeb7b0177e2efdd39de00dc7f03d944
# EXP-Topic b2.phases.push
# Available At
# HG changeset patch
# User Boris Feld
# Date 1505927857 -7200
# Wed Sep 20 19:17:37 2017 +0200
# Node ID 9c084f14df72a2d511d414e0ecf50a086c0a2341
# Parent e688d8b13100c464897c7f872c498202f8e82272
# EXP-Topic b2.phases.push
# Available At
# HG changeset patch
# User Boris Feld
# Date 1507698782 -7200
# Wed Oct 11 07:13:02 2017 +0200
# Node ID 3e12cfeb7b0177e2efdd39de00dc7f03d944
# Parent c581583a2c085662c9a59f55f2483a2c748eb573
# EXP-Topic b2.phases.push
# Available At
# HG changeset patch
# User Boris Feld
# Date 1505929086 -7200
# Wed Sep 20 19:38:06 2017 +0200
# Node ID 76e192debcd8036c6695b56681ca096690322880
# Parent 9c084f14df72a2d511d414e0ecf50a086c0a2341
# EXP-Topic b2.phases.push
# Available At
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
experimental.updatecheck was renamed into commands.update.check, use the
config system to provides the fallback on the old config name instead of
adding
# HG changeset patch
# User Boris Feld
# Date 1507936186 -7200
# Sat Oct 14 01:09:46 2017 +0200
# Node ID bdea558e769aa4e8565f8de48610feaa6f8c0534
# Parent 637d309714d8f4e9b25479eef1ad5c6de418a004
# EXP-Topic config.register.ready
# Available At
# HG changeset patch
# User Boris Feld
# Date 1507928431 -7200
# Fri Oct 13 23:00:31 2017 +0200
# Node ID d64632aed1d71fd2750aca29fe09d8a2e86921cd
# Parent bdea558e769aa4e8565f8de48610feaa6f8c0534
# EXP-Topic config.register.ready
# Available At
# HG changeset patch
# User Boris Feld
# Date 1508168487 -7200
# Mon Oct 16 17:41:27 2017 +0200
# Node ID 7a2c3832349499f8b00b9db64e6b87ff644faa9d
# Parent d64632aed1d71fd2750aca29fe09d8a2e86921cd
# EXP-Topic config.register.ready
# Available At
martinvonz added inline comments.
INLINE COMMENTS
> test-split.t:487-493
> + | o 9:88ede1d5ee13 I
> + | |
> + | x 6:af8cbf225b7b G1
> + | |
> + | x 3:be0ef73c17ad D
> + | |
> + | | o 8:74863e5b5074 H
Leaving these two behind seems reasonable. It would also be reasonable to
phillco added a comment.
I could split out the wctx passing, if necessary.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1106
To: phillco, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
quark added a comment.
I changed it to "repeatedly". The word "repetively" seems to exist but may
have negative tone according to
https://www.usingenglish.com/forum/threads/12782-Need-advice-on-the-difference-btw-Repeatedly-and-Repetitively-thanks-teachers!
REPOSITORY
rHG Mercurial
phillco added inline comments.
INLINE COMMENTS
> phillco wrote in context.py:2567
> Ryan and I talked offline -- but surprisingly, the default `filectx.cmp`
> function only compares contents:
>
> 1:~/1$ repo['.']['A'].cmp(repo['.']['B'])
> Out[1]: False
>
> 2:~/1$
52 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/ee0d74083a22
changeset: 34581:ee0d74083a22
user:Yuya Nishihara
date:Tue Sep 19 23:13:46 2017 +0900
summary: templater: store revisions as ints so min/max won't compare them
as strings
quark updated this revision to Diff 2827.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1082?vs=2758=2827
REVISION DETAIL
https://phab.mercurial-scm.org/D1082
AFFECTED FILES
hgext/split.py
tests/test-split.t
CHANGE DETAILS
diff --git
# HG changeset patch
# User Boris Feld
# Date 1507745282 -7200
# Wed Oct 11 20:08:02 2017 +0200
# Node ID 629de091478a249c97ce410733c8520aaec779f2
# Parent a652b7763f669683eb5540c6d4b77ee18e55bc80
# EXP-Topic b2.phases.push
# Available At
# HG changeset patch
# User Boris Feld
# Date 1507739944 -7200
# Wed Oct 11 18:39:04 2017 +0200
# Node ID c581583a2c085662c9a59f55f2483a2c748eb573
# Parent 9fb76d6c80d20b5af8ee1d0e7d6c221924b1d7bb
# EXP-Topic b2.phases.push
# Available At
# HG changeset patch
# User Boris Feld
# Date 1508150202 -7200
# Mon Oct 16 12:36:42 2017 +0200
# Node ID 29a71a5125a7beb8334a7f7386a3023bfa1f66f8
# Parent 629de091478a249c97ce410733c8520aaec779f2
# EXP-Topic b2.phases.push
# Available At
# HG changeset patch
# User Boris Feld
# Date 1507739974 -7200
# Wed Oct 11 18:39:34 2017 +0200
# Node ID 9fb76d6c80d20b5af8ee1d0e7d6c221924b1d7bb
# Parent 29a71a5125a7beb8334a7f7386a3023bfa1f66f8
# EXP-Topic b2.phases.push
# Available At
pulkit updated this revision to Diff 2830.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1096?vs=2786=2830
REVISION DETAIL
https://phab.mercurial-scm.org/D1096
AFFECTED FILES
hgext/releasenotes.py
CHANGE DETAILS
diff --git a/hgext/releasenotes.py
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The function document says that it returns true when the fragment can be
merged,
but if you see the function just above it which is similar(), it writes
already
pulkit updated this revision to Diff 2833.
pulkit edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1097?vs=2787=2833
REVISION DETAIL
https://phab.mercurial-scm.org/D1097
AFFECTED FILES
hgext/releasenotes.py
CHANGE
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This will help us in determining easily that whether fuzzywuzzy is loaded or
not
loaded in any of the function.
REPOSITORY
rHG Mercurial
REVISION DETAIL
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1121
AFFECTED FILES
hgext/releasenotes.py
CHANGE DETAILS
diff --git a/hgext/releasenotes.py
pulkit abandoned this revision.
pulkit added a comment.
In https://phab.mercurial-scm.org/D937#17855, @durin42 wrote:
> Could we try and get this series ready to land before the freeze on
Wednesday? or should we be aiming to get this early in the 4.5 cycle?
Me and @ryanmce were
17 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/347c0f4232e1
changeset: 34633:347c0f4232e1
user:Augie Fackler
date:Wed Oct 04 10:55:51 2017 -0400
summary: mpatch: re-wrap wide line with clang-format
pulkit added inline comments.
INLINE COMMENTS
> yuja wrote in releasenotes.py:224
> Perhaps it should return True.
>
> Any maybe it should show warning, status or debug message?
Yes it should return True and I think the doc of this function is wrong. Nice
catch.
REPOSITORY
rHG Mercurial
On Mon, Oct 16, 2017 at 07:30:32PM +0530, Pulkit Goyal wrote:
> On Mon, Oct 16, 2017 at 6:51 PM, Matt Harbison wrote:
> > # HG changeset patch
> > # User Matt Harbison
> > # Date 1508122082 14400
> > # Sun Oct 15 22:48:02 2017 -0400
> > # Node
quark added a comment.
Interface-wise, I'm thinking about defining `BASE` as `max(roots(ALLSRC) &
::SRC)^` to make it easier to use.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1063
To: quark, #hg-reviewers, durin42
Cc: dlax, martinvonz, durin42,
quark added a comment.
I think with `--command`, an option to restore to the original commit is a
useful feature in `bisect` itself. If we cannot reach agreement, could we push
the first 3 commits
quark requested changes to this revision.
quark added a comment.
This revision now requires changes to proceed.
Just a small nit.
INLINE COMMENTS
> test-dispatch.t:77
>$ HGDEMANDIMPORT=disable hg version -q
>abort: error getting current working directory: * (glob)
>[255]
singhsrb created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This test fails when run with chg because the error message starts
with "ProgrammingError" instead of "mercurial.error.ProgrammingError".
Therefore, globing
singhsrb added inline comments.
INLINE COMMENTS
> quark wrote in test-dispatch.t:77
> Alternatively, you can use individual line matching without duplicating the
> `hg version` line:
>
> abort: error getting current working directory: * (glob) (no-chg !)
> chg: abort: failed to getcwd
https://bz.mercurial-scm.org/show_bug.cgi?id=5711
Bug ID: 5711
Summary: Cannot clone in Python 3 due to string handling
Product: Mercurial
Version: 4.3.3
Hardware: Macintosh
OS: Mac OS
Status: UNCONFIRMED
singhsrb created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The test is broken when run with chg because it prints a different
error message when chg is running. This commit fixes the test by special
casing
for chg.
singhsrb updated this revision to Diff 2852.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1126?vs=2850=2852
REVISION DETAIL
https://phab.mercurial-scm.org/D1126
AFFECTED FILES
tests/test-dispatch.t
CHANGE DETAILS
diff --git
Augie Fackler a écrit :
(+jordigh, themystic, indygreg in case one of them has an opinion or
inspiration)
On Oct 13, 2017, at 10:24 AM, Yuya Nishihara wrote:
On Fri, 13 Oct 2017 10:02:07 +0200, Denis Laxalde wrote:
Yuya Nishihara a écrit :
On Tue, 10 Oct 2017 17:37:27
phillco updated this revision to Diff 2840.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1122?vs=2839=2840
REVISION DETAIL
https://phab.mercurial-scm.org/D1122
AFFECTED FILES
mercurial/context.py
tests/test-arbitraryfilectx.t
CHANGE DETAILS
phillco updated this revision to Diff 2839.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1122?vs=2838=2839
REVISION DETAIL
https://phab.mercurial-scm.org/D1122
AFFECTED FILES
mercurial/context.py
tests/test-arbitraryfilectx.t
CHANGE DETAILS
durin42 added a comment.
(Note that I'd still welcome feedback from non-BigCo contributors here - is
this something we should make permanent? Have people been testing this? Etc.)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1063
To: quark, #hg-reviewers,
phillco marked 4 inline comments as done.
phillco added inline comments.
INLINE COMMENTS
> phillco wrote in filemerge.py:604
> Sure, will do. I think most likely by breaking the context -> fileset
> dependency.
@durin42 done
REPOSITORY
rHG Mercurial
REVISION DETAIL
phillco added inline comments.
INLINE COMMENTS
> durin42 wrote in filemerge.py:604
> Ick. Please add a TODO here to figure out a way to break the cycle (it can be
> done! I'm sure of it, even if I don't yet know how) and then we can move
> forward with this.
Sure, will do. I think most likely
As we approach the freeze, I'm realizing we don't have a good way of flagging
things for stable in Phabricator. Anyone have ideas for how we should do this?
Thanks,
Augie
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
durin42 added inline comments.
INLINE COMMENTS
> phillco wrote in filemerge.py:604
> I don't think so, because the filectx classes reference the ctx classes in
> various places.
Ick. Please add a TODO here to figure out a way to break the cycle (it can be
done! I'm sure of it, even if I don't
quark added a comment.
In https://phab.mercurial-scm.org/D1082#18648, @lothiraldan wrote:
> It will be great to have split in core, even if it's only as an
experimental experiment for now.
>
> I like the UX improvements, but could we add a config knob to disable the
auto-rebase for
quark added inline comments.
INLINE COMMENTS
> martinvonz wrote in test-split.t:487-493
> Leaving these two behind seems reasonable. It would also be reasonable to
> evolve/stabilize them. Either way, it's different from what "hg rebase" does.
> Do we eventually want them to behave the same?
swhitaker added inline comments.
INLINE COMMENTS
> context.py:1941
> +if wvfs.isfileorlink(p):
> +wvfs.unlink(p)
> +break
This breaks test-audit-path.t on macOS. In the test "attack /tmp/test", we call
this codepath with f == '/tmp/test'.
phillco updated this revision to Diff 2838.
phillco edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1122?vs=2836=2838
REVISION DETAIL
https://phab.mercurial-scm.org/D1122
AFFECTED FILES
mercurial/context.py
1 - 100 of 177 matches
Mail list logo