rdamazio updated this revision to Diff 7330.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2678?vs=6980=7330
REVISION DETAIL
https://phab.mercurial-scm.org/D2678
AFFECTED FILES
hgext/show.py
mercurial/configitems.py
mercurial/dispatch.py
rdamazio added a comment.
The flakiness was just due to Python map order randomization in tests (a
fixed PYTHONHASHSEED=3170796678 or similar reproduces it consistently by
getting dln before lognull).
The real issue was the added "ignoresub=True" argument which broke strict
ordering
# HG changeset patch
# User Matt Harbison
# Date 1522117116 14400
# Mon Mar 26 22:18:36 2018 -0400
# Node ID 19b73408a618666979209b9654182e6fa72364d2
# Parent aaabd709df720e456d7f93a1c790a0dbed051b38
lfs: respect narrowmatcher when testing to add 'lfs' requirement
# HG changeset patch
# User Matt Harbison
# Date 1522119770 14400
# Mon Mar 26 23:02:50 2018 -0400
# Node ID 544761f9f8ee47e6b35b2b3fad0b69914e10341d
# Parent 19b73408a618666979209b9654182e6fa72364d2
lfs: move the 'supportedoutgoingversions' handling to
On Mon, 19 Mar 2018 00:08:24 -0400, Matt Harbison
wrote:
# HG changeset patch
# User Matt Harbison
# Date 1519360432 18000
# Thu Feb 22 23:33:52 2018 -0500
# Node ID 793636c45477f81af6fddacc458979fecc84ae3a
# Parent
rdamazio updated this revision to Diff 7331.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2678?vs=7330=7331
REVISION DETAIL
https://phab.mercurial-scm.org/D2678
AFFECTED FILES
hgext/show.py
mercurial/configitems.py
mercurial/dispatch.py
# HG changeset patch
# User Codarren Velvindron
# Date 1522053522 -14400
# Mon Mar 26 12:38:42 2018 +0400
# Node ID e11770b0adde6283965cafff1d6214a048417bfe
# Parent 6715e8035b4ff9379a80f5413a4e9148114ab256
sslutil: add tls 1.3 support
Done during the IETF101 Hackathon.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6f570c501e3e: merge: deprecate accessing update results by
index (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit added a comment.
In https://phab.mercurial-scm.org/D2678#45633, @spectral wrote:
> In https://phab.mercurial-scm.org/D2678#45552, @durin42 wrote:
>
> > Ugh:
> >
> > --- /home/augie/hg/tests/test-alias.t
> > +++ /home/augie/hg/tests/test-alias.t.err
> > @@ -357,15
sangeet259 updated this revision to Diff 7289.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2938?vs=7280=7289
REVISION DETAIL
https://phab.mercurial-scm.org/D2938
AFFECTED FILES
mercurial/commands.py
tests/test-grep.t
CHANGE DETAILS
diff --git
yuja added a comment.
If the perf hit was because of lookup of global variables, maybe we can alias
them in functions where hot loop exists.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2701
To: indygreg, #hg-reviewers, phillco, durin42
Cc: yuja, quark,
On Mon, 26 Mar 2018 13:43:59 +0400, Codarren Velvindron wrote:
> # HG changeset patch
> # User Codarren Velvindron
> # Date 1522053522 -14400
> # Mon Mar 26 12:38:42 2018 +0400
> # Node ID e11770b0adde6283965cafff1d6214a048417bfe
> # Parent
On Mon, 26 Mar 2018 22:13:18 +0900
Yuya Nishihara wrote:
> Can you hold off this series for 2-3 weeks?
Sure, I'll do that.
> I have long series which will
> add a wrapper for a list of template mappings. Basically it will allow us
> to write the default string representation as
khanchi97 updated this revision to Diff 7285.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2934?vs=7254=7285
REVISION DETAIL
https://phab.mercurial-scm.org/D2934
AFFECTED FILES
mercurial/cmdutil.py
mercurial/commands.py
tests/test-add.t
pulkit updated this revision to Diff 7287.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2874?vs=7250=7287
REVISION DETAIL
https://phab.mercurial-scm.org/D2874
AFFECTED FILES
mercurial/exchange.py
tests/test-logexchange.t
CHANGE DETAILS
diff
pulkit updated this revision to Diff 7286.
pulkit edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2873?vs=7249=7286
REVISION DETAIL
https://phab.mercurial-scm.org/D2873
AFFECTED FILES
hgext/remotenames.py
pulkit updated this revision to Diff 7288.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2875?vs=7251=7288
REVISION DETAIL
https://phab.mercurial-scm.org/D2875
AFFECTED FILES
hgext/remotenames.py
tests/test-logexchange.t
CHANGE DETAILS
diff
On Mon, 26 Mar 2018 19:55:20 +0800, Anton Shestakov wrote:
> # HG changeset patch
> # User Anton Shestakov
> # Date 1522054812 -28800
> # Mon Mar 26 17:00:12 2018 +0800
> # Node ID 123d9e4d706909c8912f11acee292735c0fb283c
> # Parent
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch moves out logic to read old histedit-state file to a separate
function as we will need to register that function as a
pulkit updated this revision to Diff 7304.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2855?vs=7108=7304
REVISION DETAIL
https://phab.mercurial-scm.org/D2855
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git a/mercurial/commands.py
martinvonz added inline comments.
INLINE COMMENTS
> pulkit wrote in state.py:84
> I don't have a strong reason. I just found this an easy way. I was going to
> add __setitem__() too so that we can store more new values or change existing
> values.
>
> For graft case, it won't be just a list
# HG changeset patch
# User Anton Shestakov
# Date 1522062197 -28800
# Mon Mar 26 19:03:17 2018 +0800
# Node ID cc4c495dc38d5cf3a1b7e1162f1c745c1440de01
# Parent 123d9e4d706909c8912f11acee292735c0fb283c
debug: remove debugwhyunstable command
It was introduced in
# HG changeset patch
# User Anton Shestakov
# Date 1522054812 -28800
# Mon Mar 26 17:00:12 2018 +0800
# Node ID 123d9e4d706909c8912f11acee292735c0fb283c
# Parent 6f570c501e3ebc3d9b59920f50ed7523d93cb847
templates: add whyunstable template keyword
diff --git
https://bz.mercurial-scm.org/show_bug.cgi?id=5827
Bug ID: 5827
Summary: Setting HG in environment breaks shell aliases
Product: Mercurial
Version: default branch
Hardware: All
OS: All
Status: UNCONFIRMED
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Capture various TODOs and return an explicit value. This
represents feedback from Yuya and Augie on various commits.
REPOSITORY
rHG Mercurial
REVISION DETAIL
durin42 added a comment.
In https://phab.mercurial-scm.org/D2939#47601, @indygreg wrote:
> This still fails for me with:
>
> File "/home/gps/src/hg/mercurial/context.py", line 1590, in
_dirstatestatus
> clean=clean, unknown=unknown)
> File
pulkit updated this revision to Diff 7303.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2597?vs=6448=7303
REVISION DETAIL
https://phab.mercurial-scm.org/D2597
AFFECTED FILES
tests/test-graft.t
CHANGE DETAILS
diff --git a/tests/test-graft.t
pulkit updated this revision to Diff 7301.
pulkit edited the summary of this revision.
pulkit retitled this revision from "graft: move logic to read current graft
state file in state.py" to "graft: move logic to read current graft state file
in separate function".
REPOSITORY
rHG Mercurial
pulkit updated this revision to Diff 7302.
pulkit edited the summary of this revision.
pulkit retitled this revision from "graft: start using the new state file" to
"graft: start using the new state file class".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg updated this revision to Diff 7295.
indygreg edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2902?vs=7151=7295
REVISION DETAIL
https://phab.mercurial-scm.org/D2902
AFFECTED FILES
indygreg added a comment.
I may look into this today. Having fsmonitor disabled makes operations on
Firefox repos much slower and this is hampering my ability to hack on that repo
:/
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2939
To: durin42,
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG86f363eabd90: wireproto: review fixups (authored by
indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2944?vs=7294=7296
REVISION DETAIL
pulkit updated this revision to Diff 7298.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2592?vs=6443=7298
REVISION DETAIL
https://phab.mercurial-scm.org/D2592
AFFECTED FILES
mercurial/state.py
CHANGE DETAILS
diff --git a/mercurial/state.py
pulkit updated this revision to Diff 7300.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2593?vs=6759=7300
REVISION DETAIL
https://phab.mercurial-scm.org/D2593
AFFECTED FILES
mercurial/state.py
CHANGE DETAILS
diff --git a/mercurial/state.py
pulkit updated this revision to Diff 7306.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2593?vs=7300=7306
REVISION DETAIL
https://phab.mercurial-scm.org/D2593
AFFECTED FILES
mercurial/state.py
CHANGE DETAILS
diff --git a/mercurial/state.py
pulkit updated this revision to Diff 7297.
pulkit edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2591?vs=6442=7297
REVISION DETAIL
https://phab.mercurial-scm.org/D2591
AFFECTED FILES
mercurial/state.py
CHANGE
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch adds a magic header to each state file written using CBOR format so
that we can distinguish between old state files and new one even if old state
sangeet259 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
If grep is passed a revset in forwards order via -r , say -r 0:tip
Then the output is errorneous. This patch fixes that. The ouput was wrong
because
we
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I vendored upstream commit 84181540f6eb650437e3f73cd104a65661fe8e67. So the
relative imports will drop from this commit when it is pushed.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Having looked at the CBOR specification, I really like it! It is a better
version of JSON and MessagePack. It's a reasonable format for at-rest storage
and for exchange. While you may
pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in state.py:117-120
> Shouldn't this code be in commands.py? I don't think we should centralize the
> code for parsing all old formats in state.py. That will not happen with
> third-party extensions anyway, of course.
No strong
pulkit added a comment.
In https://phab.mercurial-scm.org/D2593#47511, @martinvonz wrote:
> In https://phab.mercurial-scm.org/D2593#44291, @indygreg wrote:
>
> > Not sure where to record this comment in this series. So I'll pick this
commit.
> >
> > I think we want an explicit
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4bd73a955ab0: thirdparty: vendor cbor2 python library
(authored by pulkit, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D2750?vs=6756=7291#toc
REPOSITORY
rHG Mercurial
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0e06d8086295: cbor: fix core test-check* (authored by
pulkit, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D2751?vs=6757=7292#toc
REPOSITORY
rHG Mercurial
CHANGES SINCE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7723e2e8cd61: cbor: add a __init__.py to top level cbor
module (authored by pulkit, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D2752?vs=6758=7293#toc
REPOSITORY
rHG
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I'm going to fold the deletes into the previous commit and rewrite the commit
message of this one accordingly.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg added a comment.
I also fixed this in flight to make the import in `__init__.py` relative.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2752
To: pulkit, #hg-reviewers, indygreg
Cc: martinvonz, alex_gaynor, indygreg, mercurial-devel
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
Pulkit apparently has changes for this series pending. Marking accordingly.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2591
To: pulkit,
sangeet259 added a comment.
Currently, I am not sure what tests I should add, the tests in test-grep.t
are passing.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2943
To: sangeet259, #hg-reviewers
Cc: mercurial-devel
pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in state.py:84
> How about not requiring it to be a dict? I imagine practically all callers
> will want to pass a dict, but why does this class have to enforce it? I think
> the API would be simpler if it was an opaque object.
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
This still fails for me with:
File "/home/gps/src/hg/mercurial/context.py", line 1590, in
_dirstatestatus
clean=clean, unknown=unknown)
File
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It is better to create outgoing streams through the reactor so the
reactor knows about what streams are active and can track them
accordingly.
Test output
spectral added inline comments.
INLINE COMMENTS
> bser.c:106
> + if (i == 8 && PySequence_Size(obj->values) < 7) {
> +// Hack alert: Python 3 removed support for os.stat().st_mtime
> +// being an integer.Instead, if you need an integer, you have to
My system pythons (2.7.13 and 3.5.3)
indygreg updated this revision to Diff 7311.
indygreg edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2902?vs=7295=7311
REVISION DETAIL
https://phab.mercurial-scm.org/D2902
AFFECTED FILES
durin42 added inline comments.
INLINE COMMENTS
> spectral wrote in bser.c:106
> My system pythons (2.7.13 and 3.5.3) have the following behaviors:
>
> ≻ python -c 'from __future__ import print_function; import os, sys, stat;
> print(sys.version); s=os.stat("."); print(s.st_mtime,
pulkit added a comment.
Can you add a test where fixing of one parent commit leads to a child commit
becoming empty. For example:
Commit 1: echo foo> a
Commit 2: echo Foo > a
And I run a lexer on commit 1 and 2, to change everything to uppercase.
INLINE COMMENTS
> fix.py:460
> +
sangeet259 updated this revision to Diff 7321.
sangeet259 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2943?vs=7290=7321
REVISION DETAIL
https://phab.mercurial-scm.org/D2943
AFFECTED FILES
mercurial/commands.py
indygreg updated this revision to Diff 7307.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2906?vs=7166=7307
REVISION DETAIL
https://phab.mercurial-scm.org/D2906
AFFECTED FILES
mercurial/wireprotoframing.py
mercurial/wireprotoserver.py
lothiraldan added a comment.
In https://phab.mercurial-scm.org/D1952#38770, @indygreg wrote:
> I like where this is going.
>
> It's worth noting that at some point this will reinvent the
//capabilities// mechanism of bundle2. Over the wire protocol today, the client
submits its
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Without this, standalone installs don't have the cbor files.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2949
AFFECTED FILES
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Now that we're using CBOR in the new wire protocol, let's convert
command requests to it.
Before I wrote this patch and was even thinking about CBOR, I was
indygreg updated this revision to Diff 7327.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2948?vs=7310=7327
REVISION DETAIL
https://phab.mercurial-scm.org/D2948
AFFECTED FILES
mercurial/debugcommands.py
mercurial/wireprotoframing.py
indygreg updated this revision to Diff 7324.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2906?vs=7307=7324
REVISION DETAIL
https://phab.mercurial-scm.org/D2906
AFFECTED FILES
mercurial/wireprotoframing.py
mercurial/wireprotoserver.py
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
There were two "testconflictingrequestid" methods. Naturally this isn't
an error in Python. And by our luck, the test was failing.
So we rename the test and
indygreg updated this revision to Diff 7326.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2947?vs=7309=7326
REVISION DETAIL
https://phab.mercurial-scm.org/D2947
AFFECTED FILES
mercurial/wireprotoframing.py
mercurial/wireprotoserver.py
hooper updated this revision to Diff 7329.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2897?vs=7165=7329
REVISION DETAIL
https://phab.mercurial-scm.org/D2897
AFFECTED FILES
hgext/fix.py
tests/test-doctest.py
tests/test-fix-clang-format.t
hooper marked 2 inline comments as done.
hooper added a comment.
In https://phab.mercurial-scm.org/D2897#47695, @pulkit wrote:
> Can you add a test where fixing of one parent commit leads to a child
commit becoming empty. For example:
>
> Commit 1: echo foo> a
> Commit 2: echo Foo
indygreg updated this revision to Diff 7308.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2907?vs=7167=7308
REVISION DETAIL
https://phab.mercurial-scm.org/D2907
AFFECTED FILES
mercurial/debugcommands.py
mercurial/help/internals/wireprotocol.txt
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We just vendored a library for encoding and decoding the CBOR
data format. While the intent of that vendor was to support state
files, CBOR is really a nice
indygreg updated this revision to Diff 7325.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2907?vs=7308=7325
REVISION DETAIL
https://phab.mercurial-scm.org/D2907
AFFECTED FILES
mercurial/debugcommands.py
mercurial/help/internals/wireprotocol.txt
70 matches
Mail list logo