D3370: scmutil: introduce shortesthexnodeidprefix()

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8254. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3370?vs=8249=8254 REVISION DETAIL https://phab.mercurial-scm.org/D3370 AFFECTED FILES hgext/show.py mercurial/scmutil.py mercurial/templatefuncs.py

D3310: scmutil: use resolvehexnodeidprefix() from revsymbol()

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8253. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3310?vs=8116=8253 REVISION DETAIL https://phab.mercurial-scm.org/D3310 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git

D3309: scmutil: rename resolvepartialhexnodeid() to resolvehexnodeidprefix()

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8252. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3309?vs=8247=8252 REVISION DETAIL https://phab.mercurial-scm.org/D3309 AFFECTED FILES hgext/eol.py hgext/histedit.py mercurial/context.py

D3313: scmutil: make shortesthexnodeidprefix() use unfiltered repo

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8255. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3313?vs=8250=8255 REVISION DETAIL https://phab.mercurial-scm.org/D3313 AFFECTED FILES hgext/show.py mercurial/scmutil.py mercurial/templatefuncs.py

D3371: scmutil: make shortesthexnodeidprefix() take a full binary nodeid

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The shortest() template function depended on the behavior of revlog._partialmatch() for these types of inputs: - non-hex strings - ambiguous strings -

D3308: scmutil: document that isrevsymbol() raises on ambiguous node prefix

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8251. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3308?vs=8114=8251 REVISION DETAIL https://phab.mercurial-scm.org/D3308 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git

Re: [PATCH 2 of 5] lfs: log information about Internal Server Errors reported in the Batch API

2018-04-14 Thread Yuya Nishihara
On Fri, 13 Apr 2018 18:04:34 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1523637594 14400 > # Fri Apr 13 12:39:54 2018 -0400 > # Node ID 54c1ab20ed7fbf415d087e6e94ca273d172046e8 > # Parent

Re: [PATCH 1 of 5] test-lfs: add tests to force server error path coverage

2018-04-14 Thread Yuya Nishihara
On Fri, 13 Apr 2018 18:04:33 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1523119701 14400 > # Sat Apr 07 12:48:21 2018 -0400 > # Node ID 1d394ac0efd4aa4f61f428fbac140fe57398f0b8 > # Parent

Re: [PATCH 3 of 5] lfs: fix the inferred remote store path when using a --prefix

2018-04-14 Thread Yuya Nishihara
On Fri, 13 Apr 2018 18:04:35 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1523643390 14400 > # Fri Apr 13 14:16:30 2018 -0400 > # Node ID a4c12789ef4bac6e736681ef8a08ccbe71fb5c41 > # Parent

D3311: revset: use resolvehexnodeidprefix() in id() predicate (BC)

2018-04-14 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. I have vague memory that it was intentional. Since `rev()` and `id()` never error out on unknown identifier, it doesn't make sense to reject only ambiguous nodeid. REPOSITORY

D3370: scmutil: introduce shortesthexnodeidprefix()

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe743b8524d60: scmutil: introduce shortesthexnodeidprefix() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3307: context: set stack level for deprecation warning

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1764527af92e: context: set stack level for deprecation warning (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3309: scmutil: rename resolvepartialhexnodeid() to resolvehexnodeidprefix()

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5f8f013e7d52: scmutil: rename resolvepartialhexnodeid() to resolvehexnodeidprefix() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3310: scmutil: use resolvehexnodeidprefix() from revsymbol()

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGab828755e1ea: scmutil: use resolvehexnodeidprefix() from revsymbol() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3331: util: set correct stack level on deprecation warnings

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5b8a260769a2: util: set correct stack level on deprecation warnings (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3308: scmutil: document that isrevsymbol() raises on ambiguous node prefix

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG41ac707322ba: scmutil: document that isrevsymbol() raises on ambiguous node prefix (authored by martinvonz, committed by ). CHANGED PRIOR TO COMMIT

[PATCH] test-check-commit: don't run hg per commit

2018-04-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523694452 -32400 # Sat Apr 14 17:27:32 2018 +0900 # Node ID 34cde18a454484a1cf6e716a3325ca9282277d59 # Parent e743b8524d608684b5a947337c37b686cfc0ae5b test-check-commit: don't run hg per commit We aren't stress testing CPU.

D2880: bundle: add the possibility to bundle bookmarks (issue5792)

2018-04-14 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 8263. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2880?vs=7077=8263 REVISION DETAIL https://phab.mercurial-scm.org/D2880 AFFECTED FILES mercurial/bundle2.py mercurial/commands.py

D2880: bundle: add the possibility to bundle bookmarks (issue5792)

2018-04-14 Thread lothiraldan (Boris Feld)
lothiraldan added inline comments. INLINE COMMENTS > martinvonz wrote in test-bundle-bookmarks.t:37-63 > Can we have a similar test case where we create divergence? Create a fork in > the graph in the debugdrawdag call above. Let's say you have commit F that > branches off of B, then do

D3309: scmutil: rename resolvepartialhexnodeid() to resolvehexnodeidprefix()

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8247. martinvonz edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3309?vs=8115=8247 REVISION DETAIL https://phab.mercurial-scm.org/D3309 AFFECTED FILES hgext/eol.py

D3311: revset: use resolvehexnodeidprefix() in id() predicate (BC)

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8248. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3311?vs=8117=8248 REVISION DETAIL https://phab.mercurial-scm.org/D3311 AFFECTED FILES mercurial/revset.py tests/test-revset.t CHANGE DETAILS diff --git

D3313: scmutil: make shortesthexnodeidprefix() use unfiltered repo

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8250. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3313?vs=8119=8250 REVISION DETAIL https://phab.mercurial-scm.org/D3313 AFFECTED FILES hgext/show.py mercurial/scmutil.py mercurial/templatefuncs.py

D3370: scmutil: introduce shortesthexnodeidprefix()

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have scmutil.resolvehexnodeidprefix() for resolving a prefix to a full nodeid, so it makes sense to have the inverse method next to it. For now it just

Re: [PATCH] dispatch: add a whitelist map of commands to implicitly loaded extensions

2018-04-14 Thread Yuya Nishihara
On Fri, 13 Apr 2018 23:30:43 -0400, Matt Harbison wrote: > On Fri, 13 Apr 2018 15:10:45 -0400, Gregory Szorc > wrote: > > What we may want instead is to key things off .hg/requires or a > > to-be-invented supplemental requirements-like file that declares soft > >

[PATCH 2 of 2] templates: make divergentnodes in whyunstable keyword be a mappinglist too (RFC)

2018-04-14 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1523705764 -28800 # Sat Apr 14 19:36:04 2018 +0800 # Node ID 6287c68bde7bcdc1dc260da9983ecc7fffc9ee20 # Parent 987c05eac1801d0b919c874280d03f9e8cccb411 templates: make divergentnodes in whyunstable keyword be a

[PATCH 1 of 2] templates: add whyunstable template keyword

2018-04-14 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1522054812 -28800 # Mon Mar 26 17:00:12 2018 +0800 # Node ID 987c05eac1801d0b919c874280d03f9e8cccb411 # Parent 8bacc09814ba5500d15fb40c472e84cb95ae2f99 templates: add whyunstable template keyword diff --git

D3367: hgwebdir: un-bytes the env dict before re-parsing env

2018-04-14 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > hgwebdir_mod.py:425 > # repository path component. > +uenv = {k.decode('latin1'): v for k, v in > +

Re: [PATCH 1 of 2] templates: add whyunstable template keyword

2018-04-14 Thread Anton Shestakov
On Mon, 26 Mar 2018 22:13:18 +0900 Yuya Nishihara wrote: > On Mon, 26 Mar 2018 19:55:20 +0800, Anton Shestakov wrote: > > # HG changeset patch > > # User Anton Shestakov > > # Date 1522054812 -28800 > > # Mon Mar 26 17:00:12 2018 +0800 > > # Node ID

Re: [PATCH 2 of 2] templates: make divergentnodes in whyunstable keyword be a mappinglist too (RFC)

2018-04-14 Thread Yuya Nishihara
On Sat, 14 Apr 2018 19:43:16 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1523705764 -28800 > # Sat Apr 14 19:36:04 2018 +0800 > # Node ID 6287c68bde7bcdc1dc260da9983ecc7fffc9ee20 > # Parent

Re: [PATCH 2 of 2] templates: make divergentnodes in whyunstable keyword be a mappinglist too (RFC)

2018-04-14 Thread Anton Shestakov
On Sat, 14 Apr 2018 21:09:46 +0900 Yuya Nishihara wrote: > On Sat, 14 Apr 2018 19:43:16 +0800, Anton Shestakov wrote: > > # HG changeset patch > > # User Anton Shestakov > > # Date 1523705764 -28800 > > # Sat Apr 14 19:36:04 2018 +0800 > > # Node ID

[PATCH] templates: make divergentnodes in whyunstable keyword be a hybrid list

2018-04-14 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1523709254 -28800 # Sat Apr 14 20:34:14 2018 +0800 # Node ID c7fc8a7ca7f5ca13e7e54a2690872f4252a41796 # Parent 987c05eac1801d0b919c874280d03f9e8cccb411 templates: make divergentnodes in whyunstable keyword be a hybrid

[PATCH 2 of 7] hgweb: make sessionvars class less dense

2018-04-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1522591438 -32400 # Sun Apr 01 23:03:58 2018 +0900 # Node ID 8bee5eca0b75333eee2c555663ae535005505991 # Parent 7b406ab5b3e9c3da9527a3001ba62e29506bd73a hgweb: make sessionvars class less dense diff --git

[PATCH 6 of 7] hgweb: extract a generator function of _siblings class

2018-04-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1522594063 -32400 # Sun Apr 01 23:47:43 2018 +0900 # Node ID 8e479b1d96bf94e81f76c78605c16b2864b219a5 # Parent affefa7df3fe2dd06be7cab086c16626010bc8b4 hgweb: extract a generator function of _siblings class _siblings will be

[PATCH 1 of 7] hgweb: prefix private variables of sessionvars with '_'

2018-04-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1522591382 -32400 # Sun Apr 01 23:03:02 2018 +0900 # Node ID 7b406ab5b3e9c3da9527a3001ba62e29506bd73a # Parent 34cde18a454484a1cf6e716a3325ca9282277d59 hgweb: prefix private variables of sessionvars with '_' diff --git

[PATCH 5 of 7] hgweb: wrap {changenav} and {nav} with mappinglist

2018-04-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1522593608 -32400 # Sun Apr 01 23:40:08 2018 +0900 # Node ID affefa7df3fe2dd06be7cab086c16626010bc8b4 # Parent ec55e9ef2255378a190bdda6f060dca23659cc9d hgweb: wrap {changenav} and {nav} with mappinglist diff --git

[PATCH 7 of 7] hgweb: convert _siblings to a factory function of mappinggenerator

2018-04-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1522594234 -32400 # Sun Apr 01 23:50:34 2018 +0900 # Node ID fe959b32685068231cad8ef26387c7c16fe0961a # Parent 8e479b1d96bf94e81f76c78605c16b2864b219a5 hgweb: convert _siblings to a factory function of mappinggenerator IIUC,

[PATCH 4 of 7] hgweb: make revnav.gen() simply build a list of mappings by one pass

2018-04-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1522593269 -32400 # Sun Apr 01 23:34:29 2018 +0900 # Node ID ec55e9ef2255378a190bdda6f060dca23659cc9d # Parent b7742898a29d79f01beb36c1cedd58acfdab05ab hgweb: make revnav.gen() simply build a list of mappings by one pass

[PATCH 3 of 7] hgweb: lift {sessionvars} to a wrapped type

2018-04-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1522591957 -32400 # Sun Apr 01 23:12:37 2018 +0900 # Node ID b7742898a29d79f01beb36c1cedd58acfdab05ab # Parent 8bee5eca0b75333eee2c555663ae535005505991 hgweb: lift {sessionvars} to a wrapped type Since a sessionvars object is

Re: [PATCH 3 of 3 V4] revset: skip legacy lookup for revspec wrapped in 'revset(…)'

2018-04-14 Thread Yuya Nishihara
On Sat, 14 Apr 2018 15:07:06 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1523369212 -7200 > # Tue Apr 10 16:06:52 2018 +0200 > # Node ID e345b7103fef40be16f792cda46aa899d0ef8dd1 > # Parent 304b6671aa1be37fc410edb38f2f2f3040ce6708 > #

D3359: stringutil: make b prefixes on string output optional

2018-04-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 8273. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3359?vs=8236=8273 REVISION DETAIL https://phab.mercurial-scm.org/D3359 AFFECTED FILES mercurial/utils/stringutil.py CHANGE DETAILS diff --git

D3367: hgwebdir: un-bytes the env dict before re-parsing env

2018-04-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 8275. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3367?vs=8244=8275 REVISION DETAIL https://phab.mercurial-scm.org/D3367 AFFECTED FILES mercurial/hgweb/hgwebdir_mod.py CHANGE DETAILS diff --git

D3364: largefiles: opts appears to already be bytes in this instance

2018-04-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 8274. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3364?vs=8241=8274 REVISION DETAIL https://phab.mercurial-scm.org/D3364 AFFECTED FILES contrib/python3-whitelist hgext/largefiles/overrides.py CHANGE DETAILS

D3348: py3: another three passing

2018-04-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 8268. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3348?vs=8225=8268 REVISION DETAIL https://phab.mercurial-scm.org/D3348 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git

D3350: tests: fix up a couple of minor bytes inconsistencies in run-tests.py

2018-04-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 8269. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3350?vs=8227=8269 REVISION DETAIL https://phab.mercurial-scm.org/D3350 AFFECTED FILES contrib/python3-whitelist tests/run-tests.py CHANGE DETAILS diff

D3351: py3: fix test-shelve.t on Python 3

2018-04-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 8270. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3351?vs=8228=8270 REVISION DETAIL https://phab.mercurial-scm.org/D3351 AFFECTED FILES contrib/python3-whitelist tests/test-shelve.t CHANGE DETAILS diff

D3358: stringutil: teach pprint how to format None

2018-04-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 8272. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3358?vs=8235=8272 REVISION DETAIL https://phab.mercurial-scm.org/D3358 AFFECTED FILES mercurial/utils/stringutil.py CHANGE DETAILS diff --git

D3356: wsgicgi: un-do some prior porting work that is now wrong

2018-04-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 8271. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3356?vs=8233=8271 REVISION DETAIL https://phab.mercurial-scm.org/D3356 AFFECTED FILES contrib/python3-whitelist mercurial/hgweb/wsgicgi.py CHANGE DETAILS

Re: [PATCH 1 of 2] templates: add whyunstable template keyword

2018-04-14 Thread Yuya Nishihara
On Sat, 14 Apr 2018 19:43:15 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1522054812 -28800 > # Mon Mar 26 17:00:12 2018 +0800 > # Node ID 987c05eac1801d0b919c874280d03f9e8cccb411 > # Parent

D3369: tests: add all missing b prefixes in reactor tests

2018-04-14 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcb71e0f9ac6f: tests: add all missing b prefixes in reactor tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3365: commands: drop spurious r'' on dry_run in forget

2018-04-14 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5fc502e149f1: commands: drop spurious r on dry_run in forget (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3368: stringutil: ast.literal_eval needs a unicode on py3

2018-04-14 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3942bd8db8b2: stringutil: ast.literal_eval needs a unicode on py3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3366: tests: port inline extension in test-http-bundle1.t to py3

2018-04-14 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe481d54f516d: tests: port inline extension in test-http-bundle1.t to py3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 1 of 2] templates: add whyunstable template keyword

2018-04-14 Thread Anton Shestakov
On Sat, 14 Apr 2018 21:03:23 +0900 Yuya Nishihara wrote: > On Sat, 14 Apr 2018 19:43:15 +0800, Anton Shestakov wrote: > > # HG changeset patch > > # User Anton Shestakov > > # Date 1522054812 -28800 > > # Mon Mar 26 17:00:12 2018 +0800 > > # Node ID

Re: [PATCH] templates: make divergentnodes in whyunstable keyword be a hybrid list

2018-04-14 Thread Yuya Nishihara
On Sat, 14 Apr 2018 20:39:21 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1523709254 -28800 > # Sat Apr 14 20:34:14 2018 +0800 > # Node ID c7fc8a7ca7f5ca13e7e54a2690872f4252a41796 > # Parent

[PATCH 3 of 3 V4] revset: skip legacy lookup for revspec wrapped in 'revset(…)'

2018-04-14 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1523369212 -7200 # Tue Apr 10 16:06:52 2018 +0200 # Node ID e345b7103fef40be16f792cda46aa899d0ef8dd1 # Parent 304b6671aa1be37fc410edb38f2f2f3040ce6708 # EXP-Topic noname # Available At

[PATCH 2 of 3 V4] revset: use and explicit loop to resolve each spec

2018-04-14 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1523367822 -7200 # Tue Apr 10 15:43:42 2018 +0200 # Node ID 304b6671aa1be37fc410edb38f2f2f3040ce6708 # Parent 5c1a0d784a26d4e8659dcec80503c8764432a303 # EXP-Topic noname # Available At

[PATCH 1 of 3 V4] revset: add more test to show current behaviors with label looking like revset

2018-04-14 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1519922236 18000 # Thu Mar 01 11:37:16 2018 -0500 # Node ID 5c1a0d784a26d4e8659dcec80503c8764432a303 # Parent e45545f7895e66d55379a7db48b13831eff6cf2a # EXP-Topic noname # Available At

D3372: keepalive: add ** overlooked in 83250442dc81

2018-04-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by Yuya in https://phab.mercurial-scm.org/D3326. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3372 AFFECTED FILES

D3367: hgwebdir: un-bytes the env dict before re-parsing env

2018-04-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 8277. Herald added a reviewer: pulkit. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3367?vs=8275=8277 REVISION DETAIL https://phab.mercurial-scm.org/D3367 AFFECTED FILES contrib/python3-whitelist

D3373: tests: port test-hg-parseurl.py to unittest

2018-04-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3373 AFFECTED FILES tests/test-hg-parseurl.py tests/test-hg-parseurl.py.out CHANGE DETAILS diff

D3374: tests: add b prefixes to test-hg-parseurl.py

2018-04-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now passes on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3374 AFFECTED FILES tests/test-hg-parseurl.py CHANGE

D3303: cborutil: implement support for streaming encoding, bytestring decoding

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D3303#53422, @yuja wrote: > If it's just for date tuple, I have a patch to get rid of floating-point timestamps > as our timestamps should be effectively ints. I believe that's the only place we use floats. Or at

D3375: cleanup: polyfill assertRaisesRegex so we can avoid assertRaisesRegexp

2018-04-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The latter is deprecated on Python 3.7 and causes our tests to fail due to the warning. REPOSITORY rHG Mercurial REVISION DETAIL

D3375: cleanup: polyfill assertRaisesRegex so we can avoid assertRaisesRegexp

2018-04-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 8281. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3375?vs=8280=8281 REVISION DETAIL https://phab.mercurial-scm.org/D3375 AFFECTED FILES tests/test-simplekeyvaluefile.py tests/test-wireproto-clientreactor.py

D3311: revset: use resolvehexnodeidprefix() in id() predicate (BC)

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D3311#53712, @yuja wrote: > I have vague memory that it was intentional. Since `rev()` and `id()` never > error out on unknown identifier, it doesn't make sense to reject only > ambiguous nodeid. I'm fine with

D3308: scmutil: document that isrevsymbol() raises on ambiguous node prefix

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8282. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3308?vs=8259=8282 REVISION DETAIL https://phab.mercurial-scm.org/D3308 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git

D3309: scmutil: rename resolvepartialhexnodeid() to resolvehexnodeidprefix()

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8283. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3309?vs=8260=8283 REVISION DETAIL https://phab.mercurial-scm.org/D3309 AFFECTED FILES hgext/eol.py hgext/histedit.py mercurial/context.py

D3310: scmutil: use resolvehexnodeidprefix() from revsymbol()

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8284. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3310?vs=8261=8284 REVISION DETAIL https://phab.mercurial-scm.org/D3310 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git

D3370: scmutil: introduce shortesthexnodeidprefix()

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8285. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3370?vs=8262=8285 REVISION DETAIL https://phab.mercurial-scm.org/D3370 AFFECTED FILES hgext/show.py mercurial/scmutil.py mercurial/templatefuncs.py

D3371: scmutil: make shortesthexnodeidprefix() take a full binary nodeid

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 8286. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3371?vs=8256=8286 REVISION DETAIL https://phab.mercurial-scm.org/D3371 AFFECTED FILES hgext/show.py mercurial/scmutil.py mercurial/templatefuncs.py

Re: [PATCH] dispatch: add a whitelist map of commands to implicitly loaded extensions

2018-04-14 Thread Matt Harbison
On Sat, 14 Apr 2018 03:09:01 -0400, Yuya Nishihara wrote: On Fri, 13 Apr 2018 23:30:43 -0400, Matt Harbison wrote: On Fri, 13 Apr 2018 15:10:45 -0400, Gregory Szorc wrote: > What we may want instead is to key things off .hg/requires or a >

Re: [PATCH 1 of 5] test-lfs: add tests to force server error path coverage

2018-04-14 Thread Matt Harbison
On Sat, 14 Apr 2018 03:28:49 -0400, Yuya Nishihara wrote: On Fri, 13 Apr 2018 18:04:33 -0400, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1523119701 14400 # Sat Apr 07 12:48:21 2018 -0400 # Node ID

D3372: keepalive: add ** overlooked in 83250442dc81

2018-04-14 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2177b499db6b: keepalive: add ** overlooked in 83250442dc81 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3372?vs=8276=8287

Re: [PATCH 1 of 5 V2] test-lfs: add tests to force server error path coverage

2018-04-14 Thread Yuya Nishihara
On Sat, 14 Apr 2018 14:47:33 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1523119701 14400 > # Sat Apr 07 12:48:21 2018 -0400 > # Node ID a83bc37bcf3da077f78bf3377b88b61d328bd4ce > # Parent

Re: [PATCH 1 of 2] templates: add whyunstable template keyword

2018-04-14 Thread Yuya Nishihara
On Sat, 14 Apr 2018 20:50:19 +0800, Anton Shestakov wrote: > On Sat, 14 Apr 2018 21:03:23 +0900 > Yuya Nishihara wrote: > > > +def formatnode(ctx): > > > +return ' %s (%s)' % (scmutil.formatchangeid(ctx), > > > ctx.phasestr()) > > > > Nit: leading ' ' isn't nice

[PATCH 2 of 3] makefile: reformat .PHONY targets

2018-04-14 Thread Antonio Muci via Mercurial-devel
# HG changeset patch # User Antonio Muci # Date 1523723037 -7200 # Sat Apr 14 18:23:57 2018 +0200 # Node ID b5874ec21df592d83c3f97aa12ea33dfdb03e839 # Parent 3c8463e542db60db1ad234ec80f39e290ed17658 makefile: reformat .PHONY targets the list of make targets is likely to

[PATCH 1 of 3] makefile: mkdir is not needed on templatized docker builds

2018-04-14 Thread Antonio Muci via Mercurial-devel
# HG changeset patch # User Antonio Muci # Date 1523714275 -7200 # Sat Apr 14 15:57:55 2018 +0200 # Node ID 3c8463e542db60db1ad234ec80f39e290ed17658 # Parent 1541e1a8e87de9bd6b869ed498ad8e9b93c59d4d makefile: mkdir is not needed on templatized docker builds this imitates

[PATCH 3 of 3] makefile: add Ubuntu Bionic docker targets (.deb and ppa)

2018-04-14 Thread Antonio Muci via Mercurial-devel
# HG changeset patch # User Antonio Muci # Date 1523713197 -7200 # Sat Apr 14 15:39:57 2018 +0200 # Node ID b29e5ecc90eef3af76eaaa4c21b992da66b8e444 # Parent b5874ec21df592d83c3f97aa12ea33dfdb03e839 makefile: add Ubuntu Bionic docker targets (.deb and ppa) Bionic Beaver is

D2880: bundle: add the possibility to bundle bookmarks (issue5792)

2018-04-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > lothiraldan wrote in test-bundle-bookmarks.t:37-63 > I have added such test and indeed this case is not handled right now. I'm not > aware of how Mercurial handle this case when exchanging bookmarks, I will > need to take a look at the code

[PATCH 3 of 5 V2] lfs: fix the inferred remote store path when using a --prefix

2018-04-14 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1523643390 14400 # Fri Apr 13 14:16:30 2018 -0400 # Node ID 414fdd730760f960aaa9b9e8cfb7853b543c8fca # Parent f5420feae687abf2e16e8444c385bdac9eedfeab lfs: fix the inferred remote store path when using a --prefix

[PATCH 1 of 5 V2] test-lfs: add tests to force server error path coverage

2018-04-14 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1523119701 14400 # Sat Apr 07 12:48:21 2018 -0400 # Node ID a83bc37bcf3da077f78bf3377b88b61d328bd4ce # Parent 9d509015742603624ef0df5497f0f205d8768ebf test-lfs: add tests to force server error path coverage The tests

[PATCH 4 of 5 V2] lfs: gracefully handle aborts on the server when corrupt blobs are detected

2018-04-14 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1519585633 18000 # Sun Feb 25 14:07:13 2018 -0500 # Node ID 6645ae6f5e2a248f23ec05df1ff6f48f3377cc47 # Parent 414fdd730760f960aaa9b9e8cfb7853b543c8fca lfs: gracefully handle aborts on the server when corrupt blobs are

[PATCH 5 of 5 V2] lfs: update the HTTP status codes in error cases

2018-04-14 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1523651553 14400 # Fri Apr 13 16:32:33 2018 -0400 # Node ID 075edc6d6add061ac13578bc3301c581de347412 # Parent 6645ae6f5e2a248f23ec05df1ff6f48f3377cc47 lfs: update the HTTP status codes in error cases I'm not

[PATCH 2 of 5 V2] lfs: log information about Internal Server Errors reported in the Batch API

2018-04-14 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1523637594 14400 # Fri Apr 13 12:39:54 2018 -0400 # Node ID f5420feae687abf2e16e8444c385bdac9eedfeab # Parent a83bc37bcf3da077f78bf3377b88b61d328bd4ce lfs: log information about Internal Server Errors reported in the

Re: [PATCH] test-check-commit: don't run hg per commit

2018-04-14 Thread Augie Fackler
> On Apr 14, 2018, at 4:49 AM, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1523694452 -32400 > # Sat Apr 14 17:27:32 2018 +0900 > # Node ID 34cde18a454484a1cf6e716a3325ca9282277d59 > # Parent

D3380: wireprotov2: establish a type for representing command response

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It will be desirable to have a higher-level type for representing command responses. This will allow us to do nicer things. For now, the instance

D3387: wireprotov2: remove support for sending bytes response

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We recently declared that all responses must be CBOR. So remove support for sending a type that isn't CBOR data. REPOSITORY rHG Mercurial REVISION DETAIL

D3382: wireprotov2: define response data as CBOR

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, response data was defined as a stream of bytes. We had the option to declare it as CBOR using a frame flag. We've converged all wire protocol

D3383: wireprotov2: change frame type value for command data

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When we dropped the dedicated command argument frame type, this left a hole in our frame type numbering. Let's start plugging that hole. The command data

D3303: cborutil: implement support for streaming encoding, bytestring decoding

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8301. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3303?vs=8152=8301 REVISION DETAIL https://phab.mercurial-scm.org/D3303 AFFECTED FILES contrib/import-checker.py mercurial/utils/cborutil.py

D3379: wireprotov2: move response handling out of httppeer

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY And fix some bugs while we're here. The code for processing response data from the unified framing protocol is mostly peer agnostic. The peer-specific bits

D3377: hg: pass command intents to repo/peer creation (API)

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous commit introduced a mechanism to declare command intents. This commit changes the repository and peer instantiation mechanism so the intents are

D3386: wireprotov2: change behavior of error frame

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we have a leading CBOR map in command response frames to indicate overall command result status, we don't need to use the error response frame to

D3378: debugcommands: ability to suppress logging of handshake

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The tests for calling wire protocol commands were getting quite verbose because they included the results of the capabilities request. Furthermore, it was

D3384: wireprotov2: change frame type and name for command response

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There was hole at frame type value 3. And the frame is better named as a command response. REPOSITORY rHG Mercurial REVISION DETAIL

D3388: wireprotov2: add support for more response types

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This adds types to represent error and generator responses from server commands. REPOSITORY rHG Mercurial REVISION DETAIL

D3381: wireprotov2: decode responses to their expected types

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Callers of established wire protocol commands expect the response from that command to be decoded into a data structure. It's not very useful if callers get

D3385: wireprotov2: change command response protocol to include a leading map

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The error handling mechanism for the new wire protocol isn't very well-defined. This commit takes us a step in the right direction by introducing a leading

D3376: registrar: replace "cmdtype" with an intent-based mechanism (API)

2018-04-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Commands perform varied actions and repositories vary in their capabilities. Historically, the .hg/requires file has been used to lock out clients lacking

Re: [PATCH] test-check-commit: don't run hg per commit

2018-04-14 Thread Matt Harbison
On Sat, 14 Apr 2018 04:49:38 -0400, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1523694452 -32400 # Sat Apr 14 17:27:32 2018 +0900 # Node ID 34cde18a454484a1cf6e716a3325ca9282277d59 # Parent

  1   2   >