[PATCH 3 of 5 STABLE] dirstate: use tuple interface to fix leak in pack_dirstate()

# HG changeset patch # User Yuya Nishihara # Date 1536148342 -32400 # Wed Sep 05 20:52:22 2018 +0900 # Branch stable # Node ID a55517cd5da69e41a7fafa0b46379920a5bda07f # Parent c1556580015504061ab7d1e48e81f5514adc60ac dirstate: use tuple interface to fix leak in pack_dirstate() Spotted by

[PATCH 4 of 5 STABLE] manifest: incref/decref copy->pydata to clarify 'copy' holds a reference

# HG changeset patch # User Yuya Nishihara # Date 1536151613 -32400 # Wed Sep 05 21:46:53 2018 +0900 # Branch stable # Node ID 819cf6343fb821f3ef53768d722ab7990540f31f # Parent a55517cd5da69e41a7fafa0b46379920a5bda07f manifest: incref/decref copy->pydata to clarify 'copy' holds a reference

Re: Wire protocol futures

On Wed, Sep 5, 2018 at 8:24 AM Josef 'Jeff' Sipek wrote: > There is a lot of info here, thanks for the write up! > > On Fri, Aug 31, 2018 at 15:47:34 -0700, Gregory Szorc wrote: > ... > > Assuming you only have primitive data retrieval commands, you are now > > issuing a lot more commands. > >

Re: [PATCH 5 of 5 STABLE] manifest: fix leak on error return from lazymanifest_filtercopy()

On Wed, Sep 5, 2018 at 7:05 AM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1536151784 -32400 > # Wed Sep 05 21:49:44 2018 +0900 > # Branch stable > # Node ID c922d17e33d542eaab1fdfc49638d6441d159e48 > # Parent 819cf6343fb821f3ef53768d722ab7990540f31f >

D4312: New bookflow extension for bookmark-based branching

idlsoft updated this revision to Diff 10789. CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4312?vs=10754=10789 REVISION DETAIL https://phab.mercurial-scm.org/D4312 AFFECTED FILES hgext/bookflow.py tests/test-bookflow.t CHANGE DETAILS diff --git a/tests/test-bookflow.t

[PATCH 2 of 5 STABLE] xdiff: fix leak in hunk_consumer()

# HG changeset patch # User Yuya Nishihara # Date 1536153041 -32400 # Wed Sep 05 22:10:41 2018 +0900 # Branch stable # Node ID c1556580015504061ab7d1e48e81f5514adc60ac # Parent 33c58a7ff5d54660c5c15a007d8297119cf9ab82 xdiff: fix leak in hunk_consumer() Spotted by ASAN. Since

[PATCH 1 of 5 STABLE] base85: fix leak on error return from b85decode()

# HG changeset patch # User Yuya Nishihara # Date 1536148658 -32400 # Wed Sep 05 20:57:38 2018 +0900 # Branch stable # Node ID 33c58a7ff5d54660c5c15a007d8297119cf9ab82 # Parent e574cae381b66a8543c8183a76768abcb55d98fc base85: fix leak on error return from b85decode() Spotted by ASAN. We

Re: Wire protocol futures

There is a lot of info here, thanks for the write up! On Fri, Aug 31, 2018 at 15:47:34 -0700, Gregory Szorc wrote: ... > Assuming you only have primitive data retrieval commands, you are now > issuing a lot more commands. While I'm all for allowing simpler servers (and hopefully clients too),

[PATCH 5 of 5 STABLE] manifest: fix leak on error return from lazymanifest_filtercopy()

# HG changeset patch # User Yuya Nishihara # Date 1536151784 -32400 # Wed Sep 05 21:49:44 2018 +0900 # Branch stable # Node ID c922d17e33d542eaab1fdfc49638d6441d159e48 # Parent 819cf6343fb821f3ef53768d722ab7990540f31f manifest: fix leak on error return from lazymanifest_filtercopy()

Re: [PATCH 1 of 5 STABLE] base85: fix leak on error return from b85decode()

On Wed, Sep 5, 2018 at 7:00 AM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1536148658 -32400 > # Wed Sep 05 20:57:38 2018 +0900 > # Branch stable > # Node ID 33c58a7ff5d54660c5c15a007d8297119cf9ab82 > # Parent e574cae381b66a8543c8183a76768abcb55d98fc >

Re: [PATCH 1 of 5 STABLE] base85: fix leak on error return from b85decode()

On Wed, Sep 5, 2018 at 8:20 AM Martin von Zweigbergk wrote: > > > On Wed, Sep 5, 2018 at 7:00 AM Yuya Nishihara wrote: > >> # HG changeset patch >> # User Yuya Nishihara >> # Date 1536148658 -32400 >> # Wed Sep 05 20:57:38 2018 +0900 >> # Branch stable >> # Node ID

D4474: wireprotov2peer: stream decoded responses

indygreg updated this revision to Diff 10792. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4474?vs=10771=10792 REVISION DETAIL https://phab.mercurial-scm.org/D4474 AFFECTED FILES mercurial/debugcommands.py mercurial/wireprotov2peer.py

D4487: wireprotov2: add TODOs around extending changesetdata fields

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Extensions will inevitably want to extend the set of changeset data/fields that can be requested. We'll need to implement support for extending this in the

D4492: wireprotov2: let clients drive delta behavior

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, the "manifestdata" and "filedata" commands assumed the receiver had all parent revisions for requested nodes. Unless the revision had no parents,

D4480: exchangev2: start to implement pull with wire protocol v2

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Wire protocol version 2 will take a substantially different approach to exchange than version 1 (at least as far as pulling is concerned). This commit

D4472: wireprotov2: implement commands as a generator of objects

indygreg updated this revision to Diff 10791. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4472?vs=10769=10791 REVISION DETAIL https://phab.mercurial-scm.org/D4472 AFFECTED FILES mercurial/error.py mercurial/help/internals/wireprotocolrpc.txt

D4490: wireprotov2: define and implement "filedata" command

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Continuing our trend of implementing *data commands for retrieving information about specific repository data primitives, this commit implements a command for

D4482: exchangev2: fetch changeset revisions

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY All Mercurial repository data is derived from changesets: you can't do anything unless you have changesets. Therefore, it makes sense for changesets to be the

D4483: wireprotov2: add phases to "changesetdata" command

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit teaches the "changesetdata" wire protocol command to emit the phase state for each changeset. This is a different approach from existing phase

D4486: exchangev2: fetch and apply bookmarks

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is pretty similar to phases data. We collect bookmarks data as we process records. Then at the end we make a call to the bookmarks subsystem to reflect

D4488: wireprotov2: define and implement "manifestdata" command

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The added command can be used for obtaining manifest data. Given a manifest path and set of manifest nodes, data about manifests can be retrieved. Unlike

D4465: httppeer: use our CBOR decoder

indygreg added a comment. In https://phab.mercurial-scm.org/D4465#68517, @pulkit wrote: > Queued the cbor patches. I think following can improve the code more: > > - Having a `cborutil.decodeone()` function which can make sure we only have one dcoded value and using that fn instead

D4441: wireprotov2peer: properly format errors

indygreg updated this revision to Diff 10790. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4441?vs=10698=10790 REVISION DETAIL https://phab.mercurial-scm.org/D4441 AFFECTED FILES mercurial/wireprotoframing.py mercurial/wireprotov2peer.py CHANGE

D4485: wireprotov2: add bookmarks to "changesetdata" command

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Like we did for phases, we want to emit bookmarks data attached to each changeset. The approach here is very similar to phases: we emit bookmarks data

D4491: exchangev2: fetch file revisions

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that the server has an API for fetching file data, we can call into it to fetch file revisions. The implementation is relatively straightforward: we

mercurial@39424: 5 new changesets (5 on stable)

5 new changesets (5 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/91477b123700 changeset: 39420:91477b123700 branch: stable parent: 39418:e574cae381b6 user:Yuya Nishihara date:Wed Sep 05 20:57:38 2018 +0900 summary: base85: fix leak on error

D4489: exchangev2: fetch manifest revisions

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that the server has support for retrieving manifest data, we can implement the client bits to call it. We teach the changeset fetching code to capture

D4481: wireprotov2: define and implement "changesetdata" command

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit introduces the "changesetdata" wire protocol command. The role of the command is to expose data associated with changelog revisions, including the

D4484: exchangev2: fetch and apply phases data

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that the server supports emitting phases data, we can request it and apply it on the client. Because we may receive phases-only updates from the server,

D4483: wireprotov2: add phases to "changesetdata" command

pulkit added inline comments. INLINE COMMENTS > wireprotocolv2.txt:155 > +phase (optional) > + (bytestring) The phase that a revision is in. Recognized values are > + ``secret``, ``draft``, and ``public``. Only present if ``phase`` data Won't it be better to use phase numbers here because

D4493: buildrpm: fix embarassing bug in shell variable expansions

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `$distance_$node` looks up and concatenates `$distance_` and `$node`. `$distance_` is empty, so we were getting the node without the distance. Using the curly

D4479: [RFC] obsolete: add mechanism to filter obsstore

pulkit added a comment. I just had a quick look. obsmarker repr hash, are we kind of inventing a way to index obsmarkers? I am pretty sure you people have thought about that, can you explain why you went with obsmarker repr hash instead of including a real index? Also, feel free to

D4496: tests: order the imports in test-fastannotate-hg.t

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The wrong ordering breaks test-check-module-imports.t on Python 3. I am not sure why that test is so much active on py3. REPOSITORY rHG Mercurial REVISION

D4495: py3: add new passing tests spotted by the buildbot

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4495 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D4494: buildrpm: remove TODO that looks done to me

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4494 AFFECTED FILES contrib/packaging/buildrpm CHANGE DETAILS diff --git

[Bug 5980] New: Streaming clones and clone bundles do not trigger pretxnchangegroup hooks

https://bz.mercurial-scm.org/show_bug.cgi?id=5980 Bug ID: 5980 Summary: Streaming clones and clone bundles do not trigger pretxnchangegroup hooks Product: Mercurial Version: 4.7 Hardware: All OS: All

[PATCH] lfs: ensure the blob is linked to the remote store on skipped uploads

# HG changeset patch # User Matt Harbison # Date 1536209481 14400 # Thu Sep 06 00:51:21 2018 -0400 # Node ID f8b494a211f85738d924f2869102a89c29ecb309 # Parent 53ed650843c5c1e1b7a829be525ca8087c68906f lfs: ensure the blob is linked to the remote store on skipped uploads I noticed a

D4483: wireprotov2: add phases to "changesetdata" command

indygreg added inline comments. INLINE COMMENTS > pulkit wrote in wireprotocolv2.txt:155 > Won't it be better to use phase numbers here because that's how we represent > phases at most of the places. If you agree, I can send a followup for that. I have no strong opinions. Using strings is more

[PATCH V2] absorb: clarify the reason for not finding changesets to modify

# HG changeset patch # User Matt Harbison # Date 1536108502 14400 # Tue Sep 04 20:48:22 2018 -0400 # Node ID 53ed650843c5c1e1b7a829be525ca8087c68906f # Parent 481db51c83e9bb5642be1ea1e88771dae5590552 absorb: clarify the reason for not finding changesets to modify I'm used to pushing to

D4465: httppeer: use our CBOR decoder

pulkit added a comment. Queued the cbor patches. I think following can improve the code more: - Having a `cborutil.decodeone()` function which can make sure we only have one dcoded value and using that fn instead of `decodeall()[0]` - A `cborutil.encode()` function to use where we

D4465: httppeer: use our CBOR decoder

This revision was automatically updated to reflect the committed changes. Closed by commit rHGcdb56f295b03: httppeer: use our CBOR decoder (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4465?vs=10762=10782 REVISION

D4467: wireprotoserver: use our CBOR encoder

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5f4a9ada5ab5: wireprotoserver: use our CBOR encoder (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4467?vs=10764=10784

D4466: wireprotoframing: use our CBOR module

This revision was automatically updated to reflect the committed changes. Closed by commit rHG36f487a332ad: wireprotoframing: use our CBOR module (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4466?vs=10763=10783

D4470: wireprotov2peer: use our CBOR decoder

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9f51fd22ed50: wireprotov2peer: use our CBOR decoder (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4470?vs=10767=10787

D4471: state: use our CBOR module

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5bfab9400daf: state: use our CBOR module (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4471?vs=10768=10788 REVISION

D4468: wireprotov2server: use our CBOR encoder

This revision was automatically updated to reflect the committed changes. Closed by commit rHG660879e49b46: wireprotov2server: use our CBOR encoder (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4468?vs=10765=10785

D4469: debugcommands: use our CBOR decoder

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe5eb67dea6e8: debugcommands: use our CBOR decoder (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4469?vs=10766=10786

Re: [PATCH] color: issue warning in yellow

On Mon, 2018-08-20 at 10:03 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1534290303 -7200 > # Wed Aug 15 01:45:03 2018 +0200 > # Node ID 4144148d7aba13ece916c6f735c791ca3d93a249 > # Parent c62184c6299c09d2e8e7be340f9aee138229cb86 > # EXP-Topic color-warning >

D4426: zsh_completion: use revsets to exclude this rev from suggestions to hg merge

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2815e0db4c54: zsh_completion: use revsets to exclude this rev from suggestions to hg merge (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4428: zsh_completion: complete shelve and unshelve

This revision was automatically updated to reflect the committed changes. Closed by commit rHG45d12c49c3f3: zsh_completion: complete shelve and unshelve (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4428?vs=10717=10781

D4476: verify: make output less confusing (issue5924)

pulkit accepted this revision. pulkit added a comment. This change looks good to me but I am not pushing it because I helped Meirambek to prepare the patch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4476 To: meirambek77, durin42, #hg-reviewers, pulkit Cc:

Re: [PATCH 1 of 2] absorb: clarify the reason for not finding changesets to modify

On Wed, Sep 5, 2018 at 3:57 AM Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1536108502 14400 > # Tue Sep 04 20:48:22 2018 -0400 > # Node ID ae1442742d796285b85bf9e0e0159665414f0478 > # Parent ab20ee07b82df985133f4e3fa3afa2ad48516340 > absorb: clarify the

Re: [PATCH 1 of 2] absorb: clarify the reason for not finding changesets to modify

On Wed, Sep 5, 2018 at 1:38 PM Pulkit Goyal <7895pul...@gmail.com> wrote: > > > On Wed, Sep 5, 2018 at 3:57 AM Matt Harbison > wrote: > >> # HG changeset patch >> # User Matt Harbison >> # Date 1536108502 14400 >> # Tue Sep 04 20:48:22 2018 -0400 >> # Node ID

D4464: drawdag: correctly pass repo to super constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9a813e4c8406: drawdag: correctly pass repo to super constructor (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[Bug 5979] New: revlog.ancestors emits nodes before their descendants, not strictly topological

https://bz.mercurial-scm.org/show_bug.cgi?id=5979 Bug ID: 5979 Summary: revlog.ancestors emits nodes before their descendants, not strictly topological Product: Mercurial Version: 4.7.1 Hardware: All OS: