https://bz.mercurial-scm.org/show_bug.cgi?id=5989
Bug ID: 5989
Summary: pullbundles do not correctly keep phases
Product: Mercurial
Version: 4.7.1
Hardware: PC
OS: Windows
Status: UNCONFIRMED
Severity:
https://bz.mercurial-scm.org/show_bug.cgi?id=5990
Bug ID: 5990
Summary: pullbundles: 'hg incoming' fails on bundle type
Product: Mercurial
Version: 4.7.1
Hardware: PC
OS: Windows
Status: UNCONFIRMED
On Sun, 23 Sep 2018 22:24:11 +0900
Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1537686948 -32400
> # Sun Sep 23 16:15:48 2018 +0900
> # Node ID d25a329a22d1521efa61fcfec7530b7f99d10a95
> # Parent 021347195627de0eed504c548cb4e629000a4726
> hgweb: register
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8e7e822e85ec: wireprotov2: expose rich arguments metadata
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGae20f52437e9: wireprotov2: advertise recognized path filter
prefixes (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd3d333ab167a: wireprotov2: teach changesetdata to fetch
ancestors until depth (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://bz.mercurial-scm.org/show_bug.cgi?id=5991
Bug ID: 5991
Summary: pullbundles: preoutgoing and outgoing hook missing
Product: Mercurial
Version: 4.7.1
Hardware: PC
OS: Linux
Status: UNCONFIRMED
durin42 added inline comments.
INLINE COMMENTS
> wireprotov2server.py:547
> +
> + ``required``
> + Bool indicating whether the argument is required.
https://phab.mercurial-scm.org/D4617 no longer exists, so I'm taking this
change as-is, but expect a follow-up (at least
https://bz.mercurial-scm.org/show_bug.cgi?id=5992
Bug ID: 5992
Summary: push over ssh fails with "abort: not a Mercurial
bundle" when remote hg is chg
Product: Mercurial
Version: 4.7
Hardware: PC
OS: Linux
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0b61d21f05cc: wireprotov2: declare command arguments richly
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg added a comment.
In https://phab.mercurial-scm.org/D4642#71269, @yuja wrote:
> > +Extensions should wrap these factory functions to customize
repository type
> > +creation. Note that an extension's wrapped function may be called
even if
> > +that extension is
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc30faea8d02d: wireprotov2: advertise set of valid values
for requestable fields (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg added a comment.
In https://phab.mercurial-scm.org/D4654#71289, @yuja wrote:
> > -class RevlogError(Hint, Exception):
> > +class StorageError(Hint, Exception):
> > +"""Raised when an error occurs in a storage layer.
> > +
> > +Usually subclassed by a
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Currently, the file storage interface has a handful of attributes
that are exclusively or near-exclusively used by repo verification
code. In order to support
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
If an unrecognized requirement is present (possibly due to an unloaded
extension), the user will get an error message telling them to go to
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
LFS is monkeypatching filelog.filelog and is then accessing
various filelog attributes in the monkeypatched function. This is all
fine.
But some of the
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The revlog index is a very low-level data structure and it shouldn't
be exposed to the storage interface - at least not in its current
form.
upgrade.py is
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The previous test was attempting to to test delta storage behavior.
It didn't do a very good job at it because there was a good chance
a delta wasn't being
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This logic - including the experimental bundle.reorder option -
was originally added in
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
With changegroup moving to emitrevisions(), this revlog-specific
attribute is no longer used and can be deleted. Good riddance.
REPOSITORY
rHG Mercurial
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Verify appears to want to compare the changelog's revlog version
number with the version number of filelogs and error if they are
different. But what it was
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4705
AFFECTED FILES
mercurial/localrepo.py
CHANGE DETAILS
diff --git a/mercurial/localrepo.py
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Whether LFS is enabled seems like a useful feature to expose. This
will also facilitate some future work around LFS feature compatibility.
REPOSITORY
rHG
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
There are a handful of attributes/methods on repository instances that
describe the behavior of the repository. Furthermore, there is
an unbound set of
indygreg added inline comments.
INLINE COMMENTS
> wireprotov2server.py:602-605
> +if 'default' in meta and meta.get('required'):
> +raise error.ProgrammingError('%s argument for command %s is
> marked '
> + 'as required but has a
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I'm not keen about doing this. But it unblocks efforts to remove
"index" from the file storage interface. We will probably remove this
once we have a better
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I recently refactored changegroup generation code to make it more
storage agnostic. I made significant progress. But there is still
a bit of work to be done.
On Thu, Sep 20, 2018 at 10:52 AM Matt Harbison
wrote:
>
> On Sep 20, 2018, at 11:53 AM, Gregory Szorc
> wrote:
>
> On Wed, Sep 19, 2018 at 8:28 PM Matt Harbison
> wrote:
>
>> On Wed, 19 Sep 2018 21:41:20 -0400, Gregory Szorc
>> wrote:
>>
>> > Currently, the largefiles and lfs extensions
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The previous commit removed the last consumer of the "index" attribute
on the file storage interface. The index is an extremely low-level
data structure that
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It is unused after a previous refactor. Spotted in
https://phab.mercurial-scm.org/D4641.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
There is no meaningful change in behavior because wdir would
already exist in the case where we raised RepoError. But I think
the code is easier to read if we
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Now that repository loading in core supports automatically loading
the lfs extension when the "lfs" requirement is present, we no
longer need to update the
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Now that we can create a shared repository via creation options, we
can handle other special actions related to share at repo creation time
as well.
One
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Now that repository loading in core supports automatically loading
the lfs extension when the "lfs" requirement is present, we no
longer need to update the
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This was only used by verify code. The check it was used for is now
implemented as part of the verifyintegrity() implementation. The
attribute is now unused,
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Previously, hg.share() had its own logic for creating a new
repository on the filesystem.
With the recent introduction of the createopts dict for passing
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This attribute is only used by LFS. It is used by one of the revlog
flag processor functions, which gets an instance of the revlog - not
the file storage type.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is very similar to what we just did for LFS but for largefiles.
See recent commit messages for the rationale here.
REPOSITORY
rHG Mercurial
REVISION
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
upgrade.py is the only consumer of filelog.index, which I'd like
to eliminate from the file storage interface.
This commit changes the upgrade code to
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We now have a proper storage API to request data on multiple
revisions. We can drop it into wire protocol version 2 with
minimal effort.
The new API
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We now have a unified API for emitting revision data from a storage
backend. It handles sorting nodes and the complicated delta versus
revision decisions for
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
emitrevisions() is the future!
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4726
AFFECTED FILES
mercurial/changegroup.py
durin42 added a subscriber: indygreg.
durin42 added a comment.
> indygreg added inline comments.
>
> INLINE COMMENTS
>
>> wireprotov2server.py:602-605
>> +if 'default' in meta and meta.get('required'):
>> +raise error.ProgrammingError('%s argument for
indygreg added a comment.
In https://phab.mercurial-scm.org/D4615#71677, @durin42 wrote:
> No, actually - I was proposing *removing* `required` entirely, and *only*
keying off the existence of a default. What you reduces us to only two valid
states: required-with-no-default and
indygreg added a subscriber: lothiraldan.
indygreg added a comment.
@lothiraldan: you are likely interested in this change because it is in the
same space as sparse revlogs.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4721
To: indygreg, #hg-reviewers
Cc:
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
In Python 3, HTTPResponse implements read() in terms of readinto(),
which was calling back into our readinto(), which duplicates
self._rbuf if it's not empty.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Otherwise we get an error attempting to dispatch a command with
arguments because we're passing a dict with bytes keys.
REPOSITORY
rHG Mercurial
REVISION
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This was raising a TypeError on Python 3 and preventing most (all?)
wireprotov2 commands from working.
REPOSITORY
rHG Mercurial
REVISION DETAIL
mharbison72 added a comment.
Not related to this patch specifically, but if you're redesigning verify
APIs...
One of the unresolved issues in LFS is how to handle verification. Right
now, verify wants the actual blob data, so it downloads it one at a time, as
needed, as part of
# HG changeset patch
# User Matt Harbison
# Date 1537578867 14400
# Fri Sep 21 21:14:27 2018 -0400
# Node ID efe8b55207d20747f7083aa66976f9bbbd52fe27
# Parent 84c805bcb52ebf4450f04a3aaf0e125ee0c72326
py3: apply byteskwargs to contrib/perf
diff --git a/contrib/perf.py b/contrib/perf.py
---
# HG changeset patch
# User Matt Harbison
# Date 1537576080 14400
# Fri Sep 21 20:28:00 2018 -0400
# Node ID 84c805bcb52ebf4450f04a3aaf0e125ee0c72326
# Parent 3709e38b0d5b812e2f11f27f493e6f0e30def497
py3: un-byteify strings around os.system() and os.devnull in contrib/perf
diff --git
indygreg added a comment.
In https://phab.mercurial-scm.org/D4710#71752, @mharbison72 wrote:
> Is it worth doing this with largefiles too? (I can follow up when this
settles out- I just wasn't sure what particular future work you had in mind,
since the autoload on requires works
# HG changeset patch
# User Matt Harbison
# Date 1537573703 14400
# Fri Sep 21 19:48:23 2018 -0400
# Node ID 1fcff747a558e32f9cb9d8411c256532455c10f8
# Parent d3d333ab167a5f0c23bd42a822732683d9afa221
py3: rename pycompat.getcwd() to encoding.getcwd() (API)
We need to avoid os.getcwdb() on
# HG changeset patch
# User Matt Harbison
# Date 1537756604 14400
# Sun Sep 23 22:36:44 2018 -0400
# Node ID bf1934083fa5c3a97492ea112ddb23e8ccf78294
# Parent 1fcff747a558e32f9cb9d8411c256532455c10f8
py3: don't use os.getcwdb() on Windows to avoid DeprecationWarnings
See also ac32685011a3.
# HG changeset patch
# User Matt Harbison
# Date 1537842750 14400
# Mon Sep 24 22:32:30 2018 -0400
# Node ID 48a1c0848e6abfaf707243567097710b262dbd09
# Parent 4527f507eb09ea26c9a419886c9e680ce1040642
py3: update missing module list in test-check-py3-compat.t for Windows
diff --git
durin42 created this revision.
Herald added a reviewer: pulkit.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Caught by the ratchet, but initially only the non-legacy path of
test-clone-uncompressed.t was passing. That required the
https://bz.mercurial-scm.org/show_bug.cgi?id=5993
Bug ID: 5993
Summary: absorb -i can crash
Product: Mercurial
Version: default branch
Hardware: PC
OS: Windows
Status: UNCONFIRMED
Severity: bug
mharbison72 accepted this revision.
mharbison72 added a comment.
I agree with the rationale. Thanks for this.
I guess we need to figure out how to handle push/pull upgrades before doing
the same to clone, because all 3 need a wire protocol capability to work. And
if we unconditionally
mharbison72 accepted this revision.
mharbison72 added a comment.
Seems reasonable to me.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4714
To: indygreg, #hg-reviewers, mharbison72
Cc: mharbison72, mercurial-devel
# HG changeset patch
# User Matt Harbison
# Date 1537575194 14400
# Fri Sep 21 20:13:14 2018 -0400
# Node ID 2f15c0bb3936f8f929e6af509778e3a6ef8ed704
# Parent f0849e47b29986ba6bc765226cba3bfb50c9c3ee
py3: switch contrib/perf from xrange to pycompat.xrange
diff --git a/contrib/perf.py
# HG changeset patch
# User Matt Harbison
# Date 1537575373 14400
# Fri Sep 21 20:16:13 2018 -0400
# Node ID 3709e38b0d5b812e2f11f27f493e6f0e30def497
# Parent 2f15c0bb3936f8f929e6af509778e3a6ef8ed704
py3: work around the lack of sys.maxint in contrib/perf
diff --git a/contrib/perf.py
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1cf1680b0554: keepalive: be more careful about self._rbuf
when calling super impls (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG94c25f694ec3: py3: whitelist two more passing tests
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4729?vs=11337=11339
mharbison72 accepted this revision.
mharbison72 added a comment.
Is it worth doing this with largefiles too? (I can follow up when this
settles out- I just wasn't sure what particular future work you had in mind,
since the autoload on requires works without it.)
REPOSITORY
rHG Mercurial
33 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/aeb2812f304d
changeset: 39759:aeb2812f304d
user:Matt Harbison
date:Fri Sep 21 00:37:03 2018 -0400
summary: py3: fix a type error in hghave.has_hardlink
# HG changeset patch
# User Matt Harbison
# Date 1537575036 14400
# Fri Sep 21 20:10:36 2018 -0400
# Node ID f0849e47b29986ba6bc765226cba3bfb50c9c3ee
# Parent 788eb3e31f3a6f5edca3125cc08dc74e75cb936e
py3: handle sysstr conversion around get/set attr in contrib/perf
diff --git
# HG changeset patch
# User Matt Harbison
# Date 1537574587 14400
# Fri Sep 21 20:03:07 2018 -0400
# Node ID 788eb3e31f3a6f5edca3125cc08dc74e75cb936e
# Parent bf1934083fa5c3a97492ea112ddb23e8ccf78294
py3: proxy posixfile objects to re-add a useful 'name' attribute on Windows
This file
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Otherwise the CBOR encoder fails on Python 3 due to lacking support
for encoding str/unicode.
1. skip-blame just some b'' prefixes
REPOSITORY
rHG
# HG changeset patch
# User Matt Harbison
# Date 1537678024 14400
# Sun Sep 23 00:47:04 2018 -0400
# Node ID 4527f507eb09ea26c9a419886c9e680ce1040642
# Parent efe8b55207d20747f7083aa66976f9bbbd52fe27
py3: convert arguments, cwd and env to native strings when spawning subprocess
This keeps
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D4710#71757, @indygreg wrote:
> In https://phab.mercurial-scm.org/D4710#71752, @mharbison72 wrote:
>
> > Is it worth doing this with largefiles too? (I can follow up when this
settles out- I just wasn't sure what
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This was preventing HTTP 500's from being sent in Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4730
AFFECTED FILES
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
In order to appease Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4733
AFFECTED FILES
mercurial/wireprotoframing.py
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D4642#71399, @indygreg wrote:
> In https://phab.mercurial-scm.org/D4642#71269, @yuja wrote:
>
> > > +Extensions should wrap these factory functions to customize
repository type
> > > +creation. Note that an
mharbison72 accepted this revision.
mharbison72 added a comment.
LGTM, thanks.
INLINE COMMENTS
> wrapper.py:211
> self.repo.vfs.append(
> 'hgrc',
> util.tonativeeol('\n[extensions]\nlfs=\n'))
>
The convert wrapper updates .hgrc too.
74 matches
Mail list logo
