Re: [PATCH 2 of 3] upgrade: add '-' in optimisation name

On Sun, 02 Dec 2018 16:56:45 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1531443930 -7200 > # Fri Jul 13 03:05:30 2018 +0200 > # Node ID 67ee61288306b5f74c2151a3e71a5321bc5989cb > # Parent 8ca558d1dc064bef67b6fb4341feecddceb216ce > # EXP-Topic upgrade-test >

Re: [PATCH 1 of 3] upgrade: test that fncache is valid after repository upgrade

On Sun, 02 Dec 2018 16:56:44 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1531443292 -7200 > # Fri Jul 13 02:54:52 2018 +0200 > # Node ID 8ca558d1dc064bef67b6fb4341feecddceb216ce > # Parent 7e6834ade51d98da575cfbeef651fc8a465c38b8 > # EXP-Topic upgrade-test >

D4312: New bookflow extension for bookmark-based branching

smf added a comment. In https://phab.mercurial-scm.org/D4312#79581, @durin42 wrote: > In https://phab.mercurial-scm.org/D4312#79573, @smf wrote: > > > In https://phab.mercurial-scm.org/D4312#79509, @durin42 wrote: > > > > > There's been some good discussion on this. I'm

D5370: rust: core implementation of missingancestors (no bindings)

yuja added a comment. > @yuja: do you mean one of those Differential Revisions of this system for each commit, sure I can do. I don't know how Phabricator is working, but probably yes. I meant we want https://phab.mercurial-scm.org/D5370, https://phab.mercurial-scm.org/D5371, and

Re: D5372: perfrevlogwrite: use progress helper

Queued the patches but for this, thanks. perf.py has to support old Mercurial versions. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D5374: fastannotate: use progress helper

yuja added a comment. > if ismainbranch: # need to write to linelog > > - if not self.ui.quiet: > - progress += 1 > - self.ui.progress(_('building cache'), progress, > - total=len(newmainbranch)) +progress.increment() This one is BC, but I think that's okay.

D5380: remotefilelog: use progress helper in shallowrepo

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb6a6dc1a14bd: remotefilelog: use progress helper in shallowrepo (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5382: remotefilelog: avoid temporarily using "count" variable as synonym for "total"

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb34b1b865ef9: remotefilelog: avoid temporarily using count variable as synonym for total (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5383: remotefilelog: remove an unnecessary update of "count" container

This revision was automatically updated to reflect the committed changes. Closed by commit rHG70de33b9d328: remotefilelog: remove an unnecessary update of count container (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5391: cleanupnodes: trust caller when "moves" is not None

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb7823bd59b07: cleanupnodes: trust caller when moves is not None (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5393: rebase: remove now-unnecessary arguments to _abort()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2041991f1ce2: rebase: remove now-unnecessary arguments to _abort() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[PATCH 3 of 8] commandserver: remove redundant "if True" block

# HG changeset patch # User Yuya Nishihara # Date 1540990987 -32400 # Wed Oct 31 22:03:07 2018 +0900 # Node ID 92023422fbe3cf05e6d25b8213bd1e5a749c8e98 # Parent c9533007e0e09fe8129b46208dbb760ff8799a88 commandserver: remove redundant "if True" block diff --git a/mercurial/commandserver.py

[PATCH 7 of 8] util: implement pop() on lrucachedict

# HG changeset patch # User Yuya Nishihara # Date 1541318225 -32400 # Sun Nov 04 16:57:05 2018 +0900 # Node ID d5e7ded8150f66f89b5b6ed0a0c49ea38018982e # Parent 2d23efc7274a923baffe9d0dc46709d651c468b4 util: implement pop() on lrucachedict This moves __delitem__() to pop() as the

[PATCH 6 of 8] util: add method to peek item in lrucachedict

# HG changeset patch # User Yuya Nishihara # Date 1540992545 -32400 # Wed Oct 31 22:29:05 2018 +0900 # Node ID 2d23efc7274a923baffe9d0dc46709d651c468b4 # Parent 5f4354d1aa370a028eee8bcc6de245b1212cf35c util: add method to peek item in lrucachedict I want a function that doesn't

D5370: rust: core implementation of missingancestors (no bindings)

yuja added a comment. Quickly scanned, and looks generally good to me. > rust: iterator version of Graph.parents > rust: translation of missingancestors > rust: translated random test of missingancestors Can you send these as separate patches? > An alternative would

D4312: New bookflow extension for bookmark-based branching

idlsoft added a comment. In https://phab.mercurial-scm.org/D4312#79938, @smf wrote: > This will not help the *average* user and sends a mixed (and dangerous) message that bookmarks should be used. Bookmarks have been in core for some time now, and there is not one mention

D5373: debugbuildannotatecache: use progress helper

This revision was automatically updated to reflect the committed changes. Closed by commit rHG901f6ef670ca: debugbuildannotatecache: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5374: fastannotate: use progress helper

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdd1006874a5a: fastannotate: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5374?vs=12713=12735

D5377: remotefilelog: use progress helper in remotefilelogserver

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfbd053af2eda: remotefilelog: use progress helper in remotefilelogserver (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5379: remotefilelog: use progress helper in shallowbundle

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4e08bbfc6d51: remotefilelog: use progress helper in shallowbundle (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5384: remotefilelog: replace a "a=[expr]; b=a[0]" by "b=expr; a = [b]"

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfe0b65ff00e7: remotefilelog: replace a a=[expr]; b=a[0] by b=expr; a = [b] (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[PATCH 1 of 8] commandserver: pass around option to hook repo instance creation

# HG changeset patch # User Yuya Nishihara # Date 1540990631 -32400 # Wed Oct 31 21:57:11 2018 +0900 # Node ID 958a93f4f9210c4b5669e4424f8d73b048ef72ed # Parent 53bdf0ab321c90189c61beb021d8eac54cf40918 commandserver: pass around option to hook repo instance creation This is necessary to

[PATCH 4 of 8] commandserver: loop over selector events

# HG changeset patch # User Yuya Nishihara # Date 1540991145 -32400 # Wed Oct 31 22:05:45 2018 +0900 # Node ID af9746ae6d62457788853eda54374b192b7a7134 # Parent 92023422fbe3cf05e6d25b8213bd1e5a749c8e98 commandserver: loop over selector events An IPC socket will be waited by the same

D5375: remotefilelog: use progress helper when analyzing repos

This revision was automatically updated to reflect the committed changes. Closed by commit rHG05afb32e9380: remotefilelog: use progress helper when analyzing repos (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5385: remotefilelog: reduce use of "count" container

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfcee112fb7c4: remotefilelog: reduce use of count container (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5388: tests: split test-shelve.t in two

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1b836cee2d91: tests: split test-shelve.t in two (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5388?vs=12728=12748

D5389: shelve: drop unnecessary backup of dirstate for phase-based case

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd7e44da4dc70: shelve: drop unnecessary backup of dirstate for phase-based case (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[PATCH 8 of 8] commandserver: preload repository in master server and reuse its file cache

# HG changeset patch # User Yuya Nishihara # Date 1540993388 -32400 # Wed Oct 31 22:43:08 2018 +0900 # Node ID 91fd85965d35c7eab04c8601442953639a65bf7c # Parent d5e7ded8150f66f89b5b6ed0a0c49ea38018982e commandserver: preload repository in master server and reuse its file cache This greatly

Re: D5374: fastannotate: use progress helper

> if ismainbranch: # need to write to linelog > -if not self.ui.quiet: > -progress += 1 > -self.ui.progress(_('building cache'), progress, > - total=len(newmainbranch)) > +

D5376: remotefilelog: use progress helper in basestore

This revision was automatically updated to reflect the committed changes. Closed by commit rHGad21fbcb1ba5: remotefilelog: use progress helper in basestore (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5381: remotefilelog: use progress helper in fileserverclient

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe58cd7ede1c3: remotefilelog: use progress helper in fileserverclient (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5386: remotefilelog: rely on progress helper for keeping track of position

This revision was automatically updated to reflect the committed changes. Closed by commit rHG74e3df766052: remotefilelog: rely on progress helper for keeping track of position (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5392: rebase: move abort() onto rebaseruntime

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc8eb8d1fc6cf: rebase: move abort() onto rebaseruntime (authored by martinvonz, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5392?vs=12732=12752#toc REPOSITORY rHG

D5390: shelve: change transaction description from "commit" to "shelve"

This revision was automatically updated to reflect the committed changes. Closed by commit rHG236af7cfa4c3: shelve: change transaction description from commit to shelve (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5370: rust: core implementation of missingancestors (no bindings)

kevincox added a comment. I think sticking close to the python version makes sense for the initial version. Then improvements can be made in follow-ups. INLINE COMMENTS > gracinet wrote in lib.rs:26 > The reason I've preferred to implement it directly is that `into_iter()` > iterates on

[PATCH 2 of 8] commandserver: extract handler of new socket connection

# HG changeset patch # User Yuya Nishihara # Date 1540990958 -32400 # Wed Oct 31 22:02:38 2018 +0900 # Node ID c9533007e0e09fe8129b46208dbb760ff8799a88 # Parent 958a93f4f9210c4b5669e4424f8d73b048ef72ed commandserver: extract handler of new socket connection This prepares for adding an IPC

D5372: perfrevlogwrite: use progress helper

yuja added a comment. Queued the patches but for this, thanks. perf.py has to support old Mercurial versions. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5372 To: martinvonz, #hg-reviewers Cc: yuja, mercurial-devel

D5378: remotefilelog: use progress helper in repack

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb80915b52476: remotefilelog: use progress helper in repack (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[PATCH 5 of 8] commandserver: add IPC channel to teach repository path on command finished

# HG changeset patch # User Yuya Nishihara # Date 1540991943 -32400 # Wed Oct 31 22:19:03 2018 +0900 # Node ID 5f4354d1aa370a028eee8bcc6de245b1212cf35c # Parent af9746ae6d62457788853eda54374b192b7a7134 commandserver: add IPC channel to teach repository path on command finished The idea is

Re: D5370: rust: core implementation of missingancestors (no bindings)

Quickly scanned, and looks generally good to me. > rust: iterator version of Graph.parents > rust: translation of missingancestors > rust: translated random test of missingancestors Can you send these as separate patches? > An alternative would have been to expose to Python >

Re: Auto-formatting code with black - object now if you have a strong opinion

On Wed, 05 Dec 2018 08:23:17 -0500, Yuya Nishihara wrote: On Tue, 4 Dec 2018 10:06:24 -0500, Augie Fackler wrote: So, options to move forward: 1) blacken everything (controversial for good reasons) 2) try black only on a subset 3) explore yapf 4) Give up and keep manually formatting files

D5370: rust: core implementation of missingancestors (no bindings)

gracinet added a comment. @yuja: do you mean one of those Differential Revisions of this system for each commit, sure I can do. With respect to rust-cpython bindings, I'm currently waiting for feedback on https://github.com/dgrunwald/rust-cpython/issues/164 Perhaps you'd have an idea

Re: D5370: rust: core implementation of missingancestors (no bindings)

> @yuja: do you mean one of those Differential Revisions of this system for > each commit, sure I can do. I don't know how Phabricator is working, but probably yes. I meant we want D5370, D5371, and D5372 instead of a folded D5370. I think phabsend will do that way. > With respect to