Re: [PATCH] tests: fix import order in test-bdiff

On Thu, Jan 12, 2017 at 8:59 PM, Gregory Szorc wrote: > On Wed, Jan 11, 2017 at 5:36 PM, Martin von Zweigbergk < > martinv...@google.com> wrote: > >> On Wed, Jan 11, 2017 at 4:48 PM, Gregory Szorc >> wrote: >> > On Wed, Jan 11, 2017 at 12:58 PM,

Re: [PATCH 2 of 2] template: filter to fill to terminal width (issue5395)

On Fri, Oct 7, 2016 at 5:07 AM, Simon Farnsworth wrote: > # HG changeset patch > # User Simon Farnsworth > # Date 1475841473 -7200 > # Fri Oct 07 13:57:53 2016 +0200 > # Node ID ad9be6bb981ca5dccdd4d64dd682e0cba780067b > # Parent

Re: [PATCH evolve-ext] fold: disallow multiple revisions without --exact

On Fri, Nov 4, 2016 at 4:58 PM, Martin von Zweigbergk via Mercurial-devel < mercurial-devel@mercurial-scm.org> wrote: > # HG changeset patch > # User Martin von Zweigbergk > # Date 1478303512 25200 > # Fri Nov 04 16:51:52 2016 -0700 > # Node ID

Re: [PATCH 06 of 11] internals: document compression negotiation

On Sun, Nov 20, 2016 at 2:23 PM, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1479679271 28800 > # Sun Nov 20 14:01:11 2016 -0800 > # Node ID 952478a50f2583be4400c0f6fcc156d73d46711c > # Parent

Re: [PATCH 08 of 11] util: declare wire protocol support of compression engines

On Mon, Nov 21, 2016 at 2:57 PM, Augie Fackler wrote: > On Sun, Nov 20, 2016 at 02:23:45PM -0800, Gregory Szorc wrote: > > # HG changeset patch > > # User Gregory Szorc > > # Date 1479679442 28800 > > # Sun Nov 20 14:04:02 2016 -0800 > > # Node ID

Re: [PATCH 08 of 11] util: declare wire protocol support of compression engines

On Sun, Nov 20, 2016 at 2:23 PM, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1479679442 28800 > # Sun Nov 20 14:04:02 2016 -0800 > # Node ID 9e0c42d347fd8bcba87561c92fc93b3ba597ec6f > # Parent

Re: [PATCH] debuglabelcomplete: fix to call debugnamecomplete in new location

I should probably add a test; ignore this, v2 incoming soon. On Tue, Mar 14, 2017 at 1:12 PM, Kyle Lippincott via Mercurial-devel < mercurial-devel@mercurial-scm.org> wrote: > # HG changeset patch > # User Kyle Lippincott <spect...@google.com> > # Date 1489522230 25200 >

Re: [PATCH 3 of 4] color: automatically define 16 and 256 colors if supported

On Sun, Jul 9, 2017 at 4:46 PM, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1499641339 25200 > # Sun Jul 09 16:02:19 2017 -0700 > # Node ID fa6223b9e2a0d9fbfa81329b83c0512417cee713 > # Parent

Re: [PATCH 4 of 4] [RFC] color: support different styling depending on color support (BC)

On Sun, Jul 9, 2017 at 9:32 PM, Jun Wu wrote: > I think the series is a good improvement and can be queued with some small > in-flight fixes. > > Excerpts from Gregory Szorc's message of 2017-07-09 16:46:17 -0700: > > diff --git a/mercurial/color.py b/mercurial/color.py > > ---

Re: [PATCH 3 of 4] color: automatically define 16 and 256 colors if supported

On Mon, Jul 10, 2017 at 5:26 PM, Gregory Szorc <gregory.sz...@gmail.com> wrote: > On Mon, Jul 10, 2017 at 4:32 PM, Kyle Lippincott <spect...@pewpew.net> > wrote: > >> >> >> On Sun, Jul 9, 2017 at 4:46 PM, Gregory Szorc <gregory.sz...@gmail.com> >

Re: [PATCH] zsh_completion: install as _hg not hg

Apparently I missed a test (I made this change on linux, not on mac), so v2 incoming soonish. On Fri, May 26, 2017 at 1:53 PM, Kyle Lippincott via Mercurial-devel < mercurial-devel@mercurial-scm.org> wrote: > # HG changeset patch > # User Kyle Lippincott <spect...@google.com> &

Re: [PATCH 4 of 5 osx] zsh_completion: install as _hg not hg

of waiting for 4.3 to get it out there? On Fri, May 26, 2017 at 5:27 PM, Augie Fackler <r...@durin42.com> wrote: > # HG changeset patch > # User Kyle Lippincott <spect...@google.com> > # Date 1495830247 25200 > # Fri May 26 13:24:07 2017 -0700 > # Node ID ffca36020b103

Re: Discussion about Mercurial 4.8 Sprint

On Thu, Jun 7, 2018 at 9:16 PM, Sean Farley wrote: > > Kyle Lippincott writes: > > > On Thu, Jun 7, 2018 at 9:16 AM, Boris FELD > wrote: > > > >> Hello everyone, > >> > >> I have also been in contact with Mercurial contributors, small > >

Re: Discussion about Mercurial 4.8 Sprint

On Thu, Jun 7, 2018 at 9:16 AM, Boris FELD wrote: > Hello everyone, > > I have also been in contact with Mercurial contributors, small > contributors and users from Europe. From what we heard, it's both a > question of time involvements and energy cost that is a rebuttal to them. > It's not the

Re: [PATCH STABLE v2] hghave: don't claim we have `tic` if it's NetBSD's binary (issue5698)

also looks good On Wed, Jun 27, 2018 at 8:50 AM, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1529932907 14400 > # Mon Jun 25 09:21:47 2018 -0400 > # Branch stable > # Node ID af7d21e1e44c1bb756af28b5978d3f7ee7d50eda > # Parent

Sprint 5.0 (Asia, Spring 2019)

Per the recent discussion at the 4.8 Sprint, let's discuss the next sprint now. The next one, for what is currently assumed to be the 5.0 release in Spring 2019, is currently scheduled to happen in Asia and I'm proposing Japan specifically. The past two sprints have been planned by Googlers and

Sprint 5.0

(Sending as a separate thread in case people had muted the other one) Please update your availability on the wiki page: https://www.mercurial-scm.org/wiki/5.0sprint, I'd like to have a date (and location) picked on Friday. ___ Mercurial-devel mailing

Re: Sprint 5.0 (Asia, Spring 2019)

I've started https://www.mercurial-scm.org/wiki/5.0sprint, please fill it in with your interest/availability, or if there's other places that can host! On Tue, Oct 16, 2018 at 9:59 AM Gregory Szorc wrote: > On Sun, Oct 14, 2018 at 12:30 PM Kyle Lippincott > wrote: > >>

Re: Sprint 5.0

to be held, and it will be in North America. On Mon, Jan 14, 2019 at 2:07 PM Kyle Lippincott wrote: > (Sending as a separate thread in case people had muted the other one) > > Please update your availability on the wiki page: > https://www.mercurial-scm.org/wiki/5.0sprint, I'd like to

Mercurial 5.4 sprint (Spring 2020)

I know the 5.2 sprint just finished, but let's get a jump start on planning the 5.4 sprint (Spring 2020). This one will be in Europe. We have had a few offers for hosting and I don't know all of the details, so please update the wiki page: https://www.mercurial-scm.org/wiki/5.4Sprint. Please put

Re: Call for comments on new dirstate format contents

On Mon, Jun 28, 2021 at 2:50 AM Raphaël Gomès wrote: > Hello all, > > As you probably know my colleagues at Octobus and I have been working on > a new version of the dirstate, and we're coming pretty close to > something usable in production, so we need to freeze the format soon. > This email is

D223: color: remove warnings if term is not formatted (==dumb or !ui.formatted())

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If the user sets color.mode=terminfo, and then runs in the shell inside of emacs (so TERM=dumb), the previous behavior was that it would warn about no terminfo

Re: D119: color: add autoterminfo option to prefer terminfo over ansi for non-windows

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If color.mode=auto in the config (this is the default) then color.py currently checks if using windows, and if not, uses 'ansi'. This means that to get

Re: D119: color: add autoterminfo option to prefer terminfo over ansi for non-windows

spectral removed subscribers: krbullock, simonfar. spectral added a comment. In https://phab.mercurial-scm.org/D119#2012, @krbullock wrote: > I like this, but I'd rather not take it right before a freeze. Can we revisit this for 4.4? I'm fine with waiting. I was on the fence

D223: color: remove warnings if term is not formatted (==dumb or !ui.formatted())

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf9f28ee41cac: color: remove warnings if term is not formatted (==dumb or !ui.formatted()) (authored by spectral). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D883: deb: build and install chg

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0133ca39c688: deb: build and install chg (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D883?vs=2281=2291 REVISION DETAIL

D882: deb: install zsh completions to /usr/share/zsh/vendor-completions

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9ecc622ca23f: deb: install zsh completions to /usr/share/zsh/vendor-completions (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D883: deb: build and install chg

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D883 AFFECTED FILES contrib/debian/rules tests/test-debian-packages.t CHANGE DETAILS diff --git

D882: deb: install zsh completions to /usr/share/zsh/vendor-completions

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This location is used by debian (and ubuntu) to store completions provided by other deb packages. The default fpath appears to have this before any of the

D879: tests: add "have" check for dpkg builddeps

This revision was automatically updated to reflect the committed changes. Closed by commit rHG13d3f8aaed87: tests: add have check for dpkg builddeps (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D879?vs=2265=2283

D878: tests: expect parsers.so in cext, parsers.py in pure (test-debian-packages)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3d936da4f97b: tests: expect parsers.so in cext, parsers.py in pure (test-debian-packages) (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D869: hghave: fix dpkg --version check to work on recent dpkg versions

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D869 AFFECTED FILES tests/hghave.py CHANGE DETAILS diff --git a/tests/hghave.py b/tests/hghave.py

D869: hghave: fix dpkg --version check to work on recent dpkg versions

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdbf83230e8be: hghave: fix dpkg --version check to work on recent dpkg versions (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D874: hghave: check for debuild being installed as well

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D874 AFFECTED FILES tests/hghave.py CHANGE DETAILS diff --git a/tests/hghave.py b/tests/hghave.py

D874: hghave: check for debuild being installed as well

This revision was automatically updated to reflect the committed changes. Closed by commit rHG200eadbcf0b0: hghave: check for debuild being installed as well (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D879: tests: add "have" check for dpkg builddeps

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D879 AFFECTED FILES tests/hghave.py tests/test-debian-packages.t CHANGE DETAILS diff --git

D878: tests: expect parsers.so in cext, parsers.py in pure (test-debian-packages)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D878 AFFECTED FILES tests/test-debian-packages.t CHANGE DETAILS diff --git

D608: wireproto: do not abort after successful lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6c6169f71b8d: wireproto: do not abort after successful lookup (authored by spectral). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D608?vs=1560=1588 REVISION

D608: wireproto: do not abort after successful lookup

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As far as I can tell, this interface originally used 'return' here, so the "fallthrough" to self._abort made sense. When it was switched to 'yield' this didn't

D1033: pycompat: define operating system constants

spectral accepted this revision. spectral added a comment. [Accepted with a very mild concern; I'm fine with it not being addressed] INLINE COMMENTS > quark wrote in pycompat.py:24 > For encoding, Python 2 and 3 are compatible if we use `r` prefixed strings. > > The `if` condition is to

D1494: develwarn: do not emit warning if "config" is unspecified

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa2395db68c6: develwarn: do not emit warning if config is unspecified (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1494: develwarn: do not emit warning if "config" is unspecified

spectral added a comment. (Specifically picked yuja as reviewer since they reviewed the original https://www.mercurial-scm.org/repo/hg/rev/3f33831a9202, so hopefully can tell me whether this was intentional or not and I'm possibly breaking stuff with this change :)) REPOSITORY rHG

D1494: develwarn: do not emit warning if "config" is unspecified

spectral created this revision. spectral added a reviewer: yuja. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, if the develwarn call site did not specify the category of warning, and devel.all-warnings was False, it would emit

D1719: debug: remove an 'if ui.debug()' that is not doing anything

spectral added a comment. In https://phab.mercurial-scm.org/D1719#29390, @quark wrote: > I think it should be `ui.debugflag`. I agree that's probably what was intended, but is it helpful to have it if it's never once been activated in 5 years? (added:

D1721: debug: customizable timestamp when printing ui.debug text

spectral added a comment. Someone pointed me at https://bitbucket.org/octobus/mercurial-devel/commits/668806cb43a0 and mentioned discussions on the devel mailing list that I haven't tracked down yet. Theirs is more complete and probably better than mine, so it would be nice to unify them

D1721: debug: customizable timestamp when printing ui.debug text

spectral added a comment. I'm not going to recommend to users to "see if you can reproduce the slowness issues while running with `PYTHONUNBUFFERED=1 /usr/bin/hg --debug | ruby -e'start = Time.now.to_f' -e'STDIN.each_line do |l|' -e" puts \"#{'%.3f' % (Time.now.to_f - start)} #{l}\""

D1721: debug: customizable timestamp when printing ui.debug text

spectral added a comment. https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-April/096617.html is the mailing list thread. Sounds like core is generally negative on the idea, which is disappointing, but OK.I can drop it easily :) REPOSITORY rHG Mercurial REVISION DETAIL

D1720: debug: add newlines at the end of three locations that appear to need it

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1720 AFFECTED FILES hgext/patchbomb.py mercurial/bundle2.py mercurial/dispatch.py CHANGE DETAILS

D1721: debug: customizable timestamp when printing ui.debug text

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Sometimes users report "X is slow", where X is usually something that has some debug output, like `hg push`. Having timestamps as part of the ui.debug() output

D1719: debug: remove an 'if ui.debug()' that is not doing anything

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY ui.debug() does not return a value. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1719 AFFECTED FILES

D1433: run-tests: fix TESTDIR if testdescs are absolute paths

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdb5da5c563d0: run-tests: fix TESTDIR if testdescs are absolute paths (authored by spectral, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D1433?vs=3578=3590#toc REPOSITORY

D1433: run-tests: fix TESTDIR if testdescs are absolute paths

spectral updated this revision to Diff 3578. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1433?vs=3549=3578 REVISION DETAIL https://phab.mercurial-scm.org/D1433 AFFECTED FILES tests/run-tests.py CHANGE DETAILS diff --git a/tests/run-tests.py

D1433: run-tests: fix TESTDIR if testdescs are absolute paths

spectral added a comment. In https://phab.mercurial-scm.org/D1433#23806, @yuja wrote: > Looks good, but perhaps we can simply do `os.path.join(TESTDIR, pathname)` > for any pathname. I didn't think that would work because of bytes, but apparently it does, at least on 2.7.13

D1433: run-tests: fix TESTDIR if testdescs are absolute paths

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Commit https://phab.mercurial-scm.org/rHGa18eef03d879b179c69744ff3568615402542938 made TESTDIR be the location of the arguments that were passed to

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

spectral added inline comments. INLINE COMMENTS > indygreg wrote in changegroup.py:738 > Can we use ``dict.popitem()`` instead? That will pop a random key-value pair. > I just don't know if the key needs to remain in the dict until later in the > function... I think that it needs to remain,

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

spectral updated this revision to Diff 3388. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1351?vs=3358=3388 REVISION DETAIL https://phab.mercurial-scm.org/D1351 AFFECTED FILES mercurial/changegroup.py CHANGE DETAILS diff --git

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

spectral marked 4 inline comments as done. spectral added a comment. run-tests.py found no issues with this version, my manual testing (using PYTHONHASHSEED to adjust the ordering) also encountered no issues INLINE COMMENTS > indygreg wrote in changegroup.py:738 > Can we use

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd80380ba8e7d: changegroup: use any node, not min(), in treemanifests generatemanifests (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is fixing quadratic behavior, which is probably not noticeable in the common case, but if a very large directory gets added here, it can get pretty bad.

D3559: narrow: only wrap dirstate functions once, instead of per-reposetup

spectral created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY chg will call reposetup multiple times, and we will end up double-wrapping (or worse) the dirstate functions; this can cause

D3577: crecord: fallback to text mode if diffs are too big for curses mode

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY crecord uses curses.newpad to create a region that we can then scroll around in by moving the main 'screen' as a veiwport into the (probably larger than the

D3571: tests: test-parseindex.t works just fine with chg

This revision was automatically updated to reflect the committed changes. Closed by commit rHGca890999d317: tests: test-parseindex.t works just fine with chg (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3562: tests: mark tests that fail when using chg as #require no-chg

This revision was automatically updated to reflect the committed changes. Closed by commit rHG538e850ae737: tests: mark tests that fail when using chg as #require no-chg (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3562: tests: mark tests that fail when using chg as #require no-chg

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As far as I can tell, most of these failures are due to using $HGPORT, which it seems chg might be using itself? I don't know enough to debug these failures to

D3571: tests: test-parseindex.t works just fine with chg

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In https://phab.mercurial-scm.org/rHG538e850ae73745c55bbb7da1ee3659c21a315688 I annotated tests that failed with chg with "#require no-chg", but did not

D3559: narrow: only wrap dirstate functions once, instead of per-reposetup

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1cba497491be: narrow: only wrap dirstate functions once, instead of per-reposetup (authored by spectral, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3559?vs=8744=8871#toc

D3643: localrepo: add docstring to _makedirstate to make it less likely to be removed

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2b8cb0ab231c: localrepo: add docstring to _makedirstate to make it less likely to be removed (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3655: graph: add outputgraph() function, called by ascii() to printthe graph to the ui.

spectral accepted this revision. spectral added a comment. lgtm, and as long as there's no test differences seems fine. (I don't have ability to accept the patch, and this is from another Googler anyway, so this is just first-stage review). REPOSITORY rHG Mercurial REVISION DETAIL

D3577: crecord: fallback to text mode if diffs are too big for curses mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdabc2237963c: crecord: fallback to text mode if diffs are too big for curses mode (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3643: localrepo: add docstring to _makedirstate to make it less likely to be removed

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3643 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git a/mercurial/localrepo.py

D3559: narrow: only wrap dirstate functions once, instead of per-reposetup

spectral updated this revision to Diff 8744. spectral edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3559?vs=8682=8744 REVISION DETAIL https://phab.mercurial-scm.org/D3559 AFFECTED FILES hgext/narrow/__init__.py

D3665: graph: improve graph output by using Unicode characters

spectral accepted this revision. spectral added a comment. lgtm, but yuja had asked for sean and others to look, and I don't have push access :) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3665 To: johnstiles, #hg-reviewers, spectral Cc: spectral, indygreg,

D3716: ui: add an unsafeoperation context manager that can block SIGINT

spectral added a comment. In https://phab.mercurial-scm.org/D3716#58934, @indygreg wrote: > I agree with @yuja that we should move this to `util.py` or one of its siblings and rename it to `uninterruptable` or some such. > > That being said, signal handlers are process global. And we

D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa0e185f10454: tests: in test-split.t, save a clean copy of pre-split repo for later use (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3665: graph: improve graph output by using Unicode characters

spectral added a comment. In https://phab.mercurial-scm.org/D3665#58616, @smf wrote: > johnstiles (John Stiles) writes: > > > johnstiles added a comment. > > > > Hi there @indygreg and @yuja -- are you happy with the diff as it currently stands? Do you think this needs any

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

spectral updated this revision to Diff 4714. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1808?vs=4695=4714 REVISION DETAIL https://phab.mercurial-scm.org/D1808 AFFECTED FILES mercurial/debugcommands.py tests/test-install.t CHANGE DETAILS diff

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

spectral updated this revision to Diff 4694. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1808?vs=4692=4694 REVISION DETAIL https://phab.mercurial-scm.org/D1808 AFFECTED FILES mercurial/debugcommands.py tests/test-install.t CHANGE DETAILS diff

D1809: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The test is currently not testing anything, the '--config ui.editor=~/path' argument is apparently of lower priority than the HGEDITOR that run-tests.py is

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A user was in #mercurial and had the following settings in their hgrc: [ui] editor = C:\home\npp\notepad++.exe -multiInst -nosession After

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

spectral updated this revision to Diff 4695. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1808?vs=4694=4695 REVISION DETAIL https://phab.mercurial-scm.org/D1808 AFFECTED FILES mercurial/debugcommands.py tests/test-install.t CHANGE DETAILS diff

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

spectral added inline comments. INLINE COMMENTS > krbullock wrote in debugcommands.py:1212 > In this patch, we end up printing something potentially different in the > "checking" line than in the "can't find editor" line. That seems wrong. I > think I'd rather we do the shlexsplit before

D1809: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo

This revision was automatically updated to reflect the committed changes. Closed by commit rHG711149d8e676: tests: switch test from --config ui.editor=~/foo to HGEDITOR=~/foo (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1720: debug: add newlines at the end of three locations that appear to need it

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7906354cbc68: debug: add newlines at the end of three locations that appear to need it (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1719: debug: remove an 'if ui.debug()' that is not doing anything

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3bb1a647ab42: debug: remove an if ui.debug() that is not doing anything (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2011: filemerge: support passing labels to external merge tools

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This adds $labellocal, $labelother, and $labelbase to the replacement set for merge-tools..args config variables, and to the environment as HG_MY_LABEL,

D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2015 AFFECTED FILES tests/test-split.t CHANGE DETAILS diff --git a/tests/test-split.t

D2017: split: accept a --secret flag to force phase of new commits

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is for parity with the identically named option on the `hg commit` (including `hg commit --amend`) command. REPOSITORY rHG Mercurial REVISION DETAIL

D2012: merge: use operation-provided labels (ex: dest/source) in several merge-tools

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Tools that did not use labels already, used only one, or used some label other than the exact strings of "local" or "other" were unmodified. Cases that used

D2013: commit: allow --no-secret to override phases.new-commit setting

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, if the user had phases.new-commit=secret, there was no way on the command line to commit as draft. This lets the user specify --no-secret to

D2016: split: preserve phase of commit that is being split

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With this change, `hg split` will preserve the phase of the commit that is being split, ignoring the phases.new-commit setting. Previously, we would use

D2014: amend: --no-secret overrides phases.new-commit and previous phase

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, commit --amend would keep the phase of the commit that's being amended, and commit --amend --secret would force it to secret. There was no

D2011: filemerge: support passing labels to external merge tools

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9037c29e9f53: filemerge: support passing labels to external merge tools (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2012: merge: use operation-provided labels (ex: dest/source) in several merge-tools

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa9802c9ecfb5: merge: use operation-provided labels (ex: dest/source) in several merge-tools (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

spectral marked an inline comment as done. spectral added a comment. Sorry, I forgot about this, can you take another look? I believe I addressed your most recent comment. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1808 To: spectral, #hg-reviewers,

D2013: commit: allow --no-secret to override phases.new-commit setting

spectral added a comment. In https://phab.mercurial-scm.org/D2013#33867, @martinvonz wrote: > I wonder if we should instead have a --draft option for this. Reasons: > > - If we ever add a fourth phase (like Jun's proposed "archived" phase), then --no-secret doesn't clearly indicate

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG04e81ae47066: debugcommands: print out the editor that was searched for (post shlexsplit) (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4071: resolve: graduate resolve.mark-check from experimental, add docs

spectral added inline comments. INLINE COMMENTS > pulkit wrote in config.txt:452 > I think here you mean 'none'? No, I didn't document the ``none`` case explicitly. This is saying that "even if it's going to abort, adding --all will bypass the error" (this is part of the hint when it aborts,

D4072: resolve: add commands.resolve.mark-check=abort to tweakdefaults

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4072 AFFECTED FILES mercurial/ui.py CHANGE DETAILS diff --git a/mercurial/ui.py b/mercurial/ui.py

D4071: resolve: graduate resolve.mark-check from experimental, add docs

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since this hasn't been in a release yet, I'm not bothering to add an alias for the experimental name of the config variable. REPOSITORY rHG Mercurial

D4072: resolve: add commands.resolve.mark-check=abort to tweakdefaults

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe9740c07158d: resolve: add commands.resolve.mark-check=abort to tweakdefaults (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

  1   2   3   4   5   6   7   >