Re: Better release notes

2017-02-12 Thread timeless
FWIW, @nokia, I looked at our commit message based changelog and decided it wasn't useful, so I maintained a curated list. Yes, it's frustrating that one has to do it, but it's much better than most alternatives. One release fwiw: http://browser.garage.maemo.org/news/4/ __

Re: [PATCH 2 of 2 stable] debian: update copyright years

2017-02-12 Thread timeless
We should really write a test for this sort of thing. Yes it's a bit silly, but it'd be helpful to catch it faster than 13 months late... ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mer

Inconsistent HG_PENDING handling

2017-02-12 Thread timeless
bookmarks.py if 'HG_PENDING' in encoding.environ: try: bkfile = repo.vfs('bookmarks.pending') dirstate.py def _trypending(root, vfs, filename): '''Open file to be read according to HG_PENDING environment variable This opens '.pending' of specified 'filename' only

test-merge-changedelete.t fails with my hgmerge

2017-02-14 Thread timeless
dibly unhelpful. I shouldn't have to insert dozens of debug statements to find out that `hg merge` called an `hgmerge` script and that the script failed. hg should tell me that it called `hgmerge` and that it failed. [timeless@gcc2-power8 tests]$ ./run-tests.py test-merge-changedelete.t --- /ho

[PATCH] bookmarks: fix HG_PENDING handling

2017-02-14 Thread timeless
# HG changeset patch # User timeless # Date 1487089111 0 # Tue Feb 14 16:18:31 2017 + # Node ID 54804162d8b35ceff3bd22f05b515fc716705ce2 # Parent f2ad0d8047009e6e58ab1fa34ae7107714f5dc30 # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

Re: [PATCH 2 of 2 stable] debian: update copyright years

2017-02-14 Thread timeless
timeless wrote: > We should really write a test for this sort of thing. Yes it's a bit > silly, but it'd be helpful to catch it faster than 13 months late... Augie Fackler wrote: > Sure, but carefully, for the reasons expressed in > https://www.mercurial-scm.org/pipermai

[PATCH] localrepo: change HG_PENDING handling

2017-02-14 Thread timeless
# HG changeset patch # User timeless # Date 1487089673 0 # Tue Feb 14 16:27:53 2017 + # Node ID 8d10b4c0cd6eb85098ec903c802a9602eda3a2f1 # Parent f2ad0d8047009e6e58ab1fa34ae7107714f5dc30 # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

Re: [PATCH 1 of 8 v4] mercurial: use best available timer for perf measurements

2017-02-14 Thread timeless
On Mon, Feb 13, 2017 at 12:29 PM, Simon Farnsworth wrote: > mercurial: use best available timer for perf measurements > > As documented for timer.default_timer, there are better timers available for > performance measures on some platforms. These timers don't have a set epoch, > and thus are only

Re: Better release notes

2017-02-14 Thread timeless
Sean Farley wrote: > I assume that these commit messages were from employees with commit > access? If that's true, then that's a bit different than patch-based > review where we can edit and review the commit message / notes. Well, we had two sources: 1. Mozilla upstream, where in theory messages

Re: test-merge-changedelete.t fails with my hgmerge

2017-02-14 Thread timeless
Bryan O'Sullivan wrote: > A long time ago, the default external merge program that we looked for was > called hgmerge, and there's still backwards compatibility code in > filemerge.py to support it. Yeah, I have some vague recollection of this. What's odd is that I'm pretty sure my hgmerge script

Re: [PATCH] transaction: enable hardlink backups for non-windows systems

2017-02-14 Thread timeless
Augie Fackler wrote: > I'm hesitant to take this because as of 10.12 macOS is pushing people > towards CIFS instead of AFP, Interesting > so this issue feels more likely to come up there. > Also, isn't it possible to mount CIFS volumes in the filesystem space on > Linux? I was going to mention

Re: [PATCH 05 of 10 v5] ui: log time spent blocked on stdio

2017-02-19 Thread timeless
Simon Farnsworth wrote: >> - > uiblocked=echo "\$EVENT command \$OPT_COMMAND_DURATION ms" >> + > uiblocked=echo "\$EVENT stdio \$OPT_STDIO_BLOCKED ms command >> \$OPT_COMMAND_DURATION ms" For reference, what you've missed was this part. The part below was fine, but here, you can clearly see it c

[PATCH] run-tests: improve diff intelligence [RFC]

2017-02-19 Thread timeless
# HG changeset patch # User timeless # Date 1487565093 0 # Mon Feb 20 04:31:33 2017 + # Node ID b04c501c22d75f368e69b3b533f71e16c17ea8b6 # Parent 693a5bb478543a986808264e586073a3ceedc38f # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

Re: [PATCH] bookmarks: fix HG_PENDING handling

2017-02-19 Thread timeless
fwiw, I really don't have the resources to push either of these forward. I was just trying to call attention to the problem. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] histedit: improve documentation and behaviour of dates (issue4820)

2017-02-19 Thread timeless
Fwiw, recently someone identified that if's are roughly as expensive as method calls. I /think/ that means it'd be better for: +if self.firstdate(): +commitopts['date'] = ctx.date() +else: +commitopts['date'] = max(ctx.date(), oldctx.date()) to be managed a

Re: Better release notes

2017-03-08 Thread timeless
Sean Farley wrote: Some good points there. Though, I didn't think we were talking about the commit message in general but rather with the special note tag: summary: change foo to bar Some technical details. More blah werd. :: notes This would be a highly curated message. Almost as if it were

[PATCH] fix: fix grammar/typos in hg help -e fix

2020-01-09 Thread timeless
# HG changeset patch # User timeless # Date 1578597560 18000 # Thu Jan 09 14:19:20 2020 -0500 # Node ID b8915d7827251d9383879b3de1d17d0773645dc6 # Parent cb2e2b095dc930a37e4de824138e8f5133295c96 fix: fix grammar/typos in hg help -e fix diff -r cb2e2b095dc9 -r b8915d782725 hgext/fix.py

test-convert-bzr-directories.t fails

2017-11-02 Thread timeless
Mercurial Distributed SCM (version 4.4+11-7ebf850d3166+20171103) Bazaar 2.5.1 -- a free distributed version-control tool --- /home/timeless/hg/crewplan/tests/test-convert-bzr-directories.t +++ /home/timeless/hg/crewplan/tests/test-convert-bzr-directories.t.err @@ -56,12 +56,56 @@ converting

[PATCH 1 of 5] demandimport: add trailing comma

2016-09-20 Thread timeless
# HG changeset patch # User timeless # Date 1474426019 0 # Wed Sep 21 02:46:59 2016 + # Node ID 24d85146985b7d2fef3c27b97d4be983e57ae5c7 # Parent 285a8c3e53f2183438f0cdbc238e4ab851d0d110 # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

Re: [PATCH 03 of 17] push: update help hint to point to config.paths section

2016-09-20 Thread timeless
a regression in that > regard, no? > > On Tue, Sep 20, 2016, 17:19 timeless wrote: > >> # HG changeset patch >> # User timeless >> # Date 1474402358 0 >> # Tue Sep 20 20:12:38 2016 + >> # Node ID ca073d2379d406e610450b957a955bf05ebf64f3 >> # Par

[PATCH 2 of 3] help: move revsets.## documentation into infix section

2016-09-21 Thread timeless
# HG changeset patch # User timeless # Date 1474478585 0 # Wed Sep 21 17:23:05 2016 + # Node ID 2ed8375eb6ca1fe2f00fac49f1b9c79d705a522a # Parent 40410e96c0a2de344edd5a25a7d996731124ee45 # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

[PATCH 1 of 3] help: clarify quotes are needed for filesets.size expressions

2016-09-21 Thread timeless
# HG changeset patch # User timeless # Date 1474475617 0 # Wed Sep 21 16:33:37 2016 + # Node ID 40410e96c0a2de344edd5a25a7d996731124ee45 # Parent 285a8c3e53f2183438f0cdbc238e4ab851d0d110 # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

[PATCH 3 of 3] help: add sections for revsets

2016-09-21 Thread timeless
# HG changeset patch # User timeless # Date 1474478613 0 # Wed Sep 21 17:23:33 2016 + # Node ID 692f1e17fb708d83e6022fc1ef1fb69366d7ee45 # Parent 2ed8375eb6ca1fe2f00fac49f1b9c79d705a522a # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

[PATCH 3 of 3 v2] demandimport: reject contextlib._GeneratorContextManager on Py < 3.2

2016-09-21 Thread timeless
# HG changeset patch # User timeless # Date 1474429683 0 # Wed Sep 21 03:48:03 2016 + # Node ID b2d5ad899bbb3c6eace4547b975c84f155066f0b # Parent 20111b4d031e63596b93e162af9b8ca3ff1c98af # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

[PATCH 1 of 3 v2] demandimport: refactor processfromlist to ensure consistent handling

2016-09-21 Thread timeless
# HG changeset patch # User timeless # Date 1474429251 0 # Wed Sep 21 03:40:51 2016 + # Node ID 32a4cb17f935c570817249721401e0d62033987d # Parent 982fe7cdb28bb263a96b1bc2c9c3b8aedb025ab6 # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

[PATCH 2 of 3 v2] demandimport: suppport rejecting modules based on requested properties

2016-09-21 Thread timeless
# HG changeset patch # User timeless # Date 1474429655 0 # Wed Sep 21 03:47:35 2016 + # Node ID 20111b4d031e63596b93e162af9b8ca3ff1c98af # Parent 32a4cb17f935c570817249721401e0d62033987d # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

Re: [PATCH 5 of 5] demandimport: reject contextlib._GeneratorContextManager on Py < 3.2

2016-09-21 Thread timeless
Yuya Nishihara wrote: > Can't we simply ignore 'contextlib' ? I had a patch that did that. It felt gross (it clearly wasn't very elegant) > Since contextlib is imported by demandimport.py, there's no benefit to delay > importing contextlib. So, demandimport could just return a given module if it

Re: [PATCH 3 of 3 v2] demandimport: reject contextlib._GeneratorContextManager on Py < 3.2

2016-09-21 Thread timeless
please hold off on v2. I'd like to try a v3 that handles distutils.msvc9compiler -- it turns out that processfromlist might really be too late and that I may have to really split out the iteration of fromlist into two places. ___ Mercurial-devel mailing l

[PATCH 3 of 3 v3] demandimport: reject contextlib._GeneratorContextManager on Py < 3.2

2016-09-21 Thread timeless
# HG changeset patch # User timeless # Date 1474429683 0 # Wed Sep 21 03:48:03 2016 + # Node ID 0070696439eab002f6dd32bcb40eb671daff800a # Parent adb54fd7d90f0ca607432ed7ae884da55ec427de # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

[PATCH 1 of 3 v3] demandimport: suppport rejecting modules based on requested properties

2016-09-21 Thread timeless
# HG changeset patch # User timeless # Date 1474484347 0 # Wed Sep 21 18:59:07 2016 + # Node ID 33884775ee4b22109085387b0317aa17db73c483 # Parent 982fe7cdb28bb263a96b1bc2c9c3b8aedb025ab6 # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

[PATCH 2 of 3 v3] demandimport: replace distutils.msvc9compiler ignore with reject

2016-09-21 Thread timeless
# HG changeset patch # User timeless # Date 1474484334 0 # Wed Sep 21 18:58:54 2016 + # Node ID adb54fd7d90f0ca607432ed7ae884da55ec427de # Parent 33884775ee4b22109085387b0317aa17db73c483 # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

Re: [PATCH 3 of 3 v3] demandimport: reject contextlib._GeneratorContextManager on Py < 3.2

2016-09-21 Thread timeless
Siddharth Agarwal wrote: > As a general thing I don't think we should be spending time trying to fix > this implementation of demandimport on Python 3 at all. This isn't really about python3, it's just about foreign code that expects a certain object to look a certain way, but because of demandimp

Re: [PATCH 3 of 3] demandimport: error out early on missing attribute of non package (issue5373)

2016-09-27 Thread timeless
be >> obtained >> from it. We can raise ImportError early if any attributes not found. > > > This seems fine. I've pushed it. > > I assume this superseed timeless series about reject? > > -- > Pierre-Yves David > >

Re: [PATCH] copy: distinguish "file exists" cases and add a hint (BC)

2016-09-28 Thread timeless
Pierre-Yves David wrote: > I'm curious about the timeless reasoning around using "replace" for a pure > book keeping operation that does not replace the file content. (But not > challenging that timeless is most probably right). Timeless can you > elaborate a bit ? I

Re: [PATCH 2 of 2 V2] changelog: disable delta chains

2016-10-04 Thread timeless
Are repositories locally compatible with older versions of hg? I'm pretty sure from what you've written that they're wire compatible with older versions. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mai

Re: [PATCH] templater: use "needle" and "haystack" as (meta-)variables for ifcontains()

2016-10-04 Thread timeless
Fwiw, I was tempted to +1 this change ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 00 of 11 ] graft: support grafting across move/copy (issue4028)

2016-10-05 Thread timeless
You shouldn't be sending part 0, that's been deprecated for a while. I wonder why your system encouraged it... ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 01 of 11] copies: style fixes and add comment (issue4028)

2016-10-05 Thread timeless
> @@ -331,7 +331,8 @@ > m2 = c2.manifest() > ma = ca.manifest() > > -copy1, copy2, = {}, {} > +# see checkcopies documentation below for these dicts > +copy1, copy2 = {}, {} I've been meaning to ask: Do we know why this is a -1+2 instead of a -0+1 diff? __

Re: [PATCH 02 of 11] copies: limit is an optimization, and doesn't provide guarantees (issue4028)

2016-10-05 Thread timeless
As noted elsewhere, the issue tag should only be applied to the commit that actually fixes the issue, not any commits leading up to that commit. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listi

Re: [PATCH 1 of 2] py3: convert to unicode to pass into encode()

2016-10-05 Thread timeless
> @@ -85,6 +85,9 @@ > # means u.encode(sys.getdefaultencoding()).decode(enc). Since > # the Python encoding defaults to 'ascii', this fails if the > # translated string use non-ASCII characters. > +if (isinstance(encoding.encoding, bytes) and > +

Re: [PATCH 3 of 3] revlog: read index data using mmap

2016-10-05 Thread timeless
http://bugs.python.org/issue16212 Title: mmap() dumps core upon resizing the underlying file Type: crash Stage: needs patch Components: IO Versions: Python 3.4, Python 3.2, Python 3.3 > It's not specific to the zero size truncation, it's enough if the file size > decreases beyond a page border.

Re: [PATCH python-hglib] Add feature to allow hglib user to get call backs for prompts and output

2016-10-06 Thread timeless
On Thu, Oct 6, 2016 at 12:52 PM, Barry A. Scott wrote: > Both pull() and push() have had three new, optiomal, aguments added them. optional ; arguments ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mail

Re: [PATCH 2 of 7] copies: update _checkcopies to work in a rotated DAG

2016-10-07 Thread timeless
Gábor Stefanik wrote: > copies: update _checkcopies to work in a rotated DAG I'd argue this should be tagged (BC). I absolutely support this change, it should be changed, it is a bug. But the reason I'd argue that it's a change is that a repository constructed along this path will result in a dif

Re: [PATCH] hgweb: fix the MRO in Python 3

2016-10-21 Thread timeless
Is there a checkcode test for this? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH WIP] help: show help content for disabled extension

2016-10-21 Thread timeless
Have we considered supporting `hg help churn.churn` where the first churn is a (possibly) disabled extension name, and the second is the name of a command within that extension? I'm not saying we should do this right away, but I can see some advantages to being able to support it later...

Re: [PATCH 7 of 8] bisect: build a displayer only once

2016-10-21 Thread timeless
Pierre-Yves David wrote: > There is multiple spot using this, building it early will help to extract more fwiw this should be `there are multiple places` -- [are (plural verb), multiple (plural hint), plural-noun] should all agree; `places` is a better noun than `spots`. _

Re: [PATCH 2 of 8] bisect: rename 'check_code' to match our naming scheme

2016-10-21 Thread timeless
Pierre-Yves David wrote: > bisect: rename 'check_code' to match our naming scheme I think you mean check_state ;-) > -def check_state(state, interactive=True): > +def checkstate(state, interactive=True): ___ Mercurial-devel mailing list Mercuria

Re: [PATCH RFC] templater: provide ring operations on integers

2016-10-21 Thread timeless
Simon Farnsworth wrote: > @@ -33,6 +33,9 @@ > +"+": (10, None, None, ("+", 10), None), > +"-": (10, None, ("negate", 10), ("-", 10), None), > +"*": (12, None, None, ("*", 12), None), Is it reasonable for me to ask for some user facing documentation of this? Possibly just an example. A

Re: [PATCH 3 of 3] parsers: move PyInt aliasing out of util.h

2016-10-21 Thread timeless
Gregory Szorc wrote: > + * 3 to compile. We should remove this once Python 3 support is fully > + * supported and proper types are used in the extensions themselves. */ Previously the comment was in a reusable header. It is no longer, so I suspect the portion about extensions is no longer applica

Re: [PATCH] store: py26 compat, don't use a dict comprehension

2016-10-21 Thread timeless
Martijn Pieters wrote: > store: py26 compat, don't use a dict comprehension > -cmap = {x:x for x in asciistr} Can we checkcode this? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/me

Re: [PATCH] templater: handle division by zero in arithmetic

2016-10-21 Thread timeless
Should we have a test for this? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH RFC] commands: introduce `hg display`

2016-10-21 Thread timeless
I'm +1 to this proposal :-) ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 1 of 8 V2] perf: introduce safeattrsetter to replace direct attribute assignment

2016-10-26 Thread timeless
FUJIWARA Katsunori wrote: > +If 'ignoremissing' is true, missing 'name' attribute doesn't cause > +abortion, and this function returns None. This is useful to fwiw, this should be `abort`. `abortion` is only used in English with regards to terminating pregnancies (occasionally it's misused

Re: [PATCH RFC] perf: add asv benchmarks

2016-10-26 Thread timeless
On Wed, Oct 12, 2016 at 4:35 AM, Philippe Pepiot wrote: > +"show_commit_url": "https://www.selenic.com/hg/rev/";, Not a review, but I believe this should be: https://www.mercurial-scm.org/repo/hg/ ___ Mercurial-devel mailing list Mercurial-devel@mer

Re: [PATCH v5] copy: distinguish "file exists" cases and add a hint (BC)

2016-10-26 Thread timeless
Augie Fackler wrote: > +hint = _('(hg rename %s to replace the file by ' > + 'recording a rename)\n') % flags > +hint = _('(hg copy %s to replace the file by ' > + 'recording a copy)\n')

Re: [PATCH 2 of 3] repovfs: add a ward to check if locks are properly taken

2016-10-26 Thread timeless
Pierre-Yves David wrote: > +# the remainig bit and drop this line remaining ;-) -- I really should try to put together a version of my spelling tool as a test to see what people think. I'd envision it running w/ a stored cache of allowed words, each run of the test wo

Re: [PATCH 2 of 3] cmdutil: add support for evolution "troubles" display in changeset_printer

2016-10-26 Thread timeless
If someone could try to grab my attention on irc for a couple of hours sometime soon I could try to work through this w/ whomever is alive ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinf

Re: [PATCH 07 of 16] copies: detect graft-like merges

2016-10-26 Thread timeless
Gábor Stefanik wrote: > +# overridden We still need to know a real common ancestor in this case We You're missing periods before `We` twice in this line... ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.o

Re: [PATCH 15 of 16] copies: make _checkcopies handle copy sequences spanning the TCA (issue4028)

2016-10-26 Thread timeless
> + note: possible conflict - f3b was renamed multiple times to: > + f3e > + f3d >merging f4e and f4a to f4e >warning: can't find ancestor for 'f3d' copied from 'f3b'! I know this isn't where the message was introduced, but I'm having a hard time understanding "renamed multiple times"

Re: [PATCH] hgweb: fix the MRO in Python 3

2016-10-26 Thread timeless
> Is there a checkcode test for this? Martijn Pieters wrote: > No, but tests simply fail when you make this mistake. > In this *specific case* that was only visible in the Python 3 tests because > the base classes used in Python 2 were old-style classes, so in *Python 2* > the base class order h

[PATCH 3 of 3] rebase: check for conflicts before continuing

2016-11-02 Thread timeless
# HG changeset patch # User timeless # Date 1478113169 0 # Wed Nov 02 18:59:29 2016 + # Node ID e9528bc734ce94456dd2389b4ea318278139c206 # Parent 8dae4ad6767cf3456dd2fc4b2a7b478d855091f7 # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

[PATCH 2 of 3] cmdutil: refactor checkunresolved

2016-11-02 Thread timeless
# HG changeset patch # User timeless # Date 1478112353 0 # Wed Nov 02 18:45:53 2016 + # Node ID 8dae4ad6767cf3456dd2fc4b2a7b478d855091f7 # Parent 78cf30254354eafb993ed7f226eb70d7b7abb6dc # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

[PATCH 1 of 3] rebase: rename merge to mergemod

2016-11-02 Thread timeless
# HG changeset patch # User timeless # Date 1478112967 0 # Wed Nov 02 18:56:07 2016 + # Node ID 78cf30254354eafb993ed7f226eb70d7b7abb6dc # Parent b032a7b676c6637b2ac6f3ef29431013b15a08f9 # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull https

Re: [PATCH 1 of 5 STABLE] tests: invoke printenv.py via sh -c for test portability

2016-11-04 Thread timeless
I'm sure this is already in, but wouldn't it be better to use a $PYTHON than `sh -c`? On Fri, Oct 28, 2016 at 2:16 PM, FUJIWARA Katsunori wrote: > # HG changeset patch > # User FUJIWARA Katsunori > # Date 1477676685 -32400 > # Sat Oct 29 02:44:45 2016 +0900 > # Branch stable > # Node ID 34a

Re: [PATCH 1 of 3 evolve-ext] evolve: suggest "hg update -C .", including '.', to abort evolve

2016-11-04 Thread timeless
technically this isn't wonderful, if you use bookmarks, `hg up -C .` isn't equivalent to `hg up -C {currentbookmark}`, and if you're using hg-git or something that puts significant weight on your active bookmark, this can lead you into some very unfortunate weeds. __

Re: [PATCH v5] copy: distinguish "file exists" cases and add a hint (BC)

2016-11-04 Thread timeless
Kevin Bullock wrote: > I'm not totally clear on what our approach to translations during a freeze is > either. I'm going by the freeze rules on the wiki, and the fact that > translation always happens on stable anyway, both of which lead me to believe > it should be okay? We should probably cla

to abort / to continue (UX)

2016-11-04 Thread timeless
timeless wrote: > technically this isn't wonderful, if you use bookmarks, `hg up -C .` > isn't equivalent to `hg up -C {currentbookmark}`, and if you're using > hg-git or something that puts significant weight on your active > bookmark, this can lead you into some very

Re: Topics [was: news from the topic experiment]

2016-11-04 Thread timeless
Sean Farley wrote: > For what it's worth, I've started to work on another repo implementing > what Erik suggested. It removes 'stacks' (since that's obviously out of > scope) and implements a topic-like branch workflow. So far, it's been a > good experiment and requires very little change. I'll pos

Re: [PATCH 3 of 4] tests: merge 'test-push-validation.t' into 'test-push.t'

2016-11-04 Thread timeless
Pierre-Yves David wrote: > tests: merge 'test-push-validation.t' into 'test-push.t' > > That test file is very small and is merge with the new 'test-push.t'. No logic > is changed but repository name are update to avoid collision. > > We don't register this as a copy because is actually a "ypoc" me

Re: [PATCH 1 of 5 STABLE] tests: invoke printenv.py via sh -c for test portability

2016-11-04 Thread timeless
timeless wrote: > I'm sure this is already in, but wouldn't it be better to use a > $PYTHON than `sh -c`? FUJIWARA Katsunori wrote: > I don't have strong opinion for using "sh -c". > > But, if we use $PYTHON instead of `sh -c` (= backing d19787db6

Re: [PATCH 2 of 2] commands: introduce `hg display`

2016-11-06 Thread timeless
Gregory Szorc wrote: > @@ -2019,6 +2026,13 @@ Dish up an empty repo; serve it cold. >diff repository (or selected files) > > > + > + display > + > + > + show various repository information > + > + > >export > Will /help/display list the views it supports? __

Re: [PATCH] help: show help for disabled extensions(issue5228)

2016-11-06 Thread timeless
Pulkit Goyal wrote: > This patch does not exactly solve issue5228 but it results in a better If it doesn't solve the issue, should the issue be tagged in the commit summary? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.m

Re: [PATCH 2 of 8] py3: add os.fsdecode() as pycompat.fsdecode()

2016-11-06 Thread timeless
Pulkit Goyal wrote: > +# In Python 2, fsdecode() have a very chances to recieve bytes. So it's receive ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 04 of 10] repair: identify repository deficiencies

2016-11-06 Thread timeless
Gregory Szorc wrote: > A command that upgrades repositories but doesn't say what it is doing shouldn't it still mention that it isn't doing the work? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman

Re: [PATCH 05 of 10] repair: obtain and validate requirements for upgraded repo

2016-11-06 Thread timeless
Gregory Szorc wrote: > +'missing: %s') % ', '.join(sorted(missingreqs))) I'd argue ', ' should be _(', '), although we probably don't manage this well or consistently... Also, is it too early to start talking about -T support? -- See `hg debuginstall`... __

Re: [PATCH 08 of 10] repair: migrate revlogs during upgrade

2016-11-06 Thread timeless
Gregory Szorc wrote: > +return changelog.changelog(repo.svfs) > +elif path.endswith('00manifest.i'): Does mercurial use `else` after `return` or does it omit them? > + store replacement complete; repository was inconsistent for 0.0s Do we want to allow tests to run a bit slower than

Re: Checking for conflict before merge

2016-11-20 Thread timeless
Notably hg up -C . will leave .rej / .orig files... Offhand, I'd probably play w/ the `share` extension or something, and basically have a working repository which I could blow away each time to avoid worrying too much about the working directory getting dirty.

Re: [PATCH 3 of 9] chgserve: pre-import extensions

2016-11-20 Thread timeless
Jun Wu wrote: > (pretend to be timeless) not bad, but... >> pre-importing extensions does not have side effects. > do the parsing for this is (pre-importing [extensions]) does not: pre-importing (e

Re: [PATCH 04 of 10] repair: identify repository deficiencies

2016-11-22 Thread timeless
Augie Fackler wrote: > Perhaps word as "pulling from modern servers may be slow" - I'm not > sure that "generaldelta repositories" is really a helpful string to > print to normal humans. > "changelog is storing deltas; changelog reading is slower than it could be" I'm +1 to these suggestions / ju

Can we automatically recognize when we should be fulfilling our deprecation promsie?

2016-11-22 Thread timeless
Augie Fackler wrote: > We said we'd delete this after 3.8. It's time. > -ui.deprecwarn("missing attribute '%s', use @command decorator " > - "to register '%s'" % (attr, cmd), '3.8') It feels like we should be able to have a test which complains if we have deprecwarns f

Re: [PATCH 01 of 10 layering] dirstateguard: move to new module so I can break some layering violations

2016-11-23 Thread timeless
Yuya Nishihara wrote: > Is copy-and-remove a preferred way for this kind of refactoring? I have > an unsent patch that splits revset.py, so I want to know which is better. Augie Fackler wrote: > I'd prefer it slightly, because it makes the blame history a little bit more > intact in the long run.

Re: [PATCH evolve-ext] evolve: improve error message if unstable changes are disallowed

2016-11-23 Thread timeless
Mateusz Kwapich wrote: > Pulkit wrote: >> +raise error.Abort(_("cannot prune in the middle of a stack\n"\ >> +"new unstable changesets are not allowed")) > This error doesn't have hint - maybe we could use it for that purpose. I should spend some time wo

Re: [PATCH 6 of 8] crecord: rewrite status line text (BC)

2016-11-23 Thread timeless
Jun Wu wrote: > Select hunks to apply. [x]=selected **=collapsed c: confirm q: abort That's pretty good, but could we use a pipe* before ` [x]`? Possibly omitting the `.`, either as: Select hunks to apply | [x]=selected **=collapsed c: confirm q: abort or Select hunks to apply. | [x]=selec

Re: [PATCH 7 of 8] crecord: change help text for the space key dynamically

2016-11-23 Thread timeless
Jun Wu wrote: > +_('space: unselect') if selected else _('space: select'), I favor deselect (13million) over unselect (2.5million) -- numbers from Google. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercuria

Re: [PATCH 1 of 2] dispatch: move part of callcatch to scmutil

2016-11-23 Thread timeless
fwiw, it is possible to keep blame for this if you really wanted to. The approach is: 7ef2ebf5cdf91192a66b461ff56f653a65e65dd7->x x: copy scmutil.py -> scmutil_.py 7ef2ebf5cdf91192a66b461ff56f653a65e65dd7->y y: copy dispatch.py-> scmutil_.py delete lines from scmutil_.py x+y->z z: resolve mer

Re: [PATCH V2] evolve: improve error message if unstable changes are disallowed

2016-12-11 Thread timeless
I'm not going to stop this from going in, it's definitely an improvement. >> @@ -3299,7 +3301,8 @@ >> head = repo[heads.first()] >> if _disallowednewunstable(repo, revs): >> raise error.Abort(_("cannot fold chain not ending with a head "\ >> -"or with

Re: [PATCH 1 of 5] posix: move checkexec test file to .hg/cache

2016-12-11 Thread timeless
Gregory Szorc wrote: > The only scenario I can think of is someone who has moved .hg to another > filesystem and symlinked .hg in the working directory to it. I guess that's > plausible. Ugh. I can picture doing this. It's possible I've already done it... __

Re: [PATCH 02 of 10 shelve-ext] shelve: add an ability to write json to a new type of shelve files

2016-12-11 Thread timeless
We should probably have check-code complain about it and explain why we don't want it. Self-documenting code is our friend. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 1 of 2] error: add ProgrammingError

2016-12-11 Thread timeless
Jun Wu wrote: > +class ProgrammingError(RuntimeError): > +"""Raised if a developer has made some mistake""" I object to "developer" you probably mean "mercurial (core or extension) developer", not "generic developer". ___ Mercurial-devel mailing lis

Re: [PATCH] error: make it clear that ProgrammingError is for mercurial developers

2016-12-17 Thread timeless
Thanks ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 2 of 3] chg: start server at a unique address

2016-12-18 Thread timeless
Jun Wu wrote: > Pid namespace breaks mercurial lock, which is a symlink with the content > "host:pid". Would adjusting the format to: host:pid:starttime:boottime fix this? Sadly, it seems like process start time is actually stored as jiffies since system boot on Linux, and NTP can make canonicali

Re: [PATCH] rebase: fail-fast pull if working dir is not clean

2017-01-02 Thread timeless
Thanks for this. I've been meaning to do it... ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 5 of 5] test-obsolete: stabilize output on platforms without 'serve' support

2017-01-08 Thread timeless
I like this series (I've been thinking about doing things like it for a while) ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH V3] rebase: fail-fast the pull if working dir is not clean (BC)

2017-01-08 Thread timeless
Gregory Szorc wrote: > Your reasoning about users wanting extra context to help them debug is sound. > But I'm surprised nobody mentioned that the "error.Abort" exception takes an > optional keyword "hint" argument that prints an extra message to provide that > context. > When we know why an abort

Re: [PATCH] util: add length argument to util.buffer()

2017-01-23 Thread timeless
Yuya Nishihara wrote: > On Sun, 15 Jan 2017 17:04:24 +0530, Pulkit Goyal wrote: >> # HG changeset patch >> # User Pulkit Goyal <7895pul...@gmail.com> >> # Date 1484404515 -19800 >> # Sat Jan 14 20:05:15 2017 +0530 >> # Node ID 087be8a1c7a0452beee36ca23d7978d107b72315 >> # Parent 9dc4d056d85a0

[PATCH] help: replace patterns with matching

2017-01-23 Thread timeless
# HG changeset patch # User timeless # Date 1485239979 0 # Tue Jan 24 06:39:39 2017 + # Branch stable # Node ID efe7a979f88411014449f28cc3cc873187d2e0f8 # Parent 7bfe02b57695900ef996989286c1fdc2a13aec82 # Available At https://bitbucket.org/timeless/mercurial-crew # hg pull

Re: [PATCH 4 of 5] ui: log time spent blocked on the user

2017-01-24 Thread timeless
Simon Farnsworth wrote: > elpased time) to our standard performance tooling. please fix the spelling error when you resend ;-) ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-dev

Re: [PATCH 08 of 11 V4] sslutil: config option to specify TLS protocol version

2016-08-09 Thread timeless
I'm not a huge fan of this abort: +# Allow minimum TLS protocol to be specified in the config. +def validateprotocol(protocol, key): +if protocol not in configprotocols: +raise error.Abort( +_('unsupported protocol from hostsecurity.%s: %s') % +

Re: [PATCH 11 of 11 V4] sslutil: print a warning when using TLS 1.0 on legacy Python

2016-08-09 Thread timeless
On Fri, Jul 15, 2016 at 12:09 AM, Gregory Szorc wrote: > > + warning: connecting to localhost using legacy security technology (TLS > 1.0); see https://mercurial-scm.org/wiki/SecureConnections for more info (?) >(using CA certificates from *; if you see this message, your Mercurial > instal

Re: [PATCH 1 of 3] tests: remove bundle2 activation from test-tags.t

2016-08-09 Thread timeless
Pierre-Yves David wrote: > > This is an old config that predate bundle2 on by default. This should have > been > remove after Mercurail 3.6 got released. fwiw, `removed` and `Mercurial` :o ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.o

  1   2   >