D229: phabricator: update diff property even if we choose not to create a new diff

yuja added inline comments. INLINE COMMENTS > phabricator.py:280 > diff = creatediff(ctx) > writediffproperties(ctx, diff) > transactions.append({'type': 'update', 'value': diff[r'phid']}) `writediffproperties()` is called twice. Perhaps one of them should be deleted.

D229: phabricator: update diff property even if we choose not to create a new diff

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf100354cce52: phabricator: update diff property even if we choose not to create a new diff (authored by quark). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D229: phabricator: update diff property even if we choose not to create a new diff

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The diff property contains metadata like "HG Node". Previously we skip uploading a new diff if we are sure that the old patch and new patch have a same content.