D2394: histedit: make histedit's commands accept revsets (issue5746)

yuja added inline comments. INLINE COMMENTS > histedit.py:437 > +rulehash = _ctx.hex() > +rev = node.bin(rulehash) > +except error.RepoLookupError: This could be `rev = scmutil.revsingle(...).node()`. > histedit.py:438 > +rev =

D2394: histedit: make histedit's commands accept revsets (issue5746)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3d3cff1f6bde: histedit: make histedits commands accept revsets (issue5746) (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2394: histedit: make histedit's commands accept revsets (issue5746)

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. queued, many thanks REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: pulkit, tom.prince, krbullock,

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. @pulkit It is not failing as of now. It's failing on the changes proposed by @durin42, which he assumed wont fail, but that's not the case! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers

D2394: histedit: make histedit's commands accept revsets (issue5746)

pulkit added a comment. In https://phab.mercurial-scm.org/D2394#44294, @sangeet259 wrote: > @durin42 Should I make any changes? Yep, you should try fixing the failures you mentioned. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To:

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. @durin42 Should I make any changes? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: tom.prince, krbullock, rishabhmadan96, mercurial-devel

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. @durin42 Here is the output! https://bpaste.net/show/7ccf4a9fea50 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: tom.prince, krbullock, rishabhmadan96, mercurial-devel

D2394: histedit: make histedit's commands accept revsets (issue5746)

durin42 added a comment. In https://phab.mercurial-scm.org/D2394#43612, @sangeet259 wrote: > @durin42 Even I thought of this construct before as it appears more elegant. But it is failing some tests! > Specifically, the error messages are changed in this one. > > Failed

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. @durin42 Even I thought of this construct before as it appears more elegant. But it is failing some tests! Specifically, the error messages are changed in this one. Failed test-histedit-arguments.t: output changed Failed test-histedit-edit.t: output

D2394: histedit: make histedit's commands accept revsets (issue5746)

durin42 added a comment. Nice! I've got one suggested edit to the code that should still pass tests. INLINE COMMENTS > histedit.py:428-432 > try: > -rev = node.bin(rulehash) > +rev = node.bin(ruleid) > except TypeError: > -raise

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. added the tests @krbullock REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: tom.prince, krbullock, rishabhmadan96, mercurial-devel ___

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 updated this revision to Diff 6324. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2394?vs=6008=6324 REVISION DETAIL https://phab.mercurial-scm.org/D2394 AFFECTED FILES hgext/histedit.py tests/test-histedit-arguments.t CHANGE DETAILS

D2394: histedit: make histedit's commands accept revsets (issue5746)

krbullock added a comment. Oh sorry, I see you're already on the case. Carry on! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: krbullock, rishabhmadan96, mercurial-devel

D2394: histedit: make histedit's commands accept revsets (issue5746)

krbullock added a comment. Can we get some test coverage on this? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: krbullock, rishabhmadan96, mercurial-devel ___

D2394: histedit: make histedit's commands accept revsets (issue5746)

rishabhmadan96 added a comment. It'd be better if you could update the commit message with the necessary details that you mentioned in your previous comment. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc:

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. Oh, I forgot adding tests as @durin42 told. Doing that right away! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: mercurial-devel ___

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. **What I did**: @durin42 suggested in the issue page that the error was in the `verify` function of the `histedit.py` file. But when I ran through debugger using a revision number, the code was throwing the

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 updated this revision to Diff 6008. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2394?vs=6007=6008 REVISION DETAIL https://phab.mercurial-scm.org/D2394 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git a/hgext/histedit.py

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git