martinvonz added inline comments.
INLINE COMMENTS
> yuja wrote in cmdutil.py:2307
> Perhaps these two shouldn't pass `ui` nor `repo`. They evaluate
> internal query.
>
> Passing `repo` means to take any valid old-style revisions
> ignoring the revset syntax.
Thanks, Yuja. This was fixed in
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2858f7d10344: revset: pass repo when passing ui (authored
by indygreg).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D97?vs=181=275
REVISION DETAIL
yuja added inline comments.
INLINE COMMENTS
> cmdutil.py:2307
> +matcher = revset.match(repo.ui, expr, repo=repo,
> + order=revset.followorder)
> revs = matcher(repo, revs)
Perhaps these two shouldn't pass `ui` nor `repo`. They evaluate
internal
durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.
Taking this one, but going to punt on https://phab.mercurial-scm.org/D98 per
the "consider this an RFC" comment I saw.
REPOSITORY
rHG Mercurial
REVISION DETAIL
