Re: [Mesa-dev] [PATCH] st/egl: Fix build after changes in src/egl/wayland/

2013-03-23 Thread Scott Moreau
Hi all, I am having some pretty bad crashes and graphical corruption due to these series. The commit messages say tested-by but they weren't even compile-tested apparently. Here's what I have https://bugs.freedesktop.org/show_bug.cgi?id=62663 I have no idea what's going on but it seems nasty. -

[Mesa-dev] [PATCH] i965/gen7: Use WE_all mode when enabling channel masks for URB write.

2013-03-23 Thread Paul Berry
Gen7 adds mask bits to the message header for a URB write which allow the write to apply only to certain channels. We don't use this functionality, so to ensure that the entire write always occurs, we emit an OR instruction to set the mask bits. With the advent of geometry shaders, URB writes

Re: [Mesa-dev] [PATCH] i965/gen7: Use WE_all mode when enabling channel masks for URB write.

2013-03-23 Thread Kenneth Graunke
On 03/23/2013 09:17 AM, Paul Berry wrote: Gen7 adds mask bits to the message header for a URB write which allow the write to apply only to certain channels. We don't use this functionality, so to ensure that the entire write always occurs, we emit an OR instruction to set the mask bits. With

[Mesa-dev] [PATCH] libclc: implement rotate builtin

2013-03-23 Thread Aaron Watry
This implementation does a lot of bit shifting and masking. Suffice to say, this is somewhat suboptimal... but it does look to produce correct results (after the piglit tests were corrected for sign extension issues). Someone who knows LLVM better than I could re-write this more efficiently. ---

Re: [Mesa-dev] [PATCH v2 3/5] i965: Use brw.vue_map_geom_out instead of VS output VUE map where appropriate.

2013-03-23 Thread Kenneth Graunke
On 03/21/2013 05:40 PM, Paul Berry wrote: This patch modifies post-GS pipeline stages (transform feedback, clip, sf, fs) to refer to the VUE map through brw-vue_map_geom_out rather than brw-vs.prog_data-vue_map. This ensures that when geometry shader support is added, these pipeline stages will

Re: [Mesa-dev] [PATCH v2 5/5] i965: Shrink brw_vue_map struct.

2013-03-23 Thread Kenneth Graunke
On 03/22/2013 05:42 PM, Eric Anholt wrote: Paul Berry stereotype...@gmail.com writes: On 22 March 2013 12:32, Eric Anholt e...@anholt.net wrote: Paul Berry stereotype...@gmail.com writes: diff --git a/src/mesa/drivers/dri/i965/brw_vs.c b/src/mesa/drivers/dri/i965/brw_vs.c index

Re: [Mesa-dev] [PATCH v2 1/5] i965: Move brw_vs_prog_data::outputs_written into VUE map.

2013-03-23 Thread Kenneth Graunke
On 03/21/2013 05:40 PM, Paul Berry wrote: Future patches will allow for there to be separate VUE maps when both a geometry shader and a vertex shader are in use. When this happens, we will want to have correspondingly separate outputs_written bitfields. Moving outputs_written into the VUE map

Re: [Mesa-dev] [PATCH] i965/fs: Improve performance of copy propagation dataflow using bitsets.

2013-03-23 Thread Kenneth Graunke
On 03/22/2013 02:49 PM, Eric Anholt wrote: Reduces compile time of l4d2's slowest shader by 17.8% +/- 1.3% (n=10). --- .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 67 ++-- 1 file changed, 34 insertions(+), 33 deletions(-) I could've sworn I reviewed this patch

Re: [Mesa-dev] [PATCH] i965: Clarify nomenclature: vert_result - varying

2013-03-23 Thread Kenneth Graunke
On 03/22/2013 10:23 AM, Paul Berry wrote: This patch removes the terminology vert_result from the i965 driver, replacing it with varying. The old terminology, vert_result, was confusing because (a) it referred to the enum gl_vert_result, which no longer exists (it was replaced with

Re: [Mesa-dev] [PATCH] mesa: Disable validate_ir_tree() on release builds.

2013-03-23 Thread Kenneth Graunke
On 03/18/2013 08:48 AM, Eric Anholt wrote: Since half of ir_validate uses asserts() (the other using printf() then abort()), there's not much use to calling it in a release build. Cuts 6.3% of the startup time of TF2. NOTE: This is a candidate for the stable branches. ---

[Mesa-dev] [PATCH] llvmpipe: Fix assertions with assignment instead of comparison.

2013-03-23 Thread Vinson Lee
Fixes assign instead of compare defects reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/drivers/llvmpipe/lp_state_fs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c

[Mesa-dev] [PATCH] clover: add dynamic_cast results checking down in clSetKernelArgument() code path.

2013-03-23 Thread Dmitry Cherkassov
Signed-off-by: Dmitry Cherkassov dcherkas...@gmail.com --- src/gallium/state_trackers/clover/core/kernel.cpp | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp index

Re: [Mesa-dev] [PATCH v2 13/15] glsl linker: support arrays of interface block instances

2013-03-23 Thread Kenneth Graunke
On 03/19/2013 03:57 AM, Pohjolainen, Topi wrote: On Mon, Mar 18, 2013 at 04:35:10PM -0700, Jordan Justen wrote: With this change we now support interface block arrays. For example, cases like this: out block_name { float f; } block_instance[2]; This allows Mesa to pass the piglit

Re: [Mesa-dev] [PATCH v2 03/15] glsl: parse in/out types for interface blocks

2013-03-23 Thread Kenneth Graunke
On 03/20/2013 05:19 PM, Eric Anholt wrote: Jordan Justen jordan.l.jus...@intel.com writes: Previously only 'uniform' was allowed for uniform blocks. Now, in/out can be parsed, but it will only be allowed for GLSL = 150. basic_interface_block: - UNIFORM NEW_IDENTIFIER '{'

Re: [Mesa-dev] [PATCH v2 04/15] glsl parser: reject VS+in FS+out interface blocks

2013-03-23 Thread Kenneth Graunke
On 03/18/2013 04:35 PM, Jordan Justen wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/glsl/glsl_parser.yy | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 7adc06d..8e6b04d 100644 ---

Re: [Mesa-dev] Status of GL_ARB_separate_shader_objects? I would like to help.

2013-03-23 Thread gregory hainaut
On Fri, 22 Mar 2013 15:44:07 -0700 Matt Turner matts...@gmail.com wrote: On Fri, Mar 22, 2013 at 1:00 PM, gregory hainaut gregory.hain...@gmail.com wrote: * GenProgramPipelines doesn't create object! ... Spec extract: These names are marked as used, for the purposes of GenBuffers only,

Re: [Mesa-dev] [PATCH v2 05/15] glsl parser: on desktop GL require GLSL 150 for instance names

2013-03-23 Thread Kenneth Graunke
On 03/18/2013 04:35 PM, Jordan Justen wrote: Interface blocks in GLSL 150 allow an instance name to be used. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/glsl/glsl_parser.yy | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2 06/15] glsl parser: allow in out for interface block members

2013-03-23 Thread Kenneth Graunke
On 03/22/2013 08:48 PM, Jordan Justen wrote: On Wed, Mar 20, 2013 at 5:32 PM, Eric Anholt e...@anholt.net wrote: Jordan Justen jordan.l.jus...@intel.com writes: Previously uniform blocks allowed for the 'uniform' keyword to be used with members of a uniform blocks. With interface blocks 'in'

Re: [Mesa-dev] [PATCH v2 00/15] GLSL 1.50 interface blocks support

2013-03-23 Thread Kenneth Graunke
On 03/18/2013 04:34 PM, Jordan Justen wrote: git://people.freedesktop.org/~jljusten/mesa interface-blocks-v2 v2: * 3 new patches added to series * Add support for interface block instance arrays * Add support for rejecting unmatched interface blocks during the linking phase. * Known

Re: [Mesa-dev] [PATCH v2 5/5] i965: Shrink brw_vue_map struct.

2013-03-23 Thread Paul Berry
On 23 March 2013 11:02, Kenneth Graunke kenn...@whitecape.org wrote: On 03/22/2013 05:42 PM, Eric Anholt wrote: Paul Berry stereotype...@gmail.com writes: On 22 March 2013 12:32, Eric Anholt e...@anholt.net wrote: Paul Berry stereotype...@gmail.com writes: diff --git

[Mesa-dev] [PATCH] gallivm: move code for dealing with rgb9e5 and r11g11b10 formats to own file

2013-03-23 Thread sroland
From: Roland Scheidegger srol...@vmware.com This is really not generic conversion stuff and the code very particular to these formats. --- src/gallium/auxiliary/Makefile.sources |1 + src/gallium/auxiliary/gallivm/lp_bld_conv.c| 329 -

[Mesa-dev] [PATCH V2 0/3] Sample count limit tidy-up

2013-03-23 Thread Chris Forbes
This series tidies up the missing interactions between unextended GL3, ARB_texture_multisample and ARB_internalformat_query. No serious functional changes from V1, just a lot of shuffling things around. -- Chris ___ mesa-dev mailing list

[Mesa-dev] [PATCH V2 1/3] mesa: allow internalformat_query with multisample texture targets

2013-03-23 Thread Chris Forbes
Now that we support ARB_texture_multisample, there are multiple targets accepted for this query, and they may have target-dependent limits, so pass the target to the driverfunc. For example, the sampling hardware may not be able to do general texelFetch() for some format/sample count combination,

[Mesa-dev] [PATCH V2 2/3] mesa: helper for checking renderbuffer sample count

2013-03-23 Thread Chris Forbes
Pulls the checking of the sample count into a helper function, and extends the existing logic to include the interactions with both ARB_texture_multisample and ARB_internalformat_query. _mesa_check_sample_count() checks a desired sample count against a a combination of target/internalformat, and

[Mesa-dev] [PATCH V2 3/3] mesa: use _mesa_check_sample_count() for multisample textures

2013-03-23 Thread Chris Forbes
Extends _mesa_check_sample_count() to properly support the TEXTURE_2D_MULTISAMPLE and TEXTURE_2D_MULTISAMPLE_ARRAY targets, which have subtly different limits than renderbuffers. This resolves the remaining TODO in the implementation of TexImage*DMultisample. V2: - Don't introduce spurious

Re: [Mesa-dev] [PATCH] clover: add dynamic_cast results checking down in clSetKernelArgument() code path.

2013-03-23 Thread Francisco Jerez
Dmitry Cherkassov dcherkas...@gmail.com writes: Signed-off-by: Dmitry Cherkassov dcherkas...@gmail.com Thanks, pushed. --- src/gallium/state_trackers/clover/core/kernel.cpp | 16 1 file changed, 16 insertions(+) diff --git

Re: [Mesa-dev] [PATCH V2 0/3] Sample count limit tidy-up

2013-03-23 Thread Kenneth Graunke
On 03/23/2013 06:50 PM, Chris Forbes wrote: This series tidies up the missing interactions between unextended GL3, ARB_texture_multisample and ARB_internalformat_query. No serious functional changes from V1, just a lot of shuffling things around. -- Chris I believe this will allow 1 samples

Re: [Mesa-dev] [PATCH] libclc: implement rotate builtin

2013-03-23 Thread Tom Stellard
On Sat, Mar 23, 2013 at 12:37:38PM -0500, Aaron Watry wrote: This implementation does a lot of bit shifting and masking. Suffice to say, this is somewhat suboptimal... but it does look to produce correct results (after the piglit tests were corrected for sign extension issues). Someone who