Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-14 Thread Abdiel Janulgue
On Friday, October 11, 2013 11:39:53 AM Eric Anholt wrote: As I understand it, the thing that you think will make this eventually actually improve performance is state flagging that indicates which individual surfaces need updating. Since that should improve performance even in the

[Mesa-dev] [PATCH V2 0/7] ARB_gpu_shader5 textureGather*, Part 2

2013-10-14 Thread Chris Forbes
This series adds new textureGatherOffset overloads, and support for nonconstant offsets. V2: - Update for general churn + send-from-grf - Reinstate assert on nonconstant offset if ARB_gpu_shader5 not supported. This ought not to actually get hit as the GLSL frontend insists on a

[Mesa-dev] [PATCH V2 1/7] glsl: Add ARB_gpu_shader5 textureGatherOffset signatures

2013-10-14 Thread Chris Forbes
- gsampler2DRect - optional `comp` parameter Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/builtin_functions.cpp | 16 1 file changed, 16 insertions(+) diff --git a/src/glsl/builtin_functions.cpp

[Mesa-dev] [PATCH V2 2/7] glsl: relax const offset requirement for textureGatherOffset

2013-10-14 Thread Chris Forbes
Prior to ARB_gpu_shader5 / GLSL 4.0, the offset is required to be a constant expression. With that extension, it is relaxed to be an arbitrary expression. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/builtin_functions.cpp | 61

[Mesa-dev] [PATCH V2 3/7] i965: add missing tg4 case in brw_instruction_name

2013-10-14 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_shader.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index

[Mesa-dev] [PATCH V2 4/7] i965: Add SHADER_OPCODE_TG4_OFFSET for gather with nonconstant offsets.

2013-10-14 Thread Chris Forbes
The generator code ends up clearer this way than if we had to sniff via the message length. Implemented via the gather4_po message in hardware, which is present in Gen7 and later. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com ---

[Mesa-dev] [PATCH V2 5/7] i965: relax brw_texture_offset assert

2013-10-14 Thread Chris Forbes
Some texturing ops are about to have nonconstant offset support; the offset in the header in these cases should be zero. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +-

[Mesa-dev] [PATCH V2 6/7] i965/fs: add support for gather4 with nonconstant offsets

2013-10-14 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 46 +--- 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index

[Mesa-dev] [PATCH V2 7/7] i965/vs: add support for gather4 with nonconstant offsets

2013-10-14 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index

[Mesa-dev] [PATCH V2 0/5] ARB_gpu_shader5 textureGather*, Part 3

2013-10-14 Thread Chris Forbes
Adds infrastructure for separate reference Z in texturing functions, and support for shadow comparitors with textureGather*. V2: - General churn, send-from-grf rebase, etc - Make it actually work (Thanks Eric for pointing out that it didnt) ___

[Mesa-dev] [PATCH V2 1/5] glsl: Add support for separate reference Z for shadow samplers

2013-10-14 Thread Chris Forbes
ARB_gpu_shader5's textureGather*() functions which take shadow samplers have a separate `refz` parameter rather than adding it to the coordinate. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Eric Anholt e...@anholt.net Reviewed-by: Kenneth Graunke kenn...@whitecape.org ---

[Mesa-dev] [PATCH V2 2/5] glsl: Add new textureGather[Offset]() overloads for shadow samplers

2013-10-14 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Eric Anholt e...@anholt.net Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/builtin_functions.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/glsl/builtin_functions.cpp

[Mesa-dev] [PATCH V2 3/5] i965: Add Gen7 gather4_c and gather4_po_c message types

2013-10-14 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Eric Anholt e...@anholt.net Reviewed-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_defines.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h

[Mesa-dev] [PATCH V2 4/5] i965/vs: Add support for shadow comparitors with gather4

2013-10-14 Thread Chris Forbes
gather4_c's argument layout is straightforward -- refz just goes on the end. gather4_po_c's layout however -- the array index is replaced with refz. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 12 ++--

[Mesa-dev] [PATCH V2 5/5] i965/fs: Add support for shadow comparitors with gather4

2013-10-14 Thread Chris Forbes
Note that gather4_po_c's parameters are too long for SIMD16. It might be worth emitting 2xSIMD8 messages in this case at some point. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 15 --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp

[Mesa-dev] [PATCH V2 0/4] ARB_gpu_shader5 textureGather*, Part 4

2013-10-14 Thread Chris Forbes
Adds support for textureGatherOffsets() [which takes an array of texel offsets]. This isn't directly supported on i965, so we lower it to 4x textureGatherOffset(). V2: - Rebase, etc. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH V2 1/4] glsl: add support for texture functions with offset arrays

2013-10-14 Thread Chris Forbes
This is needed for textureGatherOffsets() Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/builtin_functions.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index deedddb..1b23677 100644 ---

[Mesa-dev] [PATCH V2 2/4] glsl: add signatures for textureGatherOffsets()

2013-10-14 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/builtin_functions.cpp | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 1b23677..45fff4c 100644 --- a/src/glsl/builtin_functions.cpp

[Mesa-dev] [PATCH V2 3/4] i965: Add asserts to ensure that ir_tg4 offset arrays are lowered

2013-10-14 Thread Chris Forbes
We don't have a message that does 4 independent offsets; a lowering pass needs to lower it to 4 normal gather4s before reaching this point. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 +++ src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 3

[Mesa-dev] [PATCH V2 0/3] ARB_gpu_shader5 textureGather*, Part 5

2013-10-14 Thread Chris Forbes
This is the fifth (and final) piece of ARB_gpu_shader5 textureGather* support. It turns out that unnormalized texcoords and texture offsets don't mix. This series adds yet another lowering pass, so that *sampler2DRect work with gather. 2-3/3 expand the lowering pass to cover integer coordinates

[Mesa-dev] [PATCH V2 1/3] i965: Add lowering pass to fold offset into unnormalized coords

2013-10-14 Thread Chris Forbes
It turns out that nonzero offsets with gsampler2DRect don't work -- they just return garbage. Work around this by folding the offset into the coord. Done as an IR pass rather than yet another hack in the visitors because it's clear what's going on this way. Can possibly reuse this to replace the

[Mesa-dev] [PATCH V2 2/3] i965: Generalize coord+offset lowering pass for ir_txf

2013-10-14 Thread Chris Forbes
ir_txf expects an ivec* coordinate, and may be larger than ivec2; shuffle things around so that this will work. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- .../dri/i965/brw_lower_unnormalized_offset.cpp | 51 ++ 1 file changed, 42 insertions(+), 9 deletions(-) diff

[Mesa-dev] [PATCH V2 3/3] i965: Remove ir_txf coord+offset special case in visitors

2013-10-14 Thread Chris Forbes
Just let it be handled by the lowering pass. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 56 ++ src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 25 ++-- 2 files changed, 16 insertions(+), 65 deletions(-) diff

[Mesa-dev] [Bug 70123] Freeze caused by 'winsys/radeon: remove cs_queue_empty' commit

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70123 --- Comment #10 from Jeff Blake jeffbla...@gmail.com --- Created attachment 87588 -- https://bugs.freedesktop.org/attachment.cgi?id=87588action=edit thread apply all bt With that patch things are still freezing up, see the attachment for the

[Mesa-dev] [Bug 70123] Freeze caused by 'winsys/radeon: remove cs_queue_empty' commit

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70123 --- Comment #11 from Christian König deathsim...@vodafone.de --- (In reply to comment #10) The command which causes the freeze is :- compton -b --backend glx --config /dev/null Thanks for this, I can reproduce the problem now. Not sure if

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 --- Comment #10 from Kai k...@dev.carbon-project.org --- (In reply to comment #7) Created attachment 87497 [details] [review] swrast: add correct include for out-of-tree builds A slightly more overzealous version, explicitly including the

[Mesa-dev] texelFetch*Offset from EXT_gpu_shader4

2013-10-14 Thread Mike Lothian
Hi I'm going to try adding in support for texelFetch*Offset to try and get anti aliasing working in the Unigine demos I'm not sure if anything more will be required but I just wanted to check no one else is working on this Thanks Mike ___ mesa-dev

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-14 Thread Chad Versace
On 10/13/2013 08:33 PM, Ian Romanick wrote: On 10/13/2013 01:50 PM, Frank Henigman wrote: On Fri, Oct 11, 2013 at 10:00 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 10/11/2013 10:17 AM, Courtney Goeltzenleuchter wrote: Support all levels of a supported texture format. ---

[Mesa-dev] [Bug 70435] [regression] Fast Texture Upload optimization results in corrupt rendering.

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70435 U. Artie Eoff ullysses.a.e...@intel.com changed: What|Removed |Added Summary|glTexSubImage corrupted |[regression]

[Mesa-dev] [Bug 70411] glInvalidateFramebuffer fails with GL_INVALID_ENUM

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70411 Brian Paul bri...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] swrast: add correct include for out-of-tree builds

2013-10-14 Thread Brian Paul
On 10/12/2013 10:29 AM, Emil Velikov wrote: The xmlpool/options.h file was not accessible when building out-of-tree leading to failure. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70378 Reported-by: Fabio Pedretti fabio@libero.it Tested-by: Andre Heider a.hei...@gmail.com

Re: [Mesa-dev] [PATCH] llvmpipe: increase fs shader variant instruction cache limit by factor 4

2013-10-14 Thread Jose Fonseca
- Original Message - Am 11.10.2013 16:21, schrieb Brian Paul: On 10/11/2013 07:11 AM, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com The previous limit of of 128*1024 was reported to cause frequent recompiles in some apps due to shader variant

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-14 Thread Courtney Goeltzenleuchter
Does anyone know of a test that measures frame 0 time? Or texture upload speed? For Smokin' Guns, I tried measuring the overall time, but an improved frame 0 time has difficulty standing out of a 2607 frame test. I may have to create something. Suggestions for an appropriate framework? Thanks,

Re: [Mesa-dev] texelFetch*Offset from EXT_gpu_shader4

2013-10-14 Thread Ian Romanick
On 10/14/2013 06:40 AM, Mike Lothian wrote: Hi I'm going to try adding in support for texelFetch*Offset to try and get anti aliasing working in the Unigine demos texelFetchOffset is already supported by GLSL 1.30. There's a lot more to EXT_gpu_shader4 than just these built in functions.

[Mesa-dev] [PATCH] swrast: add correct include for out-of-tree builds

2013-10-14 Thread Emil Velikov
The xmlpool/options.h file was not accessible when building out-of-tree leading to failure. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70378 Reported-by: Fabio Pedretti fabio@libero.it Tested-by: Fabio Pedretti fabio@libero.it Tested-by: Andre Heider a.hei...@gmail.com

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-14 Thread Abdiel Janulgue
On Friday, October 11, 2013 11:39:53 AM Eric Anholt wrote: As a general rule, we don't land code whose purpose is performance improvement if it doesn't actually improve performance. If more work is needed to make it actually improve performance, then we wait until then. As I understand it,

[Mesa-dev] [PATCH] mesa: consolidate cube width=height error checking

2013-10-14 Thread Brian Paul
Instead of checking width==height in four places, just do it in _mesa_legal_texture_dimensions() where we do the other width, height, depth checks. Similarly, move the check that cube map array depth is a multiple of 6. This change also fixes some missing cube dimension checks for the

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-14 Thread Mark Mueller
Hi Courtney, I've been doing similar work but using Xenotic as the benchmark. Here is how I've been estimating upload times: First I made a rough determination of a texture count, like 300, as a metric. In intelTexImage I use clock_gettime to determine the elapsed time between the loading of

[Mesa-dev] [PATCH 0/8] Implement GL_ARB_sample_shading on Intel hardware

2013-10-14 Thread Anuj Phogat
Patches listed below implement the GL_ARB_sample_shading extension on Intel hardware = gen6. I verified the implementation with a number of piglit tests, currently under review on piglit mailing list. Observed no piglit, gles3 CTS regressions with these patches on SNB IVB. These patches can also

[Mesa-dev] [PATCH 1/8] mesa: Add infrastructure for GL_ARB_sample_shading

2013-10-14 Thread Anuj Phogat
This patch implements the common support code required for the GL_ARB_sample_shading extension. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++

[Mesa-dev] [PATCH 3/8] mesa: Pass number of samples as a program state variable

2013-10-14 Thread Anuj Phogat
Number of samples will be required in fragment shader program by new GLSL builtin uniform gl_NumSamples. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/program/prog_statevars.c | 11 +++ src/mesa/program/prog_statevars.h | 2 ++ 2 files changed, 13 insertions(+) diff

[Mesa-dev] [PATCH 2/8] mesa: Add new functions and enums required by GL_ARB_sample_shading

2013-10-14 Thread Anuj Phogat
New functions added by GL_ARB_sample_shading: glMinSampleShadingARB() New enums: GL_SAMPLE_SHADING_ARB GL_MIN_SAMPLE_SHADING_VALUE_ARB Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mapi/glapi/gen/ARB_sample_shading.xml | 19 +++ src/mapi/glapi/gen/GL3x.xml

[Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-14 Thread Anuj Phogat
New builtins added by GL_ARB_sample_shading: in vec2 gl_SamplePosition in int gl_SampleID in int gl_NumSamples out int gl_SampleMask[] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/glsl/builtin_variables.cpp | 11 +++ src/glsl/link_varyings.cpp | 2 ++

[Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-14 Thread Anuj Phogat
Implement the FS backend for new builtins added by the extension: in vec2 gl_SamplePosition in int gl_SampleID in int gl_NumSamples out int gl_SampleMask[] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/brw_fs.cpp | 109 +++

[Mesa-dev] [PATCH 6/8] i965/gen6: Enable the features required for GL_ARB_sample_shading

2013-10-14 Thread Anuj Phogat
- Enable GEN6_WM_MSDISPMODE_PERSAMPLE, GEN6_WM_POSOFFSET_SAMPLE, GEN6_WM_OMASK_TO_RENDER_TARGET as per extension's specification. - Don't enable GEN6_WM_16_DISPATCH_ENABLE when GEN6_WM_MSDISPMODE_PERSAMPLE is enabled. Refer SNB PRM Vol. 2, Part 1, Page 279 for details. Signed-off-by: Anuj

[Mesa-dev] [PATCH 7/8] i965/gen7: Enable the features required for GL_ARB_sample_shading

2013-10-14 Thread Anuj Phogat
- Enable GEN7_WM_MSDISPMODE_PERSAMPLE, GEN7_WM_POSOFFSET_SAMPLE, GEN7_WM_OMASK_TO_RENDER_TARGET as per extension's specification. - Don't enable GEN7_WM_16_DISPATCH_ENABLE when GEN7_WM_MSDISPMODE_PERSAMPLE is enabled. Refer IVB PRM Vol. 2, Part 1, Page 288 for details. Signed-off-by: Anuj

[Mesa-dev] [PATCH 8/8] i965: Enable ARB_sample_shading on intel hardware = gen6

2013-10-14 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 6f024b4..0d71617 100644 ---

[Mesa-dev] Easy learning project for someone looking to get into Mesa development

2013-10-14 Thread Ian Romanick
Here's a project for anyone looking to get into Mesa development that should be easy for anyone with decent C programming skills to tackle: GL_ARB_texture_mirror_clamp_to_edge. http://www.opengl.org/registry/specs/ARB/texture_mirror_clamp_to_edge.txt This extension is effectively a subset of

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Fix type of header register for sampler messages

2013-10-14 Thread Eric Anholt
Chris Forbes chr...@ijw.co.nz writes: Previously this was float, which caused the copy from g0 to mangle everything. If we face a choice of types for a raw mov, we should choose float -- it's higher performance on IVB (they can get dispatched twice as fast, when there's a hyperthread waiting

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-14 Thread Eric Anholt
Abdiel Janulgue abdiel.janul...@linux.intel.com writes: On Friday, October 11, 2013 11:39:53 AM Eric Anholt wrote: As a general rule, we don't land code whose purpose is performance improvement if it doesn't actually improve performance. If more work is needed to make it actually improve

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-14 Thread Eric Anholt
Courtney Goeltzenleuchter court...@lunarg.com writes: Does anyone know of a test that measures frame 0 time? Or texture upload speed? For Smokin' Guns, I tried measuring the overall time, but an improved frame 0 time has difficulty standing out of a 2607 frame test. I may have to create

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-14 Thread Eric Anholt
Courtney Goeltzenleuchter court...@lunarg.com writes: Does anyone know of a test that measures frame 0 time? Or texture upload speed? For Smokin' Guns, I tried measuring the overall time, but an improved frame 0 time has difficulty standing out of a 2607 frame test. I may have to create

Re: [Mesa-dev] [PATCH 1/8] mesa: Add infrastructure for GL_ARB_sample_shading

2013-10-14 Thread Matt Turner
On Mon, Oct 14, 2013 at 10:12 AM, Anuj Phogat anuj.pho...@gmail.com wrote: diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 2507fdf..9e908c0 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -200,6 +200,7 @@ static const struct extension

Re: [Mesa-dev] [PATCH 2/8] mesa: Add new functions and enums required by GL_ARB_sample_shading

2013-10-14 Thread Matt Turner
On Mon, Oct 14, 2013 at 10:12 AM, Anuj Phogat anuj.pho...@gmail.com wrote: diff --git a/src/mapi/glapi/gen/GL3x.xml b/src/mapi/glapi/gen/GL3x.xml index 5078f7b..4ec4749 100644 --- a/src/mapi/glapi/gen/GL3x.xml +++ b/src/mapi/glapi/gen/GL3x.xml @@ -630,6 +630,11 @@ param name=divisor

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Fix type of header register for sampler messages

2013-10-14 Thread Chris Forbes
OK, so this needs to lose the retype() on both sides. On Tue, Oct 15, 2013 at 6:44 AM, Eric Anholt e...@anholt.net wrote: Chris Forbes chr...@ijw.co.nz writes: Previously this was float, which caused the copy from g0 to mangle everything. If we face a choice of types for a raw mov, we

[Mesa-dev] [PATCH] r600g/sb: fix issue with DCE between GVN and GCM (v2)

2013-10-14 Thread Vadim Girlin
We can't perform DCE using the liveness pass between GVN and GCM because it relies on the correct schedule, but GVN doesn't care about preserving correctness - it's rescheduled later by GCM. This patch makes dce_cleanup pass perform simple DCE between GVN and GCM instead of relying on liveness

Re: [Mesa-dev] EXT_image_dma_buf_import FD ownership

2013-10-14 Thread Kristian Høgsberg
On Fri, Oct 11, 2013 at 3:29 PM, John Sheu s...@google.com wrote: Hello folks: About the ownership of dmabuf file descriptors that are passed into EGL. I'm looking in particular at this blurb from the spec: * If target is EGL_LINUX_DMA_BUF_EXT and eglCreateImageKHR fails,

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-14 Thread Chad Versace
On 10/14/2013 10:54 AM, Eric Anholt wrote: Courtney Goeltzenleuchter court...@lunarg.com writes: Does anyone know of a test that measures frame 0 time? Or texture upload speed? For Smokin' Guns, I tried measuring the overall time, but an improved frame 0 time has difficulty standing out of a

[Mesa-dev] [Bug 70435] [regression] Fast Texture Upload optimization results in corrupt rendering.

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70435 Chad Versace chad.vers...@linux.intel.com changed: What|Removed |Added Assignee|i...@freedesktop.org

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-14 Thread Courtney Goeltzenleuchter
On Mon, Oct 14, 2013 at 12:43 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 10/14/2013 10:54 AM, Eric Anholt wrote: Courtney Goeltzenleuchter court...@lunarg.com writes: Does anyone know of a test that measures frame 0 time? Or texture upload speed? For Smokin' Guns, I tried

[Mesa-dev] [Bug 70435] [regression] Fast Texture Upload optimization results in corrupt rendering.

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70435 Chad Versace chad.vers...@linux.intel.com changed: What|Removed |Added Status|NEW |ASSIGNED

[Mesa-dev] [Bug 70435] [regression] Fast Texture Upload optimization results in corrupt rendering.

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70435 Chad Versace chad.vers...@linux.intel.com changed: What|Removed |Added Assignee|i...@freedesktop.org

[Mesa-dev] [Bug 70435] [regression] Fast Texture Upload optimization results in corrupt rendering.

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70435 --- Comment #2 from U. Artie Eoff ullysses.a.e...@intel.com --- Created attachment 87619 -- https://bugs.freedesktop.org/attachment.cgi?id=87619action=edit lspci -vvnn -- You are receiving this mail because: You are on the CC list for the

[Mesa-dev] [Bug 70435] [regression] Fast Texture Upload optimization results in corrupt rendering.

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70435 --- Comment #3 from U. Artie Eoff ullysses.a.e...@intel.com --- (In reply to comment #1) It's no surprise that this patch caused a regression. I wish Piglit had total and complete coverage of everything :( Artie, on which hardware did you

Re: [Mesa-dev] Easy learning project for someone looking to get into Mesa development

2013-10-14 Thread Marek Olšák
I'd just add an alias GL_ARB_texture_mirror_clamp_to_edge - o(ATI_texture_mirror_once), so it would just be a one-liner change to extensions.c. Marek On Mon, Oct 14, 2013 at 7:25 PM, Ian Romanick i...@freedesktop.org wrote: Here's a project for anyone looking to get into Mesa development that

Re: [Mesa-dev] Easy learning project for someone looking to get into Mesa development

2013-10-14 Thread Kenneth Graunke
On 10/14/2013 12:22 PM, Marek Olšák wrote: I'd just add an alias GL_ARB_texture_mirror_clamp_to_edge - o(ATI_texture_mirror_once), so it would just be a one-liner change to extensions.c. Marek They're not the same though - the new ARB extension only supports MIRROR_CLAMP_TO_EDGE, while the

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Fix type of header register for sampler messages

2013-10-14 Thread Kenneth Graunke
On 10/14/2013 10:44 AM, Eric Anholt wrote: Chris Forbes chr...@ijw.co.nz writes: Previously this was float, which caused the copy from g0 to mangle everything. If we face a choice of types for a raw mov, we should choose float -- it's higher performance on IVB (they can get dispatched

[Mesa-dev] [Bug 69437] Composite Bypass no longer works

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69437 --- Comment #3 from U. Artie Eoff ullysses.a.e...@intel.com --- Thanks, I confirmed it fixes the issue on master... waiting on 9.2 backport. -- You are receiving this mail because: You are the QA Contact for the bug.

Re: [Mesa-dev] Easy learning project for someone looking to get into Mesa development

2013-10-14 Thread Ian Romanick
On 10/14/2013 12:22 PM, Marek Olšák wrote: I'd just add an alias GL_ARB_texture_mirror_clamp_to_edge - o(ATI_texture_mirror_once), so it would just be a one-liner change to extensions.c. Like I said: Some hardware with drivers in Mesa support the ATI extension, and some hardware can only

Re: [Mesa-dev] [PATCH 7/7] i965: Move the common binding table offset code to brw_shader.cpp.

2013-10-14 Thread Paul Berry
On 4 October 2013 15:44, Eric Anholt e...@anholt.net wrote: Now that both vec4 and fs are dynamically assigning offsets, a lot of the code is the same. --- Since next_binding_table_offset is only used to into assign_common_binding_table_offsets(), I'd prefer to see it made into a function

Re: [Mesa-dev] [Bug 69437] Composite Bypass no longer works

2013-10-14 Thread Carl Worth
bugzilla-dae...@freedesktop.org writes: --- Comment #2 from Kristian Høgsberg k...@bitplanet.net --- Happy I waited to push this, I came up with a much better fix: commit 360a141f24a9d00891665b7fedb77ffb116944ca Author: Kristian Høgsberg k...@bitplanet.net ... Cc: 9.2

[Mesa-dev] [PATCH] i965/fs: In the pre-regalloc schedule, try harder at reducing reg pressure.

2013-10-14 Thread Eric Anholt
Previously, the best thing we had was to schedule the things unblocked by the current instruction, on the hope that it would be consuming two values at the end of their live intervals while only producing one new value. Sometimes that wasn't the case. Now, when an instruction is the first user of

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Fix type of header register for sampler messages

2013-10-14 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: On 10/14/2013 10:44 AM, Eric Anholt wrote: Chris Forbes chr...@ijw.co.nz writes: Previously this was float, which caused the copy from g0 to mangle everything. If we face a choice of types for a raw mov, we should choose float -- it's higher

Re: [Mesa-dev] [PATCH 2/8] mesa: Add new functions and enums required by GL_ARB_sample_shading

2013-10-14 Thread Anuj Phogat
On Mon, Oct 14, 2013 at 11:05 AM, Matt Turner matts...@gmail.com wrote: On Mon, Oct 14, 2013 at 10:12 AM, Anuj Phogat anuj.pho...@gmail.com wrote: diff --git a/src/mapi/glapi/gen/GL3x.xml b/src/mapi/glapi/gen/GL3x.xml index 5078f7b..4ec4749 100644 --- a/src/mapi/glapi/gen/GL3x.xml +++

[Mesa-dev] [PATCH] vbo: access VBO memory more efficiently when building display lists

2013-10-14 Thread Brian Paul
Use GL_MAP_INVALIDATE_RANGE, UNSYNCHRONIZED and FLUSH_EXPLICIT flags when mapping VBOs during display list compilation. This mirrors what we do for immediate-mode VBO building in vbo_exec_vtx_map(). This improves performance for applications which interleave display list compilation with

Re: [Mesa-dev] [PATCH] build: remove forced -fno-rtti

2013-10-14 Thread Francisco Jerez
Alexander von Gluck IV kallis...@unixzen.com writes: * As discussed on the mailing list, forced no-rtti breaks C++ public API's such as the Haiku C++ libGL.so * -fno-rtti *can* be still set however instead of blindly forcing -fno-rtti, we can rely on the llvm-config --cppflags

[Mesa-dev] [Bug 70471] New: undefined reference to `typeinfo for llvm::format_object_base'

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70471 Priority: medium Bug ID: 70471 Keywords: regression CC: curroje...@riseup.net, kallis...@unixzen.com Assignee: mesa-dev@lists.freedesktop.org Summary: undefined reference to

[Mesa-dev] [Bug 70471] undefined reference to `typeinfo for llvm::format_object_base'

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70471 --- Comment #1 from Alexander von Gluck kallis...@unixzen.com --- Odd. This looks like non-rtti code is getting linked against rtti code. Was this a clean build of mesa? (aka, running scons -c before running scons) I don't think the build

[Mesa-dev] [Bug 70471] undefined reference to `typeinfo for llvm::format_object_base'

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70471 --- Comment #2 from Alexander von Gluck kallis...@unixzen.com --- Just did a clean mesa build on my ArchLinux machine + LLVM 3.3. No issues seen. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 70471] undefined reference to `typeinfo for llvm::format_object_base'

2013-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70471 --- Comment #3 from Vinson Lee v...@freedesktop.org --- The build failure occurs with a clean build. $ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=13.04 DISTRIB_CODENAME=raring DISTRIB_DESCRIPTION=Ubuntu 13.04 $ llvm-config