[Mesa-dev] [PATCH] Use line number information from entire function expression

2013-12-09 Thread Kevin Rogovin
This patch changes the error reporting behavior for incorrect function invocation (triggered by match_function_by_name() unable to find a matching function call) from using the line number information associated to the function name term to using the line number information of the entire function

[Mesa-dev] [PATCH] Report that no function found if signature lookup is empty

2013-12-09 Thread Kevin Rogovin
Enhancement: if no function signature is found for a function name, report that the function is not found instead of printing an empty list of candidates. --- src/glsl/ast_function.cpp | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 0/3] More Klocwork found issues

2013-12-09 Thread Juha-Pekka Heikkila
Simple memory allocation checks became long patches. Juha-Pekka Heikkila (3): Mesa: Change save_attrib_data() to return boolean mesa: Verify memory allocations success in _mesa_PushClientAttrib mesa: Verify memory allocations success in _mesa_PushAttrib src/mesa/main/attrib.c | 394

[Mesa-dev] [PATCH 3/3] mesa: Verify memory allocations success in _mesa_PushAttrib

2013-12-09 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 320 + 1 file changed, 272 insertions(+), 48 deletions(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 87797d1..3083e21 100644 ---

[Mesa-dev] [PATCH 2/3] mesa: Verify memory allocations success in _mesa_PushClientAttrib

2013-12-09 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 70 ++ 1 file changed, 59 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 3ecf533..87797d1 100644 ---

[Mesa-dev] [PATCH 1/3] Mesa: Change save_attrib_data() to return boolean

2013-12-09 Thread Juha-Pekka Heikkila
Change save_attrib_data() to return true/false depending on success. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index

[Mesa-dev] [PATCH] glx: Add missing null check in DRI2WireToEvent

2013-12-09 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glx/dri2.c b/src/glx/dri2.c index bcd1f9c..deb50ab 100644 --- a/src/glx/dri2.c +++ b/src/glx/dri2.c @@ -102,6 +102,8 @@ DRI2WireToEvent(Display *dpy, XEvent

[Mesa-dev] [PATCH] egl_dri2: Remove the unused swap_interval member of dri2_egl_surface

2013-12-09 Thread Neil Roberts
Hi, I made this patch a while ago while adding support for eglSwapInterval to the Wayland platform. The swap_interval member confused me for a little while before I realised that it's not used anywhere. I think it would be good to get rid of it. Regards, - Neil --- 8 --- (use

Re: [Mesa-dev] [PATCH] r600g/sb: fix stack size computation on evergreen

2013-12-09 Thread Tom Stellard
On Sat, Dec 07, 2013 at 07:06:36PM +0400, Vadim Girlin wrote: On evergreen we have to reserve 1 stack element in some additional cases besides the ones mentioned in the docs, but stack size computation was recently reimplemented exactly as described in the docs by the patch that added

[Mesa-dev] [PATCH 4/5] i965/blorp: Drop dependency to tile_x and tile_y offsets in BLORP

2013-12-09 Thread Abdiel Janulgue
GEN6-specific. Using the level and lod fields allows us to resolve directly to mipmap's level. Remove legacy code to specify the level using the tile_x and y offsets. Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 25

[Mesa-dev] [PATCH 1/5] i965: Remove tile_x and tile_y dependency in DRIImage

2013-12-09 Thread Abdiel Janulgue
We don't need this and the hardware allows us to sample directly from a mipmap's specific level and layer. We can simplify the operation by adding a level field in DRIImage instead. Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/drivers/dri/i965/intel_regions.h |

[Mesa-dev] [PATCH 2/5] i965: Use mipmap's level to resolve directly to surface

2013-12-09 Thread Abdiel Janulgue
Remove legacy code when recreating a single-layer miptree from a level of the source texture using tile_x and tile_y offsets. Save the level field in intel_texture_object so we can resolve this direcly in the hardware. Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com ---

[Mesa-dev] PATCHES: R600: Register machine passes and code cleanups

2013-12-09 Thread Tom Stellard
Hi, The first two patches register the R600EmitClauseMarkers and AMDGPUCFGStructurizer passes, so that -print-*-all will now work with them. The third patch is a cleanup of Processors.td and the fourth patch adds the wavefront size property to the subtargets. Please Review. -Tom From

[Mesa-dev] [PATCH 5/5] i965:gen7+ Remove tile_x and tile_y dependency in BLORP

2013-12-09 Thread Abdiel Janulgue
GEN7+-specific hw-support. This can be copied over to GEN8/Broadwell with few modifications. Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/drivers/dri/i965/gen7_blorp.cpp | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: fix texture view use of _mesa_get_tex_image()

2013-12-09 Thread Brian Paul
On 12/07/2013 11:17 PM, Chris Forbes wrote: The target parameter to _mesa_get_tex_image() is a target enum, not an index. When we're setting up faces for a cubemap, it should be CUBE_MAP_POSITIVE_X .. CUBE_MAP_NEGATIVE_Z; for all other targets it should be the same as the texobj's target. Fixes

[Mesa-dev] i965: Remove surface state Tile-X / Tile-Y offsets (GEN8 enabling)

2013-12-09 Thread Abdiel Janulgue
(cover letter seems to be lost in the way for the patch series but here it is) Gen 6/7 hardware support for tile_x and tile_y offset fields in SURFACE_STATE has been removed in Gen8. All code dependencies must be removed. This patch series completely eliminates the tile_x and y fields in the

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-09 Thread Brian Paul
On 12/07/2013 06:17 PM, Francisco Jerez wrote: And to check if it can have layers at all. This will be used by the implementation of ARB_shader_image_load_store. --- src/mesa/main/teximage.c | 85 src/mesa/main/teximage.h | 6 2 files

Re: [Mesa-dev] [PATCH] glx: Add missing null check in DRI2WireToEvent

2013-12-09 Thread Brian Paul
On 12/09/2013 06:15 AM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glx/dri2.c b/src/glx/dri2.c index bcd1f9c..deb50ab 100644 --- a/src/glx/dri2.c +++ b/src/glx/dri2.c

Re: [Mesa-dev] [PATCH 3/3] mesa: Verify memory allocations success in _mesa_PushAttrib

2013-12-09 Thread Brian Paul
On 12/09/2013 08:19 AM, Pohjolainen, Topi wrote: On Mon, Dec 09, 2013 at 02:29:21PM +0200, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 320 + 1 file changed, 272

[Mesa-dev] [Bug 69285] Enabling LLVM results in substantially different rendering

2013-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69285 --- Comment #3 from Charles Huber genpfa...@gmail.com --- Still broken in 10.0. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list

Re: [Mesa-dev] i965: Remove surface state Tile-X / Tile-Y offsets (GEN8 enabling)

2013-12-09 Thread Jordan Justen
On Mon, Dec 9, 2013 at 8:18 AM, Abdiel Janulgue abdiel.janul...@linux.intel.com wrote: (cover letter seems to be lost in the way for the patch series but here it is) Gen 6/7 hardware support for tile_x and tile_y offset fields in SURFACE_STATE has been removed in Gen8. All code dependencies

Re: [Mesa-dev] [PATCH] dri_util: Don't assume __DRIcontext-driverPrivate is a gl_context

2013-12-09 Thread Ian Romanick
On 12/07/2013 10:02 PM, Kristian Høgsberg wrote: The driverPrivate pointer is opaque to the driver and we can't assume it's a struct gl_context in dri_util.c. Instead provide a helper function to set the struct gl_context flags from the incoming DRI context flags. Signed-off-by: Kristian

Re: [Mesa-dev] i965: Remove surface state Tile-X / Tile-Y offsets (GEN8 enabling)

2013-12-09 Thread Chris Forbes
Jordan, Abdiel: Could you provide some context -- the impression I get is that using the tile offsets is undesirable for reasons other than sharing code with Gen8, but not familiar enough with the details to know why. Just curious :) -- Chris On Tue, Dec 10, 2013 at 7:21 AM, Jordan Justen

Re: [Mesa-dev] i965: Remove surface state Tile-X / Tile-Y offsets (GEN8 enabling)

2013-12-09 Thread Chris Forbes
Thanks Paul, that makes a lot of sense. -- Chris On Tue, Dec 10, 2013 at 8:34 AM, Paul Berry stereotype...@gmail.com wrote: On 9 December 2013 11:06, Chris Forbes chr...@ijw.co.nz wrote: Jordan, Abdiel: Could you provide some context -- the impression I get is that using the tile offsets

Re: [Mesa-dev] [PATCH] dri_util: Don't assume __DRIcontext-driverPrivate is a gl_context

2013-12-09 Thread Ian Romanick
On 12/09/2013 10:53 AM, Ian Romanick wrote: On 12/07/2013 10:02 PM, Kristian Høgsberg wrote: The driverPrivate pointer is opaque to the driver and we can't assume it's a struct gl_context in dri_util.c. Instead provide a helper function to set the struct gl_context flags from the incoming DRI

Re: [Mesa-dev] [PATCH] r600g/sb: fix stack size computation on evergreen

2013-12-09 Thread Andre Heider
On Sat, Dec 07, 2013 at 07:06:36PM +0400, Vadim Girlin wrote: On evergreen we have to reserve 1 stack element in some additional cases besides the ones mentioned in the docs, but stack size computation was recently reimplemented exactly as described in the docs by the patch that added

Re: [Mesa-dev] [PATCH V2 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-12-09 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/03/2013 10:44 AM, Eric Anholt wrote: Siavash Eliasi siavashser...@gmail.com writes: Hello, this is V2 series of patches to accomplish *Enable ARB_map_buffer_alignment in all drivers* newbie project suggested by Ian Romanick. I think

Re: [Mesa-dev] Nesa-dev now integrated with patchwork

2013-12-09 Thread Paul Berry
On 5 December 2013 11:33, Carl Worth cwo...@cworth.org wrote: Carl Worth cwo...@cworth.org writes: So, you should all expect to see these hook messages now: remote: I: patch #PATCHWORK_ID updated using rev GIT_COMMIT. ... remote: E: failed to find patch for rev GIT_COMMIT.

[Mesa-dev] [PATCH v3] dri megadriver_stub: add compatibility for older DRI loaders

2013-12-09 Thread Jordan Justen
To help the transition period when DRI loaders are being updated to support the newer __driDriverExtensions_foo mechanism, we populate __driDriverExtensions with the extensions returned by __driDriverExtensions_foo during a library contructor function. We find the driver foo's name by using the

Re: [Mesa-dev] [PATCH] dri_util: Don't assume __DRIcontext-driverPrivate is a gl_context

2013-12-09 Thread Kristian Høgsberg
On Mon, Dec 9, 2013 at 12:41 PM, Ian Romanick i...@freedesktop.org wrote: On 12/09/2013 10:53 AM, Ian Romanick wrote: On 12/07/2013 10:02 PM, Kristian Høgsberg wrote: The driverPrivate pointer is opaque to the driver and we can't assume it's a struct gl_context in dri_util.c. Instead provide

Re: [Mesa-dev] [PATCH] r600g/sb: fix stack size computation on evergreen

2013-12-09 Thread Vadim Girlin
On Mon, 2013-12-09 at 10:56 -0500, Tom Stellard wrote: On Sat, Dec 07, 2013 at 07:06:36PM +0400, Vadim Girlin wrote: On evergreen we have to reserve 1 stack element in some additional cases besides the ones mentioned in the docs, but stack size computation was recently reimplemented exactly

Re: [Mesa-dev] [PATCH 06/11] mesa: Add MESA_FORMAT_ABGR2101010.

2013-12-09 Thread Paul Berry
On 7 December 2013 07:42, Francisco Jerez curroje...@riseup.net wrote: Paul Berry stereotype...@gmail.com writes: On 24 November 2013 21:00, Francisco Jerez curroje...@riseup.net wrote: Including pack/unpack and texstore code. This texture format is a requirement for

Re: [Mesa-dev] [PATCH 08/11] mesa: Implement the GL entry points defined by ARB_shader_image_load_store.

2013-12-09 Thread Paul Berry
On 7 December 2013 17:11, Francisco Jerez curroje...@riseup.net wrote: Paul Berry stereotype...@gmail.com writes: On 24 November 2013 21:00, Francisco Jerez curroje...@riseup.net wrote: [...] + + case GL_RGBA16UI: + return MESA_FORMAT_RGBA_UINT16; + + case GL_RGB10_A2UI:

Re: [Mesa-dev] [PATCH 03/11] mesa: Add state data structures requried for ARB_shader_image_load_store.

2013-12-09 Thread Paul Berry
On 7 December 2013 17:12, Francisco Jerez curroje...@riseup.net wrote: Paul Berry stereotype...@gmail.com writes: With those changes, this patch is: Reviewed-by: Paul Berry stereotype...@gmail.com I think I've taken into account all your comments here [1], and I've changed the value

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-09 Thread Paul Berry
On 7 December 2013 17:17, Francisco Jerez curroje...@riseup.net wrote: And to check if it can have layers at all. This will be used by the implementation of ARB_shader_image_load_store. --- src/mesa/main/teximage.c | 85

[Mesa-dev] [PATCH 2/2] i965: Use {point_sprite, flat}_enable variable names instead of dw*.

2013-12-09 Thread Kenneth Graunke
Calling the local variables flat_enable and point_sprite_enable is clearer than dw16 and such. It also matches the names used in calculate_attr_overrides, which computes them. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Cc: Paul Berry stereotype...@gmail.com ---

[Mesa-dev] [PATCH 1/2] i965: Zero out {point_sprite, flat}_enables in calculate_attr_overrides.

2013-12-09 Thread Kenneth Graunke
calculate_attr_overrides is responsible for computing the point sprite and flat-shading enable bitfields. It does so by OR'ing in a bunch of bits. However, it relied on the caller to set the initial value to zero. This is pretty fragile - if the caller neglects to zero out those variables, then

Re: [Mesa-dev] [PATCH v3] dri megadriver_stub: add compatibility for older DRI loaders

2013-12-09 Thread Keith Packard
Jordan Justen jordan.l.jus...@intel.com writes: To help the transition period when DRI loaders are being updated to support the newer __driDriverExtensions_foo mechanism, we populate __driDriverExtensions with the extensions returned by __driDriverExtensions_foo during a library contructor

[Mesa-dev] [PATCH v2] dri_util: Don't assume __DRIcontext-driverPrivate is a gl_context

2013-12-09 Thread Ian Romanick
From: Kristian Høgsberg k...@bitplanet.net The driverPrivate pointer is opaque to the driver and we can't assume it's a struct gl_context in dri_util.c. Instead provide a helper function to set the struct gl_context flags from the incoming DRI context flags. v2 (idr): Modify the other classic

Re: [Mesa-dev] [PATCH V2 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-12-09 Thread Eric Anholt
Ian Romanick i...@freedesktop.org writes: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/03/2013 10:44 AM, Eric Anholt wrote: Siavash Eliasi siavashser...@gmail.com writes: Hello, this is V2 series of patches to accomplish *Enable ARB_map_buffer_alignment in all drivers* newbie

Re: [Mesa-dev] [PATCH V2 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-12-09 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/09/2013 04:58 PM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/03/2013 10:44 AM, Eric Anholt wrote: Siavash Eliasi siavashser...@gmail.com writes: Hello, this is V2

[Mesa-dev] [Bug 70250] weston-terminal rendering corrupted with output transform 90 and 270

2013-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70250 --- Comment #4 from Ian Romanick i...@freedesktop.org --- Artie, Did this fix the problem for you? There's no Reviewed-by on the patch, so I want *something* before I cherry pick it over to stable. Thanks. -- You are receiving this mail

[Mesa-dev] [Bug 70250] weston-terminal rendering corrupted with output transform 90 and 270

2013-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70250 --- Comment #5 from Ian Romanick i...@freedesktop.org --- Since you marked the bug as VERIFIED, I'll call that a Tested-by. Sorry for the noise. -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [PATCH] glsl: Set ARB_texture_rectangle_enable to false if version 100 shader

2013-12-09 Thread Anuj Phogat
OpenGL with ARB_ES2_compatibility extension allows shaders that specify #version 100 and the shader is treated as targeting version 100 of the GLSL ES. state-es_shader flag might change during parsing based on the #version directive mentioned in the shader program. This patch adds another check

[Mesa-dev] [PATCH] llvmpipe: fix blending with half-float formats

2013-12-09 Thread Zack Rusin
The fact that we flush denorms to zero breaks our half-float conversion and blending. This patches enables denorms for blending. It's a little tricky due to the llvm bug that makes it incorrectly reorder the mxcsr intrinsics: http://llvm.org/bugs/show_bug.cgi?id=6393 Signed-off-by: Zack Rusin

Re: [Mesa-dev] [PATCH] r600g/sb: fix stack size computation on evergreen

2013-12-09 Thread Tom Stellard
On Tue, Dec 10, 2013 at 02:54:46AM +0400, Vadim Girlin wrote: On Mon, 2013-12-09 at 10:56 -0500, Tom Stellard wrote: On Sat, Dec 07, 2013 at 07:06:36PM +0400, Vadim Girlin wrote: On evergreen we have to reserve 1 stack element in some additional cases besides the ones mentioned in the

[Mesa-dev] [PATCH 2/2] llvmpipe: add a very useful (disabled) debugging output

2013-12-09 Thread Zack Rusin
Disabled by default, but it's very useful when needed. Signed-off-by: Zack Rusin za...@vmware.com --- src/gallium/drivers/llvmpipe/lp_setup_point.c | 20 1 file changed, 20 insertions(+) diff --git a/src/gallium/drivers/llvmpipe/lp_setup_point.c

[Mesa-dev] [PATCH 1/2] draw: fix vbuf caching of vertices with inject front face

2013-12-09 Thread Zack Rusin
Caching in the vbuf module meant that once a vertex has been emitted it was cached, but it's possible for a vertex at the same location to be emitted again, but this time with a different front-face semantic. Caching was causing the first version of the vertex to be emitted, which resulted in the

Re: [Mesa-dev] [PATCH v2] dri_util: Don't assume __DRIcontext-driverPrivate is a gl_context

2013-12-09 Thread Eric Anholt
Ian Romanick i...@freedesktop.org writes: From: Kristian Høgsberg k...@bitplanet.net The driverPrivate pointer is opaque to the driver and we can't assume it's a struct gl_context in dri_util.c. Instead provide a helper function to set the struct gl_context flags from the incoming DRI