Re: [Mesa-dev] [PATCH] automake: don't enable -Wl, --no-undefined on OpenBSD

2014-04-02 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glapi: Add static dispatch for glPointSizePointerOES

2014-04-02 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/4] glapi: Fix build break in 'make check' on non-shared-glapi builds

2014-04-02 Thread Timothy Arceri
On Wed, 2014-04-02 at 00:56 +0200, Dieter Nützel wrote: Hello Ian, hello Timothy, does this fix the regression introduced with commit fb78fa58? [Mesa-dev] Mesa git (r600g): OpenGL Error(GL_INVALID_OPERATION): initTexture2D (bisected)

[Mesa-dev] [PATCH] i965/vec4: do not trim dead channels on gen6 for math

2014-04-02 Thread Tapani Pälli
On GEN6 math operations require destination writemask to be WRITEMASK_XYZW. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76883 Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 14 +++--- 1 file changed, 11 insertions(+), 3

Re: [Mesa-dev] [PATCH] i965/vec4: do not trim dead channels on gen6 for math

2014-04-02 Thread Matt Turner
On Tue, Apr 1, 2014 at 11:18 PM, Tapani Pälli tapani.pa...@intel.com wrote: On GEN6 math operations require destination writemask to be WRITEMASK_XYZW. That's not really it. Gen6 doesn't support the math in align16 mode, which is the mode required for writemasking and swizzling. Bugzilla:

[Mesa-dev] [PATCH] docs: Add note about updating tests to dev info

2014-04-02 Thread Timothy Arceri
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- docs/devinfo.html | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/devinfo.html b/docs/devinfo.html index d4a6dfb..67c1f34 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html @@ -56,6 +56,11 @@ To add a new GL extension to

Re: [Mesa-dev] [PATCH] i965/vec4: do not trim dead channels on gen6 for math

2014-04-02 Thread Tapani Pälli
On 04/02/2014 09:45 AM, Matt Turner wrote: On Tue, Apr 1, 2014 at 11:18 PM, Tapani Pälli tapani.pa...@intel.com wrote: On GEN6 math operations require destination writemask to be WRITEMASK_XYZW. That's not really it. Gen6 doesn't support the math in align16 mode, which is the mode required for

Re: [Mesa-dev] [PATCH 2/4] xa: remove unneeded args

2014-04-02 Thread Thomas Hellstrom
On 04/01/2014 05:04 PM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Signed-off-by: Rob Clark robcl...@freedesktop.org --- src/gallium/state_trackers/xa/xa_composite.c | 3 +-- src/gallium/state_trackers/xa/xa_context.c | 5 + src/gallium/state_trackers/xa/xa_priv.h

Re: [Mesa-dev] [PATCH 3/4] xa: scissor to help tilers

2014-04-02 Thread Thomas Hellstrom
Rob, A minor nitpick below: On 04/01/2014 05:04 PM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Keep track of the maximal bounds of all the operations and set scissor accordingly. For tiling GPU's this can be a big win by reducing the memory bandwidth spent moving pixels from

Re: [Mesa-dev] [PATCH 4/4] xa: reuse surfaces

2014-04-02 Thread Thomas Hellstrom
On 04/01/2014 05:04 PM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Otherwise it will trick the gallium driver into thinking that the render target has actually changed (due to different pipe_surface pointing to same underlying pipe_resource). This is really badness for tiling

[Mesa-dev] [PATCH V3 00/30] ARB_texture_view for i965

2014-04-02 Thread Chris Forbes
This series adds ARB_texture_view support for i965 Gen7/7.5. Significant changes from V2: - All the assorted post-V2 format fixups are moved to the start of the series. This gives us consistent memory layout for all the formats between which we have to support casting. - Texture validation

[Mesa-dev] [PATCH V3 16/30] i965: Don't try to use fast upload path for nontrivial views

2014-04-02 Thread Chris Forbes
This will eventually be relaxed, but we'll get the fallback path working first. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [PATCH V3 22/30] i965: Pull out layer_multiplier in intel_update_renderbuffer_wrapper

2014-04-02 Thread Chris Forbes
We're about to need this in another place. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/intel_fbo.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c

[Mesa-dev] [PATCH V3 10/30] i965: refactor format munging for separate stencil

2014-04-02 Thread Chris Forbes
We will need this for munging the view's format. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 31 --- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 +++ 2 files

[Mesa-dev] [PATCH V3 03/30] swrast: Add support for fetching from MESA_FORMAT_R10G10B10A2_UNORM

2014-04-02 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/swrast/s_texfetch.c | 6 +++--- src/mesa/swrast/s_texfetch_tmp.h | 16 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/src/mesa/swrast/s_texfetch.c b/src/mesa/swrast/s_texfetch.c index cd09827..4084bbd

[Mesa-dev] [PATCH V3 14/30] i965: Add _Format to intel_texobj.

2014-04-02 Thread Chris Forbes
This is the actual mesa_format to use. In non-view cases this is always the same as the mt's format. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/intel_tex.c | 8 src/mesa/drivers/dri/i965/intel_tex_obj.h | 5 +

[Mesa-dev] [PATCH V3 07/30] i965: Render R8G8B8X8 as R8G8B8A8

2014-04-02 Thread Chris Forbes
The sampler can handle R8G8B8X8 (and substitute 1.0 for the fourth component) but we can't use it as a render target. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Mesa-dev] [PATCH V3 17/30] i965: Adjust map/unmap code for MinLevel/MinLayer

2014-04-02 Thread Chris Forbes
This allows core mesa's TexSubImage paths etc to work correctly with views which have nonzero MinLevel or MinLayer. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/intel_tex.c | 11 --- 1 file changed, 8

[Mesa-dev] [PATCH V3 08/30] mesa: Adjust _MaxLevel computation to account for views

2014-04-02 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/main/texobj.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 8bdbb08..918dd59 100644 --- a/src/mesa/main/texobj.c +++

[Mesa-dev] [PATCH V3 12/30] i965: Ensure that texture validation is skipped for immutable textures.

2014-04-02 Thread Chris Forbes
If we were to relayout the miptree, we'd break any views that are sharing it. (Simplified based on suggestions from Eric) Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/intel_tex_validate.c | 5 + 1 file changed, 5 insertions(+) diff --git

[Mesa-dev] [PATCH V3 02/30] mesa: fix packing of float texels to GL_SHORT/GL_BYTE

2014-04-02 Thread Chris Forbes
Previously, we would unpack the texels to floats using *_TO_FLOAT_TEX, and then pack them into the desired format using FLOAT_TO_*. Unfortunately, this isn't quite the inverse operation, and so some texel values would end up off-by-one. This fixes the GL_RGB8_SNORM and GL_RGB16_SNORM subcases in

[Mesa-dev] [PATCH V3 15/30] i965: Adjust surface_state emission to account for view parameters

2014-04-02 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c

[Mesa-dev] [PATCH V3 04/30] i965: Enable R8G8B8A8_UNORM_SRGB format

2014-04-02 Thread Chris Forbes
Now this is the preferred format for GL_SRGB8_ALPHA8. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c

[Mesa-dev] [PATCH V3 13/30] i965: Add driver hook for TextureView

2014-04-02 Thread Chris Forbes
We need to wire the original texture's mt into the view. All the hard work of setting up an appropriate tree of gl_texture_image structures has already been done by core mesa. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com ---

[Mesa-dev] [PATCH V3 05/30] i965: Enable R10G10B10A2_UNORM format

2014-04-02 Thread Chris Forbes
This is supported by all generations, and is required for memory layout consistency for texture_view. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH V3 21/30] i965: Add `layered` parameter to intel_update_renderbuffer_wrapper

2014-04-02 Thread Chris Forbes
We're about to need this so we can determine the layer count of the wrapper. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/intel_fbo.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH V3 25/30] i965/blorp: Account for nonzero MinLayer in layered clears.

2014-04-02 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp

[Mesa-dev] [PATCH V3 19/30] i965: Enable texture upload fast path with MinLevel

2014-04-02 Thread Chris Forbes
We'll still avoid MinLayer here since the fast path doesn't understand arrays at all, but it's straightforward to do levels. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 2 +- 1 file changed,

[Mesa-dev] [PATCH V3 20/30] i965: Adjust renderbuffer wrapper to account for MinLevel/MinLayer

2014-04-02 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/intel_fbo.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c index d0e1349..98247f2

[Mesa-dev] [PATCH V3 06/30] i965: Pretend we don't support BRW_SURFACEFORMAT_R16G16B16_FLOAT for textures.

2014-04-02 Thread Chris Forbes
None of the other 3-component 16bpc formats are directly supported, so they get promoted to XRGB equivalents. *Not* promoting RGB16F the same way makes texture views much more fiddly -- we don't want to have to do crazy copying behind the scenes. (with my other master + my experimental

[Mesa-dev] [PATCH V3 23/30] i965: Add layer_count to intel_renderbuffer

2014-04-02 Thread Chris Forbes
This is the effective layer count, for clears etc. This differs from the depth of the miptree level when views are involved. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/intel_fbo.c | 10 ++

[Mesa-dev] [PATCH V3 01/30] mesa: Prefer non-swizzled formats for most sized internalformats

2014-04-02 Thread Chris Forbes
These formats can be cast to others (with different component types or sizes) via ARB_texture_view or ARB_shader_image_load_store. We want them to be laid out consistently so that we can just reinterpret the memory with a different format. In V1, this was done conditionally on a

[Mesa-dev] [PATCH V3 09/30] i965: Include #slices in miptree debug

2014-04-02 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

[Mesa-dev] [PATCH V3 18/30] i965: Account for MinLevel in texture upload fast path

2014-04-02 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c

[Mesa-dev] [PATCH V3 28/30] i965: Account for view parameters in blit CTSI path

2014-04-02 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/intel_tex_copy.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_copy.c b/src/mesa/drivers/dri/i965/intel_tex_copy.c index ca0b5b9..c2b6c35 100644 ---

[Mesa-dev] [PATCH V3 24/30] i965/blorp: Use irb-layer_count in clear

2014-04-02 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp

[Mesa-dev] [PATCH V3 30/30] docs: Mark off ARB_texture_view and add to release notes for 10.2.

2014-04-02 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- docs/GL3.txt| 2 +- docs/relnotes/10.2.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index b7e4c87..657ac7e 100644 ---

[Mesa-dev] [PATCH V3 29/30] i965: Enable ARB_texture_view on Gen7+

2014-04-02 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index

[Mesa-dev] [PATCH V3 27/30] i965: Account for MinLayer/MinLevel in blorp CTSI path

2014-04-02 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp index 9e80935..300ff5c 100644 ---

[Mesa-dev] [PATCH V3 26/30] i965: Account for view parameters in fast depth clears

2014-04-02 Thread Chris Forbes
V2: - No need for layer_multiplier; multisampled depth surfaces are IMS. - Remove unused num_layers. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_clear.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[Mesa-dev] [PATCH V2] i965/vec4: do not trim dead channels on gen6 for math

2014-04-02 Thread Tapani Pälli
Do not set a writemask on Gen6 for math instructions, those are executed using align1 mode that does not support a destination mask. v2: cleanups, better comment (Matt) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76883 Signed-off-by: Tapani Pälli tapani.pa...@intel.com ---

Re: [Mesa-dev] [PATCH] Revert radeon: just don't map VRAM buffers at all

2014-04-02 Thread Christian König
Am 01.04.2014 15:47, schrieb Leo Liu: From: Leo Liu leo@amd.com This reverts commit 96e8b916a7a39a9ba58e92d1ad77b5501de63ac7. The patch itself is ok, but we should probably add an explanation why we want to revert this. Christian. Signed-off-by: Leo Liu leo@amd.com ---

Re: [Mesa-dev] [PATCH 0/6] Some glapi clean-up releated to GLES

2014-04-02 Thread Jose Fonseca
- Original Message - Tomorrow or Friday I'm going to send out the last of the GL_ARB_separate_shader_objects patches. Shortly after that, I will send out patches to enable GL_EXT_separate_shader_objects on GLES. This EXT is the GLES subset of the ARB extension. In preparing for

[Mesa-dev] [PATCH] Revert radeon: just don't map VRAM buffers at all

2014-04-02 Thread Leo Liu
From: Leo Liu leo@amd.com This reverts commit 96e8b916a7a39a9ba58e92d1ad77b5501de63ac7. In the case of VCE encoding with raw YUV file, CPU load directly to VRAM is faster than combination of CPU writing to GTT and then blit to VRAM with GPU. --- src/gallium/drivers/radeon/r600_texture.c | 4

Re: [Mesa-dev] Guidance in dwelling in the world of GPU driver development.

2014-04-02 Thread Leander Bessa Beernaert
Thanks! Not sure yet what I'll be working on yet, but I'll be sure to look into nouveau. Would it be possible for me to go about and work on OpenGL features which are beyond the capabilities of my GPU? On Mon, Mar 31, 2014 at 7:14 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Mar 31,

Re: [Mesa-dev] [PATCH] Revert radeon: just don't map VRAM buffers at all

2014-04-02 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Wed, Apr 2, 2014 at 3:09 PM, Leo Liu leo@amd.com wrote: From: Leo Liu leo@amd.com This reverts commit 96e8b916a7a39a9ba58e92d1ad77b5501de63ac7. In the case of VCE encoding with raw YUV file, CPU load directly to VRAM is faster

Re: [Mesa-dev] [PATCH] Revert radeon: just don't map VRAM buffers at all

2014-04-02 Thread Alex Deucher
On Wed, Apr 2, 2014 at 9:09 AM, Leo Liu leo@amd.com wrote: From: Leo Liu leo@amd.com This reverts commit 96e8b916a7a39a9ba58e92d1ad77b5501de63ac7. In the case of VCE encoding with raw YUV file, CPU load directly to VRAM is faster than combination of CPU writing to GTT and then blit

Re: [Mesa-dev] [PATCH] Revert radeon: just don't map VRAM buffers at all

2014-04-02 Thread Marek Olšák
Also, the VCE code could use PIPE_TRANSFER_MAP_DIRECTLY to avoid the blit and this patch wouldn't be needed. Marek On Wed, Apr 2, 2014 at 3:30 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Wed, Apr 2, 2014 at 9:09 AM, Leo Liu leo@amd.com wrote: From: Leo Liu leo@amd.com This

Re: [Mesa-dev] [PATCH] Revert radeon: just don't map VRAM buffers at all

2014-04-02 Thread Christian König
I've applied the original patch because the same thing for reading textures speeded up the decoding case with UVD quite significantly. For VCE it reduced the CPU load as well, but I didn't checked if the encoding time stayed the same (which isn't the case). I think the problem is that VCE

Re: [Mesa-dev] [PATCH 0/6] Some glapi clean-up releated to GLES

2014-04-02 Thread Brian Paul
On 04/02/2014 06:21 AM, Jose Fonseca wrote: - Original Message - Tomorrow or Friday I'm going to send out the last of the GL_ARB_separate_shader_objects patches. Shortly after that, I will send out patches to enable GL_EXT_separate_shader_objects on GLES. This EXT is the GLES subset

Re: [Mesa-dev] [PATCH] Revert radeon: just don't map VRAM buffers at all

2014-04-02 Thread Liu, Leo
Okay. with PIPE_TRANSFER_MAP_DIRECTLY, the regression can be fixed too. Going to resend patch for this approach. Leo -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Wednesday, April 02, 2014 9:43 AM To: Marek Olšák;

Re: [Mesa-dev] [PATCH 4/4] xa: reuse surfaces

2014-04-02 Thread Roland Scheidegger
Am 02.04.2014 09:47, schrieb Thomas Hellstrom: On 04/01/2014 05:04 PM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Otherwise it will trick the gallium driver into thinking that the render target has actually changed (due to different pipe_surface pointing to same underlying

Re: [Mesa-dev] [PATCH] Revert radeon: just don't map VRAM buffers at all

2014-04-02 Thread Christian König
No wait a second. As explained I've added the code in question specially for VCE so if we disable it for VCE it won't be used. I still think that reverting the patch is the right approach. Christian. Am 02.04.2014 15:54, schrieb Liu, Leo: Okay. with PIPE_TRANSFER_MAP_DIRECTLY, the regression

Re: [Mesa-dev] [PATCH V3 03/30] swrast: Add support for fetching from MESA_FORMAT_R10G10B10A2_UNORM

2014-04-02 Thread Brian Paul
On 04/02/2014 02:04 AM, Chris Forbes wrote: Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/swrast/s_texfetch.c | 6 +++--- src/mesa/swrast/s_texfetch_tmp.h | 16 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/src/mesa/swrast/s_texfetch.c

Re: [Mesa-dev] [PATCH V3 02/30] mesa: fix packing of float texels to GL_SHORT/GL_BYTE

2014-04-02 Thread Brian Paul
On 04/02/2014 02:04 AM, Chris Forbes wrote: Previously, we would unpack the texels to floats using *_TO_FLOAT_TEX, and then pack them into the desired format using FLOAT_TO_*. Unfortunately, this isn't quite the inverse operation, and so some texel values would end up off-by-one. This fixes the

Re: [Mesa-dev] [PATCH V3 01/30] mesa: Prefer non-swizzled formats for most sized internalformats

2014-04-02 Thread Brian Paul
On 04/02/2014 02:04 AM, Chris Forbes wrote: These formats can be cast to others (with different component types or sizes) via ARB_texture_view or ARB_shader_image_load_store. We want them to be laid out consistently so that we can just reinterpret the memory with a different format. In V1, this

Re: [Mesa-dev] [PATCH 4/4] xa: reuse surfaces

2014-04-02 Thread Rob Clark
On Wed, Apr 2, 2014 at 3:47 AM, Thomas Hellstrom thellst...@vmware.com wrote: On 04/01/2014 05:04 PM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Otherwise it will trick the gallium driver into thinking that the render target has actually changed (due to different pipe_surface

Re: [Mesa-dev] [PATCH] winsys/svga: Replace the query mm buffer pool with a slab pool v3

2014-04-02 Thread Brian Paul
On 04/01/2014 11:50 PM, Thomas Hellstrom wrote: This is to avoid running out of query buffer space due to winsys limitations. Instead of a fixed size per screen pool of query buffers, use a slab allocator that allocates a new slab if we run out of space in the first one. v2: Correct email

Re: [Mesa-dev] Guidance in dwelling in the world of GPU driver development.

2014-04-02 Thread Rob Clark
On Wed, Apr 2, 2014 at 9:15 AM, Leander Bessa Beernaert leande...@gmail.com wrote: Thanks! Not sure yet what I'll be working on yet, but I'll be sure to look into nouveau. Would it be possible for me to go about and work on OpenGL features which are beyond the capabilities of my GPU? short

Re: [Mesa-dev] [PATCH V2] i965/vec4: do not trim dead channels on gen6 for math

2014-04-02 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] DaibloIII: radeon: mmap failed, errno: 12

2014-04-02 Thread Sven Arvidsson
On Tue, 2014-04-01 at 17:30 -0500, Mike Mestnik wrote: http://bitly.com/1ibsC0y What debugging steps are next? There is no BT because the application exits cleanly. Hi, You should file a bug against Mesa, possibly with Wine too: https://bugs.freedesktop.org/ http://bugs.winehq.org/ Mention

[Mesa-dev] [PATCH] cso: fix sampler view count in cso_set_sampler_views()

2014-04-02 Thread Brian Paul
We want to call pipe-set_sampler_views() with count being the maximum of the old number of sampler views and the new number. This makes sure we null-out any old sampler views. We already do the same thing for sampler states in single_sampler_done(). Fixes some assertions seen in the VMware driver

Re: [Mesa-dev] [PATCH] mesa: fix check for dummy renderbuffer in _mesa_FramebufferRenderbufferEXT()

2014-04-02 Thread Anuj Phogat
On Tue, Apr 1, 2014 at 2:37 AM, Samuel Iglesias Gonsalvez sigles...@igalia.com wrote: According to the spec: renderbuffertarget must be RENDERBUFFER and renderbuffer should be set to the name of the renderbuffer object to be attached to the framebuffer. renderbuffer

Re: [Mesa-dev] [PATCH] automake: don't enable -Wl, --no-undefined on OpenBSD

2014-04-02 Thread Emil Velikov
On 02/04/14 04:55, Jonathan Gray wrote: OpenBSD does not have DT_NEEDED entries for libc by design, over concerns how the symbols would be referenced after changing the major version of the library. So avoid -no-undefined checks on OpenBSD as they will fail. If I understood things

Re: [Mesa-dev] [PATCH] cso: fix sampler view count in cso_set_sampler_views()

2014-04-02 Thread Roland Scheidegger
Am 02.04.2014 18:34, schrieb Brian Paul: We want to call pipe-set_sampler_views() with count being the maximum of the old number of sampler views and the new number. This makes sure we null-out any old sampler views. We already do the same thing for sampler states in single_sampler_done().

Re: [Mesa-dev] [PATCH 4/4] xa: reuse surfaces

2014-04-02 Thread Thomas Hellstrom
On 04/02/2014 04:40 PM, Rob Clark wrote: On Wed, Apr 2, 2014 at 3:47 AM, Thomas Hellstrom thellst...@vmware.com wrote: On 04/01/2014 05:04 PM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Otherwise it will trick the gallium driver into thinking that the render target has

Re: [Mesa-dev] [PATCH 2/4] glapi: Fix build break in 'make check' on non-shared-glapi builds

2014-04-02 Thread Ian Romanick
On 04/01/2014 02:25 PM, Timothy Arceri wrote: Thanks Ian, Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au I wasn't aware of this test. I guess the other KHR_debug functions should be added here also? If so I can create a patch for this later today unless you just want to do it. Some of

Re: [Mesa-dev] [PATCH 4/4] xa: reuse surfaces

2014-04-02 Thread Rob Clark
On Wed, Apr 2, 2014 at 2:05 PM, Thomas Hellstrom thellst...@vmware.com wrote: On 04/02/2014 04:40 PM, Rob Clark wrote: On Wed, Apr 2, 2014 at 3:47 AM, Thomas Hellstrom thellst...@vmware.com wrote: On 04/01/2014 05:04 PM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Otherwise

Re: [Mesa-dev] [PATCH 2/4] loader: don't limit the non-udev path to only android

2014-04-02 Thread Emil Velikov
On 22/03/14 00:10, Emil Velikov wrote: On 19/03/14 01:06, Jonathan Gray wrote: On Tue, Mar 18, 2014 at 07:56:21PM +, Emil Velikov wrote: On 18/03/14 14:59, Jonathan Gray wrote: Signed-off-by: Jonathan Gray j...@jsg.id.au --- Hi Jonathan While the summary covers what the patch does, the

Re: [Mesa-dev] [PATCH 0/6] Some glapi clean-up releated to GLES

2014-04-02 Thread Ian Romanick
On 04/02/2014 05:21 AM, Jose Fonseca wrote: - Original Message - Tomorrow or Friday I'm going to send out the last of the GL_ARB_separate_shader_objects patches. Shortly after that, I will send out patches to enable GL_EXT_separate_shader_objects on GLES. This EXT is the GLES subset

[Mesa-dev] [Bug 76960] New: NameError: name 'src' is not defined

2014-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76960 Priority: medium Bug ID: 76960 Keywords: regression CC: bri...@vmware.com, huax...@intel.com, i...@freedesktop.org Assignee: mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 4/4] xa: reuse surfaces

2014-04-02 Thread Rob Clark
On Wed, Apr 2, 2014 at 2:05 PM, Thomas Hellstrom thellst...@vmware.com wrote: On 04/02/2014 04:40 PM, Rob Clark wrote: On Wed, Apr 2, 2014 at 3:47 AM, Thomas Hellstrom thellst...@vmware.com wrote: On 04/01/2014 05:04 PM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Otherwise

[Mesa-dev] [Bug 76960] NameError: name 'src' is not defined

2014-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76960 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment

[Mesa-dev] [Bug 76960] NameError: name 'src' is not defined

2014-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76960 --- Comment #2 from Vinson Lee v...@freedesktop.org --- $ /usr/bin/python -c src/mapi/glapi/gen/gl_procs.py -f src/mapi/glapi/gen/gl_and_es_API.xml Traceback (most recent call last): File string, line 1, in module NameError: name 'src' is not

[Mesa-dev] [Bug 76960] NameError: name 'src' is not defined

2014-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76960 --- Comment #3 from Brian Paul bri...@vmware.com --- Looks like this fixes it for me: diff --git a/src/mapi/glapi/gen/SConscript b/src/mapi/glapi/gen/SConscript index 4d827b0..e4abe90 100644 --- a/src/mapi/glapi/gen/SConscript +++

Re: [Mesa-dev] [PATCH 0/6] Some glapi clean-up releated to GLES

2014-04-02 Thread Ian Romanick
On 03/31/2014 02:48 PM, Ian Romanick wrote: On 03/27/2014 04:10 PM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: Tomorrow or Friday I'm going to send out the last of the GL_ARB_separate_shader_objects patches. Shortly after that, I will send out patches to enable

[Mesa-dev] [Bug 76960] NameError: name 'src' is not defined

2014-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76960 --- Comment #4 from Ian Romanick i...@freedesktop.org --- Oh dear. The -c is in the wrong place. It should go on the other side of $SCRIPT. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [PATCH] glapi: Fix scons build

2014-04-02 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Put the -c in the correct place (and match Makefile.am). Signed-off-by: Ian Romanick ian.d.roman...@intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76960 Cc: Vinson Lee v...@freedesktop.org --- src/mapi/glapi/gen/SConscript | 2 +- 1

Re: [Mesa-dev] [PATCH] glx: Do not advertise buffer_age on dri2

2014-04-02 Thread Ian Romanick
On 03/30/2014 02:36 PM, Adel Gadllah wrote: Previously GLX_EXT_buffer_age has always been advertised as supported because both client_glx_support and client_glx_only where set. So it did not matter that direct_support is only set when running dri3 and we ended up always advertising it. Fix

Re: [Mesa-dev] [PATCH] glapi: Fix scons build

2014-04-02 Thread Brian Paul
On 04/02/2014 01:30 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Put the -c in the correct place (and match Makefile.am). Signed-off-by: Ian Romanick ian.d.roman...@intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76960 Cc: Vinson Lee v...@freedesktop.org

Re: [Mesa-dev] DaibloIII: radeon: mmap failed, errno: 12

2014-04-02 Thread Marek Olšák
This is a known bug. See: https://bugs.freedesktop.org/show_bug.cgi?id=74868#c14 Marek On Wed, Apr 2, 2014 at 12:30 AM, Mike Mestnik che...@mikemestnik.net wrote: http://bitly.com/1ibsC0y What debugging steps are next? There is no BT because the application exits cleanly.

Re: [Mesa-dev] [PATCH] docs: Add note about updating tests to dev info

2014-04-02 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glapi: Fix make check

2014-04-02 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com /me puts a paper bag on his head and sits in the corner. This was supposed to be included in 5a68f731, which added glPointSizePointerOES back to the list of functions exposed by libGLESv1_CM. It looks like it was an uncommitted change in my tree when

Re: [Mesa-dev] Gallium docs online builds

2014-04-02 Thread Ilia Mirkin
On Mon, Mar 31, 2014 at 12:43 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Hi everyone, I've set up a readthedocs.org build to point at the gallium docs: http://gallium.readthedocs.org/en/latest/ I didn't find any publicly available built docs otherwise (except some rather outdated

Re: [Mesa-dev] [PATCH] glapi: Fix make check

2014-04-02 Thread Matt Turner
I should have caught it too. Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/4] glapi: Fix build break in 'make check' on non-shared-glapi builds

2014-04-02 Thread Dieter Nützel
Am 02.04.2014 08:12, schrieb Timothy Arceri: On Wed, 2014-04-02 at 00:56 +0200, Dieter Nützel wrote: Hello Ian, hello Timothy, does this fix the regression introduced with commit fb78fa58? [Mesa-dev] Mesa git (r600g): OpenGL Error(GL_INVALID_OPERATION): initTexture2D (bisected)

Re: [Mesa-dev] [PATCH 2/4] glapi: Fix build break in 'make check' on non-shared-glapi builds

2014-04-02 Thread Ian Romanick
On 04/02/2014 03:43 PM, Dieter Nützel wrote: Am 02.04.2014 08:12, schrieb Timothy Arceri: On Wed, 2014-04-02 at 00:56 +0200, Dieter Nützel wrote: Hello Ian, hello Timothy, does this fix the regression introduced with commit fb78fa58? [Mesa-dev] Mesa git (r600g): OpenGL

Re: [Mesa-dev] [PATCH 2/4] glapi: Fix build break in 'make check' on non-shared-glapi builds

2014-04-02 Thread Dieter Nützel
Am 03.04.2014 01:19, schrieb Ian Romanick: On 04/02/2014 03:43 PM, Dieter Nützel wrote: Am 02.04.2014 08:12, schrieb Timothy Arceri: On Wed, 2014-04-02 at 00:56 +0200, Dieter Nützel wrote: Hello Ian, hello Timothy, does this fix the regression introduced with commit fb78fa58? [Mesa-dev]

Re: [Mesa-dev] [PATCH 13/19] linker: Modify cross_validate_outputs_to_inputs to match using explicit locations

2014-04-02 Thread Cody Northrop
I applied a fix locally for the problem Olv pointed out and tested the patches. Running into a problem with the linker code when a geometry shader has location layout qualifiers for both inputs and outputs. It falls into the assign_varying_locations() scenario that has a producer but no

Re: [Mesa-dev] [PATCH 1/7] i965: Mark is_tex() and friends as const.

2014-04-02 Thread Anuj Phogat
On Mon, Mar 31, 2014 at 10:16 AM, Matt Turner matts...@gmail.com wrote: --- src/mesa/drivers/dri/i965/brw_shader.cpp | 10 +- src/mesa/drivers/dri/i965/brw_shader.h | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/4] glapi: Fix build break in 'make check' on non-shared-glapi builds

2014-04-02 Thread Timothy Arceri
On Thursday, 3 April 2014 10:33 AM, Dieter Nützel die...@nuetzel-hh.de wrote: He's shipping a prebuilt .a???  Madness! It seems so ;-( Is there source code for FreeImage included? Can't find any. hmmm... its an external library so you need to look outside the project ;) Anyway looks like

Re: [Mesa-dev] [PATCH 2/4] glapi: Fix build break in 'make check' on non-shared-glapi builds

2014-04-02 Thread Dieter Nützel
Am 03.04.2014 01:19, schrieb Ian Romanick: On 04/02/2014 03:43 PM, Dieter Nützel wrote: Am 02.04.2014 08:12, schrieb Timothy Arceri: On Wed, 2014-04-02 at 00:56 +0200, Dieter Nützel wrote: Hello Ian, hello Timothy, does this fix the regression introduced with commit fb78fa58? [Mesa-dev]

Re: [Mesa-dev] [PATCH 2/4] glapi: Fix build break in 'make check' on non-shared-glapi builds

2014-04-02 Thread Ian Romanick
On 04/02/2014 06:13 PM, Dieter Nützel wrote: Am 03.04.2014 01:19, schrieb Ian Romanick: On 04/02/2014 03:43 PM, Dieter Nützel wrote: Am 02.04.2014 08:12, schrieb Timothy Arceri: On Wed, 2014-04-02 at 00:56 +0200, Dieter Nützel wrote: Hello Ian, hello Timothy, does this fix the regression

[Mesa-dev] [PATCH] Added Diag Handler to receive LLVM Error messages

2014-04-02 Thread Tom Stellard
From: Darren Powell darren.pow...@amd.com --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 34 --- src/gallium/drivers/radeonsi/si_shader.c | 12 +++--- src/gallium/drivers/radeonsi/si_state.c | 2 ++ 3 files changed, 42 insertions(+), 6 deletions(-)

Re: [Mesa-dev] [PATCH] glapi: Fix scons build

2014-04-02 Thread Vinson Lee
On Wed, Apr 2, 2014 at 12:30 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Put the -c in the correct place (and match Makefile.am). Signed-off-by: Ian Romanick ian.d.roman...@intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76960

[Mesa-dev] [Bug 76976] New: [llvmpipe] lp_rast.c:165:lp_rast_clear_color: Assertion `util_format_is_pure_uint(format)' failed.

2014-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76976 Priority: medium Bug ID: 76976 CC: bri...@vmware.com, jfons...@vmware.com, srol...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe]

[Mesa-dev] [PATCH v2] automake: don't enable -Wl, --no-undefined on OpenBSD

2014-04-02 Thread Jonathan Gray
OpenBSD does not have DT_NEEDED entries for libc by design, over concerns how the symbols would be referenced after changing the major version of the library. So avoid -no-undefined checks on OpenBSD as they will fail. v2: don't include the -no-undefined libtool option in the variable and

Re: [Mesa-dev] [PATCH 1/4] xa: handle solid-fill src/mask

2014-04-02 Thread Thomas Hellstrom
On 04/01/2014 05:04 PM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Add support to property handle solid-fill src and/or mask. Without this we fallback to sw a lot for common things like text rendering. Signed-off-by: Rob Clark robcl...@freedesktop.org ---

[Mesa-dev] [PATCH v3] egl/dri2: use drm macros to construct device name

2014-04-02 Thread Jonathan Gray
Don't hardcode /dev/dri/card0 but instead use the drm macros which allows the correct /dev/drm0 device to be opened on OpenBSD. v2: use snprintf and fallback to /dev/dri/card0 v3: check for snprintf truncation Signed-off-by: Jonathan Gray j...@jsg.id.au --- src/egl/drivers/dri2/platform_drm.c |