[Mesa-dev] [Bug 80836] [llvmpipe] [softpipe] piglit incorrect-in-layout-qualifier-repeated-prim.geom regression

2014-07-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80836 Samuel Iglesias sigles...@igalia.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] glsl/glcpp: Correctly handle various flavors of newlines

2014-07-03 Thread Carl Worth
This small series expands the glcpp-test test suite to be able to test all variations of newlines as allowed by the GLSL specification. It then fixes 4 bugs exposed by that testing until the entire test suite can pass with each of the 4 allowed newline variations. The new testing is not yet

[Mesa-dev] [PATCH 5/5] glsl/glcpp: Fix glcpp-test to correctly extract test-specific arguments

2014-07-03 Thread Carl Worth
The (optional) test-specific command-line arguments to be passed to glcpp are embedded within the source files of some tests, and glcpp-test uses grep to extract them. Of course, grep is line-based and looks for the native line-separator to determine line boundaries. So, for files using

[Mesa-dev] [PATCH 1/5] glsl/glcpp: Add test script for testing various line-termination characters

2014-07-03 Thread Carl Worth
The GLSL specification has a very broad definition of what is a newline. Namely, it can be the carriage-return character, '\r', the newline character, '\n', or any combination of the two, (though in combination, the two are treated as a single newline). Here, we add a new test-runner,

[Mesa-dev] [PATCH 4/5] glsl/glcpp: Fix line-continuation code to handle multiple newline flavors

2014-07-03 Thread Carl Worth
Sometimes the newline separator is a single character, and sometimes it is two characters. Before we can fold away and line-continuation backslashes, we identify the flavor of line separator that is in use. With this identified, we then correctly search for backslashes followed immediately by the

[Mesa-dev] [PATCH 3/5] glsl/glcpp: Don't include any newline characters in #error token

2014-07-03 Thread Carl Worth
Some tests were failing because the message printed by #error was including a '\r' character from the source file in its output. This is easily avoided by fixing the regular expression for #error to never include any of the possible newline characters, (neither '\r' nor '\n'). With this commit 2

[Mesa-dev] [PATCH 2/5] glsl/glcpp: Treat CR+LF pair as a single newline

2014-07-03 Thread Carl Worth
The GLSL specification says that either carriage-return, line-feed, or both together can be used to terminate lines. Further, it says that when used together, the pair of terminators shall be interpreted as a single line. This final requirement has not been respected by glcpp up until now, (it

Re: [Mesa-dev] [PATCH v2 5/5] meta: Add a meta implementation of GL_ARB_clear_texture

2014-07-03 Thread Pohjolainen, Topi
On Wed, Jul 02, 2014 at 07:00:06PM +0100, Neil Roberts wrote: Adds an implementation of the ClearTexSubImage driver entry point that tries to set up an FBO to render to the texture and then calls glClear with a scissor to perform the actual clear. If an FBO can't be created for the texture

Re: [Mesa-dev] [PATCH 4/6] i965/gen7: Don't allocate hiz miptree structure

2014-07-03 Thread Pohjolainen, Topi
On Wed, Jul 02, 2014 at 12:33:16PM -0700, Jordan Justen wrote: On Wed, Jul 2, 2014 at 5:39 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Tue, Jul 01, 2014 at 04:53:06PM -0700, Jordan Justen wrote: We now skip allocating a hiz miptree for gen7. Instead, we calculate the

[Mesa-dev] [PATCH 2/9] i965: check malloc return value in intel_resolve_map_set()

2014-07-03 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/intel_resolve_map.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_resolve_map.c b/src/mesa/drivers/dri/i965/intel_resolve_map.c index bf6bcf2..bb45231 100644

[Mesa-dev] [PATCH 4/9] glsl: Check calloc return value in link_intrastage_shaders()

2014-07-03 Thread Juha-Pekka Heikkila
Check calloc return value while adding build-in functions. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/linker.cpp | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index d588bc6..2f004f1

[Mesa-dev] [PATCH 3/9] i965: Avoid null access in intelMakeCurrent()

2014-07-03 Thread Juha-Pekka Heikkila
separate two null checks connected with to their own if branches. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/brw_context.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c

[Mesa-dev] [PATCH 0/9] Klocwork patches again

2014-07-03 Thread Juha-Pekka Heikkila
i965: Avoid null access in intelMakeCurrent() I was a bit iffy if its the same behavior which I replaced. i965: in set_read_rb_tex_image() check _mesa_meta_bind_rb_as_tex_image() did succeed - I tried to follow Topi's suggestion. I did not go touching brw_meta_updownsample() here, it is left

[Mesa-dev] [PATCH 9/9] mesa/main: Check allocations success in _mesa_one_time_init_extension_overrides()

2014-07-03 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/extensions.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 92e3f0d..cd89e8f 100644 --- a/src/mesa/main/extensions.c +++

[Mesa-dev] [PATCH 1/9] i965: in set_read_rb_tex_image() check _mesa_meta_bind_rb_as_tex_image() did succeed

2014-07-03 Thread Juha-Pekka Heikkila
Check if _mesa_meta_bind_rb_as_tex_image() did give the texture. If no texture was given there is already either GL_INVALID_VALUE or GL_OUT_OF_MEMORY error set in context. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/common/meta_blit.c | 10

[Mesa-dev] [PATCH 6/9] glsl: Check realloc return value in ir_function::matching_signature()

2014-07-03 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/ir_function.cpp | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/glsl/ir_function.cpp b/src/glsl/ir_function.cpp index 7d6c2f4..04ab5ab 100644 --- a/src/glsl/ir_function.cpp +++

[Mesa-dev] [PATCH 5/9] loader: Check dlsym() did not fail in libudev_get_device_name_for_fd()

2014-07-03 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/loader/loader.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/loader/loader.c b/src/loader/loader.c index 47e1f58..2205a9c 100644 --- a/src/loader/loader.c +++ b/src/loader/loader.c @@ -594,6 +594,9 @@

[Mesa-dev] [PATCH 8/9] i965: Check after malloc success in intel_miptree_alloc_hiz()

2014-07-03 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 2ab0faa..30030d1 100644

[Mesa-dev] [PATCH 7/9] i965: Avoid null access in fs_generator::generate_code()

2014-07-03 Thread Juha-Pekka Heikkila
Avoid null access while printing debug infos. On the same go change local variable name to avoid confusion because there already is class member with same name. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 8 ++-- 1 file

Re: [Mesa-dev] [PATCH demos 0/3] demos release plan and glxinfo: Print more limits

2014-07-03 Thread Andreas Boll
2014-07-02 21:59 GMT+02:00 Brian Paul bri...@vmware.com: On 07/02/2014 01:04 PM, Andreas Boll wrote: I'd like to make a new demos release on Friday, July 4th. The last release was on February 24th, 2013. Additionally this release is needed to fix the build with mesa 10.2. (fdo#78101) Any

Re: [Mesa-dev] [PATCH demos 0/3] demos release plan and glxinfo: Print more limits

2014-07-03 Thread Andreas Boll
2014-07-03 3:09 GMT+02:00 Ilia Mirkin imir...@alum.mit.edu: On Wed, Jul 2, 2014 at 3:04 PM, Andreas Boll andreas.boll@gmail.com wrote: I'd like to make a new demos release on Friday, July 4th. The last release was on February 24th, 2013. Additionally this release is needed to fix the

Re: [Mesa-dev] [PATCH demos 0/3] demos release plan and glxinfo: Print more limits

2014-07-03 Thread Andreas Boll
2014-07-03 7:39 GMT+02:00 Steven Newbury st...@snewbury.org.uk: On Wed, 2014-07-02 at 21:04 +0200, Andreas Boll wrote: I'd like to make a new demos release on Friday, July 4th. The last release was on February 24th, 2013. Additionally this release is needed to fix the build with mesa 10.2.

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Boris BREZILLON
Hello Giovanni, I have recently been working on a DRM/KMS driver which does not support OpenGL rendering (it only provides plane composition functionalities): [1]. If I understand correctly you patch series might solve some of the issues I am facing. I'm trying to get wayland working with HW

[Mesa-dev] [PATCH] st/xa: Don't close the drm fd on failure

2014-07-03 Thread Thomas Hellstrom
If XA fails to initialize with pipe_loader enabled, the pipe_loader's cleanup function will close the drm file descriptor. That's pretty bad because the file descriptor will probably be the X server driver's only connection to drm. Temporarily solve this by dup()'ing the file descriptor before

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Pekka Paalanen
On Thu, 3 Jul 2014 10:48:26 +0200 Boris BREZILLON boris.brezil...@free-electrons.com wrote: Hello Giovanni, I have recently been working on a DRM/KMS driver which does not support OpenGL rendering (it only provides plane composition functionalities): [1]. If I understand correctly you

[Mesa-dev] [PATCH] st/xa: Don't close the drm fd on failure v2

2014-07-03 Thread Thomas Hellstrom
If XA fails to initialize with pipe_loader enabled, the pipe_loader's cleanup function will close the drm file descriptor. That's pretty bad because the file descriptor will probably be the X server driver's only connection to drm. Temporarily solve this by dup()'ing the file descriptor before

Re: [Mesa-dev] [PATCH v2 1/5] mesa/main: add ARB_clear_texture entrypoints

2014-07-03 Thread Neil Roberts
Ilia Mirkin imir...@alum.mit.edu writes: I believe what this is saying is akin to Danger! There is a hole from 145 to 146. Since ARB_clear_texture is 145, the hole is now just 146 (ARB_enhanced_layouts)... Whereas your comments indicate the numbers of the actually-listed extensions. Note

Re: [Mesa-dev] [PATCH] st/xa: Don't close the drm fd on failure v2

2014-07-03 Thread Jakob Bornecrantz
- Original Message - If XA fails to initialize with pipe_loader enabled, the pipe_loader's cleanup function will close the drm file descriptor. That's pretty bad because the file descriptor will probably be the X server driver's only connection to drm. Temporarily solve this by

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Boris BREZILLON
On Thu, 3 Jul 2014 11:14:48 +0200 Giovanni Campagna scampa.giova...@gmail.com wrote: 2014-07-03 10:48 GMT+02:00 Boris BREZILLON boris.brezil...@free-electrons.com: Hello Giovanni, I have recently been working on a DRM/KMS driver which does not support OpenGL rendering (it only provides

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Boris BREZILLON
On Thu, 3 Jul 2014 12:24:44 +0300 Pekka Paalanen ppaala...@gmail.com wrote: On Thu, 3 Jul 2014 10:48:26 +0200 Boris BREZILLON boris.brezil...@free-electrons.com wrote: Hello Giovanni, I have recently been working on a DRM/KMS driver which does not support OpenGL rendering (it only

[Mesa-dev] Another important XA patch

2014-07-03 Thread Thomas Hellstrom
Hi, Carl, Patch st/xa: Don't close the drm fd on failure v2 causes some conflicts when backported to 10.2. Let me know if you need help resolving them, or if you want me to push a backported version to 10.2. Thanks, Thomas ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 4/5] r600g: allow vs to write to gl_ViewportIndex

2014-07-03 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Wed, Jul 2, 2014 at 10:30 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Tested-by: Tobias Droste tdro...@gmx.de --- In addition to the existing ARB_fragment_layer_viewport piglits passing and

Re: [Mesa-dev] [PATCH 5/5] mesa/st: enable AMD_vertex_shader_viewport_index

2014-07-03 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Renaming the cap to include VIEWPORT would not be a bad idea. Marek On Wed, Jul 2, 2014 at 10:30 PM, Ilia Mirkin imir...@alum.mit.edu wrote: The assumption is that any driver capable of emitting layer from the vertex shader and supporting viewports

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Pekka Paalanen
On Thu, 3 Jul 2014 12:10:36 +0200 Boris BREZILLON boris.brezil...@free-electrons.com wrote: On Thu, 3 Jul 2014 12:24:44 +0300 Pekka Paalanen ppaala...@gmail.com wrote: On Thu, 3 Jul 2014 10:48:26 +0200 Boris BREZILLON boris.brezil...@free-electrons.com wrote: Hello Giovanni,

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Boris BREZILLON
On Thu, 3 Jul 2014 13:49:06 +0300 Pekka Paalanen ppaala...@gmail.com wrote: On Thu, 3 Jul 2014 12:10:36 +0200 Boris BREZILLON boris.brezil...@free-electrons.com wrote: On Thu, 3 Jul 2014 12:24:44 +0300 Pekka Paalanen ppaala...@gmail.com wrote: On Thu, 3 Jul 2014 10:48:26 +0200

Re: [Mesa-dev] [PATCH 1/9] i965: in set_read_rb_tex_image() check _mesa_meta_bind_rb_as_tex_image() did succeed

2014-07-03 Thread Pohjolainen, Topi
On Thu, Jul 03, 2014 at 11:13:11AM +0300, Juha-Pekka Heikkila wrote: Check if _mesa_meta_bind_rb_as_tex_image() did give the texture. If no texture was given there is already either GL_INVALID_VALUE or GL_OUT_OF_MEMORY error set in context. Signed-off-by: Juha-Pekka Heikkila

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Pekka Paalanen
On Thu, 3 Jul 2014 14:15:34 +0200 Boris BREZILLON boris.brezil...@free-electrons.com wrote: On Thu, 3 Jul 2014 13:49:06 +0300 Pekka Paalanen ppaala...@gmail.com wrote: On Thu, 3 Jul 2014 12:10:36 +0200 Boris BREZILLON boris.brezil...@free-electrons.com wrote: On Thu, 3 Jul 2014

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Boris BREZILLON
On Thu, 3 Jul 2014 15:46:14 +0300 Pekka Paalanen ppaala...@gmail.com wrote: On Thu, 3 Jul 2014 14:15:34 +0200 Boris BREZILLON boris.brezil...@free-electrons.com wrote: On Thu, 3 Jul 2014 13:49:06 +0300 Pekka Paalanen ppaala...@gmail.com wrote: On Thu, 3 Jul 2014 12:10:36 +0200

Re: [Mesa-dev] [PATCH 7/9] i965: Avoid null access in fs_generator::generate_code()

2014-07-03 Thread Pohjolainen, Topi
On Thu, Jul 03, 2014 at 11:13:17AM +0300, Juha-Pekka Heikkila wrote: Avoid null access while printing debug infos. On the same go change local variable name to avoid confusion because there already is class member with same name. Signed-off-by: Juha-Pekka Heikkila

Re: [Mesa-dev] [PATCH] glsl: fix duplicated layout qualifier detection for GS

2014-07-03 Thread Samuel Iglesias Gonsálvez
On Wed, 2014-07-02 at 12:47 -0700, Jordan Justen wrote: Reviewed-by: Jordan Justen jordan.l.jus...@intel.com I don't have commit access to the repository. Would you mind pushing this patch to master? Sam signature.asc Description: This is a digitally signed message part

[Mesa-dev] [PATCH 1/2] glxinfo: remove query of GL_MAX_VERTEX_ATTRIB_STRIDE

2014-07-03 Thread Brian Paul
This is not part of the GL_ARB_vertex_attrib_binding extension. It's part of OpenGL 4.4. Fixes compilation failure if glext.h doesn't have the GL 4.4 #defines. --- src/xdemos/glinfo_common.c |1 - 1 file changed, 1 deletion(-) diff --git a/src/xdemos/glinfo_common.c

[Mesa-dev] [PATCH 2/2] glxinfo: add query for OpenGL 4.4 GL_MAX_VERTEX_ATTRIB_STRIDE

2014-07-03 Thread Brian Paul
And add support for qualifying a limit query with an OpenGL version instead of an extension string. --- src/xdemos/glinfo_common.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index

Re: [Mesa-dev] [PATCH 7/9] i965: Avoid null access in fs_generator::generate_code()

2014-07-03 Thread Juha-Pekka Heikkila
On 03.07.2014 16:26, Pohjolainen, Topi wrote: On Thu, Jul 03, 2014 at 11:13:17AM +0300, Juha-Pekka Heikkila wrote: Avoid null access while printing debug infos. On the same go change local variable name to avoid confusion because there already is class member with same name. Signed-off-by:

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-03 Thread Tom Stellard
On Thu, Jul 03, 2014 at 01:12:07AM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, Jun 26, 2014 at 04:15:39PM +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: v2: - Report correct values for

Re: [Mesa-dev] [PATCH] radeon/llvm: Allocate space for kernel metadata operands

2014-07-03 Thread Tom Stellard
On Wed, Jul 02, 2014 at 04:34:24PM -0500, Aaron Watry wrote: Previously, we were assuming that kernel metadata nodes only had 1 operand. Kernels which have attributes can have more than 1, e.g.: !0 = metadata !{void (i32 addrspace(1)*)* @testKernel, metadata !1} !1 = metadata !{metadata

[Mesa-dev] [PATCH 6/5] gallium: rename PIPE_CAP_TGSI_VS_LAYER to also have _VIEWPORT

2014-07-03 Thread Ilia Mirkin
Now that this cap is used to determine the availability of both, adjust its name to reflect the new reality. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/auxiliary/util/u_blitter.c | 2 +- src/gallium/docs/source/screen.rst | 6 --

Re: [Mesa-dev] [PATCH 6/5] gallium: rename PIPE_CAP_TGSI_VS_LAYER to also have _VIEWPORT

2014-07-03 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger srol...@vmware.com Am 03.07.2014 17:17, schrieb Ilia Mirkin: Now that this cap is used to determine the availability of both, adjust its name to reflect the new reality. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu ---

Re: [Mesa-dev] [PATCH] gallium: pass in per-sample interpolation qualifier

2014-07-03 Thread Roland Scheidegger
Am 03.07.2014 03:19, schrieb Ilia Mirkin: On Wed, Jul 2, 2014 at 4:03 PM, Roland Scheidegger srol...@vmware.com wrote: Actually on second thought, because centroid and sample are mutually exclusive (or more generally, the Interpolate member determines how interpolation is done, whereas these

Re: [Mesa-dev] [PATCH] radeon/llvm: Allocate space for kernel metadata operands

2014-07-03 Thread Aaron Watry
On Thu, Jul 3, 2014 at 9:56 AM, Tom Stellard t...@stellard.net wrote: On Wed, Jul 02, 2014 at 04:34:24PM -0500, Aaron Watry wrote: Previously, we were assuming that kernel metadata nodes only had 1 operand. Kernels which have attributes can have more than 1, e.g.: !0 = metadata !{void (i32

Re: [Mesa-dev] [PATCH] radeon/llvm: Allocate space for kernel metadata operands

2014-07-03 Thread Alex Deucher
On Thu, Jul 3, 2014 at 11:46 AM, Aaron Watry awa...@gmail.com wrote: On Thu, Jul 3, 2014 at 9:56 AM, Tom Stellard t...@stellard.net wrote: On Wed, Jul 02, 2014 at 04:34:24PM -0500, Aaron Watry wrote: Previously, we were assuming that kernel metadata nodes only had 1 operand. Kernels which

Re: [Mesa-dev] [PATCH 6/5] gallium: rename PIPE_CAP_TGSI_VS_LAYER to also have _VIEWPORT

2014-07-03 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Thu, Jul 3, 2014 at 5:17 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Now that this cap is used to determine the availability of both, adjust its name to reflect the new reality. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu ---

[Mesa-dev] [PATCH 1/2] R600/SI: fix shadow mapping for 1D and 2D array textures

2014-07-03 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com It was conflicting with def TEX_SHADOW_ARRAY, which also handles them. --- lib/Target/R600/R600Instructions.td | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Target/R600/R600Instructions.td b/lib/Target/R600/R600Instructions.td

[Mesa-dev] [PATCH] gallium: fix u_default_transfer_inline_write for textures

2014-07-03 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This doesn't fix any known issue. In fact, radeon drivers ignore all the discard flags for textures and implicitly do discard range for any write transfer. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/auxiliary/util/u_transfer.c | 4 ++-- 1 file

Re: [Mesa-dev] [PATCH] radeon/llvm: Allocate space for kernel metadata operands

2014-07-03 Thread Tom Stellard
On Thu, Jul 03, 2014 at 10:56:24AM -0400, Tom Stellard wrote: On Wed, Jul 02, 2014 at 04:34:24PM -0500, Aaron Watry wrote: Previously, we were assuming that kernel metadata nodes only had 1 operand. Kernels which have attributes can have more than 1, e.g.: !0 = metadata !{void (i32

Re: [Mesa-dev] [PATCH] radeon/llvm: Allocate space for kernel metadata operands\

2014-07-03 Thread Tom Stellard
On Thu, Jul 03, 2014 at 11:59:00AM -0400, Alex Deucher wrote: On Thu, Jul 3, 2014 at 11:46 AM, Aaron Watry awa...@gmail.com wrote: On Thu, Jul 3, 2014 at 9:56 AM, Tom Stellard t...@stellard.net wrote: On Wed, Jul 02, 2014 at 04:34:24PM -0500, Aaron Watry wrote: Previously, we were assuming

Re: [Mesa-dev] [PATCH] radeon/llvm: Allocate space for kernel metadata operands

2014-07-03 Thread Aaron Watry
On Thu, Jul 3, 2014 at 11:29 AM, Tom Stellard t...@stellard.net wrote: On Thu, Jul 03, 2014 at 10:56:24AM -0400, Tom Stellard wrote: On Wed, Jul 02, 2014 at 04:34:24PM -0500, Aaron Watry wrote: Previously, we were assuming that kernel metadata nodes only had 1 operand. Kernels which have

Re: [Mesa-dev] [PATCH] radeon/llvm: Allocate space for kernel metadata operands

2014-07-03 Thread Aaron Watry
On Thu, Jul 3, 2014 at 10:59 AM, Alex Deucher alexdeuc...@gmail.com wrote: Someone mentioned stability issues with cedar with the golden register kernel patch. Can you see if skipping the golden register setup helps? If so can you narrow down which registers are problematic? I'll give it a

Re: [Mesa-dev] [PATCH] radeon/llvm: Allocate space for kernel metadata operands

2014-07-03 Thread Tom Stellard
On Thu, Jul 03, 2014 at 11:55:25AM -0500, Aaron Watry wrote: On Thu, Jul 3, 2014 at 10:59 AM, Alex Deucher alexdeuc...@gmail.com wrote: Someone mentioned stability issues with cedar with the golden register kernel patch. Can you see if skipping the golden register setup helps? If so can

Re: [Mesa-dev] [PATCH] glsl: fix duplicated layout qualifier detection for GS

2014-07-03 Thread Jordan Justen
On 2014-07-03 07:18:42, Samuel Iglesias Gonsálvez wrote: On Wed, 2014-07-02 at 12:47 -0700, Jordan Justen wrote: Reviewed-by: Jordan Justen jordan.l.jus...@intel.com I don't have commit access to the repository. Would you mind pushing this patch to master? Pushed. Thanks for the patch!

[Mesa-dev] [PATCH 2/2] i965: Viewport extents print (don't push)

2014-07-03 Thread Ben Widawsky
Just to verify the code does what we want... --- src/mesa/drivers/dri/i965/gen8_viewport_state.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen8_viewport_state.c b/src/mesa/drivers/dri/i965/gen8_viewport_state.c index 2bf5fbb..cfbcb12 100644 ---

[Mesa-dev] [PATCH 1/2] i965: Viewport extents on gen8

2014-07-03 Thread Ben Widawsky
Viewport extents are a 3rd rectangle that defines which pixels get discarded as part of the rasterization process. This can potentially improve performance by reducing cache usage, and freeing up PS cycles. This will get hit if one's viewport is smaller than the full renderbuffer, and scissoring

[Mesa-dev] [PATCH v3 2/2] nv50/ir: Handle OP_CVT when folding constant expressions

2014-07-03 Thread Tobias Klausmann
Folding for conversions: F32/64-(U16/32, S16/32) and (U16/32, S16/32)-F32 No piglit regressions observed on nv50 and nvc0! Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 74 ++ 1 file changed, 74

[Mesa-dev] [PATCH v3 1/2] nv50/ir: Add support for the double Type to BuildUtil

2014-07-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- .../drivers/nouveau/codegen/nv50_ir_build_util.cpp | 17 + .../drivers/nouveau/codegen/nv50_ir_build_util.h| 2 ++ 2 files changed, 19 insertions(+) diff --git

[Mesa-dev] [PATCH] svga: Don't unnecessarily reemit BindGBShader commands v2

2014-07-03 Thread Thomas Hellstrom
The Linux winsys can no longer relocate shader code, so avoid reemitting BindGBShader commands. They are costly. v2: Correctly handle errors from SVGA3D_BindGBShader() Reported-by: Michael Banack bana...@vmware.com Signed-off-by: Thomas Hellstrom thellst...@vmware.com Tested-by: Brian Paul

[Mesa-dev] [PATCH] i915: Fix up intelInitScreen2 for DRI3

2014-07-03 Thread Adel Gadllah
Commit 442442026eb updated both i915 and i965 for DRI3 support, but one check in intelInitScreen2 was missed for i915 causing crashes when trying to use i915 with DRI3. So fix that up. Reported-by: Igor Gnatenko i.gnatenko.br...@gmail.com Tested-by: František Zatloukal

[Mesa-dev] [PATCH] svga: Don't unnecessarily reemit BindGBShader commands v2

2014-07-03 Thread Thomas Hellstrom
The Linux winsys can no longer relocate shader code, so avoid reemitting BindGBShader commands. They are costly. v2: Correctly handle errors from SVGA3D_BindGBShader() Reported-by: Michael Banack bana...@vmware.com Signed-off-by: Thomas Hellstrom thellst...@vmware.com Tested-by: Brian Paul

Re: [Mesa-dev] [PATCH 1/2] i965: Don't enable SOL statistics during meta operations.

2014-07-03 Thread Kenneth Graunke
On Wednesday, July 02, 2014 09:08:04 PM Kristian Høgsberg wrote: On Tue, Jul 1, 2014 at 5:25 PM, Kenneth Graunke kenn...@whitecape.org wrote: The GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN counter is not supposed to increment during glGenerateMipmap(). I don't think either counter is

[Mesa-dev] [PATCH] glsl/glcpp: Integrate recent glcpp-test-cr-lf test into make check

2014-07-03 Thread Carl Worth
Beyond just listing this in the TESTS variable in Makefile.am, only minor changes were needed to make this work. The primary issue is that the build system runs the test script from a different directory than the script itself. So we have to use the $srcdir variable to find the test input files.

[Mesa-dev] [PATCH] glsl/glcpp: Fix handling of commas that result from macro expansion

2014-07-03 Thread Carl Worth
Here is some additional stress testing of nested macros where the expansion of macros involves commas, (and whether those commas are interpreted as argument separators or not in subsequent function-like macro calls). Credit to the GCC documentation that directed my attention toward this issue:

Re: [Mesa-dev] [PATCH 2/9] i965: check malloc return value in intel_resolve_map_set()

2014-07-03 Thread Kenneth Graunke
On Thursday, July 03, 2014 11:13:12 AM Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/intel_resolve_map.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_resolve_map.c

[Mesa-dev] [PATCH] ff_fragment_shader: Access glsl_types directly.

2014-07-03 Thread Kenneth Graunke
Originally, we didn't have direct accessors for all of the GLSL types, so the only way to get at them was to use the symbol table. Now, we can just get at them directly, which is simpler and faster. --- src/mesa/main/ff_fragment_shader.cpp | 30 +++--- 1 file changed, 15

[Mesa-dev] [PATCH 1/2] radeonsi: properly implement texture opcodes that take an offset

2014-07-03 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Instead of using intr_name in lp_build_tgsi_action, this selects the names with a switch statement in the emit function. This allows emitting llvm.SI.sample for instructions without offsets and llvm.SI.image.sample.*.o otherwise. This depends on my LLVM

[Mesa-dev] [PATCH 2/2] radeonsi: fix texture fetches with derivatives for 1DArray and 3D textures

2014-07-03 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeonsi/si_shader.c | 34 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 335e43b..b4d4f22

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-03 Thread Francisco Jerez
Tom Stellard t...@stellard.net writes: On Thu, Jul 03, 2014 at 01:12:07AM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, Jun 26, 2014 at 04:15:39PM +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: v2: - Report correct

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add sampling of 4:2:2 subsampled textures

2014-07-03 Thread Andy Furniss
Andy Furniss wrote: Grigori Goronzy wrote: On 02.07.2014 22:18, Andy Furniss wrote: Before I knew how to get field sync to use my TVs deinterlacer I had to modify mesa so that I could use the vdpau de-interlacer(s), when I did this I noticed that 422 didn't work and looked the same as it does

Re: [Mesa-dev] [PATCH] ff_fragment_shader: Access glsl_types directly.

2014-07-03 Thread Ben Widawsky
Reviewed-by: Ben Widawsky b...@bwidawsk.net On Thu, Jul 03, 2014 at 02:47:14PM -0700, Kenneth Graunke wrote: Originally, we didn't have direct accessors for all of the GLSL types, so the only way to get at them was to use the symbol table. Now, we can just get at them directly, which is

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-03 Thread Tom Stellard
On Fri, Jul 04, 2014 at 12:28:20AM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, Jul 03, 2014 at 01:12:07AM +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, Jun 26, 2014 at 04:15:39PM +0200, Francisco Jerez wrote: Tom

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add sampling of 4:2:2 subsampled textures

2014-07-03 Thread Andy Furniss
Andy Furniss wrote: Andy Furniss wrote: Grigori Goronzy wrote: On 02.07.2014 22:18, Andy Furniss wrote: Before I knew how to get field sync to use my TVs deinterlacer I had to modify mesa so that I could use the vdpau de-interlacer(s), when I did this I noticed that 422 didn't work and

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Don't use derived vertex state in api_arrayelt.c

2014-07-03 Thread Carl Worth
Fredrik Höglund fred...@kde.org writes: Cc: 10.1 mesa-sta...@lists.freedesktop.org (And 10.2 as pushed to master) Hi Fredrik, I helped prod you into pushing this patch to master, which brought it more directly into my view as a candidate for the 10.2 branch. Now that I'm taking a closer look

Re: [Mesa-dev] OpenGL on Wayland

2014-07-03 Thread Kalrish Bäakjen
On Wed, Jul 2, 2014 at 6:37 PM, Thomas Daede daede...@umn.edu wrote: What Mesa version are you using? IIRC OpenGL 3.3 is only supported in llvmpipe in mesa 10.3 and newer. Using MESA_GL_VERISON_OVERRIDE just fakes the version string, it doesn't change what functions you can actually link to.

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Giovanni Campagna
2014-07-03 10:48 GMT+02:00 Boris BREZILLON boris.brezil...@free-electrons.com: Hello Giovanni, I have recently been working on a DRM/KMS driver which does not support OpenGL rendering (it only provides plane composition functionalities): [1]. If I understand correctly you patch series might

Re: [Mesa-dev] Another important XA patch

2014-07-03 Thread Carl Worth
Thomas Hellstrom thellst...@vmware.com writes: Patch st/xa: Don't close the drm fd on failure v2 causes some conflicts when backported to 10.2. Let me know if you need help resolving them, or if you want me to push a backported version to 10.2. Thanks for the heads-up, Thomas. The conflict

[Mesa-dev] Patches prepped for 10.2.3 release

2014-07-03 Thread Carl Worth
I've just made a pass over the patches nominated for inclusion in the 10.2 branch. The results can be seen here: http://cworth.org/~cworth/mesa-stable-queue/ After a bit more testing, I expect to push the queued patches to the 10.2 branch. Then I'll likely let this sit over the weekend

[Mesa-dev] What are some good beginner's tasks for Mesa?

2014-07-03 Thread Darius Goad
Hello. I'm trying to get my feet wet with Mesa, and I was wondering what some good tasks for me would be. Thanks again. - Darius Goad ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] What are some good beginner's tasks for Mesa?

2014-07-03 Thread Ilia Mirkin
On Thu, Jul 3, 2014 at 11:33 PM, Darius Goad alegen...@gmail.com wrote: Hello. I'm trying to get my feet wet with Mesa, and I was wondering what some good tasks for me would be. Thanks again. Take a look at http://wiki.freedesktop.org/dri/NewbieProjects/ Also depending on the hardware you

[Mesa-dev] [Bug 80266] Many instances of 131, which is undefined in C99

2014-07-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80266 --- Comment #13 from Vittorio zec...@gmail.com --- More issues: u_pack_color.h:365 uc-ui = (a 24) | (r 16) | (g 8) | b; should be uc-ui = ((unsigned int)a 24) | (r 16) | (g 8) | b; m_matrix.c line 1156 #define ONE(x) (1(x+16)) should be

[Mesa-dev] [Bug 80888] New: draw_cliptest_tmp.h computes zero/zero It is better to use NAN macro

2014-07-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80888 Priority: medium Bug ID: 80888 Assignee: mesa-dev@lists.freedesktop.org Summary: draw_cliptest_tmp.h computes zero/zero It is better to use NAN macro Severity: normal

[Mesa-dev] [Bug 80889] New: draw_pipe_clip.c division by zero in interp

2014-07-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80889 Priority: medium Bug ID: 80889 Assignee: mesa-dev@lists.freedesktop.org Summary: draw_pipe_clip.c division by zero in interp Severity: normal Classification: Unclassified