Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

So... can I get a review on this? It's the last bit needed for ARB_gs5 (well, except for the actual setting of the extension bit to 1) The only additional change I have in my local version is that instead of + inst->sampler_array_size = + ir->sampler->as_dereference_array() +

Re: [Mesa-dev] [PATCH] clover: support CL_PROGRAM_BINARY_TYPE query

On Fri, Aug 8, 2014 at 10:10 PM, EdB wrote: > --- > src/gallium/state_trackers/clover/api/program.cpp | 3 +++ > src/gallium/state_trackers/clover/core/program.cpp | 8 > src/gallium/state_trackers/clover/core/program.hpp | 1 + > 3 files changed, 12 insertions(+) > > diff --git a/src/g

Re: [Mesa-dev] [PATCH] configure: check for dladdr via AC_CHECK_FUNC/AC_CHECK_LIB

This problem happen when gcc is compiled with LTO support (even if is not used). Also in some manpage (I do not remember) is written that it depends on order of arguments for compiler/linker Btw, you can add my Signed-off-by to commit message. On Friday 08 August 2014 19:58:07 Ilia Mirkin wrote

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

On Wed, Aug 6, 2014 at 6:29 PM, Marek Olšák wrote: > What IR? A flatland GLSL IR? A replacement for Mesa IR? Something else? It's a flatland IR, similar to TGSI/Direct3D style with enough GLSL IR-like stuff to get existing things working now and enable us to eventually do linking in it (so we can

[Mesa-dev] [Bug 79470] [llvmpipe] src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c:2343:emit_fetch_texels: Assertion `0' failed.

https://bugs.freedesktop.org/show_bug.cgi?id=79470 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions > viewport width/height are not displayed

https://bugs.freedesktop.org/show_bug.cgi?id=80183 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 7/8] mesa: fix assertion in _mesa_drawbuffers()

Am 08.08.2014 23:20, schrieb Brian Paul: > Fixes failed assertion when _mesa_update_draw_buffers() was called > with GL_DRAW_BUFFER == GL_FRONT_AND_BACK. The piglit gl30basic hit > this. > > Cc: "10.2" > --- > src/mesa/main/buffers.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(

Re: [Mesa-dev] [PATCH 8/8] mesa: simplify _mesa_update_draw_buffers()

Am 08.08.2014 23:20, schrieb Brian Paul: > There's no need to copy the array of DrawBuffer enums to a temp array. > --- > src/mesa/main/buffers.c |9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c > index 6b4fac9.

[Mesa-dev] [PATCH] clover: support CL_PROGRAM_BINARY_TYPE query

--- src/gallium/state_trackers/clover/api/program.cpp | 3 +++ src/gallium/state_trackers/clover/core/program.cpp | 8 src/gallium/state_trackers/clover/core/program.hpp | 1 + 3 files changed, 12 insertions(+) diff --git a/src/gallium/state_trackers/clover/api/program.cpp b/src/galliu

Re: [Mesa-dev] [PATCH 3/8] mesa: use PRIu64 for printing 64-bit uints

Am 09.08.2014 02:24, schrieb Matt Turner: >> Other than that, is there some recommendation wrt whitespace around that >> ugly format specifier? Some places seem to use it, some don't. Either >> way it's ugly dunno which one is worse. Would be nice though if we'd be >> consistent imho. > > I've alw

Re: [Mesa-dev] [PATCH 3/8] mesa: use PRIu64 for printing 64-bit uints

> Other than that, is there some recommendation wrt whitespace around that > ugly format specifier? Some places seem to use it, some don't. Either > way it's ugly dunno which one is worse. Would be nice though if we'd be > consistent imho. I've always seen spaces between the quotes and the specifi

Re: [Mesa-dev] [PATCH 6/8] mesa: whitespace, 80-column wrapping in program.c

Am 08.08.2014 23:20, schrieb Brian Paul: > --- > src/mesa/program/program.c | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c > index 9886b75..ef5bf6b 100644 > --- a/src/mesa/program/program.c >

Re: [Mesa-dev] [PATCH] i965/cse: Don't eliminate instructions with side-effects

On Friday, August 08, 2014 05:05:35 PM Jason Ekstrand wrote: > On Fri, Aug 8, 2014 at 4:58 PM, Kenneth Graunke wrote: > > It's also worth noting in your commit message that this is not actually > > fixing a current bug, but rather preventing a regression once your patches > > that convert atomics t

Re: [Mesa-dev] [PATCH 3/8] mesa: use PRIu64 for printing 64-bit uints

Am 08.08.2014 23:20, schrieb Brian Paul: > Silences MinGW warnings: > warning: unknown conversion type character ‘l’ in format [-Wformat] > warning: too many arguments for format [-Wformat-extra-args] > --- > src/mesa/main/bufferobj.c | 33 + > src/mesa/main/var

Re: [Mesa-dev] [PATCH] i965/cse: Don't eliminate instructions with side-effects

On Fri, Aug 8, 2014 at 4:58 PM, Kenneth Graunke wrote: > On Friday, August 08, 2014 02:42:27 PM Jason Ekstrand wrote: >> In particular, this caused problems where atomics operations were getting >> eliminated. >> >> Signed-off-by: Jason Ekstrand >> --- >> src/mesa/drivers/dri/i965/brw_fs_cse.cpp

Re: [Mesa-dev] [PATCH] i965/cse: Don't eliminate instructions with side-effects

On Fri, Aug 8, 2014 at 4:58 PM, Kenneth Graunke wrote: > On Friday, August 08, 2014 02:42:27 PM Jason Ekstrand wrote: > > In particular, this caused problems where atomics operations were getting > > eliminated. > > > > Signed-off-by: Jason Ekstrand > > --- > > src/mesa/drivers/dri/i965/brw_fs_

Re: [Mesa-dev] [PATCH] i965: Use memcpy instead of an assignment when storing uniforms

On Friday, August 08, 2014 02:56:53 PM Eric Anholt wrote: > Roland Scheidegger writes: > > > Am 08.08.2014 22:56, schrieb Neil Roberts: > >> The i965 driver uses a float pointer to point to the value of a uniform and > >> also as the destination within the batch buffer. However the same locations

Re: [Mesa-dev] [PATCH] i965/fs: set virtual_grf_count in assign_regs()

On Fri, Aug 8, 2014 at 4:55 PM, Matt Turner wrote: > Reviewed-by: Matt Turner > > I'll commit both of these tonight. (Does the vec4 backend have the > same problem?) AFAICT, it has the same problem that this patch fixes but not the last patch. I would fix send another patch, but I'm not as famil

Re: [Mesa-dev] [PATCH] i965/cse: Don't eliminate instructions with side-effects

On Friday, August 08, 2014 02:42:27 PM Jason Ekstrand wrote: > In particular, this caused problems where atomics operations were getting > eliminated. > > Signed-off-by: Jason Ekstrand > --- > src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 3 ++- > src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 3 ++

Re: [Mesa-dev] [PATCH 2/8] mesa: define and use ALL_TYPE_BITS in varray.c code

Am 08.08.2014 23:20, schrieb Brian Paul: > --- > src/mesa/main/varray.c | 33 + > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c > index 0356858..1454449 100644 > --- a/src/mesa/main/varray.c > +

Re: [Mesa-dev] [PATCH] i965/fs: set virtual_grf_count in assign_regs()

Reviewed-by: Matt Turner I'll commit both of these tonight. (Does the vec4 backend have the same problem?) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/13] mesa: Document SYSTEM_VALUE_VERTEX_ID and SYSTEM_VALUE_INSTANCE_ID

Am 08.08.2014 23:38, schrieb Ian Romanick: > On 08/08/2014 07:55 AM, Roland Scheidegger wrote: >> The mesa parts of the series all look good to me. > > So.. can we put your R-b on patches 1 through 7? :) Actually I'm not really qualified for the glsl parts in 4,5 but 1-3, 6, 7 are Reviewed-by: Rol

[Mesa-dev] [PATCH] i965/fs: set virtual_grf_count in assign_regs()

This lets us call dump_instructions() after register allocation without failing an assertion. This interacts trivially with my previous patch. Signed-off-by: Connor Abbott --- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/driv

[Mesa-dev] [Bug 82327] FAIL: glcpp/tests/glcpp-test-cr-lf

https://bugs.freedesktop.org/show_bug.cgi?id=82327 Matt Turner changed: What|Removed |Added QA Contact||mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH] glxinfo/wglinfo: query/print GL_ARB_texture_multisample limits

--- src/xdemos/glinfo_common.c |5 + 1 file changed, 5 insertions(+) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index f536e98..d3acc19 100644 --- a/src/xdemos/glinfo_common.c +++ b/src/xdemos/glinfo_common.c @@ -573,6 +573,11 @@ print_limits(const char *extension

Re: [Mesa-dev] [PATCH] RFC: glsl/glcpp: Allow for '#' characters to appear in shader body

Erik Faye-Lund writes: > It seems to me like this is there to support non-ASCII identifiers and > strings, but GLSL doesn't support either. I'm not able to come up with > a conclusion here. That's almost always the case with GLSL. The GLSL specification does have its own section for character set

Re: [Mesa-dev] [PATCH 03/13] mesa: Add SYSTEM_VALUE_BASE_VERTEX

Am 08.08.2014 23:47, schrieb Ian Romanick: > On 08/08/2014 11:31 AM, Roland Scheidegger wrote: >> Am 08.08.2014 20:06, schrieb Ian Romanick: >>> On 08/08/2014 12:37 AM, Kenneth Graunke wrote: On Friday, August 08, 2014 12:31:07 AM Kenneth Graunke wrote: > From: Ian Romanick > > Th

Re: [Mesa-dev] [PATCH] i965/fs: don't read from uninitialized memory while assigning registers

Weird that I didn't notice this before. Thanks! Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965/fs: don't read from uninitialized memory while assigning registers

Signed-off-by: Connor Abbott --- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp index 3f27364..2233621 100644

Re: [Mesa-dev] [PATCH] i965: Use memcpy instead of an assignment when storing uniforms

Roland Scheidegger writes: > Am 08.08.2014 22:56, schrieb Neil Roberts: >> The i965 driver uses a float pointer to point to the value of a uniform and >> also as the destination within the batch buffer. However the same locations >> can also be used to store values for integer uniforms. Previousl

Re: [Mesa-dev] [PATCH 7/8] mesa: fix assertion in _mesa_drawbuffers()

Pavel, Does this patch fix the problem you were trying to solve? On 08/08/2014 02:20 PM, Brian Paul wrote: > Fixes failed assertion when _mesa_update_draw_buffers() was called > with GL_DRAW_BUFFER == GL_FRONT_AND_BACK. The piglit gl30basic hit > this. > > Cc: "10.2" > --- > src/mesa/main/buf

Re: [Mesa-dev] [PATCH 1/8] mesa: add comment that GL_CLIP_DISTANCE0 == GL_CLIP_PLANE0 in enable.c

Assuming patch 7 fixes the problem Pavel was seeing (and I'm not even 100% what problem that was), the series is Reviewed-by: Ian Romanick On 08/08/2014 02:20 PM, Brian Paul wrote: > --- > src/mesa/main/enable.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sr

Re: [Mesa-dev] [PATCH 03/13] mesa: Add SYSTEM_VALUE_BASE_VERTEX

On 08/08/2014 11:31 AM, Roland Scheidegger wrote: > Am 08.08.2014 20:06, schrieb Ian Romanick: >> On 08/08/2014 12:37 AM, Kenneth Graunke wrote: >>> On Friday, August 08, 2014 12:31:07 AM Kenneth Graunke wrote: From: Ian Romanick This system value represents the basevertex value pas

[Mesa-dev] [PATCH] i965/cse: Don't eliminate instructions with side-effects

In particular, this caused problems where atomics operations were getting eliminated. Signed-off-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 3 ++- src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/

Re: [Mesa-dev] [PATCH 01/13] mesa: Document SYSTEM_VALUE_VERTEX_ID and SYSTEM_VALUE_INSTANCE_ID

On 08/08/2014 07:55 AM, Roland Scheidegger wrote: > The mesa parts of the series all look good to me. So.. can we put your R-b on patches 1 through 7? :) > We definitely want something like that in gallium too (draw fails the > vertex id tests sort of on purpose right now because we needed d3d10

Re: [Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

Am 08.08.2014 09:46, schrieb Kenneth Graunke: > On Thursday, August 07, 2014 10:41:36 PM Roland Scheidegger wrote: >> Am 07.08.2014 20:25, schrieb Jason Ekstrand: >>> Michel, >>> >>> On Thu, Aug 7, 2014 at 12:04 AM, Michel Dänzer >> > wrote: >>> >>> On 07.08.2014 02:0

Re: [Mesa-dev] [PATCH] i965: Use memcpy instead of an assignment when storing uniforms

Am 08.08.2014 22:56, schrieb Neil Roberts: > The i965 driver uses a float pointer to point to the value of a uniform and > also as the destination within the batch buffer. However the same locations > can also be used to store values for integer uniforms. Previously the value > was being copied int

[Mesa-dev] [PATCH 8/8] mesa: simplify _mesa_update_draw_buffers()

There's no need to copy the array of DrawBuffer enums to a temp array. --- src/mesa/main/buffers.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c index 6b4fac9..140cf6e 100644 --- a/src/mesa/main/buffers.c +++ b/src

[Mesa-dev] [PATCH 7/8] mesa: fix assertion in _mesa_drawbuffers()

Fixes failed assertion when _mesa_update_draw_buffers() was called with GL_DRAW_BUFFER == GL_FRONT_AND_BACK. The piglit gl30basic hit this. Cc: "10.2" --- src/mesa/main/buffers.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/

[Mesa-dev] [PATCH 1/8] mesa: add comment that GL_CLIP_DISTANCE0 == GL_CLIP_PLANE0 in enable.c

--- src/mesa/main/enable.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index 0f3bcf0..417548a 100644 --- a/src/mesa/main/enable.c +++ b/src/mesa/main/enable.c @@ -313,7 +313,7 @@ _mesa_set_enable(struct gl_context *ctx,

[Mesa-dev] [PATCH 6/8] mesa: whitespace, 80-column wrapping in program.c

--- src/mesa/program/program.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index 9886b75..ef5bf6b 100644 --- a/src/mesa/program/program.c +++ b/src/mesa/program/program.c @@ -251,8 +251,9 @@ init

[Mesa-dev] [PATCH 2/8] mesa: define and use ALL_TYPE_BITS in varray.c code

--- src/mesa/main/varray.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index 0356858..1454449 100644 --- a/src/mesa/main/varray.c +++ b/src/mesa/main/varray.c @@ -46,21 +46,22 @@ /** Used

[Mesa-dev] [PATCH 4/8] st/mesa: use PRIu64 for printing 64-bit uints

--- src/mesa/state_tracker/st_cb_bufferobjects.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_bufferobjects.c b/src/mesa/state_tracker/st_cb_bufferobjects.c index 3b4d28d..4143dff 100644 --- a/src/mesa/state_tracker/st_cb_bufferobjects.c

[Mesa-dev] [PATCH 3/8] mesa: use PRIu64 for printing 64-bit uints

Silences MinGW warnings: warning: unknown conversion type character ‘l’ in format [-Wformat] warning: too many arguments for format [-Wformat-extra-args] --- src/mesa/main/bufferobj.c | 33 + src/mesa/main/varray.c| 13 - 2 files changed, 25 in

[Mesa-dev] [PATCH 5/8] mesa: simplify/rename _mesa_init_program_struct()

No need to return a value. Remove unused ctx parameter. Remove _mesa_ prefix since it's static. --- src/mesa/program/program.c | 69 ++-- 1 file changed, 35 insertions(+), 34 deletions(-) diff --git a/src/mesa/program/program.c b/src/mesa/program/progra

Re: [Mesa-dev] [PATCH] i965: Support the allow_glsl_extension_directive_midshader option.

On 08/08/2014 01:06 AM, Kenneth Graunke wrote: > This adds support for Marek's new driconf parameter, which avoids > totally white rendering in Unigine Valley (which attempts to enable > the GL_ARB_sample_shading extension in an illegal place). > > Signed-off-by: Kenneth Graunke Bugzilla: https:

Re: [Mesa-dev] [PATCH v2] mesa: Fix glDrawBuffer/glDrawBuffers logic in _mesa_drawbuffer.

I've come up with a simpler solution. Patch coming soon. -Brian On 07/25/2014 04:00 AM, Popov, Pavel E wrote: Hi Brian, Could you commit the updated patch if it's ok? Regards, Pavel -Original Message- From: Popov, Pavel E Sent: Wednesday, July 23, 2014 4:58 PM To: mesa-dev@lists.fre

Re: [Mesa-dev] [PATCH] i965: Use memcpy instead of an assignment when storing uniforms

On 08/08/2014 01:56 PM, Neil Roberts wrote: > The i965 driver uses a float pointer to point to the value of a uniform and > also as the destination within the batch buffer. However the same locations > can also be used to store values for integer uniforms. Previously the value > was being copied in

Re: [Mesa-dev] [PATCH v2 0/12] Add support for BPTC texture compression

Patches 1, 2, 3, and 5 though 12 are Reviewed-by: Ian Romanick Admittedly, I wasn't exceptionally thorogh with patches 6 and 7. I'm not worried about 6 getting a lot of use, and I expect we'll revisit 7 in the not too distant future (per previous discussions about the compressor). On 08/06/201

[Mesa-dev] [PATCH] i965: Use memcpy instead of an assignment when storing uniforms

The i965 driver uses a float pointer to point to the value of a uniform and also as the destination within the batch buffer. However the same locations can also be used to store values for integer uniforms. Previously the value was being copied into the batch buffer with a regular assignment. This

Re: [Mesa-dev] [PATCH] configure: check for dladdr via AC_CHECK_FUNC/AC_CHECK_LIB

On 08/08/14 20:09, Jon TURNEY wrote: > On 08/08/2014 18:58, Ilia Mirkin wrote: >> The problem is that AC_CHECK_FUNCS would stick the LDFLAGS before the >> conftest.c arg while AC_CHECK_LIB sticks the -ldl after conftest.c. >> This apparently matters with newer gcc's. There's probably some > > The

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

On Thu, 2014-08-07 at 16:02 +0300, Francisco Jerez wrote: > Jan Vesely writes: > > > This respin includes Francisco's approach of providing implicit > > in the arg vector passed from clover, and Tom's idea of appending > > implicit args after the kernel args. > > > > Hmmm... Maybe it would make

Re: [Mesa-dev] [PATCH] configure: check for dladdr via AC_CHECK_FUNC/AC_CHECK_LIB

On 08/08/2014 18:58, Ilia Mirkin wrote: The problem is that AC_CHECK_FUNCS would stick the LDFLAGS before the conftest.c arg while AC_CHECK_LIB sticks the -ldl after conftest.c. This apparently matters with newer gcc's. There's probably some The key difference seems to be that lto was enabled,

Re: [Mesa-dev] [PATCH 1/2] draw: don't use clipvertex output if user plane clipping is disabled

On 08/08/2014 11:02 AM, srol...@vmware.com wrote: From: Roland Scheidegger The non-llvm path made sure that both clip and pre_clip_pos point to the data output by position, not clipvertex, if user based clipping is disabled. However, the llvm path did not, which apparently led to failures if gl

[Mesa-dev] [PATCH 1/5] mesa: Add GL API support for ARB_copy_image

This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. v2: Fix a typo in ARB_copy_image.xml and add it to the makefile v3: Put ARB_copy_image.xml in the right place alphebetically in the makefile and properly prefix the commit message v4: Fixed

Re: [Mesa-dev] [PATCH 2/2] draw: (trivial) use information about gs being present from variant key

On 08/08/2014 11:02 AM, srol...@vmware.com wrote: From: Roland Scheidegger This is a purely cosmetic change. --- src/gallium/auxiliary/draw/draw_llvm.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_llvm.c b/src/gallium/auxiliary

Re: [Mesa-dev] [PATCH 03/13] mesa: Add SYSTEM_VALUE_BASE_VERTEX

Am 08.08.2014 20:06, schrieb Ian Romanick: > On 08/08/2014 12:37 AM, Kenneth Graunke wrote: >> On Friday, August 08, 2014 12:31:07 AM Kenneth Graunke wrote: >>> From: Ian Romanick >>> >>> This system value represents the basevertex value passed to >>> glDrawElementsBaseVertex and related functions

[Mesa-dev] [PATCH 4/5] i965: Add support for ARB_copy_image

This, together with the meta path, provides a complete implemetation of ARB_copy_image. v2: Add a fallback memcpy path for when the texture is too big for the blitter v3: Properly support copying between two places on the same texture in the memcpy fallback v4: Properly handle blit between

[Mesa-dev] [Bug 82327] FAIL: glcpp/tests/glcpp-test-cr-lf

https://bugs.freedesktop.org/show_bug.cgi?id=82327 Ian Romanick changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |cwo...@cworth.org |org

Re: [Mesa-dev] [PATCH 03/13] mesa: Add SYSTEM_VALUE_BASE_VERTEX

On 08/08/2014 12:37 AM, Kenneth Graunke wrote: > On Friday, August 08, 2014 12:31:07 AM Kenneth Graunke wrote: >> From: Ian Romanick >> >> This system value represents the basevertex value passed to >> glDrawElementsBaseVertex and related functions. >> >> Signed-off-by: Ian Romanick >> --- >> sr

Re: [Mesa-dev] [PATCH 07/13] mesa: Fix glGetActiveAttribute for gl_VertexID when lowered.

On 08/08/2014 12:31 AM, Kenneth Graunke wrote: > The lower_vertex_id pass converts uses of the gl_VertexID system value > to the gl_BaseVertex and gl_VertexIDMESA system values. Since > gl_VertexID is no longer accessed, it would not be considered active. > > Of course, it should be, since the sh

Re: [Mesa-dev] [PATCH] configure: check for dladdr via AC_CHECK_FUNC/AC_CHECK_LIB

The problem is that AC_CHECK_FUNCS would stick the LDFLAGS before the conftest.c arg while AC_CHECK_LIB sticks the -ldl after conftest.c. This apparently matters with newer gcc's. There's probably some correct autoconf way of dealing with it, but... this works :) On Fri, Aug 8, 2014 at 1:55 PM, Ma

Re: [Mesa-dev] [PATCH 4/5] i965: Add support for ARB_copy_image

On Fri, Aug 8, 2014 at 4:05 AM, Neil Roberts wrote: > Jason Ekstrand writes: > > > + if (src_mt == dst_mt && src_level == dst_level && src_z == dst_z) { > > + /* If we are on the same miptree, same level, and same slice, then > > + * intel_miptree_map won't let us map it twice. We

Re: [Mesa-dev] [PATCH] configure: check for dladdr via AC_CHECK_FUNC/AC_CHECK_LIB

No idea why this was a problem, but the new code matches the existing dlopen check. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 12/13] i965: Expose gl_BaseVertex via a vertex attribute.

(For what it's worth.) Reviewed-by: Ian Romanick On 08/08/2014 12:31 AM, Kenneth Graunke wrote: > Now that we have the data available, we need to expose it to the > shaders. We can reuse the same vertex element that we use for > gl_VertexID, but we need to back it by an actual vertex buffer. >

Re: [Mesa-dev] [PATCH 06/13] mesa: Replace string comparisons with SYSTEM_VALUE enum checks.

This patch is Reviewed-by: Ian Romanick But it raises an interesting question. If we lower gl_VertexID to gl_VertexIDMESA + gl_BaseVertex, are we going to report active attributes incorrectly through the API? On 08/08/2014 12:31 AM, Kenneth Graunke wrote: > This is more efficient. > > Signed-

Re: [Mesa-dev] [PATCH 10/13] i965: Make gl_BaseVertex available in a buffer object.

Reviewed-by: Ian Romanick On 08/08/2014 12:31 AM, Kenneth Graunke wrote: > This will be used for GL_ARB_shader_draw_parameters, as well as fixing > gl_VertexID, which is supposed to include gl_BaseVertex's value. > > For indirect draws, we simply point at the indirect buffer; for normal > draws,

Re: [Mesa-dev] [PATCH 11/13] i965: Refactor Gen4-7 VERTEX_BUFFER_STATE emission into a helper.

Reviewed-by: Ian Romanick On 08/08/2014 12:31 AM, Kenneth Graunke wrote: > We'll need to emit another VERTEX_BUFFER_STATE for gl_BaseVertex; > pulling this into a helper function will save us from having to deal > with cross-generation differences in that code. > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 09/13] i965: Calculate start/base_vertex_location after preparing vertices.

Reviewed-by: Ian Romanick It might be useful in the commit message to explain why this change is necessary. On 08/08/2014 12:31 AM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_context.h | 8 > src/mesa/drivers/dri/i965/brw_draw.c

[Mesa-dev] [PATCH] configure: check for dladdr via AC_CHECK_FUNC/AC_CHECK_LIB

From: Pali Rohár Use both macros as in some cases using AC_CHECK_FUNCS alone may fail. Thus HAVE_DLADDR will not be defined, and as a result most of the code in megadriver_stub.c will not be compiled. Breakind the backwards compat with between older libGL/xserver(s) and DRI megadrivers. Cc: Jon

Re: [Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

On Tuesday, July 01, 2014 04:04:56 PM Neil Roberts wrote: > > FWIW, I relaxed the format restrictions in > > brw_blorp_copytexsubimage, so it can handle general format > > conversions as well (i.e. RGBA_FLOAT16 -> RGBA_UNORM). There's > > no reason we couldn't do that for BlitFramebuffer as wel

[Mesa-dev] [PATCH 1/2] draw: don't use clipvertex output if user plane clipping is disabled

From: Roland Scheidegger The non-llvm path made sure that both clip and pre_clip_pos point to the data output by position, not clipvertex, if user based clipping is disabled. However, the llvm path did not, which apparently led to failures if gl_ClipVertex was written but user plane clipping not

[Mesa-dev] [PATCH 2/2] draw: (trivial) use information about gs being present from variant key

From: Roland Scheidegger This is a purely cosmetic change. --- src/gallium/auxiliary/draw/draw_llvm.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_llvm.c b/src/gallium/auxiliary/draw/draw_llvm.c index 5a7bedb..3d9ddf2 100644 --- a/

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions > viewport width/height are not displayed

https://bugs.freedesktop.org/show_bug.cgi?id=80183 --- Comment #7 from Roland Scheidegger --- (In reply to comment #2) > I found out that the problem is the line: > > gl_ClipVertex = gl_ModelViewMatrix * gl_Vertex; > > in the fragment shader. If I remove that line, it works as expected. > > Si

Re: [Mesa-dev] [PATCH] RFC: glsl/glcpp: Allow for '#' characters to appear in shader body

On Fri, Aug 8, 2014 at 12:29 AM, Carl Worth wrote: > Erik Faye-Lund writes: >> Note that '$' is a bit different, as it's not a part of the >> preprocessor's character set, so using it might be interpreted as >> undefined behavior. > > Right. That could easily go either way. Is the phrase "each >

Re: [Mesa-dev] [PATCH v2] clover: Add support for CL_MAP_WRITE_INVALIDATE_REGION

On Fri, 2014-08-08 at 18:10 +0300, Francisco Jerez wrote: > Bruno Jiménez writes: > > > OpenCL 1.2 CL_MAP_WRITE_INVALIDATE_REGION sounds a lot like > > PIPE_TRANSFER_DISCARD_RANGE: > > > > From OpenCL 1.2 spec: > > The contents of the region being mapped are to be discarded. > > > > From p_de

Re: [Mesa-dev] [PATCH 7/7] clover: Flush the command queue in clReleaseCommandQueue()

Tom Stellard writes: > This is required by the spec. > > CC: "10.2" > --- > src/gallium/state_trackers/clover/api/queue.cpp | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/state_trackers/clover/api/queue.cpp > b/src/gallium/state_trackers/clover/api/qu

Re: [Mesa-dev] [PATCH] i965: Support the allow_glsl_extension_directive_midshader option.

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] radeonsi/compute: Memory usage fixes

Hi, This series contains fixes for applications which allocate large amounts of memory. The first two patches fix the values reported for PIPE_COMPUTE_CAP_MAX_GLOBAL_SIZE, PIPE_COMPUTE_CAP_MAX_MEM_ALLOC_SIZE, and PIPE_SHADER_CAP_MAX_CONST_BUFFER_SIZE so that applications don't allocate more memor

[Mesa-dev] [PATCH 3/7] radeonsi/compute: Update reference counts for buffers in si_set_global_binding()

CC: "10.2" --- src/gallium/drivers/radeonsi/si_compute.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 42e4fec..482d475 100644 --- a/src/gallium/drivers/radeonsi/si_compute.c +++

[Mesa-dev] [PATCH 1/7] radeon/compute: Fix reported values for MAX_GLOBAL_SIZE and MAX_MEM_ALLOC_SIZE

There is a hard limit in older kernels of 256 MB for buffer allocations, so report this value as MAX_MEM_ALLOC_SIZE and adjust MAX_GLOBAL_SIZE to statisfy requirements of OpenCL. CC: "10.2" --- src/gallium/drivers/radeon/r600_pipe_common.c | 32 --- 1 file changed, 19 ins

[Mesa-dev] [PATCH 5/7] radeonsi/compute: Whitespace fixes

CC: "10.2" --- src/gallium/drivers/radeonsi/si_compute.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index e8fc8eb..dff5ddd 100644 --- a/src/gallium/drivers/radeonsi/si_compute.c +++ b

[Mesa-dev] [PATCH 2/7] radeon/compute: Report a value for PIPE_SHADER_CAP_MAX_CONST_BUFFER_SIZE

CC: "10.2" --- src/gallium/drivers/r600/r600_pipe.c | 11 ++- src/gallium/drivers/radeonsi/si_pipe.c | 7 +++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index a08e70e..7ace671 100644 --

[Mesa-dev] [PATCH 6/7] radeonsi/compute: Stop leaking the input buffer

We were leaking the input buffer used for kernel arguments and since we were allocating it using si_upload_const_buffer() we were leaking 1 MB per kernel invocation. CC: "10.2" --- src/gallium/drivers/radeonsi/si_compute.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletion

[Mesa-dev] [PATCH 4/7] radeonsi/compute: Call si_pm4_free_state() after emitting compute state

This will decrement the reference count for buffers referenced in the command stream will prevent us from leaking them. CC: "10.2" --- src/gallium/drivers/radeonsi/si_compute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/ga

[Mesa-dev] [PATCH 7/7] clover: Flush the command queue in clReleaseCommandQueue()

This is required by the spec. CC: "10.2" --- src/gallium/state_trackers/clover/api/queue.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/queue.cpp b/src/gallium/state_trackers/clover/api/queue.cpp index a136018..06a2863 100644 -

Re: [Mesa-dev] [PATCH v2] clover: Add support for CL_MAP_WRITE_INVALIDATE_REGION

Bruno Jiménez writes: > OpenCL 1.2 CL_MAP_WRITE_INVALIDATE_REGION sounds a lot like > PIPE_TRANSFER_DISCARD_RANGE: > > From OpenCL 1.2 spec: > The contents of the region being mapped are to be discarded. > > From p_defines.h: > Discards the memory within the mapped region. > > v2: Move th

Re: [Mesa-dev] [PATCH] egl_dri2: fix EXT_image_dma_buf_import fds

On Fri, 8 Aug 2014 17:28:59 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > The EGL_EXT_image_dma_buf_import specification was revised (according to > its revision history) on Dec 5th, 2013, for EGL to not take ownership of > the file descriptors. > > Do not close the file descriptors

Re: [Mesa-dev] [PATCH 01/13] mesa: Document SYSTEM_VALUE_VERTEX_ID and SYSTEM_VALUE_INSTANCE_ID

The mesa parts of the series all look good to me. We definitely want something like that in gallium too (draw fails the vertex id tests sort of on purpose right now because we needed d3d10 behavior). Oh and sort of off-topic but since you're familiar with it do you know why the gl_PrimitiveIn of

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

Tom Stellard writes: > On Thu, Aug 07, 2014 at 04:02:40PM +0300, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > This respin includes Francisco's approach of providing implicit >> > in the arg vector passed from clover, and Tom's idea of appending >> > implicit args after the kernel args.

Re: [Mesa-dev] [PATCH 03/13] mesa: Add SYSTEM_VALUE_BASE_VERTEX

Am 08.08.2014 09:37, schrieb Kenneth Graunke: > On Friday, August 08, 2014 12:31:07 AM Kenneth Graunke wrote: >> From: Ian Romanick >> >> This system value represents the basevertex value passed to >> glDrawElementsBaseVertex and related functions. >> >> Signed-off-by: Ian Romanick >> --- >> src

[Mesa-dev] [PATCH] egl_dri2: fix EXT_image_dma_buf_import fds

From: Pekka Paalanen The EGL_EXT_image_dma_buf_import specification was revised (according to its revision history) on Dec 5th, 2013, for EGL to not take ownership of the file descriptors. Do not close the file descriptors passed in to eglCreateImageKHR with EGL_LINUX_DMA_BUF_EXT target. It is

Re: [Mesa-dev] [PATCH 4/5] i965: Add support for ARB_copy_image

Jason Ekstrand writes: > + if (src_mt == dst_mt && src_level == dst_level && src_z == dst_z) { > + /* If we are on the same miptree, same level, and same slice, then > + * intel_miptree_map won't let us map it twice. We have to do a > + * single map in read-write mode. > +

Re: [Mesa-dev] [PATCH] mesa: Drop USE_IEEE define.

On Wed, Aug 06, 2014 at 04:54:38PM -0700, Matt Turner wrote: > I think OpenVMS was the only platform that Mesa ran on that used a > non-IEEE representation for floats. We removed OpenVMS support a while > back, and this should alleviate the need to continue updating the > this-platform-uses-IEEE li

[Mesa-dev] [PATCH] i965: Support the allow_glsl_extension_directive_midshader option.

This adds support for Marek's new driconf parameter, which avoids totally white rendering in Unigine Valley (which attempts to enable the GL_ARB_sample_shading extension in an illegal place). Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.c | 3 +++ src/mesa/drivers/dr

Re: [Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

On Thursday, August 07, 2014 10:41:36 PM Roland Scheidegger wrote: > Am 07.08.2014 20:25, schrieb Jason Ekstrand: > > Michel, > > > > On Thu, Aug 7, 2014 at 12:04 AM, Michel Dänzer > > wrote: > > > > On 07.08.2014 02:02, Jason Ekstrand wrote: > > > Michael, > >

Re: [Mesa-dev] [PATCH 03/13] mesa: Add SYSTEM_VALUE_BASE_VERTEX

On Friday, August 08, 2014 12:31:07 AM Kenneth Graunke wrote: > From: Ian Romanick > > This system value represents the basevertex value passed to > glDrawElementsBaseVertex and related functions. > > Signed-off-by: Ian Romanick > --- > src/mesa/main/mtypes.h | 15 +

[Mesa-dev] [PATCH 10/13] i965: Make gl_BaseVertex available in a buffer object.

This will be used for GL_ARB_shader_draw_parameters, as well as fixing gl_VertexID, which is supposed to include gl_BaseVertex's value. For indirect draws, we simply point at the indirect buffer; for normal draws, we upload the value via the upload buffer. Signed-off-by: Kenneth Graunke --- src

[Mesa-dev] [PATCH 12/13] i965: Expose gl_BaseVertex via a vertex attribute.

Now that we have the data available, we need to expose it to the shaders. We can reuse the same vertex element that we use for gl_VertexID, but we need to back it by an actual vertex buffer. A hardware restriction requires that vertex attributes coming from a buffer (STORE_SRC) must come before a

[Mesa-dev] [PATCH 09/13] i965: Calculate start/base_vertex_location after preparing vertices.

Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.h | 8 src/mesa/drivers/dri/i965/brw_draw.c | 17 - src/mesa/drivers/dri/i965/brw_draw.h | 2 ++ src/mesa/drivers/dri/i965/brw_draw_upload.c | 12 src/mesa/driver

  1   2   >