Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but that
is an assumption OpenGL drivers (or any dynamic library for that matter) can't
afford to make as there are many closed- and open- source application binaries
out there that only assume 4-byte stack alignment.
V4: fi
Possibly mark this for 10.4, since the assertion failures we hit when
emitting a pointless centroid workaround make other issues hard to
debug?
On Tue, Dec 9, 2014 at 8:44 PM, Chris Forbes wrote:
> Reviewed-by: Chris Forbes
>
> On Tue, Dec 9, 2014 at 8:08 PM, Matt Turner wrote:
>> Back to the o
On Mon, 2014-12-08 at 22:08 -0800, Matt Turner wrote:
> On Mon, Dec 8, 2014 at 9:43 PM, Timothy Arceri wrote:
> > Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but
> > that is an assumption OpenGL drivers (or any dynamic library for that
> > matter)
> > can't afford to
On Mon, Dec 8, 2014 at 11:08 PM, Matt Turner wrote:
> I cannot find documentation that says that Sandybridge needs this
> workaround
In fact, the BSpec specifically says that this workaround is needed
for HSW, IVB, and VLV (no SNB).
I was apparently incorrect that it doesn't apply to Haswell whe
Reviewed-by: Chris Forbes
On Tue, Dec 9, 2014 at 8:08 PM, Matt Turner wrote:
> Back to the original commit (8313f444) adding the workaround, we were
> enabling it on gens <= 7, even though gens <= 5 can't do multisampling.
>
> I cannot find documentation that says that Sandybridge needs this
> w
Back to the original commit (8313f444) adding the workaround, we were
enabling it on gens <= 7, even though gens <= 5 can't do multisampling.
I cannot find documentation that says that Sandybridge needs this
workaround but in practice disabling it causes these piglit tests to
fail:
EXT_framebuffe
From: Dave Airlie
r600, rv610 and rv630 all have a bug in their GPR indexing
and how the hw inserts access to PV.
If the base index for the src is the same as the dst gpr
in a previous group, then it will use PV instead of using
the indexed gpr correctly.
The workaround is to insert a NOP when
https://bugs.freedesktop.org/show_bug.cgi?id=87137
--- Comment #2 from Bob ---
(In reply to Matt Turner from comment #1)
> Dear Vlad/Bob/Chris (which is it?!),
none of the above.
>
> Please submit a patch to mesa-dev@lists.freedesktop.org adding
>
> #ifdef _OPENMP
> #include
> #endif
>
> to
https://bugs.freedesktop.org/show_bug.cgi?id=87137
--- Comment #1 from Matt Turner ---
Dear Vlad/Bob/Chris (which is it?!),
Please submit a patch to mesa-dev@lists.freedesktop.org adding
#ifdef _OPENMP
#include
#endif
to the files that call omp_* functions.
Also, don't put -fopenmp in your s
https://bugs.freedesktop.org/show_bug.cgi?id=87136
Matt Turner changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=87137
Bug ID: 87137
Summary: Unable to build when configured with openmp and
CFLAGS/LDFLAGS contain -fopenmp
Product: Mesa
Version: 10.3
Hardware: x86-64 (AMD64)
https://bugs.freedesktop.org/show_bug.cgi?id=87136
Bug ID: 87136
Summary: Incorrect/undefined behavior from shifting an integer
too far
Product: Mesa
Version: unspecified
Hardware: Other
OS: All
On Mon, Dec 8, 2014 at 9:43 PM, Timothy Arceri wrote:
> Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but
> that is an assumption OpenGL drivers (or any dynamic library for that matter)
> can't afford to make as there are many closed- and open- source application
> bina
Am 09.12.2014 um 06:40 schrieb Matt Turner:
> On Mon, Nov 24, 2014 at 2:37 PM, wrote:
>> From: Roland Scheidegger
>>
>> llvmpipe disables denorms on purpose (on x86/sse only), because denorms are
>> generally neither required nor desired for graphic apis (and in case of
>> d3d10,
>> they are fo
https://bugs.freedesktop.org/show_bug.cgi?id=86939
Vinson Lee changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=79706
Bug 79706 depends on bug 86939, which changed state.
Bug 86939 Summary: test_vf_float_conversions.cpp:63:12: error: expected
primary-expression before ‘union’
https://bugs.freedesktop.org/show_bug.cgi?id=86939
What|Removed
Am 09.12.2014 um 02:31 schrieb Dave Airlie:
> From: Dave Airlie
>
> Since d8da6deceadf5e48201d848b7061dad17a5b7cac where the
> state tracker started using UCMP on cayman a number of tests
> regressed.
>
> this seems to be r600g is doing CNDGE_INT for UCMP which is >= 0,
> we should be doing CNDE
Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but
that is an assumption OpenGL drivers (or any dynamic library for that matter)
can't afford to make as there are many closed- and open- source application
binaries out there that only assume 4-byte stack alignment.
V3: mo
On Mon, Nov 24, 2014 at 2:37 PM, wrote:
> From: Roland Scheidegger
>
> llvmpipe disables denorms on purpose (on x86/sse only), because denorms are
> generally neither required nor desired for graphic apis (and in case of d3d10,
> they are forbidden).
> However, this caused some arithmetic tests
On 12/09/2014 05:18 AM, Dave Airlie wrote:
On 8 December 2014 at 20:41, Vadim Girlin wrote:
On 12/06/2014 07:13 AM, Vadim Girlin wrote:
On 12/04/2014 01:43 AM, Dave Airlie wrote:
Hi Vadim,
I've been looking with Glenn's help into a bug in sb for a couple of
weeks now triggered by a change
On Tue, Dec 02, 2014 at 11:07:34PM -0800, Ian Romanick wrote:
> Since there will be a v3 anyway, nits below...
>
> On 12/02/2014 06:33 PM, Ben Widawsky wrote:
> > This patch implements ARB_pipeline_statistics_query. This addition to GL
> > does
> > not add a new API. Instead, it adds new tokens t
On 8 December 2014 at 20:41, Vadim Girlin wrote:
> On 12/06/2014 07:13 AM, Vadim Girlin wrote:
>>
>> On 12/04/2014 01:43 AM, Dave Airlie wrote:
>>>
>>> Hi Vadim,
>>>
>>> I've been looking with Glenn's help into a bug in sb for a couple of
>>> weeks now triggered by a change in how GLSL generates s
On 9 December 2014 at 10:25, Dave Airlie wrote:
> On 8 December 2014 at 20:41, Vadim Girlin wrote:
>> On 12/06/2014 07:13 AM, Vadim Girlin wrote:
>>>
>>> On 12/04/2014 01:43 AM, Dave Airlie wrote:
Hi Vadim,
I've been looking with Glenn's help into a bug in sb for a couple of
>
On Tue, 09 Dec 2014 02:31:01 +0100, Dave Airlie wrote:
From: Dave Airlie
Since d8da6deceadf5e48201d848b7061dad17a5b7cac where the
state tracker started using UCMP on cayman a number of tests
regressed.
this seems to be r600g is doing CNDGE_INT for UCMP which is >= 0,
we should be doing CNDE_IN
From: Dave Airlie
Since d8da6deceadf5e48201d848b7061dad17a5b7cac where the
state tracker started using UCMP on cayman a number of tests
regressed.
this seems to be r600g is doing CNDGE_INT for UCMP which is >= 0,
we should be doing CNDE_INT with reverse arguments.
Signed-off-by: Dave Airlie
--
On 8 December 2014 at 20:41, Vadim Girlin wrote:
> On 12/06/2014 07:13 AM, Vadim Girlin wrote:
>>
>> On 12/04/2014 01:43 AM, Dave Airlie wrote:
>>>
>>> Hi Vadim,
>>>
>>> I've been looking with Glenn's help into a bug in sb for a couple of
>>> weeks now triggered by a change in how GLSL generates s
No, we depend on the MALLOC/FREE debug wrappers, etc. for memory
debugging on Windows.
-Brian
On 12/08/2014 02:40 PM, Ian Romanick wrote:
Didn't Gallium also remove the FREE business?
Either way, patch 1 and 2 are
Reviewed-by: Ian Romanick
I sent a comment on patch 3. With that comment re
On Mon, Dec 8, 2014 at 1:59 PM, Ian Romanick wrote:
> On 12/08/2014 01:56 PM, Matt Turner wrote:
>> On Mon, Dec 8, 2014 at 1:54 PM, Ian Romanick wrote:
diff --git a/configure.ac b/configure.ac
index b0df1bb..7dc435a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -253,8 +
On Sun, Dec 7, 2014 at 4:13 AM, Timothy Arceri wrote:
> Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but
> that is an assumption OpenGL drivers (or any dynamic library for that matter)
> can't afford to make as there are many closed- and open- source application
> bina
On 12/08/2014 01:56 PM, Matt Turner wrote:
> On Mon, Dec 8, 2014 at 1:54 PM, Ian Romanick wrote:
>>> diff --git a/configure.ac b/configure.ac
>>> index b0df1bb..7dc435a 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -253,8 +253,9 @@ AC_SUBST([VISIBILITY_CXXFLAGS])
>>> dnl
>>> dnl Op
On 12/07/2014 06:57 PM, Matt Turner wrote:
> I've finished fixing up make distcheck.
>
> git://people.freedesktop.org/~mattst88/mesa make-dist
>
> I've seen some (sporadic?) failures of the glcpp/tests/glcpp-test. I
> think it's because it's trying to write out files into the
> distribution d
On Mon, Dec 8, 2014 at 1:54 PM, Ian Romanick wrote:
>> diff --git a/configure.ac b/configure.ac
>> index b0df1bb..7dc435a 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -253,8 +253,9 @@ AC_SUBST([VISIBILITY_CXXFLAGS])
>> dnl
>> dnl Optional flags, check for compiler support
>> dnl
>>
On 12/07/2014 04:13 AM, Timothy Arceri wrote:
> Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but
> that is an assumption OpenGL drivers (or any dynamic library for that matter)
> can't afford to make as there are many closed- and open- source application
> binaries out
Has the game vendor been notified of their bug? This won't work on any
OpenGL ES 2.x or 3.x implementation (there *is* a conformance test), and
AMD has said they're going to make their driver be conformant too.
On 12/08/2014 10:43 AM, Sven Arvidsson wrote:
> Signed-off-by: Sven Arvidsson
> Bugzi
Dead since 2010 (commit 284ce209).
Reviewed-by: Ian Romanick
---
src/mesa/program/prog_instruction.c | 17 -
src/mesa/program/prog_instruction.h | 4
2 files changed, 21 deletions(-)
diff --git a/src/mesa/program/prog_instruction.c
b/src/mesa/program/prog_instruction.c
in
On 12/02/2014 12:10 AM, Valentin Corfu wrote:
> With this check we can avoid segmentation fault when invalid value used
> during eglCreateContext.
>
> Cc: mesa-sta...@lists.freedesktop.org
> Cc: mesa-dev@lists.freedesktop.org
> Signed-off-by: Valentin Corfu
> ---
> src/egl/drivers/dri2/egl_dri2
On Mon, Dec 8, 2014 at 1:39 PM, Ian Romanick wrote:
> On 12/08/2014 11:56 AM, Matt Turner wrote:
>
>> diff --git a/src/mesa/program/prog_instruction.c
>> b/src/mesa/program/prog_instruction.c
>> index 976024e..c1b9527 100644
>> --- a/src/mesa/program/prog_instruction.c
>> +++ b/src/mesa/program/p
Didn't Gallium also remove the FREE business?
Either way, patch 1 and 2 are
Reviewed-by: Ian Romanick
I sent a comment on patch 3. With that comment resolved in patch 3 or
as a patch 4, patch 3 is also
Reviewed-by: Ian Romanick
On 12/08/2014 11:56 AM, Matt Turner wrote:
> See commits 506750
On 12/08/2014 11:56 AM, Matt Turner wrote:
> diff --git a/src/mesa/program/prog_instruction.c
> b/src/mesa/program/prog_instruction.c
> index 976024e..c1b9527 100644
> --- a/src/mesa/program/prog_instruction.c
> +++ b/src/mesa/program/prog_instruction.c
> @@ -87,13 +87,7 @@ struct prog_instructio
On Mon, Dec 8, 2014 at 1:34 PM, Ian Romanick wrote:
> Reviewed-by: Ian Romanick
>
> How'd you come across this?
I saw a scary looking warning during the make distcheck build. :)
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.free
On Tue, Dec 2, 2014 at 12:10 AM, Valentin Corfu wrote:
> With this check we can avoid segmentation fault when invalid value used
> during eglCreateContext.
Kristian, Ian, can one of you review this?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.
Reviewed-by: Ian Romanick
How'd you come across this?
On 12/08/2014 11:34 AM, Matt Turner wrote:
> ---
> Patch formatted with -U22 so that reviewers can see regs definition,
> and last element initialization with -1.
>
> src/mesa/drivers/dri/r200/r200_sanity.c | 2 +-
> 1 file changed, 1 inser
Series is
Reviewed-by: Ian Romanick
On 12/08/2014 04:05 AM, Abdiel Janulgue wrote:
> Fixes an infinite loop in swrast where the lowering pass unpacks saturate into
> clamp but the opt_algebraic pass tries to do the opposite.
>
> v3 (Ian):
> This is a revert of commit cfa8c1cb "ir_to_mesa: lower
On Fri, Dec 5, 2014 at 6:18 PM, Vinson Lee wrote:
> This patch fixes this build error with GCC <= 4.6.
Change GCC to G++ here and in the commit message, and
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists
Reviewed-by: Brian Paul
On 12/08/2014 01:02 PM, Matt Turner wrote:
Reduces .text size of mesa_dri_drivers.so (i965-only) by 62k, or 1.4%.
Note that we don't remove inline from lerp_2d(), which has a comment
above it saying it definitely should be inlined. Though, removing the
inline keyword
On 12/08/2014 12:56 PM, Matt Turner wrote:
See commits 5067506e and b6109de3 for the Coccinelle script.
---
src/gallium/auxiliary/util/u_debug_flush.c | 12
src/gallium/drivers/i915/i915_state.c| 10 --
src/gallium/drivers/ilo/shader/toy_tgsi.c
Reduces .text size of mesa_dri_drivers.so (i965-only) by 62k, or 1.4%.
Note that we don't remove inline from lerp_2d(), which has a comment
above it saying it definitely should be inlined. Though, removing the
inline keyword from it doesn't actually change the compiled code for me.
---
src/mesa/s
See commit 2b7a972e for the Coccinelle script.
---
src/gallium/state_trackers/glx/xlib/glx_api.c | 12 +---
src/gallium/state_trackers/glx/xlib/glx_usefont.c | 2 +-
src/gallium/state_trackers/glx/xlib/xm_api.c | 2 +-
src/gallium/state_trackers/wgl/stw_tls.c | 2 +-
s
See commit 6bda027e for the Coccinelle script.
---
src/egl/drivers/dri2/platform_wayland.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_wayland.c
b/src/egl/drivers/dri2/platform_wayland.c
index 59b2792..ba0eb10 100644
--- a/src/egl/drivers/dr
See commits 5067506e and b6109de3 for the Coccinelle script.
---
src/gallium/auxiliary/util/u_debug_flush.c | 12
src/gallium/drivers/i915/i915_state.c| 10 --
src/gallium/drivers/ilo/shader/toy_tgsi.c| 6 ++
src/gallium/drivers/nouve
---
Patch formatted with -U22 so that reviewers can see regs definition,
and last element initialization with -1.
src/mesa/drivers/dri/r200/r200_sanity.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/r200/r200_sanity.c
b/src/mesa/drivers/dri/r200/r200_s
It's actually quite nice in our hardware drivers. The viewport
transformation enable bit and the computation of 1/w bit now lives in
the VS state. The clip enable bits have to be derived from both the VS
and the rasterizer state on most/all drivers anyway (based on
whether ClipDistances or ClipVert
On Mon, Dec 8, 2014 at 10:43 AM, Sven Arvidsson wrote:
> Signed-off-by: Sven Arvidsson
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87076
> ---
Thanks!
(When someone commits this, please tag it for 10.4)
___
mesa-dev mailing list
mesa-dev@
Signed-off-by: Sven Arvidsson
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87076
---
src/mesa/drivers/dri/common/drirc | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/drivers/dri/common/drirc
b/src/mesa/drivers/dri/common/drirc
index 4b9841b..cecd6a9 100644
--- a/src/m
Am 06.12.2014 um 18:24 schrieb Marek Olšák:
> Ping.
>
> On Mon, Nov 17, 2014 at 10:43 PM, Marek Olšák wrote:
>> From: Marek Olšák
>>
>> Required by Nine. Tested with util_run_tests.
>> It's added to softpipe, llvmpipe, and r300g/swtcl.
>> ---
>> src/gallium/auxiliary/draw/draw_context.c
Thanks Abdiel. This series looks good to me.
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
I'm not particularly knowledgeable about autoconf/make, but it looks
correct AFAICT. Thanks for doing this.
I think it would be useful to also add a comment somewhere on why
-mstackrealign is necessary for 32-bits, for future reference.
Reviewed-by: Jose Fonseca
Jose
On 07/12/14 12:13, Ti
https://bugs.freedesktop.org/show_bug.cgi?id=86788
--- Comment #13 from José Fonseca ---
Timothy,
Sorry for jumping into wrong conclusions, and thanks for pursuing a more
comprehensive fix. I appreciate it.
Jose
--
You are receiving this mail because:
You are the assignee for the bug.
__
Fixes an infinite loop in swrast where the lowering pass unpacks saturate into
clamp but the opt_algebraic pass tries to do the opposite.
v3 (Ian):
This is a revert of commit cfa8c1cb "ir_to_mesa: lower ir_unop_saturate" on
the ir_to_mesa.cpp portion. prog_execute.c can handle saturates in vertex
v3: Fix multi-line comment format (Ian)
Signed-off-by: Abdiel Janulgue
---
src/glsl/opt_algebraic.cpp | 2 +-
src/mesa/main/mtypes.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
index c4f883b..c6f4a9c 100644
---
There is a bug in the current lowering pass implementation where we lower
saturate
to clamp only for vertex shaders on drivers supporting SM 3.0. The correct
behavior
is to actually lower to clamp only when we don't support saturate which happens
on drivers that don't support SM 3.0
Reviewed-by:
Hi,
On 12/06/2014 05:46 AM, Jonathan Gray wrote:
Along with the ABI-check scripts it seems at the very least
all occurances of "#!/bin/bash" should be changed to
"#!/usr/bin/env bash" if they are actually bash specific.
Debian's devscripts package's checkbashisms checker tells about Bash needs
Hi Ian,
On 12/04/2014 01:01 AM, Ian Romanick wrote:
> On 12/01/2014 05:47 AM, Abdiel Janulgue wrote:
>> Fixes an infinite loop in swrast where the lowering pass unpacks saturate
>> into clamp
>
> Which swrast are we talking about here? Classic swrast? softpipe?
> llvmpipe?
Classic swrast. Alt
On 12/06/2014 07:13 AM, Vadim Girlin wrote:
On 12/04/2014 01:43 AM, Dave Airlie wrote:
Hi Vadim,
I've been looking with Glenn's help into a bug in sb for a couple of
weeks now triggered by a change in how GLSL generates switch
statements.
I understand you probably aren't too interested in r600
On Sun, Dec 7, 2014 at 6:57 PM, Matt Turner wrote:
> I've seen some (sporadic?) failures of the glcpp/tests/glcpp-test. I
> think it's because it's trying to write out files into the
> distribution directory, which isn't allowed. I'll try to track that
> down.
That's now fixed. glcpp-test was wri
65 matches
Mail list logo
