[Mesa-dev] [PATCH v3] mesa: add GL_RED, GL_RG support for floating point textures

2015-06-09 Thread Tapani Pälli
Mesa supports EXT_texture_rg and OES_texture_float. This patch adds support for using unsized enums GL_RED and GL_RG for floating point targets and writes proper checks for internalformat when format is GL_RED or GL_RG and type is of GL_FLOAT or GL_HALF_FLOAT. Later, internalformat will get

Re: [Mesa-dev] [PATCH] i965: do not round line width when multisampling or antialiasing are enabled

2015-06-09 Thread Iago Toral
On Tue, 2015-06-09 at 01:49 -0700, Kenneth Graunke wrote: On Tuesday, June 09, 2015 08:49:54 AM Iago Toral Quiroga wrote: In commit fe74fee8fa721a we rounded the line width to the nearest integer to match the GLES3 spec requirements stated in section 13.4.2.1, but that seems to break a dEQP

Re: [Mesa-dev] [PATCH v2] mesa: add GL_RED, GL_RG support for floating point textures

2015-06-09 Thread Tapani Pälli
On 06/09/2015 11:25 AM, Kenneth Graunke wrote: On Tuesday, June 09, 2015 09:53:42 AM Tapani Pälli wrote: Mesa supports EXT_texture_rg and OES_texture_float. This patch adds support for using unsized enums GL_RED and GL_RG for floating point targets and writes proper checks for internalformat

Re: [Mesa-dev] [PATCH] glsl: remove restriction on unsized arrays in GLSL ES 3.10

2015-06-09 Thread Tapani Pälli
Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 06/09/2015 10:03 AM, Timothy Arceri wrote: --- src/glsl/ast_to_hir.cpp | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index dfe106b..350f6ed 100644 ---

Re: [Mesa-dev] [PATCH] i965: do not round line width when multisampling or antialiasing are enabled

2015-06-09 Thread Kenneth Graunke
On Tuesday, June 09, 2015 08:49:54 AM Iago Toral Quiroga wrote: In commit fe74fee8fa721a we rounded the line width to the nearest integer to match the GLES3 spec requirements stated in section 13.4.2.1, but that seems to break a dEQP test that renders wide lines in some multisampling scenarios.

Re: [Mesa-dev] [PATCH 1/2] clover: Implement image attribute getters

2015-06-09 Thread Zoltán Gilián
Ok, thanks for the feedback. On Mon, Jun 8, 2015 at 2:18 PM, Francisco Jerez curroje...@riseup.net wrote: Zoltan Gilian zoltan.gil...@gmail.com writes: Image attributes are passed to the kernel as hidden parameters after the image attribute itself. An llvm pass replaces the getter builtins

Re: [Mesa-dev] [PATCH resend 3/7] i965: Enable hardware-generated binding tables on render path.

2015-06-09 Thread Kenneth Graunke
On Thursday, June 04, 2015 02:03:21 AM Kenneth Graunke wrote: On Thursday, June 04, 2015 11:38:52 AM Abdiel Janulgue wrote: On 06/02/2015 10:54 AM, Kenneth Graunke wrote: On Monday, June 01, 2015 03:14:26 PM Abdiel Janulgue wrote: [snip] I'm the one who is being funny here. After

Re: [Mesa-dev] [PATCH v2] mesa: add GL_RED, GL_RG support for floating point textures

2015-06-09 Thread Kenneth Graunke
On Tuesday, June 09, 2015 09:53:42 AM Tapani Pälli wrote: Mesa supports EXT_texture_rg and OES_texture_float. This patch adds support for using unsized enums GL_RED and GL_RG for floating point targets and writes proper checks for internalformat when format is GL_RED or GL_RG and type is of

Re: [Mesa-dev] [PATCH 1/2] tgsi: texture types

2015-06-09 Thread Jose Fonseca
On 09/06/15 04:03, Rob Clark wrote: On Mon, Jun 8, 2015 at 10:50 PM, Roland Scheidegger srol...@vmware.com wrote: Am 09.06.2015 um 04:40 schrieb Rob Clark: On Mon, Jun 8, 2015 at 10:36 PM, Roland Scheidegger srol...@vmware.com wrote: Am 09.06.2015 um 04:20 schrieb Rob Clark: On Mon, Jun 8,

[Mesa-dev] [PATCH] glsl: remove cross validation of interpolation qualifier with GLSL 4.40

2015-06-09 Thread Tapani Pälli
Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/glsl/link_varyings.cpp | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 7b2d4bd..a19ee39 100644 --- a/src/glsl/link_varyings.cpp +++

Re: [Mesa-dev] [PATCH 2/2] r600, compute: Allow image resource creation

2015-06-09 Thread Zoltán Gilián
Why keeping the assertion commented out? Because to test the image support functionality I'm working on, I have to create an image and pass it to a kernel, which triggers the assertion ATM. Can you just fix evergreen_set_cs_sampler_view so that it supports views==NULL? Fair point, will do

Re: [Mesa-dev] [PATCH 01/38] i965/fs: Introduce FS IR builder.

2015-06-09 Thread Francisco Jerez
Matt Turner matts...@gmail.com writes: On Fri, Jun 5, 2015 at 4:13 PM, Francisco Jerez curroje...@riseup.net wrote: Matt Turner matts...@gmail.com writes: On Fri, Jun 5, 2015 at 1:42 PM, Francisco Jerez curroje...@riseup.net wrote: Matt Turner matts...@gmail.com writes: On Thu, Jun 4,

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Don't let the EOT send message interfere with the MRF hack

2015-06-09 Thread Neil Roberts
Both patches look good to me and I can confirm they make the Piglit tests pass on Skylake. Reviewed-by: Neil Roberts n...@linux.intel.com My original assumption of the problem was that the implied writes from the SCRATCH_WRITE instruction aren't taken into account when calculating the liveliness

[Mesa-dev] [PATCH 0/4] sampler array indexing fixes v2

2015-06-09 Thread Tapani Pälli
Here's a series of patches to tackle bug 84225. Previous series was discussed in this thread: http://lists.freedesktop.org/archives/mesa-dev/2015-May/084604.html Thanks; Tapani Pälli (4): glsl: Allow dynamic sampler array indexing with GLSL ES 3.00 mesa/glsl: new compiler option

[Mesa-dev] [PATCH 1/4] glsl: Allow dynamic sampler array indexing with GLSL ES 3.00

2015-06-09 Thread Tapani Pälli
Dynamic indexing of sampler arrays is prohibited by GLSL ES 3.00. Earlier versions allow 'constant-index-expression' indexing, where index can contain a loop induction variable. Patch allows dynamic indexing for sampler arrays when GLSL ES 3.00. This change makes 'sampler-array-index.frag'

[Mesa-dev] [PATCH 2/4] mesa/glsl: new compiler option UnrollSamplerArrayDynamicIndexing

2015-06-09 Thread Tapani Pälli
Patch provides new compiler option for backend to force unroll loops that have non-constant expression indexing on sampler arrays. This makes sure that we can never end up with a shader that uses loop induction variable as sampler array index but does not unroll because of having too much

[Mesa-dev] [PATCH 3/4] i965: use UnrollSamplerArrayDynamicIndexing for gen 7

2015-06-09 Thread Tapani Pälli
Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/drivers/dri/i965/brw_context.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 652d9a3..38c6f72 100644 ---

[Mesa-dev] [PATCH 4/4] glsl: validate sampler array indexing for 'constant-index-expression'

2015-06-09 Thread Tapani Pälli
Desktop GLSL 130 and GLSL ES 300 allow sampler array indexing where index can contain a loop induction variable. This extra check will warn during linking if some of the indexes could not be turned in to constant expressions. v2: warning instead of error for backends that did not enable

Re: [Mesa-dev] [PATCH resend 3/7] i965: Enable hardware-generated binding tables on render path.

2015-06-09 Thread Abdiel Janulgue
Thanks a lot Ken! Your help in debugging this pointed me in the right direction! I had some further observations below: On 06/09/2015 11:08 AM, Kenneth Graunke wrote: (To bring the mailing list up to speed: Abdiel mentioned on IRC tonight that this is actually still necessary---some Piglit

Re: [Mesa-dev] [PATCH v2 09/82] mesa: Add shader storage buffer support to struct gl_context

2015-06-09 Thread Samuel Iglesias Gonsálvez
On 08/06/15 23:36, Jordan Justen wrote: On 2015-06-03 00:00:59, Iago Toral Quiroga wrote: This includes the array of bindings, the current buffer bound to the GL_SHADER_STORAGE_BUFFER target and a set of general limits and default values for shader storage buffers. ---

Re: [Mesa-dev] [PATCH v2 08/82] glsl: lower SSBO reads to ir_binop_ssbo_load expressions

2015-06-09 Thread Samuel Iglesias Gonsálvez
On 08/06/15 23:25, Jordan Justen wrote: Patches 3-8 Reviewed-by: Jordan Justen jordan.l.jus...@intel.com Thanks Jordan! Sam On 2015-06-03 00:00:58, Iago Toral Quiroga wrote: From: Kristian Høgsberg k...@bitplanet.net The same we do for UBO loads with ir_binop_ubo_load. ---

[Mesa-dev] [PATCH v2] mesa: add GL_RED, GL_RG support for floating point textures

2015-06-09 Thread Tapani Pälli
Mesa supports EXT_texture_rg and OES_texture_float. This patch adds support for using unsized enums GL_RED and GL_RG for floating point targets and writes proper checks for internalformat when format is GL_RED or GL_RG and type is of GL_FLOAT or GL_HALF_FLOAT. Later, internalformat will get

[Mesa-dev] [PATCH] i965: do not round line width when multisampling or antialiasing are enabled

2015-06-09 Thread Iago Toral Quiroga
In commit fe74fee8fa721a we rounded the line width to the nearest integer to match the GLES3 spec requirements stated in section 13.4.2.1, but that seems to break a dEQP test that renders wide lines in some multisampling scenarios. Ian noted that the Open 4.4 spec has the following similar text:

[Mesa-dev] [PATCH] glsl: remove restriction on unsized arrays in GLSL ES 3.10

2015-06-09 Thread Timothy Arceri
--- src/glsl/ast_to_hir.cpp | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index dfe106b..350f6ed 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -3850,7 +3850,15 @@

[Mesa-dev] [PATCH v3] egl/dri2: implement platform_surfaceless (v3)

2015-06-09 Thread Zach Reizner
From: Haixia Shi h...@chromium.org The surfaceless platform is for off-screen rendering only. Render node support is required. Only consider the render nodes. Do not use normal nodes as they require auth hooks. v3: change platform_null to platform_surfaceless Signed-off-by: Haixia Shi

Re: [Mesa-dev] [PATCH v2 09/82] mesa: Add shader storage buffer support to struct gl_context

2015-06-09 Thread Samuel Iglesias Gonsálvez
On 09/06/15 08:18, Samuel Iglesias Gonsálvez wrote: On 08/06/15 23:36, Jordan Justen wrote: On 2015-06-03 00:00:59, Iago Toral Quiroga wrote: This includes the array of bindings, the current buffer bound to the GL_SHADER_STORAGE_BUFFER target and a set of general limits and default values

Re: [Mesa-dev] [PATCH] rtasm: Generalize executable memory allocator to all Unices.

2015-06-09 Thread Roland Scheidegger
Am 09.06.2015 um 15:48 schrieb Jose Fonseca: We're only using fairly portable standard Unix calls here, so might as well save ourselves future trouble by enabling on all Unices by default.

Re: [Mesa-dev] [PATCH] i965: do not round line width when multisampling or antialiasing are enabled

2015-06-09 Thread Ian Romanick
On 06/08/2015 11:49 PM, Iago Toral Quiroga wrote: In commit fe74fee8fa721a we rounded the line width to the nearest integer to match the GLES3 spec requirements stated in section 13.4.2.1, but that seems to break a dEQP test that renders wide lines in some multisampling scenarios. Ian noted

Re: [Mesa-dev] [PATCH] mesa/es3.1: enable DRAW_INDIRECT_BUFFER_BINDING for gles3.1

2015-06-09 Thread Ian Romanick
On 05/06/2015 03:43 AM, Tapani Pälli wrote: (increases ES31-CTS.draw_indirect.basic.* passing tests) v2: only expose DRAW_INDIRECT_BUFFER_BINDING for GL core + ES3.1 Signed-off-by: Tapani Pälli tapani.pa...@intel.com I would have rather seen adding the EXTRA_API_ES31 bits and the

[Mesa-dev] [Bug 90904] OSX: EXC_BAD_ACCESS when using translate_sse + gallium + softpipe/llvmpipe

2015-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90904 José Fonseca jfons...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] rtasm: Generalize executable memory allocator to all Unices.

2015-06-09 Thread Brian Paul
On 06/09/2015 07:48 AM, Jose Fonseca wrote: We're only using fairly portable standard Unix calls here, so might as well save ourselves future trouble by enabling on all Unices by default. https://bugs.freedesktop.org/show_bug.cgi?id=90904 --- src/gallium/auxiliary/rtasm/rtasm_execmem.c | 2 +-

Re: [Mesa-dev] [PATCH 2/7] mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1

2015-06-09 Thread Ian Romanick
On 05/06/2015 01:53 AM, Marta Lofstedt wrote: GL_ARB_shader_image_load store support is required for GLES 3.1 conformance. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 8 2 files

Re: [Mesa-dev] Mesa (master): mesa: Allow overriding the version of ES2+ contexts

2015-06-09 Thread Ian Romanick
On 05/29/2015 02:44 AM, Michel Dänzer wrote: Hi Ian, On 29.05.2015 09:00, i...@kemper.freedesktop.org (Ian Romanick) wrote: Module: Mesa Branch: master Commit: 9b5e92f4ccc6ee1cb9caea947f6efaad2b391cf1 URL:

Re: [Mesa-dev] [PATCH] glsl/es31:Allow GL_ARB_TEXTURE_MULTISAMPLE in GLSL ES 3.10

2015-06-09 Thread Ian Romanick
On 05/12/2015 08:00 AM, Ilia Mirkin wrote: On Tue, May 12, 2015 at 10:53 AM, Marta Lofstedt marta.lofst...@linux.intel.com wrote: From: Marta Lofstedt marta.lofst...@intel.com Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/glsl/builtin_functions.cpp | 3 +--

Re: [Mesa-dev] [PATCH 3/5] glcpp: Allow arithmetic integer expressions in #line

2015-06-09 Thread Ian Romanick
On 03/11/2015 02:01 AM, Eduardo Lima Mitev wrote: From: Antia Puentes apuen...@igalia.com From section 3.4 (Preprocessor) of the GLSL ES 3.00 specification: #line must have, after macro substitution, one of the following forms: #line line #line line source-string-number where

Re: [Mesa-dev] [PATCH v2 1/6] mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1

2015-06-09 Thread Ian Romanick
On 05/07/2015 12:57 AM, Marta Lofstedt wrote: From: Marta Lofstedt marta.lofst...@intel.com v2: only expose enums from GL_ARB_shader_image_load_store for gles 3.1 and GL core We expose all of these extensions on compatibility profile, so only allowing the queries in core profile is going to

Re: [Mesa-dev] [PATCH 3/6] i965: Extract tiling from fast clear decision

2015-06-09 Thread Anuj Phogat
On Mon, Jun 8, 2015 at 3:38 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: There are several constraints when determining if one can fast clear a surface. Some of these are alignment, pixel density, tiling formats, and others that vary by generation. The helper function which exists

Re: [Mesa-dev] [PATCH 1/2] tgsi: texture types

2015-06-09 Thread Rob Clark
On Tue, Jun 9, 2015 at 9:32 AM, Roland Scheidegger srol...@vmware.com wrote: Am 09.06.2015 um 15:00 schrieb Rob Clark: On Tue, Jun 9, 2015 at 5:01 AM, Jose Fonseca jfons...@vmware.com wrote: On 09/06/15 04:03, Rob Clark wrote: On Mon, Jun 8, 2015 at 10:50 PM, Roland Scheidegger

Re: [Mesa-dev] [PATCH 2/7] mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1

2015-06-09 Thread Ian Romanick
On 06/09/2015 08:48 AM, Ian Romanick wrote: On 05/06/2015 01:53 AM, Marta Lofstedt wrote: GL_ARB_shader_image_load store support is required for GLES 3.1 conformance. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Don't let the EOT send message interfere with the MRF hack

2015-06-09 Thread Jason Ekstrand
On Tue, Jun 9, 2015 at 4:05 AM, Neil Roberts n...@linux.intel.com wrote: Both patches look good to me and I can confirm they make the Piglit tests pass on Skylake. Reviewed-by: Neil Roberts n...@linux.intel.com My original assumption of the problem was that the implied writes from the

Re: [Mesa-dev] [PATCH 01/38] i965/fs: Introduce FS IR builder.

2015-06-09 Thread Jason Ekstrand
On Mon, Jun 8, 2015 at 9:50 AM, Matt Turner matts...@gmail.com wrote: On Fri, Jun 5, 2015 at 4:13 PM, Francisco Jerez curroje...@riseup.net wrote: Matt Turner matts...@gmail.com writes: On Fri, Jun 5, 2015 at 1:42 PM, Francisco Jerez curroje...@riseup.net wrote: Matt Turner

Re: [Mesa-dev] [PATCH 2/7] mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1

2015-06-09 Thread Ian Romanick
On 06/09/2015 09:08 AM, Ian Romanick wrote: On 06/09/2015 08:48 AM, Ian Romanick wrote: On 05/06/2015 01:53 AM, Marta Lofstedt wrote: GL_ARB_shader_image_load store support is required for GLES 3.1 conformance. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c

Re: [Mesa-dev] [PATCH v2] mesa/es3.1: Pass sample count check for multisampled textures

2015-06-09 Thread Ian Romanick
On 05/12/2015 01:46 AM, Marta Lofstedt wrote: From: Marta Lofstedt marta.lofst...@intel.com v2 : Refine the restriction to Version == 30. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/multisample.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH] i965/gen9: Use raw PS invocation count for queries

2015-06-09 Thread Anuj Phogat
On Mon, Jun 8, 2015 at 3:50 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: Previously the number needed to be divided by 4 to get the proper results. Now the hardware does the right thing. Through experimentation it seems Braswell (CHV) does also need this. Fixes piglit test:

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Don't let the EOT send message interfere with the MRF hack

2015-06-09 Thread Jason Ekstrand
On Tue, Jun 9, 2015 at 11:11 AM, Neil Roberts n...@linux.intel.com wrote: Jason Ekstrand ja...@jlekstrand.net writes: The only place when the fact that the MRFs are virtual matters is in register allocation. Implied MRF writes are taken into account in setup_mrf_hack_interference. We figure

Re: [Mesa-dev] [RFC v2 10/15] i965: enable ASTC support for Skylake

2015-06-09 Thread Ian Romanick
Should this patch be last? It looks like later patches fix bugs. On 06/01/2015 10:13 AM, Nanley Chery wrote: From: Nanley Chery nanley.g.ch...@intel.com v2: remove OES ASTC extension reference. Signed-off-by: Nanley Chery nanley.g.ch...@intel.com ---

Re: [Mesa-dev] [PATCH v2 09/82] mesa: Add shader storage buffer support to struct gl_context

2015-06-09 Thread Jordan Justen
On 2015-06-09 00:30:45, Samuel Iglesias Gonsálvez wrote: On 09/06/15 08:18, Samuel Iglesias Gonsálvez wrote: On 08/06/15 23:36, Jordan Justen wrote: On 2015-06-03 00:00:59, Iago Toral Quiroga wrote: This includes the array of bindings, the current buffer bound to the

Re: [Mesa-dev] [PATCH v2 12/82] glsl: shader buffer variables cannot have initializers

2015-06-09 Thread Jordan Justen
On 2015-06-03 00:01:02, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com Section 4.3.7 Buffer Variables of the GLSL 4.30 spec: Buffer variables cannot have initializers. Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com ---

Re: [Mesa-dev] [RFC v2 03/15] mesa: disable online compression for ASTC formats

2015-06-09 Thread Ian Romanick
On 06/01/2015 10:13 AM, Nanley Chery wrote: From: Nanley Chery nanley.g.ch...@intel.com Signed-off-by: Nanley Chery nanley.g.ch...@intel.com --- src/mesa/main/texcompress.c | 22 ++ src/mesa/main/teximage.c| 28 2 files changed, 50

Re: [Mesa-dev] [PATCH 1/2] tgsi: texture types

2015-06-09 Thread Marek Olšák
If you only want to modify TGSI and not all the users, you only have to fix tgsi_ureg. tgsi_ureg is a layer that can hide a lot of small ugly details if needed, including sampler view declarations when the users don't even know about them. Marek On Tue, Jun 9, 2015 at 6:01 PM, Rob Clark

Re: [Mesa-dev] [PATCH resend 3/7] i965: Enable hardware-generated binding tables on render path.

2015-06-09 Thread Kenneth Graunke
On Tuesday, June 09, 2015 03:01:00 PM Abdiel Janulgue wrote: Thanks a lot Ken! Your help in debugging this pointed me in the right direction! I had some further observations below: On 06/09/2015 11:08 AM, Kenneth Graunke wrote: (To bring the mailing list up to speed: Abdiel mentioned

Re: [Mesa-dev] [PATCH 1/5] mesa: Fix errors values returned by glShaderBinary()

2015-06-09 Thread Ian Romanick
On 06/04/2015 06:38 PM, Ben Widawsky wrote: On Wed, Mar 11, 2015 at 10:01:24AM +0100, Eduardo Lima Mitev wrote: Page 68, section 7.2 'Shader Binaries of the of the OpenGL ES 3.1, and page 88 of the OpenGL 4.5 specs state: An INVALID_VALUE error is generated if count or length is negative.

Re: [Mesa-dev] [PATCH 3/5] glcpp: Allow arithmetic integer expressions in #line

2015-06-09 Thread Ian Romanick
On 06/09/2015 10:40 AM, Carl Worth wrote: On Tue, Jun 09 2015, Ian Romanick wrote: From section 3.4 (Preprocessor) of the GLSL ES 3.00 specification: #line must have, after macro substitution, one of the following forms: #line line #line line source-string-number where line and

Re: [Mesa-dev] [RFC v2 08/15] mesa/formats: store whether or not a format is sRGB in gl_format_info

2015-06-09 Thread Ian Romanick
On 06/01/2015 10:13 AM, Nanley Chery wrote: From: Nanley Chery nanley.g.ch...@intel.com v2: remove extra newline. Signed-off-by: Nanley Chery nanley.g.ch...@intel.com --- src/mesa/main/format_info.py | 2 ++ src/mesa/main/formats.c | 28 2 files

Re: [Mesa-dev] [PATCH] i965: do not round line width when multisampling or antialiasing are enabled

2015-06-09 Thread Kenneth Graunke
On Tuesday, June 09, 2015 11:29:48 AM Iago Toral wrote: On Tue, 2015-06-09 at 01:49 -0700, Kenneth Graunke wrote: On Tuesday, June 09, 2015 08:49:54 AM Iago Toral Quiroga wrote: In commit fe74fee8fa721a we rounded the line width to the nearest integer to match the GLES3 spec

Re: [Mesa-dev] [PATCH v2 11/82] glsl: enable binding layout qualifier usage for shader storage buffer objects

2015-06-09 Thread Jordan Justen
On 2015-06-03 00:01:01, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com See GLSL 4.30 spec, section 4.4.5 Uniform and Shader Storage Block Layout Qualifiers. Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com --- src/glsl/ast_to_hir.cpp | 29

Re: [Mesa-dev] [PATCH 01/38] i965/fs: Introduce FS IR builder.

2015-06-09 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: On Mon, Jun 8, 2015 at 9:50 AM, Matt Turner matts...@gmail.com wrote: On Fri, Jun 5, 2015 at 4:13 PM, Francisco Jerez curroje...@riseup.net wrote: Matt Turner matts...@gmail.com writes: On Fri, Jun 5, 2015 at 1:42 PM, Francisco Jerez

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Don't let the EOT send message interfere with the MRF hack

2015-06-09 Thread Neil Roberts
Jason Ekstrand ja...@jlekstrand.net writes: The only place when the fact that the MRFs are virtual matters is in register allocation. Implied MRF writes are taken into account in setup_mrf_hack_interference. We figure out what MRFs are used and then mark them as conflicting with *all* of

Re: [Mesa-dev] [RFC v2 12/15] i965: correct VALIGN for 2d textures on Skylake

2015-06-09 Thread Ian Romanick
On 06/01/2015 10:13 AM, Nanley Chery wrote: From: Nanley Chery nanley.g.ch...@intel.com In agreement with commit 4ab8d59a23, vertical alignment values are equal to four times the block height on Gen9+. Signed-off-by: Nanley Chery nanley.g.ch...@intel.com ---

Re: [Mesa-dev] [PATCH 3/5] glcpp: Allow arithmetic integer expressions in #line

2015-06-09 Thread Carl Worth
On Tue, Jun 09 2015, Ian Romanick wrote: From section 3.4 (Preprocessor) of the GLSL ES 3.00 specification: #line must have, after macro substitution, one of the following forms: #line line #line line source-string-number where line and source-string-number are constant integral

Re: [Mesa-dev] [PATCH 5/5] glsl: Avoid buffer overflow when assigning attribute locations

2015-06-09 Thread Ian Romanick
On 03/11/2015 02:01 AM, Eduardo Lima Mitev wrote: From: Iago Toral Quiroga ito...@igalia.com Shaders with excessive number of attributes (16) can produce a crash due to buffer overflow in assign_attribute_or_color_locations. The overflow can happen because we declare a fixed size array that

Re: [Mesa-dev] [PATCH v3] mesa: add GL_RED, GL_RG support for floating point textures

2015-06-09 Thread Kenneth Graunke
On Tuesday, June 09, 2015 12:26:48 PM Tapani Pälli wrote: Mesa supports EXT_texture_rg and OES_texture_float. This patch adds support for using unsized enums GL_RED and GL_RG for floating point targets and writes proper checks for internalformat when format is GL_RED or GL_RG and type is of

Re: [Mesa-dev] [RFC v2 14/15] i965: refactor miptree alignment calculation code

2015-06-09 Thread Ian Romanick
On 06/01/2015 10:13 AM, Nanley Chery wrote: From: Nanley Chery nanley.g.ch...@intel.com - Remove redundant checks and comments by grouping our calculations for align_w and align_h wherever possible. - Don't pass more parameters than necessary. - Minor code simplifications.

Re: [Mesa-dev] [PATCH 1/2] clover: fix event handling of buffer operations

2015-06-09 Thread Francisco Jerez
Hi Grigori, Grigori Goronzy g...@chown.ath.cx writes: Wrap MapBuffer and MapImage as hard_event actions, like other operations. This enables correct profiling. Also make sure to wait for events to finish when blocking is requested by the caller. ---

[Mesa-dev] [PATCH 2/4] gallium: Enable build of NIR support on Android.

2015-06-09 Thread Eric Anholt
--- src/gallium/auxiliary/Android.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/Android.mk b/src/gallium/auxiliary/Android.mk index 2d91752..4e204f9 100644 --- a/src/gallium/auxiliary/Android.mk +++ b/src/gallium/auxiliary/Android.mk @@ -30,6 +30,7 @@ include

[Mesa-dev] [PATCH 3/4] vc4: Add support for building on Android.

2015-06-09 Thread Eric Anholt
--- Android.mk| 2 +- src/gallium/Android.mk| 5 + src/gallium/drivers/vc4/Android.mk| 39 +++ src/gallium/targets/dri/Android.mk| 4 src/gallium/winsys/vc4/drm/Android.mk | 34

[Mesa-dev] [PATCH 4/4] gallium: Drop the gallium-specific Android sw winsys.

2015-06-09 Thread Eric Anholt
This was part of gallium_egl, and we now have the normal libEGL Android winsys support to handle it. --- src/gallium/winsys/sw/android/Android.mk | 34 --- .../winsys/sw/android/android_sw_winsys.cpp| 264 - src/gallium/winsys/sw/android/android_sw_winsys.h

[Mesa-dev] [PATCH] egl: Drop check for driver != NULL.

2015-06-09 Thread Eric Anholt
Back in 2013, a patch was added (with 2 reviewers!) at the end of the block to early exit the loop in this case, without noticing that the loop already did. I added another early exit case, again without noticing, but Rob caught me. Just drop the loop condition that apparently surprises most of

[Mesa-dev] [PATCH 1/4] egl/dri2: Fix Android Lollipop build on ARM.

2015-06-09 Thread Eric Anholt
--- src/egl/drivers/dri2/Android.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/drivers/dri2/Android.mk b/src/egl/drivers/dri2/Android.mk index d4d809b..109e4d4 100644 --- a/src/egl/drivers/dri2/Android.mk +++ b/src/egl/drivers/dri2/Android.mk @@ -36,6 +36,7 @@ LOCAL_CFLAGS := \

Re: [Mesa-dev] [PATCH 2/2] clover: check clEnqueueMap* for map errors

2015-06-09 Thread Francisco Jerez
Grigori Goronzy g...@chown.ath.cx writes: Mapping can fail, and this should be handled. Return the proper error code and abort the associated event in this case. --- src/gallium/state_trackers/clover/api/transfer.cpp | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH 3/3] i965: Export format comparison for blitting between miptrees

2015-06-09 Thread Alexander Monakov
Hello, Unfortunately, this patch breaks things further, because... On Fri, Jun 5, 2015 at 5:14 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: @@ -76,8 +77,14 @@ do_blit_drawpixels(struct gl_context * ctx, struct gl_renderbuffer *rb = ctx-DrawBuffer-_ColorDrawBuffers[0]; struct

[Mesa-dev] [Bug 90249] Fails to build egl_dri2 on osx

2015-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90249 --- Comment #2 from José Fonseca jfons...@vmware.com --- It might be better to send the patch to mesa-dev for review. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] egl: Drop check for driver != NULL.

2015-06-09 Thread Ian Romanick
On 06/09/2015 01:06 PM, Eric Anholt wrote: Back in 2013, a patch was added (with 2 reviewers!) at the end of the block to early exit the loop in this case, without noticing that the loop already did. I added another early exit case, again without noticing, but Rob caught me. Just drop the

Re: [Mesa-dev] [PATCH] egl: Drop check for driver != NULL.

2015-06-09 Thread Rob Clark
On Tue, Jun 9, 2015 at 4:06 PM, Eric Anholt e...@anholt.net wrote: Back in 2013, a patch was added (with 2 reviewers!) at the end of the block to early exit the loop in this case, without noticing that the loop already did. I added another early exit case, again without noticing, but Rob

[Mesa-dev] [RFC] nir: Value Range Propagation pass

2015-06-09 Thread Thomas Helland
Hi all, So here goes my first RFC on the value range pass for NIR that I'm attacking as part of my GSoC. RFC as it is not nearly done, and should be treated as a this is how I imagine it ending up instead of close to functioning implementation. For that reason, whoever feels like looking at it

Re: [Mesa-dev] Mesa doesn't expose any sRGB visuals

2015-06-09 Thread Dave Airlie
On 10 June 2015 at 07:45, Marek Olšák mar...@gmail.com wrote: Hi, The spec doesn't specify any behavior for GLX_FRAMEBUFFER_SRGB_CAPABLE_ARB other than it being accepted by a few functions, so it's questionable whether we should do anything for it, but all drivers currently only support

[Mesa-dev] [PATCH] i965: Invalidate virtual register information after register allocation.

2015-06-09 Thread Kenneth Graunke
Connor and I have both hit bugs where code (such as dump_instructions()) attempts to use live intervals or VGRF information, and wasted a bunch of time trying to debug that. By freeing the arrays and zeroing the counts, we make any array access out of bounds, which results in an obvious problem

[Mesa-dev] [PATCH] Revert i965: Advertise a line width of 40.0 on Cherryview and Skylake.

2015-06-09 Thread Kenneth Graunke
This reverts commit f3b709c0ac073cd0ec90a3a0d91d1ee94668e043. The dEQP-GLES3.functional.rasterization.fbo.rbo_multisample_4. interpolation.lines_wide test appears to be broken on Cherryview when we expose line widths greater than 12.0. I'm not sure why. For now, just go back to the limits we

Re: [Mesa-dev] [v4 PATCH 02/10] mesa: Constants and functions for ARB_framebuffer_no_attachments

2015-06-09 Thread Ian Romanick
On 05/27/2015 02:49 AM, Kevin Rogovin wrote: Define the enumeration constants, function entry points and glGet for the GL_ARB_framebuffer_no_attachments. v2: Add output=true for GetFramebufferParameteriv parameter params. Alphabetical insertion. v3: Implement

Re: [Mesa-dev] [v4 PATCH 03/10] mesa: Complete ARB_framebuffer_no_attachments in Mesa core

2015-06-09 Thread Ian Romanick
On 05/27/2015 02:49 AM, Kevin Rogovin wrote: Implement GL_ARB_framebuffer_no_attachments in Mesa core - changes to conditions for framebuffer completenss - implement set/get functions for framebuffers for new functions in GL_ARB_framebuffer_no_attachments v2: Spacing and exceed 80

Re: [Mesa-dev] [v4 PATCH 06/10] i965: Use _mesa_geometry_ functions appropriately

2015-06-09 Thread Ian Romanick
With the comment typo noticed by Ilia fixed (which I did not notice), this patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 05/27/2015 02:49 AM, Kevin Rogovin wrote: Change references to gl_framebuffer::Width, Height, MaxNumLayers and Visual::samples to use the _mesa_geometry_

Re: [Mesa-dev] [v4 PATCH 07/10] mesa: function for testing if current frag-shader has atomics

2015-06-09 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 05/27/2015 02:49 AM, Kevin Rogovin wrote: Add helper function that checks if current fragment shader active of gl_context has atomic buffer access. v3: Added in v3 of patch series. v4: Formatting fixes.

Re: [Mesa-dev] [v4 PATCH 08/10] i965: execution of frag-shader when it has atomic buffer

2015-06-09 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 05/27/2015 02:49 AM, Kevin Rogovin wrote: Ensure that the GPU spawns the fragment shader thread for those fragment shaders with atomic buffer access. v2: No change. v3: Use utility function

Re: [Mesa-dev] [v4 PATCH 04/10] mesa: add helper functions for geometry of gl_framebuffer

2015-06-09 Thread Ian Romanick
With the whitespace issues pointed out by Ilia fixed (which I noticed too... lol), this patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 05/27/2015 02:49 AM, Kevin Rogovin wrote: Add convenience helper functions for fetching geometry of gl_framebuffer that return the geometry of

[Mesa-dev] [PATCH] i965: Momentarily pretend to support ARB_texture_stencil8 for blits.

2015-06-09 Thread Kenneth Graunke
Broadwell's stencil blitting code attempts to bind a renderbuffer as a texture, using dd-BindRenderbufferTexImage(). This calls _mesa_init_teximage_fields(), which then attempts to set img-_BaseFormat = _mesa_base_tex_format(ctx, internalFormat), which assert fails if internalFormat is

Re: [Mesa-dev] [v4 PATCH 01/10] mesa: Define infrastructure for ARB_framebuffer_no_attachments

2015-06-09 Thread Ian Romanick
On 05/27/2015 02:49 AM, Kevin Rogovin wrote: Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments: - extension table - additions to gl_framebuffer v2: Formatting fixes. v3: mtypes.h: Correct comment on _HasAttachments. v4: Formatting fixes. mtypes.h:

Re: [Mesa-dev] [v4 PATCH 10/10] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-06-09 Thread Ian Romanick
Prefix the commit message with docs: and you can keep the R-b. :) On 05/27/2015 02:49 AM, Kevin Rogovin wrote: Mark GL_ARB_framebuffer_no_attachments as done for i965. v2: File added to patch series v3: docs/GL3.txt : add done mark under GLES3.1 docs/relnotes/10.6.0.html : maintain

Re: [Mesa-dev] [v4 PATCH 00/10] Implement extension ARB_framebuffer_no_attachments

2015-06-09 Thread Ian Romanick
I've sent out review for all of the patches that don't already have R-b on them. Before pushing, you should double check the whitespace. In particular, it's hard to notice tabs and trailing whitespace when reviewing. If you do 'git show origin/master..' and search for tab or '[[:space:]]*$'

Re: [Mesa-dev] [v4 PATCH 05/10] mesa: helper function for scissor box of gl_framebuffer

2015-06-09 Thread Ian Romanick
On 05/27/2015 02:49 AM, Kevin Rogovin wrote: Add helper convenience function that intersects the scissor values against a passed bounding box. In addition, to avoid replicated code, make the function _mesa_scissor_bounding_box() use this new function. v2: Split from patch

Re: [Mesa-dev] [PATCH 3/3] i965: Export format comparison for blitting between miptrees

2015-06-09 Thread Jason Ekstrand
On Tue, Jun 9, 2015 at 2:24 PM, Alexander Monakov amona...@gmail.com wrote: Hello, Unfortunately, this patch breaks things further, because... On Fri, Jun 5, 2015 at 5:14 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: @@ -76,8 +77,14 @@ do_blit_drawpixels(struct gl_context * ctx,

Re: [Mesa-dev] [PATCH V3 14/22] i965/gen9: Set vertical and horizontal surface alignments

2015-06-09 Thread Anuj Phogat
On Tue, Jun 2, 2015 at 2:51 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Patch sets the alignments for texture and renderbuffer surfaces. V3: Make changes inside horizontal_alignment() and vertical_alignment() (Topi) Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Cc: Topi Pohjolainen

[Mesa-dev] Mesa doesn't expose any sRGB visuals

2015-06-09 Thread Marek Olšák
Hi, The spec doesn't specify any behavior for GLX_FRAMEBUFFER_SRGB_CAPABLE_ARB other than it being accepted by a few functions, so it's questionable whether we should do anything for it, but all drivers currently only support FALSE. All the infrastructure is there. Drivers only have to add a

Re: [Mesa-dev] [PATCH] mesa/es3.1: enable DRAW_INDIRECT_BUFFER_BINDING for gles3.1

2015-06-09 Thread Martin Peres
Reviewed-by: Martin Peres martin.pe...@linux.intel.com Sorry for the delay... On 06/05/15 13:43, Tapani Pälli wrote: (increases ES31-CTS.draw_indirect.basic.* passing tests) v2: only expose DRAW_INDIRECT_BUFFER_BINDING for GL core + ES3.1 Signed-off-by: Tapani Pälli tapani.pa...@intel.com

Re: [Mesa-dev] [PATCH 4/4] glsl: validate sampler array indexing for 'constant-index-expression'

2015-06-09 Thread Francisco Jerez
Tapani Pälli tapani.pa...@intel.com writes: Desktop GLSL 130 and GLSL ES 300 allow sampler array indexing where index can contain a loop induction variable. This extra check will warn during linking if some of the indexes could not be turned in to constant expressions. v2: warning instead

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/4] glsl: Allow dynamic sampler array indexing with GLSL ES 3.00

2015-06-09 Thread Francisco Jerez
Tapani Pälli tapani.pa...@intel.com writes: Dynamic indexing of sampler arrays is prohibited by GLSL ES 3.00. Earlier versions allow 'constant-index-expression' indexing, where index can contain a loop induction variable. Patch allows dynamic indexing for sampler arrays when GLSL ES 3.00.

Re: [Mesa-dev] [PATCH] i965: do not round line width when multisampling or antialiasing are enabled

2015-06-09 Thread Predut, Marius
-Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Iago Toral Quiroga Sent: Tuesday, June 09, 2015 9:50 AM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH] i965: do not round line width when multisampling or antialiasing are

Re: [Mesa-dev] [PATCH 2/4] mesa/glsl: new compiler option UnrollSamplerArrayDynamicIndexing

2015-06-09 Thread Francisco Jerez
Tapani Pälli tapani.pa...@intel.com writes: Patch provides new compiler option for backend to force unroll loops that have non-constant expression indexing on sampler arrays. This makes sure that we can never end up with a shader that uses loop induction variable as sampler array index but

Re: [Mesa-dev] [PATCH 3/4] i965: use UnrollSamplerArrayDynamicIndexing for gen 7

2015-06-09 Thread Francisco Jerez
Tapani Pälli tapani.pa...@intel.com writes: Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/drivers/dri/i965/brw_context.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index

Re: [Mesa-dev] [PATCH 1/2] tgsi: texture types

2015-06-09 Thread Rob Clark
On Tue, Jun 9, 2015 at 5:01 AM, Jose Fonseca jfons...@vmware.com wrote: On 09/06/15 04:03, Rob Clark wrote: On Mon, Jun 8, 2015 at 10:50 PM, Roland Scheidegger srol...@vmware.com wrote: Am 09.06.2015 um 04:40 schrieb Rob Clark: On Mon, Jun 8, 2015 at 10:36 PM, Roland Scheidegger

Re: [Mesa-dev] [PATCH] i965: Invalidate virtual register information after register allocation.

2015-06-09 Thread Matt Turner
On Tue, Jun 9, 2015 at 5:23 PM, Kenneth Graunke kenn...@whitecape.org wrote: Connor and I have both hit bugs where code (such as dump_instructions()) attempts to use live intervals or VGRF information, and wasted a bunch of time trying to debug that. By freeing the arrays and zeroing the

  1   2   >