Re: [Mesa-dev] [PATCH 5/6] mesa: don't rebind constant buffers after every state change if GS is active

2015-06-18 Thread Emil Velikov
Strange I was under the impression that there are apps that make use of GS, albeit not too many. On the perf side - I was thinking about the hardware (i.e. regardless if the driver does extra state-tracking or not) - would there be the optimisation mentioned, would there be a stall in the

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-18 Thread Rob Clark
On Thu, Jun 18, 2015 at 1:23 AM, Connor Abbott cwabbo...@gmail.com wrote: On Wed, Jun 17, 2015 at 12:02 PM, Rob Clark robdcl...@gmail.com wrote: On Wed, Jun 17, 2015 at 2:27 PM, Connor Abbott cwabbo...@gmail.com wrote: So, as is, this patch isn't quite correct. When I originally wrote NIR, the

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/x11: Remove duplicate call to dri2_x11_add_configs_for_visuals

2015-06-18 Thread Emil Velikov
Hi Boyan, On 13 June 2015 at 08:33, Boyan Ding boyan.j.d...@gmail.com wrote: The call to dri2_x11_add_configs_for_visuals (previously dri2_add_configs_for_visuals) was moved downwards in commit f8c5b8a1, but appeared again in its original position after its rename in d019cd81. Remove it. I

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/x11: Set version of swrastLoader to 2

2015-06-18 Thread Emil Velikov
On 16 June 2015 at 16:39, Ian Romanick i...@freedesktop.org wrote: Gak... I thought we fixed all of those. :( Ops seems like I've missed it. Good news is that this is the last one :-) Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 06/15/2015 08:08 PM, Boyan Ding wrote: which it

Re: [Mesa-dev] [PATCH] configure.ac: rename LLVM_VERSION_PATCH to avoid conflict with llvm-config.h

2015-06-18 Thread Marek Olšák
We'll need to check the patch version for tessellation and amdgpu. Marek On Thu, Jun 18, 2015 at 2:22 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 16 June 2015 at 20:18, Tom Stellard t...@stellard.net wrote: On Tue, Jun 16, 2015 at 08:07:57PM +0100, Emil Velikov wrote: On 13 June 2015

Re: [Mesa-dev] [PATCH] configure.ac: rename LLVM_VERSION_PATCH to avoid conflict with llvm-config.h

2015-06-18 Thread Emil Velikov
On 16 June 2015 at 20:18, Tom Stellard t...@stellard.net wrote: On Tue, Jun 16, 2015 at 08:07:57PM +0100, Emil Velikov wrote: On 13 June 2015 at 19:16, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

2015-06-18 Thread Iago Toral
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: Without this patch, arb_color_buffer_float-readpixels test fails, when forced to use meta pbo path. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/common/meta_tex_subimage.c

[Mesa-dev] [PATCH] clover: Implement image attribute getters

2015-06-18 Thread Zoltan Gilian
Image attributes are passed to the kernel as hidden parameters after the image attribute itself. An llvm pass replaces the getter builtins to the appropriate parameters. --- src/gallium/state_trackers/clover/core/kernel.cpp | 26 +++ src/gallium/state_trackers/clover/core/kernel.hpp | 13

Re: [Mesa-dev] [PATCH] llvmpipe: Truncate the binned constants to max const buffer size.

2015-06-18 Thread Roland Scheidegger
Am 18.06.2015 um 16:52 schrieb Jose Fonseca: Tested with Ilia Mirkin's gzdoom.trace and arb_uniform_buffer_object-maxuniformblocksize fsexceed piglit test without my earlier fix to fail linkage when UBO exceeds GL_MAX_UNIFORM_BLOCK_SIZE. --- src/gallium/auxiliary/gallivm/lp_bld_limits.h | 6

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-18 Thread Connor Abbott
On Thu, Jun 18, 2015 at 4:48 AM, Rob Clark robdcl...@gmail.com wrote: On Thu, Jun 18, 2015 at 1:23 AM, Connor Abbott cwabbo...@gmail.com wrote: On Wed, Jun 17, 2015 at 12:02 PM, Rob Clark robdcl...@gmail.com wrote: On Wed, Jun 17, 2015 at 2:27 PM, Connor Abbott cwabbo...@gmail.com wrote: So,

Re: [Mesa-dev] [PATCH 03/14] mesa: Fix conditions to test signed, unsigned integer format

2015-06-18 Thread Iago Toral
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/readpix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index

[Mesa-dev] [PATCH] llvmpipe: Truncate the binned constants to max const buffer size.

2015-06-18 Thread Jose Fonseca
Tested with Ilia Mirkin's gzdoom.trace and arb_uniform_buffer_object-maxuniformblocksize fsexceed piglit test without my earlier fix to fail linkage when UBO exceeds GL_MAX_UNIFORM_BLOCK_SIZE. --- src/gallium/auxiliary/gallivm/lp_bld_limits.h | 6 +- src/gallium/drivers/llvmpipe/lp_setup.c

Re: [Mesa-dev] [PATCH] EGL: Add pbuffer support for drm platform

2015-06-18 Thread Chad Versace
On Thu 11 Jun 2015, Ying Liu wrote: Add pbuffer support for drm platform, because some customers are still using this feature. Signed-off-by: Ying Liu ying2@intel.com --- src/egl/drivers/dri2/egl_dri2.c | 2 +- src/egl/drivers/dri2/platform_drm.c | 18 ++ 2

Re: [Mesa-dev] [PATCH 03/14] mesa: Fix conditions to test signed, unsigned integer format

2015-06-18 Thread Anuj Phogat
On Thu, Jun 18, 2015 at 7:09 AM, Iago Toral ito...@igalia.com wrote: On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/readpix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-18 Thread Rob Clark
On Thu, Jun 18, 2015 at 12:42 PM, Rob Clark robdcl...@gmail.com wrote: On Thu, Jun 18, 2015 at 11:01 AM, Connor Abbott cwabbo...@gmail.com wrote: (really I want phi's for variables too.. the way I turn arrays into fanin/collect fanout/split works on the backend for dealing with arrays in ssa

Re: [Mesa-dev] [PATCH] EGL: Add pbuffer support for drm platform

2015-06-18 Thread Liu, Ying2
Hi, Chad, Thank you so much for reviewing my patch. I am in vacation and sabbatical right now. I will talk with our customer about your suggestion. I will fix the patch when I come back. Ying -Original Message- From: Versace, Chad Sent: Thursday, June 18, 2015 7:34 AM To: Liu, Ying2

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-18 Thread Connor Abbott
On Thu, Jun 18, 2015 at 9:42 AM, Rob Clark robdcl...@gmail.com wrote: On Thu, Jun 18, 2015 at 11:01 AM, Connor Abbott cwabbo...@gmail.com wrote: (really I want phi's for variables too.. the way I turn arrays into fanin/collect fanout/split works on the backend for dealing with arrays in ssa

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-18 Thread Rob Clark
On Thu, Jun 18, 2015 at 11:01 AM, Connor Abbott cwabbo...@gmail.com wrote: (really I want phi's for variables too.. the way I turn arrays into fanin/collect fanout/split works on the backend for dealing with arrays in ssa form (other than making instruction graph large) but the way I go from

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-18 Thread Ian Romanick
On 06/17/2015 10:53 PM, Julien Isorce wrote: From: Jon TURNEY jon.tur...@dronecode.org.uk On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on linux. For the moment, apply a cast to supress the warning Possibly this is safe, as for the mesa software renderer the

[Mesa-dev] [PATCH] docs: update developer info

2015-06-18 Thread Timothy Arceri
Just link directly to the piglit repo the old link has outdated information. Add note about updating patchwork when sending patch revisions. --- docs/devinfo.html | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/devinfo.html b/docs/devinfo.html index

Re: [Mesa-dev] [PATCH] docs: update developer info

2015-06-18 Thread Matt Turner
On Thu, Jun 18, 2015 at 8:14 PM, Timothy Arceri t_arc...@yahoo.com.au wrote: Just link directly to the piglit repo the old link has outdated information. Add note about updating patchwork when sending patch revisions. --- docs/devinfo.html | 8 +++- 1 file changed, 7 insertions(+), 1

[Mesa-dev] [PATCH 16/17] i965/fs_generator: Use inst-exec_size for determining hardware reg widths

2015-06-18 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index 8eb3ace..2b66acf 100644 ---

Re: [Mesa-dev] [PATCH 1/2] i965/gen9: Implement Push Constant Buffer workaround

2015-06-18 Thread Anuj Phogat
On Wed, Jun 3, 2015 at 9:35 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: This implements a workaround (exact excerpt as a comment in the code). The docs specify [clearly, after you struggle for a while] that the offset isn't relative to state base. This actually makes sense. Buffer

[Mesa-dev] [PATCH] mesa_tags: dri/common no longer exists

2015-06-18 Thread Ben Widawsky
--- scripts/tags/mesa_tags.sh | 4 1 file changed, 4 deletions(-) diff --git a/scripts/tags/mesa_tags.sh b/scripts/tags/mesa_tags.sh index 4404b92..c8e2098 100755 --- a/scripts/tags/mesa_tags.sh +++ b/scripts/tags/mesa_tags.sh @@ -3,13 +3,9 @@ rm cscope.* rm tags git ls-files

[Mesa-dev] [PATCH] i965/gen8: Use HALIGN_16 for single sample mcs buffers

2015-06-18 Thread Ben Widawsky
The original code meant to do this, but was only checking num_samples == 1 to figure out if a surface was fast clear capable. However, we can allocate single sample miptrees with num_samples == 0 (when it's an internally created buffer). This fixes a bunch of the piglit tests on gen8. Other gens

Re: [Mesa-dev] [PATCH] mesa_tags: dri/common no longer exists

2015-06-18 Thread Ben Widawsky
Sorry, ignore this. I had script fail. Real patch coming up. On Thu, Jun 18, 2015 at 06:44:35PM -0700, Ben Widawsky wrote: --- scripts/tags/mesa_tags.sh | 4 1 file changed, 4 deletions(-) diff --git a/scripts/tags/mesa_tags.sh b/scripts/tags/mesa_tags.sh index 4404b92..c8e2098

[Mesa-dev] [PATCH 01/17] i965/fs: Use a switch statement in fs_inst::regs_read()

2015-06-18 Thread Jason Ekstrand
This makes things a little simpler, more efficient, and quite a bit more readable. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 45 ++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH 03/17] i965/fs: Report the right value in fs_inst::regs_read() for PIXEL_X/Y

2015-06-18 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index ce56657..4f98d63 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp @@

[Mesa-dev] [PATCH 04/17] i965/fs: Explicitly set the exec_size on the add(32) in interpolation setup

2015-06-18 Thread Jason Ekstrand
Soon we will start using the builder to explicitly set all the execution sizes. We could make a 32-wide builder, but the builder asserts that we never grow it which is usually a reasonable assumption. Sinc this one instruction is a bit of an odd-ball, we just set the exec_size explicitly. ---

[Mesa-dev] [PATCH 02/17] i965/fs: Fix fs_inst::regs_read() for uniform pull constant loads

2015-06-18 Thread Jason Ekstrand
Previously, fs_inst::regs_read() fell back to depending on the register width for the second source. This isn't really correct since it isn't a SIMD8 value at all, but a SIMD4x2 value. This commit changes it to explicitly be always one register. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 6

[Mesa-dev] [PATCH 05/17] i965/fs: Set the builder group for emitting FB-write stencil/AA alpha

2015-06-18 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index b00825e..8a43ec8 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp +++

[Mesa-dev] [PATCH 15/17] i965/fs: Use exec_size instead of dst.width for computing component size

2015-06-18 Thread Jason Ekstrand
There are a variety of places where we use dst.width / 8 to compute the size of a single logical channel. Instead, we should be using exec_size. --- src/mesa/drivers/dri/i965/brw_fs.cpp| 6 +++--- src/mesa/drivers/dri/i965/brw_fs_cse.cpp| 2 +-

[Mesa-dev] [PATCH 10/17] i965/fs: Use exec_size for determining regs read/written and partial writes

2015-06-18 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 61235d7..cff27e7 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++

[Mesa-dev] [PATCH 13/17] i965/fs: Use the builder dispatch width instead of dst.width for pull constants

2015-06-18 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index d9b7f75..b889432 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++

[Mesa-dev] [PATCH 07/17] i965/fs: Move offset() and half() to the fs_builder

2015-06-18 Thread Jason Ekstrand
We want to move these into the builder so that they know the current builder's dispatch width. This will be needed by a later commit. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 52 ++ src/mesa/drivers/dri/i965/brw_fs_builder.h | 46 +

[Mesa-dev] [PATCH 11/17] i965/fs_builder: Use the dispatch width for setting exec sizes

2015-06-18 Thread Jason Ekstrand
Previously we used dst.width but the two *should* be the same. --- src/mesa/drivers/dri/i965/brw_fs_builder.h | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_builder.h b/src/mesa/drivers/dri/i965/brw_fs_builder.h index

[Mesa-dev] [PATCH 06/17] i965/blorp: Explicitly set execution sizes for new'd instructions

2015-06-18 Thread Jason Ekstrand
This doesn't affect instructions allocated using the builder. --- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp index

[Mesa-dev] [PATCH 17/17] i965/fs: Remove the width field from fs_reg

2015-06-18 Thread Jason Ekstrand
As of now, the width field is no longer used for anything. The width field seemed like a good idea at the time but is actually entirely redundant with the instruction's execution size. Initially, it gave us the ability to easily set the instructions execution size based entirely on register

[Mesa-dev] [PATCH 12/17] i965/fs: Remove exec_size guessing from fs_inst::init()

2015-06-18 Thread Jason Ekstrand
Now that all of the non-explicit constructors are gone, we don't need to guess anymore. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 22 -- 1 file changed, 22 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index

[Mesa-dev] [PATCH 14/17] i965/fs_builder: Use dispatch_width instead of reg.width for offset and half

2015-06-18 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs_builder.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_builder.h b/src/mesa/drivers/dri/i965/brw_fs_builder.h index 7d3c8ab..58519d7 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_builder.h +++

[Mesa-dev] [PATCH 09/17] i965/fs: Remove fs_inst constructors that don't take an explicit exec_size

2015-06-18 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 30 ++ src/mesa/drivers/dri/i965/brw_fs_builder.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 6 -- src/mesa/drivers/dri/i965/brw_ir_fs.h | 9 + 4 files changed, 8 insertions(+), 39

[Mesa-dev] [PATCH 08/17] i965/fs: Make better use of the builder in shader_time

2015-06-18 Thread Jason Ekstrand
Previously, we were just depending on register widths to ensure that various things were exec_size of 1 etc. Now, we do so explicitly using the builder. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

2015-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91020 --- Comment #1 from Emil Velikov emil.l.veli...@gmail.com --- Mesa commit 7a58262e58d removed all the EGL_MESA_screen_surface definitions as it was never implemented (according to it). Seems like mesa-demos doesn't have the necessary compile

Re: [Mesa-dev] [PATCH 4/5] egl: use unix defines on osx with clang

2015-06-18 Thread Emil Velikov
On 18 June 2015 at 06:53, Julien Isorce julien.iso...@gmail.com wrote: CC egl_dri2.lo include/EGL/eglplatform.h:135:2: error: Platform not recognized include/EGL/eglplatform.h:140:9: error: unknown type name 'EGLNativeDisplayType' typedef EGLNativeDisplayType NativeDisplayType;

Re: [Mesa-dev] [RFC v2 14/15] i965: refactor miptree alignment calculation code

2015-06-18 Thread Nanley Chery
The next revision will be all code refactoring. I moved the spec references into the new top-level function intel_get_texture_alignment_unit because some of the alignment calculations occurring in the top-level function reference the spec. Since the intel_vertical_texture_alignment_unit and

Re: [Mesa-dev] [PATCH] configure.ac: rename LLVM_VERSION_PATCH to avoid conflict with llvm-config.h

2015-06-18 Thread Emil Velikov
On 18 June 2015 at 13:32, Marek Olšák mar...@gmail.com wrote: We'll need to check the patch version for tessellation and amdgpu. Did not see that one. Thanks ! -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-18 Thread Rob Clark
On Thu, Jun 18, 2015 at 1:27 PM, Connor Abbott cwabbo...@gmail.com wrote: On Thu, Jun 18, 2015 at 9:42 AM, Rob Clark robdcl...@gmail.com wrote: On Thu, Jun 18, 2015 at 11:01 AM, Connor Abbott cwabbo...@gmail.com wrote: (really I want phi's for variables too.. the way I turn arrays into

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-18 Thread Emil Velikov
On 18 June 2015 at 06:53, Julien Isorce julien.iso...@gmail.com wrote: From: Jon TURNEY jon.tur...@dronecode.org.uk On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on linux. For the moment, apply a cast to supress the warning Possibly this is safe, as for the mesa

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-18 Thread Connor Abbott
On Thu, Jun 18, 2015 at 11:19 AM, Rob Clark robdcl...@gmail.com wrote: On Thu, Jun 18, 2015 at 1:27 PM, Connor Abbott cwabbo...@gmail.com wrote: On Thu, Jun 18, 2015 at 9:42 AM, Rob Clark robdcl...@gmail.com wrote: On Thu, Jun 18, 2015 at 11:01 AM, Connor Abbott cwabbo...@gmail.com wrote:

Re: [Mesa-dev] [PATCH v2 23/82] glsl: Do not do CSE for expressions involving SSBO loads

2015-06-18 Thread Jordan Justen
On 2015-06-17 22:57:27, Iago Toral wrote: On Wed, 2015-06-17 at 17:20 -0700, Jordan Justen wrote: I wanted to question whether this was required, based on this text from the extension spec: The ability to write to buffer objects creates the potential for multiple independent shader

Re: [Mesa-dev] [PATCH 5/5] osx: fix asm support on darwin

2015-06-18 Thread Emil Velikov
On 18 June 2015 at 06:53, Julien Isorce julien.iso...@gmail.com wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90908 Signed-off-by: Julien Isorce j.iso...@samsung.com --- configure.ac | 2 +- src/mesa/x86-64/xform4.S | 53

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-18 Thread Rob Clark
On Thu, Jun 18, 2015 at 2:34 PM, Connor Abbott cwabbo...@gmail.com wrote: On Thu, Jun 18, 2015 at 11:19 AM, Rob Clark robdcl...@gmail.com wrote: On Thu, Jun 18, 2015 at 1:27 PM, Connor Abbott cwabbo...@gmail.com wrote: On Thu, Jun 18, 2015 at 9:42 AM, Rob Clark robdcl...@gmail.com wrote: On

[Mesa-dev] New stable-branch 10.5 candidate pushed

2015-06-18 Thread Emil Velikov
Hello list, The candidate for the Mesa 10.5.8 is now available. Currently we have: - 11 queued - 10 nominated (outstanding) - and 0 rejected (obsolete) patches The present queue consist of a few nouveau and i965 patches, along with couple libEGL hit bug fixes and a build fix for people using

Re: [Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

2015-06-18 Thread Emil Velikov
On 18 June 2015 at 06:53, Julien Isorce julien.iso...@gmail.com wrote: From: Jon TURNEY jon.tur...@dronecode.org.uk _SET_DrawBuffers requires driDispatchRemapTable, so we need to link with libmesa for remap.c. libmesa requires the C++ linker. Also need to arrange to call

Re: [Mesa-dev] [PATCH 3/5] egl/dri2: load libglapi.0.dylib on osx

2015-06-18 Thread Emil Velikov
On 18 June 2015 at 06:53, Julien Isorce julien.iso...@gmail.com wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90903 Signed-off-by: Julien Isorce j.iso...@samsung.com --- src/egl/drivers/dri2/egl_dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 4/5] egl: use unix defines on osx with clang

2015-06-18 Thread Emil Velikov
On 18 June 2015 at 19:29, Emil Velikov emil.l.veli...@gmail.com wrote: Sorry about that. Unintentionally hit send ;-\ On 18 June 2015 at 06:53, Julien Isorce julien.iso...@gmail.com wrote: CC egl_dri2.lo include/EGL/eglplatform.h:135:2: error: Platform not recognized

Re: [Mesa-dev] [PATCH 0/4] CLOEXEC fix-ups

2015-06-18 Thread Emil Velikov
On 17 June 2015 at 17:28, Derek Foreman der...@osg.samsung.com wrote: This series catches a couple of places where we forget to set CLOEXEC on file descriptors, and makes a helper function for the necessarily ugly way we have to open fds to make sure CLOEXEC is set. Derek Foreman (4):

Re: [Mesa-dev] [PATCH] EGL: Add pbuffer support for drm platform

2015-06-18 Thread Emil Velikov
On 18 June 2015 at 17:11, Liu, Ying2 ying2@intel.com wrote: Hi, Chad, Thank you so much for reviewing my patch. I am in vacation and sabbatical right now. I will talk with our customer about your suggestion. I will fix the patch when I come back. Enjoy your sabbatical Ying ! As you

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-18 Thread Julien Isorce
Hi Emil, Do you mean adding the cast only if __APPLE__ is defined ? Actually when reading comment #2 we should get the build error for src/mesa/main/uniform_query.cpp too but it is not the case anymore. So with git blame I can see that the build error has been fixed by commit d96ed5c0 for the

[Mesa-dev] [PATCH] glsl: move gl_NumSamples enablement with other ARB_sample_shading vars

2015-06-18 Thread Ilia Mirkin
gl_NumSamples should only be enabled when ARB_sample_shading is enabled, and only in the fragment shader. Move to the generate_fs_special_vars function, next to the other ARB_sample_shading-provided variables. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/glsl/builtin_variables.cpp | 2

Re: [Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

2015-06-18 Thread Julien Isorce
Sorry for removing the XXX line. Original message is here: https://bugs.freedesktop.org/attachment.cgi?id=115539 At the time src/glx/apple/apple_glapi.c has been developed this patch was not needed I guess so I wonder which change made the regression. Cheers Julien On 18 June 2015 at 19:23,

Re: [Mesa-dev] [PATCH] glsl: move gl_NumSamples enablement with other ARB_sample_shading vars

2015-06-18 Thread Ilia Mirkin
Hmmm actually looking at the GLSL 4.50 doc, it looks like it just has a list of all uniforms available in one place, unlike the ARB_sample_shading spec which says it should go into fs only. From ARB_sample_shading: Add the following prototype to the list of built-in uniforms

[Mesa-dev] [PATCH v2] glsl: guard gl_NumSamples enablement on ARB_sample_shading

2015-06-18 Thread Ilia Mirkin
gl_NumSamples should only be enabled when ARB_sample_shading is enabled. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/glsl/builtin_variables.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index

Re: [Mesa-dev] [PATCH 3/5] egl/dri2: load libglapi.0.dylib on osx

2015-06-18 Thread Julien Isorce
On 18 June 2015 at 19:29, Emil Velikov emil.l.veli...@gmail.com wrote: On 18 June 2015 at 06:53, Julien Isorce julien.iso...@gmail.com wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90903 Signed-off-by: Julien Isorce j.iso...@samsung.com ---

[Mesa-dev] [Bug 90903] egl_dri2.c:dri2_load fails to load libglapi on osx

2015-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90903 --- Comment #1 from Julien Isorce julien.iso...@gmail.com --- Created attachment 116583 -- https://bugs.freedesktop.org/attachment.cgi?id=116583action=edit es2gears_x11 and es2_info with llvmpipe on osx Running gears with egl/gles2/x11 with

[Mesa-dev] [PATCH] i965: Add missing braces around if-statement.

2015-06-18 Thread Matt Turner
Fixes a performance problem caused by commit b639ed2f. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895 --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c

Re: [Mesa-dev] [PATCH 4/5] egl: use unix defines on osx with clang

2015-06-18 Thread Julien Isorce
On 18 June 2015 at 19:33, Emil Velikov emil.l.veli...@gmail.com wrote: On 18 June 2015 at 19:29, Emil Velikov emil.l.veli...@gmail.com wrote: Sorry about that. Unintentionally hit send ;-\ On 18 June 2015 at 06:53, Julien Isorce julien.iso...@gmail.com wrote: CC egl_dri2.lo

Re: [Mesa-dev] [PATCH] i965: Add missing braces around if-statement.

2015-06-18 Thread Chris Forbes
Oh, how silly :) Reviewed-by: Chris Forbes chr...@ijw.co.nz - Chris On Fri, Jun 19, 2015 at 11:19 AM, Matt Turner matts...@gmail.com wrote: Fixes a performance problem caused by commit b639ed2f. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895 ---

Re: [Mesa-dev] [PATCH] i965: Add missing braces around if-statement.

2015-06-18 Thread Jason Ekstrand
Wow... Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Thu, Jun 18, 2015 at 4:19 PM, Matt Turner matts...@gmail.com wrote: Fixes a performance problem caused by commit b639ed2f. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895 ---

Re: [Mesa-dev] [PATCH] i965: Add missing braces around if-statement.

2015-06-18 Thread Ben Widawsky
On Thu, Jun 18, 2015 at 04:19:36PM -0700, Matt Turner wrote: Fixes a performance problem caused by commit b639ed2f. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895 Ken spotted this in review. /me hides Reviewed-by: Ben Widawsky b...@bwidawsk.net ---

Re: [Mesa-dev] New stable-branch 10.5 candidate pushed

2015-06-18 Thread Jason Ekstrand
We should also pull in Chris' 3-patch drawbuffers series if it applies: http://lists.freedesktop.org/archives/mesa-dev/2015-June/085851.html On Thu, Jun 18, 2015 at 11:30 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Hello list, The candidate for the Mesa 10.5.8 is now available. Currently

Re: [Mesa-dev] [PATCH 5/5] osx: fix asm support on darwin

2015-06-18 Thread Julien Isorce
On 18 June 2015 at 19:46, Emil Velikov emil.l.veli...@gmail.com wrote: On 18 June 2015 at 06:53, Julien Isorce julien.iso...@gmail.com wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90908 Signed-off-by: Julien Isorce j.iso...@samsung.com --- configure.ac | 2

Re: [Mesa-dev] [PATCH] i965: Add missing braces around if-statement.

2015-06-18 Thread Kenneth Graunke
On Thursday, June 18, 2015 04:28:25 PM Ben Widawsky wrote: On Thu, Jun 18, 2015 at 04:19:36PM -0700, Matt Turner wrote: Fixes a performance problem caused by commit b639ed2f. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895 Ken spotted this in review. /me hides

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

2015-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91020 Mike Lothian m...@fireburn.co.uk changed: What|Removed |Added Attachment #116585|Buid log without EGL|Build log without EGL

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

2015-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91020 Mike Lothian m...@fireburn.co.uk changed: What|Removed |Added CC||m...@fireburn.co.uk

Re: [Mesa-dev] [PATCH v2] glsl: guard gl_NumSamples enablement on ARB_sample_shading

2015-06-18 Thread Anuj Phogat
On Thu, Jun 18, 2015 at 4:08 PM, Ilia Mirkin imir...@alum.mit.edu wrote: gl_NumSamples should only be enabled when ARB_sample_shading is enabled. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/glsl/builtin_variables.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

2015-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91020 --- Comment #3 from Mike Lothian m...@fireburn.co.uk --- Created attachment 116585 -- https://bugs.freedesktop.org/attachment.cgi?id=116585action=edit Buid log without EGL -- You are receiving this mail because: You are the QA Contact for the

Re: [Mesa-dev] [PATCH 3/4] i965/gen9: Don't use encrypted MOCS

2015-06-18 Thread Kenneth Graunke
On Wednesday, June 17, 2015 03:50:13 PM Ben Widawsky wrote: On gen9+ MOCS is an index into a table. It is 7 bits, and AFAICT, bit 0 is for doing encrypted reads. I don't recall how I decided to do this for BXT. I don't know this patch was ever needed, since it seems nothing is broken today

[Mesa-dev] [Bug 91016] Piglit regression: shaders/glsl-floating-constant-120

2015-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91016 Kenneth Graunke kenn...@whitecape.org changed: What|Removed |Added Component|Mesa core

[Mesa-dev] [Bug 91015] Piglit regression: spec/ARB_occlusion_query2/api

2015-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91015 Kenneth Graunke kenn...@whitecape.org changed: What|Removed |Added Component|Mesa core

[Mesa-dev] [Bug 91014] Piglit regression: spec/!OpenGL 1.2/texture-packed-formats

2015-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91014 Kenneth Graunke kenn...@whitecape.org changed: What|Removed |Added Component|Mesa core

Re: [Mesa-dev] [PATCH 1/2] i965: Split VUE map handling out of brw_vs.c into brw_vue_map.c.

2015-06-18 Thread Pohjolainen, Topi
On Wed, Jun 17, 2015 at 10:36:04PM -0700, Kenneth Graunke wrote: This was originally only used by the vertex shader, but it's now used by the geometry shader as well, and will also eventually be used for tessellation control and evaluation shaders. I suspect it will be easier to find in a

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

2015-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91020 Bug ID: 91020 Summary: Mesa's demo / tools won't compile since EGL changes Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH] mesa: add GL_PROGRAM_PIPELINE support in KHR_debug calls

2015-06-18 Thread Timothy Arceri
On Wed, 2015-06-17 at 23:02 -0400, Ilia Mirkin wrote: This was apparently missed when KHR_debug or ARB_sso support was added. SSO was still missing when I added KHR_debug, but this should have been picked up by the object label piglit test I wrote. However the test was broken, it failed to fail