On Gen9+ there is a new bit in 3DSTATE_PS_EXTRA that must be set if
the shader sends a message to the pixel interpolator. This fixes the
interpolateAt* tests on SKL, apart from interpolateatsample-nonconst
but that is not implemented anywhere so it's not a regression.
---
On 02/07/15 18:25, Dylan Baker wrote:
One of the plugins I use with vim helpfully added an underscore to the
front of mode for kicks.
Obviously this isn't a feature used very often because it's been broken
since d986cb7c70db (since May 20th), and no one has noticed.
Iirc these have a long
On Fri, 2015-07-03 at 15:08 +0300, Martin Peres wrote:
On 03/07/15 13:55, Timothy Arceri wrote:
This change removes multiple functions designed to validate an array
subscript and replaces them with a call to a single function.
The change also means that validation is now only done once
On Wed, Jul 1, 2015 at 4:27 PM, Eric Anholt e...@anholt.net wrote:
Rob Clark robdcl...@gmail.com writes:
From: Ilia Mirkin imir...@alum.mit.edu
We need to distinguish a shader that has separate writes to each MRT
from one which is supposed to write the data from MRT 0 to all the MRTs.
In
Hi Boyan,
Thank you for doing this ! A few suggestions which you might be interesting:
Considering that the backend has handled more than dri2 perhaps we can
do a s/dri2/dri/ :-) That obviously is independent of your work.
On 01/07/15 16:31, Boyan Ding wrote:
Signed-off-by: Boyan Ding
On Friday, July 03, 2015 10:50:52 AM Pohjolainen, Topi wrote:
On Wed, Jul 01, 2015 at 03:03:31PM -0700, Kenneth Graunke wrote:
Jason plumbed this through a while back in the FS backend, but
apparently we were just passing NULL in the vec4 backend.
This patch passes brw in as intended.
On Fri, Jul 03, 2015 at 01:15:21PM +0100, Neil Roberts wrote:
On Gen9+ there is a new bit in 3DSTATE_PS_EXTRA that must be set if
the shader sends a message to the pixel interpolator. This fixes the
interpolateAt* tests on SKL, apart from interpolateatsample-nonconst
but that is not
On Friday, July 03, 2015 11:11:45 AM Pohjolainen, Topi wrote:
On Wed, Jul 01, 2015 at 03:03:32PM -0700, Kenneth Graunke wrote:
This patch makes us only issue the performance warning about register
spilling if we actually spilled registers. We also use scratch space
for indirect addressing
Hi Jason,
On mar, 2015-06-30 at 14:18 -0700, Jason Ekstrand wrote:
On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote:
From: Antia Puentes apuen...@igalia.com
For operations that have a predefined operand size 0, defined in
glsl/nir/nir_opcodes.c, NIR returns a
On 02/07/15 16:32, Jon TURNEY wrote:
On 02/07/2015 13:42, Emil Velikov wrote:
On 27 June 2015 at 12:21, Jon TURNEY wrote:
This smells to me like there's something not quite right about the
partitioning of stuff between libmesa and libglapi, but I don't have any
insight into what exactly the
https://bugs.freedesktop.org/show_bug.cgi?id=90162
Tapani Pälli lem...@gmail.com changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
On Fri, Jul 3, 2015 at 12:46 AM, Erik Faye-Lund kusmab...@gmail.com wrote:
After c61bc6e (util: port _mesa_strto[df] to C), make check
fails due to a missing _mesa_locale_init. Fixup this oversight,
by moving the stand-alone compiler initializer inside
initialize_context_to_defaults().
Hi Emil,
On 07/03/2015 10:36 PM, Emil Velikov wrote:
Hi Boyan,
Thank you for doing this ! A few suggestions which you might be interesting:
Considering that the backend has handled more than dri2 perhaps we can
do a s/dri2/dri/ :-) That obviously is independent of your work.
On 01/07/15
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu
On Sat, Jun 20, 2015 at 8:33 AM, Timothy Arceri t_arc...@yahoo.com.au wrote:
---
src/glsl/ast_to_hir.cpp | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index
Cc: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/uniform_query.cpp | 75 -
src/mesa/main/uniforms.h| 4 ---
2 files changed, 79 deletions(-)
diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp
index
This change removes multiple functions designed to validate an array
subscript and replaces them with a call to a single function.
The change also means that validation is now only done once and the index
is retrived at the same time, as a result the getUniformLocation code can
be simplified
Cc: Tapani Pälli tapani.pa...@intel.com
---
src/mesa/main/shader_query.cpp | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp
index a6246a3..0473c2e 100644
--- a/src/mesa/main/shader_query.cpp
+++ b/src/mesa/main/shader_query.cpp
Cc: Tapani Pälli tapani.pa...@intel.com
---
src/glsl/linker.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 71a45e8..d8f1689 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -462,6 +462,10 @@
From: Roland Scheidegger srol...@vmware.com
The expansion should always be to the same width as the input arguments
no matter what, since these functions should work with any bit width of
the arguments (the sext is a no-op on any sane simd architecture).
Thus, fix the caller expecting
I asked about dumping them and was told that they would leave mesa only
when x itself died. If be more than happy to see them go if they're not
useful
On Jul 3, 2015 06:28, Emil Velikov emil.l.veli...@gmail.com wrote:
On 02/07/15 18:25, Dylan Baker wrote:
One of the plugins I use with vim
https://bugs.freedesktop.org/show_bug.cgi?id=91222
Bug ID: 91222
Summary: lp_test_format regression on CentOS 7
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Keywords:
On Friday, July 03, 2015 01:15:21 PM Neil Roberts wrote:
On Gen9+ there is a new bit in 3DSTATE_PS_EXTRA that must be set if
the shader sends a message to the pixel interpolator. This fixes the
interpolateAt* tests on SKL, apart from interpolateatsample-nonconst
but that is not implemented
On Thu, 2015-07-02 at 09:31 +0200, Iago Toral wrote:
On Tue, 2015-06-30 at 11:32 -0700, Jason Ekstrand wrote:
I'm not sure what I think about adding an is_scalar flag vs. having
_scalar and _vec4 versions of each function. My feeling is that once
we tweak assign_var_locations as I
On Wed, Jul 01, 2015 at 03:03:34PM -0700, Kenneth Graunke wrote:
Nothing outside of vec4_visitor uses it, so we may as well keep it
internal.
Commit db9c915abcc5ad78d2d11d0e732f04cc94631350 for the vec4 backend.
(The empty class will be going away soon.)
Signed-off-by: Kenneth Graunke
On Wed, Jul 01, 2015 at 03:03:35PM -0700, Kenneth Graunke wrote:
At this point, the brw_vs_compile structure only contains the key and
gl_vertex_program pointer. We may as well pass and store them directly;
it's simpler and more convenient (key- instead of vs_compile-key...).
Signed-off-by:
On Wed, Jul 01, 2015 at 03:03:32PM -0700, Kenneth Graunke wrote:
This patch makes us only issue the performance warning about register
spilling if we actually spilled registers. We also use scratch space
for indirect addressing and the like.
This is basically commit
On Fri, Jul 03, 2015 at 11:29:33AM +0300, Pohjolainen, Topi wrote:
On Wed, Jul 01, 2015 at 03:03:35PM -0700, Kenneth Graunke wrote:
At this point, the brw_vs_compile structure only contains the key and
gl_vertex_program pointer. We may as well pass and store them directly;
it's simpler and
On Thu, 2015-07-02 at 10:11 -0700, Jason Ekstrand wrote:
On Wed, Jul 1, 2015 at 11:44 PM, Iago Toral ito...@igalia.com wrote:
On Tue, 2015-06-30 at 09:30 -0700, Jason Ekstrand wrote:
On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com
wrote:
From: Iago Toral Quiroga
After c61bc6e (util: port _mesa_strto[df] to C), make check
fails due to a missing _mesa_locale_init. Fixup this oversight,
by moving the stand-alone compiler initializer inside
initialize_context_to_defaults().
Signed-off-by: Erik Faye-Lund kusmab...@gmail.com
---
Here's what the latter
On Wed, Jul 01, 2015 at 03:03:31PM -0700, Kenneth Graunke wrote:
Jason plumbed this through a while back in the FS backend, but
apparently we were just passing NULL in the vec4 backend.
This patch passes brw in as intended.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
On Wed, Jul 01, 2015 at 03:03:33PM -0700, Kenneth Graunke wrote:
This is more consistent with how we do it in the FS backend, and reduces
a tiny bit of duplication. It'll also allow for a bit more tidying.
And it also makes it clearer that code generation doesn't have anything to do
with the
On Wed, Jul 01, 2015 at 03:03:36PM -0700, Kenneth Graunke wrote:
After tearing it out another level or two, and just passing the key and
vp directly, we can finally remove this struct. It also eliminates a
pointless memcpy() of the key.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Change function to get all gl_constants for inspection, this is used
by follow-up patch.
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/glsl/linker.cpp | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
Same check is made for glBindFragDataLocationIndexed but it was missing
when using layout qualifiers.
Fixes following Piglit test:
arb_blend_func_extended-output-location
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
src/glsl/linker.cpp | 19 +++
1 file changed,
When hardware-generated binding tables are enabled, use the hw-generated
binding table format when uploading binding table state.
Normally, the CS will will just consume the binding table pointer commands
as pipelined state. When the RS is enabled however, the RS flushes whatever
edited surface
Check first if the hardware and kernel supports resource streamer. If this
is allowed, tell the kernel to enable the resource streamer enable bit on
MI_BATCHBUFFER_START by specifying I915_EXEC_RESOURCE_STREAMER
execbuffer flags.
v2: - Use new I915_PARAM_HAS_RESOURCE_STREAMER ioctl to check if
This patch implements the binding table enable command which is also
used to allocate a binding table pool where where hardware-generated
binding table entries are flushed into. Each binding table offset in
the binding table pool is unique per each shader stage that are
enabled within a batch.
Switch off hardware-generated binding tables and gather push
constants in the blorp. Blorp requires only a minimal set of
simple constants. There is no need for the extra complexity
to program a gather table entry into the pipeline.
Cc: kenn...@whitecape.org
Signed-off-by: Abdiel Janulgue
On 2015-06-25 11:34:59, Ben Widawsky wrote:
On Thu, Jun 11, 2015 at 09:04:45PM -0700, Jordan Justen wrote:
+ desc[dw++] = 0;
+ const uint32_t media_threads =
+ brw-gen = 8 ?
+ SET_FIELD(threads, GEN8_MEDIA_GPGPU_THREAD_COUNT) :
+ SET_FIELD(threads,
On Fri, Jul 03, 2015 at 10:00:31AM +0300, Abdiel Janulgue wrote:
+void
+gen7_enable_hw_binding_tables(struct brw_context *brw)
+{
+ if (!brw-use_resource_streamer)
+ return;
+
+ if (!brw-hw_bt_pool.bo) {
+ /* We use a single re-usable buffer object for the lifetime of the
+
On Fri, 2015-07-03 at 13:23 +0300, Francisco Jerez wrote:
Samuel Iglesias Gonsálvez sigles...@igalia.com writes:
On 29/06/15 09:11, Jordan Justen wrote:
On 2015-06-24 07:36:24, Iago Toral wrote:
On Wed, 2015-06-24 at 15:43 +0300, Francisco Jerez wrote:
AFAICT the reason why this (and
Samuel Iglesias Gonsálvez sigles...@igalia.com writes:
On 29/06/15 09:11, Jordan Justen wrote:
On 2015-06-24 07:36:24, Iago Toral wrote:
On Wed, 2015-06-24 at 15:43 +0300, Francisco Jerez wrote:
AFAICT the reason why this (and many of the other changes in GLSL
optimization passes) is needed
Neil Roberts n...@linux.intel.com writes:
There was a comment saying that in SIMD16 mode the pixel interpolator
returns coords interleaved 8 channels at a time and that this requires
extra work to support. However, this interleaved format is exactly
what the PLN instruction requires so I
This change removes multiple functions designed to validate an array
subscript and replaces them with a call to a single function.
The change also means that validation is now only done once and the index
is retrived at the same time, as a result the getUniformLocation code can
be merged saving
Cc: Martin Peres martin.pe...@linux.intel.com
Cc: Tapani Pälli tapani.pa...@intel.com
---
src/glsl/linker.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 71a45e8..d8f1689 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@
On 03/07/15 13:55, Timothy Arceri wrote:
This change removes multiple functions designed to validate an array
subscript and replaces them with a call to a single function.
The change also means that validation is now only done once and the index
is retrived at the same time, as a result the
46 matches
Mail list logo
