Re: [Mesa-dev] [PATCH v2] mesa: add missing queries for ARB_direct_state_access

2015-08-12 Thread Brian Paul
Another question below... On 08/12/2015 08:31 AM, Daniel Scharrer wrote: On 2015-08-06 15:46, Brian Paul wrote: On 08/06/2015 07:44 AM, Daniel Scharrer wrote: CC: 10.6 mesa-sta...@lists.freedesktop.org --- v2: added CC for 10.6 renamed _mesa_tex_target_to_index to tex_target_to_index

[Mesa-dev] [PATCH v2] mesa/formats: don't byteswap when building array formats

2015-08-12 Thread Oded Gabbay
Because we build here an array format, we don't need to swap the bytes for big endian. If it isn't an array format, the bytes will be swapped in _mesa_format_convert. v2: remove temp variable Signed-off-by: Oded Gabbay oded.gab...@gmail.com Cc: Jason Ekstrand jason.ekstr...@intel.com Cc: Iago

Re: [Mesa-dev] [PATCH 1/1] mesa/formats: don't byteswap when building array formats

2015-08-12 Thread Jason Ekstrand
On Aug 12, 2015 3:55 AM, Oded Gabbay oded.gab...@gmail.com wrote: Because we build here an array format, we don't need to swap the bytes for big endian. If it isn't an array format, the bytes will be swapped in _mesa_format_convert. Signed-off-by: Oded Gabbay oded.gab...@gmail.com Cc:

Re: [Mesa-dev] [PATCH] mesa: update MaxShaderStorageBlockSize to 2^27

2015-08-12 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga ito...@igalia.com El 2015-08-12 10:24, Tapani Pälli escribió: Extension spec originally required 2^24 but 2^27 is the minimum value required by OpenGL 4.5 and OpenGL ES 3.1 specifications. Fixes: ES31-CTS.shader_storage_buffer_object.basic-max Signed-off-by:

Re: [Mesa-dev] [PATCH v2] mesa: add missing queries for ARB_direct_state_access

2015-08-12 Thread Daniel Scharrer
On 2015-08-06 15:46, Brian Paul wrote: On 08/06/2015 07:44 AM, Daniel Scharrer wrote: CC: 10.6 mesa-sta...@lists.freedesktop.org --- v2: added CC for 10.6 renamed _mesa_tex_target_to_index to tex_target_to_index moved declaration of variable before code added missing spaces

Re: [Mesa-dev] [PATCH v2] mesa/formats: don't byteswap when building array formats

2015-08-12 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Wed, Aug 12, 2015 at 8:22 AM, Oded Gabbay oded.gab...@gmail.com wrote: Because we build here an array format, we don't need to swap the bytes for big endian. If it isn't an array format, the bytes will be swapped in _mesa_format_convert.

[Mesa-dev] [PATCH 2/2] egl: improve attribute checking for eglCreateContext

2015-08-12 Thread Frank Binns
The EGL 1.4 spec states for eglCreateContext: attribute EGL_CONTEXT_CLIENT_VERSION is only valid when the current rendering API is EGL_OPENGL_ES_API Additionally, if the EGL_KHR_create_context EGL extension is supported (this is mandatory in EGL 1.5) then the

[Mesa-dev] [PATCH 1/2] egl: don't allow eglGetConfigs to set num_configs param to a negative value

2015-08-12 Thread Frank Binns
When a buffer is provided to eglGetConfigs it's supposed to set the value of the num_config parameter to the total number of configs that have been copied into this buffer. For some reason the EGL spec doesn't consider it to be an error to pass this function a buffer while specifying its size to

Re: [Mesa-dev] [PATCH V2] docs: Update with GLES3.2 entries and status

2015-08-12 Thread Thomas Helland
2015-08-12 15:59 GMT+02:00 Gustaw Smolarczyk wielkie...@gmail.com: Hello. I've just spotted a simple typo. 2015-08-12 15:07 GMT+02:00 Thomas Helland thomashellan...@gmail.com: V2: -Change to not started for most entries -Add status for multisample_2d_array -Change

Re: [Mesa-dev] [PATCH V2] docs: Update with GLES3.2 entries and status

2015-08-12 Thread Thomas Helland
2015-08-12 16:15 GMT+02:00 Ilia Mirkin imir...@alum.mit.edu: On Wed, Aug 12, 2015 at 9:07 AM, Thomas Helland thomashellan...@gmail.com wrote: V2: -Change to not started for most entries -Add status for multisample_2d_array -Change shader_multisample_interpolation to not_stared

Re: [Mesa-dev] [PATCH 2/2][RFC] docs: Add the 2015 ARB extensions

2015-08-12 Thread Ilia Mirkin
On Tue, Aug 11, 2015 at 1:48 PM, Thomas Helland thomashellan...@gmail.com wrote: Signed-off-by: Thomas Helland thomashellan...@gmail.com --- This adds a section for the extensions nvidia has chosen to call the GL ARB 2015 Extensions unveiled at SIGGRAPH. There are ARB extensions released

Re: [Mesa-dev] [PATCH v2] mesa/formats: add more MESA_FORMAT_LAYOUTs

2015-08-12 Thread Nanley Chery
My comment about making ASTC format detection simpler is a little subjective. I'm planning to remove it from the final patch if it's accepted. What this change allows in general is detecting compressed formats belonging to a certain category of compressed formats. Regards, Nanley On Tue, Aug 11,

Re: [Mesa-dev] [PATCH v2] mesa: add missing queries for ARB_direct_state_access

2015-08-12 Thread Daniel Scharrer
Hi, On 2015-08-12 18:05, Fredrik Höglund wrote: On Thursday 06 August 2015, Daniel Scharrer wrote: CC: 10.6 mesa-sta...@lists.freedesktop.org I think the commit message should say which queries are added. --- v2: added CC for 10.6 renamed _mesa_tex_target_to_index to

Re: [Mesa-dev] [PATCH 2/2][RFC] docs: Add the 2015 ARB extensions

2015-08-12 Thread Thomas Helland
2015-08-12 18:56 GMT+02:00 Kenneth Graunke kenn...@whitecape.org: On Wednesday, August 12, 2015 06:32:50 PM Thomas Helland wrote: 2015-08-12 17:48 GMT+02:00 Ilia Mirkin imir...@alum.mit.edu: On Tue, Aug 11, 2015 at 1:48 PM, Thomas Helland thomashellan...@gmail.com wrote: Signed-off-by:

[Mesa-dev] [PATCH] i965/vec4/nir: Emit single MOV to generate a scalar constant.

2015-08-12 Thread Matt Turner
If an immediate is written to multiple channels, we can load it in a single writemasked MOV. total instructions in shared programs: 6285144 - 6261991 (-0.37%) instructions in affected programs: 718991 - 695838 (-3.22%) helped:5762 --- The shader-db numbers are

Re: [Mesa-dev] [PATCH] i965/vec4/nir: Emit single MOV to generate a scalar constant.

2015-08-12 Thread Jason Ekstrand
On Wed, Aug 12, 2015 at 1:58 PM, Matt Turner matts...@gmail.com wrote: If an immediate is written to multiple channels, we can load it in a single writemasked MOV. total instructions in shared programs: 6285144 - 6261991 (-0.37%) instructions in affected programs: 718991 - 695838 (-3.22%)

[Mesa-dev] [PATCH] ttn: add buffer texture type

2015-08-12 Thread Rob Clark
From: Rob Clark robcl...@freedesktop.org Signed-off-by: Rob Clark robcl...@freedesktop.org --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index 4130697..93dfb80

Re: [Mesa-dev] [PATCH 2/2] nir: Add support for CSE on textures.

2015-08-12 Thread Eric Anholt
Jason Ekstrand ja...@jlekstrand.net writes: On Wed, Aug 12, 2015 at 11:55 AM, Eric Anholt e...@anholt.net wrote: NIR instruction count results on i965: total instructions in shared programs: 1261954 - 1261937 (-0.00%) instructions in affected programs: 455 - 438 (-3.74%) One in

Re: [Mesa-dev] [PATCH] glsl: make linker error message more informative

2015-08-12 Thread Ilia Mirkin
Please change those to be %u, all those are GLuint's. With that fixed, Reviewed-by: Ilia Mirkin imir...@alum.mit.edu On Wed, Aug 12, 2015 at 3:03 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: --- src/glsl/linker.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] ttn: add buffer texture type

2015-08-12 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu On Wed, Aug 12, 2015 at 5:29 PM, Rob Clark robdcl...@gmail.com wrote: From: Rob Clark robcl...@freedesktop.org Signed-off-by: Rob Clark robcl...@freedesktop.org --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 3 +++ 1 file changed, 3

[Mesa-dev] [PATCH] docs: Add ARB extensions from 2012 - 2015

2015-08-12 Thread Thomas Helland
... that are not mandated by the current openGL specifications Signed-off-by: Thomas Helland thomashellan...@gmail.com Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com Reviewed-by: Tapani Pälli tapani.pa...@intel.com --- Tapani, Edward: Does your review still stand? I decided to be

Re: [Mesa-dev] [PATCH 2/2][RFC] docs: Add the 2015 ARB extensions

2015-08-12 Thread Chris Forbes
I'd just add a 2015 block and a 2014 block. On Thu, Aug 13, 2015 at 9:36 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, Aug 12, 2015 at 5:23 PM, Thomas Helland thomashellan...@gmail.com wrote: 2015-08-12 18:56 GMT+02:00 Kenneth Graunke kenn...@whitecape.org: On Wednesday, August 12, 2015

Re: [Mesa-dev] [PATCH 2/2][RFC] docs: Add the 2015 ARB extensions

2015-08-12 Thread Ilia Mirkin
On Wed, Aug 12, 2015 at 5:23 PM, Thomas Helland thomashellan...@gmail.com wrote: 2015-08-12 18:56 GMT+02:00 Kenneth Graunke kenn...@whitecape.org: On Wednesday, August 12, 2015 06:32:50 PM Thomas Helland wrote: 2015-08-12 17:48 GMT+02:00 Ilia Mirkin imir...@alum.mit.edu: On Tue, Aug 11, 2015

Re: [Mesa-dev] [PATCH] docs: Add ARB extensions from 2012 - 2015

2015-08-12 Thread Ilia Mirkin
On Wed, Aug 12, 2015 at 6:59 PM, Thomas Helland thomashellan...@gmail.com wrote: ... that are not mandated by the current openGL specifications Signed-off-by: Thomas Helland thomashellan...@gmail.com Reviewed-by: Edward O'Callaghan eocallag...@alterapraxis.com Reviewed-by: Tapani Pälli

[Mesa-dev] [PATCH] mesa/texformat: Use format conversion function in _mesa_choose_tex_format

2015-08-12 Thread Nanley Chery
From: Nanley Chery nanley.g.ch...@intel.com This function's cases for non-generic compressed formats duplicate the GL to MESA translation in _mesa_glenum_to_compressed_format(). This patch replaces the switch cases with a call to the translation function. There are no behavioral changes except

Re: [Mesa-dev] [PATCH] i915: BINDING_TABLE_POINTER_* after CONSTANT_* for SKL BXT

2015-08-12 Thread Ben Widawsky
On Wed, Aug 12, 2015 at 03:09:44PM +0300, Joonas Lahtinen wrote: Add a comment about reinforcing command order so that 3DSTATE_BINDING_TABLE_POINTER_* commands are after 3DSTATE_CONSTANT_* commands for SKL BXT, otherwise the GPU might hang. Changing the BLORP code is not relevant (where

[Mesa-dev] [Bug 91254] (regresion) video using VA-API on Intel slow and freeze system with mesa 10.6 or 10.6.1

2015-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91254 --- Comment #11 from Tomasz C. toma...@o2.pl --- In 10.6.4 this bug is still present Can not you just go back patch that causes the problem? -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Lower 32x32 bit multiplication on BXT.

2015-08-12 Thread Jason Ekstrand
On Aug 12, 2015 4:41 AM, Francisco Jerez curroje...@riseup.net wrote: Francisco Jerez curroje...@riseup.net writes: Neil Roberts n...@linux.intel.com writes: Ok, that makes sense, thanks for the detailed explanation. I think you're right, given the extra restrictions avoiding the

Re: [Mesa-dev] [PATCH 1/4] mesa: expose dimension check for glTex*Storage functions

2015-08-12 Thread Tapani Pälli
On 08/10/2015 07:50 PM, Brian Paul wrote: On 08/10/2015 02:06 AM, Tapani Pälli wrote: This is done so that following patch can use it to verify dimenstions for multisample variants of glTex*Storage. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/main/texstorage.c | 22

[Mesa-dev] [PATCH] tgsi/nouveau: Add support for tesselation ctrl and tesselation eval

2015-08-12 Thread Marcos Paulo de Souza
From: Marcos Paulo de Souza marcos.souza@gmail.com Signed-off-by: Marcos Paulo de Souza marcos.souza.org Suggested-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/auxiliary/tgsi/tgsi_text.c | 6 +- src/gallium/drivers/nouveau/nouveau_compiler.c | 4 2 files changed, 9

Re: [Mesa-dev] [PATCH 2/2] nir: Add support for CSE on textures.

2015-08-12 Thread Jason Ekstrand
On Aug 12, 2015 4:21 PM, Eric Anholt e...@anholt.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Wed, Aug 12, 2015 at 11:55 AM, Eric Anholt e...@anholt.net wrote: NIR instruction count results on i965: total instructions in shared programs: 1261954 - 1261937 (-0.00%)

Re: [Mesa-dev] [PATCH 1/5] radeonsi: move VGT_GS_MODE to the VS state

2015-08-12 Thread Michel Dänzer
On 12.08.2015 08:02, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com The series is Reviewed-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [Mesa-dev] [PATCH] mesa/teximage: report the correct function which triggered the error

2015-08-12 Thread Tapani Pälli
Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 08/12/2015 03:09 AM, Nanley Chery wrote: From: Nanley Chery nanley.g.ch...@intel.com This function would always report that a dimension or size error occurred in glTexImage even when it was called from glCompressedTexImage. Replace the static

Re: [Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-12 Thread Tapani Pälli
Hi Ilia; Some comments below; On 08/12/2015 04:51 AM, Ilia Mirkin wrote: --- src/glsl/builtin_functions.cpp | 32 +- src/glsl/glcpp/glcpp-parse.y | 3 +++ src/glsl/glsl_parser_extras.cpp| 1 +

[Mesa-dev] [PATCH] glsl: make linker error message more informative

2015-08-12 Thread Timothy Arceri
--- src/glsl/linker.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index d7efea5..e18754a 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -2880,8 +2880,9 @@ check_image_resources(struct gl_context *ctx, struct

[Mesa-dev] [PATCH] mesa: update MaxShaderStorageBlockSize to 2^27

2015-08-12 Thread Tapani Pälli
Extension spec originally required 2^24 but 2^27 is the minimum value required by OpenGL 4.5 and OpenGL ES 3.1 specifications. Fixes: ES31-CTS.shader_storage_buffer_object.basic-max Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/main/context.c | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH 1/1] mesa/formats: don't byteswap when building array formats

2015-08-12 Thread Oded Gabbay
Because we build here an array format, we don't need to swap the bytes for big endian. If it isn't an array format, the bytes will be swapped in _mesa_format_convert. Signed-off-by: Oded Gabbay oded.gab...@gmail.com Cc: Jason Ekstrand jason.ekstr...@intel.com Cc: Iago Toral ito...@igalia.com Cc:

Re: [Mesa-dev] [PATCH] mesa: update MaxShaderStorageBlockSize to 2^27

2015-08-12 Thread Timothy Arceri
Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/dri: Use packed RGB formats

2015-08-12 Thread Michel Dänzer
On 11.08.2015 01:56, Marek Olšák wrote: Reviewed-by: Marek Olšák marek.ol...@amd.com Thanks Marek. Unfortunately, I remembered in the meantime that this patch alone won't help for r300g, because it doesn't support PIPE_FORMAT_x8R8G8B8_UNORM. It should help at least for r600g though, not sure

Re: [Mesa-dev] [PATCH] mesa/main: Add GL_IMAGE_FORMAT_COMPATIBILITY_TYPE to glGetTexParameterfv

2015-08-12 Thread Francisco Jerez
Marta Lofstedt marta.lofst...@linux.intel.com writes: From: Marta Lofstedt marta.lofst...@intel.com According to Open GL ES 3.1 specification, section 8.10.2. GL_IMAGE_FORMAT_COMPATIBILITY_TYPE should be supported by glGetTexParameterfv. Signed-off-by: Marta Lofstedt

[Mesa-dev] [PATCH] gallium: add support for GLES texture float extensions (v2)

2015-08-12 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74329 v2: add a CAP for half floats drivers should not expose the CAPs if they don't support the formats --- src/gallium/docs/source/screen.rst | 6 ++

[Mesa-dev] [PATCH 1/2] glsl: set image access qualifiers for AoA

2015-08-12 Thread Timothy Arceri
Cc: Francisco Jerez curroje...@riseup.net --- src/glsl/link_uniforms.cpp | 77 +- 1 file changed, 49 insertions(+), 28 deletions(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index 4757fd5..f8a6620 100644 ---

[Mesa-dev] [RFC 2/2] i965: add support for image AoA

2015-08-12 Thread Timothy Arceri
Cc: Francisco Jerez curroje...@riseup.net --- This patch works for direct indexing of images, but I'm having some trouble getting indirect to work. For example for: tests/spec/arb_arrays_of_arrays/execution/image_store/basic-imageStore -non-const-uniform-index.shader_test Which has and

[Mesa-dev] [PATCH] mesa/main: Add GL_IMAGE_FORMAT_COMPATIBILITY_TYPE to glGetTexParameterfv

2015-08-12 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com According to Open GL ES 3.1 specification, section 8.10.2. GL_IMAGE_FORMAT_COMPATIBILITY_TYPE should be supported by glGetTexParameterfv. Signed-off-by: Marta Lofstedt marta.lofst...@linux.intel.com --- src/mesa/main/texparam.c | 6 ++ 1 file

Re: [Mesa-dev] [PATCH] st/dri: Use packed RGB formats

2015-08-12 Thread Marek Olšák
On Wed, Aug 12, 2015 at 11:30 AM, Michel Dänzer mic...@daenzer.net wrote: On 11.08.2015 01:56, Marek Olšák wrote: Reviewed-by: Marek Olšák marek.ol...@amd.com Thanks Marek. Unfortunately, I remembered in the meantime that this patch alone won't help for r300g, because it doesn't support

Re: [Mesa-dev] [PATCH] i965/fs: Clamp image array indices to the array bounds on IVB.

2015-08-12 Thread Francisco Jerez
Timothy Arceri t_arc...@yahoo.com.au writes: On Mon, 2015-07-27 at 16:01 +0300, Francisco Jerez wrote: This fixes the spec@arb_shader_image_load_store@invalid index bounds piglit tests on IVB, which were causing a GPU hang and then a crash due to the invalid binding table index result of the

Re: [Mesa-dev] [PATCH] mesa/main: Add GL_IMAGE_FORMAT_COMPATIBILITY_TYPE to glGetTexParameterfv

2015-08-12 Thread Lofstedt, Marta
-Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Francisco Jerez Sent: Wednesday, August 12, 2015 12:45 PM To: Marta Lofstedt; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] mesa/main: Add

[Mesa-dev] [PATCH v2 2/5] glsl: add support for the imageSize builtin

2015-08-12 Thread Martin Peres
The code is heavily inspired from Francisco Jerez's code supporting the image_load_store extension. I moved out image_types[] out of builtin_builder::add_image_function to share it with the newly-added builtin_builder::add_image_size_functions. Backends willing to support this builtin should

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Lower 32x32 bit multiplication on BXT.

2015-08-12 Thread Francisco Jerez
Neil Roberts n...@linux.intel.com writes: Ok, that makes sense, thanks for the detailed explanation. I think you're right, given the extra restrictions avoiding the integer dword multiplication seems like the simplest solution. I can't say that I fully understand what the documentation is

Re: [Mesa-dev] [PATCH 2/2][RFC] docs: Add the 2015 ARB extensions

2015-08-12 Thread Thomas Helland
2015-08-12 17:48 GMT+02:00 Ilia Mirkin imir...@alum.mit.edu: On Tue, Aug 11, 2015 at 1:48 PM, Thomas Helland thomashellan...@gmail.com wrote: Signed-off-by: Thomas Helland thomashellan...@gmail.com --- This adds a section for the extensions nvidia has chosen to call the GL ARB 2015

Re: [Mesa-dev] [PATCH 2/2][RFC] docs: Add the 2015 ARB extensions

2015-08-12 Thread Kenneth Graunke
On Wednesday, August 12, 2015 06:32:50 PM Thomas Helland wrote: 2015-08-12 17:48 GMT+02:00 Ilia Mirkin imir...@alum.mit.edu: On Tue, Aug 11, 2015 at 1:48 PM, Thomas Helland thomashellan...@gmail.com wrote: Signed-off-by: Thomas Helland thomashellan...@gmail.com --- This adds a section

Re: [Mesa-dev] [PATCH v2] mesa: add missing queries for ARB_direct_state_access

2015-08-12 Thread Fredrik Höglund
On Thursday 06 August 2015, Daniel Scharrer wrote: CC: 10.6 mesa-sta...@lists.freedesktop.org I think the commit message should say which queries are added. --- v2: added CC for 10.6 renamed _mesa_tex_target_to_index to tex_target_to_index moved declaration of variable before

Re: [Mesa-dev] [PATCH v2] mesa: add missing queries for ARB_direct_state_access

2015-08-12 Thread Daniel Scharrer
On 2015-08-12 17:14, Brian Paul wrote: Another question below... On 08/12/2015 08:31 AM, Daniel Scharrer wrote: On 2015-08-06 15:46, Brian Paul wrote: On 08/06/2015 07:44 AM, Daniel Scharrer wrote: CC: 10.6 mesa-sta...@lists.freedesktop.org --- v2: added CC for 10.6 renamed

Re: [Mesa-dev] [PATCH 24/70] i965: Refactor batch flush into intel_front_flush()

2015-08-12 Thread Martin Peres
On 07/08/15 23:13, Chris Wilson wrote: Since we always flush the intel_batchbuffer before calling intel_front_flush(), simply more that call into intel_front_flush() more - move. I will pick up the review tomorrow but I did not want to forget about this typo. itself. Signed-off-by: Chris

Re: [Mesa-dev] [PATCH] i965/fs: Clamp image array indices to the array bounds on IVB.

2015-08-12 Thread Timothy Arceri
On Wed, 2015-08-12 at 13:47 +0300, Francisco Jerez wrote: Timothy Arceri t_arc...@yahoo.com.au writes: On Mon, 2015-07-27 at 16:01 +0300, Francisco Jerez wrote: This fixes the spec@arb_shader_image_load_store@invalid index bounds piglit tests on IVB, which were causing a GPU hang and

[Mesa-dev] [PATCH V2] docs: Update with GLES3.2 entries and status

2015-08-12 Thread Thomas Helland
V2: -Change to not started for most entries -Add status for multisample_2d_array -Change shader_multisample_interpolation to not_stared Signed-off-by: Thomas Helland thomashellan...@gmail.com Reviewed-by: Tapani Pälli tapani.pa...@intel.com --- docs/GL3.txt | 25 +

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Lower 32x32 bit multiplication on BXT.

2015-08-12 Thread Francisco Jerez
Francisco Jerez curroje...@riseup.net writes: Neil Roberts n...@linux.intel.com writes: Ok, that makes sense, thanks for the detailed explanation. I think you're right, given the extra restrictions avoiding the integer dword multiplication seems like the simplest solution. I can't say that

Re: [Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-12 Thread Ilia Mirkin
On Wed, Aug 12, 2015 at 2:34 AM, Tapani Pälli tapani.pa...@intel.com wrote: Hi Ilia; Some comments below; On 08/12/2015 04:51 AM, Ilia Mirkin wrote: --- src/glsl/builtin_functions.cpp | 32 +- src/glsl/glcpp/glcpp-parse.y | 3 +++

Re: [Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

2015-08-12 Thread Zoltán Gilián
On 8/11/15, Marek Olšák mar...@gmail.com wrote: Do compute sampler states need RADEON_CP_PACKET3_COMPUTE_MODE as well? Oops, I've forgotten to add it. My mistake. I'm not sure if needed (I have a working test which uses linear filtering), but the SET_SAMPLER packet too has a header with the

Re: [Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-12 Thread Tapani Pälli
On 08/12/2015 03:00 PM, Ilia Mirkin wrote: On Wed, Aug 12, 2015 at 2:34 AM, Tapani Pälli tapani.pa...@intel.com wrote: Hi Ilia; Some comments below; On 08/12/2015 04:51 AM, Ilia Mirkin wrote: --- src/glsl/builtin_functions.cpp | 32 +-

[Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

2015-08-12 Thread Zoltan Gilian
v2: Add compute mode flag to sampler state setup (Marek). Drop branches which avoid reference counting (Marek). Simplify unset branch condition (Marek). --- src/gallium/drivers/r600/evergreen_compute.c | 25 --- src/gallium/drivers/r600/evergreen_state.c | 46

[Mesa-dev] [PATCH mesa] nv30: Fix creation of scanout buffers

2015-08-12 Thread Hans de Goede
Scanout buffers on nv30 must always be non-swizzled and have special width alignment constraints. These constrains have been taken from the xf86-video-nouveau src/nv_accel_common.c: nouveau_allocate_surface() function. nouveau_allocate_surface() applies these width constraints only when a tiled

Re: [Mesa-dev] [PATCH V2] docs: Update with GLES3.2 entries and status

2015-08-12 Thread Gustaw Smolarczyk
Hello. I've just spotted a simple typo. 2015-08-12 15:07 GMT+02:00 Thomas Helland thomashellan...@gmail.com: V2: -Change to not started for most entries -Add status for multisample_2d_array -Change shader_multisample_interpolation to not_stared Signed-off-by: Thomas Helland

Re: [Mesa-dev] [PATCH 1/2] r600g: fix polygon offset scale

2015-08-12 Thread Alex Deucher
On Tue, Aug 11, 2015 at 7:02 PM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com The value was copied from r300g, which uses 1/12 subpixels, but this hw uses 1/16 subpixels. Should fix piglit: gl-1.4-polygon-offset (formerly a glean test) (untested, ported from

Re: [Mesa-dev] [PATCH V2] docs: Update with GLES3.2 entries and status

2015-08-12 Thread Ilia Mirkin
On Wed, Aug 12, 2015 at 9:07 AM, Thomas Helland thomashellan...@gmail.com wrote: V2: -Change to not started for most entries -Add status for multisample_2d_array -Change shader_multisample_interpolation to not_stared Signed-off-by: Thomas Helland thomashellan...@gmail.com

[Mesa-dev] [PATCH] drirc: Add Unigine Oil Rush quirk (allow_glsl_extension_directive_midshader).

2015-08-12 Thread Richard Yao
Appears to fix shader compilation. Tested by starting the client and observing that the screen was correct after the trailers ran when previously, it was blank. Play tested on amd64. This was suggested by Kuuchan on the Steam forums:

Re: [Mesa-dev] [PATCH] drirc: Add Unigine Oil Rush quirk (allow_glsl_extension_directive_midshader).

2015-08-12 Thread Matt Turner
On Wed, Aug 12, 2015 at 9:48 AM, Richard Yao r...@gentoo.org wrote: Appears to fix shader compilation. Tested by starting the client and observing that the screen was correct after the trailers ran when previously, it was blank. Play tested on amd64. This was suggested by Kuuchan on the Steam

Re: [Mesa-dev] ARB_copy_image support in Gallium

2015-08-12 Thread Ilia Mirkin
As I'm guessing that it's unlikely that the VMWare implementation will get upstreamed before the Mesa 11.0 branch point, how do people feel about including the below implementation *without* the extension enable? That way people will still be able to run bioshock infinite without resorting to

[Mesa-dev] [PATCH] i915: BINDING_TABLE_POINTER_* after CONSTANT_* for SKL BXT

2015-08-12 Thread Joonas Lahtinen
Add a comment about reinforcing command order so that 3DSTATE_BINDING_TABLE_POINTER_* commands are after 3DSTATE_CONSTANT_* commands for SKL BXT, otherwise the GPU might hang. Changing the BLORP code is not relevant (where the order is wrong), as it is not used for GEN8 or up. Cc: Mika Kuoppala

Re: [Mesa-dev] [PATCH 1/2] egl: don't allow eglGetConfigs to set num_configs param to a negative value

2015-08-12 Thread Matt Turner
On Wed, Aug 12, 2015 at 8:35 AM, Frank Binns frank.bi...@imgtec.com wrote: When a buffer is provided to eglGetConfigs it's supposed to set the value of the num_config parameter to the total number of configs that have been copied into this buffer. For some reason the EGL spec doesn't consider

Re: [Mesa-dev] [PATCH 2/2] egl: improve attribute checking for eglCreateContext

2015-08-12 Thread Matt Turner
On Wed, Aug 12, 2015 at 8:36 AM, Frank Binns frank.bi...@imgtec.com wrote: The EGL 1.4 spec states for eglCreateContext: attribute EGL_CONTEXT_CLIENT_VERSION is only valid when the current rendering API is EGL_OPENGL_ES_API Additionally, if the EGL_KHR_create_context EGL

[Mesa-dev] [PATCH 1/2] nir: Zero out texture instructions when creating them.

2015-08-12 Thread Eric Anholt
There are so many flags in textures, that the CSE pass would have a hard time referencing the correct set when figuring out if two texture ops are the same. By zeroing, we can avoid that fragility. --- src/glsl/nir/nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/2] nir: Add support for CSE on textures.

2015-08-12 Thread Eric Anholt
NIR instruction count results on i965: total instructions in shared programs: 1261954 - 1261937 (-0.00%) instructions in affected programs: 455 - 438 (-3.74%) One in yofrankie, two in tropics. Apparently i965 had also optimized all of these out anyway. Reviewed-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH] i915: BINDING_TABLE_POINTER_* after CONSTANT_* for SKL BXT

2015-08-12 Thread Matt Turner
Subject: [PATCH] i915: BINDING_TABLE_POINTER_* after CONSTANT_* for SKL BXT The driver you're modifying is i965. :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-12 Thread Ilia Mirkin
On Wed, Aug 12, 2015 at 1:58 PM, Matt Turner matts...@gmail.com wrote: On Tue, Aug 11, 2015 at 6:51 PM, Ilia Mirkin imir...@alum.mit.edu wrote: --- src/glsl/builtin_functions.cpp | 32 +- src/glsl/glcpp/glcpp-parse.y | 3 +++

Re: [Mesa-dev] [PATCH v2] mesa: add missing queries for ARB_direct_state_access

2015-08-12 Thread Brian Paul
On 08/12/2015 10:07 AM, Daniel Scharrer wrote: On 2015-08-12 17:14, Brian Paul wrote: Another question below... On 08/12/2015 08:31 AM, Daniel Scharrer wrote: On 2015-08-06 15:46, Brian Paul wrote: On 08/06/2015 07:44 AM, Daniel Scharrer wrote: CC: 10.6 mesa-sta...@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-12 Thread Matt Turner
On Tue, Aug 11, 2015 at 6:51 PM, Ilia Mirkin imir...@alum.mit.edu wrote: --- src/glsl/builtin_functions.cpp | 32 +- src/glsl/glcpp/glcpp-parse.y | 3 +++ src/glsl/glsl_parser_extras.cpp| 1 + src/glsl/glsl_parser_extras.h

Re: [Mesa-dev] [PATCH 2/2] nir: Add support for CSE on textures.

2015-08-12 Thread Jason Ekstrand
On Wed, Aug 12, 2015 at 11:55 AM, Eric Anholt e...@anholt.net wrote: NIR instruction count results on i965: total instructions in shared programs: 1261954 - 1261937 (-0.00%) instructions in affected programs: 455 - 438 (-3.74%) One in yofrankie, two in tropics. Apparently i965 had also

Re: [Mesa-dev] [PATCH 1/2] nir: Zero out texture instructions when creating them.

2015-08-12 Thread Matt Turner
On Wed, Aug 12, 2015 at 11:55 AM, Eric Anholt e...@anholt.net wrote: There are so many flags in textures, that the CSE pass would have a hard time referencing the correct set when figuring out if two texture ops are the same. By zeroing, we can avoid that fragility. --- Presumably you didn't